cookstyle 7.26.1 → 7.30.3
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/config/cookstyle.yml +36 -0
- data/config/upstream.yml +3 -0
- data/lib/cookstyle/version.rb +2 -2
- data/lib/rubocop/chef/cookbook_helpers.rb +2 -0
- data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_cookbook_name.rb +47 -0
- data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb +59 -0
- data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/metadata_malformed_version.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/metadata_missing_version.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/node_normal.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/powershell_file_exists.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/property_without_type.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/service_resource.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/tmp_path.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chef_rewind.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/cheffile.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_chef_nginx_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_chef_reporting_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_omnibus_updater_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +3 -2
- data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_sudo_actions.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/node_set.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/policyfile_community_source.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_without_unified_mode_true.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/use_automatic_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/berksfile.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb +2 -2
- data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_environment.rb +2 -2
- data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +2 -2
- data/lib/rubocop/cop/chef/effortless/node_roles.rb +2 -2
- data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/build_essential.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/chef_15_resources.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/class_eval_action_class.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/declare_action_class.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/definitions.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_chef_vault_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_chocolatey_cookbooks.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_kernel_module_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_locale_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_openssl_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_timezone_lwrp_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_windows_firewall_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/node_init_package.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +54 -14
- data/lib/rubocop/cop/chef/security/ssh_private_key.rb +49 -0
- data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +1 -1
- data/lib/rubocop/cop/chef/style/attribute_keys.rb +5 -5
- data/lib/rubocop/cop/chef/style/chef_whaaat.rb +1 -1
- data/lib/rubocop/cop/chef/style/comment_sentence_spacing.rb +1 -1
- data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +1 -1
- data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +1 -1
- data/lib/rubocop/cop/chef/style/comments_format.rb +1 -1
- data/lib/rubocop/cop/chef/style/file_mode.rb +1 -1
- data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +1 -1
- data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +1 -1
- data/lib/rubocop/cop/chef/style/negating_only_if.rb +1 -1
- data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +1 -1
- data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +1 -1
- data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +3 -3
- data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +1 -1
- data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +3 -3
- data/lib/rubocop/cop/inspec/deprecation/attribute_default.rb +1 -1
- data/lib/rubocop/cop/inspec/deprecation/attribute_helper.rb +1 -1
- metadata +7 -4
@@ -40,7 +40,7 @@ module RuboCop
|
|
40
40
|
|
41
41
|
def on_def(node)
|
42
42
|
empty_initialize?(node) do
|
43
|
-
add_offense(node,
|
43
|
+
add_offense(node, severity: :refactor) do |corrector|
|
44
44
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
45
45
|
end
|
46
46
|
end
|
@@ -63,15 +63,15 @@ module RuboCop
|
|
63
63
|
|
64
64
|
def on_send(node)
|
65
65
|
execute_apt_update?(node) do
|
66
|
-
add_offense(node,
|
66
|
+
add_offense(node, severity: :refactor)
|
67
67
|
end
|
68
68
|
|
69
69
|
notification_property?(node) do |val|
|
70
|
-
add_offense(val,
|
70
|
+
add_offense(val, severity: :refactor) if val.str_content&.start_with?('execute[apt-get update]')
|
71
71
|
end
|
72
72
|
|
73
73
|
execute_command?(node) do |val|
|
74
|
-
add_offense(node,
|
74
|
+
add_offense(node, severity: :refactor) if val.str_content == 'apt-get update'
|
75
75
|
end
|
76
76
|
end
|
77
77
|
end
|
@@ -49,7 +49,7 @@ module RuboCop
|
|
49
49
|
# with a nested string and a begin. Source allows us to avoid a lot of defensive programming here
|
50
50
|
return unless node&.arguments.first&.source&.match?(/^("|')sc.exe/)
|
51
51
|
|
52
|
-
add_offense(node,
|
52
|
+
add_offense(node, severity: :refactor)
|
53
53
|
end
|
54
54
|
|
55
55
|
# block execute resources
|
@@ -57,7 +57,7 @@ module RuboCop
|
|
57
57
|
match_property_in_resource?(:execute, 'command', node) do |code_property|
|
58
58
|
property_data = method_arg_ast_to_string(code_property)
|
59
59
|
return unless property_data && property_data.match?(/^sc.exe/i)
|
60
|
-
add_offense(node,
|
60
|
+
add_offense(node, severity: :refactor)
|
61
61
|
end
|
62
62
|
end
|
63
63
|
end
|
@@ -52,7 +52,7 @@ module RuboCop
|
|
52
52
|
# use a regex on source instead of .value in case there's string interpolation which adds a complex dstr type
|
53
53
|
# with a nested string and a begin. Source allows us to avoid a lot of defensive programming here
|
54
54
|
return unless node&.arguments.first&.source&.match?(/^("|')sleep/)
|
55
|
-
add_offense(node,
|
55
|
+
add_offense(node, severity: :refactor)
|
56
56
|
end
|
57
57
|
|
58
58
|
# block execute resources
|
@@ -60,13 +60,13 @@ module RuboCop
|
|
60
60
|
match_property_in_resource?(:execute, 'command', node) do |code_property|
|
61
61
|
property_data = method_arg_ast_to_string(code_property)
|
62
62
|
next unless property_data && property_data.match?(/^sleep/i)
|
63
|
-
add_offense(node,
|
63
|
+
add_offense(node, severity: :refactor)
|
64
64
|
end
|
65
65
|
|
66
66
|
match_property_in_resource?(:bash, 'code', node) do |code_property|
|
67
67
|
property_data = method_arg_ast_to_string(code_property)
|
68
68
|
next unless property_data && property_data.match?(/^sleep/i)
|
69
|
-
add_offense(node,
|
69
|
+
add_offense(node, severity: :refactor)
|
70
70
|
end
|
71
71
|
end
|
72
72
|
end
|
@@ -52,7 +52,7 @@ module RuboCop
|
|
52
52
|
# use a regex on source instead of .value in case there's string interpolation which adds a complex dstr type
|
53
53
|
# with a nested string and a begin. Source allows us to avoid a lot of defensive programming here
|
54
54
|
return unless node&.arguments.first&.source&.match?(/^("|')sysctl -p/)
|
55
|
-
add_offense(node,
|
55
|
+
add_offense(node, severity: :refactor)
|
56
56
|
end
|
57
57
|
|
58
58
|
# block execute resources
|
@@ -60,7 +60,7 @@ module RuboCop
|
|
60
60
|
match_property_in_resource?(:execute, 'command', node) do |code_property|
|
61
61
|
property_data = method_arg_ast_to_string(code_property)
|
62
62
|
return unless property_data && property_data.match?(%r{^(/sbin/)?sysctl -p}i)
|
63
|
-
add_offense(node,
|
63
|
+
add_offense(node, severity: :refactor)
|
64
64
|
end
|
65
65
|
end
|
66
66
|
end
|
@@ -54,19 +54,19 @@ module RuboCop
|
|
54
54
|
def on_send(node)
|
55
55
|
execute_resource?(node) do
|
56
56
|
return unless node.arguments.first.value.match?(/^tzutil/i)
|
57
|
-
add_offense(node,
|
57
|
+
add_offense(node, severity: :refactor)
|
58
58
|
end
|
59
59
|
end
|
60
60
|
|
61
61
|
def on_block(node)
|
62
62
|
match_property_in_resource?(:execute, 'command', node) do |code_property|
|
63
63
|
next unless calls_tzutil?(code_property)
|
64
|
-
add_offense(node,
|
64
|
+
add_offense(node, severity: :refactor)
|
65
65
|
end
|
66
66
|
|
67
67
|
match_property_in_resource?(:powershell_script, 'code', node) do |code_property|
|
68
68
|
next unless calls_tzutil?(code_property)
|
69
|
-
add_offense(node,
|
69
|
+
add_offense(node, severity: :refactor)
|
70
70
|
end
|
71
71
|
end
|
72
72
|
|
@@ -34,7 +34,7 @@ module RuboCop
|
|
34
34
|
def on_new_investigation
|
35
35
|
processed_source.comments.each do |comment|
|
36
36
|
next unless comment.text.match?(/#\s*~FC\d{3}.*/)
|
37
|
-
add_offense(comment,
|
37
|
+
add_offense(comment, severity: :refactor) do |corrector|
|
38
38
|
corrector.remove(comment)
|
39
39
|
end
|
40
40
|
end
|
@@ -37,7 +37,7 @@ module RuboCop
|
|
37
37
|
def on_defined?(node)
|
38
38
|
return unless node.arguments.first == s(:send, nil, :default_action)
|
39
39
|
node = node.parent if node.parent.respond_to?(:if?) && node.parent.if? # we want the whole if statement
|
40
|
-
add_offense(node,
|
40
|
+
add_offense(node, severity: :refactor) do |corrector|
|
41
41
|
corrector.replace(node, node.children[1].source)
|
42
42
|
end
|
43
43
|
end
|
@@ -61,7 +61,7 @@ module RuboCop
|
|
61
61
|
|
62
62
|
# only add offenses when we're in a custom resource or HWRP, but not a plain old library
|
63
63
|
if containing_dir == 'resources' || hwrp_classes?(processed_source.ast)
|
64
|
-
add_offense(node,
|
64
|
+
add_offense(node, severity: :refactor) do |corrector|
|
65
65
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
66
66
|
end
|
67
67
|
end
|
@@ -50,15 +50,15 @@ module RuboCop
|
|
50
50
|
|
51
51
|
def on_send(node)
|
52
52
|
# The need for this goes away once https://github.com/rubocop-hq/rubocop/pull/8365 is pulled into Cookstyle
|
53
|
-
if node.
|
54
|
-
add_offense(node,
|
53
|
+
if node.method?(:libarchive_file)
|
54
|
+
add_offense(node, severity: :refactor) do |corrector|
|
55
55
|
corrector.replace(node, node.source.gsub('libarchive_file', 'archive_file'))
|
56
56
|
end
|
57
57
|
end
|
58
58
|
|
59
59
|
notification_property?(node) do |val|
|
60
60
|
next unless val.str_content&.start_with?('libarchive_file')
|
61
|
-
add_offense(val,
|
61
|
+
add_offense(val, severity: :refactor) do |corrector|
|
62
62
|
corrector.replace(node, node.source.gsub('libarchive_file', 'archive_file'))
|
63
63
|
end
|
64
64
|
end
|
@@ -47,7 +47,7 @@ module RuboCop
|
|
47
47
|
RESTRICT_ON_SEND = [:mac_os_x_userdefaults].freeze
|
48
48
|
|
49
49
|
def on_send(node)
|
50
|
-
add_offense(node,
|
50
|
+
add_offense(node, severity: :refactor) do |corrector|
|
51
51
|
corrector.replace(node, node.source.gsub(/^mac_os_x_userdefaults/, 'macos_userdefaults'))
|
52
52
|
end
|
53
53
|
end
|
@@ -39,7 +39,7 @@ module RuboCop
|
|
39
39
|
|
40
40
|
def on_send(node)
|
41
41
|
minitest_depends?(node) do
|
42
|
-
add_offense(node,
|
42
|
+
add_offense(node, severity: :refactor) do |corrector|
|
43
43
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
44
44
|
end
|
45
45
|
end
|
@@ -71,13 +71,13 @@ module RuboCop
|
|
71
71
|
# if there's a ::File.exist?('/proc/1/comm') check first we want to match that as well
|
72
72
|
node = node.parent if node.parent&.and_type? && proc_1_comm_exists?(node.parent.conditions.first)
|
73
73
|
|
74
|
-
add_offense(node,
|
74
|
+
add_offense(node, severity: :refactor) do |corrector|
|
75
75
|
corrector.replace(node, "node['init_package'] == 'systemd'")
|
76
76
|
end
|
77
77
|
end
|
78
78
|
|
79
79
|
file_systemd_conditional?(node) do |conditional|
|
80
|
-
add_offense(node,
|
80
|
+
add_offense(node, severity: :refactor) do |corrector|
|
81
81
|
corrector.replace(conditional, "{ node['init_package'] == 'systemd' }")
|
82
82
|
end
|
83
83
|
end
|
@@ -45,7 +45,7 @@ module RuboCop
|
|
45
45
|
|
46
46
|
def on_send(node)
|
47
47
|
node_role_include?(node) do |val|
|
48
|
-
add_offense(node,
|
48
|
+
add_offense(node, severity: :refactor) do |corrector|
|
49
49
|
corrector.replace(node, "node.role?(#{val.source})")
|
50
50
|
end
|
51
51
|
end
|
@@ -43,7 +43,7 @@ module RuboCop
|
|
43
43
|
RESTRICT_ON_SEND = [:openssl_rsa_key].freeze
|
44
44
|
|
45
45
|
def on_send(node)
|
46
|
-
add_offense(node,
|
46
|
+
add_offense(node, severity: :refactor) do |corrector|
|
47
47
|
corrector.replace(node, node.source.gsub(/^openssl_rsa_key/, 'openssl_rsa_private_key'))
|
48
48
|
end
|
49
49
|
end
|
@@ -49,7 +49,7 @@ module RuboCop
|
|
49
49
|
RESTRICT_ON_SEND = [:openssl_x509].freeze
|
50
50
|
|
51
51
|
def on_send(node)
|
52
|
-
add_offense(node,
|
52
|
+
add_offense(node, severity: :refactor) do |corrector|
|
53
53
|
corrector.replace(node, node.source.gsub(/^openssl_x509/, 'openssl_x509_certificate'))
|
54
54
|
end
|
55
55
|
end
|
@@ -40,7 +40,7 @@ module RuboCop
|
|
40
40
|
RESTRICT_ON_SEND = [:osx_config_profile].freeze
|
41
41
|
|
42
42
|
def on_send(node)
|
43
|
-
add_offense(node,
|
43
|
+
add_offense(node, severity: :refactor) do |corrector|
|
44
44
|
corrector.replace(node, node.source.gsub(/^osx_config_profile/, 'osx_profile'))
|
45
45
|
end
|
46
46
|
end
|
@@ -40,7 +40,7 @@ module RuboCop
|
|
40
40
|
match_property_in_resource?(:powershell_script, 'code', node) do |code_property|
|
41
41
|
property_data = method_arg_ast_to_string(code_property)
|
42
42
|
return unless property_data && property_data.match?(/^expand-archive/i)
|
43
|
-
add_offense(node,
|
43
|
+
add_offense(node, severity: :refactor)
|
44
44
|
end
|
45
45
|
end
|
46
46
|
end
|
@@ -56,7 +56,7 @@ module RuboCop
|
|
56
56
|
def on_block(node)
|
57
57
|
match_property_in_resource?(%i(powershell_script batch), 'guard_interpreter', node) do |interpreter|
|
58
58
|
return unless interpreter.arguments.first.source == ':powershell_script'
|
59
|
-
add_offense(interpreter,
|
59
|
+
add_offense(interpreter, severity: :refactor) do |corrector|
|
60
60
|
corrector.remove(range_with_surrounding_space(range: interpreter.loc.expression, side: :left))
|
61
61
|
end
|
62
62
|
end
|
@@ -43,7 +43,7 @@ module RuboCop
|
|
43
43
|
match_property_in_resource?(:powershell_script, 'code', node) do |code_property|
|
44
44
|
property_data = method_arg_ast_to_string(code_property)
|
45
45
|
return unless property_data && property_data.match?(/^install-package\s/i)
|
46
|
-
add_offense(node,
|
46
|
+
add_offense(node, severity: :refactor)
|
47
47
|
end
|
48
48
|
end
|
49
49
|
end
|
@@ -46,7 +46,7 @@ module RuboCop
|
|
46
46
|
match_property_in_resource?(:powershell_script, 'code', node) do |code_property|
|
47
47
|
property_data = method_arg_ast_to_string(code_property)
|
48
48
|
return unless property_data && property_data.match?(/^(install|add)-windowsfeature\s/i)
|
49
|
-
add_offense(node,
|
49
|
+
add_offense(node, severity: :refactor)
|
50
50
|
end
|
51
51
|
end
|
52
52
|
end
|
@@ -44,7 +44,7 @@ module RuboCop
|
|
44
44
|
|
45
45
|
def on_send(node)
|
46
46
|
property_with_name_attribute?(node) do |name_attribute|
|
47
|
-
add_offense(node,
|
47
|
+
add_offense(node, severity: :refactor) do |corrector|
|
48
48
|
corrector.replace(name_attribute, 'name_property: true')
|
49
49
|
end
|
50
50
|
end
|
@@ -45,7 +45,7 @@ module RuboCop
|
|
45
45
|
def on_ivasgn(node)
|
46
46
|
provides_assignment?(node) do
|
47
47
|
return unless initialize_method(node.parent.parent).any?
|
48
|
-
add_offense(node,
|
48
|
+
add_offense(node, severity: :refactor) do |corrector|
|
49
49
|
# insert the new provides call above the initialize method, but not if one already exists (this is sadly common)
|
50
50
|
unless provides_method?(processed_source.ast)
|
51
51
|
initialize_node = initialize_method(processed_source.ast).first
|
@@ -39,13 +39,13 @@ module RuboCop
|
|
39
39
|
MSG = 'The name of a resource can be set with the "resource_name" helper instead of using the initialize method.'
|
40
40
|
|
41
41
|
def on_def(node)
|
42
|
-
return unless node.
|
42
|
+
return unless node.method?(:initialize)
|
43
43
|
return if node.body.nil? # nil body is an empty initialize method
|
44
44
|
|
45
45
|
node.body.each_node do |x|
|
46
46
|
next unless x.assignment? && !x.node_parts.empty? && x.node_parts.first == :@resource_name
|
47
47
|
|
48
|
-
add_offense(x,
|
48
|
+
add_offense(x, severity: :refactor) do |corrector|
|
49
49
|
# insert the new resource_name call above the initialize method
|
50
50
|
initialize_node = initialize_method(processed_source.ast).first
|
51
51
|
corrector.insert_before(initialize_node.source_range, "resource_name #{x.descendants.first.source}\n\n")
|
@@ -54,7 +54,7 @@ module RuboCop
|
|
54
54
|
def on_send(node)
|
55
55
|
return unless resource_actions?(processed_source.ast)
|
56
56
|
attribute?(node) do
|
57
|
-
add_offense(node.loc.selector,
|
57
|
+
add_offense(node.loc.selector, severity: :refactor) do |corrector|
|
58
58
|
corrector.replace(node.loc.selector, 'property')
|
59
59
|
end
|
60
60
|
end
|
@@ -81,7 +81,7 @@ module RuboCop
|
|
81
81
|
def on_block(node)
|
82
82
|
match_property_in_resource?(:chef_gem, 'compile_time', node) do |compile_time_property|
|
83
83
|
compile_time_method_defined?(compile_time_property.parent) do |val|
|
84
|
-
add_offense(compile_time_property.parent,
|
84
|
+
add_offense(compile_time_property.parent, severity: :refactor) do |corrector|
|
85
85
|
corrector.replace(compile_time_property.parent, "compile_time #{val.source}")
|
86
86
|
end
|
87
87
|
end
|
@@ -44,7 +44,7 @@ module RuboCop
|
|
44
44
|
|
45
45
|
def on_if(node)
|
46
46
|
if_respond_to?(node) do
|
47
|
-
add_offense(node,
|
47
|
+
add_offense(node, severity: :refactor) do |corrector|
|
48
48
|
# When the if statement is if modifier like `foo if respond_to?(:foo)` then
|
49
49
|
# node.if_branch is the actual method call we want to extract.
|
50
50
|
# If a series of metadata methods are wrapped in an if statement then the content we want
|
@@ -62,7 +62,7 @@ module RuboCop
|
|
62
62
|
# If a series of metadata methods are wrapped in an if statement then the content we want
|
63
63
|
# is a block under the if statement and node.parent.if_branch can get us that block
|
64
64
|
node = node.parent if node.parent.conditional? # we want the whole conditional statement
|
65
|
-
add_offense(node,
|
65
|
+
add_offense(node, severity: :refactor) do |corrector|
|
66
66
|
corrector.replace(node, node.if_branch.source)
|
67
67
|
end
|
68
68
|
end
|
@@ -38,7 +38,7 @@ module RuboCop
|
|
38
38
|
|
39
39
|
def on_if(node)
|
40
40
|
if_respond_to_provides?(node) do
|
41
|
-
add_offense(node,
|
41
|
+
add_offense(node, severity: :refactor) do |corrector|
|
42
42
|
corrector.replace(node, node.children[1].source)
|
43
43
|
end
|
44
44
|
end
|
@@ -36,7 +36,7 @@ module RuboCop
|
|
36
36
|
|
37
37
|
def on_if(node)
|
38
38
|
if_respond_to_resource_name?(node) do
|
39
|
-
add_offense(node,
|
39
|
+
add_offense(node, severity: :refactor) do |corrector|
|
40
40
|
corrector.replace(node, node.children[1].source)
|
41
41
|
end
|
42
42
|
end
|
@@ -48,7 +48,7 @@ module RuboCop
|
|
48
48
|
|
49
49
|
def on_send(node)
|
50
50
|
mixlib_shellout_run_cmd?(node) do |cmd|
|
51
|
-
add_offense(node,
|
51
|
+
add_offense(node, severity: :refactor) do |corrector|
|
52
52
|
corrector.replace(node, "shell_out(#{cmd.source})")
|
53
53
|
end
|
54
54
|
end
|
@@ -42,13 +42,13 @@ module RuboCop
|
|
42
42
|
match_property_in_resource?(:powershell_script, 'code', node) do |code_property|
|
43
43
|
property_data = method_arg_ast_to_string(code_property)
|
44
44
|
next unless property_data && property_data.match?(/^choco /i)
|
45
|
-
add_offense(node,
|
45
|
+
add_offense(node, severity: :refactor)
|
46
46
|
end
|
47
47
|
|
48
48
|
match_property_in_resource?(:execute, 'command', node) do |code_property|
|
49
49
|
property_data = method_arg_ast_to_string(code_property)
|
50
50
|
next unless property_data && property_data.match?(/^choco /i)
|
51
|
-
add_offense(node,
|
51
|
+
add_offense(node, severity: :refactor)
|
52
52
|
end
|
53
53
|
end
|
54
54
|
end
|
@@ -49,7 +49,7 @@ module RuboCop
|
|
49
49
|
def on_block(node)
|
50
50
|
match_property_in_resource?(:apt_repository, 'uri', node) do |uri|
|
51
51
|
if %r{http(s)*://ppa.launchpad.net/(.*)/ubuntu$}.match?(uri.arguments&.first&.str_content)
|
52
|
-
add_offense(uri,
|
52
|
+
add_offense(uri, severity: :refactor) do |corrector|
|
53
53
|
next unless (replacement_val = %r{http(s)*://ppa.launchpad.net/(.*)/ubuntu}.match(node.source)[2])
|
54
54
|
corrector.replace(uri, "uri 'ppa:#{replacement_val}'")
|
55
55
|
end
|
@@ -44,7 +44,7 @@ module RuboCop
|
|
44
44
|
RESTRICT_ON_SEND = [:sysctl_param].freeze
|
45
45
|
|
46
46
|
def on_send(node)
|
47
|
-
add_offense(node,
|
47
|
+
add_offense(node, severity: :refactor) do |corrector|
|
48
48
|
corrector.replace(node, node.source.gsub(/^sysctl_param/, 'sysctl'))
|
49
49
|
end
|
50
50
|
end
|
@@ -39,7 +39,7 @@ module RuboCop
|
|
39
39
|
|
40
40
|
def on_send(node)
|
41
41
|
require_mixlibshellout?(node) do
|
42
|
-
add_offense(node,
|
42
|
+
add_offense(node, severity: :refactor) do |corrector|
|
43
43
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
44
44
|
end
|
45
45
|
end
|
@@ -81,7 +81,7 @@ module RuboCop
|
|
81
81
|
# if they were checking for node['cloud'] and the provider replace it all
|
82
82
|
node = node.parent if node.parent.and_type? && node_cloud?(node.left_sibling)
|
83
83
|
|
84
|
-
add_offense(node,
|
84
|
+
add_offense(node, severity: :refactor) do |corrector|
|
85
85
|
corrector.replace(node, "#{cloud_name}?")
|
86
86
|
end
|
87
87
|
end
|
@@ -48,7 +48,7 @@ module RuboCop
|
|
48
48
|
def on_send(node)
|
49
49
|
env?(node) do |env_value|
|
50
50
|
# we don't handle .nil? checks yet so just skip them
|
51
|
-
next if node.parent.send_type? && node.parent.
|
51
|
+
next if node.parent.send_type? && node.parent.method?(:nil?)
|
52
52
|
|
53
53
|
case env_value
|
54
54
|
when 'CI'
|
@@ -48,7 +48,7 @@ module RuboCop
|
|
48
48
|
|
49
49
|
def on_send(node)
|
50
50
|
node_init_package?(node) do |_cloud_name|
|
51
|
-
add_offense(node,
|
51
|
+
add_offense(node, severity: :refactor) do |corrector|
|
52
52
|
corrector.replace(node, 'systemd?')
|
53
53
|
end
|
54
54
|
end
|
@@ -89,7 +89,7 @@ module RuboCop
|
|
89
89
|
return if node.body.nil? # don't blow up on empty whens
|
90
90
|
|
91
91
|
package_array_install(node.body) do |install_block, pkgs|
|
92
|
-
add_offense(install_block,
|
92
|
+
add_offense(install_block, severity: :refactor) do |corrector|
|
93
93
|
corrector.replace(install_block, "package #{pkgs.source}")
|
94
94
|
end
|
95
95
|
end
|
@@ -99,7 +99,7 @@ module RuboCop
|
|
99
99
|
platform_helper?(node) do |plats, blk, _pkgs|
|
100
100
|
return unless multipackage_platforms?(plats)
|
101
101
|
|
102
|
-
add_offense(blk,
|
102
|
+
add_offense(blk, severity: :refactor) do |corrector|
|
103
103
|
package_array_install(blk) do |install_block, pkgs|
|
104
104
|
corrector.replace(install_block, "package #{pkgs.source}")
|
105
105
|
end
|
@@ -46,7 +46,7 @@ module RuboCop
|
|
46
46
|
def on_send(node)
|
47
47
|
require_with_expand_path?(node) do |file, path|
|
48
48
|
return unless path.source == '__FILE__'
|
49
|
-
add_offense(node,
|
49
|
+
add_offense(node, severity: :refactor) do |corrector|
|
50
50
|
corrected_value = file.value
|
51
51
|
corrected_value.slice!(%r{^../}) # take the first ../ off the path
|
52
52
|
corrector.replace(node, "require_relative '#{corrected_value}'")
|
@@ -46,7 +46,7 @@ module RuboCop
|
|
46
46
|
|
47
47
|
def on_def(node)
|
48
48
|
whyrun_true?(node) do
|
49
|
-
add_offense(node,
|
49
|
+
add_offense(node, severity: :refactor) do |corrector|
|
50
50
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
51
51
|
end
|
52
52
|
end
|
@@ -40,7 +40,7 @@ module RuboCop
|
|
40
40
|
|
41
41
|
def on_send(node)
|
42
42
|
windows_recipe_usage?(node) do
|
43
|
-
add_offense(node,
|
43
|
+
add_offense(node, severity: :refactor) do |corrector|
|
44
44
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
45
45
|
end
|
46
46
|
end
|
@@ -51,10 +51,10 @@ module RuboCop
|
|
51
51
|
|
52
52
|
# block registry_key resources
|
53
53
|
def on_block(node)
|
54
|
-
return unless node.
|
54
|
+
return unless node.method?(:registry_key)
|
55
55
|
return unless correct_key?(node)
|
56
56
|
return unless uac_supported_values?(node)
|
57
|
-
add_offense(node,
|
57
|
+
add_offense(node, severity: :refactor)
|
58
58
|
end
|
59
59
|
|
60
60
|
# make sure the values passed are all the ones in the uac resource
|
@@ -43,13 +43,13 @@ module RuboCop
|
|
43
43
|
|
44
44
|
def on_send(node)
|
45
45
|
depends_zipfile?(node) do
|
46
|
-
add_offense(node,
|
46
|
+
add_offense(node, severity: :refactor)
|
47
47
|
end
|
48
48
|
end
|
49
49
|
|
50
50
|
def on_block(node)
|
51
51
|
match_resource_type?(:zipfile, node) do
|
52
|
-
add_offense(node,
|
52
|
+
add_offense(node, severity: :refactor)
|
53
53
|
end
|
54
54
|
end
|
55
55
|
end
|
@@ -49,7 +49,7 @@ module RuboCop
|
|
49
49
|
RESTRICT_ON_SEND = [:zypper_repo].freeze
|
50
50
|
|
51
51
|
def on_send(node)
|
52
|
-
add_offense(node,
|
52
|
+
add_offense(node, severity: :refactor) do |corrector|
|
53
53
|
corrector.replace(node, node.source.gsub(/^zypper_repo/, 'zypper_repository'))
|
54
54
|
end
|
55
55
|
end
|
@@ -52,7 +52,7 @@ module RuboCop
|
|
52
52
|
def on_block(node)
|
53
53
|
match_property_in_resource?(:apt_repository, 'distribution', node) do |dist|
|
54
54
|
default_dist?(dist) do
|
55
|
-
add_offense(dist,
|
55
|
+
add_offense(dist, severity: :refactor) do |corrector|
|
56
56
|
corrector.remove(range_with_surrounding_space(range: dist.loc.expression, side: :left))
|
57
57
|
end
|
58
58
|
end
|