cookstyle 7.26.1 → 7.30.3

Sign up to get free protection for your applications and to get access to all the features.
Files changed (255) hide show
  1. checksums.yaml +4 -4
  2. data/config/cookstyle.yml +36 -0
  3. data/config/upstream.yml +3 -0
  4. data/lib/cookstyle/version.rb +2 -2
  5. data/lib/rubocop/chef/cookbook_helpers.rb +2 -0
  6. data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +1 -1
  7. data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +1 -1
  8. data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +1 -1
  9. data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +1 -1
  10. data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +1 -1
  11. data/lib/rubocop/cop/chef/correctness/invalid_cookbook_name.rb +47 -0
  12. data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +1 -1
  13. data/lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb +59 -0
  14. data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +1 -1
  15. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +1 -1
  16. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +1 -1
  17. data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +1 -1
  18. data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +2 -2
  19. data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +1 -1
  20. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +2 -2
  21. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -2
  22. data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +1 -1
  23. data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +1 -1
  24. data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +1 -1
  25. data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +1 -1
  26. data/lib/rubocop/cop/chef/correctness/metadata_malformed_version.rb +1 -1
  27. data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
  28. data/lib/rubocop/cop/chef/correctness/metadata_missing_version.rb +1 -1
  29. data/lib/rubocop/cop/chef/correctness/node_normal.rb +1 -1
  30. data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb +1 -1
  31. data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
  32. data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +1 -1
  33. data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +1 -1
  34. data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
  35. data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +1 -1
  36. data/lib/rubocop/cop/chef/correctness/powershell_file_exists.rb +1 -1
  37. data/lib/rubocop/cop/chef/correctness/property_without_type.rb +1 -1
  38. data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +1 -1
  39. data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +1 -1
  40. data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +1 -1
  41. data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +1 -1
  42. data/lib/rubocop/cop/chef/correctness/service_resource.rb +1 -1
  43. data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +1 -1
  44. data/lib/rubocop/cop/chef/correctness/tmp_path.rb +1 -1
  45. data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +1 -1
  46. data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +1 -1
  47. data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +1 -1
  48. data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +2 -2
  49. data/lib/rubocop/cop/chef/deprecation/chef_rewind.rb +4 -4
  50. data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +3 -3
  51. data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb +1 -1
  52. data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +1 -1
  53. data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +1 -1
  54. data/lib/rubocop/cop/chef/deprecation/cheffile.rb +1 -1
  55. data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
  56. data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +1 -1
  57. data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +1 -1
  58. data/lib/rubocop/cop/chef/deprecation/depends_chef_nginx_cookbook.rb +1 -1
  59. data/lib/rubocop/cop/chef/deprecation/depends_chef_reporting_cookbook.rb +1 -1
  60. data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
  61. data/lib/rubocop/cop/chef/deprecation/depends_omnibus_updater_cookbook.rb +1 -1
  62. data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +1 -1
  63. data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +3 -2
  64. data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb +1 -1
  65. data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +3 -3
  66. data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +1 -1
  67. data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +1 -1
  68. data/lib/rubocop/cop/chef/deprecation/deprecated_sudo_actions.rb +1 -1
  69. data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
  70. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb +1 -1
  71. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +1 -1
  72. data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
  73. data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
  74. data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +1 -1
  75. data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
  76. data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +1 -1
  77. data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +1 -1
  78. data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +1 -1
  79. data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +1 -1
  80. data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb +1 -1
  81. data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +1 -1
  82. data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +1 -1
  83. data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +1 -1
  84. data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +1 -1
  85. data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +1 -1
  86. data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +1 -1
  87. data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +1 -1
  88. data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +1 -1
  89. data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +1 -1
  90. data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +1 -1
  91. data/lib/rubocop/cop/chef/deprecation/node_set.rb +1 -1
  92. data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb +1 -1
  93. data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb +2 -2
  94. data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +1 -1
  95. data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +1 -1
  96. data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +2 -2
  97. data/lib/rubocop/cop/chef/deprecation/policyfile_community_source.rb +1 -1
  98. data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +1 -1
  99. data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +1 -1
  100. data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +2 -2
  101. data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +1 -1
  102. data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +1 -1
  103. data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +1 -1
  104. data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +1 -1
  105. data/lib/rubocop/cop/chef/deprecation/resource_without_unified_mode_true.rb +1 -1
  106. data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +1 -1
  107. data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +1 -1
  108. data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +3 -3
  109. data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +1 -1
  110. data/lib/rubocop/cop/chef/deprecation/use_automatic_resource_name.rb +1 -1
  111. data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
  112. data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +1 -1
  113. data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +2 -2
  114. data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +1 -1
  115. data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +1 -1
  116. data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +1 -1
  117. data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +1 -1
  118. data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +1 -1
  119. data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +1 -1
  120. data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
  121. data/lib/rubocop/cop/chef/effortless/berksfile.rb +1 -1
  122. data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb +2 -2
  123. data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
  124. data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb +1 -1
  125. data/lib/rubocop/cop/chef/effortless/node_environment.rb +2 -2
  126. data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +2 -2
  127. data/lib/rubocop/cop/chef/effortless/node_roles.rb +2 -2
  128. data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
  129. data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
  130. data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +1 -1
  131. data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +2 -2
  132. data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +1 -1
  133. data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +2 -2
  134. data/lib/rubocop/cop/chef/modernize/build_essential.rb +1 -1
  135. data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +1 -1
  136. data/lib/rubocop/cop/chef/modernize/chef_15_resources.rb +1 -1
  137. data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +2 -2
  138. data/lib/rubocop/cop/chef/modernize/class_eval_action_class.rb +1 -1
  139. data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +1 -1
  140. data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +1 -1
  141. data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +1 -1
  142. data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +1 -1
  143. data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +1 -1
  144. data/lib/rubocop/cop/chef/modernize/declare_action_class.rb +1 -1
  145. data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +1 -1
  146. data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
  147. data/lib/rubocop/cop/chef/modernize/definitions.rb +1 -1
  148. data/lib/rubocop/cop/chef/modernize/depends_chef_vault_cookbook.rb +1 -1
  149. data/lib/rubocop/cop/chef/modernize/depends_chocolatey_cookbooks.rb +1 -1
  150. data/lib/rubocop/cop/chef/modernize/depends_kernel_module_cookbook.rb +1 -1
  151. data/lib/rubocop/cop/chef/modernize/depends_locale_cookbook.rb +1 -1
  152. data/lib/rubocop/cop/chef/modernize/depends_openssl_cookbook.rb +1 -1
  153. data/lib/rubocop/cop/chef/modernize/depends_timezone_lwrp_cookbook.rb +1 -1
  154. data/lib/rubocop/cop/chef/modernize/depends_windows_firewall_cookbook.rb +1 -1
  155. data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +1 -1
  156. data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +1 -1
  157. data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
  158. data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +3 -3
  159. data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +2 -2
  160. data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +3 -3
  161. data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +2 -2
  162. data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +3 -3
  163. data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
  164. data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +1 -1
  165. data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +1 -1
  166. data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +3 -3
  167. data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +1 -1
  168. data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
  169. data/lib/rubocop/cop/chef/modernize/node_init_package.rb +2 -2
  170. data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +1 -1
  171. data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +1 -1
  172. data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +1 -1
  173. data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +1 -1
  174. data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +1 -1
  175. data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +1 -1
  176. data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +1 -1
  177. data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +1 -1
  178. data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +1 -1
  179. data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +1 -1
  180. data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +1 -1
  181. data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +2 -2
  182. data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +1 -1
  183. data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +1 -1
  184. data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +1 -1
  185. data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +2 -2
  186. data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +1 -1
  187. data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +1 -1
  188. data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +1 -1
  189. data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +1 -1
  190. data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +1 -1
  191. data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +2 -2
  192. data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +1 -1
  193. data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +1 -1
  194. data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
  195. data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb +1 -1
  196. data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb +1 -1
  197. data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb +1 -1
  198. data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +2 -2
  199. data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +1 -1
  200. data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
  201. data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +1 -1
  202. data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +2 -2
  203. data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +1 -1
  204. data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +2 -2
  205. data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +1 -1
  206. data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +1 -1
  207. data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +1 -1
  208. data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
  209. data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
  210. data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +1 -1
  211. data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +1 -1
  212. data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
  213. data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
  214. data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +1 -1
  215. data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +1 -1
  216. data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +1 -1
  217. data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +1 -1
  218. data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +1 -1
  219. data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
  220. data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
  221. data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
  222. data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
  223. data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +1 -1
  224. data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +1 -1
  225. data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
  226. data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +1 -1
  227. data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +1 -1
  228. data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +54 -14
  229. data/lib/rubocop/cop/chef/security/ssh_private_key.rb +49 -0
  230. data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +1 -1
  231. data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +1 -1
  232. data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +1 -1
  233. data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
  234. data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
  235. data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +1 -1
  236. data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +1 -1
  237. data/lib/rubocop/cop/chef/style/attribute_keys.rb +5 -5
  238. data/lib/rubocop/cop/chef/style/chef_whaaat.rb +1 -1
  239. data/lib/rubocop/cop/chef/style/comment_sentence_spacing.rb +1 -1
  240. data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +1 -1
  241. data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +1 -1
  242. data/lib/rubocop/cop/chef/style/comments_format.rb +1 -1
  243. data/lib/rubocop/cop/chef/style/file_mode.rb +1 -1
  244. data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +1 -1
  245. data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +1 -1
  246. data/lib/rubocop/cop/chef/style/negating_only_if.rb +1 -1
  247. data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +1 -1
  248. data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +1 -1
  249. data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +1 -1
  250. data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +3 -3
  251. data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +1 -1
  252. data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +3 -3
  253. data/lib/rubocop/cop/inspec/deprecation/attribute_default.rb +1 -1
  254. data/lib/rubocop/cop/inspec/deprecation/attribute_helper.rb +1 -1
  255. metadata +7 -4
@@ -41,13 +41,13 @@ module RuboCop
41
41
 
42
42
  def on_send(node)
43
43
  require_rest?(node) do
44
- add_offense(node, message: MSG, severity: :warning)
44
+ add_offense(node, severity: :warning)
45
45
  end
46
46
  end
47
47
 
48
48
  def on_const(node)
49
49
  rest_const?(node) do
50
- add_offense(node, message: MSG, severity: :warning)
50
+ add_offense(node, severity: :warning)
51
51
  end
52
52
  end
53
53
  end
@@ -64,20 +64,20 @@ module RuboCop
64
64
 
65
65
  def on_send(node)
66
66
  rewind_gem_install?(node) do
67
- add_offense(node, message: MSG, severity: :warning) do |corrector|
67
+ add_offense(node, severity: :warning) do |corrector|
68
68
  node = node.parent if node.parent&.block_type? # make sure we get the whole block not just the method in the block
69
69
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
70
70
  end
71
71
  end
72
72
 
73
73
  require_rewind?(node) do
74
- add_offense(node, message: MSG, severity: :warning) do |corrector|
74
+ add_offense(node, severity: :warning) do |corrector|
75
75
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
76
76
  end
77
77
  end
78
78
 
79
79
  rewind_resources?(node) do |string|
80
- add_offense(node, message: MSG, severity: :warning) do |corrector|
80
+ add_offense(node, severity: :warning) do |corrector|
81
81
  corrector.replace(node, node.source.gsub(string.to_s, MAPPING[string]))
82
82
  end
83
83
  end
@@ -86,7 +86,7 @@ module RuboCop
86
86
  def on_block(node)
87
87
  match_property_in_resource?(:chef_gem, 'package_name', node) do |pkg_name|
88
88
  next unless pkg_name.arguments&.first&.str_content == 'chef-rewind'
89
- add_offense(node, message: MSG, severity: :warning) do |corrector|
89
+ add_offense(node, severity: :warning) do |corrector|
90
90
  corrector.remove(node) if pkg_name.arguments&.first&.str_content == 'chef-rewind'
91
91
  end
92
92
  end
@@ -59,19 +59,19 @@ module RuboCop
59
59
 
60
60
  def on_send(node)
61
61
  include_shellout?(node) do
62
- add_offense(node, message: MSG, severity: :warning) do |corrector|
62
+ add_offense(node, severity: :warning) do |corrector|
63
63
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
64
64
  end
65
65
  end
66
66
 
67
67
  require_shellout?(node) do
68
- add_offense(node, message: MSG, severity: :warning) do |corrector|
68
+ add_offense(node, severity: :warning) do |corrector|
69
69
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
70
70
  end
71
71
  end
72
72
 
73
73
  shellout_new?(node) do
74
- add_offense(node, message: MSG, severity: :warning) do |corrector|
74
+ add_offense(node, severity: :warning) do |corrector|
75
75
  corrector.replace(node, node.source.gsub('Chef::ShellOut', 'Mixlib::ShellOut'))
76
76
  end
77
77
  end
@@ -46,7 +46,7 @@ module RuboCop
46
46
  RESTRICT_ON_SEND = [:vagrant_key?, :vagrant_domain?, :vagrant_user?, :require_chef_gem, :best_ip_for, :nexus?, :ios_xr?, :ruby_20?, :ruby_19?, :includes_recipe?, :wrlinux?, :dev_null, :nexentacore_platform?, :opensolaris_platform?, :nexentacore?, :opensolaris?].freeze
47
47
 
48
48
  def on_send(node)
49
- add_offense(node, message: MSG, severity: :refactor)
49
+ add_offense(node, severity: :refactor)
50
50
  end
51
51
  end
52
52
  end
@@ -43,7 +43,7 @@ module RuboCop
43
43
 
44
44
  def on_send(node)
45
45
  chef_platform_windows?(node) do
46
- add_offense(node, message: MSG, severity: :warning) do |corrector|
46
+ add_offense(node, severity: :warning) do |corrector|
47
47
  corrector.replace(node, "platform?('windows')")
48
48
  end
49
49
  end
@@ -45,7 +45,7 @@ module RuboCop
45
45
  # We want to catch calls like ChefCLI::CLI.whatever or places where classes are defined in the ChefDK module
46
46
  return unless node.const_name == 'ChefDK' && (node.parent&.module_type? || node.parent&.const_type?)
47
47
 
48
- add_offense(node, message: MSG, severity: :warning) do |corrector|
48
+ add_offense(node, severity: :warning) do |corrector|
49
49
  corrector.replace(node, node.source.gsub('ChefDK', 'ChefCLI'))
50
50
  end
51
51
  end
@@ -30,7 +30,7 @@ module RuboCop
30
30
  # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
31
31
  range = source_range(processed_source.buffer, 1, 0)
32
32
 
33
- add_offense(range, message: MSG, severity: :warning)
33
+ add_offense(range, severity: :warning)
34
34
  end
35
35
  end
36
36
  end
@@ -37,7 +37,7 @@ module RuboCop
37
37
 
38
38
  def on_block(node)
39
39
  coverage_reporter?(node) do
40
- add_offense(node, message: MSG, severity: :warning) do |corrector|
40
+ add_offense(node, severity: :warning) do |corrector|
41
41
  corrector.remove(node)
42
42
  end
43
43
  end
@@ -49,7 +49,7 @@ module RuboCop
49
49
 
50
50
  def on_const(node)
51
51
  chefspec_runner?(node) do
52
- add_offense(node, message: MSG, severity: :warning) do |corrector|
52
+ add_offense(node, severity: :warning) do |corrector|
53
53
  corrector.replace(node, 'ChefSpec::ServerRunner')
54
54
  end
55
55
  end
@@ -43,7 +43,7 @@ module RuboCop
43
43
  match_property_in_resource?(:chocolatey_package, 'action', node) do |choco_action|
44
44
  choco_action.arguments.each do |action|
45
45
  next unless action.source == ':uninstall'
46
- add_offense(action, message: MSG, severity: :warning) do |corrector|
46
+ add_offense(action, severity: :warning) do |corrector|
47
47
  corrector.replace(action, ':remove')
48
48
  end
49
49
  end
@@ -42,7 +42,7 @@ module RuboCop
42
42
 
43
43
  def on_send(node)
44
44
  depends_compat_resource?(node) do
45
- add_offense(node, message: MSG, severity: :warning) do |corrector|
45
+ add_offense(node, severity: :warning) do |corrector|
46
46
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
47
47
  end
48
48
  end
@@ -39,7 +39,7 @@ module RuboCop
39
39
 
40
40
  def on_send(node)
41
41
  legacy_depends?(node) do
42
- add_offense(node, message: MSG, severity: :warning) do |corrector|
42
+ add_offense(node, severity: :warning) do |corrector|
43
43
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
44
44
  end
45
45
  end
@@ -42,7 +42,7 @@ module RuboCop
42
42
 
43
43
  def on_send(node)
44
44
  depends_compat_resource?(node) do
45
- add_offense(node, message: MSG, severity: :warning) do |corrector|
45
+ add_offense(node, severity: :warning) do |corrector|
46
46
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
47
47
  end
48
48
  end
@@ -42,7 +42,7 @@ module RuboCop
42
42
 
43
43
  def on_send(node)
44
44
  legacy_depends?(node) do
45
- add_offense(node, message: MSG, severity: :warning) do |corrector|
45
+ add_offense(node, severity: :warning) do |corrector|
46
46
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
47
47
  end
48
48
  end
@@ -40,7 +40,7 @@ module RuboCop
40
40
 
41
41
  def on_send(node)
42
42
  depends_partial_search?(node) do
43
- add_offense(node, message: MSG, severity: :warning)
43
+ add_offense(node, severity: :warning)
44
44
  end
45
45
  end
46
46
  end
@@ -1,6 +1,6 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
- # Copyright:: 2019, Chef Software, Inc.
3
+ # Copyright:: 2019-2022, Chef Software, Inc.
4
4
  # Author:: Tim Smith (<tsmith@chef.io>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
@@ -26,6 +26,7 @@ module RuboCop
26
26
  # #### incorrect
27
27
  # depends 'poise'
28
28
  # depends 'poise-service'
29
+ # depends 'poise-hoist'
29
30
  #
30
31
  class CookbookDependsOnPoise < Base
31
32
  MSG = 'Cookbooks should not depend on the deprecated Poise framework'
@@ -37,7 +38,7 @@ module RuboCop
37
38
 
38
39
  def on_send(node)
39
40
  depends_method?(node) do |arg|
40
- add_offense(node, message: MSG, severity: :warning) if %w(poise poise-service).include?(arg.value)
41
+ add_offense(node, severity: :warning) if %w(poise poise-service poise-hoist).include?(arg.value)
41
42
  end
42
43
  end
43
44
  end
@@ -114,7 +114,7 @@ module RuboCop
114
114
  def on_send(node)
115
115
  chefspec_definition?(node) do |plat, ver|
116
116
  next unless legacy_chefspec_platform(plat.value, ver.value)
117
- add_offense(node, message: MSG, severity: :warning) do |corrector|
117
+ add_offense(node, severity: :warning) do |corrector|
118
118
  if replacement = replacement_string(plat.value, ver.value) # rubocop: disable Lint/AssignmentInCondition
119
119
  corrector.replace(ver, "'#{replacement}'")
120
120
  end
@@ -54,19 +54,19 @@ module RuboCop
54
54
 
55
55
  def on_send(node)
56
56
  deprecated_mixin?(node) do
57
- add_offense(node, message: MSG, severity: :warning) do |corrector|
57
+ add_offense(node, severity: :warning) do |corrector|
58
58
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
59
59
  end
60
60
  end
61
61
 
62
62
  deprecated_dsl?(node) do
63
- add_offense(node, message: MSG, severity: :warning) do |corrector|
63
+ add_offense(node, severity: :warning) do |corrector|
64
64
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
65
65
  end
66
66
  end
67
67
 
68
68
  dsl_mixin_require?(node) do
69
- add_offense(node, message: MSG, severity: :warning) do |corrector|
69
+ add_offense(node, severity: :warning) do |corrector|
70
70
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
71
71
  end
72
72
  end
@@ -51,7 +51,7 @@ module RuboCop
51
51
 
52
52
  def on_send(node)
53
53
  platform_method?(node) do
54
- add_offense(node, message: MSG, severity: :warning)
54
+ add_offense(node, severity: :warning)
55
55
  end
56
56
  end
57
57
  end
@@ -55,7 +55,7 @@ module RuboCop
55
55
  ).freeze
56
56
 
57
57
  def on_send(node)
58
- add_offense(node, message: MSG, severity: :warning)
58
+ add_offense(node, severity: :warning)
59
59
  end
60
60
  end
61
61
  end
@@ -51,7 +51,7 @@ module RuboCop
51
51
  next unless prop_node.arguments.first.sym_type?
52
52
  next unless [s(:sym, :install), s(:sym, :remove)].include?(prop_node.arguments.first)
53
53
 
54
- add_offense(prop_node, message: MSG, severity: :warning) do |corrector|
54
+ add_offense(prop_node, severity: :warning) do |corrector|
55
55
  corrector.replace(prop_node, prop_node.source
56
56
  .gsub('install', 'create')
57
57
  .gsub('remove', 'delete'))
@@ -33,7 +33,7 @@ module RuboCop
33
33
  RESTRICT_ON_SEND = [:older_than_win_2012_or_8?].freeze
34
34
 
35
35
  def on_send(node)
36
- add_offense(node, message: MSG, severity: :warning)
36
+ add_offense(node, severity: :warning)
37
37
  end
38
38
  end
39
39
  end
@@ -53,7 +53,7 @@ module RuboCop
53
53
  next unless prop_node.arguments.first.sym_type?
54
54
  next unless [s(:sym, :add), s(:sym, :delete)].include?(prop_node.arguments.first)
55
55
 
56
- add_offense(prop_node, message: MSG, severity: :warning) do |corrector|
56
+ add_offense(prop_node, severity: :warning) do |corrector|
57
57
  corrector.replace(prop_node, prop_node.source
58
58
  .gsub('add', 'create')
59
59
  .gsub('delete', 'remove'))
@@ -53,7 +53,7 @@ module RuboCop
53
53
  def on_block(node)
54
54
  %w(url keyurl mirrorexpire).each do |prop|
55
55
  match_property_in_resource?(:yum_repository, prop, node) do |prop_node|
56
- add_offense(prop_node, message: MSG, severity: :warning) do |corrector|
56
+ add_offense(prop_node, severity: :warning) do |corrector|
57
57
  corrector.replace(prop_node, prop_node.source
58
58
  .gsub(/^url/, 'baseurl')
59
59
  .gsub(/^keyurl/, 'gpgkey')
@@ -33,7 +33,7 @@ module RuboCop
33
33
  RESTRICT_ON_SEND = [:easy_install].freeze
34
34
 
35
35
  def on_send(node)
36
- add_offense(node, message: MSG, severity: :warning)
36
+ add_offense(node, severity: :warning)
37
37
  end
38
38
  end
39
39
  end
@@ -39,7 +39,7 @@ module RuboCop
39
39
 
40
40
  def on_send(node)
41
41
  control_group?(node) do
42
- add_offense(node.loc.selector, message: MSG, severity: :warning)
42
+ add_offense(node.loc.selector, severity: :warning)
43
43
  end
44
44
  end
45
45
  end
@@ -40,7 +40,7 @@ module RuboCop
40
40
  RESTRICT_ON_SEND = [:epic_fail].freeze
41
41
 
42
42
  def on_send(node)
43
- add_offense(node, message: MSG, severity: :warning) do |corrector|
43
+ add_offense(node, severity: :warning) do |corrector|
44
44
  corrector.replace(node, 'ignore_failure true')
45
45
  end
46
46
  end
@@ -33,7 +33,7 @@ module RuboCop
33
33
  RESTRICT_ON_SEND = [:erl_call].freeze
34
34
 
35
35
  def on_send(node)
36
- add_offense(node, message: MSG, severity: :warning)
36
+ add_offense(node, severity: :warning)
37
37
  end
38
38
  end
39
39
  end
@@ -40,7 +40,7 @@ module RuboCop
40
40
 
41
41
  def on_block(node)
42
42
  match_property_in_resource?(:execute, 'path', node) do |offense|
43
- add_offense(offense, message: MSG, severity: :warning) # @todo: we could probably autocorrect this with some work
43
+ add_offense(offense, severity: :warning) # @todo: we could probably autocorrect this with some work
44
44
  end
45
45
  end
46
46
  end
@@ -56,7 +56,7 @@ module RuboCop
56
56
  return
57
57
  end
58
58
 
59
- add_offense(offense, message: MSG, severity: :warning)
59
+ add_offense(offense, severity: :warning)
60
60
  end
61
61
  end
62
62
  end
@@ -34,7 +34,7 @@ module RuboCop
34
34
  def on_send(node)
35
35
  return unless node.arguments.first == s(:str, 'foodcritic')
36
36
 
37
- add_offense(node, message: MSG, severity: :warning)
37
+ add_offense(node, severity: :warning)
38
38
  end
39
39
  end
40
40
  end
@@ -105,7 +105,7 @@ module RuboCop
105
105
  def on_class(node)
106
106
  return if has_provides?
107
107
  HWRP?(node) do |inherit|
108
- add_offense(inherit, message: MSG, severity: :warning) do |corrector|
108
+ add_offense(inherit, severity: :warning) do |corrector|
109
109
  resource_name_ast(node) do |ast_match|
110
110
  # build a new string to add after that includes the new line and the proper indentation
111
111
  new_string = "\n" + ast_match.source.dup.gsub('resource_name', 'provides').prepend(' ' * indentation(ast_match))
@@ -76,7 +76,7 @@ module RuboCop
76
76
  def on_class(node)
77
77
  return if unified_mode?(processed_source.ast)
78
78
  HWRP?(node) do |inherit|
79
- add_offense(inherit, message: MSG, severity: :warning)
79
+ add_offense(inherit, severity: :warning)
80
80
  end
81
81
  end
82
82
  end
@@ -47,7 +47,7 @@ module RuboCop
47
47
 
48
48
  def on_class(node)
49
49
  inherits_from_compat_resource?(node) do
50
- add_offense(node, message: MSG, severity: :warning) do |corrector|
50
+ add_offense(node, severity: :warning) do |corrector|
51
51
  corrector.replace(node, node.source.gsub('ChefCompat', 'Chef'))
52
52
  end
53
53
  end
@@ -44,7 +44,7 @@ module RuboCop
44
44
 
45
45
  def on_block(node)
46
46
  match_property_in_resource?(:launchd, 'hash', node) do |offense|
47
- add_offense(offense.loc.expression, message: MSG, severity: :warning) do |corrector|
47
+ add_offense(offense.loc.expression, severity: :warning) do |corrector|
48
48
  corrector.replace(offense.loc.expression, offense.loc.expression.source.gsub(/^hash/, 'plist_hash'))
49
49
  end
50
50
  end
@@ -69,7 +69,7 @@ module RuboCop
69
69
 
70
70
  def on_send(node)
71
71
  legacy_notify?(node) do |notify_type, action, type, name, timing|
72
- add_offense(node, message: MSG, severity: :warning) do |corrector|
72
+ add_offense(node, severity: :warning) do |corrector|
73
73
  service_value = case name.type
74
74
  when :str
75
75
  "'#{type.source}[#{name.value}]'"
@@ -43,7 +43,7 @@ module RuboCop
43
43
 
44
44
  def on_send(node)
45
45
  old_yum_recipe?(node) do
46
- add_offense(node, message: MSG, severity: :warning)
46
+ add_offense(node, severity: :warning)
47
47
  end
48
48
  end
49
49
  end
@@ -33,7 +33,7 @@ module RuboCop
33
33
  def on_send(node)
34
34
  return unless node.arguments.first == s(:str, 'chefspec/librarian')
35
35
 
36
- add_offense(node, message: MSG, severity: :warning)
36
+ add_offense(node, severity: :warning)
37
37
  end
38
38
  end
39
39
  end
@@ -36,7 +36,7 @@ module RuboCop
36
36
 
37
37
  def on_block(node)
38
38
  match_property_in_resource?(:locale, 'lc_all', node) do |property|
39
- add_offense(property, message: MSG, severity: :warning)
39
+ add_offense(property, severity: :warning)
40
40
  end
41
41
  end
42
42
  end
@@ -53,7 +53,7 @@ module RuboCop
53
53
 
54
54
  def on_block(node)
55
55
  match_property_in_resource?(:log, 'notifies', node) do |prop_node|
56
- add_offense(prop_node, message: MSG, severity: :warning)
56
+ add_offense(prop_node, severity: :warning)
57
57
  end
58
58
  end
59
59
  end
@@ -48,7 +48,7 @@ module RuboCop
48
48
 
49
49
  def on_block(node)
50
50
  match_property_in_resource?(:macos_userdefaults, 'global', node) do |global|
51
- add_offense(global.loc.expression, message: MSG, severity: :warning) do |corrector|
51
+ add_offense(global.loc.expression, severity: :warning) do |corrector|
52
52
  corrector.remove(range_with_surrounding_space(range: global.loc.expression, side: :left))
53
53
  end
54
54
  end
@@ -47,7 +47,7 @@ module RuboCop
47
47
 
48
48
  def on_send(node)
49
49
  name_property_with_default?(node) do |default|
50
- add_offense(node, message: MSG, severity: :warning) do |corrector|
50
+ add_offense(node, severity: :warning) do |corrector|
51
51
  range = range_with_surrounding_comma(range_with_surrounding_space(range: default.loc.expression, side: :left), :left)
52
52
  corrector.remove(range)
53
53
  end
@@ -68,7 +68,7 @@ module RuboCop
68
68
 
69
69
  def on_send(node)
70
70
  node_ohai_methods?(node) do
71
- add_offense(node.loc.selector, message: MSG, severity: :warning) do |corrector|
71
+ add_offense(node.loc.selector, severity: :warning) do |corrector|
72
72
  corrector.replace(node, "node['#{node.method_name}']")
73
73
  end
74
74
  end
@@ -42,7 +42,7 @@ module RuboCop
42
42
 
43
43
  def on_send(node)
44
44
  node_set?(node) do
45
- add_offense(node.loc.selector, message: MSG, severity: :warning) do |corrector|
45
+ add_offense(node.loc.selector, severity: :warning) do |corrector|
46
46
  corrector.replace(node.loc.selector, 'normal')
47
47
  end
48
48
  end
@@ -42,7 +42,7 @@ module RuboCop
42
42
 
43
43
  def on_send(node)
44
44
  node_set_unless?(node) do
45
- add_offense(node.loc.selector, message: MSG, severity: :warning) do |corrector|
45
+ add_offense(node.loc.selector, severity: :warning) do |corrector|
46
46
  corrector.replace(node.loc.selector, 'normal_unless')
47
47
  end
48
48
  end
@@ -56,11 +56,11 @@ module RuboCop
56
56
 
57
57
  def add_offense_for_bare_assignment(sub_node)
58
58
  if sub_node.receiver == s(:send, nil, :node) # node['foo'] scenario
59
- add_offense(sub_node.receiver.loc.selector, message: MSG, severity: :warning)
59
+ add_offense(sub_node.receiver.loc.selector, severity: :warning)
60
60
  elsif sub_node.receiver &&
61
61
  sub_node.receiver&.node_parts[0] == s(:send, nil, :node) &&
62
62
  sub_node.receiver&.node_parts[1] == :[] # node['foo']['bar'] scenario
63
- add_offense(sub_node.receiver.node_parts.first.loc.selector, message: MSG, severity: :warning)
63
+ add_offense(sub_node.receiver.node_parts.first.loc.selector, severity: :warning)
64
64
  end
65
65
  end
66
66
  end
@@ -57,7 +57,7 @@ module RuboCop
57
57
 
58
58
  def on_send(node)
59
59
  partial_search_class?(node) do
60
- add_offense(node, message: MSG, severity: :warning)
60
+ add_offense(node, severity: :warning)
61
61
  end
62
62
  end
63
63
  end
@@ -52,7 +52,7 @@ module RuboCop
52
52
  RESTRICT_ON_SEND = [:partial_search].freeze
53
53
 
54
54
  def on_send(node)
55
- add_offense(node, message: MSG, severity: :warning)
55
+ add_offense(node, severity: :warning)
56
56
  end
57
57
  end
58
58
  end
@@ -47,13 +47,13 @@ module RuboCop
47
47
 
48
48
  def on_send(node)
49
49
  depends_poise_archive?(node) do
50
- add_offense(node, message: MSG, severity: :warning)
50
+ add_offense(node, severity: :warning)
51
51
  end
52
52
  end
53
53
 
54
54
  def on_block(node)
55
55
  match_resource_type?(:poise_archive, node) do
56
- add_offense(node, message: MSG, severity: :warning)
56
+ add_offense(node, severity: :warning)
57
57
  end
58
58
  end
59
59
  end
@@ -41,7 +41,7 @@ module RuboCop
41
41
 
42
42
  def on_send(node)
43
43
  community_source?(node) do
44
- add_offense(node, message: MSG, severity: :warning) do |corrector|
44
+ add_offense(node, severity: :warning) do |corrector|
45
45
  corrector.replace(node, 'default_source :supermarket')
46
46
  end
47
47
  end
@@ -47,7 +47,7 @@ module RuboCop
47
47
 
48
48
  def on_send(node)
49
49
  ps_cb_helper?(node) do |ver|
50
- add_offense(node, message: MSG, severity: :warning) do |corrector|
50
+ add_offense(node, severity: :warning) do |corrector|
51
51
  corrector.replace(node, "node['powershell']['version'].to_f == #{ver.source}")
52
52
  end
53
53
  end
@@ -41,7 +41,7 @@ module RuboCop
41
41
 
42
42
  def on_send(node)
43
43
  require_recipe?(node) do
44
- add_offense(node.loc.selector, message: MSG, severity: :warning) do |corrector|
44
+ add_offense(node.loc.selector, severity: :warning) do |corrector|
45
45
  corrector.replace(node.loc.selector, 'include_recipe')
46
46
  end
47
47
  end
@@ -37,9 +37,9 @@ module RuboCop
37
37
  def_node_search :calls_provides?, '(send nil? :provides ...)'
38
38
 
39
39
  def on_def(node)
40
- return unless node.method_name == :provides?
40
+ return unless node.method?(:provides?)
41
41
 
42
- add_offense(node, message: MSG, severity: :warning) unless calls_provides?(processed_source.ast)
42
+ add_offense(node, severity: :warning) unless calls_provides?(processed_source.ast)
43
43
  end
44
44
  end
45
45
  end