cookstyle 6.21.1 → 7.0.0

data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
+      module Deprecations
         # Use 'shell_out!' instead of the legacy 'run_command' or 'run_command_with_systems_locale' helpers for shelling out. The run_command helper was removed in Chef Infra Client 13.
         #
         # @example

data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
+      module Deprecations
         # In the cookbook search helper you need to use named parameters (key/value style) other than the first (type) and second (query string) values.
         #
         # @example

data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
+      module Deprecations
         # use_inline_resources became the default in Chef Infra Client 13+ and no longer needs
         # to be called in resources
         #

data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
+      module Deprecations
         # Chef Infra Client 16.5 introduced performance enhancements to Ruby library loading. Due to the underlying implementation of Ruby's `.to_yaml` method, it does not automatically load the `yaml` library and `YAML.dump()` should be used instead to properly load the `yaml` library.
         #
         # @example

data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
+      module Deprecations
         # The supports property was removed in Chef Infra Client 13 in favor of individual 'manage_home' and 'non_unique' properties.
         #
         # @example

data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
+      module Deprecations
         # In Chef Infra Client 13 the "file" variable for use within the verify property was replaced with the "path" variable.
         #
         # @example

data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
+      module Deprecations
         # The `windows_feature` resource no longer supports setting the `install_method` to `:servermanagercmd`. `:windows_feature_dism` or `:windows_feature_powershell` should be used instead.
         #
         # @example

data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
+      module Deprecations
         # In Chef Infra Client 13 and later the `windows_package` resource's `installer_type` property must be a symbol.
         #
         # @example

data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
+      module Deprecations
         # The :change action in the windows_task resource was removed when windows_task was added to Chef Infra Client 13+
         # The default action of :create should can now be used to create an update tasks.
         #

data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
+      module Deprecations
         # Use node['platform_version'] and node['kernel'] data instead of the deprecated Windows::VersionHelper helpers from the Windows cookbook.
         #
         # @example

data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
+      module Deprecations
         # Do not include the deprecated xml::ruby recipe to install the nokogiri gem. Chef Infra Client 12 and later ships with nokogiri included.
         #
         # @example

data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
+      module Deprecations
         # Don't include the deprecated yum DNF compatibility recipe, which is no longer necessary
         # as Chef Infra Client includes DNF package support
         #

data/lib/rubocop/cop/chef/effortless/berksfile.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefEffortless
+      module Effortless
         # Policyfiles should be used for cookbook dependency solving instead of a Berkshelf Berksfile.
         #
         class Berksfile < Base

data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefEffortless
+      module Effortless
         # Chef Vault is not supported in the Effortless pattern, so usage of Chef Vault must be shifted to another secrets management solution before leveraging the Effortless pattern.
         #
         # @example

data/lib/rubocop/cop/chef/effortless/data_bags.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefEffortless
+      module Effortless
         # Data bags cannot be used with the Effortless Infra pattern
         #
         # @example

data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefEffortless
+      module Effortless
         # Chef Vault is not supported in the Effortless pattern, so usage of Chef Vault must be shifted to another secrets management solution before leveraging the Effortless pattern.
         #
         # @example

data/lib/rubocop/cop/chef/effortless/node_environment.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefEffortless
+      module Effortless
         # Neither Policyfiles or Effortless Infra which is based on Policyfiles supports Chef Environments
         #
         # @example

data/lib/rubocop/cop/chef/effortless/node_policygroup.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefEffortless
+      module Effortless
         # Effortless Infra does not support Policyfile's Policygroup feature
         #
         # @example

data/lib/rubocop/cop/chef/effortless/node_roles.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefEffortless
+      module Effortless
         # Neither Policyfiles or Effortless Infra which is based on Policyfiles supports Chef Infra Roles
         #
         # @example

data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefEffortless
+      module Effortless
         # Policyfiles (and Effortless) do not use environments or roles so searching for those will need to be refactored before migrating to Policyfiles and the Effortless pattern.
         #
         # @example

data/lib/rubocop/cop/chef/effortless/search_used.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefEffortless
+      module Effortless
         # Search is not compatible with the Effortless Infra pattern
         #
         # @example

data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use the custom resource language's `action :my_action` blocks instead of creating actions with methods.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The allowed actions can now be specified using the `allowed_actions` helper instead of using the @actions or @allowed_actions variables in the resource's initialize method. In general we recommend against writing HWRPs, but if HWRPs are necessary you should utilize as much of the resource DSL as possible.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # For many users the apt::default cookbook is used only to update apt's package cache. Chef Infra Client 12.7 and later include an apt_update resource which should be used to perform this instead. Keep in mind that some users will want to stick with the apt::default recipe as it also installs packages necessary for using https repositories on Debian systems and manages some configuration files.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/berksfile_source.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Over the course of years there have been many different valid community site / Supermarket
         # URLs to use in a cookbook's Berksfile. These old URLs continue to function via redirects,
         # but should be updated to point to the latest Supermarket URL.

data/lib/rubocop/cop/chef/modernize/build_essential.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use the build_essential resource from the build-essential cookbook 5.0+ or Chef Infra Client 14+ instead of using the build-essential::default recipe.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Don't depend on cookbooks made obsolete by Chef Infra Client 14+. These community cookbooks contain resources that are now included in Chef Infra Client itself.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The nokogiri gem ships in Chef Infra Client 12+ and does not need to be installed before being used
         #
         # @example

data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The hostname, build_essential, chef_gem, and ohai_hint resources include 'compile_time' properties, which should be used to force the resources to run at compile time by setting `compile_time true`.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use ::File.exist?('/foo/bar') instead of the slower 'test -f /foo/bar' which requires shelling out
         #
         # @example

data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use the cron_d resource that ships with Chef Infra Client 14.4+ instead of manually creating the file with template, file, or cookbook_file resources.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The cron_manage resource was renamed to cron_access in the 6.1 release of the cron
         # cookbook, and later shipped in Chef Infra Client 14.4. The new resource name should
         # be used.

data/lib/rubocop/cop/chef/modernize/databag_helpers.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use the `data_bag_item` helper instead of `Chef::DataBagItem.load` or `Chef::EncryptedDataBagItem.load`.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The default actions can now be specified using the `default_action` helper instead of using the @action variable in the resource provider initialize method. In general we recommend against writing HWRPs, but if HWRPs are necessary you should utilize as much of the resource DSL as possible.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # ChefSpec 7.1 and later auto generate ChefSpec matchers. Matchers in cookbooks can now be removed.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/definitions.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # In 2016 with Chef Infra Client 12.5 Custom Resources were introduced as a way of writing reusable resource code that could be shipped in cookbooks. Custom Resources offer many advantages of legacy Definitions including unit testing with ChefSpec, input validation, actions, common properties like not_if/only_if, and resource reporting.
         #
         class Definitions < Base

data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Don't depend on the zypper cookbook as the zypper_repository resource is built into Chef Infra Client 13.3+
         #
         # @example

data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Chef Infra Client 12.4+ includes the Chef::DSL::Recipe in the resource and provider classed by default so there is no need to include this DSL in your resources or providers.
         #
         #   # bad

data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # There is no need for an empty initialize method in a resource
         #
         # @example

data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Instead of using the execute resource to to run the `apt-get update` use Chef Infra Client's built-n
         # apt_update resource which is available in Chef Infra Client 12.7 and later.
         #

data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Chef Infra Client 14.0 and later includes :create, :delete, and :configure actions with the full idempotency of the windows_service resource. See the windows_service documentation at https://docs.chef.io/resource_windows_service.html for additional details on creating services with the windows_service resource.
         #
         #   # bad

data/lib/rubocop/cop/chef/modernize/execute_sleep.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Chef Infra Client 15.5 and later include a chef_sleep resource that should be used to sleep between executing resources if necessary instead of using the bash or execute resources to run the sleep command.
         #
         #   # bad

data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Chef Infra Client 14.0 and later includes a sysctl resource that should be used to idempotently load sysctl values instead of templating files and using execute to load them.
         #
         #   # bad

data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Instead of using the execute or powershell_script resources to to run the `tzutil` command, use
         # Chef Infra Client's built-in timezone resource which is available in Chef Infra Client 14.6 and later.
         #

data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Remove legacy code comments that disable Foodcritic rules. These comments are no longer necessary if you've migrated from Foodcritic to Cookstyle for cookbook linting.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # if defined?(default_action) is no longer necessary in Chef Resources as default_action shipped in Chef 10.8.
         #
         # @example