cookstyle 6.21.1 → 7.0.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/config/cookstyle.yml +235 -236
- data/config/disable_all.yml +14 -0
- data/config/upstream.yml +111 -57
- data/lib/cookstyle/version.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/node_normal.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/property_without_type.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/service_resource.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/tmp_path.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/ use_automatic_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_rewind.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/cheffile.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/node_set.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/berksfile.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_environment.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_roles.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/build_essential.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/definitions.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/node_init_package.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +4 -4
- data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +13 -12
- data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +1 -1
- data/lib/rubocop/cop/chef/style/attribute_keys.rb +1 -1
- data/lib/rubocop/cop/chef/style/chef_whaaat.rb +1 -1
- data/lib/rubocop/cop/chef/style/comment_sentence_spacing.rb +1 -1
- data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +4 -3
- data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +1 -1
- data/lib/rubocop/cop/chef/style/comments_format.rb +1 -1
- data/lib/rubocop/cop/chef/style/file_mode.rb +1 -1
- data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +1 -1
- data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +1 -1
- data/lib/rubocop/cop/chef/style/negating_only_if.rb +1 -1
- data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +1 -1
- data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +1 -1
- data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +1 -1
- data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +1 -1
- data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +1 -1
- data/lib/rubocop/monkey_patches/comment_config.rb +1 -1
- metadata +4 -4
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA256:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: b7657520e64c1c6c6a5fb35520e8b03b7627c0cbf7f8c97c6b98876188174dd2
|
4
|
+
data.tar.gz: 541043c03cc4521990a973bad5b07834c89fa60d1d385ca449c63979917689ce
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: 177c42fe47c369af9a4f83545c0b702ee0407e3e66eb7f055055fa644b24fdc2f99dcfcabe7c1b16c29ed58a90d351a5e8a573a6e7d5beb443cecf0f858e4751
|
7
|
+
data.tar.gz: 48ccb6906f3793eabd00fe6f3b3ff1651196375d509ef5d07018552364e1f7b7dce47434d3d8c766b1aa3910b734747c3f39669a5749174f275e51ae6a81fb61
|
data/config/cookstyle.yml
CHANGED
@@ -7,13 +7,13 @@ AllCops:
|
|
7
7
|
- Guardfile
|
8
8
|
|
9
9
|
###############################
|
10
|
-
#
|
10
|
+
# Chef/Style: Making cookbooks look better
|
11
11
|
###############################
|
12
12
|
|
13
|
-
|
13
|
+
Chef/Style:
|
14
14
|
StyleGuideBaseURL: https://github.com/chef/cookstyle/blob/master/docs/cops_chefstyle.md
|
15
15
|
|
16
|
-
|
16
|
+
Chef/Style/AttributeKeys:
|
17
17
|
Description: Check which style of keys are used to access node attributes.
|
18
18
|
StyleGuide: '#chefstyleattributekeys'
|
19
19
|
Enabled: true
|
@@ -25,19 +25,19 @@ ChefStyle/AttributeKeys:
|
|
25
25
|
Exclude:
|
26
26
|
- '**/metadata.rb'
|
27
27
|
|
28
|
-
|
28
|
+
Chef/Style/CopyrightCommentFormat:
|
29
29
|
Description: Properly format copyright dates in comment blocks and ensure dates are up to date
|
30
30
|
StyleGuide: '#chefstylecopyrightcommentformat'
|
31
31
|
Enabled: false
|
32
32
|
VersionAdded: '5.0.0'
|
33
33
|
|
34
|
-
|
34
|
+
Chef/Style/CommentSentenceSpacing:
|
35
35
|
Description: Use a single space after sentences in comments
|
36
36
|
StyleGuide: '#chefstylecommentsentencespacing'
|
37
37
|
Enabled: false
|
38
38
|
VersionAdded: '5.1.0'
|
39
39
|
|
40
|
-
|
40
|
+
Chef/Style/CommentFormat:
|
41
41
|
Description: Use Chef's unique format for comment headers
|
42
42
|
StyleGuide: '#chefstylecommentformat'
|
43
43
|
Enabled: true
|
@@ -45,7 +45,7 @@ ChefStyle/CommentFormat:
|
|
45
45
|
Exclude:
|
46
46
|
- '**/Berksfile'
|
47
47
|
|
48
|
-
|
48
|
+
Chef/Style/FileMode:
|
49
49
|
Description: Use strings to represent file modes to avoid confusion between octal and base 10 integer formats.
|
50
50
|
StyleGuide: '#chefstylefilemode'
|
51
51
|
Enabled: true
|
@@ -55,7 +55,7 @@ ChefStyle/FileMode:
|
|
55
55
|
- '**/metadata.rb'
|
56
56
|
- '**/Berksfile'
|
57
57
|
|
58
|
-
|
58
|
+
Chef/Style/UsePlatformHelpers:
|
59
59
|
Description: Use platform? and platform_family? helpers to check node platform in resources and recipes
|
60
60
|
StyleGuide: '#chefstyleuseplatformhelpers'
|
61
61
|
Enabled: true
|
@@ -65,7 +65,7 @@ ChefStyle/UsePlatformHelpers:
|
|
65
65
|
- '**/libraries/*'
|
66
66
|
- '**/Berksfile'
|
67
67
|
|
68
|
-
|
68
|
+
Chef/Style/SimplifyPlatformMajorVersionCheck:
|
69
69
|
Description: Use node['platform_version'].to_i instead of node['platform_version'].split('.').first or node['platform_version'].split('.')[0]
|
70
70
|
StyleGuide: '#chefstylesimplifyplatformmajorversioncheck'
|
71
71
|
Enabled: true
|
@@ -74,13 +74,13 @@ ChefStyle/SimplifyPlatformMajorVersionCheck:
|
|
74
74
|
- '**/metadata.rb'
|
75
75
|
- '**/Berksfile'
|
76
76
|
|
77
|
-
|
77
|
+
Chef/Style/DefaultCopyrightComments:
|
78
78
|
Description: Cookbook copyright comment headers should be updated for a real person or organization.
|
79
79
|
StyleGuide: '#chefstyledefaultcopyrightcomments'
|
80
80
|
Enabled: true
|
81
81
|
VersionAdded: '5.12.0'
|
82
82
|
|
83
|
-
|
83
|
+
Chef/Style/UnnecessaryPlatformCaseStatement:
|
84
84
|
Description: Use the platform?() and platform_family?() helpers instead of a case statement that only includes a single when statement.
|
85
85
|
StyleGuide: '#chefstyleunnecessaryplatformcasestatement'
|
86
86
|
Enabled: true
|
@@ -89,7 +89,7 @@ ChefStyle/UnnecessaryPlatformCaseStatement:
|
|
89
89
|
- '**/metadata.rb'
|
90
90
|
- '**/Berksfile'
|
91
91
|
|
92
|
-
|
92
|
+
Chef/Style/ImmediateNotificationTiming:
|
93
93
|
Description: Use :immediately instead of :immediate for resource notification timing.
|
94
94
|
StyleGuide: '#chefstyleimmediatenotificationtiming'
|
95
95
|
Enabled: true
|
@@ -99,7 +99,7 @@ ChefStyle/ImmediateNotificationTiming:
|
|
99
99
|
- '**/metadata.rb'
|
100
100
|
- '**/Berksfile'
|
101
101
|
|
102
|
-
|
102
|
+
Chef/Style/TrueClassFalseClassResourceProperties:
|
103
103
|
Description: When setting the allowed types for a resource to accept either true or false values it's much simpler to use true and false instead of TrueClass and FalseClass.
|
104
104
|
StyleGuide: '#chefstyletrueclassfalseclassresourceproperties'
|
105
105
|
Enabled: true
|
@@ -108,7 +108,7 @@ ChefStyle/TrueClassFalseClassResourceProperties:
|
|
108
108
|
- '**/libraries/*.rb'
|
109
109
|
- '**/resources/*.rb'
|
110
110
|
|
111
|
-
|
111
|
+
Chef/Style/OverlyComplexSupportsDependsMetadata:
|
112
112
|
Description: Don't loop over an array to set cookbook dependencies or supported platforms if you have fewer than three values to set.
|
113
113
|
StyleGuide: '#chefstyleovercomplexsupportsdependsmetadata'
|
114
114
|
Enabled: true
|
@@ -116,13 +116,13 @@ ChefStyle/OverlyComplexSupportsDependsMetadata:
|
|
116
116
|
Include:
|
117
117
|
- '**/metadata.rb'
|
118
118
|
|
119
|
-
|
119
|
+
Chef/Style/ChefWhaaat:
|
120
120
|
Description: Do you mean Chef (the company) or a Chef product (e.g. Chef Infra, Chef InSpec, etc)?
|
121
121
|
StyleGuide: '#chefstylechefwhaaat'
|
122
122
|
Enabled: false
|
123
123
|
VersionAdded: '5.20.0'
|
124
124
|
|
125
|
-
|
125
|
+
Chef/Style/UnnecessaryOSCheck:
|
126
126
|
Description: Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match 1:1 with OS values. These helpers are easier to read and can accept multiple platform arguments, which greatly simplifies complex platform logic.
|
127
127
|
StyleGuide: '#chefstyleunnecessaryoscheck'
|
128
128
|
Enabled: true
|
@@ -131,7 +131,7 @@ ChefStyle/UnnecessaryOSCheck:
|
|
131
131
|
- '**/metadata.rb'
|
132
132
|
- '**/Berksfile'
|
133
133
|
|
134
|
-
|
134
|
+
Chef/Style/NegatingOnlyIf:
|
135
135
|
Description: Use not_if instead of only_if that negates the Ruby statement with a !
|
136
136
|
StyleGuide: '#chefstylenegatingonlyif'
|
137
137
|
VersionAdded: '6.2.0'
|
@@ -140,7 +140,7 @@ ChefStyle/NegatingOnlyIf:
|
|
140
140
|
- '**/metadata.rb'
|
141
141
|
- '**/Berksfile'
|
142
142
|
|
143
|
-
|
143
|
+
Chef/Style/IncludeRecipeWithParentheses:
|
144
144
|
Description: There is no need to wrap the recipe in parentheses when using the include_recipe helper
|
145
145
|
StyleGuide: '#includerecipewithparentheses'
|
146
146
|
VersionAdded: '6.11.0'
|
@@ -151,13 +151,13 @@ ChefStyle/IncludeRecipeWithParentheses:
|
|
151
151
|
- '**/Berksfile'
|
152
152
|
|
153
153
|
###############################
|
154
|
-
#
|
154
|
+
# Chef/Correctness: Avoiding potential problems
|
155
155
|
###############################
|
156
156
|
|
157
|
-
|
157
|
+
Chef/Correctness:
|
158
158
|
StyleGuideBaseURL: https://github.com/chef/cookstyle/blob/master/docs/cops_chefcorrectness.md
|
159
159
|
|
160
|
-
|
160
|
+
Chef/Correctness/ServiceResource:
|
161
161
|
Description: Use a service resource to start and stop services instead of execute resources
|
162
162
|
StyleGuide: '#chefcorrectnessserviceresource'
|
163
163
|
Enabled: true
|
@@ -167,7 +167,7 @@ ChefCorrectness/ServiceResource:
|
|
167
167
|
- '**/metadata.rb'
|
168
168
|
- '**/Berksfile'
|
169
169
|
|
170
|
-
|
170
|
+
Chef/Correctness/NodeNormal:
|
171
171
|
Description: Do not use the node.normal method
|
172
172
|
StyleGuide: '#chefcorrectnessnodenormal'
|
173
173
|
Enabled: true
|
@@ -176,7 +176,7 @@ ChefCorrectness/NodeNormal:
|
|
176
176
|
- '**/metadata.rb'
|
177
177
|
- '**/Berksfile'
|
178
178
|
|
179
|
-
|
179
|
+
Chef/Correctness/NodeNormalUnless:
|
180
180
|
Description: Do not use the node.normal_unless method
|
181
181
|
Enabled: true
|
182
182
|
VersionAdded: '5.1.0'
|
@@ -184,7 +184,7 @@ ChefCorrectness/NodeNormalUnless:
|
|
184
184
|
- '**/metadata.rb'
|
185
185
|
- '**/Berksfile'
|
186
186
|
|
187
|
-
|
187
|
+
Chef/Correctness/TmpPath:
|
188
188
|
Description: Use file_cache_path rather than hard-coding tmp paths
|
189
189
|
StyleGuide: '#chefcorrectnessnodenormalunless'
|
190
190
|
Enabled: true
|
@@ -193,7 +193,7 @@ ChefCorrectness/TmpPath:
|
|
193
193
|
- '**/metadata.rb'
|
194
194
|
- '**/Berksfile'
|
195
195
|
|
196
|
-
|
196
|
+
Chef/Correctness/InvalidPlatformMetadata:
|
197
197
|
Description: metadata.rb "supports" platform is invalid
|
198
198
|
StyleGuide: '#chefcorrectnessinvalidplatformmetadata'
|
199
199
|
Enabled: true
|
@@ -201,7 +201,7 @@ ChefCorrectness/InvalidPlatformMetadata:
|
|
201
201
|
Include:
|
202
202
|
- '**/metadata.rb'
|
203
203
|
|
204
|
-
|
204
|
+
Chef/Correctness/CookbookUsesNodeSave:
|
205
205
|
Description: Don't use node.save to save partial node data to the Chef Infra Server mid-run unless it's absolutely necessary. Node.save can result in failed Chef Infra runs appearing in search and increases load on the Chef Infra Server.
|
206
206
|
StyleGuide: '#chefcorrectnesscookbookusesnodesave'
|
207
207
|
Enabled: true
|
@@ -210,7 +210,7 @@ ChefCorrectness/CookbookUsesNodeSave:
|
|
210
210
|
- '**/metadata.rb'
|
211
211
|
- '**/Berksfile'
|
212
212
|
|
213
|
-
|
213
|
+
Chef/Correctness/MetadataMissingName:
|
214
214
|
Description: The metadata.rb file is missing the name field which is required by Chef Infra Client 12 and later
|
215
215
|
StyleGuide: '#chefcorrectnessmetadatamissingname'
|
216
216
|
Enabled: true
|
@@ -218,7 +218,7 @@ ChefCorrectness/MetadataMissingName:
|
|
218
218
|
Include:
|
219
219
|
- '**/metadata.rb'
|
220
220
|
|
221
|
-
|
221
|
+
Chef/Correctness/BlockGuardWithOnlyString:
|
222
222
|
Description: A resource guard (not_if/only_if) that is a string should not be wrapped in {}. Wrapping a guard string in {} causes it be executed as Ruby code which will always returns true instead of a shell command that will actually run.
|
223
223
|
StyleGuide: '#chefcorrectnessblockguardwithonlystring'
|
224
224
|
Enabled: true
|
@@ -228,7 +228,7 @@ ChefCorrectness/BlockGuardWithOnlyString:
|
|
228
228
|
- '**/metadata.rb'
|
229
229
|
- '**/Berksfile'
|
230
230
|
|
231
|
-
|
231
|
+
Chef/Correctness/ResourceSetsInternalProperties:
|
232
232
|
Description: Do not set properties used internally by Chef Infra Client to track the system state.
|
233
233
|
StyleGuide: '#chefcorrectnessresourcesetsinternalproperties'
|
234
234
|
Enabled: true
|
@@ -238,7 +238,7 @@ ChefCorrectness/ResourceSetsInternalProperties:
|
|
238
238
|
- '**/metadata.rb'
|
239
239
|
- '**/Berksfile'
|
240
240
|
|
241
|
-
|
241
|
+
Chef/Correctness/ResourceSetsNameProperty:
|
242
242
|
Description: Resource sets the name property in the resource instead of using a name_property.
|
243
243
|
StyleGuide: '#chefcorrectnessresourcesetsnameproperty'
|
244
244
|
Enabled: true
|
@@ -248,7 +248,7 @@ ChefCorrectness/ResourceSetsNameProperty:
|
|
248
248
|
- '**/metadata.rb'
|
249
249
|
- '**/Berksfile'
|
250
250
|
|
251
|
-
|
251
|
+
Chef/Correctness/ResourceWithNoneAction:
|
252
252
|
Description: Resource uses the nonexistent :none action instead of the :nothing action
|
253
253
|
StyleGuide: '#chefcorrectnessresourcewithnoneaction'
|
254
254
|
Enabled: true
|
@@ -258,7 +258,7 @@ ChefCorrectness/ResourceWithNoneAction:
|
|
258
258
|
- '**/metadata.rb'
|
259
259
|
- '**/Berksfile'
|
260
260
|
|
261
|
-
|
261
|
+
Chef/Correctness/InvalidVersionMetadata:
|
262
262
|
Description: Cookbook metadata.rb version field should follow X.Y.Z version format.
|
263
263
|
StyleGuide: '#chefcorrectnessinvalidversionmetadata'
|
264
264
|
Enabled: true
|
@@ -266,7 +266,7 @@ ChefCorrectness/InvalidVersionMetadata:
|
|
266
266
|
Include:
|
267
267
|
- '**/metadata.rb'
|
268
268
|
|
269
|
-
|
269
|
+
Chef/Correctness/NotifiesActionNotSymbol:
|
270
270
|
Description: When notifying or subscribing an action within a resource the action should always be a symbol. In Chef Infra Client releases before 14.0 this may result in double notification.
|
271
271
|
StyleGuide: '#chefcorrectnessnotifiesactionnotsymbol'
|
272
272
|
Enabled: true
|
@@ -276,7 +276,7 @@ ChefCorrectness/NotifiesActionNotSymbol:
|
|
276
276
|
- '**/metadata.rb'
|
277
277
|
- '**/Berksfile'
|
278
278
|
|
279
|
-
|
279
|
+
Chef/Correctness/IncorrectLibraryInjection:
|
280
280
|
Description: Libraries should be injected into the Chef::DSL::Recipe or Chef::DSL::Resource classes and not Recipe/Resource/Provider classes directly.
|
281
281
|
StyleGuide: '#chefcorrectnessincorrectlibraryinjection'
|
282
282
|
Enabled: true
|
@@ -285,7 +285,7 @@ ChefCorrectness/IncorrectLibraryInjection:
|
|
285
285
|
- '**/metadata.rb'
|
286
286
|
- '**/Berksfile'
|
287
287
|
|
288
|
-
|
288
|
+
Chef/Correctness/InvalidPlatformHelper:
|
289
289
|
Description: Pass valid platforms to the platform? helper.
|
290
290
|
StyleGuide: '#chefcorrectnessinvalidplatformhelper'
|
291
291
|
Enabled: true
|
@@ -294,7 +294,7 @@ ChefCorrectness/InvalidPlatformHelper:
|
|
294
294
|
- '**/metadata.rb'
|
295
295
|
- '**/Berksfile'
|
296
296
|
|
297
|
-
|
297
|
+
Chef/Correctness/InvalidPlatformFamilyHelper:
|
298
298
|
Description: Pass valid platform families to the platform_family? helper.
|
299
299
|
StyleGuide: '#chefcorrectnessinvalidplatformfamilyhelper'
|
300
300
|
Enabled: true
|
@@ -303,7 +303,7 @@ ChefCorrectness/InvalidPlatformFamilyHelper:
|
|
303
303
|
- '**/metadata.rb'
|
304
304
|
- '**/Berksfile'
|
305
305
|
|
306
|
-
|
306
|
+
Chef/Correctness/ScopedFileExist:
|
307
307
|
Description: Scope file exist to access the correct File class by using ::File.exist? not File.exist?.
|
308
308
|
StyleGuide: '#chefcorrectnessscopedfileexist'
|
309
309
|
Enabled: true
|
@@ -313,7 +313,7 @@ ChefCorrectness/ScopedFileExist:
|
|
313
313
|
- '**/metadata.rb'
|
314
314
|
- '**/Berksfile'
|
315
315
|
|
316
|
-
|
316
|
+
Chef/Correctness/InvalidPlatformValueForPlatformFamilyHelper:
|
317
317
|
Description: Pass valid platforms families to the value_for_platform_family helper.
|
318
318
|
StyleGuide: '#chefcorrectnessinvalidplatformvalueforplatformfamilyhelper'
|
319
319
|
Enabled: true
|
@@ -322,7 +322,7 @@ ChefCorrectness/InvalidPlatformValueForPlatformFamilyHelper:
|
|
322
322
|
- '**/metadata.rb'
|
323
323
|
- '**/Berksfile'
|
324
324
|
|
325
|
-
|
325
|
+
Chef/Correctness/InvalidPlatformValueForPlatformHelper:
|
326
326
|
Description: Pass valid platforms to the value_for_platform helper.
|
327
327
|
StyleGuide: '#chefcorrectnessinvalidplatformvalueforplatformhelper'
|
328
328
|
Enabled: true
|
@@ -331,7 +331,7 @@ ChefCorrectness/InvalidPlatformValueForPlatformHelper:
|
|
331
331
|
- '**/metadata.rb'
|
332
332
|
- '**/Berksfile'
|
333
333
|
|
334
|
-
|
334
|
+
Chef/Correctness/InvalidNotificationTiming:
|
335
335
|
Description: Valid notification timings are :immediately, :immediate (alias for :immediately), :delayed, and :before.
|
336
336
|
StyleGuide: '#chefcorrectnessinvalidnotificationtiming'
|
337
337
|
Enabled: true
|
@@ -341,7 +341,7 @@ ChefCorrectness/InvalidNotificationTiming:
|
|
341
341
|
- '**/metadata.rb'
|
342
342
|
- '**/Berksfile'
|
343
343
|
|
344
|
-
|
344
|
+
Chef/Correctness/MalformedPlatformValueForPlatformHelper:
|
345
345
|
Description: When using the value_for_platform helper you must include a hash of possible platforms where each platform contains a hash of versions and potential values. If you don't wish to match on a particular version you can instead use the key 'default'.
|
346
346
|
StyleGuide: '#chefcorrectnessmalformedplatformvalueforplatformhelper'
|
347
347
|
Enabled: true
|
@@ -350,7 +350,7 @@ ChefCorrectness/MalformedPlatformValueForPlatformHelper:
|
|
350
350
|
- '**/metadata.rb'
|
351
351
|
- '**/Berksfile'
|
352
352
|
|
353
|
-
|
353
|
+
Chef/Correctness/DnfPackageAllowDowngrades:
|
354
354
|
Description: dnf_package does not support the allow_downgrades property
|
355
355
|
StyleGuide: '#chefcorrectnessdnfpackageallowdowngrades'
|
356
356
|
Enabled: true
|
@@ -360,7 +360,7 @@ ChefCorrectness/DnfPackageAllowDowngrades:
|
|
360
360
|
- '**/metadata.rb'
|
361
361
|
- '**/Berksfile'
|
362
362
|
|
363
|
-
|
363
|
+
Chef/Correctness/ChefApplicationFatal:
|
364
364
|
Description: Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal
|
365
365
|
StyleGuide: '#chefcorrectnesschefapplicationfatal'
|
366
366
|
Enabled: true
|
@@ -369,7 +369,7 @@ ChefCorrectness/ChefApplicationFatal:
|
|
369
369
|
- '**/metadata.rb'
|
370
370
|
- '**/Berksfile'
|
371
371
|
|
372
|
-
|
372
|
+
Chef/Correctness/PowershellScriptDeleteFile:
|
373
373
|
Description: Use the `file` or `directory` resources built into Chef Infra Client with the :delete action to remove files/directories instead of using Remove-Item in a powershell_script resource
|
374
374
|
StyleGuide: '#chefcorrectnesspowershellscriptdeletefiles'
|
375
375
|
Enabled: true
|
@@ -379,7 +379,7 @@ ChefCorrectness/PowershellScriptDeleteFile:
|
|
379
379
|
- '**/metadata.rb'
|
380
380
|
- '**/Berksfile'
|
381
381
|
|
382
|
-
|
382
|
+
Chef/Correctness/ConditionalRubyShellout:
|
383
383
|
Description: Don't use Ruby to shellout in an only_if / not_if conditional when you can shellout directly by wrapping the command in quotes.
|
384
384
|
StyleGuide: '#chefcorrectnessconditionalrubyshellout'
|
385
385
|
Enabled: true
|
@@ -389,7 +389,7 @@ ChefCorrectness/ConditionalRubyShellout:
|
|
389
389
|
- '**/metadata.rb'
|
390
390
|
- '**/Berksfile'
|
391
391
|
|
392
|
-
|
392
|
+
Chef/Correctness/LazyEvalNodeAttributeDefaults:
|
393
393
|
Description: When setting a node attribute as a default value for a custom resource property, make sure to wrap the node attribute in `lazy {}` so that the node attribute is available when the resource executes.
|
394
394
|
StyleGuide: '#chefcorrectnesslazyevalnodeattributedefaults'
|
395
395
|
Enabled: true
|
@@ -398,7 +398,7 @@ ChefCorrectness/LazyEvalNodeAttributeDefaults:
|
|
398
398
|
- '**/libraries/*.rb'
|
399
399
|
- '**/resources/*.rb'
|
400
400
|
|
401
|
-
|
401
|
+
Chef/Correctness/OpenSSLPasswordHelpers:
|
402
402
|
Description: The secure_password helper from the openssl cookbooks Opscode::OpenSSL::Password class should not be used to generate passwords.
|
403
403
|
StyleGuide: '#chefcorrectnessopensslpasswordhelpers'
|
404
404
|
Enabled: true
|
@@ -407,7 +407,7 @@ ChefCorrectness/OpenSSLPasswordHelpers:
|
|
407
407
|
- '**/metadata.rb'
|
408
408
|
- '**/Berksfile'
|
409
409
|
|
410
|
-
|
410
|
+
Chef/Correctness/InvalidPlatformFamilyInCase:
|
411
411
|
Description: Use valid platform family values in case statements.
|
412
412
|
StyleGuide: '#chefcorrectnessinvalidplatformfamilyincase'
|
413
413
|
Enabled: true
|
@@ -416,7 +416,7 @@ ChefCorrectness/InvalidPlatformFamilyInCase:
|
|
416
416
|
- '**/metadata.rb'
|
417
417
|
- '**/Berksfile'
|
418
418
|
|
419
|
-
|
419
|
+
Chef/Correctness/InvalidPlatformInCase:
|
420
420
|
Description: Use valid platform values in case statements.
|
421
421
|
StyleGuide: '#chefcorrectnessinvalidplatformincase'
|
422
422
|
Enabled: true
|
@@ -425,7 +425,7 @@ ChefCorrectness/InvalidPlatformInCase:
|
|
425
425
|
- '**/metadata.rb'
|
426
426
|
- '**/Berksfile'
|
427
427
|
|
428
|
-
|
428
|
+
Chef/Correctness/InvalidDefaultAction:
|
429
429
|
Description: Default actions in resources should be a symbol or an array of symbols.
|
430
430
|
StyleGuide: '#chefcorrectnessinvaliddefaultaction'
|
431
431
|
Enabled: true
|
@@ -434,7 +434,7 @@ ChefCorrectness/InvalidDefaultAction:
|
|
434
434
|
- '**/libraries/*.rb'
|
435
435
|
- '**/resources/*.rb'
|
436
436
|
|
437
|
-
|
437
|
+
Chef/Correctness/SupportsMustBeFloat:
|
438
438
|
Description: Versions used in metadata.rb supports calls should be floats not integers.
|
439
439
|
StyleGuide: '#chefcorrectnesssupportsmustbefloat'
|
440
440
|
Enabled: true
|
@@ -442,7 +442,7 @@ ChefCorrectness/SupportsMustBeFloat:
|
|
442
442
|
Include:
|
443
443
|
- '**/metadata.rb'
|
444
444
|
|
445
|
-
|
445
|
+
Chef/Correctness/MacosUserdefaultsInvalidType:
|
446
446
|
Description: The macos_userdefaults resource prior to Chef Infra Client 16.3 would silently continue if invalid types were passed resulting in unexpected behavior. Valid values are 'array', 'bool', 'dict', 'float', 'int', and 'string'.
|
447
447
|
StyleGuide: '#chefcorrectnessmacosuserdefaultsinvalidtype'
|
448
448
|
Enabled: true
|
@@ -451,7 +451,7 @@ ChefCorrectness/MacosUserdefaultsInvalidType:
|
|
451
451
|
- '**/metadata.rb'
|
452
452
|
- '**/Berksfile'
|
453
453
|
|
454
|
-
|
454
|
+
Chef/Correctness/LazyInResourceGuard:
|
455
455
|
Description: Using `lazy {}` within a resource guard (not_if/only_if) will cause failures and is unnecessary as resource guards are always lazily evaluated.
|
456
456
|
StyleGuide: '#chefcorrectnesslazyinresourceguard'
|
457
457
|
Enabled: true
|
@@ -460,7 +460,7 @@ ChefCorrectness/LazyInResourceGuard:
|
|
460
460
|
- '**/metadata.rb'
|
461
461
|
- '**/Berksfile'
|
462
462
|
|
463
|
-
|
463
|
+
Chef/Correctness/PropertyWithoutType:
|
464
464
|
Description: Custom resource properties or attributes should always define a type to help users understand the correct allowed values.
|
465
465
|
StyleGuide: '#chefcorrectnesspropertywithouttype'
|
466
466
|
Enabled: true
|
@@ -469,7 +469,7 @@ ChefCorrectness/PropertyWithoutType:
|
|
469
469
|
- '**/libraries/*.rb'
|
470
470
|
- '**/resources/*.rb'
|
471
471
|
|
472
|
-
|
472
|
+
Chef/Correctness/OctalModeAsString:
|
473
473
|
Description: Don't represent file modes as strings containing octal values. Use standard base 10 file modes instead.
|
474
474
|
StyleGuide: '#chefcorrectnessoctalmodeasstring'
|
475
475
|
Enabled: true
|
@@ -480,13 +480,13 @@ ChefCorrectness/OctalModeAsString:
|
|
480
480
|
- '**/Berksfile'
|
481
481
|
|
482
482
|
###############################
|
483
|
-
#
|
483
|
+
# Chef/Sharing: Issues that prevent sharing code with other teams or with the Chef community in general
|
484
484
|
###############################
|
485
485
|
|
486
|
-
|
486
|
+
Chef/Sharing:
|
487
487
|
StyleGuideBaseURL: https://github.com/chef/cookstyle/blob/master/docs/cops_chefsharing.md
|
488
488
|
|
489
|
-
|
489
|
+
Chef/Sharing/InsecureCookbookURL:
|
490
490
|
Description: Insecure http Github or Gitlab URLs for metadata source_url/issues_url fields
|
491
491
|
StyleGuide: '#chefsharinginsecurecookbookurl'
|
492
492
|
Enabled: true
|
@@ -495,7 +495,7 @@ ChefSharing/InsecureCookbookURL:
|
|
495
495
|
Include:
|
496
496
|
- '**/metadata.rb'
|
497
497
|
|
498
|
-
|
498
|
+
Chef/Sharing/InvalidLicenseString:
|
499
499
|
Description: Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved"
|
500
500
|
StyleGuide: '#chefsharinginvalidlicensestring'
|
501
501
|
Enabled: true
|
@@ -504,7 +504,7 @@ ChefSharing/InvalidLicenseString:
|
|
504
504
|
Include:
|
505
505
|
- '**/metadata.rb'
|
506
506
|
|
507
|
-
|
507
|
+
Chef/Sharing/DefaultMetadataMaintainer:
|
508
508
|
Description: Metadata contains default maintainer information from the cookbook generator. Add actual cookbook maintainer information to the metadata.rb.
|
509
509
|
StyleGuide: '#chefsharingdefaultmetadatamaintainer'
|
510
510
|
Enabled: true
|
@@ -513,7 +513,7 @@ ChefSharing/DefaultMetadataMaintainer:
|
|
513
513
|
Include:
|
514
514
|
- '**/metadata.rb'
|
515
515
|
|
516
|
-
|
516
|
+
Chef/Sharing/EmptyMetadataField:
|
517
517
|
Description: metadata.rb should not include fields with an empty string. Either don't include the field or add a value.
|
518
518
|
StyleGuide: '#chefsharingemptymetadatafield'
|
519
519
|
Enabled: true
|
@@ -522,7 +522,7 @@ ChefSharing/EmptyMetadataField:
|
|
522
522
|
Include:
|
523
523
|
- '**/metadata.rb'
|
524
524
|
|
525
|
-
|
525
|
+
Chef/Sharing/IncludePropertyDescriptions:
|
526
526
|
Description: Properties should include description fields to allow automated documentation. Requires Chef Infra Client 13.9 or later.
|
527
527
|
StyleGuide: '#chefsharingincludepropetydescriptions'
|
528
528
|
Enabled: false
|
@@ -531,7 +531,7 @@ ChefSharing/IncludePropertyDescriptions:
|
|
531
531
|
- '**/libraries/*.rb'
|
532
532
|
- '**/resources/*.rb'
|
533
533
|
|
534
|
-
|
534
|
+
Chef/Sharing/IncludeResourceDescriptions:
|
535
535
|
Description: Resources should include description fields to allow automated documentation. Requires Chef Infra Client 13.9 or later.
|
536
536
|
StyleGuide: '#chefsharingincluderesourcedescriptions'
|
537
537
|
Enabled: false
|
@@ -539,7 +539,7 @@ ChefSharing/IncludeResourceDescriptions:
|
|
539
539
|
Include:
|
540
540
|
- '**/resources/*.rb'
|
541
541
|
|
542
|
-
|
542
|
+
Chef/Sharing/IncludeResourceExamples:
|
543
543
|
Description: Resources should include examples field to allow automated documentation. Requires Chef Infra Client 13.9 or later.
|
544
544
|
StyleGuide: '#chefsharingincluderesourceexamples'
|
545
545
|
Enabled: false
|
@@ -548,13 +548,13 @@ ChefSharing/IncludeResourceExamples:
|
|
548
548
|
- '**/resources/*.rb'
|
549
549
|
|
550
550
|
###############################
|
551
|
-
#
|
551
|
+
# Chef/Deprecations: Resolving Deprecations that block upgrading Chef Infra Client
|
552
552
|
###############################
|
553
553
|
|
554
|
-
|
554
|
+
Chef/Deprecations:
|
555
555
|
StyleGuideBaseURL: https://github.com/chef/cookstyle/blob/master/docs/cops_chefdeprecations.md
|
556
556
|
|
557
|
-
|
557
|
+
Chef/Deprecations/NodeDeepFetch:
|
558
558
|
Description: Do not use the deprecated chef-sugar node.deep_fetch methods
|
559
559
|
StyleGuide: '#chefdeprecationsnodedeepfetch'
|
560
560
|
Enabled: true
|
@@ -563,7 +563,7 @@ ChefDeprecations/NodeDeepFetch:
|
|
563
563
|
- '**/metadata.rb'
|
564
564
|
- '**/Berksfile'
|
565
565
|
|
566
|
-
|
566
|
+
Chef/Deprecations/NodeSet:
|
567
567
|
Description: Do not use the deprecated node.set method
|
568
568
|
StyleGuide: '#chefdeprecationsnodeset'
|
569
569
|
Enabled: true
|
@@ -572,7 +572,7 @@ ChefDeprecations/NodeSet:
|
|
572
572
|
- '**/metadata.rb'
|
573
573
|
- '**/Berksfile'
|
574
574
|
|
575
|
-
|
575
|
+
Chef/Deprecations/NodeSetUnless:
|
576
576
|
Description: Do not use the deprecated node.set_unless method
|
577
577
|
StyleGuide: '#chefdeprecationsnodesetunless'
|
578
578
|
Enabled: true
|
@@ -581,7 +581,7 @@ ChefDeprecations/NodeSetUnless:
|
|
581
581
|
- '**/metadata.rb'
|
582
582
|
- '**/Berksfile'
|
583
583
|
|
584
|
-
|
584
|
+
Chef/Deprecations/EpicFail:
|
585
585
|
Description: Use ignore_failure method instead of the deprecated epic_fail method
|
586
586
|
StyleGuide: '#chefdeprecationsepicfail'
|
587
587
|
Enabled: true
|
@@ -591,7 +591,7 @@ ChefDeprecations/EpicFail:
|
|
591
591
|
- '**/metadata.rb'
|
592
592
|
- '**/Berksfile'
|
593
593
|
|
594
|
-
|
594
|
+
Chef/Deprecations/CookbookDependsOnPoise:
|
595
595
|
Description: Cookbooks should not depend on the deprecated Poise framework
|
596
596
|
StyleGuide: '#chefdeprecationscookbookdependsonpoise'
|
597
597
|
Enabled: true
|
@@ -599,7 +599,7 @@ ChefDeprecations/CookbookDependsOnPoise:
|
|
599
599
|
Include:
|
600
600
|
- '**/metadata.rb'
|
601
601
|
|
602
|
-
|
602
|
+
Chef/Deprecations/CookbookDependsOnCompatResource:
|
603
603
|
Description: Don't depend on the deprecated compat_resource cookbook made obsolete by Chef Infra Client 12.19+
|
604
604
|
StyleGuide: '#chefdeprecationscookbookdependsoncompatresource'
|
605
605
|
Enabled: true
|
@@ -607,7 +607,7 @@ ChefDeprecations/CookbookDependsOnCompatResource:
|
|
607
607
|
Include:
|
608
608
|
- '**/metadata.rb'
|
609
609
|
|
610
|
-
|
610
|
+
Chef/Deprecations/CookbookDependsOnPartialSearch:
|
611
611
|
Description: Don't depend on the deprecated partial_search cookbook made obsolete by Chef Infra Client 13+
|
612
612
|
StyleGuide: '#chefdeprecationscookbookdependsonpartialsearch'
|
613
613
|
Enabled: true
|
@@ -615,7 +615,7 @@ ChefDeprecations/CookbookDependsOnPartialSearch:
|
|
615
615
|
Include:
|
616
616
|
- '**/metadata.rb'
|
617
617
|
|
618
|
-
|
618
|
+
Chef/Deprecations/EasyInstallResource:
|
619
619
|
Description: Don't use the deprecated easy_install resource resource removed in Chef Infra Client 13
|
620
620
|
StyleGuide: '#chefdeprecationseasyinstallresource'
|
621
621
|
Enabled: true
|
@@ -625,7 +625,7 @@ ChefDeprecations/EasyInstallResource:
|
|
625
625
|
- '**/metadata.rb'
|
626
626
|
- '**/Berksfile'
|
627
627
|
|
628
|
-
|
628
|
+
Chef/Deprecations/ErlCallResource:
|
629
629
|
Description: Don't use the deprecated erl_call resource removed in Chef Infra Client 13
|
630
630
|
StyleGuide: '#chefdeprecationserlcallresource'
|
631
631
|
Enabled: true
|
@@ -635,7 +635,7 @@ ChefDeprecations/ErlCallResource:
|
|
635
635
|
- '**/metadata.rb'
|
636
636
|
- '**/Berksfile'
|
637
637
|
|
638
|
-
|
638
|
+
Chef/Deprecations/RequireRecipe:
|
639
639
|
Description: Use include_recipe instead of the require_recipe method
|
640
640
|
StyleGuide: '#chefdeprecationsrequirerecipe'
|
641
641
|
Enabled: true
|
@@ -645,7 +645,7 @@ ChefDeprecations/RequireRecipe:
|
|
645
645
|
- '**/metadata.rb'
|
646
646
|
- '**/Berksfile'
|
647
647
|
|
648
|
-
|
648
|
+
Chef/Deprecations/NodeMethodsInsteadofAttributes:
|
649
649
|
Description: Use node attributes to access Ohai data instead of node methods, which were deprecated in Chef Infra Client 13.
|
650
650
|
StyleGuide: '#chefdeprecationsnodemethodsinsteadofattributes'
|
651
651
|
Enabled: true
|
@@ -654,7 +654,7 @@ ChefDeprecations/NodeMethodsInsteadofAttributes:
|
|
654
654
|
- '**/metadata.rb'
|
655
655
|
- '**/Berksfile'
|
656
656
|
|
657
|
-
|
657
|
+
Chef/Deprecations/UsesDeprecatedMixins:
|
658
658
|
Description: Don't use deprecated Mixins no longer included in Chef Infra Client 14 and later.
|
659
659
|
StyleGuide: '#chefdeprecationsusesdeprecatedmixins'
|
660
660
|
Enabled: true
|
@@ -664,7 +664,7 @@ ChefDeprecations/UsesDeprecatedMixins:
|
|
664
664
|
- '**/providers/*.rb'
|
665
665
|
- '**/resources/*.rb'
|
666
666
|
|
667
|
-
|
667
|
+
Chef/Deprecations/IncludingXMLRubyRecipe:
|
668
668
|
Description: The xml::ruby recipe installs nokogiri which is included in Chef Infra Client 12 and later.
|
669
669
|
StyleGuide: '#chefdeprecationsincludingxmlrubyrecipe'
|
670
670
|
Enabled: true
|
@@ -674,7 +674,7 @@ ChefDeprecations/IncludingXMLRubyRecipe:
|
|
674
674
|
- '**/metadata.rb'
|
675
675
|
- '**/Berksfile'
|
676
676
|
|
677
|
-
|
677
|
+
Chef/Deprecations/LegacyYumCookbookRecipes:
|
678
678
|
Description: The elrepo, epel, ius, remi, and repoforge recipes were split into their own cookbooks and the yum recipe was renamed to be default with the release of yum cookbook 3.0 (Dec 2013).
|
679
679
|
StyleGuide: '#chefdeprecationslegacyyumcookbookrecipes'
|
680
680
|
Enabled: true
|
@@ -682,7 +682,7 @@ ChefDeprecations/LegacyYumCookbookRecipes:
|
|
682
682
|
Exclude:
|
683
683
|
- '**/metadata.rb'
|
684
684
|
|
685
|
-
|
685
|
+
Chef/Deprecations/UsesChefRESTHelpers:
|
686
686
|
Description: Don't use the helpers in Chef::REST which were removed in Chef Infra Client 13
|
687
687
|
StyleGuide: '#chefdeprecationsuseschefresthelpers'
|
688
688
|
Enabled: true
|
@@ -690,7 +690,7 @@ ChefDeprecations/UsesChefRESTHelpers:
|
|
690
690
|
Exclude:
|
691
691
|
- '**/metadata.rb'
|
692
692
|
|
693
|
-
|
693
|
+
Chef/Deprecations/ChocolateyPackageUninstallAction:
|
694
694
|
Description: Use the :remove action in the chocolatey_package resource instead of :uninstall which was removed in Chef Infra Client 14+
|
695
695
|
StyleGuide: '#chefdeprecationschocolateypackageuninstallaction'
|
696
696
|
Enabled: true
|
@@ -698,7 +698,7 @@ ChefDeprecations/ChocolateyPackageUninstallAction:
|
|
698
698
|
Exclude:
|
699
699
|
- '**/metadata.rb'
|
700
700
|
|
701
|
-
|
701
|
+
Chef/Deprecations/LaunchdDeprecatedHashProperty:
|
702
702
|
Description: The launchd resource's hash property was renamed to plist_hash in Chef Infra Client 13+ to avoid conflicts with Ruby's hash class.
|
703
703
|
StyleGuide: '#chefdeprecationslaunchddeprecatedhashproperty'
|
704
704
|
Enabled: true
|
@@ -706,7 +706,7 @@ ChefDeprecations/LaunchdDeprecatedHashProperty:
|
|
706
706
|
Exclude:
|
707
707
|
- '**/metadata.rb'
|
708
708
|
|
709
|
-
|
709
|
+
Chef/Deprecations/LocaleDeprecatedLcAllProperty:
|
710
710
|
Description: The local resource's lc_all property has been deprecated and will be removed in Chef Infra Client 16
|
711
711
|
StyleGuide: '#chefdeprecationslocaledeprecatedlcallproperty'
|
712
712
|
Enabled: true
|
@@ -714,7 +714,7 @@ ChefDeprecations/LocaleDeprecatedLcAllProperty:
|
|
714
714
|
Exclude:
|
715
715
|
- '**/metadata.rb'
|
716
716
|
|
717
|
-
|
717
|
+
Chef/Deprecations/UserDeprecatedSupportsProperty:
|
718
718
|
Description: The supports property was removed in Chef Infra Client 13 in favor of individual 'manage_home' and 'non_unique' properties.
|
719
719
|
StyleGuide: '#chefdeprecationsuserdeprecatedsupportsproperty'
|
720
720
|
Enabled: true
|
@@ -722,7 +722,7 @@ ChefDeprecations/UserDeprecatedSupportsProperty:
|
|
722
722
|
Exclude:
|
723
723
|
- '**/metadata.rb'
|
724
724
|
|
725
|
-
|
725
|
+
Chef/Deprecations/UseInlineResourcesDefined:
|
726
726
|
Description: use_inline_resources is now the default for resources in Chef Infra Client 13+ and does not need to be specified.
|
727
727
|
StyleGuide: '#chefdeprecationsuseinlineresourcesdefined'
|
728
728
|
Enabled: true
|
@@ -732,7 +732,7 @@ ChefDeprecations/UseInlineResourcesDefined:
|
|
732
732
|
- '**/providers/*.rb'
|
733
733
|
- '**/resources/*.rb'
|
734
734
|
|
735
|
-
|
735
|
+
Chef/Deprecations/IncludingYumDNFCompatRecipe:
|
736
736
|
Description: Do not include the yum::dnf_yum_compat default recipe to install yum on dnf systems. Chef Infra Client now includes built in support for DNF.
|
737
737
|
StyleGuide: '#chefdeprecationsincludingyumdnfcompatrecipe'
|
738
738
|
Enabled: true
|
@@ -740,7 +740,7 @@ ChefDeprecations/IncludingYumDNFCompatRecipe:
|
|
740
740
|
Exclude:
|
741
741
|
- '**/metadata.rb'
|
742
742
|
|
743
|
-
|
743
|
+
Chef/Deprecations/WindowsTaskChangeAction:
|
744
744
|
Description: The :change action in the windows_task resource was removed when windows_task was added to Chef Infra Client 13+. The default action of :create should can now be used to create an update tasks.
|
745
745
|
StyleGuide: '#chefdeprecationswindowstaskchangeaction'
|
746
746
|
Enabled: true
|
@@ -748,7 +748,7 @@ ChefDeprecations/WindowsTaskChangeAction:
|
|
748
748
|
Exclude:
|
749
749
|
- '**/metadata.rb'
|
750
750
|
|
751
|
-
|
751
|
+
Chef/Deprecations/ResourceOverridesProvidesMethod:
|
752
752
|
Description: Don't override the provides? method in a resource provider. Use provides :SOME_PROVIDER_NAME instead. This will cause failures in Chef Infra Client 13 and later.
|
753
753
|
StyleGuide: '#chefdeprecationsresourceoverridesprovidesmethod'
|
754
754
|
Enabled: true
|
@@ -758,7 +758,7 @@ ChefDeprecations/ResourceOverridesProvidesMethod:
|
|
758
758
|
- '**/providers/*.rb'
|
759
759
|
- '**/resources/*.rb'
|
760
760
|
|
761
|
-
|
761
|
+
Chef/Deprecations/ResourceUsesDslNameMethod:
|
762
762
|
Description: Use resource_name instead of the dsl_name method in resources. This will cause failures in Chef Infra Client 13 and later.
|
763
763
|
StyleGuide: '#chefdeprecationsresourceusesdslnamemethod'
|
764
764
|
Enabled: true
|
@@ -768,7 +768,7 @@ ChefDeprecations/ResourceUsesDslNameMethod:
|
|
768
768
|
- '**/providers/*.rb'
|
769
769
|
- '**/resources/*.rb'
|
770
770
|
|
771
|
-
|
771
|
+
Chef/Deprecations/ResourceUsesUpdatedMethod:
|
772
772
|
Description: Don't use updated = true/false to update resource state. This will cause failures in Chef Infra Client 13 and later.
|
773
773
|
StyleGuide: '#chefdeprecationsresourceusesupdatedmethod'
|
774
774
|
Enabled: false # has a high potential for false positives
|
@@ -778,7 +778,7 @@ ChefDeprecations/ResourceUsesUpdatedMethod:
|
|
778
778
|
- '**/providers/*.rb'
|
779
779
|
- '**/resources/*.rb'
|
780
780
|
|
781
|
-
|
781
|
+
Chef/Deprecations/NamePropertyWithDefaultValue:
|
782
782
|
Description: A resource property can't be marked as a name_property and also have a default value. This will fail in Chef Infra Client 13 or later.
|
783
783
|
StyleGuide: '#chefdeprecationsnamepropertywithdefaultvalue'
|
784
784
|
Enabled: true
|
@@ -787,7 +787,7 @@ ChefDeprecations/NamePropertyWithDefaultValue:
|
|
787
787
|
- '**/libraries/*.rb'
|
788
788
|
- '**/resources/*.rb'
|
789
789
|
|
790
|
-
|
790
|
+
Chef/Deprecations/ResourceUsesProviderBaseMethod:
|
791
791
|
Description: Don't use the deprecated provider_base method in a resource to specify the provider module to use. Instead, the provider should call provides to register itself, or the resource should call provider to specify the provider to use. This will cause failures in Chef Infra Client 13 and later.
|
792
792
|
StyleGuide: '#chefdeprecationsresourceusesproviderbasemethod'
|
793
793
|
Enabled: true
|
@@ -796,7 +796,7 @@ ChefDeprecations/ResourceUsesProviderBaseMethod:
|
|
796
796
|
- '**/libraries/*.rb'
|
797
797
|
- '**/resources/*.rb'
|
798
798
|
|
799
|
-
|
799
|
+
Chef/Deprecations/ChefSpecCoverageReport:
|
800
800
|
Description: Don't use the deprecated ChefSpec coverage report functionality in your specs.
|
801
801
|
StyleGuide: '#chefdeprecationschefspeccoveragereport'
|
802
802
|
Enabled: true
|
@@ -804,7 +804,7 @@ ChefDeprecations/ChefSpecCoverageReport:
|
|
804
804
|
Include:
|
805
805
|
- '**/spec/*.rb'
|
806
806
|
|
807
|
-
|
807
|
+
Chef/Deprecations/ChefSpecLegacyRunner:
|
808
808
|
Description: Use ChefSpec::SoloRunner or ChefSpec::ServerRunner instead of the deprecated ChefSpec::Runner.
|
809
809
|
StyleGuide: '#chefdeprecationschefspeclegacyrunner'
|
810
810
|
Enabled: true
|
@@ -812,7 +812,7 @@ ChefDeprecations/ChefSpecLegacyRunner:
|
|
812
812
|
Include:
|
813
813
|
- '**/spec/*.rb'
|
814
814
|
|
815
|
-
|
815
|
+
Chef/Deprecations/UsesRunCommandHelper:
|
816
816
|
Description: Use 'shell_out!' instead of the legacy 'run_command' helper for shelling out. The run_command helper was removed in Chef Infra Client 13.
|
817
817
|
StyleGuide: '#chefdeprecationsusesruncommandhelper'
|
818
818
|
Enabled: true
|
@@ -821,7 +821,7 @@ ChefDeprecations/UsesRunCommandHelper:
|
|
821
821
|
- '**/metadata.rb'
|
822
822
|
- 'Rakefile'
|
823
823
|
|
824
|
-
|
824
|
+
Chef/Deprecations/ChefHandlerUsesSupports:
|
825
825
|
Description: Use the type property instead of the deprecated supports property in the chef_handler resource. The supports property was removed in chef_handler cookbook version 3.0 (June 2017) and Chef Infra Client 14.0.
|
826
826
|
StyleGuide: '#chefdeprecationschefhandlerusessupports'
|
827
827
|
Enabled: true
|
@@ -829,7 +829,7 @@ ChefDeprecations/ChefHandlerUsesSupports:
|
|
829
829
|
Exclude:
|
830
830
|
- '**/metadata.rb'
|
831
831
|
|
832
|
-
|
832
|
+
Chef/Deprecations/DeprecatedYumRepositoryProperties:
|
833
833
|
Description: With the release of Chef Infra Client 12.14 and the yum cookbook 3.0 several properties in the yum_repository resource were renamed. url -> baseurl, keyurl -> gpgkey, and mirrorexpire -> mirror_expire.
|
834
834
|
StyleGuide: '#chefdeprecationsdeprecatedyumrepositoryproperties'
|
835
835
|
Enabled: true
|
@@ -837,7 +837,7 @@ ChefDeprecations/DeprecatedYumRepositoryProperties:
|
|
837
837
|
Exclude:
|
838
838
|
- '**/metadata.rb'
|
839
839
|
|
840
|
-
|
840
|
+
Chef/Deprecations/EOLAuditModeUsage:
|
841
841
|
Description: The beta Audit Mode feature in Chef Infra Client was removed in Chef Infra Client 15.0. Users should instead use InSpec and the audit cookbook. See https://www.inspec.io/ for more informmation.
|
842
842
|
StyleGuide: '#chefdeprecationseolauditmodeusage'
|
843
843
|
Enabled: true
|
@@ -845,7 +845,7 @@ ChefDeprecations/EOLAuditModeUsage:
|
|
845
845
|
Exclude:
|
846
846
|
- '**/metadata.rb'
|
847
847
|
|
848
|
-
|
848
|
+
Chef/Deprecations/ResourceInheritsFromCompatResource:
|
849
849
|
Description: HWRP style resource should inherit from the 'Chef::Resource' class and not the 'ChefCompat::Resource' class from the deprecated compat_resource cookbook.
|
850
850
|
StyleGuide: '#chefdeprecationsresourceinheritsfromcompatresource'
|
851
851
|
Enabled: true
|
@@ -853,7 +853,7 @@ ChefDeprecations/ResourceInheritsFromCompatResource:
|
|
853
853
|
Include:
|
854
854
|
- '**/libraries/*.rb'
|
855
855
|
|
856
|
-
|
856
|
+
Chef/Deprecations/VerifyPropertyUsesFileExpansion:
|
857
857
|
Description: Use the 'path' variable in the verify property and not the 'file' variable which was removed in Chef Infra Client 13.
|
858
858
|
StyleGuide: '#chefdeprecationsverifypropertyusesfileexpansion'
|
859
859
|
Enabled: true
|
@@ -861,13 +861,13 @@ ChefDeprecations/VerifyPropertyUsesFileExpansion:
|
|
861
861
|
Exclude:
|
862
862
|
- '**/metadata.rb'
|
863
863
|
|
864
|
-
|
864
|
+
Chef/Deprecations/PoiseArchiveUsage:
|
865
865
|
Description: The poise_archive resource in the deprecated poise-archive should be replaced with the archive_file resource found in Chef Infra Client 15+.
|
866
866
|
StyleGuide: '#chefdeprecationspoisearchiveusage'
|
867
867
|
Enabled: true
|
868
868
|
VersionAdded: '5.11.0'
|
869
869
|
|
870
|
-
|
870
|
+
Chef/Deprecations/PartialSearchHelperUsage:
|
871
871
|
Description: Legacy partial_search usage should be updated to use :filter_result in the search helper instead.
|
872
872
|
StyleGuide: '#chefdeprecationspartialsearchhelperusage'
|
873
873
|
Enabled: true
|
@@ -875,7 +875,7 @@ ChefDeprecations/PartialSearchHelperUsage:
|
|
875
875
|
Exclude:
|
876
876
|
- '**/metadata.rb'
|
877
877
|
|
878
|
-
|
878
|
+
Chef/Deprecations/SearchUsesPositionalParameters:
|
879
879
|
Description: Don't use deprecated positional parameters in cookbook search queries.
|
880
880
|
StyleGuide: '#chefdeprecationssearchusespositionalparameters'
|
881
881
|
Enabled: true
|
@@ -883,7 +883,7 @@ ChefDeprecations/SearchUsesPositionalParameters:
|
|
883
883
|
Exclude:
|
884
884
|
- '**/metadata.rb'
|
885
885
|
|
886
|
-
|
886
|
+
Chef/Deprecations/PartialSearchClassUsage:
|
887
887
|
Description: Legacy Chef::PartialSearch class usage should be updated to use the search helper instead with the filter_result key.
|
888
888
|
StyleGuide: '#chefdeprecationspartialsearchclassusage'
|
889
889
|
Enabled: true
|
@@ -891,7 +891,7 @@ ChefDeprecations/PartialSearchClassUsage:
|
|
891
891
|
Exclude:
|
892
892
|
- '**/metadata.rb'
|
893
893
|
|
894
|
-
|
894
|
+
Chef/Deprecations/Cheffile:
|
895
895
|
Description: The Libarian-Chef depsolving project is no longer maintained and should not be used for cookbook depsolving. Consider using Policyfiles instead.
|
896
896
|
StyleGuide: '#chefdeprecationscheffile'
|
897
897
|
Enabled: true
|
@@ -899,7 +899,7 @@ ChefDeprecations/Cheffile:
|
|
899
899
|
Include:
|
900
900
|
- '**/Cheffile'
|
901
901
|
|
902
|
-
|
902
|
+
Chef/Deprecations/LegacyNotifySyntax:
|
903
903
|
Description: Use the new-style notification syntax which allows you to notify resources defined later in a recipe or resource.
|
904
904
|
StyleGuide: '#chefdeprecationslegacynotifysyntax'
|
905
905
|
Enabled: true
|
@@ -907,7 +907,7 @@ ChefDeprecations/LegacyNotifySyntax:
|
|
907
907
|
Exclude:
|
908
908
|
- '**/metadata.rb'
|
909
909
|
|
910
|
-
|
910
|
+
Chef/Deprecations/NodeSetWithoutLevel:
|
911
911
|
Description: When setting a node attribute in Chef Infra Client 11 and later you must specify the precedence level.
|
912
912
|
StyleGuide: '#chefdeprecationsnodesetwithoutlevel'
|
913
913
|
Enabled: true
|
@@ -916,7 +916,7 @@ ChefDeprecations/NodeSetWithoutLevel:
|
|
916
916
|
- '**/metadata.rb'
|
917
917
|
- '**/attributes/*.rb'
|
918
918
|
|
919
|
-
|
919
|
+
Chef/Deprecations/ChefRewind:
|
920
920
|
Description: Use delete_resource / edit_resource instead of functionality in the deprecated chef-rewind gem
|
921
921
|
StyleGuide: '#chefdeprecationschefrewind'
|
922
922
|
Enabled: true
|
@@ -925,7 +925,7 @@ ChefDeprecations/ChefRewind:
|
|
925
925
|
- '**/metadata.rb'
|
926
926
|
- '**/attributes/*.rb'
|
927
927
|
|
928
|
-
|
928
|
+
Chef/Deprecations/RubyBlockCreateAction:
|
929
929
|
Description: Use the :run action in the ruby_block resource instead of the deprecated :create action
|
930
930
|
StyleGuide: '#chefdeprecationsrubyblockcreateaction'
|
931
931
|
Enabled: true
|
@@ -935,7 +935,7 @@ ChefDeprecations/RubyBlockCreateAction:
|
|
935
935
|
- '**/attributes/*.rb'
|
936
936
|
- '**/Berksfile'
|
937
937
|
|
938
|
-
|
938
|
+
Chef/Deprecations/DeprecatedPlatformMethods:
|
939
939
|
Description: Use provider_for_action or provides instead of the deprecated Chef::Platform methods in resources.
|
940
940
|
StyleGuide: '#chefdeprecationsdeprecatedplatformmethods'
|
941
941
|
Enabled: true
|
@@ -946,7 +946,7 @@ ChefDeprecations/DeprecatedPlatformMethods:
|
|
946
946
|
- '**/resources/*.rb'
|
947
947
|
- '**/providers/*.rb'
|
948
948
|
|
949
|
-
|
949
|
+
Chef/Deprecations/DeprecatedChefSpecPlatform:
|
950
950
|
Description: Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3
|
951
951
|
StyleGuide: '#chefdeprecationsdeprecatedchefspecplatform'
|
952
952
|
Enabled: true
|
@@ -954,7 +954,7 @@ ChefDeprecations/DeprecatedChefSpecPlatform:
|
|
954
954
|
Include:
|
955
955
|
- '**/spec/**/*.rb'
|
956
956
|
|
957
|
-
|
957
|
+
Chef/Deprecations/WindowsFeatureServermanagercmd:
|
958
958
|
Description: The `windows_feature` resource no longer supports setting the `install_method` to `:servermanagercmd`. `:windows_feature_dism` or `:windows_feature_powershell` should be used instead.
|
959
959
|
StyleGuide: '#chefdeprecationswindowsfeatureservermanagercmd'
|
960
960
|
Enabled: true
|
@@ -964,7 +964,7 @@ ChefDeprecations/WindowsFeatureServermanagercmd:
|
|
964
964
|
- '**/attributes/*.rb'
|
965
965
|
- '**/Berksfile'
|
966
966
|
|
967
|
-
|
967
|
+
Chef/Deprecations/DeprecatedWindowsVersionCheck:
|
968
968
|
Description: Don't use the deprecated older_than_win_2012_or_8? helper. Windows versions before 2012 and 8 are now end of life and this helper will always return false.
|
969
969
|
StyleGuide: '#chefdeprecationsdeprecatedwindowsversioncheck'
|
970
970
|
Enabled: true
|
@@ -973,7 +973,7 @@ ChefDeprecations/DeprecatedWindowsVersionCheck:
|
|
973
973
|
- '**/metadata.rb'
|
974
974
|
- '**/Berksfile'
|
975
975
|
|
976
|
-
|
976
|
+
Chef/Deprecations/ChefWindowsPlatformHelper:
|
977
977
|
Description: Use `platform?('windows')` instead of the legacy `Chef::Platform.windows?` helper.
|
978
978
|
StyleGuide: '#chefdeprecationschefwindowsplatformhelper'
|
979
979
|
Enabled: true
|
@@ -982,7 +982,7 @@ ChefDeprecations/ChefWindowsPlatformHelper:
|
|
982
982
|
- '**/metadata.rb'
|
983
983
|
- '**/Berksfile'
|
984
984
|
|
985
|
-
|
985
|
+
Chef/Deprecations/LogResourceNotifications:
|
986
986
|
Description: In Chef Infra Client 16 the log resource no longer notifies when logging so notifications should not be triggered from log resources. Use the notify_group resource instead to aggregate notifications.
|
987
987
|
StyleGuide: '#chefdeprecationslogresourcenotifications'
|
988
988
|
Enabled: true
|
@@ -991,7 +991,7 @@ ChefDeprecations/LogResourceNotifications:
|
|
991
991
|
- '**/metadata.rb'
|
992
992
|
- '**/Berksfile'
|
993
993
|
|
994
|
-
|
994
|
+
Chef/Deprecations/HWRPWithoutProvides:
|
995
995
|
Description: In Chef Infra Client 16 and later a legacy HWRP resource must use `provides` to define how the resource is called in recipes or other resources. To maintain compatibility with Chef Infra Client < 16 use both `resource_name` and `provides`.
|
996
996
|
StyleGuide: '#chefdeprecationsresourcewithoutnameorprovides'
|
997
997
|
Enabled: true
|
@@ -1000,7 +1000,7 @@ ChefDeprecations/HWRPWithoutProvides:
|
|
1000
1000
|
Include:
|
1001
1001
|
- '**/libraries/*.rb'
|
1002
1002
|
|
1003
|
-
|
1003
|
+
Chef/Deprecations/WindowsVersionHelpers:
|
1004
1004
|
Description: Use node['platform_version'] data instead of the Windows::VersionHelper helper from the Windows cookbook.
|
1005
1005
|
StyleGuide: '#chefdeprecationswindowsversionhelpers'
|
1006
1006
|
Enabled: true
|
@@ -1009,7 +1009,7 @@ ChefDeprecations/WindowsVersionHelpers:
|
|
1009
1009
|
- '**/metadata.rb'
|
1010
1010
|
- '**/Berksfile'
|
1011
1011
|
|
1012
|
-
|
1012
|
+
Chef/Deprecations/PowershellCookbookHelpers:
|
1013
1013
|
Description: Use node['powershell']['version'] or the new powershell_version helper available in Chef Infra Client 16+ instead of the deprecated PowerShell cookbook helpers.
|
1014
1014
|
StyleGuide: '#chefdeprecationspowershellcookbookhelpers'
|
1015
1015
|
Enabled: true
|
@@ -1018,7 +1018,7 @@ ChefDeprecations/PowershellCookbookHelpers:
|
|
1018
1018
|
- '**/metadata.rb'
|
1019
1019
|
- '**/Berksfile'
|
1020
1020
|
|
1021
|
-
|
1021
|
+
Chef/Deprecations/DeprecatedShelloutMethods:
|
1022
1022
|
Description: Many legacy specialized shell_out methods were replaced in Chef Infra Client 14.3 and removed in Chef Infra Client 15. Use shell_out and any additional options if necessary.
|
1023
1023
|
StyleGuide: '#chefdeprecationsdeprecatedshelloutmethods'
|
1024
1024
|
Enabled: true
|
@@ -1028,7 +1028,7 @@ ChefDeprecations/DeprecatedShelloutMethods:
|
|
1028
1028
|
- '**/attributes/*.rb'
|
1029
1029
|
- '**/Berksfile'
|
1030
1030
|
|
1031
|
-
|
1031
|
+
Chef/Deprecations/Ruby27KeywordArgumentWarnings:
|
1032
1032
|
Description: Pass options to shell_out helpers without the brackets to avoid Ruby 2.7 deprecation warnings.
|
1033
1033
|
StyleGuide: '#chefdeprecationsruby27keywordargumentwarnings'
|
1034
1034
|
Enabled: true
|
@@ -1037,7 +1037,7 @@ ChefDeprecations/Ruby27KeywordArgumentWarnings:
|
|
1037
1037
|
- '**/metadata.rb'
|
1038
1038
|
- '**/Berksfile'
|
1039
1039
|
|
1040
|
-
|
1040
|
+
Chef/Deprecations/ResourceUsesOnlyResourceName:
|
1041
1041
|
Description: Starting with Chef Infra Client 16, using `resource_name` without also using `provides` will result in resource failures. Use `provides` to change the name of the resource instead and omit `resource_name` entirely if it matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME.
|
1042
1042
|
StyleGuide: '#chefdeprecationsresourceusesonlyresourcename'
|
1043
1043
|
Enabled: true
|
@@ -1046,7 +1046,7 @@ ChefDeprecations/ResourceUsesOnlyResourceName:
|
|
1046
1046
|
- '**/libraries/*.rb'
|
1047
1047
|
- '**/resources/*.rb'
|
1048
1048
|
|
1049
|
-
|
1049
|
+
Chef/Deprecations/ChefDKGenerators:
|
1050
1050
|
Description: Chef Workstation 0.8 and later renamed the ChefDK module used when writing custom cookbook generators from ChefDK to ChefCLI. For compatibility with the latest Chef Workstation releases you'll need to reference the new class names.
|
1051
1051
|
StyleGuide: '#chefdeprecationschefdkgenerators'
|
1052
1052
|
Enabled: true
|
@@ -1055,7 +1055,7 @@ ChefDeprecations/ChefDKGenerators:
|
|
1055
1055
|
- '**/metadata.rb'
|
1056
1056
|
- '**/Berksfile'
|
1057
1057
|
|
1058
|
-
|
1058
|
+
Chef/Deprecations/ChefHandlerRecipe:
|
1059
1059
|
Description: There is no need to include the empty and deprecated chef_handler::default recipe in order to use the chef_handler resource.
|
1060
1060
|
StyleGuide: '#chefdeprecationschefhandlerrecipe'
|
1061
1061
|
Enabled: true
|
@@ -1064,7 +1064,7 @@ ChefDeprecations/ChefHandlerRecipe:
|
|
1064
1064
|
- '**/metadata.rb'
|
1065
1065
|
- '**/Berksfile'
|
1066
1066
|
|
1067
|
-
|
1067
|
+
Chef/Deprecations/UseAutomaticResourceName:
|
1068
1068
|
Description: The use_automatic_resource_name method was removed in Chef Infra Client 16. The resource name/provides should be set explicitly instead.
|
1069
1069
|
StyleGuide: '#chefdeprecationsuseautomaticresourcename'
|
1070
1070
|
Enabled: true
|
@@ -1073,7 +1073,7 @@ ChefDeprecations/UseAutomaticResourceName:
|
|
1073
1073
|
- '**/libraries/*.rb'
|
1074
1074
|
- '**/resources/*.rb'
|
1075
1075
|
|
1076
|
-
|
1076
|
+
Chef/Deprecations/MacosUserdefaultsGlobalProperty:
|
1077
1077
|
Description: The `global` property in the macos_userdefaults resource was deprecated in Chef Infra Client 16.3. Omitting the `domain` property will now set global defaults.
|
1078
1078
|
StyleGuide: '#chefdeprecationsmacosuserdefaultsglobalproperty'
|
1079
1079
|
Enabled: true
|
@@ -1082,7 +1082,7 @@ ChefDeprecations/MacosUserdefaultsGlobalProperty:
|
|
1082
1082
|
- '**/metadata.rb'
|
1083
1083
|
- '**/Berksfile'
|
1084
1084
|
|
1085
|
-
|
1085
|
+
Chef/Deprecations/CookbooksDependsOnSelf:
|
1086
1086
|
Description: A cookbook cannot depend on itself in Chef Infra Client 13 or later.
|
1087
1087
|
StyleGuide: '#chefdeprecationscookbooksdependonself'
|
1088
1088
|
Enabled: true
|
@@ -1091,7 +1091,7 @@ ChefDeprecations/CookbooksDependsOnSelf:
|
|
1091
1091
|
Include:
|
1092
1092
|
- '**/metadata.rb'
|
1093
1093
|
|
1094
|
-
|
1094
|
+
Chef/Deprecations/ChefShellout:
|
1095
1095
|
Description: Don't use deprecated Chef::ShellOut which was removed in Chef Infra Client 13. Use Mixlib::ShellOut instead, which behaves identically.
|
1096
1096
|
StyleGuide: '#chefdeprecationschefshellout'
|
1097
1097
|
Enabled: true
|
@@ -1101,7 +1101,7 @@ ChefDeprecations/ChefShellout:
|
|
1101
1101
|
- '**/attributes/*.rb'
|
1102
1102
|
- '**/Berksfile'
|
1103
1103
|
|
1104
|
-
|
1104
|
+
Chef/Deprecations/ExecutePathProperty:
|
1105
1105
|
Description: In Chef Infra Client 13 and later you must set path env vars in `execute` resources using the `environment` property not the legacy `path` property.
|
1106
1106
|
StyleGuide: '#chefdeprecationsexecutepathproperty'
|
1107
1107
|
Enabled: true
|
@@ -1111,7 +1111,7 @@ ChefDeprecations/ExecutePathProperty:
|
|
1111
1111
|
- '**/attributes/*.rb'
|
1112
1112
|
- '**/Berksfile'
|
1113
1113
|
|
1114
|
-
|
1114
|
+
Chef/Deprecations/ExecuteRelativeCreatesWithoutCwd:
|
1115
1115
|
Description: In Chef Infra Client 13 and later you must either specify an absolute path when using the `execute` resource's `creates` property or also use the `cwd` property.
|
1116
1116
|
StyleGuide: '#chefdeprecationsexecuterelativecreateswithoutcwd'
|
1117
1117
|
Enabled: true
|
@@ -1121,7 +1121,7 @@ ChefDeprecations/ExecuteRelativeCreatesWithoutCwd:
|
|
1121
1121
|
- '**/attributes/*.rb'
|
1122
1122
|
- '**/Berksfile'
|
1123
1123
|
|
1124
|
-
|
1124
|
+
Chef/Deprecations/WindowsPackageInstallerTypeString:
|
1125
1125
|
Description: In Chef Infra Client 13 and later the `windows_package` resource's `installer_type` property must be a symbol.
|
1126
1126
|
StyleGuide: '#chefdeprecationswindowspackageinstallertypestring'
|
1127
1127
|
Enabled: true
|
@@ -1131,20 +1131,20 @@ ChefDeprecations/WindowsPackageInstallerTypeString:
|
|
1131
1131
|
- '**/attributes/*.rb'
|
1132
1132
|
- '**/Berksfile'
|
1133
1133
|
|
1134
|
-
|
1134
|
+
Chef/Deprecations/UseYamlDump:
|
1135
1135
|
Description: Chef Infra Client 16.5 introduced performance enhancements to Ruby library loading. Due to the underlying implementation of Ruby's `.to_yaml` method, it does not automatically load the `yaml` library and `YAML.dump()` should be used instead to properly load the `yaml` library.
|
1136
1136
|
StyleGuide: '#chefdeprecationsuseyamldump'
|
1137
1137
|
Enabled: true
|
1138
1138
|
VersionAdded: '6.21.0'
|
1139
1139
|
|
1140
1140
|
###############################
|
1141
|
-
#
|
1141
|
+
# Chef/Modernize: Cleaning up legacy code and using new built-in resources
|
1142
1142
|
###############################
|
1143
1143
|
|
1144
|
-
|
1144
|
+
Chef/Modernize:
|
1145
1145
|
StyleGuideBaseURL: https://github.com/chef/cookstyle/blob/master/docs/cops_chefmodernize.md
|
1146
1146
|
|
1147
|
-
|
1147
|
+
Chef/Modernize/LegacyBerksfileSource:
|
1148
1148
|
Description: Do not use legacy Berksfile community sources. Use Chef Supermarket instead.
|
1149
1149
|
StyleGuide: '#chefmodernizelegacyberksfilesource'
|
1150
1150
|
Enabled: true
|
@@ -1152,7 +1152,7 @@ ChefModernize/LegacyBerksfileSource:
|
|
1152
1152
|
Include:
|
1153
1153
|
- '**/Berksfile'
|
1154
1154
|
|
1155
|
-
|
1155
|
+
Chef/Modernize/WhyRunSupportedTrue:
|
1156
1156
|
Description: whyrun_supported? no longer needs to be set to true as it is the default in Chef 13+
|
1157
1157
|
StyleGuide: '#chefmodernizewhyrunsupportedtrue'
|
1158
1158
|
Enabled: true
|
@@ -1162,7 +1162,7 @@ ChefModernize/WhyRunSupportedTrue:
|
|
1162
1162
|
- '**/providers/*.rb'
|
1163
1163
|
- '**/libraries/*.rb'
|
1164
1164
|
|
1165
|
-
|
1165
|
+
Chef/Modernize/UnnecessaryDependsChef14:
|
1166
1166
|
Description: Don't depend on cookbooks made obsolete by Chef Infra Client 14+. These community cookbooks contain resources that are now included in Chef Infra Client itself.
|
1167
1167
|
StyleGuide: '#chefmodernizeunnecessarydependschef14'
|
1168
1168
|
Enabled: true
|
@@ -1170,7 +1170,7 @@ ChefModernize/UnnecessaryDependsChef14:
|
|
1170
1170
|
Include:
|
1171
1171
|
- '**/metadata.rb'
|
1172
1172
|
|
1173
|
-
|
1173
|
+
Chef/Modernize/RespondToInMetadata:
|
1174
1174
|
Description: It is no longer necessary to use respond_to? in metadata.rb in Chef Infra Client 12.15 and later
|
1175
1175
|
StyleGuide: '#chefmodernizerespondtoinmetadata'
|
1176
1176
|
Enabled: true
|
@@ -1178,7 +1178,7 @@ ChefModernize/RespondToInMetadata:
|
|
1178
1178
|
Include:
|
1179
1179
|
- '**/metadata.rb'
|
1180
1180
|
|
1181
|
-
|
1181
|
+
Chef/Modernize/RespondToResourceName:
|
1182
1182
|
Description: respond_to?(:resource_name) in resources is no longer necessary in Chef Infra Client 12.5+
|
1183
1183
|
StyleGuide: '#chefmodernizerespondtoresourcename'
|
1184
1184
|
Enabled: true
|
@@ -1187,7 +1187,7 @@ ChefModernize/RespondToResourceName:
|
|
1187
1187
|
- '**/resources/*.rb'
|
1188
1188
|
- '**/libraries/*.rb'
|
1189
1189
|
|
1190
|
-
|
1190
|
+
Chef/Modernize/RespondToProvides:
|
1191
1191
|
Description: respond_to?(:provides) in resources is no longer necessary in Chef Infra Client 12+
|
1192
1192
|
StyleGuide: '#chefmodernizerespondtoprovides'
|
1193
1193
|
Enabled: true
|
@@ -1196,7 +1196,7 @@ ChefModernize/RespondToProvides:
|
|
1196
1196
|
- '**/providers/*.rb'
|
1197
1197
|
- '**/libraries/*.rb'
|
1198
1198
|
|
1199
|
-
|
1199
|
+
Chef/Modernize/SetOrReturnInResources:
|
1200
1200
|
Description: Do not use set_or_return within a method to define a property for a resource. Use the property method instead, which supports validation, reporting, and documentation functionality.
|
1201
1201
|
StyleGuide: '#chefmodernizesetorreturninresources'
|
1202
1202
|
Enabled: true
|
@@ -1205,7 +1205,7 @@ ChefModernize/SetOrReturnInResources:
|
|
1205
1205
|
- '**/resources/*.rb'
|
1206
1206
|
- '**/libraries/*.rb'
|
1207
1207
|
|
1208
|
-
|
1208
|
+
Chef/Modernize/CustomResourceWithAttributes:
|
1209
1209
|
Description: Custom Resources should contain properties not attributes.
|
1210
1210
|
StyleGuide: '#chefmodernizecustomresourcewithattributes'
|
1211
1211
|
Enabled: true
|
@@ -1213,7 +1213,7 @@ ChefModernize/CustomResourceWithAttributes:
|
|
1213
1213
|
Include:
|
1214
1214
|
- '**/resources/*.rb'
|
1215
1215
|
|
1216
|
-
|
1216
|
+
Chef/Modernize/IncludingAptDefaultRecipe:
|
1217
1217
|
Description: Do not include the Apt default recipe to update package cache. Instead use the apt_update resource, which is built into Chef Infra Client 12.7 and later.
|
1218
1218
|
StyleGuide: '#chefmodernizeincludingaptdefaultrecipe'
|
1219
1219
|
Enabled: true
|
@@ -1221,7 +1221,7 @@ ChefModernize/IncludingAptDefaultRecipe:
|
|
1221
1221
|
Exclude:
|
1222
1222
|
- '**/metadata.rb'
|
1223
1223
|
|
1224
|
-
|
1224
|
+
Chef/Modernize/IncludingWindowsDefaultRecipe:
|
1225
1225
|
Description: Do not include the Windows default recipe, which only installs win32 gems already included in Chef Infra Client
|
1226
1226
|
StyleGuide: '#chefmodernizeincludingwindowsdefaultrecipe'
|
1227
1227
|
Enabled: true
|
@@ -1229,7 +1229,7 @@ ChefModernize/IncludingWindowsDefaultRecipe:
|
|
1229
1229
|
Exclude:
|
1230
1230
|
- '**/metadata.rb'
|
1231
1231
|
|
1232
|
-
|
1232
|
+
Chef/Modernize/DefinesChefSpecMatchers:
|
1233
1233
|
Description: ChefSpec matchers are now auto generated by ChefSpec 7.1+ and do not need to be defined in a cookbook
|
1234
1234
|
StyleGuide: '#chefmodernizedefineschefspecmatchers'
|
1235
1235
|
Enabled: true
|
@@ -1237,7 +1237,7 @@ ChefModernize/DefinesChefSpecMatchers:
|
|
1237
1237
|
Include:
|
1238
1238
|
- '**/libraries/*.rb'
|
1239
1239
|
|
1240
|
-
|
1240
|
+
Chef/Modernize/ExecuteAptUpdate:
|
1241
1241
|
Description: Use the apt_update resource instead of the execute resource to run an apt-get update package cache update
|
1242
1242
|
StyleGuide: '#chefmodernizeexecuteaptupdate'
|
1243
1243
|
Enabled: true
|
@@ -1245,7 +1245,7 @@ ChefModernize/ExecuteAptUpdate:
|
|
1245
1245
|
Exclude:
|
1246
1246
|
- '**/metadata.rb'
|
1247
1247
|
|
1248
|
-
|
1248
|
+
Chef/Modernize/MinitestHandlerUsage:
|
1249
1249
|
Description: Use Chef InSpec for testing instead of the Minitest Handler cookbook pattern.
|
1250
1250
|
StyleGuide: '#chefmodernizeminitesthandlerusage'
|
1251
1251
|
Enabled: true
|
@@ -1253,7 +1253,7 @@ ChefModernize/MinitestHandlerUsage:
|
|
1253
1253
|
Include:
|
1254
1254
|
- '**/metadata.rb'
|
1255
1255
|
|
1256
|
-
|
1256
|
+
Chef/Modernize/IncludingMixinShelloutInResources:
|
1257
1257
|
Description: There is no need to include Chef::Mixin::ShellOut or Chef::Mixin::PowershellOut in resources or providers as this is already done by Chef Infra Client 12.4+.
|
1258
1258
|
StyleGuide: '#chefmodernizeincludingmixinshelloutinresources'
|
1259
1259
|
Enabled: true
|
@@ -1263,7 +1263,7 @@ ChefModernize/IncludingMixinShelloutInResources:
|
|
1263
1263
|
- '**/providers/*.rb'
|
1264
1264
|
- '**/libraries/*.rb'
|
1265
1265
|
|
1266
|
-
|
1266
|
+
Chef/Modernize/UseBuildEssentialResource:
|
1267
1267
|
Description: Use the build_essential resource instead of the legacy build-essential recipe. This resource ships in the build-essential cookbook v5.0+ and is built into Chef Infra Client 14+
|
1268
1268
|
StyleGuide: '#chefmodernizeusebuildessentialresource'
|
1269
1269
|
Enabled: true
|
@@ -1271,7 +1271,7 @@ ChefModernize/UseBuildEssentialResource:
|
|
1271
1271
|
Exclude:
|
1272
1272
|
- '**/metadata.rb'
|
1273
1273
|
|
1274
|
-
|
1274
|
+
Chef/Modernize/WindowsZipfileUsage:
|
1275
1275
|
Description: Use the archive_file resource built into Chef Infra Client 15+ instead of the windows_zipfile from the Windows cookbook
|
1276
1276
|
StyleGuide: '#chefmodernizewindowszipfileusage'
|
1277
1277
|
Enabled: true
|
@@ -1279,7 +1279,7 @@ ChefModernize/WindowsZipfileUsage:
|
|
1279
1279
|
Exclude:
|
1280
1280
|
- '**/metadata.rb'
|
1281
1281
|
|
1282
|
-
|
1282
|
+
Chef/Modernize/SevenZipArchiveResource:
|
1283
1283
|
Description: Use the archive_file resource built into Chef Infra Client 15+ instead of the seven_zip_archive
|
1284
1284
|
StyleGuide: '#chefmodernizesevenziparchiveresource'
|
1285
1285
|
Enabled: true
|
@@ -1287,7 +1287,7 @@ ChefModernize/SevenZipArchiveResource:
|
|
1287
1287
|
Exclude:
|
1288
1288
|
- '**/metadata.rb'
|
1289
1289
|
|
1290
|
-
|
1290
|
+
Chef/Modernize/LibarchiveFileResource:
|
1291
1291
|
Description: Use the archive_file resource built into Chef Infra Client 15+ instead of the libarchive file resource
|
1292
1292
|
StyleGuide: '#chefmodernizelibarchivefileresource'
|
1293
1293
|
Enabled: true
|
@@ -1295,7 +1295,7 @@ ChefModernize/LibarchiveFileResource:
|
|
1295
1295
|
Exclude:
|
1296
1296
|
- '**/metadata.rb'
|
1297
1297
|
|
1298
|
-
|
1298
|
+
Chef/Modernize/PowershellScriptExpandArchive:
|
1299
1299
|
Description: Use the archive_file resource built into Chef Infra Client 15+ instead of using Expand-Archive in a powershell_script resource
|
1300
1300
|
StyleGuide: '#chefmodernizepowershellscriptexpandarchive'
|
1301
1301
|
Enabled: true
|
@@ -1303,7 +1303,7 @@ ChefModernize/PowershellScriptExpandArchive:
|
|
1303
1303
|
Exclude:
|
1304
1304
|
- '**/metadata.rb'
|
1305
1305
|
|
1306
|
-
|
1306
|
+
Chef/Modernize/PowershellInstallPackage:
|
1307
1307
|
Description: Use the package resource built into Chef Infra Client instead of using Install-Package in a powershell_script resource
|
1308
1308
|
StyleGuide: '#chefmodernizepowershellinstallpackage'
|
1309
1309
|
Enabled: true
|
@@ -1311,7 +1311,7 @@ ChefModernize/PowershellInstallPackage:
|
|
1311
1311
|
Exclude:
|
1312
1312
|
- '**/metadata.rb'
|
1313
1313
|
|
1314
|
-
|
1314
|
+
Chef/Modernize/PowershellInstallWindowsFeature:
|
1315
1315
|
Description: Use the windows_feature resource built into Chef Infra Client 13+ instead of using Install-WindowsFeature or Add-WindowsFeature in a powershell_script resource
|
1316
1316
|
StyleGuide: '#chefmodernizepowershellinstallwindowsfeature'
|
1317
1317
|
Enabled: true
|
@@ -1319,7 +1319,7 @@ ChefModernize/PowershellInstallWindowsFeature:
|
|
1319
1319
|
Exclude:
|
1320
1320
|
- '**/metadata.rb'
|
1321
1321
|
|
1322
|
-
|
1322
|
+
Chef/Modernize/ShellOutToChocolatey:
|
1323
1323
|
Description: Use the Chocolatey resources built into Chef Infra Client instead of shelling out to the choco command
|
1324
1324
|
StyleGuide: '#chefmodernizeshellouttochocolatey'
|
1325
1325
|
Enabled: true
|
@@ -1327,7 +1327,7 @@ ChefModernize/ShellOutToChocolatey:
|
|
1327
1327
|
Exclude:
|
1328
1328
|
- '**/metadata.rb'
|
1329
1329
|
|
1330
|
-
|
1330
|
+
Chef/Modernize/CronManageResource:
|
1331
1331
|
Description: The cron_manage resource was renamed to cron_access in the 6.1 release of the cron cookbook and later shipped in Chef Infra Client 14.4. The new resource name should be used.
|
1332
1332
|
StyleGuide: '#chefmodernizecronmanageresource'
|
1333
1333
|
Enabled: true
|
@@ -1335,7 +1335,7 @@ ChefModernize/CronManageResource:
|
|
1335
1335
|
Exclude:
|
1336
1336
|
- '**/metadata.rb'
|
1337
1337
|
|
1338
|
-
|
1338
|
+
Chef/Modernize/UsesZypperRepo:
|
1339
1339
|
Description: The zypper_repo resource was renamed zypper_repository when it was added to Chef Infra Client 13.3.
|
1340
1340
|
StyleGuide: '#chefmodernizeuseszypperrepo'
|
1341
1341
|
Enabled: true
|
@@ -1343,7 +1343,7 @@ ChefModernize/UsesZypperRepo:
|
|
1343
1343
|
Exclude:
|
1344
1344
|
- '**/metadata.rb'
|
1345
1345
|
|
1346
|
-
|
1346
|
+
Chef/Modernize/DependsOnZypperCookbook:
|
1347
1347
|
Description: Don't include the zypper cookbook as the zypper_repository resource is built into Chef Infra Client 13.3+
|
1348
1348
|
StyleGuide: '#chefmodernizedependsonzyppercookbook'
|
1349
1349
|
Enabled: true
|
@@ -1351,7 +1351,7 @@ ChefModernize/DependsOnZypperCookbook:
|
|
1351
1351
|
Exclude:
|
1352
1352
|
- '**/metadata.rb'
|
1353
1353
|
|
1354
|
-
|
1354
|
+
Chef/Modernize/ExecuteTzUtil:
|
1355
1355
|
Description: Use the timezone resource included in Chef Infra Client 14.6+ instead of shelling out to tzutil
|
1356
1356
|
StyleGuide: '#chefmodernizeexecutetzutil'
|
1357
1357
|
Enabled: true
|
@@ -1359,7 +1359,7 @@ ChefModernize/ExecuteTzUtil:
|
|
1359
1359
|
Exclude:
|
1360
1360
|
- '**/metadata.rb'
|
1361
1361
|
|
1362
|
-
|
1362
|
+
Chef/Modernize/OpensslRsaKeyResource:
|
1363
1363
|
Description: The openssl_rsa_key resource was renamed to openssl_rsa_private_key in Chef Infra Client 14.0. The new resource name should be used.
|
1364
1364
|
StyleGuide: '#chefmodernizeopensslrsakeyresource'
|
1365
1365
|
Enabled: true
|
@@ -1367,7 +1367,7 @@ ChefModernize/OpensslRsaKeyResource:
|
|
1367
1367
|
Exclude:
|
1368
1368
|
- '**/metadata.rb'
|
1369
1369
|
|
1370
|
-
|
1370
|
+
Chef/Modernize/OpensslX509Resource:
|
1371
1371
|
Description: The openssl_x509 resource was renamed to openssl_x509_certificate in Chef Infra Client 14.4. The new resource name should be used.
|
1372
1372
|
StyleGuide: '#chefmodernizeopensslx509resource'
|
1373
1373
|
Enabled: true
|
@@ -1375,7 +1375,7 @@ ChefModernize/OpensslX509Resource:
|
|
1375
1375
|
Exclude:
|
1376
1376
|
- '**/metadata.rb'
|
1377
1377
|
|
1378
|
-
|
1378
|
+
Chef/Modernize/OsxConfigProfileResource:
|
1379
1379
|
Description: The osx_config_profile resource was renamed to osx_profile. The new resource name should be used.
|
1380
1380
|
StyleGuide: '#chefmodernizeosxconfigprofileresource'
|
1381
1381
|
Enabled: true
|
@@ -1383,7 +1383,7 @@ ChefModernize/OsxConfigProfileResource:
|
|
1383
1383
|
Exclude:
|
1384
1384
|
- '**/metadata.rb'
|
1385
1385
|
|
1386
|
-
|
1386
|
+
Chef/Modernize/SysctlParamResource:
|
1387
1387
|
Description: The sysctl_param resource was renamed to sysctl when it was added to Chef Infra Client 14.0. The new resource name should be used.
|
1388
1388
|
StyleGuide: '#chefmodernizesysctlparamresource'
|
1389
1389
|
Enabled: true
|
@@ -1391,7 +1391,7 @@ ChefModernize/SysctlParamResource:
|
|
1391
1391
|
Exclude:
|
1392
1392
|
- '**/metadata.rb'
|
1393
1393
|
|
1394
|
-
|
1394
|
+
Chef/Modernize/MacOsXUserdefaults:
|
1395
1395
|
Description: The mac_os_x_userdefaults resource was renamed to macos_userdefaults when it was added to Chef Infra Client 14.0. The new resource name should be used.
|
1396
1396
|
StyleGuide: '#chefmodernizemacosxuserdefaults'
|
1397
1397
|
Enabled: true
|
@@ -1399,7 +1399,7 @@ ChefModernize/MacOsXUserdefaults:
|
|
1399
1399
|
Exclude:
|
1400
1400
|
- '**/metadata.rb'
|
1401
1401
|
|
1402
|
-
|
1402
|
+
Chef/Modernize/PowerShellGuardInterpreter:
|
1403
1403
|
Description: PowerShell is already set as the default guard interpreter for powershell_script resources in Chef Infra Client 13 and later and does not need to be specified.
|
1404
1404
|
StyleGuide: '#chefmodernizepowershellguardinterpreter'
|
1405
1405
|
Enabled: true
|
@@ -1407,7 +1407,7 @@ ChefModernize/PowerShellGuardInterpreter:
|
|
1407
1407
|
Exclude:
|
1408
1408
|
- '**/metadata.rb'
|
1409
1409
|
|
1410
|
-
|
1410
|
+
Chef/Modernize/DefaultActionFromInitialize:
|
1411
1411
|
Description: The default actions can now be specified using the `default_action` helper instead of using the @action variable in the resource provider initialize method.
|
1412
1412
|
StyleGuide: '#chefmodernizedefaultactionfrominitialize'
|
1413
1413
|
Enabled: true
|
@@ -1417,7 +1417,7 @@ ChefModernize/DefaultActionFromInitialize:
|
|
1417
1417
|
- '**/providers/*.rb'
|
1418
1418
|
- '**/libraries/*.rb'
|
1419
1419
|
|
1420
|
-
|
1420
|
+
Chef/Modernize/ResourceNameFromInitialize:
|
1421
1421
|
Description: The name of a resource can be set with the "resource_name" helper instead of using the initialize method.
|
1422
1422
|
StyleGuide: '#chefmodernizeresourcenamefrominitialize'
|
1423
1423
|
Enabled: true
|
@@ -1427,7 +1427,7 @@ ChefModernize/ResourceNameFromInitialize:
|
|
1427
1427
|
- '**/providers/*.rb'
|
1428
1428
|
- '**/libraries/*.rb'
|
1429
1429
|
|
1430
|
-
|
1430
|
+
Chef/Modernize/Definitions:
|
1431
1431
|
Description: Legacy Chef Infra definitions should be rewritten as custom resources to take full advantage of the Chef Infra feature set.
|
1432
1432
|
StyleGuide: '#chefmodernizedefinitions'
|
1433
1433
|
Enabled: true
|
@@ -1435,7 +1435,7 @@ ChefModernize/Definitions:
|
|
1435
1435
|
Include:
|
1436
1436
|
- '**/definitions/*.rb'
|
1437
1437
|
|
1438
|
-
|
1438
|
+
Chef/Modernize/IfProvidesDefaultAction:
|
1439
1439
|
Description: if defined?(default_action) is no longer necessary in Chef Infra resources as default_action shipped in Chef Infra Client 10.8.
|
1440
1440
|
StyleGuide: '#chefmodernizeifprovidesdefaultaction'
|
1441
1441
|
Enabled: true
|
@@ -1444,13 +1444,13 @@ ChefModernize/IfProvidesDefaultAction:
|
|
1444
1444
|
- '**/resources/*.rb'
|
1445
1445
|
- '**/libraries/*.rb'
|
1446
1446
|
|
1447
|
-
|
1447
|
+
Chef/Modernize/ZipfileResource:
|
1448
1448
|
Description: Use the archive_file resource built into Chef Infra Client 15+ instead of the zipfile resource from the zipfile cookbook.
|
1449
1449
|
StyleGuide: '#chefmodernizezipfileresource'
|
1450
1450
|
Enabled: true
|
1451
1451
|
VersionAdded: '5.12.0'
|
1452
1452
|
|
1453
|
-
|
1453
|
+
Chef/Modernize/UnnecessaryMixlibShelloutRequire:
|
1454
1454
|
Description: Chef Infra Client 12.4 and later include mixlib/shellout automatically in resources and providers.
|
1455
1455
|
StyleGuide: '#chefmodernizeunnecessarymixlibshelloutrequire'
|
1456
1456
|
Enabled: true
|
@@ -1459,7 +1459,7 @@ ChefModernize/UnnecessaryMixlibShelloutRequire:
|
|
1459
1459
|
- '**/resources/*.rb'
|
1460
1460
|
- '**/providers/*.rb'
|
1461
1461
|
|
1462
|
-
|
1462
|
+
Chef/Modernize/EmptyResourceInitializeMethod:
|
1463
1463
|
Description: There is no need for an empty initialize method in a resource
|
1464
1464
|
StyleGuide: '#chefmodernizeemptyresourceinitializemethod'
|
1465
1465
|
Enabled: true
|
@@ -1468,7 +1468,7 @@ ChefModernize/EmptyResourceInitializeMethod:
|
|
1468
1468
|
- '**/resources/*.rb'
|
1469
1469
|
- '**/providers/*.rb'
|
1470
1470
|
|
1471
|
-
|
1471
|
+
Chef/Modernize/ChefGemNokogiri:
|
1472
1472
|
Description: The nokogiri gem ships in Chef Infra Client 12+ and does not need to be installed before being used.
|
1473
1473
|
StyleGuide: '#chefmodernizechefgemnokogiri'
|
1474
1474
|
Enabled: true
|
@@ -1477,7 +1477,7 @@ ChefModernize/ChefGemNokogiri:
|
|
1477
1477
|
- '**/metadata.rb'
|
1478
1478
|
- '**/attributes/*.rb'
|
1479
1479
|
|
1480
|
-
|
1480
|
+
Chef/Modernize/PropertyWithNameAttribute:
|
1481
1481
|
Description: Resource property sets name_attribute not name_property
|
1482
1482
|
StyleGuide: '#chefmodernizepropertywithnameattribute'
|
1483
1483
|
Enabled: true
|
@@ -1487,7 +1487,7 @@ ChefModernize/PropertyWithNameAttribute:
|
|
1487
1487
|
- '**/resources/*.rb'
|
1488
1488
|
- '**/libraries/*.rb'
|
1489
1489
|
|
1490
|
-
|
1490
|
+
Chef/Modernize/IncludingOhaiDefaultRecipe:
|
1491
1491
|
Description: Use the ohai_plugin resource to ship custom Ohai plugins instead of using the ohai::default recipe. If you're not shipping custom Ohai plugins, then you can remove this recipe entirely.
|
1492
1492
|
StyleGuide: '#chefmodernizeincludingohaidefaultrecipe'
|
1493
1493
|
Enabled: true
|
@@ -1497,7 +1497,7 @@ ChefModernize/IncludingOhaiDefaultRecipe:
|
|
1497
1497
|
- '**/metadata.rb'
|
1498
1498
|
- '**/Berksfile'
|
1499
1499
|
|
1500
|
-
|
1500
|
+
Chef/Modernize/AllowedActionsFromInitialize:
|
1501
1501
|
Description: The allowed actions of a resource can be set with the "allowed_actions" helper instead of using the initialize method.
|
1502
1502
|
StyleGuide: '#chefmodernizeallowedactionsfrominitialize'
|
1503
1503
|
Enabled: true
|
@@ -1506,7 +1506,7 @@ ChefModernize/AllowedActionsFromInitialize:
|
|
1506
1506
|
- '**/resources/*.rb'
|
1507
1507
|
- '**/libraries/*.rb'
|
1508
1508
|
|
1509
|
-
|
1509
|
+
Chef/Modernize/FoodcriticComments:
|
1510
1510
|
Description: Remove legacy code comments that disable Foodcritic rules. These comments are no longer necessary if you've migrated from Foodcritic to Cookstyle for cookbook linting.
|
1511
1511
|
StyleGuide: '#chefmodernizefoodcriticcomments'
|
1512
1512
|
Enabled: true
|
@@ -1514,7 +1514,7 @@ ChefModernize/FoodcriticComments:
|
|
1514
1514
|
Exclude:
|
1515
1515
|
- '**/Berksfile'
|
1516
1516
|
|
1517
|
-
|
1517
|
+
Chef/Modernize/ExecuteScExe:
|
1518
1518
|
Description: Chef Infra Client 14.0 and later includes :create, :delete, and :configure actions with the full idempotency of the windows_service resource. See the windows_service documentation at https://docs.chef.io/resource_windows_service.html for additional details on creating services with the windows_service resource
|
1519
1519
|
StyleGuide: '#chefmodernizeexecutescexe'
|
1520
1520
|
Enabled: true
|
@@ -1524,7 +1524,7 @@ ChefModernize/ExecuteScExe:
|
|
1524
1524
|
- '**/attributes/*.rb'
|
1525
1525
|
- '**/Berksfile'
|
1526
1526
|
|
1527
|
-
|
1527
|
+
Chef/Modernize/WindowsScResource:
|
1528
1528
|
Description: Chef Infra Client 14.0 and later includes :create, :delete, and :configure actions without the need for the sc cookbook dependency. See the windows_service documentation at https://docs.chef.io/resource_windows_service.html for additional details.
|
1529
1529
|
StyleGuide: '#chefmodernizewindowsscresource'
|
1530
1530
|
Enabled: true
|
@@ -1534,7 +1534,7 @@ ChefModernize/WindowsScResource:
|
|
1534
1534
|
- '**/attributes/*.rb'
|
1535
1535
|
- '**/Berksfile'
|
1536
1536
|
|
1537
|
-
|
1537
|
+
Chef/Modernize/ExecuteSleep:
|
1538
1538
|
Description: Chef Infra Client 15.5 and later include a chef_sleep resource that should be used to sleep between executing resources if necessary instead of using the bash or execute resources to run the sleep command.
|
1539
1539
|
StyleGuide: '#chefmodernizeexecutesleep'
|
1540
1540
|
Enabled: true
|
@@ -1544,7 +1544,7 @@ ChefModernize/ExecuteSleep:
|
|
1544
1544
|
- '**/attributes/*.rb'
|
1545
1545
|
- '**/Berksfile'
|
1546
1546
|
|
1547
|
-
|
1547
|
+
Chef/Modernize/DslIncludeInResource:
|
1548
1548
|
Description: 'There is no need to include Chef::DSL::Recipe or Chef::DSL::IncludeRecipe classes in resources or providers as this is done automatically.'
|
1549
1549
|
StyleGuide: '#chefmodernizedslincludeinresource'
|
1550
1550
|
Enabled: true
|
@@ -1553,7 +1553,7 @@ ChefModernize/DslIncludeInResource:
|
|
1553
1553
|
- '**/resources/*.rb'
|
1554
1554
|
- '**/providers/*.rb'
|
1555
1555
|
|
1556
|
-
|
1556
|
+
Chef/Modernize/ResourceForcingCompileTime:
|
1557
1557
|
Description: The hostname, build_essential, chef_gem, and ohai_hint resources include 'compile_time' properties, which should be used to force the resources to run at compile time by setting `compile_time true`.
|
1558
1558
|
StyleGuide: '#chefmodernizeresourceforcingcompiletime'
|
1559
1559
|
Enabled: true
|
@@ -1563,7 +1563,7 @@ ChefModernize/ResourceForcingCompileTime:
|
|
1563
1563
|
- '**/attributes/*.rb'
|
1564
1564
|
- '**/Berksfile'
|
1565
1565
|
|
1566
|
-
|
1566
|
+
Chef/Modernize/ExecuteSysctl:
|
1567
1567
|
Description: Chef Infra Client 14.0 and later includes a sysctl resource that should be used to idempotently load sysctl values instead of templating files and using execute to load them.
|
1568
1568
|
StyleGuide: '#chefmodernizeexecutesysctl'
|
1569
1569
|
Enabled: true
|
@@ -1573,7 +1573,7 @@ ChefModernize/ExecuteSysctl:
|
|
1573
1573
|
- '**/attributes/*.rb'
|
1574
1574
|
- '**/Berksfile'
|
1575
1575
|
|
1576
|
-
|
1576
|
+
Chef/Modernize/SimplifyAptPpaSetup:
|
1577
1577
|
Description: The apt_repository resource allows setting up PPAs without using the full URL to ppa.launchpad.net.
|
1578
1578
|
StyleGuide: '#chefmodernizesimplifyaptppasetup'
|
1579
1579
|
Enabled: true
|
@@ -1583,7 +1583,7 @@ ChefModernize/SimplifyAptPpaSetup:
|
|
1583
1583
|
- '**/attributes/*.rb'
|
1584
1584
|
- '**/Berksfile'
|
1585
1585
|
|
1586
|
-
|
1586
|
+
Chef/Modernize/UseRequireRelative:
|
1587
1587
|
Description: Instead of using require with a File.expand_path and __FILE__ use the simpler require_relative method.
|
1588
1588
|
StyleGuide: '#chefmodernizeuserequirerelative'
|
1589
1589
|
Enabled: true
|
@@ -1593,7 +1593,7 @@ ChefModernize/UseRequireRelative:
|
|
1593
1593
|
- '**/attributes/*.rb'
|
1594
1594
|
- '**/Berksfile'
|
1595
1595
|
|
1596
|
-
|
1596
|
+
Chef/Modernize/NodeInitPackage:
|
1597
1597
|
Description: Use node['init_package'] to check for systemd instead of reading the contents of '/proc/1/comm'
|
1598
1598
|
StyleGuide: '#chefmodernizenodeinitpackage'
|
1599
1599
|
Enabled: true
|
@@ -1602,7 +1602,7 @@ ChefModernize/NodeInitPackage:
|
|
1602
1602
|
- '**/metadata.rb'
|
1603
1603
|
- '**/Berksfile'
|
1604
1604
|
|
1605
|
-
|
1605
|
+
Chef/Modernize/WindowsRegistryUAC:
|
1606
1606
|
Description: Chef Infra Client 15.0 and later includes a windows_uac resource that should be used to set Windows UAC values instead of setting registry keys directly.
|
1607
1607
|
StyleGuide: '#chefmodernizewindowsregistryuac'
|
1608
1608
|
Enabled: true
|
@@ -1612,7 +1612,7 @@ ChefModernize/WindowsRegistryUAC:
|
|
1612
1612
|
- '**/attributes/*.rb'
|
1613
1613
|
- '**/Berksfile'
|
1614
1614
|
|
1615
|
-
|
1615
|
+
Chef/Modernize/UseMultipackageInstalls:
|
1616
1616
|
Description: Pass an array of packages to package resources instead of iterating over an array of packages when using multi-package capable package subsystem such as apt, yum, chocolatey, dnf, or zypper. Multi-package installs are faster and simplify logs.
|
1617
1617
|
StyleGuide: '#chefmodernizeusemultipackageinstalls'
|
1618
1618
|
Enabled: true
|
@@ -1622,7 +1622,7 @@ ChefModernize/UseMultipackageInstalls:
|
|
1622
1622
|
- '**/attributes/*.rb'
|
1623
1623
|
- '**/Berksfile'
|
1624
1624
|
|
1625
|
-
|
1625
|
+
Chef/Modernize/ProvidesFromInitialize:
|
1626
1626
|
Description: Provides should be set using the `provides` resource DSL method instead of instead of setting @provides in the initialize method.
|
1627
1627
|
StyleGuide: '#chefmodernizeprovidesfrominitialize'
|
1628
1628
|
Enabled: true
|
@@ -1632,7 +1632,7 @@ ChefModernize/ProvidesFromInitialize:
|
|
1632
1632
|
- '**/providers/*.rb'
|
1633
1633
|
- '**/libraries/*.rb'
|
1634
1634
|
|
1635
|
-
|
1635
|
+
Chef/Modernize/DatabagHelpers:
|
1636
1636
|
Description: Use the `data_bag_item` helper instead of `Chef::DataBagItem.load` or `Chef::EncryptedDataBagItem.load`.
|
1637
1637
|
StyleGuide: '#chefmodernizedatabaghelpers'
|
1638
1638
|
Enabled: true
|
@@ -1641,7 +1641,7 @@ ChefModernize/DatabagHelpers:
|
|
1641
1641
|
- '**/metadata.rb'
|
1642
1642
|
- '**/Berksfile'
|
1643
1643
|
|
1644
|
-
|
1644
|
+
Chef/Modernize/NodeRolesInclude:
|
1645
1645
|
Description: Use `node.role?('foo')` to check if a node includes a role instead of `node['roles'].include?('foo')`.
|
1646
1646
|
StyleGuide: '#chefmodernizenoderolesinclude'
|
1647
1647
|
Enabled: true
|
@@ -1650,7 +1650,7 @@ ChefModernize/NodeRolesInclude:
|
|
1650
1650
|
- '**/metadata.rb'
|
1651
1651
|
- '**/Berksfile'
|
1652
1652
|
|
1653
|
-
|
1653
|
+
Chef/Modernize/RespondToCompileTime:
|
1654
1654
|
Description: There is no need to check if the chef_gem resource supports compile_time as Chef Infra Client 12.1 and later support the compile_time property.
|
1655
1655
|
StyleGuide: '#chefmodernizeresondtocompiletime'
|
1656
1656
|
Enabled: true
|
@@ -1659,7 +1659,7 @@ ChefModernize/RespondToCompileTime:
|
|
1659
1659
|
- '**/metadata.rb'
|
1660
1660
|
- '**/Berksfile'
|
1661
1661
|
|
1662
|
-
|
1662
|
+
Chef/Modernize/ShellOutHelper:
|
1663
1663
|
Description: Use the built-in shell_out helper available in Chef Infra Client 12.11+ instead of calling Mixlib::ShellOut.new('foo').run_command.
|
1664
1664
|
StyleGuide: '#chefmodernizeshellouthelper'
|
1665
1665
|
Enabled: true
|
@@ -1669,7 +1669,7 @@ ChefModernize/ShellOutHelper:
|
|
1669
1669
|
- '**/Berksfile'
|
1670
1670
|
- '**/libraries/*.rb'
|
1671
1671
|
|
1672
|
-
|
1672
|
+
Chef/Modernize/ConditionalUsingTest:
|
1673
1673
|
Description: Use ::File.exist?('/foo/bar') instead of the slower 'test -f /foo/bar' which requires shelling out.
|
1674
1674
|
StyleGuide: '#chefmodernizeconditionalusingtest'
|
1675
1675
|
Enabled: true
|
@@ -1679,7 +1679,7 @@ ChefModernize/ConditionalUsingTest:
|
|
1679
1679
|
- '**/Berksfile'
|
1680
1680
|
- '**/attributes/*.rb'
|
1681
1681
|
|
1682
|
-
|
1682
|
+
Chef/Modernize/CronDFileOrTemplate:
|
1683
1683
|
Description: Use the cron_d resource that ships with Chef Infra Client 14.4+ instead of manually creating the file with template, file, or cookbook_file resources
|
1684
1684
|
StyleGuide: '#chefmodernizecrondfileortemplate'
|
1685
1685
|
Enabled: true
|
@@ -1689,7 +1689,7 @@ ChefModernize/CronDFileOrTemplate:
|
|
1689
1689
|
- '**/Berksfile'
|
1690
1690
|
- '**/attributes/*.rb'
|
1691
1691
|
|
1692
|
-
|
1692
|
+
Chef/Modernize/ActionMethodInResource:
|
1693
1693
|
Description: Use the custom resource language's `action :my_action` blocks instead of creating actions with methods.
|
1694
1694
|
StyleGuide: '#chefmodernizeactionmethodinresource'
|
1695
1695
|
Enabled: true
|
@@ -1700,13 +1700,13 @@ ChefModernize/ActionMethodInResource:
|
|
1700
1700
|
- '**/libraries/*.rb'
|
1701
1701
|
|
1702
1702
|
###############################
|
1703
|
-
#
|
1703
|
+
# Chef/RedundantCode: Cleanup unnecessary code in your cookbooks regardless of Chef Infra Client release
|
1704
1704
|
###############################
|
1705
1705
|
|
1706
|
-
|
1706
|
+
Chef/RedundantCode:
|
1707
1707
|
StyleGuideBaseURL: https://github.com/chef/cookstyle/blob/master/docs/cops_chefredundantcode.md
|
1708
1708
|
|
1709
|
-
|
1709
|
+
Chef/RedundantCode/ConflictsMetadata:
|
1710
1710
|
Description: Don't use the deprecated 'conflicts' metadata value
|
1711
1711
|
StyleGuide: '#chefredundantcodeconflictsmetadata'
|
1712
1712
|
Enabled: true
|
@@ -1715,7 +1715,7 @@ ChefRedundantCode/ConflictsMetadata:
|
|
1715
1715
|
Include:
|
1716
1716
|
- '**/metadata.rb'
|
1717
1717
|
|
1718
|
-
|
1718
|
+
Chef/RedundantCode/SuggestsMetadata:
|
1719
1719
|
Description: The suggests metadata.rb method is not used and is unnecessary in cookbooks.
|
1720
1720
|
StyleGuide: '#chefredundantcodesuggestsmetadata'
|
1721
1721
|
Enabled: true
|
@@ -1724,7 +1724,7 @@ ChefRedundantCode/SuggestsMetadata:
|
|
1724
1724
|
Include:
|
1725
1725
|
- '**/metadata.rb'
|
1726
1726
|
|
1727
|
-
|
1727
|
+
Chef/RedundantCode/ProvidesMetadata:
|
1728
1728
|
Description: The provides metadata.rb method is not used and is unnecessary in cookbooks.
|
1729
1729
|
StyleGuide: '#chefredundantcodeprovidesmetadata'
|
1730
1730
|
Enabled: true
|
@@ -1733,7 +1733,7 @@ ChefRedundantCode/ProvidesMetadata:
|
|
1733
1733
|
Include:
|
1734
1734
|
- '**/metadata.rb'
|
1735
1735
|
|
1736
|
-
|
1736
|
+
Chef/RedundantCode/ReplacesMetadata:
|
1737
1737
|
Description: The replaces metadata.rb method is not used and is unnecessary in cookbooks.
|
1738
1738
|
StyleGuide: '#chefredundantcodereplacesmetadata'
|
1739
1739
|
Enabled: true
|
@@ -1742,7 +1742,7 @@ ChefRedundantCode/ReplacesMetadata:
|
|
1742
1742
|
Include:
|
1743
1743
|
- '**/metadata.rb'
|
1744
1744
|
|
1745
|
-
|
1745
|
+
Chef/RedundantCode/AttributeMetadata:
|
1746
1746
|
Description: The attribute metadata.rb method is not used and is unnecessary in cookbooks.
|
1747
1747
|
StyleGuide: '#chefredundantcodeattributemetadata'
|
1748
1748
|
Enabled: true
|
@@ -1751,7 +1751,7 @@ ChefRedundantCode/AttributeMetadata:
|
|
1751
1751
|
Include:
|
1752
1752
|
- '**/metadata.rb'
|
1753
1753
|
|
1754
|
-
|
1754
|
+
Chef/RedundantCode/LongDescriptionMetadata:
|
1755
1755
|
Description: The long_description metadata.rb method is not used and is unnecessary in cookbooks
|
1756
1756
|
StyleGuide: '#chefredundantcodelongdescriptionmetadata'
|
1757
1757
|
Enabled: true
|
@@ -1760,7 +1760,7 @@ ChefRedundantCode/LongDescriptionMetadata:
|
|
1760
1760
|
Include:
|
1761
1761
|
- '**/metadata.rb'
|
1762
1762
|
|
1763
|
-
|
1763
|
+
Chef/RedundantCode/RecipeMetadata:
|
1764
1764
|
Description: The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the README.md file instead.
|
1765
1765
|
StyleGuide: '#chefredundantcoderecipemetadata'
|
1766
1766
|
Enabled: true
|
@@ -1769,7 +1769,7 @@ ChefRedundantCode/RecipeMetadata:
|
|
1769
1769
|
Include:
|
1770
1770
|
- '**/metadata.rb'
|
1771
1771
|
|
1772
|
-
|
1772
|
+
Chef/RedundantCode/ResourceWithNothingAction:
|
1773
1773
|
Description: There is no need to define a :nothing action in your resource as Chef Infra Client provides the :nothing action by default for every resource.
|
1774
1774
|
StyleGuide: '#chefredundantcoderesourcewithnothingaction'
|
1775
1775
|
Enabled: true
|
@@ -1780,7 +1780,7 @@ ChefRedundantCode/ResourceWithNothingAction:
|
|
1780
1780
|
- '**/resources/*.rb'
|
1781
1781
|
- '**/providers/*.rb'
|
1782
1782
|
|
1783
|
-
|
1783
|
+
Chef/RedundantCode/UnnecessaryNameProperty:
|
1784
1784
|
Description: There is no need to define a property named :name in a resource as Chef Infra defines that property for all resources by default.
|
1785
1785
|
StyleGuide: '#chefredundantcodeunnecessarynameproperty'
|
1786
1786
|
Enabled: true
|
@@ -1790,7 +1790,7 @@ ChefRedundantCode/UnnecessaryNameProperty:
|
|
1790
1790
|
- '**/resources/*.rb'
|
1791
1791
|
- '**/libraries/*.rb'
|
1792
1792
|
|
1793
|
-
|
1793
|
+
Chef/RedundantCode/PropertyWithRequiredAndDefault:
|
1794
1794
|
Description: Resource property should not be both required and have a default value
|
1795
1795
|
StyleGuide: '#chefredundantcodepropertywithrequiredanddefault'
|
1796
1796
|
Enabled: true
|
@@ -1800,7 +1800,7 @@ ChefRedundantCode/PropertyWithRequiredAndDefault:
|
|
1800
1800
|
- '**/resources/*.rb'
|
1801
1801
|
- '**/libraries/*.rb'
|
1802
1802
|
|
1803
|
-
|
1803
|
+
Chef/RedundantCode/NamePropertyIsRequired:
|
1804
1804
|
Description: Resource properties marked as name properties should not also be required properties
|
1805
1805
|
StyleGuide: '#chefredundantcodenamepropertyisrequired'
|
1806
1806
|
Enabled: true
|
@@ -1810,7 +1810,7 @@ ChefRedundantCode/NamePropertyIsRequired:
|
|
1810
1810
|
- '**/resources/*.rb'
|
1811
1811
|
- '**/libraries/*.rb'
|
1812
1812
|
|
1813
|
-
|
1813
|
+
Chef/RedundantCode/CustomResourceWithAllowedActions:
|
1814
1814
|
Description: It is not necessary to set `actions` or `allowed_actions` in custom resources as Chef Infra Client determines these automatically from the set of all actions defined in the resource.
|
1815
1815
|
StyleGuide: '#chefredundantcodecustomresourcewithallowedactions'
|
1816
1816
|
Enabled: true
|
@@ -1819,7 +1819,7 @@ ChefRedundantCode/CustomResourceWithAllowedActions:
|
|
1819
1819
|
Include:
|
1820
1820
|
- '**/resources/*.rb'
|
1821
1821
|
|
1822
|
-
|
1822
|
+
Chef/RedundantCode/SensitivePropertyInResource:
|
1823
1823
|
Description: Every Chef Infra resources already include a sensitive property with a default value of false.
|
1824
1824
|
StyleGuide: '#chefredundantcodesensitivepropertyinresource'
|
1825
1825
|
Enabled: true
|
@@ -1828,7 +1828,7 @@ ChefRedundantCode/SensitivePropertyInResource:
|
|
1828
1828
|
- '**/resources/*.rb'
|
1829
1829
|
- '**/libraries/*.rb'
|
1830
1830
|
|
1831
|
-
|
1831
|
+
Chef/RedundantCode/UnnecessaryDesiredState:
|
1832
1832
|
Description: 'There is no need to set a property to desired_state: true as all properties have a desired_state of true by default.'
|
1833
1833
|
StyleGuide: '#chefredundantcodeunnecessarydesiredstate'
|
1834
1834
|
Enabled: true
|
@@ -1837,7 +1837,7 @@ ChefRedundantCode/UnnecessaryDesiredState:
|
|
1837
1837
|
- '**/resources/*.rb'
|
1838
1838
|
- '**/libraries/*.rb'
|
1839
1839
|
|
1840
|
-
|
1840
|
+
Chef/RedundantCode/AptRepositoryNotifiesAptUpdate:
|
1841
1841
|
Description: There is no need to notify an apt-get update when an apt_repository is created as this is done automatically by the apt_repository resource.
|
1842
1842
|
StyleGuide: '#chefredundantcodeaptrepositorynotifiesaptupdate'
|
1843
1843
|
Enabled: true
|
@@ -1847,7 +1847,7 @@ ChefRedundantCode/AptRepositoryNotifiesAptUpdate:
|
|
1847
1847
|
- '**/attributes/*.rb'
|
1848
1848
|
- '**/Berksfile'
|
1849
1849
|
|
1850
|
-
|
1850
|
+
Chef/RedundantCode/AptRepositoryDistributionDefault:
|
1851
1851
|
Description: There is no need to pass `distribution node['lsb']['codename']` to an apt_repository resource as this is done automatically by the apt_repository resource.
|
1852
1852
|
StyleGuide: '#chefredundantcodeaptrepositorydistributiondefault'
|
1853
1853
|
Enabled: true
|
@@ -1857,7 +1857,7 @@ ChefRedundantCode/AptRepositoryDistributionDefault:
|
|
1857
1857
|
- '**/attributes/*.rb'
|
1858
1858
|
- '**/Berksfile'
|
1859
1859
|
|
1860
|
-
|
1860
|
+
Chef/RedundantCode/GroupingMetadata:
|
1861
1861
|
Description: The grouping metadata.rb method is not used and is unnecessary in cookbooks.
|
1862
1862
|
StyleGuide: '#chefredundantcodegroupingmetadata'
|
1863
1863
|
Enabled: true
|
@@ -1865,7 +1865,7 @@ ChefRedundantCode/GroupingMetadata:
|
|
1865
1865
|
Include:
|
1866
1866
|
- '**/metadata.rb'
|
1867
1867
|
|
1868
|
-
|
1868
|
+
Chef/RedundantCode/StringPropertyWithNilDefault:
|
1869
1869
|
Description: Properties have a nil value by default so there is no need to set the default value to nil.
|
1870
1870
|
StyleGuide: '#chefredundantcodestringpropertywithnildefault'
|
1871
1871
|
Enabled: true
|
@@ -1874,7 +1874,7 @@ ChefRedundantCode/StringPropertyWithNilDefault:
|
|
1874
1874
|
- '**/resources/*.rb'
|
1875
1875
|
- '**/libraries/*.rb'
|
1876
1876
|
|
1877
|
-
|
1877
|
+
Chef/RedundantCode/PropertySplatRegex:
|
1878
1878
|
Description: There is no need to validate the input of properties in resources using a regex value that will always pass.
|
1879
1879
|
StyleGuide: '#chefredundantcodepropertysplatregex'
|
1880
1880
|
Enabled: true
|
@@ -1883,7 +1883,7 @@ ChefRedundantCode/PropertySplatRegex:
|
|
1883
1883
|
- '**/resources/*.rb'
|
1884
1884
|
- '**/libraries/*.rb'
|
1885
1885
|
|
1886
|
-
|
1886
|
+
Chef/RedundantCode/UseCreateIfMissing:
|
1887
1887
|
Description: Use the :create_if_missing action instead of not_if with a ::File.exist(FOO) check.
|
1888
1888
|
StyleGuide: '#chefredundantcodeusecreateifmissing'
|
1889
1889
|
Enabled: true
|
@@ -1893,7 +1893,7 @@ ChefRedundantCode/UseCreateIfMissing:
|
|
1893
1893
|
- '**/attributes/*.rb'
|
1894
1894
|
- '**/Berksfile'
|
1895
1895
|
|
1896
|
-
|
1896
|
+
Chef/RedundantCode/OhaiAttributeToString:
|
1897
1897
|
Description: Many Ohai node attributes are already strings and don't need to be cast to strings again
|
1898
1898
|
StyleGuide: '#chefredundantcodeohaiattributetostring'
|
1899
1899
|
Enabled: true
|
@@ -1902,7 +1902,7 @@ ChefRedundantCode/OhaiAttributeToString:
|
|
1902
1902
|
- '**/metadata.rb'
|
1903
1903
|
- '**/Berksfile'
|
1904
1904
|
|
1905
|
-
|
1905
|
+
Chef/RedundantCode/MultiplePlatformChecks:
|
1906
1906
|
Description: You can pass multiple values to the platform? and platform_family? helpers instead of calling the helpers multiple times.
|
1907
1907
|
StyleGuide: '#chefredundantcodemultipleplatformchecks'
|
1908
1908
|
Enabled: true
|
@@ -1911,7 +1911,7 @@ ChefRedundantCode/MultiplePlatformChecks:
|
|
1911
1911
|
- '**/metadata.rb'
|
1912
1912
|
- '**/Berksfile'
|
1913
1913
|
|
1914
|
-
|
1914
|
+
Chef/RedundantCode/DoubleCompileTime:
|
1915
1915
|
Description: If a resource includes the `compile_time` property there's no need to also use `.run_action(:some_action)` on the resource block
|
1916
1916
|
StyleGuide: '#chefredundantcodedoublecompiletime'
|
1917
1917
|
Enabled: true
|
@@ -1922,13 +1922,13 @@ ChefRedundantCode/DoubleCompileTime:
|
|
1922
1922
|
- '**/Berksfile'
|
1923
1923
|
|
1924
1924
|
###############################
|
1925
|
-
#
|
1925
|
+
# Chef/Effortless: Migrating to new patterns
|
1926
1926
|
###############################
|
1927
1927
|
|
1928
|
-
|
1928
|
+
Chef/Effortless:
|
1929
1929
|
StyleGuideBaseURL: https://github.com/chef/cookstyle/blob/master/docs/cops_chefeffortless.md
|
1930
1930
|
|
1931
|
-
|
1931
|
+
Chef/Effortless/CookbookUsesSearch:
|
1932
1932
|
Description: Cookbook uses search, which cannot be used in the Effortless Infra pattern
|
1933
1933
|
StyleGuide: '#chefeffortlesscookbookusessearch'
|
1934
1934
|
Enabled: false
|
@@ -1937,7 +1937,7 @@ ChefEffortless/CookbookUsesSearch:
|
|
1937
1937
|
- '**/metadata.rb'
|
1938
1938
|
- '**/Berksfile'
|
1939
1939
|
|
1940
|
-
|
1940
|
+
Chef/Effortless/CookbookUsesDatabags:
|
1941
1941
|
Description: Cookbook uses data bags, which cannot be used in the Effortless Infra pattern
|
1942
1942
|
StyleGuide: '#chefeffortlesscookbookusesdatabags'
|
1943
1943
|
Enabled: false
|
@@ -1947,7 +1947,7 @@ ChefEffortless/CookbookUsesDatabags:
|
|
1947
1947
|
- '**/Berksfile'
|
1948
1948
|
|
1949
1949
|
# https://github.com/chef/cookstyle/issues/346
|
1950
|
-
|
1950
|
+
Chef/Effortless/ChefVaultUsed:
|
1951
1951
|
Description: Cookbook uses Chef Vault, which cannot be used in the Effortless Infra pattern
|
1952
1952
|
StyleGuide: '#chefeffortlesscookbookuseschefvault'
|
1953
1953
|
Enabled: false
|
@@ -1957,7 +1957,7 @@ ChefEffortless/ChefVaultUsed:
|
|
1957
1957
|
- '**/Berksfile'
|
1958
1958
|
|
1959
1959
|
# https://github.com/chef/cookstyle/issues/346
|
1960
|
-
|
1960
|
+
Chef/Effortless/DependsChefVault:
|
1961
1961
|
Description: Cookbook depends on Chef Vault, which cannot be used in the Effortless Infra pattern
|
1962
1962
|
StyleGuide: '#chefeffortlesscookbookdependschefvault'
|
1963
1963
|
Enabled: false
|
@@ -1965,7 +1965,7 @@ ChefEffortless/DependsChefVault:
|
|
1965
1965
|
Include:
|
1966
1966
|
- '**/metadata.rb'
|
1967
1967
|
|
1968
|
-
|
1968
|
+
Chef/Effortless/CookbookUsesEnvironments:
|
1969
1969
|
Description: Cookbook uses environments, which cannot be used in the Effortless Infra pattern
|
1970
1970
|
StyleGuide: '#chefeffortlesscookbookusesenvironments'
|
1971
1971
|
Enabled: false
|
@@ -1974,7 +1974,7 @@ ChefEffortless/CookbookUsesEnvironments:
|
|
1974
1974
|
- '**/metadata.rb'
|
1975
1975
|
- '**/Berksfile'
|
1976
1976
|
|
1977
|
-
|
1977
|
+
Chef/Effortless/CookbookUsesPolicygroups:
|
1978
1978
|
Description: Cookbook uses Policy Groups, which cannot be used in the Effortless Infra pattern
|
1979
1979
|
StyleGuide: '#chefeffortlesscookbookusespolicygroups'
|
1980
1980
|
Enabled: false
|
@@ -1983,7 +1983,7 @@ ChefEffortless/CookbookUsesPolicygroups:
|
|
1983
1983
|
- '**/metadata.rb'
|
1984
1984
|
- '**/Berksfile'
|
1985
1985
|
|
1986
|
-
|
1986
|
+
Chef/Effortless/CookbookUsesRoles:
|
1987
1987
|
Description: Cookbook uses Roles, which cannot be used in the Effortless Infra pattern
|
1988
1988
|
StyleGuide: '#chefeffortlesscookbookusesroles'
|
1989
1989
|
Enabled: false
|
@@ -1992,7 +1992,7 @@ ChefEffortless/CookbookUsesRoles:
|
|
1992
1992
|
- '**/metadata.rb'
|
1993
1993
|
- '**/Berksfile'
|
1994
1994
|
|
1995
|
-
|
1995
|
+
Chef/Effortless/SearchForEnvironmentsOrRoles:
|
1996
1996
|
Description: Cookbook uses search with a node query that looks for a role or environment
|
1997
1997
|
StyleGuide: '#chefeffortlesssearchforenvironmentsorroles'
|
1998
1998
|
Enabled: false
|
@@ -2001,7 +2001,7 @@ ChefEffortless/SearchForEnvironmentsOrRoles:
|
|
2001
2001
|
- '**/metadata.rb'
|
2002
2002
|
- '**/Berksfile'
|
2003
2003
|
|
2004
|
-
|
2004
|
+
Chef/Effortless/Berksfile:
|
2005
2005
|
Description: Policyfiles should be used for cookbook dependency solving instead of a Berkshelf Berksfile.
|
2006
2006
|
StyleGuide: '#chefeffortlessberksfile'
|
2007
2007
|
Enabled: false
|
@@ -2493,10 +2493,9 @@ Style/EachForSimpleLoop:
|
|
2493
2493
|
Style/EmptyCaseCondition:
|
2494
2494
|
Enabled: true
|
2495
2495
|
|
2496
|
-
#
|
2496
|
+
# It doesn't matter if people use the friendly helpers or not for overall readability
|
2497
2497
|
Style/NumericPredicate:
|
2498
|
-
Enabled:
|
2499
|
-
EnforcedStyle: comparison
|
2498
|
+
Enabled: false
|
2500
2499
|
|
2501
2500
|
# this is bad %w(something another_thing one_more)
|
2502
2501
|
Layout/SpaceInsideArrayPercentLiteral:
|