cookstyle 6.19.11 → 7.1.2

Sign up to get free protection for your applications and to get access to all the features.
Files changed (229) hide show
  1. checksums.yaml +4 -4
  2. data/config/cookstyle.yml +275 -235
  3. data/config/disable_all.yml +26 -0
  4. data/config/upstream.yml +169 -59
  5. data/cookstyle.gemspec +1 -1
  6. data/lib/cookstyle/version.rb +2 -2
  7. data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +1 -1
  8. data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +1 -1
  9. data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +1 -1
  10. data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +1 -1
  11. data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +1 -1
  12. data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +1 -1
  13. data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +1 -1
  14. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +1 -1
  15. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +1 -1
  16. data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +1 -1
  17. data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +1 -1
  18. data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +1 -1
  19. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +1 -1
  20. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +1 -1
  21. data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +1 -1
  22. data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +1 -1
  23. data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +1 -1
  24. data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +1 -1
  25. data/lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb +1 -1
  26. data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
  27. data/lib/rubocop/cop/chef/correctness/node_normal.rb +1 -1
  28. data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb +1 -1
  29. data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
  30. data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +1 -1
  31. data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +48 -0
  32. data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
  33. data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +1 -1
  34. data/lib/rubocop/cop/chef/correctness/property_without_type.rb +1 -1
  35. data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +1 -1
  36. data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +1 -1
  37. data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +1 -1
  38. data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +1 -1
  39. data/lib/rubocop/cop/chef/correctness/service_resource.rb +1 -1
  40. data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +1 -1
  41. data/lib/rubocop/cop/chef/correctness/tmp_path.rb +1 -1
  42. data/lib/rubocop/cop/chef/deprecation/ use_automatic_resource_name.rb +1 -1
  43. data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +1 -1
  44. data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +1 -1
  45. data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +1 -1
  46. data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +1 -1
  47. data/lib/rubocop/cop/chef/deprecation/chef_rewind.rb +1 -1
  48. data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +1 -1
  49. data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +1 -1
  50. data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +1 -1
  51. data/lib/rubocop/cop/chef/deprecation/cheffile.rb +1 -1
  52. data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
  53. data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +1 -1
  54. data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +1 -1
  55. data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
  56. data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +1 -1
  57. data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +1 -1
  58. data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb +1 -1
  59. data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +1 -1
  60. data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +1 -1
  61. data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +1 -1
  62. data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
  63. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +1 -1
  64. data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
  65. data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
  66. data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +1 -1
  67. data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
  68. data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +1 -1
  69. data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +1 -1
  70. data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +43 -0
  71. data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +1 -1
  72. data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +1 -1
  73. data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +1 -1
  74. data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +1 -1
  75. data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +1 -1
  76. data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +42 -0
  77. data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +1 -1
  78. data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +3 -3
  79. data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +1 -1
  80. data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +1 -1
  81. data/lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb +1 -1
  82. data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +1 -1
  83. data/lib/rubocop/cop/chef/deprecation/node_set.rb +1 -1
  84. data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb +1 -1
  85. data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb +1 -1
  86. data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +1 -1
  87. data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +1 -1
  88. data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +1 -1
  89. data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +1 -1
  90. data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +1 -1
  91. data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +1 -1
  92. data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +1 -1
  93. data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +1 -1
  94. data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +1 -1
  95. data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +1 -1
  96. data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +1 -1
  97. data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +1 -1
  98. data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +1 -1
  99. data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +1 -1
  100. data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
  101. data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +47 -0
  102. data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +1 -1
  103. data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +1 -1
  104. data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +1 -1
  105. data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +1 -1
  106. data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +1 -1
  107. data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +1 -1
  108. data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +1 -1
  109. data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
  110. data/lib/rubocop/cop/chef/effortless/berksfile.rb +1 -1
  111. data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb +1 -1
  112. data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
  113. data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb +1 -1
  114. data/lib/rubocop/cop/chef/effortless/node_environment.rb +1 -1
  115. data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +1 -1
  116. data/lib/rubocop/cop/chef/effortless/node_roles.rb +1 -1
  117. data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
  118. data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
  119. data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +1 -1
  120. data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +1 -1
  121. data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +1 -1
  122. data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +1 -1
  123. data/lib/rubocop/cop/chef/modernize/build_essential.rb +1 -1
  124. data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +1 -1
  125. data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +1 -1
  126. data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +1 -1
  127. data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +1 -1
  128. data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +1 -1
  129. data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +1 -1
  130. data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +1 -1
  131. data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +1 -1
  132. data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
  133. data/lib/rubocop/cop/chef/modernize/definitions.rb +1 -1
  134. data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +1 -1
  135. data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +1 -1
  136. data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
  137. data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +1 -1
  138. data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +1 -1
  139. data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +1 -1
  140. data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +1 -1
  141. data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +1 -1
  142. data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
  143. data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +1 -1
  144. data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +1 -1
  145. data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +1 -1
  146. data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +1 -1
  147. data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
  148. data/lib/rubocop/cop/chef/modernize/node_init_package.rb +1 -1
  149. data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +1 -1
  150. data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +1 -1
  151. data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +1 -1
  152. data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +1 -1
  153. data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +1 -1
  154. data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +1 -1
  155. data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +1 -1
  156. data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +1 -1
  157. data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +1 -1
  158. data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +1 -1
  159. data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +1 -1
  160. data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +1 -1
  161. data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +1 -1
  162. data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +1 -1
  163. data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +1 -1
  164. data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +1 -1
  165. data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +1 -1
  166. data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +1 -1
  167. data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +1 -1
  168. data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +1 -1
  169. data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +1 -1
  170. data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +1 -1
  171. data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +1 -1
  172. data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +1 -1
  173. data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
  174. data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +17 -13
  175. data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +1 -1
  176. data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
  177. data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +1 -1
  178. data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +4 -4
  179. data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +1 -1
  180. data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +1 -1
  181. data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +1 -1
  182. data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +1 -1
  183. data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +1 -1
  184. data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
  185. data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
  186. data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +1 -1
  187. data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +1 -1
  188. data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
  189. data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
  190. data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +1 -1
  191. data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +1 -1
  192. data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +1 -1
  193. data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +1 -1
  194. data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +1 -1
  195. data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
  196. data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
  197. data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
  198. data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
  199. data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +1 -1
  200. data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +1 -1
  201. data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
  202. data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +13 -12
  203. data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +1 -1
  204. data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +1 -1
  205. data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +1 -1
  206. data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +1 -1
  207. data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +1 -1
  208. data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
  209. data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
  210. data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +1 -1
  211. data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +1 -1
  212. data/lib/rubocop/cop/chef/style/attribute_keys.rb +1 -1
  213. data/lib/rubocop/cop/chef/style/chef_whaaat.rb +1 -1
  214. data/lib/rubocop/cop/chef/style/comment_sentence_spacing.rb +1 -1
  215. data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +4 -3
  216. data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +1 -1
  217. data/lib/rubocop/cop/chef/style/comments_format.rb +1 -1
  218. data/lib/rubocop/cop/chef/style/file_mode.rb +1 -1
  219. data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +1 -1
  220. data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +1 -1
  221. data/lib/rubocop/cop/chef/style/negating_only_if.rb +1 -1
  222. data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +1 -1
  223. data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +1 -1
  224. data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +1 -1
  225. data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +1 -1
  226. data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +1 -1
  227. data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +1 -1
  228. data/lib/rubocop/monkey_patches/comment_config.rb +1 -1
  229. metadata +9 -5
@@ -19,7 +19,7 @@
19
19
  module RuboCop
20
20
  module Cop
21
21
  module Chef
22
- module ChefSharing
22
+ module Sharing
23
23
  # metadata.rb should not include fields with an empty string. Either don't include the field or add a value.
24
24
  #
25
25
  # @example
@@ -18,7 +18,7 @@
18
18
  module RuboCop
19
19
  module Cop
20
20
  module Chef
21
- module ChefSharing
21
+ module Sharing
22
22
  # Resource properties should include description fields to allow automated documentation. Requires Chef Infra Client 13.9 or later.
23
23
  #
24
24
  # @example
@@ -18,7 +18,7 @@
18
18
  module RuboCop
19
19
  module Cop
20
20
  module Chef
21
- module ChefSharing
21
+ module Sharing
22
22
  # Resources should include description fields to allow automated documentation. Requires Chef Infra Client 13.9 or later.
23
23
  #
24
24
  # @example
@@ -18,7 +18,7 @@
18
18
  module RuboCop
19
19
  module Cop
20
20
  module Chef
21
- module ChefSharing
21
+ module Sharing
22
22
  # Resources should include examples field to allow automated documentation. Requires Chef Infra Client 13.9 or later.
23
23
  #
24
24
  # @example
@@ -18,7 +18,7 @@
18
18
  module RuboCop
19
19
  module Cop
20
20
  module Chef
21
- module ChefSharing
21
+ module Sharing
22
22
  # Use secure Github and Gitlab URLs for source_url and issues_url
23
23
  #
24
24
  # @example
@@ -19,7 +19,7 @@
19
19
  module RuboCop
20
20
  module Cop
21
21
  module Chef
22
- module ChefSharing
22
+ module Sharing
23
23
  # metadata.rb license field should include a SPDX compliant string or "all right reserved" (not case sensitive)
24
24
  #
25
25
  # @example
@@ -18,7 +18,7 @@
18
18
  module RuboCop
19
19
  module Cop
20
20
  module Chef
21
- module ChefStyle
21
+ module Style
22
22
  # Check which style of keys are used to access node attributes.
23
23
  #
24
24
  # There are two supported styles: "symbols" and "strings".
@@ -19,7 +19,7 @@
19
19
  module RuboCop
20
20
  module Cop
21
21
  module Chef
22
- module ChefStyle
22
+ module Style
23
23
  # Checks for comments that mention "Chef" without context. Do you mean Chef Infra or Chef Software?
24
24
  #
25
25
  # @example
@@ -19,7 +19,7 @@
19
19
  module RuboCop
20
20
  module Cop
21
21
  module Chef
22
- module ChefStyle
22
+ module Style
23
23
  # Replaces double spaces between sentences with a single space.
24
24
  # Note: This is DISABLED by default.
25
25
  class CommentSentenceSpacing < Base
@@ -19,7 +19,7 @@
19
19
  module RuboCop
20
20
  module Cop
21
21
  module Chef
22
- module ChefStyle
22
+ module Style
23
23
  # Checks for incorrectly formatted copyright comments.
24
24
  #
25
25
  # @example
@@ -38,7 +38,8 @@ module RuboCop
38
38
  # Copyright:: 2013-2019 Tim Smith
39
39
  # Copyright:: 2019 37Signals, Inc.
40
40
  #
41
- class CopyrightCommentFormat < Cop
41
+ class CopyrightCommentFormat < Base
42
+ extend AutoCorrector
42
43
  require 'date'
43
44
 
44
45
  MSG = 'Properly format copyrights header comments'
@@ -49,7 +50,7 @@ module RuboCop
49
50
  processed_source.comments.each do |comment|
50
51
  next unless comment.inline? && invalid_copyright_comment?(comment) # headers aren't in blocks
51
52
 
52
- add_offense(comment, location: comment, message: MSG, severity: :refactor) do |corrector|
53
+ add_offense(comment, message: MSG, severity: :refactor) do |corrector|
53
54
  correct_comment = "# Copyright:: #{copyright_date_range(comment)}, #{copyright_holder(comment)}"
54
55
  corrector.replace(comment, correct_comment)
55
56
  end
@@ -19,7 +19,7 @@
19
19
  module RuboCop
20
20
  module Cop
21
21
  module Chef
22
- module ChefStyle
22
+ module Style
23
23
  # Checks for default copyright comments from the chef generator cookbook command
24
24
  #
25
25
  # @example
@@ -19,7 +19,7 @@
19
19
  module RuboCop
20
20
  module Cop
21
21
  module Chef
22
- module ChefStyle
22
+ module Style
23
23
  # Checks for incorrectly formatted headers
24
24
  #
25
25
  # @example
@@ -18,7 +18,7 @@
18
18
  module RuboCop
19
19
  module Cop
20
20
  module Chef
21
- module ChefStyle
21
+ module Style
22
22
  # Use strings to represent file modes to avoid confusion between octal and base 10 integer formats.
23
23
  #
24
24
  # @example
@@ -18,7 +18,7 @@
18
18
  module RuboCop
19
19
  module Cop
20
20
  module Chef
21
- module ChefStyle
21
+ module Style
22
22
  # Use :immediately instead of :immediate for resource notification timing
23
23
  #
24
24
  # @example
@@ -19,7 +19,7 @@
19
19
  module RuboCop
20
20
  module Cop
21
21
  module Chef
22
- module ChefStyle
22
+ module Style
23
23
  # There is no need to wrap the recipe in parentheses when using the include_recipe helper.
24
24
  #
25
25
  # @example
@@ -18,7 +18,7 @@
18
18
  module RuboCop
19
19
  module Cop
20
20
  module Chef
21
- module ChefStyle
21
+ module Style
22
22
  # Instead of using only_if conditionals with ! to negate the returned value, use not_if which is easier to read
23
23
  #
24
24
  # @example
@@ -18,7 +18,7 @@
18
18
  module RuboCop
19
19
  module Cop
20
20
  module Chef
21
- module ChefStyle
21
+ module Style
22
22
  # Don't loop over an array to set cookbook dependencies or supported platforms if you have fewer than three values to set. Setting multiple `supports` or `depends` values is simpler and easier to understand for new users.
23
23
  #
24
24
  # @example
@@ -18,7 +18,7 @@
18
18
  module RuboCop
19
19
  module Cop
20
20
  module Chef
21
- module ChefStyle
21
+ module Style
22
22
  # When checking the major version number of a platform you can take the node['platform_version'] attribute and transform it to an integer to strip it down to just the major version number. This simple way of determining the major version number of a platform should be used instead of splitting the platform into multiple fields with '.' as the delimiter.
23
23
  #
24
24
  # @example
@@ -18,7 +18,7 @@
18
18
  module RuboCop
19
19
  module Cop
20
20
  module Chef
21
- module ChefStyle
21
+ module Style
22
22
  # When setting the allowed types for a resource to accept either true or false values it's much simpler to use true and false instead of TrueClass and FalseClass.
23
23
  #
24
24
  # @example
@@ -18,7 +18,7 @@
18
18
  module RuboCop
19
19
  module Cop
20
20
  module Chef
21
- module ChefStyle
21
+ module Style
22
22
  # Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match one-to-one with OS values. These helpers are easier to read and can accept multiple platform arguments, which greatly simplifies complex platform logic. All values of `os` from Ohai match one-to-one with `platform_family` values except for `linux`, which has no single equivalent `plaform_family`.
23
23
  #
24
24
  # @example
@@ -18,7 +18,7 @@
18
18
  module RuboCop
19
19
  module Cop
20
20
  module Chef
21
- module ChefStyle
21
+ module Style
22
22
  # Use the platform?() and platform_family?() helpers instead of a case statement that only includes a single when statement.
23
23
  #
24
24
  # @example
@@ -18,7 +18,7 @@
18
18
  module RuboCop
19
19
  module Cop
20
20
  module Chef
21
- module ChefStyle
21
+ module Style
22
22
  # Use the platform?() and platform_family?() helpers instead of node['platform] == 'foo' and node['platform_family'] == 'bar'. These helpers are easier to read and can accept multiple platform arguments, which greatly simplifies complex platform logic.
23
23
  #
24
24
  # @example
@@ -5,7 +5,7 @@ module RuboCop
5
5
  class CommentConfig
6
6
  remove_const('COMMENT_DIRECTIVE_REGEXP')
7
7
  COMMENT_DIRECTIVE_REGEXP = Regexp.new(
8
- ('# (?:rubocop|cookstyle) : ((?:dis|en)able)\b ' + COPS_PATTERN).gsub(' ', '\s*')
8
+ "# (?:rubocop|cookstyle): ((?:disable|enable|todo))\\b #{COPS_PATTERN}".gsub(' ', '\s*')
9
9
  )
10
10
  end
11
11
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: cookstyle
3
3
  version: !ruby/object:Gem::Version
4
- version: 6.19.11
4
+ version: 7.1.2
5
5
  platform: ruby
6
6
  authors:
7
7
  - Thom May
@@ -9,7 +9,7 @@ authors:
9
9
  autorequire:
10
10
  bindir: bin
11
11
  cert_chain: []
12
- date: 2020-10-02 00:00:00.000000000 Z
12
+ date: 2020-11-05 00:00:00.000000000 Z
13
13
  dependencies:
14
14
  - !ruby/object:Gem::Dependency
15
15
  name: rubocop
@@ -17,14 +17,14 @@ dependencies:
17
17
  requirements:
18
18
  - - '='
19
19
  - !ruby/object:Gem::Version
20
- version: 0.92.0
20
+ version: 1.2.0
21
21
  type: :runtime
22
22
  prerelease: false
23
23
  version_requirements: !ruby/object:Gem::Requirement
24
24
  requirements:
25
25
  - - '='
26
26
  - !ruby/object:Gem::Version
27
- version: 0.92.0
27
+ version: 1.2.0
28
28
  description:
29
29
  email:
30
30
  - thom@chef.io
@@ -74,6 +74,7 @@ files:
74
74
  - lib/rubocop/cop/chef/correctness/node_normal_unless.rb
75
75
  - lib/rubocop/cop/chef/correctness/node_save.rb
76
76
  - lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb
77
+ - lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb
77
78
  - lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb
78
79
  - lib/rubocop/cop/chef/correctness/powershell_delete_file.rb
79
80
  - lib/rubocop/cop/chef/correctness/property_without_type.rb
@@ -112,11 +113,13 @@ files:
112
113
  - lib/rubocop/cop/chef/deprecation/erl_call.rb
113
114
  - lib/rubocop/cop/chef/deprecation/execute_path_property.rb
114
115
  - lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb
116
+ - lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb
115
117
  - lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb
116
118
  - lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb
117
119
  - lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb
118
120
  - lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb
119
121
  - lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb
122
+ - lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb
120
123
  - lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb
121
124
  - lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb
122
125
  - lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb
@@ -141,6 +144,7 @@ files:
141
144
  - lib/rubocop/cop/chef/deprecation/run_command_helper.rb
142
145
  - lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb
143
146
  - lib/rubocop/cop/chef/deprecation/use_inline_resources.rb
147
+ - lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb
144
148
  - lib/rubocop/cop/chef/deprecation/user_supports_property.rb
145
149
  - lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb
146
150
  - lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb
@@ -280,7 +284,7 @@ metadata:
280
284
  homepage_uri: https://github.com/chef/cookstyle
281
285
  changelog_uri: https://github.com/chef/cookstyle/blob/master/CHANGELOG.md
282
286
  source_code_uri: https://github.com/chef/cookstyle
283
- documentation_uri: https://docs.chef.io/cookstyle.html
287
+ documentation_uri: https://docs.chef.io/workstation/cookstyle/
284
288
  bug_tracker_uri: https://github.com/chef/cookstyle/issues
285
289
  post_install_message:
286
290
  rdoc_options: []