cookstyle 6.19.11 → 7.1.2

data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The hostname, build_essential, chef_gem, and ohai_hint resources include 'compile_time' properties, which should be used to force the resources to run at compile time by setting `compile_time true`.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use ::File.exist?('/foo/bar') instead of the slower 'test -f /foo/bar' which requires shelling out
         #
         # @example

data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use the cron_d resource that ships with Chef Infra Client 14.4+ instead of manually creating the file with template, file, or cookbook_file resources.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The cron_manage resource was renamed to cron_access in the 6.1 release of the cron
         # cookbook, and later shipped in Chef Infra Client 14.4. The new resource name should
         # be used.

data/lib/rubocop/cop/chef/modernize/databag_helpers.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use the `data_bag_item` helper instead of `Chef::DataBagItem.load` or `Chef::EncryptedDataBagItem.load`.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The default actions can now be specified using the `default_action` helper instead of using the @action variable in the resource provider initialize method. In general we recommend against writing HWRPs, but if HWRPs are necessary you should utilize as much of the resource DSL as possible.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # ChefSpec 7.1 and later auto generate ChefSpec matchers. Matchers in cookbooks can now be removed.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/definitions.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # In 2016 with Chef Infra Client 12.5 Custom Resources were introduced as a way of writing reusable resource code that could be shipped in cookbooks. Custom Resources offer many advantages of legacy Definitions including unit testing with ChefSpec, input validation, actions, common properties like not_if/only_if, and resource reporting.
         #
         class Definitions < Base

data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Don't depend on the zypper cookbook as the zypper_repository resource is built into Chef Infra Client 13.3+
         #
         # @example

data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Chef Infra Client 12.4+ includes the Chef::DSL::Recipe in the resource and provider classed by default so there is no need to include this DSL in your resources or providers.
         #
         #   # bad

data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # There is no need for an empty initialize method in a resource
         #
         # @example

data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Instead of using the execute resource to to run the `apt-get update` use Chef Infra Client's built-n
         # apt_update resource which is available in Chef Infra Client 12.7 and later.
         #

data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Chef Infra Client 14.0 and later includes :create, :delete, and :configure actions with the full idempotency of the windows_service resource. See the windows_service documentation at https://docs.chef.io/resource_windows_service.html for additional details on creating services with the windows_service resource.
         #
         #   # bad

data/lib/rubocop/cop/chef/modernize/execute_sleep.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Chef Infra Client 15.5 and later include a chef_sleep resource that should be used to sleep between executing resources if necessary instead of using the bash or execute resources to run the sleep command.
         #
         #   # bad

data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Chef Infra Client 14.0 and later includes a sysctl resource that should be used to idempotently load sysctl values instead of templating files and using execute to load them.
         #
         #   # bad

data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Instead of using the execute or powershell_script resources to to run the `tzutil` command, use
         # Chef Infra Client's built-in timezone resource which is available in Chef Infra Client 14.6 and later.
         #

data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Remove legacy code comments that disable Foodcritic rules. These comments are no longer necessary if you've migrated from Foodcritic to Cookstyle for cookbook linting.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # if defined?(default_action) is no longer necessary in Chef Resources as default_action shipped in Chef 10.8.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # There is no need to include Chef::Mixin::ShellOut or Chef::Mixin::PowershellOut in resources or providers as this is already done by Chef Infra Client 12.4+.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/libarchive_file.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use the archive_file resource built into Chef Infra Client 15+ instead of the libarchive_file resource.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The mac_os_x_userdefaults resource was renamed to macos_userdefaults when it was added to Chef Infra Client
         # 14.0. The new resource name should be used.
         #

data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use Chef InSpec for testing instead of the Minitest Handler cookbook pattern.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/node_init_package.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use node['init_package'] to check for systemd instead of reading the contents of '/proc/1/comm'
         #
         # @example

data/lib/rubocop/cop/chef/modernize/node_roles_include.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use `node.role?('foo')` to check if a node includes a role instead of `node['roles'].include?('foo')`.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The Ohai default recipe previously allowed a user to ship custom Ohai plugins to a system by including them
         # in a directory in the Ohai cookbook. This functionality was replaced with the ohai_plugin resource, which
         # should be used instead as it doesn't require forking the ohai cookbook.

data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The openssl_rsa_key resource was renamed to openssl_rsa_private_key in Chef
         # Infra Client 14.0. The new resource name should be used.
         #

data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The openssl_x509 resource was renamed to openssl_x509_certificate in Chef Infra Client 14.4.
         # The new resource name should be used.
         #

data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The osx_config_profile resource was renamed to osx_profile.
         # The new resource name should be used.
         #

data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use the archive_file resource built into Chef Infra Client 15+ instead of using the powershell_script
         # resource to run Expand-Archive
         #

data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # PowerShell is already set as the default guard interpreter for `powershell_script` and `batch` resources in Chef Infra Client 13 and later and does not need to be specified.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use the powershell_package resource built into Chef Infra Client instead of the powershell_script
         # resource to run Install-Package
         #

data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use the windows_feature resource built into Chef Infra Client 14+ instead of the powershell_script resource
         # to run Install-WindowsFeature or Add-WindowsFeature
         #

data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # When using properties in a custom resource you should use name_property not the legacy name_attribute from the days of attributes
         #
         # @example

data/lib/rubocop/cop/chef/modernize/provides_initializer.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Provides should be set using the `provides` resource DSL method instead of instead of setting @provides in the initialize method.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The resource name can now be specified using the `resource_name` helper instead of using the @resource_name variable in the resource provider initialize method. In general we recommend against writing HWRPs, but if HWRPs are necessary you should utilize as much of the resource DSL as possible.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # set_or_return within a method should not be used to define property in a resource. Instead use
         # the property method which properly validates and defines properties in a way that works with
         # reporting and documentation functionality in Chef Infra Client

data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # In HWRPs and LWRPs you defined attributes, but custom resources changed the name to
         # be properties to avoid confusion with chef recipe attributes. When writing a custom resource
         # they should be called properties even though the two are aliased.

data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # There is no need to check if the chef_gem resource supports compile_time as Chef Infra Client 12.1 and later support the compile_time property.
         #
         #   # bad

data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # It is not longer necessary respond_to?(:foo) or defined?(foo) in metadata. This was used to support new metadata
         # methods in Chef 11 and early versions of Chef 12.
         #

data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # In Chef Infra Client 12+ is is no longer necessary to gate the use of the provides methods in resources with `if respond_to?(:provides)` or `if defined? provides`.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Chef Infra Client 12.5 introduced the resource_name method for resources. Many cookbooks used respond_to?(:resource_name) to provide backwards compatibility with older chef-client releases. This backwards compatibility is no longer necessary.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The sc_windows resource from the sc cookbook allowed for the creation of windows services on legacy Chef Infra Client releases. Chef Infra Client 14.0 and later includes :create, :delete, and :configure actions without the need for additional cookbook dependencies. See the windows_service documentation at https://docs.chef.io/resource_windows_service.html for additional details on creating services with the windows_service resource.
         #
         #   # bad

data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use the archive_file resource built into Chef Infra Client 15+ instead of the seven_zip_archive
         #
         # @example

data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use the built-in `shell_out` helper available in Chef Infra Client 12.11+ instead of calling `Mixlib::ShellOut.new('foo').run_command`.
         #
         # @example

data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # Use the Chocolatey resources built into Chef Infra Client instead of shelling out to the choco command
         #
         # @example

data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
+      module Modernize
         # The apt_repository resource allows setting up PPAs without using the full URL to ppa.launchpad.net, which should be used to simplify the resource code in your cookbooks.
         #
         # @example