cookstyle 5.23.0 → 6.0.19

data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb

@@ -1,5 +1,5 @@
 #
-# Copyright:: 2019-2020, Chef Software Inc.
+# Copyright:: 2019, Chef Software Inc.
 # Author:: Tim Smith (<tsmith@chef.io>)
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -35,15 +35,8 @@ module RuboCop
 
           MSG = 'whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+'.freeze
 
-          # match on both whyrun_supported? and the typo form why_run_supported?
-          def_node_matcher :whyrun_true?, <<-PATTERN
-            (def {:whyrun_supported? :why_run_supported?}
-              (args)
-              (true))
-          PATTERN
-
           def on_def(node)
-            whyrun_true?(node) do
+            if node.method_name == :whyrun_supported? && node.body == s(:true) # rubocop: disable Lint/BooleanSymbol
               add_offense(node, location: :expression, message: MSG, severity: :refactor)
             end
           end

data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb

@@ -50,7 +50,7 @@ module RuboCop
 
             # use source instead of .value in case there's string interpolation which adds a complex dstr type
             # with a nested string and a begin. Source allows us to avoid a lot of defensive programming here
-            if node&.arguments.first&.source.match?(/HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Policies\\System/i)
+            if node&.arguments.first&.source.match?(/(HKLM|HKEY_LOCAL_MACHINE)\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Policies\\System/i) && node.parent&.method_name != :describe
               add_offense(node, location: :expression, message: MSG, severity: :refactor)
             end
           end
@@ -59,7 +59,7 @@ module RuboCop
           def on_block(node)
             match_property_in_resource?(:registry_key, 'key', node) do |key_prop|
               property_data = method_arg_ast_to_string(key_prop)
-              if property_data && property_data.match?(/HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Policies\\System/i)
+              if property_data && property_data.match?(/(HKLM|HKEY_LOCAL_MACHINE)\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Policies\\System/i)
                 add_offense(node, location: :expression, message: MSG, severity: :refactor)
               end
             end

data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb

@@ -47,7 +47,6 @@ module RuboCop
 
           def on_block(node)
             match_property_in_resource?(:apt_repository, 'distribution', node) do |dist|
-              ## require 'pry'; binding.pry
               default_dist?(dist) do
                 add_offense(dist, location: :expression, message: MSG, severity: :refactor)
               end

data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb

@@ -1,5 +1,5 @@
 #
-# Copyright:: Copyright 2019-2020, Chef Software Inc.
+# Copyright:: Copyright 2019, Chef Software Inc.
 # Author:: Tim Smith (<tsmith@chef.io>)
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -18,13 +18,13 @@ module RuboCop
   module Cop
     module Chef
       module ChefRedundantCode
-        # Every Chef Infra resource already includes a sensitive property with a default value of false.
+        # Every Chef Infra resources already include a sensitive property with a default value of false.
         #
         # # bad
         # property :sensitive, [true, false], default: false
         #
         class SensitivePropertyInResource < Cop
-          MSG = 'Every Chef Infra resource already includes a sensitive property with a default value of false.'.freeze
+          MSG = 'Every Chef Infra resources already include a sensitive property with a default value of false.'.freeze
 
           def_node_matcher :sensitive_property?, <<-PATTERN
             (send nil? {:property :attribute} (sym :sensitive) ... (hash (pair (sym :default) (false))))

data/lib/rubocop/monkey_patches/comment_config.rb

@@ -1,6 +1,6 @@
 module RuboCop
   # we're monkey patching the config regex to allow for # cookstyle: disable whatever
-  # in addition to the # rubocop: disable whatever that comes with Rubocop
+  # in addition to the # rubocop: disable whatever that comes with RuboCop
   class CommentConfig
     remove_const('COMMENT_DIRECTIVE_REGEXP')
     COMMENT_DIRECTIVE_REGEXP = Regexp.new(

data/lib/rubocop/monkey_patches/config.rb

@@ -2,7 +2,7 @@
 
 module RuboCop
   class Config
-    # This is a copy of the #target_rails_version method from Rubocop
+    # This is a copy of the #target_rails_version method from RuboCop
     def target_chef_version
       @target_chef_version ||=
         if for_all_cops['TargetChefVersion']

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 5.23.0
+  version: 6.0.19
 platform: ruby
 authors:
 - Thom May
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-20 00:00:00.000000000 Z
+date: 2020-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.75.1
+        version: 0.80.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.75.1
+        version: 0.80.1
 description: 
 email:
 - thom@chef.io
@@ -51,6 +51,7 @@ files:
 - lib/rubocop/chef/platform_helpers.rb
 - lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb
 - lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
+- lib/rubocop/cop/chef/correctness/chef_application_fatal.rb
 - lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb
 - lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb
 - lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb
@@ -66,6 +67,7 @@ files:
 - lib/rubocop/cop/chef/correctness/node_normal_unless.rb
 - lib/rubocop/cop/chef/correctness/node_save.rb
 - lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb
+- lib/rubocop/cop/chef/correctness/powershell_delete_file.rb
 - lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
 - lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
 - lib/rubocop/cop/chef/correctness/resource_with_none_action.rb
@@ -75,6 +77,7 @@ files:
 - lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb
 - lib/rubocop/cop/chef/deprecation/chef_rest.rb
 - lib/rubocop/cop/chef/deprecation/chef_rewind.rb
+- lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb
 - lib/rubocop/cop/chef/deprecation/cheffile.rb
 - lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb
 - lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb
@@ -85,6 +88,7 @@ files:
 - lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb
 - lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb
 - lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb
+- lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb
 - lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb
 - lib/rubocop/cop/chef/deprecation/easy_install.rb
 - lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb
@@ -95,6 +99,7 @@ files:
 - lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb
 - lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb
 - lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb
+- lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb
 - lib/rubocop/cop/chef/deprecation/name_property_and_default.rb
 - lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb
 - lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb
@@ -109,6 +114,7 @@ files:
 - lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb
 - lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb
 - lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb
+- lib/rubocop/cop/chef/deprecation/resource_without_name_or_provides.rb
 - lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb
 - lib/rubocop/cop/chef/deprecation/run_command_helper.rb
 - lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb
@@ -134,6 +140,7 @@ files:
 - lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb
 - lib/rubocop/cop/chef/modernize/compile_time_resources.rb
 - lib/rubocop/cop/chef/modernize/cron_manage_resource.rb
+- lib/rubocop/cop/chef/modernize/databag_helpers.rb
 - lib/rubocop/cop/chef/modernize/default_action_initializer.rb
 - lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb
 - lib/rubocop/cop/chef/modernize/definitions.rb
@@ -161,6 +168,7 @@ files:
 - lib/rubocop/cop/chef/modernize/powershell_install_package.rb
 - lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb
 - lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb
+- lib/rubocop/cop/chef/modernize/provides_initializer.rb
 - lib/rubocop/cop/chef/modernize/resource_name_initializer.rb
 - lib/rubocop/cop/chef/modernize/resource_set_or_return.rb
 - lib/rubocop/cop/chef/modernize/resource_with_attributes.rb
@@ -173,6 +181,7 @@ files:
 - lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb
 - lib/rubocop/cop/chef/modernize/systctl_param_resource.rb
 - lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb
+- lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb
 - lib/rubocop/cop/chef/modernize/use_require_relative.rb
 - lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb
 - lib/rubocop/cop/chef/modernize/windows_default_recipe.rb
@@ -223,7 +232,6 @@ files:
 - lib/rubocop/monkey_patches/commissioner.rb
 - lib/rubocop/monkey_patches/config.rb
 - lib/rubocop/monkey_patches/cop.rb
-- lib/rubocop/monkey_patches/json_formatter.rb
 homepage: 
 licenses:
 - Apache-2.0

data/lib/rubocop/monkey_patches/json_formatter.rb

@@ -1,20 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Formatter
-    # This formatter formats the report data in JSON format.
-    class JSONFormatter < BaseFormatter
-      # We need to expose the correctable status until https://github.com/rubocop-hq/rubocop/pull/7514 is merged
-      def hash_for_offense(offense)
-        {
-          severity: offense.severity.name,
-          message: offense.message,
-          cop_name: offense.cop_name,
-          corrected: offense.corrected?,
-          correctable: offense.status != :unsupported,
-          location: hash_for_location(offense),
-        }
-      end
-    end
-  end
-end