cookstyle 5.23.0 → 6.0.19

data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb

@@ -42,16 +42,13 @@ module RuboCop
         #
         class DeprecatedYumRepositoryProperties < Cop
           include RuboCop::Chef::CookbookHelpers
-          extend TargetChefVersion
-
-          minimum_target_chef_version '12.14'
 
           MSG = 'With the release of Chef Infra Client 12.14 and the yum cookbook 3.0 several properties in the yum_repository resource were renamed. url -> baseurl, keyurl -> gpgkey, and mirrorexpire -> mirror_expire.'.freeze
 
           def on_block(node)
             %w(url keyurl mirrorexpire).each do |prop|
               match_property_in_resource?(:yum_repository, prop, node) do |prop_node|
-                add_offense(prop_node, location: :expression, message: MSG, severity: :refactor)
+                add_offense(prop_node, location: :expression, message: MSG, severity: :warning)
               end
             end
           end

data/lib/rubocop/cop/chef/deprecation/easy_install.rb

@@ -32,7 +32,7 @@ module RuboCop
           MSG = "Don't use the deprecated easy_install resource removed in Chef 13".freeze
 
           def on_send(node)
-            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :easy_install
+            add_offense(node, location: :expression, message: MSG, severity: :warning) if node.method_name == :easy_install
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb

@@ -38,7 +38,7 @@ module RuboCop
 
           def on_send(node)
             control_group?(node) do
-              add_offense(node, location: :selector, message: MSG, severity: :refactor)
+              add_offense(node, location: :selector, message: MSG, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/epic_fail.rb

@@ -37,7 +37,7 @@ module RuboCop
           MSG = 'Use ignore_failure method instead of the deprecated epic_fail method'.freeze
 
           def on_send(node)
-            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :epic_fail
+            add_offense(node, location: :expression, message: MSG, severity: :warning) if node.method_name == :epic_fail
           end
 
           def autocorrect(node)

data/lib/rubocop/cop/chef/deprecation/erl_call.rb

@@ -32,7 +32,7 @@ module RuboCop
           MSG = "Don't use the deprecated erl_call resource removed in Chef 13".freeze
 
           def on_send(node)
-            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :erl_call
+            add_offense(node, location: :expression, message: MSG, severity: :warning) if node.method_name == :erl_call
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb

@@ -45,7 +45,7 @@ module RuboCop
 
           def on_class(node)
             inherits_from_compat_resource?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              add_offense(node, location: :expression, message: MSG, severity: :warning)
             end
           end
 

data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb

@@ -34,15 +34,12 @@ module RuboCop
         #
         class LaunchdDeprecatedHashProperty < Cop
           include RuboCop::Chef::CookbookHelpers
-          extend TargetChefVersion
-
-          minimum_target_chef_version '12.19'
 
           MSG = "The launchd resource's hash property was renamed to plist_hash in Chef Infra Client 13+ to avoid conflicts with Ruby's hash class.".freeze
 
           def on_block(node)
             match_property_in_resource?(:launchd, 'hash', node) do |hash_prop|
-              add_offense(hash_prop, location: :expression, message: MSG, severity: :refactor)
+              add_offense(hash_prop, location: :expression, message: MSG, severity: :warning)
             end
           end
 

data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb

@@ -65,7 +65,7 @@ module RuboCop
 
           def on_send(node)
             legacy_notify?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              add_offense(node, location: :expression, message: MSG, severity: :warning)
             end
           end
 

data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb

@@ -41,7 +41,7 @@ module RuboCop
 
           def on_send(node)
             old_yum_recipe?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              add_offense(node, location: :expression, message: MSG, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb

@@ -35,7 +35,7 @@ module RuboCop
 
           def on_block(node)
             match_property_in_resource?(:locale, 'lc_all', node) do |property|
-              add_offense(property, location: :expression, message: MSG, severity: :refactor)
+              add_offense(property, location: :expression, message: MSG, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb

@@ -0,0 +1,60 @@
+#
+# Copyright:: 2020, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module RuboCop
+  module Cop
+    module Chef
+      module ChefDeprecations
+        # In Chef Infra Client 16 the log resource no longer notifies when logging so notifications should not be triggered from log resources. See the notify_group functionality for a potential replacement.
+        #
+        # @example
+        #
+        #   # bad
+        #   template '/etc/foo' do
+        #     source 'bar.erb'
+        #     notifies :write, 'log[Aggregate notifications using a single log resource]', :immediately
+        #   end
+        #
+        #   log 'Aggregate notifications using a single log resource' do
+        #     notifies :restart, 'service[foo]', :delayed
+        #   end
+        #
+        #   # good
+        #   template '/etc/foo' do
+        #     source 'bar.erb'
+        #     notifies :run, 'notify_group[Aggregate notifications using a single notify_group resource]', :immediately
+        #   end
+        #
+        #   notify_group 'Aggregate notifications using a single notify_group resource' do
+        #     notifies :restart, 'service[foo]', :delayed
+        #   end
+        #
+        class LogResourceNotifications < Cop
+          include RuboCop::Chef::CookbookHelpers
+
+          MSG = 'In Chef Infra Client 16 the log resource no longer notifies when logging so notifications should not be triggered from log resources. Use the notify_group resource instead to aggregate notifications.'.freeze
+
+          def on_block(node)
+            match_property_in_resource?(:log, 'notifies', node) do |prop_node|
+              add_offense(prop_node, location: :expression, message: MSG, severity: :warning)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb

@@ -44,7 +44,7 @@ module RuboCop
 
           def on_send(node)
             name_property_with_default?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              add_offense(node, location: :expression, message: MSG, severity: :warning)
             end
           end
 

data/lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb

@@ -48,11 +48,11 @@ module RuboCop
 
           def on_send(node)
             node_deep_fetch?(node) do
-              add_offense(node, location: :selector, message: MSG, severity: :refactor)
+              add_offense(node, location: :selector, message: MSG, severity: :warning)
             end
 
             node_deep_fetch_bang?(node) do
-              add_offense(node, location: :selector, message: MSG2, severity: :refactor)
+              add_offense(node, location: :selector, message: MSG2, severity: :warning)
             end
           end
 

data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb

@@ -45,7 +45,7 @@ module RuboCop
 
           def on_send(node)
             node_ohai_methods?(node) do
-              add_offense(node, location: :selector, message: MSG, severity: :refactor)
+              add_offense(node, location: :selector, message: MSG, severity: :warning)
             end
           end
 

data/lib/rubocop/cop/chef/deprecation/node_set.rb

@@ -39,7 +39,7 @@ module RuboCop
 
           def on_send(node)
             node_set?(node) do
-              add_offense(node, location: :selector, message: MSG, severity: :refactor)
+              add_offense(node, location: :selector, message: MSG, severity: :warning)
             end
           end
 

data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb

@@ -39,7 +39,7 @@ module RuboCop
 
           def on_send(node)
             node_set_unless?(node) do
-              add_offense(node, location: :selector, message: MSG, severity: :refactor)
+              add_offense(node, location: :selector, message: MSG, severity: :warning)
             end
           end
 

data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb

@@ -54,9 +54,9 @@ module RuboCop
 
           def add_offense_for_bare_assignment(sub_node)
             if sub_node.receiver == s(:send, nil, :node) # node['foo'] scenario
-              add_offense(sub_node.receiver, location: :selector, message: MSG, severity: :refactor)
+              add_offense(sub_node.receiver, location: :selector, message: MSG, severity: :warning)
             elsif sub_node.receiver && sub_node.receiver&.node_parts[0] == s(:send, nil, :node) && sub_node.receiver&.node_parts[1] == :[] # node['foo']['bar'] scenario
-              add_offense(sub_node.receiver.node_parts.first, location: :selector, message: MSG, severity: :refactor)
+              add_offense(sub_node.receiver.node_parts.first, location: :selector, message: MSG, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb

@@ -55,7 +55,7 @@ module RuboCop
 
           def on_send(node)
             partial_search_class?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              add_offense(node, location: :expression, message: MSG, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb

@@ -50,7 +50,7 @@ module RuboCop
           MSG = 'Legacy partial_search usage should be updated to use :filter_result in the search helper instead'.freeze
 
           def on_send(node)
-            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :partial_search
+            add_offense(node, location: :expression, message: MSG, severity: :warning) if node.method_name == :partial_search
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/poise_archive.rb

@@ -43,13 +43,13 @@ module RuboCop
 
           def on_send(node)
             depends_poise_archive?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              add_offense(node, location: :expression, message: MSG, severity: :warning)
             end
           end
 
           def on_block(node)
             match_resource_type?(:poise_archive, node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              add_offense(node, location: :expression, message: MSG, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/require_recipe.rb

@@ -37,7 +37,7 @@ module RuboCop
           PATTERN
 
           def on_send(node)
-            require_recipe?(node) { add_offense(node, location: :selector, message: MSG, severity: :refactor) }
+            require_recipe?(node) { add_offense(node, location: :selector, message: MSG, severity: :warning) }
           end
 
           def autocorrect(node)

data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb

@@ -37,7 +37,7 @@ module RuboCop
 
           def on_def(node)
             if node.method_name == :provides?
-              add_offense(node, location: :expression, message: MSG, severity: :refactor) if provides(processed_source.ast).count == 0
+              add_offense(node, location: :expression, message: MSG, severity: :warning) if provides(processed_source.ast).count == 0
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb

@@ -32,7 +32,7 @@ module RuboCop
           MSG = 'Use resource_name instead of the dsl_name method in resources. This will cause failures in Chef Infra Client 13 and later.'.freeze
 
           def on_send(node)
-            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :dsl_name
+            add_offense(node, location: :expression, message: MSG, severity: :warning) if node.method_name == :dsl_name
           end
 
           # potential autocorrect is new_resource.updated_by_last_action true, but we need to actually see what class we were called from

data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb

@@ -29,7 +29,7 @@ module RuboCop
           MSG = "Don't use the deprecated provider_base method in a resource to specify the provider module to use. Instead, the provider should call provides to register itself, or the resource should call provider to specify the provider to use. This will cause failures in Chef Infra Client 13 and later.".freeze
 
           def on_send(node)
-            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :provider_base
+            add_offense(node, location: :expression, message: MSG, severity: :warning) if node.method_name == :provider_base
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb

@@ -37,7 +37,7 @@ module RuboCop
           MSG = "Don't use updated = true/false to update resource state. This will cause failures in Chef Infra Client 13 and later.".freeze
 
           def on_lvasgn(node)
-            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.node_parts.first == :updated
+            add_offense(node, location: :expression, message: MSG, severity: :warning) if node.node_parts.first == :updated
           end
 
           # potential autocorrect is new_resource.updated_by_last_action true, but we need to actually see what class we were called from

data/lib/rubocop/cop/chef/deprecation/resource_without_name_or_provides.rb

@@ -0,0 +1,81 @@
+#
+# Copyright:: 2020, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module RuboCop
+  module Cop
+    module Chef
+      module ChefDeprecations
+        # In Chef Infra Client 16 and later a legacy HWRP resource must use either `resource_name` or `provides` to define the resource name.
+        #
+        # @example
+        #
+        #   # bad
+        #   class Chef
+        #     class Resource
+        #       class UlimitRule < Chef::Resource
+        #         property :type, [Symbol, String], required: true
+        #         property :item, [Symbol, String], required: true
+        #
+        #         # additional resource code
+        #       end
+        #     end
+        #   end
+        #
+        #  # good
+        #   class Chef
+        #     class Resource
+        #       class UlimitRule < Chef::Resource
+        #         resource_name :ulimit_rule
+        #
+        #         property :type, [Symbol, String], required: true
+        #         property :item, [Symbol, String], required: true
+        #
+        #         # additional resource code
+        #       end
+        #     end
+        #   end
+        #
+        #  # better
+        #  Convert your legacy HWRPs to custom resources
+        #
+        class ResourceWithoutNameOrProvides < Cop
+          MSG = 'In Chef Infra Client 16 and later legacy HWRP resources must use either `resource_name` or `provides` to define the resource name.'.freeze
+
+          def_node_matcher :HWRP?, <<-PATTERN
+          (class
+            (const nil? :Chef) nil?
+            (class
+              (const nil? :Resource) nil?
+              $(class
+                (const nil? ... )
+                (const
+                  (const nil? :Chef) :Resource)
+                  (begin ... ))))
+          PATTERN
+
+          def_node_search :provides_or_resource_name?, '(send nil? {:provides :resource_name} ...)'
+
+          def on_class(node)
+            HWRP?(node) do |inherit|
+              add_offense(inherit, location: :expression, message: MSG, severity: :warning) if provides_or_resource_name?(processed_source.ast).nil?
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb

@@ -47,7 +47,7 @@ module RuboCop
           def on_block(node)
             match_property_in_resource?(:ruby_block, 'action', node) do |ruby_action|
               ruby_action.arguments.each do |action|
-                add_offense(action, location: :expression, message: MSG, severity: :refactor) if action.source == ':create'
+                add_offense(action, location: :expression, message: MSG, severity: :warning) if action.source == ':create'
               end
             end
           end

data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb

@@ -43,15 +43,15 @@ module RuboCop
 
           def on_send(node)
             calls_run_command?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor) unless defines_run_command?(processed_source.ast)
+              add_offense(node, location: :expression, message: MSG, severity: :warning) unless defines_run_command?(processed_source.ast)
             end
 
             require_mixin_command?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              add_offense(node, location: :expression, message: MSG, severity: :warning)
             end
 
             include_mixin_command?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              add_offense(node, location: :expression, message: MSG, severity: :warning)
             end
           end
         end