cookbook-omnifetch 0.8.0 → 0.8.1

data/spec/unit/exceptions_spec.rb

@@ -1,87 +0,0 @@
-require "spec_helper"
-require "cookbook-omnifetch/exceptions"
-
-module CookbookOmnifetch
-  describe "Exceptions" do
-
-    describe NotACookbook do
-
-      subject(:exception) do
-        described_class.new("/path/to/cookbook")
-      end
-
-      let(:message) do
-        "The resource at '/path/to/cookbook' does not appear to be a valid cookbook. Does it have a metadata.rb?"
-      end
-
-      it "creates an informative error in #message" do
-        expect(exception.message).to eq(message)
-      end
-
-      it "creates an informative error in #to_s" do
-        expect(exception.to_s).to eq(message)
-      end
-
-    end
-
-    describe CookbookValidationFailure do
-
-      let(:dependency) { instance_double("ChefDK::Policyfile::CookbookLocationSpecification", to_s: "apt ~> 1.2.3") }
-
-      # The exception class itself doesn't use this
-      let(:cached_cookbook) { Object.new }
-
-      subject(:exception) do
-        described_class.new(dependency, cached_cookbook)
-      end
-
-      let(:message) do
-        "The cookbook downloaded for apt ~> 1.2.3 did not satisfy the constraint."
-      end
-
-      it "creates an informative error in #message" do
-        expect(exception.message).to eq(message)
-      end
-
-      it "creates an informative error in #to_s" do
-        expect(exception.to_s).to eq(message)
-      end
-
-    end
-
-    describe MismatchedCookbookName do
-
-      let(:dependency) { instance_double("ChefDK::Policyfile::CookbookLocationSpecification", name: "apt") }
-
-      let(:cached_cookbook) { instance_double("Chef::Cookbook", cookbook_name: "apt") }
-
-      subject(:exception) do
-        described_class.new(dependency, cached_cookbook)
-      end
-
-      let(:message) do
-        <<-EOM
-In your Berksfile, you have:
-
-  cookbook 'apt'
-
-But that cookbook is actually named 'apt'
-
-This can cause potentially unwanted side-effects in the future.
-
-NOTE: If you do not explicitly set the 'name' attribute in the metadata, the name of the directory will be used instead. This is often a cause of confusion for dependency solving.
-EOM
-      end
-
-      it "creates an informative error in #message" do
-        expect(exception.message).to eq(message)
-      end
-
-      it "creates an informative error in #to_s" do
-        expect(exception.to_s).to eq(message)
-      end
-
-    end
-
-  end
-end

data/spec/unit/git_spec.rb

@@ -1,290 +0,0 @@
-require "spec_helper"
-require "cookbook-omnifetch/git"
-
-module CookbookOmnifetch
-  describe GitLocation do
-    let(:dependency) { double(name: "bacon") }
-
-    subject do
-      described_class.new(dependency, git: "https://repo.com", branch: "ham",
-                                      tag: "v1.2.3", ref: "abc123", revision: "defjkl123456", rel: "hi")
-    end
-
-    describe ".initialize" do
-      it "sets the uri" do
-        instance = described_class.new(dependency, git: "https://repo.com")
-        expect(instance.uri).to eq("https://repo.com")
-      end
-
-      it "sets the branch" do
-        instance = described_class.new(dependency,
-          git: "https://repo.com", branch: "magic_new_feature")
-        expect(instance.branch).to eq("magic_new_feature")
-      end
-
-      it "sets the tag" do
-        instance = described_class.new(dependency,
-          git: "https://repo.com", tag: "v1.2.3")
-        expect(instance.tag).to eq("v1.2.3")
-      end
-
-      it "adds the ref" do
-        instance = described_class.new(dependency,
-          git: "https://repo.com", ref: "abc123")
-        expect(instance.ref).to eq("abc123")
-      end
-
-      it "sets the revision" do
-        instance = described_class.new(dependency,
-          git: "https://repo.com", revision: "abcde12345")
-        expect(instance.revision).to eq("abcde12345")
-      end
-
-      it "sets the rel" do
-        instance = described_class.new(dependency,
-          git: "https://repo.com", rel: "internal/path")
-        expect(instance.rel).to eq("internal/path")
-      end
-
-      context "rev_parse" do
-        def rev_parse(instance)
-          instance.instance_variable_get(:@rev_parse)
-        end
-
-        it "uses the :ref option with priority" do
-          instance = described_class.new(dependency,
-            git: "https://repo.com", ref: "abc123", branch: "magic_new_feature")
-          expect(rev_parse(instance)).to eq("abc123")
-        end
-
-        it "uses the :branch option with priority" do
-          instance = described_class.new(dependency,
-            git: "https://repo.com", branch: "magic_new_feature", tag: "v1.2.3")
-          expect(rev_parse(instance)).to eq("magic_new_feature")
-        end
-
-        it "uses the :tag option" do
-          instance = described_class.new(dependency,
-            git: "https://repo.com", tag: "v1.2.3")
-          expect(rev_parse(instance)).to eq("v1.2.3")
-        end
-
-        it 'uses "master" when none is given' do
-          instance = described_class.new(dependency, git: "https://repo.com")
-          expect(rev_parse(instance)).to eq("master")
-        end
-      end
-    end
-
-    describe "#cache_key" do
-
-      it "concatenates the name and revision" do
-        subject.stub(:revision).and_return("abcdef123456")
-        expect(subject.cache_key).to eq("bacon-abcdef123456")
-      end
-    end
-
-    describe "#installed?" do
-      it "returns false when there is no revision" do
-        subject.stub(:revision).and_return(nil)
-        expect(subject.installed?).to be false
-      end
-
-      it "returns false when the install_path does not exist" do
-        subject.stub(:revision).and_return("abcd1234")
-        subject.stub(:install_path).and_return(double(exist?: false))
-        expect(subject.installed?).to be false
-      end
-
-      it "returns true when the location is installed" do
-        subject.stub(:revision).and_return("abcd1234")
-        subject.stub(:install_path).and_return(double(exist?: true))
-        expect(subject.installed?).to be true
-      end
-    end
-
-    describe "#install" do
-      before do
-        File.stub(:chmod)
-        FileUtils.stub(:cp_r)
-        subject.stub(:validate_cached!)
-        subject.stub(:git)
-      end
-
-      context "when the repository is cached" do
-        it "pulls a new version" do
-          Dir.stub(:chdir) { |args, &b| b.call } # Force eval the chdir block
-
-          subject.stub(:cached?).and_return(true)
-          expect(subject).to receive(:git).with(
-            'fetch --force --tags https://repo.com "refs/heads/*:refs/heads/*"'
-          )
-          subject.install
-        end
-      end
-
-      context "when the revision is not cached" do
-        it "clones the repository" do
-          Dir.stub(:chdir) { |args, &b| b.call } # Force eval the chdir block
-
-          cache_path = subject.send(:cache_path)
-          subject.stub(:cached?).and_return(false)
-          expect(subject).to receive(:git).with(
-            %{clone https://repo.com "#{cache_path}" --bare --no-hardlinks}
-          )
-          subject.install
-        end
-      end
-    end
-
-    describe "#cached_cookbook" do
-      it "returns nil if the cookbook is not installed" do
-        subject.stub(:installed?).and_return(false)
-        expect(subject.cached_cookbook).to be_nil
-      end
-
-      it "returns the cookbook at the install_path" do
-        subject.stub(:installed?).and_return(true)
-        MockCachedCookbook.stub(:from_path)
-
-        expect(MockCachedCookbook).to receive(:from_path).once
-        subject.cached_cookbook
-      end
-    end
-
-    describe "#==" do
-      let(:other) { subject.dup }
-
-      it "returns true when everything matches" do
-        expect(subject).to eq(other)
-      end
-
-      it "returns false when the other location is not an GitLocation" do
-        other.stub(:is_a?).and_return(false)
-        expect(subject).to_not eq(other)
-      end
-
-      it "returns false when the uri is different" do
-        other.stub(:uri).and_return("different")
-        expect(subject).to_not eq(other)
-      end
-
-      it "returns false when the branch is different" do
-        other.stub(:branch).and_return("different")
-        expect(subject).to_not eq(other)
-      end
-
-      it "returns false when the tag is different" do
-        other.stub(:tag).and_return("different")
-        expect(subject).to_not eq(other)
-      end
-
-      it "returns false when the ref is different" do
-        other.stub(:ref).and_return("different")
-        expect(subject).to_not eq(other)
-      end
-
-      it "returns false when the rel is different" do
-        other.stub(:rel).and_return("different")
-        expect(subject).to_not eq(other)
-      end
-    end
-
-    describe "#to_s" do
-      it "prefers the tag" do
-        expect(subject.to_s).to eq("https://repo.com (at v1.2.3/hi)")
-      end
-
-      it "prefers the branch" do
-        subject.stub(:tag).and_return(nil)
-        expect(subject.to_s).to eq("https://repo.com (at ham/hi)")
-      end
-
-      it "falls back to the ref" do
-        subject.stub(:tag).and_return(nil)
-        subject.stub(:branch).and_return(nil)
-        expect(subject.to_s).to eq("https://repo.com (at abc123/hi)")
-      end
-
-      it "does not use the rel if missing" do
-        subject.stub(:rel).and_return(nil)
-        expect(subject.to_s).to eq("https://repo.com (at v1.2.3)")
-      end
-    end
-
-    describe "#to_lock" do
-      it "includes all the information" do
-        expect(subject.to_lock).to eq <<-EOH.gsub(/^ {8}/, "")
-            git: https://repo.com
-            revision: defjkl123456
-            ref: abc123
-            branch: ham
-            tag: v1.2.3
-            rel: hi
-        EOH
-      end
-
-      it "does not include the branch if missing" do
-        subject.stub(:branch).and_return(nil)
-        expect(subject.to_lock).to_not include("branch")
-      end
-
-      it "does not include the tag if missing" do
-        subject.stub(:tag).and_return(nil)
-        expect(subject.to_lock).to_not include("tag")
-      end
-
-      it "does not include the rel if missing" do
-        subject.stub(:rel).and_return(nil)
-        expect(subject.to_lock).to_not include("rel")
-      end
-    end
-
-    describe "#lock_data" do
-      let(:full_lock_data) do
-        {
-          "git" => "https://repo.com",
-          "revision" => "defjkl123456",
-          "ref" => "abc123",
-          "branch" => "ham",
-          "tag" => "v1.2.3",
-          "rel" => "hi",
-        }
-      end
-
-      it "includes all the information" do
-        expect(subject.lock_data).to eq(full_lock_data)
-      end
-
-      it "does not include the branch if missing" do
-        subject.stub(:branch).and_return(nil)
-        expect(subject.lock_data).to_not have_key("branch")
-      end
-
-      it "does not include the tag if missing" do
-        subject.stub(:tag).and_return(nil)
-        expect(subject.lock_data).to_not have_key("tag")
-      end
-
-      it "does not include the rel if missing" do
-        subject.stub(:rel).and_return(nil)
-        expect(subject.lock_data).to_not have_key("rel")
-      end
-    end
-
-    describe "#git" do
-      before { described_class.send(:public, :git) }
-
-      it "raises an error if Git is not installed" do
-        CookbookOmnifetch.stub(:which).and_return(false)
-        expect { subject.git("foo") }.to raise_error(GitNotInstalled)
-      end
-
-      it "raises an error if the command fails" do
-        shell_out = double("shell_out", success?: false, stderr: nil)
-        MockShellOut.stub(:shell_out).and_return(shell_out)
-        expect { subject.git("foo") }.to raise_error(GitCommandError)
-      end
-    end
-  end
-end

data/spec/unit/metadata_based_installer_spec.rb

@@ -1,137 +0,0 @@
-require "spec_helper"
-require "cookbook-omnifetch/metadata_based_installer.rb"
-
-RSpec.shared_context "sample_metadata" do
-
-  let(:raw_metadata) do
-    {
-      "recipes" => [
-        { "name" => "default.rb", "path" => "recipes/default.rb", "checksum" => "a6be794cdd2eb44d38fdf17f792a0d0d", "specificity" => "default", "url" => "https://example.com/recipes/default.rb" },
-      ],
-      "root_files" => [
-        { "name" => "metadata.rb", "path" => "metadata.rb", "checksum" => "5b346119e5e41ab99500608decac8dca", "specificity" => "default", "url" => "https://example.com/metadata.rb" },
-      ],
-    }
-
-  end
-end
-
-RSpec.describe CookbookOmnifetch::MetadataBasedInstaller::CookbookMetadata do
-
-  include_context "sample_metadata"
-
-  subject(:cb_metadata) { described_class.new(raw_metadata) }
-
-  it "yields a set of paths and urls" do
-    expect { |b| cb_metadata.files(&b) }.to yield_successive_args(["https://example.com/recipes/default.rb", "recipes/default.rb"], ["https://example.com/metadata.rb", "metadata.rb"])
-  end
-end
-
-RSpec.describe CookbookOmnifetch::MetadataBasedInstaller do
-
-  include_context "sample_metadata"
-
-  let(:url_path) { "/cookbooks/example/0.5.0" }
-
-  let(:http_client) do
-    double("Http Client")
-  end
-
-  let(:recipe_url) do
-    raw_metadata["recipes"][0]["url"]
-  end
-
-  let(:recipe_path) do
-    raw_metadata["recipes"][0]["path"]
-  end
-
-  let(:recipe_filehandle) do
-    File.open(File.join(remote_path, recipe_path))
-  end
-
-  let(:root_file_url) do
-    raw_metadata["root_files"][0]["url"]
-  end
-
-  let(:root_file_path) do
-    raw_metadata["root_files"][0]["path"]
-  end
-
-  let(:root_file_filehandle) do
-    File.open(File.join(remote_path, root_file_path))
-  end
-
-  let(:cookbook_fixture_path) { fixtures_path.join("cookbooks/example_cookbook") }
-
-  let(:test_root) { Dir.mktmpdir(nil) }
-
-  let(:cache_path) { File.join(test_root, "cache") }
-
-  let(:remote_path) { File.join(test_root, "remote") }
-
-  let(:install_path) { File.join(test_root, "install_path") }
-
-  let(:cookbook_files) { %w{metadata.rb recipes recipes/default.rb} }
-
-  let(:expected_installed_files) do
-    cookbook_files.map do |file|
-      File.join(install_path, file)
-    end
-  end
-
-  subject(:installer) do
-    described_class.new(http_client: http_client,
-                        url_path: url_path,
-                        install_path: install_path)
-  end
-
-  before do
-    FileUtils.cp_r(cookbook_fixture_path, remote_path)
-
-    allow(CookbookOmnifetch).to receive(:cache_path).and_return(cache_path)
-  end
-
-  after do
-    FileUtils.rm_r(test_root)
-  end
-
-  it "stages the download to a randomized location" do
-    Kernel.srand(0)
-    expected_path = Pathname.new(cache_path).join(".cache_tmp/metadata-installer/_cookbooks_example_0_5_0_209652396")
-
-    expect(installer.staging_path).to eq(expected_path)
-
-    next_installer = described_class.new(http_client: http_client,
-                                         url_path: url_path,
-                                         install_path: install_path)
-
-    next_expected_path = Pathname.new(cache_path).join(".cache_tmp/metadata-installer/_cookbooks_example_0_5_0_398764591")
-    expect(next_installer.staging_path).to eq(next_expected_path)
-  end
-
-  describe "installing the cookbook" do
-
-    before do
-      expect(http_client).to receive(:get).
-        with(url_path).
-        and_return(raw_metadata)
-      expect(http_client).to receive(:streaming_request).
-        with(recipe_url).
-        and_yield(recipe_filehandle)
-      expect(http_client).to receive(:streaming_request).
-        with(root_file_url).
-        and_yield(root_file_filehandle)
-    end
-
-    it "installs the cookbook to the desired install path" do
-      expect(Dir).to_not exist(install_path)
-
-      installer.install
-
-      expect(Dir).to exist(install_path)
-      expect(Dir.glob("#{install_path}/**/*")).to match_array(expected_installed_files)
-    end
-
-  end
-
-end