cookbook-omnifetch 0.8.0 → 0.8.1

data/spec/fixtures/cookbooks/example_cookbook/metadata.rb

@@ -1,3 +0,0 @@
-name       "example_cookbook"
-maintainer "Berkshelf Core"
-version    "0.5.0"

data/spec/fixtures/cookbooks/example_cookbook/recipes/default.rb

@@ -1,8 +0,0 @@
-#
-# Cookbook Name:: example_cookbook
-# Recipe:: default
-#
-# Copyright 2012, YOUR_COMPANY_NAME
-#
-# All rights reserved - Do Not Redistribute
-#

data/spec/spec_helper.rb

@@ -1,43 +0,0 @@
-require "cookbook-omnifetch"
-
-module Fixtures
-
-  def fixtures_path
-    spec_root.join("fixtures")
-  end
-
-  def spec_root
-    Pathname.new(File.expand_path(File.dirname(__FILE__)))
-  end
-
-end
-
-module MockShellOut; end
-module MockCachedCookbook; end
-
-RSpec.configure do |config|
-
-  config.raise_errors_for_deprecations!
-
-  config.include Fixtures
-
-  config.expect_with :rspec do |c|
-    c.syntax = [:expect]
-  end
-  config.mock_with :rspec do |c|
-    c.syntax = [:expect, :should]
-  end
-
-  config.filter_run :focus => true
-
-  config.run_all_when_everything_filtered = true
-
-  config.before(:suite) do
-    CookbookOmnifetch.configure do |c|
-      c.cache_path = File.expand_path("~/.berkshelf")
-      c.storage_path = Pathname.new(File.expand_path("~/.berkshelf/cookbooks"))
-      c.shell_out_class = MockShellOut
-      c.cached_cookbook_class = MockCachedCookbook
-    end
-  end
-end

data/spec/unit/artifactory_spec.rb

@@ -1,64 +0,0 @@
-require "spec_helper"
-require "cookbook-omnifetch/artifactory"
-require "zlib"
-require "archive/tar/minitar"
-
-module CookbookOmnifetch
-  describe ArtifactoryLocation do
-
-    let(:cookbook_name) { "nginx" }
-
-    let(:cookbook_version) { "1.5.23" }
-
-    let(:http_client) { double("Chef::HTTP::Simple") }
-
-    let(:constraint) { double("Constraint") }
-
-    let(:dependency) { double("Dependency", name: cookbook_name, constraint: constraint) }
-
-    let(:url) { "https://artifactory.example.com/api/v1/cookbooks/nginx/versions/1.5.23/download" }
-
-    let(:options) { { artifactory: url, version: cookbook_version, http_client: http_client } }
-
-    subject(:public_repo_location) { described_class.new(dependency, options) }
-
-    it "has a URI" do
-      expect(public_repo_location.uri).to eq(url)
-    end
-
-    it "has a repo host" do
-      expect(public_repo_location.repo_host).to eq("artifactory.example.com")
-    end
-
-    it "has an exact version" do
-      expect(public_repo_location.cookbook_version).to eq("1.5.23")
-    end
-
-    it "has a cache key containing the site URI and version" do
-      expect(public_repo_location.cache_key).to eq("nginx-1.5.23-artifactory.example.com")
-    end
-
-    it "sets the install location as the cache path plus cache key" do
-      expected_install_path = Pathname.new("~/.berkshelf/cookbooks").expand_path.join("nginx-1.5.23-artifactory.example.com")
-      expect(public_repo_location.install_path).to eq(expected_install_path)
-    end
-
-    it "considers the cookbook installed if it exists in the main cache" do
-      expect(public_repo_location.install_path).to receive(:exist?).and_return(true)
-      expect(public_repo_location.installed?).to be true
-    end
-
-    it "considers the cookbook not installed if it doesn't exist in the main cache" do
-      expect(public_repo_location.install_path).to receive(:exist?).and_return(false)
-      expect(public_repo_location.installed?).to be false
-    end
-
-    it "provides lock data as a Hash" do
-      expected_data = {
-        "artifactory" => url,
-        "version" => "1.5.23",
-      }
-      expect(public_repo_location.lock_data).to eq(expected_data)
-    end
-  end
-end

data/spec/unit/artifactserver_spec.rb

@@ -1,116 +0,0 @@
-require "spec_helper"
-require "cookbook-omnifetch/artifactserver"
-require "zlib"
-require "archive/tar/minitar"
-
-module CookbookOmnifetch
-  describe ArtifactserverLocation do
-
-    let(:cookbook_name) { "nginx" }
-
-    let(:cookbook_version) { "1.5.23" }
-
-    let(:constraint) { double("Constraint") }
-
-    let(:dependency) { double("Dependency", name: cookbook_name, constraint: constraint) }
-
-    let(:url) { "https://supermarket.getchef.com/api/v1/cookbooks/nginx/versions/1.5.23/download" }
-
-    let(:options) { { artifactserver: url, version: cookbook_version } }
-
-    subject(:public_repo_location) { described_class.new(dependency, options) }
-
-    it "has a URI" do
-      expect(public_repo_location.uri).to eq(url)
-    end
-
-    it "has a repo host" do
-      expect(public_repo_location.repo_host).to eq("supermarket.getchef.com")
-    end
-
-    it "has an exact version" do
-      expect(public_repo_location.cookbook_version).to eq("1.5.23")
-    end
-
-    it "has a cache key containing the site URI and version" do
-      expect(public_repo_location.cache_key).to eq("nginx-1.5.23-supermarket.getchef.com")
-    end
-
-    it "sets the install location as the cache path plus cache key" do
-      expected_install_path = Pathname.new("~/.berkshelf/cookbooks").expand_path.join("nginx-1.5.23-supermarket.getchef.com")
-      expect(public_repo_location.install_path).to eq(expected_install_path)
-    end
-
-    it "considers the cookbook installed if it exists in the main cache" do
-      expect(public_repo_location.install_path).to receive(:exist?).and_return(true)
-      expect(public_repo_location.installed?).to be true
-    end
-
-    it "considers the cookbook not installed if it doesn't exist in the main cache" do
-      expect(public_repo_location.install_path).to receive(:exist?).and_return(false)
-      expect(public_repo_location.installed?).to be false
-    end
-
-    it "provides lock data as a Hash" do
-      expected_data = {
-        "artifactserver" => url,
-        "version" => "1.5.23",
-      }
-      expect(public_repo_location.lock_data).to eq(expected_data)
-    end
-
-    context "when asked to install a new cookbook" do
-
-      let(:http_client) { double("Http Client") }
-
-      let(:test_root) { Dir.mktmpdir(nil) }
-
-      let(:storage_path) { File.join(test_root, "storage") }
-
-      let(:cache_path) { File.join(test_root, "cache") }
-
-      let(:cookbook_fixtures_path) { fixtures_path.join("cookbooks") }
-
-      let(:cookbook_name) { "example_cookbook" }
-
-      let(:cookbook_version) { "0.5.0" }
-
-      let(:cookbook_tarball_handle) do
-        gz_file_name = File.join(test_root, "input.gz")
-        Zlib::GzipWriter.open(gz_file_name) do |gz|
-          # Minitar writes the full paths provided and doesn't seem to have a way to
-          # remove prefixes.  So we chdir like barbarians.
-          Dir.chdir(cookbook_fixtures_path) do
-            Archive::Tar::Minitar.pack(cookbook_name, gz)
-          end
-        end
-        File.open(gz_file_name)
-      end
-
-      let(:cookbook_files) { %w{. .. .gitignore .kitchen.yml Berksfile Berksfile.lock metadata.rb README.md recipes} }
-
-      before do
-        allow(CookbookOmnifetch).to receive(:storage_path).and_return(Pathname.new(storage_path))
-        allow(CookbookOmnifetch).to receive(:cache_path).and_return(cache_path)
-        FileUtils.mkdir_p(storage_path)
-      end
-
-      after do
-        FileUtils.rm_r(test_root)
-      end
-
-      it "installs the cookbook to the desired install path" do
-        expect(public_repo_location).to receive(:http_client).and_return(http_client)
-        expect(cookbook_tarball_handle).to receive(:close).and_call_original
-        expect(http_client).to receive(:streaming_request).with(nil).and_yield(cookbook_tarball_handle)
-        expect(public_repo_location).to receive(:validate_cached!)
-
-        public_repo_location.install
-
-        expect(File).to exist(public_repo_location.cache_path)
-        expect(Dir).to exist(public_repo_location.install_path)
-        expect(Dir.entries(public_repo_location.install_path)).to match_array(cookbook_files)
-      end
-    end
-  end
-end

data/spec/unit/base_spec.rb

@@ -1,87 +0,0 @@
-require "spec_helper"
-require "cookbook-omnifetch/base"
-
-module CookbookOmnifetch
-  describe BaseLocation do
-    let(:constraint) { double("constraint") }
-    let(:dependency) { double("dependency", name: "cookbook", version_constraint: constraint) }
-
-    subject { described_class.new(dependency) }
-
-    describe "#installed?" do
-      it "is an abstract function" do
-        expect { subject.installed? }.to raise_error(AbstractFunction)
-      end
-    end
-
-    describe "#install" do
-      it "is an abstract function" do
-        expect { subject.install }.to raise_error(AbstractFunction)
-      end
-    end
-
-    describe "#cached_cookbook" do
-      it "is an abstract function" do
-        expect { subject.cached_cookbook }.to raise_error(AbstractFunction)
-      end
-    end
-
-    describe "#to_lock" do
-      it "is an abstract function" do
-        expect { subject.to_lock }.to raise_error(AbstractFunction)
-      end
-    end
-
-    describe "#lock_data" do
-      it "is an abstract function" do
-        expect { subject.lock_data }.to raise_error(AbstractFunction)
-      end
-    end
-
-    describe "#validate_cached!" do
-      context "when the path is not a cookbook" do
-        before { CookbookOmnifetch.stub(:cookbook?).and_return(false) }
-
-        it "raises an error" do
-          expect do
-            subject.validate_cached!("/foo/bar")
-          end.to raise_error(NotACookbook)
-        end
-      end
-
-      context "when the path is a cookbook" do
-        let(:cookbook) do
-          double("cookbook",
-            cookbook_name: "cookbook",
-            version: "0.1.0"
-          )
-        end
-
-        before do
-          CookbookOmnifetch.stub(:cookbook?).and_return(true)
-          MockCachedCookbook.stub(:from_path).and_return(cookbook)
-        end
-
-        it "raises an error if the constraint does not satisfy" do
-          constraint.stub(:satisfies?).with("0.1.0").and_return(false)
-          expect do
-            subject.validate_cached!(cookbook)
-          end.to raise_error(CookbookValidationFailure)
-        end
-
-        it "raises an error if the names do not match" do
-          constraint.stub(:satisfies?).with("0.1.0").and_return(true)
-          cookbook.stub(:cookbook_name).and_return("different_name")
-          expect do
-            subject.validate_cached!(cookbook)
-          end.to raise_error(MismatchedCookbookName)
-        end
-
-        it "returns true when the validation succeeds" do
-          constraint.stub(:satisfies?).with("0.1.0").and_return(true)
-          expect(subject.validate_cached!(cookbook)).to be true
-        end
-      end
-    end
-  end
-end

data/spec/unit/chef_server_artifact_spec.rb

@@ -1,110 +0,0 @@
-require "spec_helper"
-require "cookbook-omnifetch/chef_server.rb"
-
-RSpec.describe CookbookOmnifetch::ChefServerArtifactLocation do
-
-  let(:http_client) { double("Http Client") }
-
-  let(:test_root) { "/some/fake/path" }
-
-  let(:storage_path) { File.join(test_root, "storage") }
-
-  let(:dependency) { double("Dependency", name: cookbook_name) }
-
-  let(:cookbook_name) { "example" }
-
-  let(:cookbook_identifier) { "467dc855408ce8b74f991c5dc2fd72a6aa369b60" }
-
-  let(:url) { "https://chef.example.com/organizations/example" }
-
-  let(:options) { { chef_server_artifact: url, identifier: cookbook_identifier, http_client: http_client } }
-
-  let(:expected_cache_key) { "example-467dc855408ce8b74f991c5dc2fd72a6aa369b60" }
-
-  let(:expected_install_path) { File.join(storage_path, expected_cache_key) }
-
-  subject(:chef_server_artifact_location) { described_class.new(dependency, options) }
-
-  before do
-    allow(CookbookOmnifetch).to receive(:storage_path).and_return(Pathname.new(storage_path))
-  end
-
-  it "has a URI" do
-    expect(chef_server_artifact_location.uri).to eq(url)
-  end
-
-  it "has an HTTP client" do
-    expect(chef_server_artifact_location.http_client).to eq(http_client)
-  end
-
-  it "has a metadata_based_installer" do
-    installer = chef_server_artifact_location.installer
-    expect(installer).to be_a(CookbookOmnifetch::MetadataBasedInstaller)
-    expect(installer.http_client).to eq(http_client)
-    expect(installer.url_path).to eq("/cookbook_artifacts/example/467dc855408ce8b74f991c5dc2fd72a6aa369b60")
-    expect(installer.install_path.to_s).to eq(expected_install_path)
-  end
-
-  it "has a cache key containing the site URI and version" do
-    expect(chef_server_artifact_location.cache_key).to eq(expected_cache_key)
-  end
-
-  it "has an identifier" do
-    expect(chef_server_artifact_location.cookbook_identifier).to eq(cookbook_identifier)
-  end
-
-  it "provides lock data as a Hash" do
-    expected_data = {
-      "chef_server_artifact" => url,
-      "identifier" => cookbook_identifier,
-    }
-    expect(chef_server_artifact_location.lock_data).to eq(expected_data)
-  end
-
-  it "returns a cached cookbook object" do
-    expect(MockCachedCookbook).to receive(:from_path).with(Pathname.new(expected_install_path))
-    chef_server_artifact_location.cached_cookbook
-  end
-
-  context "when using the default chef server HTTP client" do
-
-    let(:options) { { chef_server_artifact: url, identifier: cookbook_identifier } }
-
-    let(:default_http_client) { double("Http Client") }
-
-    before do
-      CookbookOmnifetch.integration.default_chef_server_http_client = default_http_client
-    end
-
-    after do
-      CookbookOmnifetch.integration.default_chef_server_http_client = nil
-    end
-
-    it "uses the default http client for requests" do
-      expect(chef_server_artifact_location.http_client).to eq(default_http_client)
-    end
-
-    context "and an http client is explicitly passed" do
-
-      let(:options) { { chef_server: url, identifier: cookbook_identifier, http_client: http_client } }
-
-      it "uses the explicitly passed client instead of the default" do
-        expect(chef_server_artifact_location.http_client).to eq(http_client)
-      end
-
-    end
-  end
-
-  describe "when installing" do
-
-    let(:installer) { instance_double("CookbookOmnifetch::MetadataBasedInstaller") }
-
-    it "delegates to the MetadataBasedInstaller" do
-      allow(chef_server_artifact_location).to receive(:installer).and_return(installer)
-      expect(installer).to receive(:install)
-      chef_server_artifact_location.install
-    end
-
-  end
-
-end

data/spec/unit/chef_server_spec.rb

@@ -1,108 +0,0 @@
-require "spec_helper"
-require "cookbook-omnifetch/chef_server.rb"
-
-RSpec.describe CookbookOmnifetch::ChefServerLocation do
-
-  let(:http_client) { double("Http Client") }
-
-  let(:test_root) { "/some/fake/path" }
-
-  let(:storage_path) { File.join(test_root, "storage") }
-
-  let(:dependency) { double("Dependency", name: cookbook_name) }
-
-  let(:cookbook_name) { "example" }
-
-  let(:cookbook_version) { "0.5.0" }
-
-  let(:url) { "https://chef.example.com/organizations/example" }
-
-  let(:options) { { chef_server: url, version: cookbook_version, http_client: http_client } }
-
-  let(:expected_install_path) { File.join(storage_path, "example-0.5.0") }
-
-  subject(:chef_server_location) { described_class.new(dependency, options) }
-
-  before do
-    allow(CookbookOmnifetch).to receive(:storage_path).and_return(Pathname.new(storage_path))
-  end
-
-  it "has a URI" do
-    expect(chef_server_location.uri).to eq(url)
-  end
-
-  it "has an HTTP client" do
-    expect(chef_server_location.http_client).to eq(http_client)
-  end
-
-  it "has a metadata_based_installer" do
-    installer = chef_server_location.installer
-    expect(installer).to be_a(CookbookOmnifetch::MetadataBasedInstaller)
-    expect(installer.http_client).to eq(http_client)
-    expect(installer.url_path).to eq("/cookbooks/example/0.5.0")
-    expect(installer.install_path.to_s).to eq(expected_install_path)
-  end
-
-  it "has a cache key containing the site URI and version" do
-    expect(chef_server_location.cache_key).to eq("example-0.5.0")
-  end
-
-  it "has an exact version" do
-    expect(chef_server_location.cookbook_version).to eq("0.5.0")
-  end
-
-  it "provides lock data as a Hash" do
-    expected_data = {
-      "chef_server" => url,
-      "version" => "0.5.0",
-    }
-    expect(chef_server_location.lock_data).to eq(expected_data)
-  end
-
-  it "returns a cached cookbook object" do
-    expect(MockCachedCookbook).to receive(:from_path).with(Pathname.new(expected_install_path))
-    chef_server_location.cached_cookbook
-  end
-
-  context "when using the default chef server HTTP client" do
-
-    let(:options) { { chef_server_artifact: url, version: cookbook_version } }
-
-    let(:default_http_client) { double("Http Client") }
-
-    before do
-      CookbookOmnifetch.integration.default_chef_server_http_client = default_http_client
-    end
-
-    after do
-      CookbookOmnifetch.integration.default_chef_server_http_client = nil
-    end
-
-    it "uses the default http client for requests" do
-      expect(chef_server_location.http_client).to eq(default_http_client)
-    end
-
-    context "and an http client is explicitly passed" do
-
-      let(:options) { { chef_server: url, version: cookbook_version, http_client: http_client } }
-
-      it "uses the explicitly passed client instead of the default" do
-        expect(chef_server_location.http_client).to eq(http_client)
-      end
-
-    end
-  end
-
-  describe "when installing" do
-
-    let(:installer) { instance_double("CookbookOmnifetch::MetadataBasedInstaller") }
-
-    it "delegates to the MetadataBasedInstaller" do
-      allow(chef_server_location).to receive(:installer).and_return(installer)
-      expect(installer).to receive(:install)
-      chef_server_location.install
-    end
-
-  end
-
-end