contrast-agent 6.6.4 → 6.8.0

data/lib/contrast/agent/protect/rule/default_scanner.rb

@@ -5,7 +5,7 @@
 # state, indicating a successful attack using SQL or NoSQL Injection.
 #
 # @deprecated RUBY-356: this class and those that extend it are being phased out
-#   in favor of the more performant code in the Service.
+#   in favor of the more performant code in the Agent Library.
 class Contrast::Agent::Protect::Rule::DefaultScanner # rubocop:disable Style/ClassAndModuleChildren
   OPERATOR_PATTERN = %r{[+=*^/%><!-]}.cs__freeze
 

data/lib/contrast/agent/protect/rule/deserialization.rb

@@ -2,6 +2,7 @@
 # frozen_string_literal: true
 
 require 'contrast/agent/protect/rule/base'
+require 'contrast/agent/reporting/details/untrusted_deserialization_details'
 require 'contrast/components/logger'
 
 module Contrast
@@ -42,17 +43,6 @@ module Contrast
           # Used to indicate to TeamServer the gadget is an Arel module
           AREL = 'Arel'
 
-          class << self
-            # @param attack_sample [Contrast::Api::Dtm::RaspRuleSample]
-            # @return [Hash] the details for this specific rule
-            def extract_details attack_sample
-              {
-                  command: attack_sample.untrusted_deserialization.command,
-                  deserializer: attack_sample.untrusted_deserialization.deserializer
-              }
-            end
-          end
-
           # Return the TeamServer understood id / name of this rule.
           # @return [String] the TeamServer understood id / name of this rule.
           def rule_name
@@ -68,9 +58,10 @@ module Contrast
           # Per the spec, this rule applies regardless of input. Only the mode
           # of the rule and code exclusions apply at this point.
           # @return [Boolean] should the rule apply to this call.
-          def infilter? _context
+          def infilter? context
             return false unless enabled?
             return false if protect_excluded_by_code?
+            return false if protect_excluded_by_url?(context)
 
             true
           end
@@ -116,7 +107,7 @@ module Contrast
             ia_result = build_evaluation(gadget_command)
             result = build_attack_with_match(context, ia_result, nil, gadget_command, **kwargs)
             append_to_activity(context, result)
-            cef_logging(result, :successful_attack, gadget_command)
+            cef_logging(result, :successful_attack, value: gadget_command)
             raise(Contrast::SecurityException.new(self, BLOCK_MESSAGE)) if blocked?
           end
 
@@ -125,7 +116,7 @@ module Contrast
           # Build the RaspRuleSample for the detected Deserialization attack.
           # @param context [Contrast::Agent::RequestContext] the request
           #   context in which this attack is occurring.
-          # @param input_analysis_result [Contrast::Api::Settings::InputAnalysisResult]
+          # @param input_analysis_result [Contrast::Agent::Reporting::InputAnalysis]
           #   the result of the analysis done by this rule.
           # @param _candidate_string [nil] unused.
           # @param kwargs [Hash, nil] Hash of inputs used by this rule to flesh
@@ -135,13 +126,13 @@ module Contrast
           #   to render this attack event in TeamServer.
           def build_sample context, input_analysis_result, _candidate_string, **kwargs
             sample = build_base_sample(context, input_analysis_result)
-            sample.untrusted_deserialization = Contrast::Api::Dtm::UntrustedDeserializationDetails.new
+            sample.details = Contrast::Agent::Reporting::Details::UntrustedDeserializationDetails.new
 
             deserializer = Contrast::Utils::StringUtils.protobuf_safe_string(kwargs[:GADGET_TYPE])
-            sample.untrusted_deserialization.deserializer = deserializer
+            sample.details.deserializer = deserializer
 
             command = !!kwargs[:COMMAND_SCOPE]
-            sample.untrusted_deserialization.command = command
+            sample.details.cmd = command
 
             sample
           end
@@ -154,10 +145,10 @@ module Contrast
           # @param gadget_string [String] the input to be deserialized in which
           #   the gadget exists or the command that resulted from deserializing
           #   an input not detected in the initial infilter.
-          # @return [Contrast::Api::Settings::InputAnalysisResult] the result
+          # @return [Contrast::Agent::Reporting::InputAnalysisResult] the result
           #   of the analysis done by this rule.
           def build_evaluation gadget_string
-            ia_result = Contrast::Api::Settings::InputAnalysisResult.new
+            ia_result = Contrast::Agent::Reporting::InputAnalysisResult.new
             ia_result.rule_id = rule_name
             ia_result.input_type = :UNKNOWN
             ia_result.key = INPUT_NAME

data/lib/contrast/agent/protect/rule/http_method_tampering/http_method_tampering_input_classification.rb

@@ -5,7 +5,7 @@ require 'contrast/utils/object_share'
 require 'contrast/agent/protect/input_analyzer/input_analyzer'
 require 'contrast/agent/reporting/attack_result/attack_result'
 require 'contrast/agent/reporting/attack_result/rasp_rule_sample'
-require 'contrast/utils/input_classification'
+require 'contrast/utils/input_classification_base'
 
 module Contrast
   module Agent
@@ -36,7 +36,7 @@ module Contrast
           #
           #     attack_result = build_attack_result ia_result, rule_id
           #
-          #     if Contrast::Api::Settings::ProtectionRule::Mode::BLOCK != Contrast::PROTECT.rule_mode(rule_id)
+          #     if :BLOCK != Contrast::PROTECT.rule_mode(rule_id)
           #       attack_result.response = :EXPLOITED
           #       Contrast::Agent::EXPLOITS.push attack_result
           #       return input_analysis

data/lib/contrast/agent/protect/rule/http_method_tampering.rb

@@ -20,17 +20,6 @@ module Contrast
           #   UNLOCK UPDATE VERSION-CONTROL
           # ].cs__freeze
 
-          class << self
-            # @param attack_sample [Contrast::Api::Dtm::RaspRuleSample]
-            # @return [Hash] the details for this specific rule
-            def extract_details attack_sample
-              {
-                  method: attack_sample.method_tampering.method, # rubocop:disable Security/Object/Method
-                  responseCode: attack_sample.method_tampering.response_code
-              }
-            end
-          end
-
           def rule_name
             NAME
           end

data/lib/contrast/agent/protect/rule/no_sqli/no_sqli_input_classification.rb

@@ -4,7 +4,7 @@
 require 'contrast/utils/object_share'
 require 'contrast/agent/protect/rule/no_sqli'
 require 'contrast/agent/protect/input_analyzer/input_analyzer'
-require 'contrast/utils/input_classification'
+require 'contrast/utils/input_classification_base'
 
 module Contrast
   module Agent
@@ -50,33 +50,26 @@ module Contrast
             NOSQL_WORTH_WATCHING_THRESHOLD = 1
             NOSQL_CONFIDENCE_THRESHOLD = 3
             MAX_DISTANCE = 10
-
-            # Input Classification stage is done to determine if an user input is
-            # WORTHWATCHING or to be ignored.
-            #
-            # @param input_type [Contrast::Agent::Reporting::InputType] The type of the user input.
-            # @param value [String, Array<String>] the value of the input.
-            # @param input_analysis [Contrast::Agent::Reporting::InputAnalysis] Holds all the results from the
-            #                                                       agent analysis from the current
-            #                                                       Request.
-            # @return ia [Contrast::Agent::Reporting::InputAnalysis] with updated results.
-            def classify input_type, value, input_analysis
-              return unless input_analysis.request
-
-              rule_id = Contrast::Agent::Protect::Rule::NoSqli::NAME
-
-              # double check the input to avoid calling match? on array
-              Array(value).each do |val|
-                Array(val).each do |v|
-                  input_analysis.results << nosqli_create_new_input_result(input_analysis.request,
-                                                                           rule_id,
-                                                                           input_type,
-                                                                           v)
-                end
-              end
-
-              input_analysis
-            end
+            DEFAULT_RULE_DEFINITIONS = [
+              {
+                  keywords: [],
+                  name: 'nosql-injection',
+                  patterns: [
+                    {
+                        caseSensitive: false,
+                        id: 'NO-SQLI-1',
+                        score: 1,
+                        value: '(?:\\{\\s*\".*\"\\s*:.*\\})'
+                    },
+                    {
+                        id: 'NO-SQLI-2',
+                        caseSensitive: true,
+                        score: 3,
+                        value: "(?:\"|')?\\$(?:gte|gt|lt|lte|eq|ne|in|nin|where|mod|all|size|exists|type|slice|or)(?:\"|')?\\s*:.*" # rubocop:disable Layout/LineLength
+                    }
+                  ]
+              }
+            ].cs__freeze
 
             private
 
@@ -102,7 +95,7 @@ module Contrast
             # @param value [String, Array<String>] the value of the input.
             #
             # @return res [Contrast::Agent::Reporting::InputAnalysisResult]
-            def nosqli_create_new_input_result request, rule_id, input_type, value
+            def create_new_input_result request, rule_id, input_type, value
               score = evaluate_patterns(value)
               score = evaluate_rules(value, score)
 
@@ -113,8 +106,9 @@ module Contrast
                             else
                               IGNORE
                             end
-
-              new_ia_result(rule_id, input_type, score_level, request.path, value)
+              result = new_ia_result(rule_id, input_type, score_level, request.path, value)
+              add_needed_key(request, result, input_type, value)
+              result
             end
 
             # This method evaluates the patterns relevant to NoSQL Injection to check whether
@@ -125,7 +119,7 @@ module Contrast
             # point is returned.
             #
             # @param value [String] the value of the input.
-            # @param value [Integer] the total score thus far.
+            # @param total_score [Integer] the total score thus far.
             #
             # @return res [Integer]
             def evaluate_patterns value, total_score = 0
@@ -159,7 +153,7 @@ module Contrast
             # point is returned.
             #
             # @param value [String] the value of the input.
-            # @param value [Integer] the total score thus far.
+            # @param total_score [Integer] the total score thus far.
             #
             # @return res [Integer]
             def evaluate_rules value, total_score = 0
@@ -209,7 +203,8 @@ module Contrast
             def nosqli_patterns
               server_features = Contrast::Agent::Reporting::Settings::ServerFeatures.new
               rule_definitions = server_features&.protect&.rule_definition_list
-              rule_definitions&.find { |r| r[:name] == Contrast::Agent::Protect::Rule::NoSqli::NAME }&.dig(:patterns)
+              rule_definitions = DEFAULT_RULE_DEFINITIONS if rule_definitions.empty?
+              rule_definitions.find { |r| r[:name] == Contrast::Agent::Protect::Rule::NoSqli::NAME }&.dig(:patterns)
             end
 
             def matches_by_position value, pattern

data/lib/contrast/agent/protect/rule/no_sqli.rb

@@ -3,6 +3,7 @@
 
 require 'contrast/agent/protect/rule/base_service'
 require 'contrast/agent/protect/rule/sql_sample_builder'
+require 'contrast/agent/reporting/input_analysis/input_type'
 
 module Contrast
   module Agent
@@ -15,22 +16,16 @@ module Contrast
           include SqlSampleBuilder::NoSqliSample
           # Defining build_attack_with_match method
           include SqlSampleBuilder::AttackBuilder
+          include Contrast::Agent::Reporting::InputType
 
           NAME = 'nosql-injection'
           BLOCK_MESSAGE = 'NoSQLi rule triggered. Response blocked.'
-          class << self
-            # @param attack_sample [Contrast::Api::Dtm::RaspRuleSample]
-            # @return [Hash] the details for this specific rule
-            def extract_details attack_sample
-              {
-                  start: attack_sample.no_sqli.start_idx,
-                  end: attack_sample.no_sqli.end_idx,
-                  boundaryOverrunIndex: attack_sample.no_sqli.boundary_overrun_idx,
-                  inputBoundaryIndex: attack_sample.no_sqli.input_boundary_idx,
-                  query: attack_sample.no_sqli.query
-              }
-            end
-          end
+          APPLICABLE_USER_INPUTS = [
+            BODY, COOKIE_NAME, COOKIE_VALUE, HEADER,
+            PARAMETER_NAME, PARAMETER_VALUE, JSON_VALUE,
+            MULTIPART_VALUE, MULTIPART_FIELD_NAME,
+            XML_VALUE, DWR_VALUE
+          ].cs__freeze
 
           def rule_name
             NAME
@@ -40,6 +35,10 @@ module Contrast
             BLOCK_MESSAGE
           end
 
+          def applicable_user_inputs
+            APPLICABLE_USER_INPUTS
+          end
+
           # @raise [Contrast::SecurityException] if the attack is blocked
           #   raised with BLOCK_MESSAGE
           def infilter context, database, query_string
@@ -55,11 +54,7 @@ module Contrast
           end
 
           def build_attack_with_match context, input_analysis_result, result, candidate_string, **kwargs
-            if mode == Contrast::Api::Settings::ProtectionRule::Mode::NO_ACTION ||
-                  mode == Contrast::Api::Settings::ProtectionRule::Mode::PERMIT
-
-              return result
-            end
+            return result if mode == :NO_ACTION || mode == :PERMIT
 
             result ||= build_attack_result(context)
             update_successful_attack_response(context, input_analysis_result, result, candidate_string)
@@ -67,6 +62,18 @@ module Contrast
             result
           end
 
+          # @param context [Contrast::Agent::RequestContext]
+          def infilter? context
+            return false unless enabled?
+            return false unless context&.agent_input_analysis&.results&.any? do |result|
+              result.rule_id == rule_name
+            end
+
+            return false if protect_excluded_by_code?
+
+            true
+          end
+
           protected
 
           def find_attacker context, potential_attack_string, **kwargs

data/lib/contrast/agent/protect/rule/path_traversal/path_traversal_input_classification.rb

@@ -0,0 +1,61 @@
+# Copyright (c) 2022 Contrast Security, Inc. See https://www.contrastsecurity.com/enduser-terms-0317a for more details.
+# frozen_string_literal: true
+
+require 'contrast/utils/input_classification_base'
+
+module Contrast
+  module Agent
+    module Protect
+      module Rule
+        # The Ruby implementation of the Protect Path Traversal rule
+        # Input classification
+        module PathTraversalInputClassification
+          PATH_TRAVERSAL_MATCH = 'path-traversal-input-tracing-v1'
+          WORTHWATCHING_MATCH = 'path-traversal-worth-watching-v2'
+
+          THRESHOLD = 90.cs__freeze
+          class << self
+            include InputClassificationBase
+
+            private
+
+            # This methods checks if input is tagged DEFINITEATTACK or IGNORE matches value with it's
+            # key if needed and Creates new isntance of InputAnalysisResult.
+            #
+            # @param request [Contrast::Agent::Request] the current request context.
+            # @param rule_id [String] The name of the Protect Rule.
+            # @param input_type [Contrast::Agent::Reporting::InputType] The type of the user input.
+            # @param value [String, Array<String>] the value of the input.
+            #
+            # @return res [Contrast::Agent::Reporting::InputAnalysisResult]
+            def create_new_input_result request, rule_id, input_type, value
+              return unless Contrast::AGENT_LIB
+
+              input_eval = Contrast::AGENT_LIB.eval_input(value,
+                                                          convert_input_type(input_type),
+                                                          Contrast::AGENT_LIB.rule_set[rule_id],
+                                                          Contrast::AGENT_LIB.eval_option[:WORTHWATCHING])
+
+              ia_result = new_ia_result(rule_id, input_type, request.path, value)
+              score = input_eval&.score || 0
+              if score >= THRESHOLD
+                ia_result.score_level = DEFINITEATTACK
+                ia_result.ids << PATH_TRAVERSAL_MATCH
+              elsif score == 10
+                # There is one pattern to match 10 and thus on its own will be reported as a probe.
+                # This rule can report WORTHWATCHING:
+                # https://protect-spec.prod.dotnet.contsec.com/rules/path-traversal.html#applicable-input-types
+                ia_result.score_level = WORTHWATCHING
+                ia_result.ids << WORTHWATCHING_MATCH
+              else
+                ia_result.score_level = IGNORE
+              end
+              add_needed_key(request, ia_result, input_type, value)
+              ia_result
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/contrast/agent/protect/rule/path_traversal/path_traversal_semantic_security_bypass.rb

@@ -0,0 +1,114 @@
+# Copyright (c) 2022 Contrast Security, Inc. See https://www.contrastsecurity.com/enduser-terms-0317a for more details.
+# frozen_string_literal: true
+
+require 'contrast/agent/protect/rule/base_service'
+require 'contrast/agent/reporting/details/path_traversal_semantic_analysis_details'
+require 'contrast/agent/request_context'
+require 'contrast/utils/string_utils'
+require 'contrast/agent_lib/api/path_semantic_file_security_bypass'
+require 'contrast/agent_lib/interface'
+
+module Contrast
+  module Agent
+    module Protect
+      module Rule
+        # The Ruby implementation of the Protect Path Traversal Semantic
+        # Bypass sub-rule. This rule should report the attack result
+        class PathTraversalSemanticBypass < Contrast::Agent::Protect::Rule::BaseService
+          NAME = 'path-traversal-semantic-file-security-bypass'
+          # There paths here will eventually be moved
+
+          def rule_name
+            NAME
+          end
+
+          def infilter context, method, path
+            return unless rule_violated?(path)
+
+            result = find_vulnerability(context, path)
+
+            return unless result
+
+            append_to_activity(context, result)
+            return unless blocked?
+
+            result_rule_name = Contrast::Utils::StringUtils.transform_string(result.rule_id)
+            cef_logging(result, :successful_attack, value: path)
+            exception_messasge = "#{ result_rule_name } rule triggered. Call to File.#{ method } blocked."
+            raise(Contrast::SecurityException.new(self, exception_messasge))
+          end
+
+          protected
+
+          # Check if semantic file security bypass is detected
+          #
+          # @param file_path [String] command to check.
+          # @param is_custom_code[String] whether the file is being accessed by custom (user) code,
+          #     rather than framework code
+          # @return result[Integer, nil] returns:
+          #     1 => security bypass is detected.
+          #     0 => no security bypass is detected.
+          def file_security_bypassed? file_path, is_custom_code = nil
+            return false unless (agent_lib = Contrast::AGENT_LIB) || file_path
+
+            custom_call = is_custom_code.nil? ? 0 : 1
+
+            agent_lib.check_path_semantic_security_bypass(file_path, custom_call) == 1
+          end
+
+          def rule_violated? path
+            is_custom_code = custom_code_accessing_system_file?(path)
+            is_custom_code || file_security_bypassed?(path, is_custom_code)
+          end
+
+          def find_vulnerability context, path
+            build_attack_with_match(context, nil, nil, path)
+          end
+
+          def build_sample context, _input_analysis_result, path, **_kwargs
+            sample = build_base_sample(context, nil)
+            sample.details = Contrast::Agent::Reporting::Details::PathTraversalSemanticAnalysisDetails.new
+            path = Contrast::Utils::StringUtils.protobuf_safe_string(path)
+            sample.details.path = path
+
+            is_custom_code = custom_code_accessing_system_file?(path)
+            # This should catch all the types of security breaches in that sub-rule scope
+            # but apparently it's not, because some of the system files is being skipped and not detected,
+            # but for our previous logic - it was expected for certain files to be detected and blocked
+            security_bypassed = file_security_bypassed?(path, is_custom_code)
+
+            # if agent lib sub-rule returns true and is custom code -> assign and report
+            if security_bypassed
+              if is_custom_code
+                sample.details.findings << :CUSTOM_CODE_ACCESSING_SYSTEM_FILES
+                sample.details.findings << :COMMON_FILE_EXPLOITS if common_file_exploits_enabled?
+              end
+              return sample
+            end
+
+            if is_custom_code
+              sample.details.findings << :CUSTOM_CODE_ACCESSING_SYSTEM_FILES
+              return sample
+            end
+
+            nil
+          end
+
+          def custom_code_accessing_system_file? input
+            system_file?(input) && Contrast::Utils::StackTraceUtils.custom_code_context?
+          end
+
+          def system_file? path
+            return false unless path
+
+            Contrast::Agent::Protect::Rule::PathTraversal::SYSTEM_PATHS.any? { |sys_path| sys_path.include?(path) }
+          end
+
+          def common_file_exploits_enabled?
+            false
+          end
+        end
+      end
+    end
+  end
+end

data/lib/contrast/agent/protect/rule/path_traversal.rb

@@ -2,7 +2,13 @@
 # frozen_string_literal: true
 
 require 'contrast/agent/protect/rule/base_service'
+require 'contrast/agent/protect/rule/path_traversal/path_traversal_semantic_security_bypass'
+require 'contrast/agent/reporting/input_analysis/input_type'
+require 'contrast/agent/reporting/input_analysis/score_level'
 require 'contrast/utils/stack_trace_utils'
+require 'contrast/agent/reporting/details/path_traversal_details'
+require 'contrast/agent/reporting/details/path_traversal_semantic_analysis_details'
+require 'contrast/utils/string_utils'
 
 module Contrast
   module Agent
@@ -11,7 +17,13 @@ module Contrast
         # This class handles our implementation of the Path Traversal
         # Protect rule.
         class PathTraversal < Contrast::Agent::Protect::Rule::BaseService
+          include Contrast::Agent::Reporting::InputType
+
           NAME = 'path-traversal'
+          APPLICABLE_USER_INPUTS = [
+            BODY, COOKIE_NAME, COOKIE_VALUE, HEADER, PARAMETER_VALUE, PARAMETER_NAME,
+            JSON_VALUE, MULTIPART_VALUE, MULTIPART_FIELD_NAME, XML_VALUE, DWR_VALUE, URI
+          ].cs__freeze
           SYSTEM_PATHS = %w[
             /proc/self
             etc/passwd
@@ -25,20 +37,20 @@ module Contrast
             /windows/repair/
           ].cs__freeze
 
-          class << self
-            # @param attack_sample [Contrast::Api::Dtm::RaspRuleSample]
-            # @return [Hash] the details for this specific rule
-            def extract_details attack_sample
-              {
-                  path: attack_sample.path_traversal.path
-              }
-            end
-          end
+          SUB_RULES = [Contrast::Agent::Protect::Rule::PathTraversalSemanticBypass.new].cs__freeze
 
           def rule_name
             NAME
           end
 
+          def sub_rules
+            SUB_RULES
+          end
+
+          def applicable_user_inputs
+            APPLICABLE_USER_INPUTS
+          end
+
           def infilter context, method, path
             return unless infilter?(context)
 
@@ -48,9 +60,10 @@ module Contrast
             append_to_activity(context, result)
             return unless blocked?
 
-            cef_logging(result, :successful_attack, path)
-            raise(Contrast::SecurityException.new(self,
-                                                  "Path Traversal rule triggered. Call to File.#{ method } blocked."))
+            result_rule_name = Contrast::Utils::StringUtils.transform_string(result.rule_id)
+            cef_logging(result, :successful_attack, value: path)
+            exception_messasge = "#{ result_rule_name } rule triggered. Call to File.#{ method } blocked."
+            raise(Contrast::SecurityException.new(self, exception_messasge))
           end
 
           protected
@@ -65,28 +78,43 @@ module Contrast
           # evaluation
           def build_sample context, input_analysis_result, path, **_kwargs
             sample = build_base_sample(context, input_analysis_result)
-            sample.path_traversal = Contrast::Api::Dtm::PathTraversalDetails.new
+            sample.details = Contrast::Agent::Reporting::Details::PathTraversalDetails.new
             path ||= input_analysis_result.value
-            sample.path_traversal.path = Contrast::Utils::StringUtils.protobuf_safe_string(path)
+            sample.details.path = Contrast::Utils::StringUtils.protobuf_safe_string(path)
             sample
           end
 
+          # @param context [Contrast::Agent::RequestContext]
+          def infilter? context
+            return false unless enabled?
+            return false unless context&.agent_input_analysis&.results&.any? do |result|
+              # When a file is being accessed, the agent should see if any of its worth-watching inputs appear in
+              # the file path. If so, the input is considered a confirmed attack and should be reported or blocked.
+              # If the score level is ignore we don't need to report it.
+              result.rule_id == rule_name && result.score_level != Contrast::Agent::Reporting::ScoreLevel::IGNORE
+            end
+
+            return false if protect_excluded_by_code?
+
+            true
+          end
+
           private
 
           # Build a subclass of the RaspRuleSample if the sample matches
           def build_rep_sample context, path
             sample = build_base_sample(context, nil)
-            sample.path_traversal_semantic = Contrast::Api::Dtm::PathTraversalSemanticAnalysisDetails.new
+            sample.details = Contrast::Agent::Reporting::Details::PathTraversalSemanticAnalysisDetails.new
             path = Contrast::Utils::StringUtils.protobuf_safe_string(path)
-            sample.path_traversal_semantic.path = path
+            sample.details.path = path
 
             if custom_code_access_sysfile_enabled? && custom_code_accessing_system_file?(path)
-              sample.path_traversal_semantic.findings << :CUSTOM_CODE_ACCESSING_SYSTEM_FILES
+              sample.details.findings << :CUSTOM_CODE_ACCESSING_SYSTEM_FILES
               return sample
             end
 
             if common_file_exploits_enabled? && contains_known_attack_signatures?(path)
-              sample.path_traversal_semantic.findings << :COMMON_FILE_EXPLOITS
+              sample.details.findings << :COMMON_FILE_EXPLOITS
               return sample
             end