commontator 2.0.2 → 4.0.0

data/spec/lib/commontator/acts_as_commontable_spec.rb

@@ -1,4 +1,4 @@
-require 'minitest_helper'
+require 'test_helper'
 
 module Commontator
   describe ActsAsCommontable do

data/spec/lib/commontator/acts_as_commontable_spec.rb~

@@ -1,9 +1,9 @@
-require 'test_helper'
+require 'minitest_helper'
 
 module Commontator
   describe ActsAsCommontable do
     it 'must add methods to ActiveRecord and subclasses' do
-      ActiveRecord::Base.must_respond_to :acts_as_common
+      ActiveRecord::Base.must_respond_to :acts_as_commontable
       ActiveRecord::Base.must_respond_to :is_commontable
       ActiveRecord::Base.is_commontable.must_equal false
       DummyModel.must_respond_to :acts_as_commontable

data/spec/lib/commontator/acts_as_commontator_spec.rb

@@ -1,4 +1,4 @@
-require 'minitest_helper'
+require 'test_helper'
 
 module Commontator
   describe ActsAsCommontator do

data/spec/lib/commontator/commontable_config_spec.rb

@@ -1,4 +1,4 @@
-require 'minitest_helper'
+require 'test_helper'
 
 module Commontator
   describe CommontableConfig do

data/spec/lib/commontator/commontator_config_spec.rb

@@ -1,4 +1,4 @@
-require 'minitest_helper'
+require 'test_helper'
 
 module Commontator
   describe CommontatorConfig do

data/spec/lib/commontator/controller_includes_spec.rb

@@ -1,10 +1,10 @@
-require 'minitest_helper'
+require 'test_helper'
 
 module Commontator
   describe ControllerIncludes do
     it 'must add commontator_thread_show to ActionController instances' do
-      ActionController::Base.new.must_respond_to :commontator_thread_show
-      DummyModelsController.new.must_respond_to :commontator_thread_show
+      ActionController::Base.new.respond_to?(:commontator_thread_show, true).must_equal true
+      DummyModelsController.new.respond_to?(:commontator_thread_show, true).must_equal true
     end
     
     it 'must add shared helper to ActionController and subclasses' do

data/spec/lib/commontator/shared_helper_spec.rb

@@ -1,10 +1,14 @@
-require 'minitest_helper'
+require 'test_helper'
 
 module Commontator
   describe SharedHelper do
     it 'must show commontator thread' do
-      view_context = DummyModelsController.new.view_context
-      thread_link = view_context.commontator_thread(DummyModel.create)
+      controller = DummyModelsController.new
+      # Workaround for https://github.com/rails/rails/issues/11662
+      controller.define_singleton_method(:params) do
+        {}
+      end
+      thread_link = controller.view_context.commontator_thread(DummyModel.create)
       thread_link.wont_be_nil
       thread_link.wont_be_empty
     end

data/spec/lib/commontator_spec.rb

@@ -1,4 +1,4 @@
-require 'minitest_helper'
+require 'test_helper'
 
 module Commontator
   describe Commontator do

data/spec/{minitest_helper.rb → test_helper.rb}

@@ -1,10 +1,14 @@
-# Configure Rails Environment
 ENV["RAILS_ENV"] = "test"
+require File.expand_path("../dummy/config/environment", __FILE__)
+require "rails/test_help"
+require "minitest/rails"
 
-require File.expand_path("../dummy/config/environment.rb",  __FILE__)
+# To add Capybara feature tests add `gem "minitest-rails-capybara"`
+# to the test group in the Gemfile and uncomment the following:
+# require "minitest/rails/capybara"
 
-require "minitest/autorun"
-require "minitest/rails"
+# Uncomment for awesome colorful output
+# require "minitest/pride"
 
 Rails.backtrace_cleaner.remove_silencers!
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: commontator
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 4.0.0
 platform: ruby
 authors:
 - Dante Soares
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-04 00:00:00.000000000 Z
+date: 2013-09-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: jquery-rails
   requirement: !ruby/object:Gem::Requirement
@@ -108,7 +108,6 @@ files:
 - app/models/commontator/subscription.rb~
 - app/models/commontator/thread.rb
 - app/models/commontator/comment.rb
-- app/models/commontator/comment_observer.rb
 - app/models/commontator/comment.rb~
 - app/helpers/commontator/threads_helper.rb
 - app/helpers/commontator/application_helper.rb
@@ -144,7 +143,7 @@ files:
 - config/initializers/commontator.rb~
 - config/initializers/commontator.rb
 - config/routes.rb~
-- db/migrate/0_install_commontator.rb
+- db/migrate/0_install.rb
 - db/migrate/0_install.rb~
 - lib/commontator.rb~
 - lib/commontator/version.rb~
@@ -168,7 +167,6 @@ files:
 - MIT-LICENSE
 - Rakefile
 - README.md
-- spec/minitest_helper.rb
 - spec/app/controllers/commontator/comments_controller_spec.rb~
 - spec/app/controllers/commontator/threads_controller_spec.rb~
 - spec/app/controllers/commontator/threads_controller_spec.rb
@@ -176,7 +174,6 @@ files:
 - spec/app/controllers/commontator/comments_controller_spec.rb
 - spec/app/controllers/commontator/subscriptions_controller_spec.rb
 - spec/app/models/commontator/comment_observer_spec.rb~
-- spec/app/models/commontator/comment_observer_spec.rb
 - spec/app/models/commontator/thread_spec.rb~
 - spec/app/models/commontator/comment_spec.rb
 - spec/app/models/commontator/subscription_spec.rb
@@ -189,6 +186,7 @@ files:
 - spec/app/helpers/commontator/application_helper_spec.rb
 - spec/app/mailers/commontator/subscriptions_mailer_spec.rb
 - spec/app/mailers/commontator/subscriptions_mailer_spec.rb~
+- spec/test_helper.rb
 - spec/minitest_helper.rb~
 - spec/dummy/script/rails
 - spec/dummy/Rakefile
@@ -222,6 +220,7 @@ files:
 - spec/dummy/config/initializers/secret_token.rb~
 - spec/dummy/config/initializers/wrap_parameters.rb
 - spec/dummy/config/initializers/secret_token.rb
+- spec/dummy/config/initializers/filter_parameter_logging.rb
 - spec/dummy/config/initializers/mime_types.rb
 - spec/dummy/config/initializers/session_store.rb
 - spec/dummy/config/initializers/commontator.rb
@@ -288,7 +287,6 @@ signing_key:
 specification_version: 4
 summary: Allows users to comment on any model in your application.
 test_files:
-- spec/minitest_helper.rb
 - spec/app/controllers/commontator/comments_controller_spec.rb~
 - spec/app/controllers/commontator/threads_controller_spec.rb~
 - spec/app/controllers/commontator/threads_controller_spec.rb
@@ -296,7 +294,6 @@ test_files:
 - spec/app/controllers/commontator/comments_controller_spec.rb
 - spec/app/controllers/commontator/subscriptions_controller_spec.rb
 - spec/app/models/commontator/comment_observer_spec.rb~
-- spec/app/models/commontator/comment_observer_spec.rb
 - spec/app/models/commontator/thread_spec.rb~
 - spec/app/models/commontator/comment_spec.rb
 - spec/app/models/commontator/subscription_spec.rb
@@ -309,6 +306,7 @@ test_files:
 - spec/app/helpers/commontator/application_helper_spec.rb
 - spec/app/mailers/commontator/subscriptions_mailer_spec.rb
 - spec/app/mailers/commontator/subscriptions_mailer_spec.rb~
+- spec/test_helper.rb
 - spec/minitest_helper.rb~
 - spec/dummy/script/rails
 - spec/dummy/Rakefile
@@ -342,6 +340,7 @@ test_files:
 - spec/dummy/config/initializers/secret_token.rb~
 - spec/dummy/config/initializers/wrap_parameters.rb
 - spec/dummy/config/initializers/secret_token.rb
+- spec/dummy/config/initializers/filter_parameter_logging.rb
 - spec/dummy/config/initializers/mime_types.rb
 - spec/dummy/config/initializers/session_store.rb
 - spec/dummy/config/initializers/commontator.rb

data/app/models/commontator/comment_observer.rb

@@ -1,12 +0,0 @@
-module Commontator
-  class CommentObserver < ActiveRecord::Observer
-    def after_create(comment)
-      thread = comment.thread
-      thread.subscribe(comment.creator) if thread.config.auto_subscribe_on_comment
-      thread.add_unread_except_for(comment.creator)
-      recipients = thread.active_subscribers.reject{|s| s == comment.creator}
-      SubscriptionsMailer.comment_created(comment, recipients).deliver \
-        unless recipients.empty?
-    end
-  end
-end

data/db/migrate/0_install_commontator.rb

@@ -1,50 +0,0 @@
-class InstallCommontator < ActiveRecord::Migration
-  def change
-    create_table "commontator_comments" do |t|
-      t.string   "creator_type"
-      t.integer  "creator_id"
-      t.string   "editor_type"
-      t.integer  "editor_id"
-      t.integer  "thread_id", :null => false
-      t.text     "body", :null => false
-      t.datetime "deleted_at"
-      
-      t.integer  "cached_votes_total", :default => 0
-      t.integer  "cached_votes_up", :default => 0
-      t.integer  "cached_votes_down", :default => 0
-
-      t.timestamps
-    end
-
-    add_index :commontator_comments, [:creator_type, :creator_id, :thread_id], :name => "index_c_c_on_c_type_and_c_id_and_t_id"
-    add_index :commontator_comments, :thread_id
-
-    add_index :commontator_comments, :cached_votes_total
-    add_index :commontator_comments, :cached_votes_up
-    add_index :commontator_comments, :cached_votes_down
-    
-    create_table "commontator_subscriptions" do |t|
-      t.string   "subscriber_type", :null => false
-      t.integer  "subscriber_id", :null => false
-      t.integer  "thread_id", :null => false
-      t.integer  "unread", :null => false, :default => 0
-
-      t.timestamps
-    end
-
-    add_index :commontator_subscriptions, [:subscriber_type, :subscriber_id, :thread_id], :unique => true, :name => "index_c_s_on_s_type_and_s_id_and_t_id"
-    add_index :commontator_subscriptions, :thread_id
-
-    create_table "commontator_threads" do |t|
-      t.string   "commontable_type"
-      t.integer  "commontable_id"
-      t.datetime "closed_at"
-      t.string   "closer_type"
-      t.integer  "closer_id"
-
-      t.timestamps
-    end
-
-    add_index :commontator_threads, [:commontable_type, :commontable_id], :unique => true
-  end
-end

data/spec/app/models/commontator/comment_observer_spec.rb

@@ -1,27 +0,0 @@
-require 'minitest_helper'
-
-module Commontator
-  describe CommentObserver do
-    before do
-      setup_model_spec
-      @comment_observer = CommentObserver.instance
-      @thread.subscribe(@user)
-      @comment = Comment.new
-      @comment.thread = @thread
-      @comment.creator = @user
-      @comment.body = 'Something'
-      @comment.save!
-    end
-    
-    it 'wont send mail unless recipients not empty' do
-      @comment_observer.after_create(@comment).must_be_nil
-    end
-    
-    it 'must send mail if recipients not empty' do
-      @user2 = DummyUser.create
-      @thread.subscribe(@user2)
-      @comment.reload
-      @comment_observer.after_create(@comment).must_be_instance_of Mail::Message
-    end
-  end
-end