commontator 2.0.2 → 4.0.0

data/spec/app/controllers/commontator/threads_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'minitest_helper'
+require 'test_helper'
 
 module Commontator
   describe ThreadsController do
@@ -35,23 +35,23 @@ module Commontator
     end
     
     it 'wont close unless authorized and open' do
-      put :close, :id => @thread.id, :use_route => :commontator
+      patch :close, :id => @thread.id, :use_route => :commontator
       assert_response 403
       assigns(:thread).is_closed?.must_equal false
       
       sign_in @user
-      put :close, :id => @thread.id, :use_route => :commontator
+      patch :close, :id => @thread.id, :use_route => :commontator
       assert_response 403
       assigns(:thread).is_closed?.must_equal false
       
       @user.can_read = true
-      put :close, :id => @thread.id, :use_route => :commontator
+      patch :close, :id => @thread.id, :use_route => :commontator
       assert_response 403
       assigns(:thread).is_closed?.must_equal false
       
       @user.can_edit = true
       @thread.close.must_equal true
-      put :close, :id => @thread.id, :use_route => :commontator
+      patch :close, :id => @thread.id, :use_route => :commontator
       assert_redirected_to @thread
       assigns(:thread).errors.wont_be_empty
     end
@@ -60,7 +60,7 @@ module Commontator
       sign_in @user
       
       @user.can_edit = true
-      put :close, :id => @thread.id, :use_route => :commontator
+      patch :close, :id => @thread.id, :use_route => :commontator
       assert_redirected_to @thread
       assigns(:thread).errors.must_be_empty
       assigns(:thread).is_closed?.must_equal true
@@ -69,7 +69,7 @@ module Commontator
       assigns(:thread).reopen.must_equal true
       @user.can_edit = false
       @user.is_admin = true
-      put :close, :id => @thread.id, :use_route => :commontator
+      patch :close, :id => @thread.id, :use_route => :commontator
       assert_redirected_to @thread
       assigns(:thread).errors.must_be_empty
       assigns(:thread).is_closed?.must_equal true
@@ -78,23 +78,23 @@ module Commontator
     
     it 'wont reopen unless authorized and closed' do
       @thread.close.must_equal true
-      put :reopen, :id => @thread.id, :use_route => :commontator
+      patch :reopen, :id => @thread.id, :use_route => :commontator
       assert_response 403
       assigns(:thread).is_closed?.must_equal true
       
       sign_in @user
-      put :reopen, :id => @thread.id, :use_route => :commontator
+      patch :reopen, :id => @thread.id, :use_route => :commontator
       assert_response 403
       assigns(:thread).is_closed?.must_equal true
       
       @user.can_read = true
-      put :reopen, :id => @thread.id, :use_route => :commontator
+      patch :reopen, :id => @thread.id, :use_route => :commontator
       assert_response 403
       assigns(:thread).is_closed?.must_equal true
       
       @thread.reopen.must_equal true
       @user.can_edit = true
-      put :reopen, :id => @thread.id, :use_route => :commontator
+      patch :reopen, :id => @thread.id, :use_route => :commontator
       assert_redirected_to @thread
       assigns(:thread).errors.wont_be_empty
     end
@@ -104,7 +104,7 @@ module Commontator
       
       @thread.close.must_equal true
       @user.can_edit = true
-      put :reopen, :id => @thread.id, :use_route => :commontator
+      patch :reopen, :id => @thread.id, :use_route => :commontator
       assert_redirected_to @thread
       assigns(:thread).errors.must_be_empty
       assigns(:thread).is_closed?.must_equal false
@@ -112,7 +112,7 @@ module Commontator
       assigns(:thread).close.must_equal true
       @user.can_edit = false
       @user.is_admin = true
-      put :reopen, :id => @thread.id, :use_route => :commontator
+      patch :reopen, :id => @thread.id, :use_route => :commontator
       assert_redirected_to @thread
       assigns(:thread).errors.must_be_empty
       assigns(:thread).is_closed?.must_equal false

data/spec/app/helpers/commontator/application_helper_spec.rb

@@ -1,4 +1,4 @@
-require 'minitest_helper'
+require 'test_helper'
 
 module Commontator
   describe ApplicationHelper do

data/spec/app/helpers/commontator/threads_helper_spec.rb

@@ -1,4 +1,4 @@
-require 'minitest_helper'
+require 'test_helper'
 
 module Commontator
   describe ThreadsHelper do

data/spec/app/mailers/commontator/subscriptions_mailer_spec.rb

@@ -1,4 +1,4 @@
-require 'minitest_helper'
+require 'test_helper'
 
 module Commontator
   describe SubscriptionsMailer do
@@ -18,7 +18,7 @@ module Commontator
     it 'must create deliverable mail' do
       mail = SubscriptionsMailer.comment_created(@comment, @recipients)
       mail.must_be_instance_of Mail::Message
-      mail.to.must_be_nil
+      mail.to.must_equal 'Undisclosed Recipients'
       mail.cc.must_be_nil
       mail.bcc.size.must_equal 1
       mail.bcc.must_include @user2.email

data/spec/app/models/commontator/comment_spec.rb

@@ -1,4 +1,4 @@
-require 'minitest_helper'
+require 'test_helper'
 require 'acts_as_votable'
 
 module Commontator

data/spec/app/models/commontator/subscription_spec.rb

@@ -1,4 +1,4 @@
-require 'minitest_helper'
+require 'test_helper'
 
 module Commontator
   describe Subscription do

data/spec/app/models/commontator/thread_spec.rb

@@ -1,4 +1,4 @@
-require 'minitest_helper'
+require 'test_helper'
 
 module Commontator
   describe Thread do

data/spec/dummy/Rakefile

@@ -1,4 +1,3 @@
-#!/usr/bin/env rake
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 

data/spec/dummy/config.ru

@@ -1,4 +1,4 @@
 # This file is used by Rack-based servers to start the application.
 
 require ::File.expand_path('../config/environment',  __FILE__)
-run Dummy::Application
+run Rails.application

data/spec/dummy/config/application.rb

@@ -2,7 +2,7 @@ require File.expand_path('../boot', __FILE__)
 
 require 'rails/all'
 
-Bundler.require
+Bundler.require(*Rails.groups)
 require "commontator"
 
 module Dummy
@@ -11,16 +11,6 @@ module Dummy
     # Application configuration should go into files in config/initializers
     # -- all .rb files in that directory are automatically loaded.
 
-    # Custom directories with classes and modules you want to be autoloadable.
-    # config.autoload_paths += %W(#{config.root}/extras)
-
-    # Only load the plugins named here, in the order given (default is alphabetical).
-    # :all can be used as a placeholder for all plugins not explicitly named.
-    # config.plugins = [ :exception_notification, :ssl_requirement, :all ]
-
-    # Activate observers that should always be running.
-    # config.active_record.observers = :cacher, :garbage_collector, :forum_observer
-
     # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
     # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
     # config.time_zone = 'Central Time (US & Canada)'
@@ -29,31 +19,9 @@ module Dummy
     # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
     # config.i18n.default_locale = :de
 
-    # Configure the default encoding used in templates for Ruby 1.9.
-    config.encoding = "utf-8"
-
-    # Configure sensitive parameters which will be filtered from the log file.
-    config.filter_parameters += [:password]
-
-    # Enable escaping HTML in JSON.
-    config.active_support.escape_html_entities_in_json = true
-
-    # Use SQL instead of Active Record's schema dumper when creating the database.
-    # This is necessary if your schema can't be completely dumped by the schema dumper,
-    # like if you have constraints or database-specific column types
-    # config.active_record.schema_format = :sql
-
-    # Enforce whitelist mode for mass assignment.
-    # This will create an empty whitelist of attributes available for mass-assignment for all models
-    # in your app. As such, your models will need to explicitly whitelist or blacklist accessible
-    # parameters by using an attr_accessible or attr_protected declaration.
-    config.active_record.whitelist_attributes = true
-
-    # Enable the asset pipeline
-    config.assets.enabled = true
-
-    # Version of your assets, change this if you want to expire all your assets
-    config.assets.version = '1.0'
+    config.generators do |g|
+      g.test_framework :mini_test, :spec => true, :fixture => false
+    end
   end
 end
 

data/spec/dummy/config/boot.rb

@@ -1,10 +1,5 @@
-require 'rubygems'
-gemfile = File.expand_path('../../../../Gemfile', __FILE__)
+# Set up gems listed in the Gemfile.
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../../Gemfile', __FILE__)
 
-if File.exist?(gemfile)
-  ENV['BUNDLE_GEMFILE'] = gemfile
-  require 'bundler'
-  Bundler.setup
-end
-
-$:.unshift File.expand_path('../../../../lib', __FILE__)
+require 'bundler/setup' if File.exists?(ENV['BUNDLE_GEMFILE'])
+$LOAD_PATH.unshift File.expand_path('../../../../lib', __FILE__)

data/spec/dummy/config/environment.rb

@@ -1,5 +1,5 @@
-# Load the rails application
+# Load the Rails application.
 require File.expand_path('../application', __FILE__)
 
-# Initialize the rails application
+# Initialize the Rails application.
 Dummy::Application.initialize!

data/spec/dummy/config/environments/development.rb

@@ -1,37 +1,29 @@
 Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb
+  # Settings specified here will take precedence over those in config/application.rb.
 
   # In the development environment your application's code is reloaded on
   # every request. This slows down response time but is perfect for development
   # since you don't have to restart the web server when you make code changes.
   config.cache_classes = false
 
-  # Log error messages when you accidentally call methods on nil.
-  config.whiny_nils = true
+  # Do not eager load code on boot.
+  config.eager_load = false
 
-  # Show full error reports and disable caching
+  # Show full error reports and disable caching.
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false
 
-  # Don't care if the mailer can't send
+  # Don't care if the mailer can't send.
   config.action_mailer.raise_delivery_errors = false
 
-  # Print deprecation notices to the Rails logger
+  # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log
 
-  # Only use best-standards-support built into browsers
-  config.action_dispatch.best_standards_support = :builtin
+  # Raise an error on page load if there are pending migrations
+  config.active_record.migration_error = :page_load
 
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
-
-  # Log the query plan for queries taking more than this (works
-  # with SQLite, MySQL, and PostgreSQL)
-  config.active_record.auto_explain_threshold_in_seconds = 0.5
-
-  # Do not compress assets
-  config.assets.compress = false
-
-  # Expands the lines which load the assets
+  # Debug mode disables concatenation and preprocessing of assets.
+  # This option may cause significant delays in view rendering with a large
+  # number of complex assets.
   config.assets.debug = true
 end

data/spec/dummy/config/environments/production.rb

@@ -1,67 +1,80 @@
 Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb
+  # Settings specified here will take precedence over those in config/application.rb.
 
-  # Code is not reloaded between requests
+  # Code is not reloaded between requests.
   config.cache_classes = true
 
-  # Full error reports are disabled and caching is turned on
+  # Eager load code on boot. This eager loads most of Rails and
+  # your application in memory, allowing both thread web servers
+  # and those relying on copy on write to perform better.
+  # Rake tasks automatically ignore this option for performance.
+  config.eager_load = true
+
+  # Full error reports are disabled and caching is turned on.
   config.consider_all_requests_local       = false
   config.action_controller.perform_caching = true
 
-  # Disable Rails's static asset server (Apache or nginx will already do this)
+  # Enable Rack::Cache to put a simple HTTP cache in front of your application
+  # Add `rack-cache` to your Gemfile before enabling this.
+  # For large-scale production use, consider using a caching reverse proxy like nginx, varnish or squid.
+  # config.action_dispatch.rack_cache = true
+
+  # Disable Rails's static asset server (Apache or nginx will already do this).
   config.serve_static_assets = false
 
-  # Compress JavaScripts and CSS
-  config.assets.compress = true
+  # Compress JavaScripts and CSS.
+  config.assets.js_compressor = :uglifier
+  # config.assets.css_compressor = :sass
 
-  # Don't fallback to assets pipeline if a precompiled asset is missed
+  # Do not fallback to assets pipeline if a precompiled asset is missed.
   config.assets.compile = false
 
-  # Generate digests for assets URLs
+  # Generate digests for assets URLs.
   config.assets.digest = true
 
-  # Defaults to nil and saved in location specified by config.assets.prefix
-  # config.assets.manifest = YOUR_PATH
+  # Version of your assets, change this if you want to expire all your assets.
+  config.assets.version = '1.0'
 
-  # Specifies the header that your server uses for sending files
+  # Specifies the header that your server uses for sending files.
   # config.action_dispatch.x_sendfile_header = "X-Sendfile" # for apache
   # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for nginx
 
   # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
   # config.force_ssl = true
 
-  # See everything in the log (default is :info)
-  # config.log_level = :debug
+  # Set to :debug to see everything in the log.
+  config.log_level = :info
 
-  # Prepend all log lines with the following tags
+  # Prepend all log lines with the following tags.
   # config.log_tags = [ :subdomain, :uuid ]
 
-  # Use a different logger for distributed setups
+  # Use a different logger for distributed setups.
   # config.logger = ActiveSupport::TaggedLogging.new(SyslogLogger.new)
 
-  # Use a different cache store in production
+  # Use a different cache store in production.
   # config.cache_store = :mem_cache_store
 
-  # Enable serving of images, stylesheets, and JavaScripts from an asset server
+  # Enable serving of images, stylesheets, and JavaScripts from an asset server.
   # config.action_controller.asset_host = "http://assets.example.com"
 
-  # Precompile additional assets (application.js, application.css, and all non-JS/CSS are already added)
+  # Precompile additional assets.
+  # application.js, application.css, and all non-JS/CSS in app/assets folder are already added.
   # config.assets.precompile += %w( search.js )
 
-  # Disable delivery errors, bad email addresses will be ignored
+  # Ignore bad email addresses and do not raise email delivery errors.
+  # Set this to true and configure the email server for immediate delivery to raise delivery errors.
   # config.action_mailer.raise_delivery_errors = false
 
-  # Enable threaded mode
-  # config.threadsafe!
-
   # Enable locale fallbacks for I18n (makes lookups for any locale fall back to
-  # the I18n.default_locale when a translation can not be found)
+  # the I18n.default_locale when a translation can not be found).
   config.i18n.fallbacks = true
 
-  # Send deprecation notices to registered listeners
+  # Send deprecation notices to registered listeners.
   config.active_support.deprecation = :notify
 
-  # Log the query plan for queries taking more than this (works
-  # with SQLite, MySQL, and PostgreSQL)
-  # config.active_record.auto_explain_threshold_in_seconds = 0.5
+  # Disable automatic flushing of the log to improve performance.
+  # config.autoflush_log = false
+
+  # Use default logging formatter so that PID and timestamp are not suppressed.
+  config.log_formatter = ::Logger::Formatter.new
 end

data/spec/dummy/config/environments/test.rb

@@ -1,5 +1,5 @@
 Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb
+  # Settings specified here will take precedence over those in config/application.rb.
 
   # The test environment is used exclusively to run your application's
   # test suite. You never need to work with it otherwise. Remember that
@@ -7,31 +7,30 @@ Dummy::Application.configure do
   # and recreated between test runs. Don't rely on the data there!
   config.cache_classes = true
 
-  # Configure static asset server for tests with Cache-Control for performance
-  config.serve_static_assets = true
-  config.static_cache_control = "public, max-age=3600"
+  # Do not eager load code on boot. This avoids loading your whole application
+  # just for the purpose of running a single test. If you are using a tool that
+  # preloads Rails for running tests, you may have to set it to true.
+  config.eager_load = false
 
-  # Log error messages when you accidentally call methods on nil
-  config.whiny_nils = true
+  # Configure static asset server for tests with Cache-Control for performance.
+  config.serve_static_assets  = true
+  config.static_cache_control = "public, max-age=3600"
 
-  # Show full error reports and disable caching
+  # Show full error reports and disable caching.
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false
 
-  # Raise exceptions instead of rendering exception templates
+  # Raise exceptions instead of rendering exception templates.
   config.action_dispatch.show_exceptions = false
 
-  # Disable request forgery protection in test environment
-  config.action_controller.allow_forgery_protection    = false
+  # Disable request forgery protection in test environment.
+  config.action_controller.allow_forgery_protection = false
 
   # Tell Action Mailer not to deliver emails to the real world.
   # The :test delivery method accumulates sent emails in the
   # ActionMailer::Base.deliveries array.
   config.action_mailer.delivery_method = :test
 
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
-
-  # Print deprecation notices to the stderr
+  # Print deprecation notices to the stderr.
   config.active_support.deprecation = :stderr
 end