commonmeta-ruby 3.3.7 → 3.3.9

data/spec/readers/json_feed_reader_spec.rb

@@ -174,6 +174,54 @@ describe Commonmeta::Metadata, vcr: true do
       expect(subject.references.length).to eq(3)
       expect(subject.references.first).to eq("key" => "ref1", "url" => "https://sauroposeidon.files.wordpress.com/2010/04/foster-and-wedel-2014-haplocanthosaurus-from-snowmass-colorado.pdf")
     end
+    
+    it "wordpress post with tracking code on url" do
+      input = "https://rogue-scholar.org/api/posts/5d95d90d-ff59-4c8b-b7f8-44e6b45fd593"
+      subject = described_class.new(input: input)
+      puts subject.errors
+      # expect(subject.valid?).to be true
+      expect(subject.id).to eq("https://doi.org/10.59350/tpa8t-j6292")
+      expect(subject.url).to eq("https://www.samuelmoore.org/2023/04/20/how-to-cultivate-good-closures-scaling-small-and-the-limits-of-openness")
+      expect(subject.type).to eq("Article")
+      expect(subject.creators.length).to eq(1)
+      expect(subject.creators.first).to eq("familyName"=>"Moore", "givenName"=>"Samuel", "id"=>"https://orcid.org/0000-0002-0504-2897", "type"=>"Person")
+      expect(subject.titles).to eq([{ "title" => "How to cultivate good closures: ‘scaling small’ and the limits of openness" }])
+      expect(subject.license).to eq("id" => "CC-BY-4.0",
+                                    "url" => "https://creativecommons.org/licenses/by/4.0/legalcode")
+      expect(subject.date).to eq("published"=>"2023-04-20", "updated"=>"2023-06-19")
+      expect(subject.descriptions.first["description"]).to start_with("Text of a talk given to the COPIM end-of-project conference")
+      expect(subject.publisher).to eq("name" => "Samuel Moore")
+      expect(subject.subjects).to eq([{ "subject" => "Social sciences" },
+                                      { "schemeUri" => "http://www.oecd.org/science/inno/38235147.pdf",
+                                        "subject" => "FOS: Social sciences",
+                                        "subjectScheme" => "Fields of Science and Technology (FOS)" }])
+      expect(subject.language).to eq("en")
+      expect(subject.container).to eq("identifier" => "https://www.samuelmoore.org/", "identifierType" => "URL", "title" => "Samuel Moore", "type" => "Periodical")
+      expect(subject.references).to be_nil
+    end
+
+    it "ghost post with institutional author" do
+      input = "https://rogue-scholar.org/api/posts/2b3cdd27-5123-4167-9482-3c074392e2d2"
+      subject = described_class.new(input: input)
+      expect(subject.valid?).to be true
+      expect(subject.id).to eq("https://blog.oa.works/nature-features-oa-reports-work-putting-oa-policy-into-practice")
+      expect(subject.url).to eq("https://blog.oa.works/nature-features-oa-reports-work-putting-oa-policy-into-practice")
+      expect(subject.type).to eq("Article")
+      expect(subject.creators.length).to eq(1)
+      expect(subject.creators.first).to eq("name"=>"OA.Works", "type"=>"Organization")
+      expect(subject.titles).to eq([{ "title" => "Nature features OA.Report's work putting OA policy into practice!" }])
+      expect(subject.license).to eq("id" => "CC-BY-4.0",
+                                    "url" => "https://creativecommons.org/licenses/by/4.0/legalcode")
+      expect(subject.date).to eq("published" => "2023-01-24")
+      expect(subject.descriptions.first["description"]).to start_with("After a couple of years of working to support institutions implementing their OA policies")
+      expect(subject.publisher).to eq("name" => "OA.Works Blog")
+      expect(subject.subjects).to eq([{ "subject" => "Engineering and technology" },
+                                      { "schemeUri" => "http://www.oecd.org/science/inno/38235147.pdf",
+                                        "subject" => "FOS: Engineering and technology",
+                                        "subjectScheme" => "Fields of Science and Technology (FOS)" }])
+      expect(subject.language).to eq("en")
+      expect(subject.container).to eq("identifier" => "https://blog.oa.works/", "identifierType" => "URL", "title" => "OA.Works Blog", "type" => "Periodical")
+    end
 
     it "upstream post with references" do
       input = "https://rogue-scholar.org/api/posts/954f8138-0ecd-4090-87c5-cef1297f1470"
@@ -228,8 +276,7 @@ describe Commonmeta::Metadata, vcr: true do
     it "ghost post with organizational author" do
       input = "https://rogue-scholar.org/api/posts/5561f8e4-2ff1-4186-a8d5-8dacb3afe414"
       subject = described_class.new(input: input)
-      puts subject.errors
-      # expect(subject.valid?).to be true
+      expect(subject.valid?).to be true
       expect(subject.id).to eq("https://libscie.org/ku-leuven-supports-researchequals")
       expect(subject.url).to eq("https://libscie.org/ku-leuven-supports-researchequals")
       expect(subject.alternate_identifiers).to eq([{ "alternateIdentifier" => "5561f8e4-2ff1-4186-a8d5-8dacb3afe414", "alternateIdentifierType" => "UUID" }])
@@ -251,6 +298,31 @@ describe Commonmeta::Metadata, vcr: true do
       expect(subject.references).to be_nil
     end
 
+    it "jekyll post with anonymous author" do
+      input = "https://rogue-scholar.org/api/posts/a163e340-5b3c-4736-9ab0-8c54fdff6a3c"
+      subject = described_class.new(input: input)
+      expect(subject.valid?).to be true
+      expect(subject.id).to eq("https://doi.org/10.59350/g6bth-b6f85")
+      expect(subject.url).to eq("https://lab.sub.uni-goettingen.de/welcome.html")
+      expect(subject.alternate_identifiers).to eq([{ "alternateIdentifier" => "a163e340-5b3c-4736-9ab0-8c54fdff6a3c", "alternateIdentifierType" => "UUID" }])
+      expect(subject.type).to eq("Article")
+      expect(subject.creators.length).to eq(1)
+      expect(subject.creators.first).to eq("affiliation"=>[{"id"=>"https://ror.org/05745n787"}], "type"=>"Person")
+      expect(subject.titles).to eq([{ "title" => "Welcome to the Lab" }])
+      expect(subject.license).to eq("id" => "CC-BY-4.0",
+                                    "url" => "https://creativecommons.org/licenses/by/4.0/legalcode")
+      expect(subject.date).to eq("published"=>"2017-01-01", "updated"=>"2017-01-01")
+      expect(subject.descriptions.first["description"]).to start_with("Welcome everyone!")
+      expect(subject.publisher).to eq("name" => "lab.sub - Articles")
+      expect(subject.subjects).to eq([{ "subject" => "Engineering and technology" },
+                                      { "schemeUri" => "http://www.oecd.org/science/inno/38235147.pdf",
+                                        "subject" => "FOS: Engineering and technology",
+                                        "subjectScheme" => "Fields of Science and Technology (FOS)" }])
+      expect(subject.language).to eq("en")
+      expect(subject.container).to eq("identifier" => "https://lab.sub.uni-goettingen.de/", "identifierType" => "URL", "title" => "lab.sub - Articles", "type" => "Periodical")
+      expect(subject.references).to be_nil
+    end
+
     it "blog post with non-url id" do
       input = "https://rogue-scholar.org/api/posts/1898d2d7-4d87-4487-96c4-3073cf99e9a5"
       subject = described_class.new(input: input)

data/spec/readers/ris_reader_spec.rb

@@ -50,7 +50,7 @@ describe Commonmeta::Metadata, vcr: true do
       expect(subject.state).to eq('not_found')
       expect(subject.id).to eq('https://doi.org/10.7554/elife.01567')
       expect(subject.type).to eq('Dissertation')
-      expect(subject.creators).to eq([{ 'name' => 'Toparlar,Y.' }])
+      expect(subject.creators).to eq([{"familyName"=>"Toparlar", "givenName"=>"Y.", "type"=>"Person"}])
       expect(subject.titles).to eq([{ 'title' => 'A multiscale analysis of the urban heat island effect' }])
       expect(subject.descriptions.first['description']).to start_with('Designing the climates of cities')
       expect(subject.date).to eq('created' => '2018-04-25', 'published' => '2018-04-25')

data/spec/readers/schema_org_reader_spec.rb

@@ -153,9 +153,7 @@ describe Commonmeta::Metadata, vcr: true do
       expect(subject.titles).to eq([{ 'title' => 'Summary data ankylosing spondylitis GWAS' }])
       expect(subject.container).to eq('identifier' => 'https://dataverse.harvard.edu',
                                       'identifierType' => 'URL', 'title' => 'Harvard Dataverse', 'type' => 'DataRepository')
-      expect(subject.creators).to eq([{
-                                       'name' => 'International Genetics of Ankylosing Spondylitis Consortium (IGAS)'
-                                     }])
+      expect(subject.creators).to eq([{"name"=>"International Genetics of Ankylosing Spondylitis Consortium (IGAS)", "type"=>"Organization"}])
       expect(subject.subjects).to eq([{ 'subject' => 'Medicine, health and life sciences' },
                                       { 'subject' => 'genome-wide association studies' },
                                       { 'subject' => 'Ankylosing spondylitis' }])

data/spec/writers/crossref_xml_writer_spec.rb

@@ -279,11 +279,44 @@ describe Commonmeta::Metadata, vcr: true do
       crossref_xml = Hash.from_xml(subject.crossref_xml).dig("doi_batch", "body", "posted_content")
       expect(Array.wrap(crossref_xml.dig("contributors", "organization")).length).to eq(1)
       expect(Array.wrap(crossref_xml.dig("contributors",
-                                         "organization")).first).to eq("contributor_role"=>"author", "name"=>"Liberate Science", "sequence"=>"first")
+                                         "organization")).first).to eq("__content__"=>"Liberate Science", "contributor_role"=>"author", "sequence"=>"first")
       expect(crossref_xml.dig("titles",
                               "title")).to eq("KU Leuven supports ResearchEquals")
       expect(crossref_xml.dig('item_number')).to eq("__content__"=>"5561f8e42ff14186a8d58dacb3afe414", "item_number_type"=>"uuid")
       expect(crossref_xml.dig('group_title')).to eq('Social sciences')
     end
+
+    it "json_feed_item from rogue scholar with anonymous author" do
+      input = "https://rogue-scholar.org/api/posts/a163e340-5b3c-4736-9ab0-8c54fdff6a3c"
+      subject = described_class.new(input: input, doi: "10.59350/9ry27-7cz42")
+
+      expect(subject.id).to eq("https://doi.org/10.59350/9ry27-7cz42")
+      expect(subject.url).to eq("https://lab.sub.uni-goettingen.de/welcome.html")
+      expect(subject.alternate_identifiers).to eq([{ "alternateIdentifier" => "a163e340-5b3c-4736-9ab0-8c54fdff6a3c", "alternateIdentifierType" => "UUID" }])
+      expect(subject.type).to eq("Article")
+      expect(subject.creators.length).to eq(1)
+      expect(subject.creators.first).to eq("affiliation"=>[{"id"=>"https://ror.org/05745n787"}], "type"=>"Person")
+      expect(subject.titles).to eq([{ "title" => "Welcome to the Lab" }])
+      expect(subject.license).to eq("id" => "CC-BY-4.0",
+                                    "url" => "https://creativecommons.org/licenses/by/4.0/legalcode")
+      expect(subject.date).to eq("published"=>"2017-01-01", "updated"=>"2017-01-01")
+      expect(subject.descriptions.first["description"]).to start_with("Welcome everyone!")
+      expect(subject.publisher).to eq("name" => "lab.sub - Articles")
+      expect(subject.subjects).to eq([{ "subject" => "Engineering and technology" },
+                                      { "schemeUri" => "http://www.oecd.org/science/inno/38235147.pdf",
+                                        "subject" => "FOS: Engineering and technology",
+                                        "subjectScheme" => "Fields of Science and Technology (FOS)" }])
+      expect(subject.language).to eq("en")
+      expect(subject.container).to eq("identifier" => "https://lab.sub.uni-goettingen.de/", "identifierType" => "URL", "title" => "lab.sub - Articles", "type" => "Periodical")
+      expect(subject.references).to be_nil
+      crossref_xml = Hash.from_xml(subject.crossref_xml).dig("doi_batch", "body", "posted_content")
+      expect(Array.wrap(crossref_xml.dig("contributors", "anonymous")).length).to eq(1)
+      expect(Array.wrap(crossref_xml.dig("contributors",
+                                         "anonymous")).first).to eq("affiliations"=>{"institution"=>{"institution_id"=>{"__content__"=>"https://ror.org/05745n787", "type"=>"ror"}}}, "contributor_role"=>"author", "sequence"=>"first")
+      expect(crossref_xml.dig("titles",
+                              "title")).to eq("Welcome to the Lab")
+      expect(crossref_xml.dig('item_number')).to eq("__content__"=>"a163e3405b3c47369ab08c54fdff6a3c", "item_number_type"=>"uuid")
+      expect(crossref_xml.dig('group_title')).to eq('Engineering and technology')
+    end
   end
 end

data/spec/writers/schema_org_writer_spec.rb

@@ -177,7 +177,7 @@ describe Commonmeta::Metadata, vcr: true do
       expect(json['@id']).to eq('https://doi.org/10.23725/8na3-9s47')
       expect(json['@type']).to eq('Dataset')
       expect(json['name']).to eq('NWD165827.recab.cram')
-      expect(json['author']).to eq('name' => 'TOPMed')
+      expect(json['author']).to eq("@type"=>"Organization", "name"=>"TOPMed")
       expect(json['includedInDataCatalog']).to be_empty
       expect(json['identifier']).to eq(
         [{ '@type' => 'PropertyValue',

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: commonmeta-ruby
 version: !ruby/object:Gem::Version
-  version: 3.3.7
+  version: 3.3.9
 platform: ruby
 authors:
 - Martin Fenner
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-18 00:00:00.000000000 Z
+date: 2023-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -655,7 +655,7 @@ files:
 - lib/commonmeta/xml_converter.rb
 - resources/2008/09/xsd.xsl
 - resources/cff.json
-- resources/commonmeta_v0.9.1.json
+- resources/commonmeta_v0.9.2.json
 - resources/crossref/AccessIndicators.xsd
 - resources/crossref/JATS-journalpublishing1-3d2-mathml3-elements.xsd
 - resources/crossref/JATS-journalpublishing1-3d2-mathml3.xsd
@@ -870,14 +870,18 @@ files:
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_json_feed_item_metadata/blogger_post.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_json_feed_item_metadata/ghost_post_with_author_name_suffix.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_json_feed_item_metadata/ghost_post_with_doi.yml
+- spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_json_feed_item_metadata/ghost_post_with_institutional_author.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_json_feed_item_metadata/ghost_post_with_organizational_author.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_json_feed_item_metadata/ghost_post_without_doi.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_json_feed_item_metadata/jekyll_post.yml
+- spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_json_feed_item_metadata/jekyll_post_with_anonymous_author.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_json_feed_item_metadata/substack_post_with_broken_reference.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_json_feed_item_metadata/syldavia_gazette_post_with_references.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_json_feed_item_metadata/upstream_post_with_references.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_json_feed_item_metadata/wordpress_post.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_json_feed_item_metadata/wordpress_post_with_references.yml
+- spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_json_feed_item_metadata/wordpress_post_with_tracking_code_on_url.yml
+- spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_one_author/affiliation_is_space.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_one_author/has_familyName.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_one_author/has_name_in_display-order_with_ORCID.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/get_one_author/name_with_affiliation_crossref.yml
@@ -917,6 +921,7 @@ files:
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/write_metadata_as_crossref/another_schema_org_from_front-matter.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/write_metadata_as_crossref/journal_article.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/write_metadata_as_crossref/journal_article_from_datacite.yml
+- spec/fixtures/vcr_cassettes/Commonmeta_Metadata/write_metadata_as_crossref/json_feed_item_from_rogue_scholar_with_anonymous_author.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/write_metadata_as_crossref/json_feed_item_from_rogue_scholar_with_doi.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/write_metadata_as_crossref/json_feed_item_from_rogue_scholar_with_organizational_author.yml
 - spec/fixtures/vcr_cassettes/Commonmeta_Metadata/write_metadata_as_crossref/json_feed_item_from_upstream_blog.yml