commonmeta-ruby 3.3.7 → 3.3.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a142d529ddbead4512d9a66531983b5dc8849631ccb28a0cc12b9801af7c7e6e
-  data.tar.gz: 77b47a7afa4e7aa2b0cb82d6dad99da9b01cfaedb0ee6aba90d03187aa8691f5
+  metadata.gz: 39731365147aea3875a44db36625a0cd825826f7f0f94755601634b2716fcef9
+  data.tar.gz: 7591e80c87796e20933352f49079437a9faac148e47889009a5ee3298471ee4c
 SHA512:
-  metadata.gz: 0a672da90701e5d53ba7a91ac095e8577dac584150aa4ca58c095e757d47a9fd473638a662a5402c334e1399574d9596a7dc0d2bb2354f08f4c25cd73992c7d2
-  data.tar.gz: 69c7a71c0dd770cd0685e792e639cc4d78f02196ce0dbad596107257557b1d4ff5e18e8caefc956d72fabbb45071432004c0653550eb94df6769ef2b8e21e5b6
+  metadata.gz: c9c3593d73cadfd1697163801d0505a74c536a93e2a40c2bcaac5e12e7c6e703970a4a207f9282331fe065257ec26856db4e214342926019334e64229b920059
+  data.tar.gz: 69a053002420f6aa808b15c6a77344fa02e7a7c26e208a00b7be68d489540356beb47481e8f7565e102905233b51830a1dbd591a4a6435d5bc4c646a3f632d01

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    commonmeta-ruby (3.3.7)
+    commonmeta-ruby (3.3.9)
       activesupport (>= 4.2.5, < 8.0)
       addressable (~> 2.8.1, < 2.8.2)
       base32-url (>= 0.7.0, < 1)
@@ -27,7 +27,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.5)
+    activesupport (7.0.5.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -113,6 +113,7 @@ GEM
       oj (~> 3)
       optimist (~> 3)
     jwt (2.7.1)
+    language_server-protocol (3.17.0.3)
     latex-decode (0.4.0)
     link_header (0.0.8)
     llhttp-ffi (0.4.0)
@@ -186,12 +187,13 @@ GEM
     rspec-mocks (3.12.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
-    rspec-support (3.12.0)
+    rspec-support (3.12.1)
     rspec-xsd (0.1.0)
       nokogiri (~> 1.6)
       rspec (~> 3)
-    rubocop (1.52.1)
+    rubocop (1.53.1)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.2.2.3)
       rainbow (>= 2.2.2, < 4.0)
@@ -245,7 +247,7 @@ GEM
     unicode-display_width (2.4.2)
     unicode-types (1.8.0)
     uuidtools (2.2.0)
-    vcr (6.1.0)
+    vcr (6.2.0)
     webmock (3.18.1)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)

data/lib/commonmeta/author_utils.rb

@@ -49,7 +49,11 @@ module Commonmeta
       # DataCite metadata
       type = type[0..-3] if type.is_a?(String) && type.end_with?('al')
 
-      if type.blank? && id.is_a?(String) && URI.parse(id).host == 'ror.org'
+      if type.blank? && name.blank? && id.is_a?(String) && URI.parse(id).host == 'ror.org'
+        type = 'Person'
+        author['affiliation'] = { 'affiliationIdentifier' => id }
+        id = nil
+      elsif type.blank? && id.is_a?(String) && URI.parse(id).host == 'ror.org'
         type = 'Organization'
       elsif type.blank? && author['type'] == 'Organization'
         type = 'Organization'
@@ -59,13 +63,15 @@ module Commonmeta
         type = 'Person'
       elsif type.blank? && is_personal_name?(name: name) && name.to_s.exclude?(';')
         type = 'Person'
+      elsif type.blank? && name.present? && !is_personal_name?(name: name)
+        type = 'Organization'
       end
 
       # parse author contributor role
       contributor_type = parse_attributes(author.fetch('contributorType', nil))
 
       # split name for type Person into given/family name if not already provided
-      if type == 'Person' && given_name.blank? && family_name.blank?
+      if type == 'Person' && name.present? && given_name.blank? && family_name.blank?
         Namae.options[:include_particle_in_family] = true
         names = Namae.parse(name)
         parsed_name = names.first
@@ -123,8 +129,8 @@ module Commonmeta
     def is_personal_name?(name: nil)
       return true if name_exists?(name.to_s.split.first) || name_exists?(name.to_s.split(', ').last)
 
-      # check if a name has only one word, e.g. "FamousOrganization"
-      return false if name.to_s.split(' ').size == 1
+      # check if a name has only one word, e.g. "FamousOrganization", not including commas
+      return false if name.to_s.split(' ').size == 1 && name.to_s.exclude?(',')
 
       # check for suffixes, e.g. "John Smith, MD"
       return true if %w[MD PhD].include? name.split(', ').last
@@ -181,9 +187,7 @@ module Commonmeta
           name = (a['name'] || a['__content__']).to_s.squish.presence
         end
 
-        next unless name.present?
-
-        { 'id' => affiliation_identifier, 'name' => name }.compact
+        { 'id' => affiliation_identifier, 'name' => name }.compact.presence
       end.compact.presence
     end
 

data/lib/commonmeta/crossref_utils.rb

@@ -95,21 +95,22 @@ module Commonmeta
     def insert_crossref_creators(xml)
       xml.contributors do
         Array.wrap(creators).each_with_index do |creator, index|
-          if creator["type"] == "Organization"
-            xml.organization("contributor_role" => "author",
-                             "sequence" => index.zero? ? "first" : "additional") do
-              insert_crossref_organization(xml, creator)
-            end
+          if creator["type"] == "Organization" && creator["name"].present?
+            xml.organization(creator["name"], "contributor_role" => "author",
+                             "sequence" => index.zero? ? "first" : "additional")
           elsif creator["givenName"].present? || creator["familyName"].present?
             xml.person_name("contributor_role" => "author",
                             "sequence" => index.zero? ? "first" : "additional") do
               insert_crossref_person(xml, creator)
             end
-          else
-            xml.unknown("contributor_role" => "author",
-                        "sequence" => index.zero? ? "first" : "additional") do
+          elsif creator["affiliation"].present?
+            xml.anonymous("contributor_role" => "author",
+                          "sequence" => index.zero? ? "first" : "additional") do
               insert_crossref_anonymous(xml, creator)
             end
+          else
+            xml.anonymous("contributor_role" => "author",
+                          "sequence" => index.zero? ? "first" : "additional")
           end
         end
       end
@@ -125,36 +126,18 @@ module Commonmeta
         xml.affiliations do
           xml.institution do
             xml.institution_name(creator.dig("affiliation", 0, "name")) if creator.dig("affiliation", 0, "name").present?
-            xml.institution_id(creator.dig("affiliation", 0, "affiliationIdentifier"), "type" => creator.dig("affiliation", 0, "affiliationIdentifierScheme")) if creator.dig("affiliation", 0, "affiliationIdentifier").present?
-          end
-        end
-      end
-    end
-
-    def insert_crossref_organization(xml, creator)
-      xml.name(creator["name"]) if creator["name"].present?
-      if creator["affiliation"].present?
-        xml.affiliations do
-          xml.institution do
-            xml.institution_name(creator.dig("affiliation", 0, "name")) if creator.dig("affiliation", 0, "name").present?
-            xml.institution_id(creator.dig("affiliation", 0, "affiliationIdentifier"), "type" => creator.dig("affiliation", 0, "affiliationIdentifierScheme")) if creator.dig("affiliation", 0, "affiliationIdentifier").present?
+            xml.institution_id(creator.dig("affiliation", 0, "id"), 'type' => "ror") if creator.dig("affiliation", 0, "id").present?
           end
         end
       end
     end
 
     def insert_crossref_anonymous(xml, creator)
-      if person["affiliation"].present?
-        xml.anonymous do
-          xml.affiliations do
-            xml.institution do
-              xml.institution_name(creator.dig("affiliation", 0, "name")) if creator.dig("affiliation", 0, "name").present?
-              xml.institution_id(creator.dig("affiliation", 0, "affiliationIdentifier"), "type" => creator.dig("affiliation", 0, "affiliationIdentifierScheme")) if creator.dig("affiliation", 0, "affiliationIdentifier").present?
-            end
-          end
+      xml.affiliations do
+        xml.institution do
+          xml.institution_name(creator.dig("affiliation", 0, "name")) if creator.dig("affiliation", 0, "name").present?
+          xml.institution_id(creator.dig("affiliation", 0, "id"), 'type' => "ror") if creator.dig("affiliation", 0, "id").present?
         end
-      else
-        xml.anonymous
       end
     end
 

data/lib/commonmeta/schema_utils.rb

@@ -5,7 +5,7 @@ require "pathname"
 
 module Commonmeta
   module SchemaUtils
-    COMMONMETA = File.read(File.expand_path("../../resources/commonmeta_v0.9.1.json",
+    COMMONMETA = File.read(File.expand_path("../../resources/commonmeta_v0.9.2.json",
                                             __dir__))
 
     def json_schema_errors

data/lib/commonmeta/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Commonmeta
-  VERSION = '3.3.7'
+  VERSION = '3.3.9'
 end

data/resources/{commonmeta_v0.9.1.json → commonmeta_v0.9.2.json}

@@ -1,7 +1,7 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
-  "$id": "https://commonmeta.org/commonmeta_v0.9.1.json",
-  "title": "Commonmeta v0.9.1",
+  "$id": "https://commonmeta.org/commonmeta_v0.9.2.json",
+  "title": "Commonmeta v0.9.2",
   "description": "JSON representation of the Commonmeta schema.",
   "additionalProperties": false,
   "definitions": {
@@ -13,7 +13,14 @@
           "id": { "type": "string", "format": "uri" },
           "name": { "type": "string" }
         },
-        "required": ["name"]
+        "anyOf": [
+          {
+            "required": ["id"]
+          },
+          {
+            "required": ["name"]
+          }
+        ]
       },
       "uniqueItems": true
     },
@@ -78,7 +85,7 @@
       "description": "The additional type of the resource.",
       "type": "string"
     },
-     
+
     "url": {
       "description": "The URL of the resource.",
       "type": "string",
@@ -168,7 +175,14 @@
         "type": {
           "description": "The type of the container.",
           "type": "string",
-          "enum": ["Book", "BookSeries", "Journal", "Periodical", "ProceedingsSeries", "Series"]
+          "enum": [
+            "Book",
+            "BookSeries",
+            "Journal",
+            "Periodical",
+            "ProceedingsSeries",
+            "Series"
+          ]
         },
         "title": {
           "description": "The title of the container.",

data/spec/author_utils_spec.rb

@@ -1,181 +1,222 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Commonmeta::Metadata, vcr: true do
   let(:subject) do
     described_class.new
   end
 
-  context 'is_personal_name?' do
-    it 'has id' do
-      author = { 'id' => 'http://orcid.org/0000-0003-1419-2405', 'givenName' => 'Martin', 'familyName' => 'Fenner', 'name' => 'Martin Fenner' }
-      expect(subject.is_personal_name?(name: author['name'])).to be true
+  context "is_personal_name?" do
+    it "has id" do
+      author = { "id" => "http://orcid.org/0000-0003-1419-2405", "givenName" => "Martin", "familyName" => "Fenner", "name" => "Martin Fenner" }
+      expect(subject.is_personal_name?(name: author["name"])).to be true
     end
 
-    it 'has orcid id' do
-      author = { 'creatorName' => 'Fenner, Martin', 'givenName' => 'Martin', 'familyName' => 'Fenner',
-                 'nameIdentifier' => { 'schemeURI' => 'http://orcid.org/', 'nameIdentifierScheme' => 'ORCID', '__content__' => '0000-0003-1419-2405' } }
-      expect(subject.is_personal_name?(name: author['creatorName'])).to be true
+    it "has orcid id" do
+      author = { "creatorName" => "Fenner, Martin", "givenName" => "Martin", "familyName" => "Fenner",
+                 "nameIdentifier" => { "schemeURI" => "http://orcid.org/", "nameIdentifierScheme" => "ORCID", "__content__" => "0000-0003-1419-2405" } }
+      expect(subject.is_personal_name?(name: author["creatorName"])).to be true
     end
 
-    it 'has family name' do
-      author = { 'givenName' => 'Martin', 'familyName' => 'Fenner', 'name' => 'Martin Fenner' }
-      expect(subject.is_personal_name?(name: author['name'])).to be true
+    it "has family name" do
+      author = { "givenName" => "Martin", "familyName" => "Fenner", "name" => "Martin Fenner" }
+      expect(subject.is_personal_name?(name: author["name"])).to be true
     end
 
-    it 'has comma' do
-      author = { 'name' => 'Fenner, Martin' }
-      expect(subject.is_personal_name?(name: author['name'])).to be true
+    it "has comma" do
+      author = { "name" => "Fenner, Martin" }
+      expect(subject.is_personal_name?(name: author["name"])).to be true
     end
 
-    it 'has known given name' do
-      author = { 'name' => 'Martin Fenner' }
-      expect(subject.is_personal_name?(name: author['name'])).to be true
+    it "has known given name" do
+      author = { "name" => "Martin Fenner" }
+      expect(subject.is_personal_name?(name: author["name"])).to be true
     end
 
-    it 'has unknown given name' do
-      author = { 'name' => 'Rintze Zelle' }
-      expect(subject.is_personal_name?(name: author['name'])).to be true
+    it "has unknown given name" do
+      author = { "name" => "Rintze Zelle" }
+      expect(subject.is_personal_name?(name: author["name"])).to be true
     end
 
-    it 'has middle initial' do
-      author = { 'name' => 'Martin H. Fenner' }
-      expect(subject.is_personal_name?(name: author['name'])).to be true
+    it "has middle initial" do
+      author = { "name" => "Martin H. Fenner" }
+      expect(subject.is_personal_name?(name: author["name"])).to be true
     end
 
-    it 'has unknown given name and middle initial' do
-      author = { 'name' => 'Tejas S. Sathe' }
-      expect(subject.is_personal_name?(name: author['name'])).to be true
+    it "has unknown given name and middle initial" do
+      author = { "name" => "Tejas S. Sathe" }
+      expect(subject.is_personal_name?(name: author["name"])).to be true
     end
 
-    it 'has no info' do
-      author = { 'name' => 'M Fenner' }
-      expect(subject.is_personal_name?(name: author['name'])).to be true
+    it "has no info" do
+      author = { "name" => "M Fenner" }
+      expect(subject.is_personal_name?(name: author["name"])).to be true
     end
 
-    it 'name with title' do
-      author = { 'name' => 'Tejas S. Sathe, MD' }
-      expect(subject.is_personal_name?(name: author['name'])).to be true
+    it "name with title" do
+      author = { "name" => "Tejas S. Sathe, MD" }
+      expect(subject.is_personal_name?(name: author["name"])).to be true
     end
   end
 
-  context 'cleanup_author' do
-    it 'Smith J.' do
-      author = 'Smith J.'
-      expect(subject.cleanup_author(author)).to eq('Smith, J.')
+  context "cleanup_author" do
+    it "Smith J." do
+      author = "Smith J."
+      expect(subject.cleanup_author(author)).to eq("Smith, J.")
     end
 
-    it 'Smith, John' do
-      author = 'Smith, John'
-      expect(subject.cleanup_author(author)).to eq('Smith, John')
+    it "Smith, John" do
+      author = "Smith, John"
+      expect(subject.cleanup_author(author)).to eq("Smith, John")
     end
 
-    it 'John Smith' do
-      author = 'John Smith'
-      expect(subject.cleanup_author(author)).to eq('John Smith')
+    it "John Smith" do
+      author = "John Smith"
+      expect(subject.cleanup_author(author)).to eq("John Smith")
     end
 
-    it 'with email' do
-      author = 'noreply@blogger.com (Roderic Page)'
-      expect(subject.cleanup_author(author)).to eq('Roderic Page')
+    it "with email" do
+      author = "noreply@blogger.com (Roderic Page)"
+      expect(subject.cleanup_author(author)).to eq("Roderic Page")
     end
   end
 
-  context 'get_one_author' do
-    it 'has type organization' do
-      author = { 'email' => 'info@ucop.edu', 'name' => 'University of California, Santa Barbara',
-                 'role' => { 'namespace' => 'http://www.ngdc.noaa.gov/metadata/published/xsd/schema/resources/Codelist/gmxCodelists.xml#CI_RoleCode', 'roleCode' => 'copyrightHolder' }, 'type' => 'Organization' }
+  context "get_one_author" do
+    it "has type organization" do
+      author = { "email" => "info@ucop.edu", "name" => "University of California, Santa Barbara",
+                 "role" => { "namespace" => "http://www.ngdc.noaa.gov/metadata/published/xsd/schema/resources/Codelist/gmxCodelists.xml#CI_RoleCode", "roleCode" => "copyrightHolder" }, "type" => "Organization" }
       response = subject.get_one_author(author)
-      expect(response).to eq('name' => 'University of California, Santa Barbara', 'type' => 'Organization')
+      expect(response).to eq("name" => "University of California, Santa Barbara", "type" => "Organization")
     end
 
-    it 'has familyName' do
-      input = 'https://doi.org/10.5438/4K3M-NYVG'
+    it "has familyName" do
+      input = "https://doi.org/10.5438/4K3M-NYVG"
       subject = described_class.new(input: input)
-      meta = JSON.parse(subject.raw).dig('data', 'attributes')
-      response = subject.get_one_author(meta.dig('creators').first)
+      meta = JSON.parse(subject.raw).dig("data", "attributes")
+      response = subject.get_one_author(meta.dig("creators").first)
       expect(response).to eq(
-        'id' => 'https://orcid.org/0000-0003-1419-2405',
-        'givenName' => 'Martin', 'familyName' => 'Fenner', 'type' => 'Person'
+        "id" => "https://orcid.org/0000-0003-1419-2405",
+        "givenName" => "Martin", "familyName" => "Fenner", "type" => "Person",
       )
     end
 
-    it 'has name with title' do
-      author = { 'name' => "Tejas S. Sathe, MD" }
+    it "has name with title" do
+      author = { "name" => "Tejas S. Sathe, MD" }
       response = subject.get_one_author(author)
-      expect(response).to eq('givenName' => 'Tejas S.', 'familyName' => 'Sathe', 'type' => 'Person')
+      expect(response).to eq("givenName" => "Tejas S.", "familyName" => "Sathe", "type" => "Person")
     end
 
-    it 'has name in display-order with ORCID' do
-      input = 'https://doi.org/10.6084/M9.FIGSHARE.4700788'
+    it "has name in display-order with ORCID" do
+      input = "https://doi.org/10.6084/M9.FIGSHARE.4700788"
       subject = described_class.new(input: input)
-      meta = JSON.parse(subject.raw).dig('data', 'attributes')
-      response = subject.get_one_author(meta.dig('creators').first)
-      expect(response).to eq('type' => 'Person',
-                             'id' => 'https://orcid.org/0000-0003-4881-1606',
-                             'givenName' => 'Andrea', 'familyName' => 'Bedini')
+      meta = JSON.parse(subject.raw).dig("data", "attributes")
+      response = subject.get_one_author(meta.dig("creators").first)
+      expect(response).to eq("type" => "Person",
+                             "id" => "https://orcid.org/0000-0003-4881-1606",
+                             "givenName" => "Andrea", "familyName" => "Bedini")
     end
 
-    it 'is organization' do
-      author = { 'email' => 'info@ucop.edu',
-                 'name' => { '__content__' => 'University of California, Santa Barbara' },
-                 'type' => 'Organization', 'role' => { 'namespace' => 'http://www.ngdc.noaa.gov/metadata/published/xsd/schema/resources/Codelist/gmxCodelists.xml#CI_RoleCode', 'roleCode' => 'copyrightHolder' } }
+    it "is organization" do
+      author = { "email" => "info@ucop.edu",
+                 "name" => { "__content__" => "University of California, Santa Barbara" },
+                 "type" => "Organization", "role" => { "namespace" => "http://www.ngdc.noaa.gov/metadata/published/xsd/schema/resources/Codelist/gmxCodelists.xml#CI_RoleCode", "roleCode" => "copyrightHolder" } }
       response = subject.get_one_author(author)
-      expect(response).to eq('name' => 'University of California, Santa Barbara',
-                             'type' => 'Organization')
+      expect(response).to eq("name" => "University of California, Santa Barbara",
+                             "type" => "Organization")
     end
 
-    it 'name with affiliation crossref' do
-      input = '10.7554/elife.01567'
-      subject = described_class.new(input: input, from: 'crossref')
+    it "is another organization" do
+      author = { "name" => "University of California, Santa Barbara",
+                 "id" => "https://ror.org/02t274463" }
+      response = subject.get_one_author(author)
+      expect(response).to eq("id" => "https://ror.org/02t274463", "name" => "University of California, Santa Barbara", "type" => "Organization")
+    end
+
+    it "is anonymous" do
+      author = { "id" => "https://ror.org/05745n787" }
+      response = subject.get_one_author(author)
+      expect(response).to eq("type" => "Person", "affiliation" => [{"id"=>"https://ror.org/05745n787"}])
+    end
+
+    it "name with affiliation crossref" do
+      input = "10.7554/elife.01567"
+      subject = described_class.new(input: input, from: "crossref")
       response = subject.get_one_author(subject.creators.first)
-      expect(response).to eq('affiliation' => [{ 'name' => 'Department of Plant Molecular Biology, University of Lausanne, Lausanne, Switzerland' }], 'familyName' => 'Sankar',
-                             'givenName' => 'Martial',
-                             'type' => 'Person')
+      expect(response).to eq("affiliation" => [{ "name" => "Department of Plant Molecular Biology, University of Lausanne, Lausanne, Switzerland" }], "familyName" => "Sankar",
+                             "givenName" => "Martial",
+                             "type" => "Person")
     end
 
-    it 'only familyName and givenName' do
-      input = 'https://doi.pangaea.de/10.1594/PANGAEA.836178'
-      subject = described_class.new(input: input, from: 'schema_org')
+    it "only familyName and givenName" do
+      input = "https://doi.pangaea.de/10.1594/PANGAEA.836178"
+      subject = described_class.new(input: input, from: "schema_org")
       response = subject.get_one_author(subject.creators.first)
-      expect(response).to eq('type' => 'Person', 'givenName' => 'Emma', 'familyName' => 'Johansson')
+      expect(response).to eq("type" => "Person", "givenName" => "Emma", "familyName" => "Johansson")
+    end
+
+    it "affiliation is space" do
+      input = "10.1177/0042098011428175"
+      subject = described_class.new(input: input)
+      response = subject.get_one_author(subject.creators.first)
+      expect(response).to eq("familyName"=>"Petrovici", "givenName"=>"Norbert", "type"=>"Person")
     end
   end
 
-  context 'authors_as_string' do
+  context "authors_as_string" do
     let(:authors) do
-      [{ 'type' => 'Person',
-         'id' => 'https://orcid.org/0000-0003-0077-4738',
-         'givenName' => 'Matt',
-         'familyName' => 'Jones' },
-       { 'type' => 'Person',
-         'id' => 'https://orcid.org/0000-0002-2192-403X',
-         'givenName' => 'Peter',
-         'familyName' => 'Slaughter' },
-       { 'type' => 'Organization',
-         'id' => 'https://ror.org/02t274463',
-         'name' => 'University of California, Santa Barbara' }]
-    end
-
-    it 'authors' do
+      [{ "type" => "Person",
+         "id" => "https://orcid.org/0000-0003-0077-4738",
+         "givenName" => "Matt",
+         "familyName" => "Jones" },
+       { "type" => "Person",
+         "id" => "https://orcid.org/0000-0002-2192-403X",
+         "givenName" => "Peter",
+         "familyName" => "Slaughter" },
+       { "type" => "Organization",
+         "id" => "https://ror.org/02t274463",
+         "name" => "University of California, Santa Barbara" }]
+    end
+
+    it "authors" do
       response = subject.authors_as_string(authors[0..1])
-      expect(response).to eq('Jones, Matt and Slaughter, Peter')
+      expect(response).to eq("Jones, Matt and Slaughter, Peter")
     end
 
-    it 'single author' do
+    it "single author" do
       response = subject.authors_as_string(authors.first)
-      expect(response).to eq('Jones, Matt')
+      expect(response).to eq("Jones, Matt")
     end
 
-    it 'no author' do
+    it "no author" do
       response = subject.authors_as_string(nil)
       expect(response.nil?).to be(true)
     end
 
-    it 'with organization' do
+    it "with organization" do
       response = subject.authors_as_string(authors)
-      expect(response).to eq('Jones, Matt and Slaughter, Peter and {University of California, Santa Barbara}')
+      expect(response).to eq("Jones, Matt and Slaughter, Peter and {University of California, Santa Barbara}")
+    end
+  end
+
+  context "get_affiliations" do
+    it "name" do
+      affiliation = [{ 'name' => 'University of Zurich, Zurich, Switzerland' }]
+      response = subject.get_affiliations(affiliation)
+      expect(response).to eq([{ 'name' => 'University of Zurich, Zurich, Switzerland' }])
+    end
+
+    it "name and ROR ID" do
+      affiliation = { "id" => "https://ror.org/02t274463",
+                      "name" => "University of California, Santa Barbara" }
+      response = subject.get_affiliations(affiliation)
+      expect(response).to eq([{ "name" => "University of California, Santa Barbara" }])
+    end
+
+    it "only ROR ID" do
+      affiliation = { "affiliationIdentifier" => "https://ror.org/02t274463" }
+      response = subject.get_affiliations(affiliation)
+      expect(response).to eq([{"id"=>"https://ror.org/02t274463"}])
     end
   end
 end