cisco_node_utils 1.0.1 → 1.1.0

data/tests/test_yum.rb

@@ -12,57 +12,63 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-require File.expand_path("../ciscotest", __FILE__)
-require File.expand_path("../../lib/cisco_node_utils/yum", __FILE__)
+require_relative 'ciscotest'
+require_relative '../lib/cisco_node_utils/yum'
 
+# TestYum - Minitest for Yum node utility class
 class TestYum < CiscoTestCase
+  # rubocop:disable Style/ClassVars
   @@skip = false
   @@run_setup = true
   @@pkg = 'n9000_sample'
   @@pkg_ver = '1.0.0-7.0.3'
   @@pkg_filename = 'n9000_sample-1.0.0-7.0.3.x86_64.rpm'
+  @@incompatible_rpm_msg =
+    ': The sample rpm is compatible with NX-OS release version 7.0(3)I2(1). ' \
+    'This test may fail with other versions.'
+  # rubocop:enable Style/ClassVars
 
   def setup
     super
     # only run check once (can't use initialize because @device isn't ready)
-    if @@run_setup
-      s = @device.cmd("show file bootflash:#{@@pkg_filename} cksum")
-      if s[/No such file/]
-        @@skip = true
-      else
-        # add pkg to the repo
-        # normally this could be accomplished by first installing via full path
-        # but that would make these tests order dependent
-        unless @device.cmd("show install package | include #{@@pkg}")[/@patching/]
-          @device.cmd("install add bootflash:#{@@pkg_filename}")
-          # Wait for install to complete
-          sleep 30
-        end
+    return unless @@run_setup
+
+    s = @device.cmd("show file bootflash:#{@@pkg_filename} cksum")
+    if s[/No such file/]
+      @@skip = true # rubocop:disable Style/ClassVars
+    else
+      # add pkg to the repo
+      # normally this could be accomplished by first installing via full path
+      # but that would make these tests order dependent
+      unless @device.cmd("show install package | include #{@@pkg}")[/@patching/]
+        @device.cmd("install add bootflash:#{@@pkg_filename}")
+        # Wait for install to complete
+        sleep 30
       end
-      @@run_setup = false
     end
+    @@run_setup = false # rubocop:disable Style/ClassVars
   end
 
   def skip?
-    skip "file bootflash:#{@@pkg_filename} is required. " +
-      "this file can be found in the cisco_node_utils/tests directory" if @@skip
+    skip "file bootflash:#{@@pkg_filename} is required. " \
+      'this file can be found in the cisco_node_utils/tests directory' if @@skip
   end
 
   def test_install
-      skip?
-      if @device.cmd("show install package | include #{@@pkg}")[/@patching/]
-        @device.cmd("install deactivate #{@@pkg}")
-        node.cache_flush
-        sleep 20
-      end
-
-      # Specify "management" vrf for install
-      Yum.install(@@pkg, "management")
+    skip?
+    if @device.cmd("show install package | include #{@@pkg}")[/@patching/]
+      @device.cmd("install deactivate #{@@pkg}")
+      node.cache_flush
       sleep 20
-      s = @device.cmd("show install package | include #{@@pkg}")[/@patching/]
-      assert(s, "failed to find installed package #{@@pkg}")
-    rescue RuntimeError => e
-      assert(false, e.message)
+    end
+
+    # Specify "management" vrf for install
+    Yum.install(@@pkg, 'management')
+    sleep 20
+    s = @device.cmd("show install package | include #{@@pkg}")[/@patching/]
+    assert(s, "failed to find installed package #{@@pkg}")
+  rescue RuntimeError => e
+    assert(false, e.message + @@incompatible_rpm_msg)
   end
 
   def test_remove
@@ -74,22 +80,22 @@ class TestYum < CiscoTestCase
     end
     Yum.remove(@@pkg)
     sleep 20
-    s = @device.cmd("show install package | include #{@@pkg}")[/@patching/]
-    assert_nil(s)
+    refute_show_match(command: "show install package | include #{@@pkg}",
+                      pattern: /@patching/)
   end
 
   def test_ambiguous_package_error
     skip?
-    assert_raises(RuntimeError) { Yum.query("busybox") }
+    assert_raises(RuntimeError) { Yum.query('busybox') }
   end
 
   def test_package_does_not_exist_error
-    assert_raises(Cisco::CliError) {
-      Yum.install("bootflash:this_is_not_real.rpm", "management")
-    }
-    assert_raises(RuntimeError) {
-      Yum.install("also_not_real", "management")
-    }
+    assert_raises(Cisco::CliError) do
+      Yum.install('bootflash:this_is_not_real.rpm', 'management')
+    end
+    assert_raises(RuntimeError) do
+      Yum.install('also_not_real', 'management')
+    end
   end
 
   def test_query
@@ -100,7 +106,7 @@ class TestYum < CiscoTestCase
       sleep 20
     end
     ver = Yum.query(@@pkg)
-    assert_equal(ver, @@pkg_ver)
+    assert_equal(ver, @@pkg_ver, @@incompatible_rpm_msg)
     @device.cmd("install deactivate #{@@pkg}")
     node.cache_flush
     sleep 20

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cisco_node_utils
 version: !ruby/object:Gem::Version
-  version: 1.0.1
-  prerelease: 
+  version: 1.1.0
 platform: ruby
 authors:
 - Alex Hunsberger
@@ -13,109 +12,104 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-18 00:00:00.000000000 Z
+date: 2015-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.5.1
-    - - <
-      - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: '5.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 2.5.1
-    - - <
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.34.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.34.2
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.32'
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.32'
+        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: cisco_nxapi
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-description: ! 'Utilities for management of Cisco network nodes.
-
+description: |
+  Utilities for management of Cisco network nodes.
   Designed to work with Puppet and Chef.
-
   Currently supports NX-OS nodes.
-
-'
 email: cisco_agent_gem@cisco.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rubocop.yml
-- .rubocop_todo.yml
+- ".gitignore"
+- ".rubocop.yml"
+- ".travis.yml"
 - CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
@@ -123,91 +117,133 @@ files:
 - README.md
 - Rakefile
 - SUPPORT.md
+- bin/check_metric_limits.rb
+- bin/git/hooks/commit-msg/enforce_style
+- bin/git/hooks/hook_lib
+- bin/git/hooks/hooks-wrapper
+- bin/git/hooks/post-flow-hotfix-start/update-version
+- bin/git/hooks/post-flow-release-finish/update-version
+- bin/git/hooks/post-flow-release-start/update-version
+- bin/git/hooks/post-merge/update-hooks
+- bin/git/hooks/post-rewrite/update-hooks
+- bin/git/hooks/pre-commit/rubocop
+- bin/git/hooks/pre-commit/validate-diffs
+- bin/git/hooks/pre-push/check-changelog
+- bin/git/hooks/pre-push/rubocop
+- bin/git/update-hooks
 - cisco_node_utils.gemspec
-- docs/.rubocop.yml
+- docs/README-develop-best-practices.md
 - docs/README-develop-node-utils-APIs.md
 - docs/README-maintainers.md
 - docs/agent_files.png
-- docs/template-feature.rb
 - docs/template-router.rb
-- docs/template-test_feature.rb
 - docs/template-test_router.rb
+- lib/.rubocop.yml
 - lib/cisco_node_utils.rb
 - lib/cisco_node_utils/README_YAML.md
+- lib/cisco_node_utils/bgp.rb
+- lib/cisco_node_utils/bgp_af.rb
+- lib/cisco_node_utils/bgp_neighbor.rb
+- lib/cisco_node_utils/bgp_neighbor_af.rb
 - lib/cisco_node_utils/cisco_cmn_utils.rb
 - lib/cisco_node_utils/command_reference.rb
 - lib/cisco_node_utils/command_reference_common.yaml
+- lib/cisco_node_utils/command_reference_common_bgp.yaml
 - lib/cisco_node_utils/command_reference_n3064.yaml
 - lib/cisco_node_utils/command_reference_n7k.yaml
 - lib/cisco_node_utils/command_reference_n9k.yaml
 - lib/cisco_node_utils/configparser_lib.rb
+- lib/cisco_node_utils/dns_domain.rb
+- lib/cisco_node_utils/domain_name.rb
 - lib/cisco_node_utils/interface.rb
 - lib/cisco_node_utils/interface_ospf.rb
+- lib/cisco_node_utils/name_server.rb
 - lib/cisco_node_utils/node.rb
+- lib/cisco_node_utils/node_util.rb
+- lib/cisco_node_utils/ntp_config.rb
+- lib/cisco_node_utils/ntp_server.rb
 - lib/cisco_node_utils/platform.rb
-- lib/cisco_node_utils/platform_info.rb
-- lib/cisco_node_utils/platform_info.yaml
+- lib/cisco_node_utils/radius_global.rb
+- lib/cisco_node_utils/radius_server.rb
 - lib/cisco_node_utils/router_ospf.rb
 - lib/cisco_node_utils/router_ospf_vrf.rb
 - lib/cisco_node_utils/snmpcommunity.rb
 - lib/cisco_node_utils/snmpgroup.rb
 - lib/cisco_node_utils/snmpserver.rb
 - lib/cisco_node_utils/snmpuser.rb
+- lib/cisco_node_utils/syslog_server.rb
+- lib/cisco_node_utils/syslog_settings.rb
 - lib/cisco_node_utils/tacacs_server.rb
 - lib/cisco_node_utils/tacacs_server_host.rb
 - lib/cisco_node_utils/version.rb
 - lib/cisco_node_utils/vlan.rb
+- lib/cisco_node_utils/vrf.rb
 - lib/cisco_node_utils/vtp.rb
 - lib/cisco_node_utils/yum.rb
+- tests/.rubocop.yml
 - tests/basetest.rb
 - tests/ciscotest.rb
 - tests/cmd_config.yaml
 - tests/cmd_config_invalid.yaml
 - tests/n9000_sample-1.0.0-7.0.3.x86_64.rpm
-- tests/test_all_cisco.rb
+- tests/platform_info.rb
+- tests/platform_info.yaml
+- tests/test_bgp_af.rb
+- tests/test_bgp_neighbor.rb
+- tests/test_bgp_neighbor_af.rb
 - tests/test_command_config.rb
 - tests/test_command_reference.rb
+- tests/test_dns_domain.rb
+- tests/test_domain_name.rb
 - tests/test_interface.rb
 - tests/test_interface_ospf.rb
 - tests/test_interface_svi.rb
 - tests/test_interface_switchport.rb
+- tests/test_name_server.rb
 - tests/test_node.rb
 - tests/test_node_ext.rb
+- tests/test_ntp_config.rb
+- tests/test_ntp_server.rb
 - tests/test_platform.rb
+- tests/test_radius_global.rb
+- tests/test_radius_server.rb
+- tests/test_router_bgp.rb
 - tests/test_router_ospf.rb
 - tests/test_router_ospf_vrf.rb
 - tests/test_snmpcommunity.rb
 - tests/test_snmpgroup.rb
 - tests/test_snmpserver.rb
 - tests/test_snmpuser.rb
+- tests/test_syslog_server.rb
+- tests/test_syslog_settings.rb
 - tests/test_tacacs_server.rb
 - tests/test_tacacs_server_host.rb
 - tests/test_vlan.rb
+- tests/test_vrf.rb
 - tests/test_vtp.rb
 - tests/test_yum.rb
-homepage: 
+homepage: https://github.com/cisco/cisco-network-node-utils
 licenses:
 - Apache-2.0
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.1.0
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Utilities for management of Cisco network nodes
 test_files: []

data/.rubocop_todo.yml

@@ -1,293 +0,0 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2015-06-22 10:15:27 -0400 using RuboCop version 0.32.0.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 1
-# Configuration parameters: AllowSafeAssignment.
-Lint/AssignmentInCondition:
-  Enabled: false
-
-# Offense count: 2
-Lint/ConditionPosition:
-  Enabled: false
-
-# Offense count: 4
-Lint/DuplicateMethods:
-  Enabled: false
-
-# Offense count: 1
-Lint/Eval:
-  Enabled: false
-
-# Offense count: 1
-Lint/HandleExceptions:
-  Enabled: false
-
-# Offense count: 3
-Lint/ParenthesesAsGroupedExpression:
-  Enabled: false
-
-# Offense count: 6
-Lint/RescueException:
-  Enabled: false
-
-# Offense count: 1
-Lint/ShadowingOuterLocalVariable:
-  Enabled: false
-
-# Offense count: 32
-# Cop supports --auto-correct.
-Lint/UnusedBlockArgument:
-  Enabled: false
-
-# Offense count: 7
-# Cop supports --auto-correct.
-Lint/UnusedMethodArgument:
-  Enabled: false
-
-# Offense count: 501
-Lint/UselessAssignment:
-  Enabled: false
-
-# Offense count: 25
-Lint/UselessSetterCall:
-  Enabled: false
-
-# Offense count: 188
-Metrics/AbcSize:
-  Max: 143
-
-# Offense count: 4
-Metrics/BlockNesting:
-  Max: 4
-
-# Offense count: 31
-# Configuration parameters: CountComments.
-Metrics/ClassLength:
-  Max: 768
-
-# Offense count: 26
-Metrics/CyclomaticComplexity:
-  Max: 26
-
-# Offense count: 235
-# Configuration parameters: AllowURI, URISchemes.
-Metrics/LineLength:
-  Max: 128
-
-# Offense count: 276
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 177
-
-# Offense count: 1
-# Configuration parameters: CountKeywordArgs.
-Metrics/ParameterLists:
-  Max: 9
-
-# Offense count: 22
-Metrics/PerceivedComplexity:
-  Max: 26
-
-# Offense count: 10
-Style/AccessorMethodName:
-  Enabled: false
-
-# Offense count: 231
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/AlignParameters:
-  Enabled: false
-
-# Offense count: 64
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/AndOr:
-  Enabled: false
-
-# Offense count: 3
-# Cop supports --auto-correct.
-Style/BlockComments:
-  Enabled: false
-
-# Offense count: 88
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
-Style/BlockDelimiters:
-  Enabled: false
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/BracesAroundHashParameters:
-  Enabled: false
-
-# Offense count: 1
-Style/CaseEquality:
-  Enabled: false
-
-# Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/ClassCheck:
-  Enabled: false
-
-# Offense count: 85
-# Cop supports --auto-correct.
-Style/ClassMethods:
-  Enabled: false
-
-# Offense count: 65
-Style/ClassVars:
-  Enabled: false
-
-# Offense count: 55
-Style/Documentation:
-  Enabled: false
-
-# Offense count: 1
-Style/DoubleNegation:
-  Enabled: false
-
-# Offense count: 5
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/FormatString:
-  Enabled: false
-
-# Offense count: 5
-# Configuration parameters: AllowedVariables.
-Style/GlobalVars:
-  Enabled: false
-
-# Offense count: 10
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Enabled: false
-
-# Offense count: 153
-# Cop supports --auto-correct.
-# Configuration parameters: SupportedStyles, UseHashRocketsWithSymbolValues.
-Style/HashSyntax:
-  EnforcedStyle: hash_rockets
-
-# Offense count: 52
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/IndentationConsistency:
-  Enabled: false
-
-# Offense count: 42
-# Cop supports --auto-correct.
-# Configuration parameters: Width.
-Style/IndentationWidth:
-  Enabled: false
-
-# Offense count: 56
-# Cop supports --auto-correct.
-Style/LineEndConcatenation:
-  Enabled: false
-
-# Offense count: 105
-# Cop supports --auto-correct.
-Style/MethodCallParentheses:
-  Enabled: false
-
-# Offense count: 1
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/MethodName:
-  Enabled: false
-
-# Offense count: 25
-Style/MultilineTernaryOperator:
-  Enabled: false
-
-# Offense count: 12
-# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
-Style/Next:
-  Enabled: false
-
-# Offense count: 61
-# Cop supports --auto-correct.
-Style/Not:
-  Enabled: false
-
-# Offense count: 18
-# Cop supports --auto-correct.
-Style/NumericLiterals:
-  MinDigits: 11
-
-# Offense count: 30
-# Cop supports --auto-correct.
-Style/ParallelAssignment:
-  Enabled: false
-
-# Offense count: 1
-# Configuration parameters: NamePrefix, NamePrefixBlacklist.
-Style/PredicateName:
-  Enabled: false
-
-# Offense count: 1
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/RaiseArgs:
-  Enabled: false
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
-Style/RegexpLiteral:
-  Enabled: false
-
-# Offense count: 139
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/SignalException:
-  Enabled: false
-
-# Offense count: 69
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleInsidePipes, SupportedStyles.
-Style/SpaceAroundBlockParameters:
-  Enabled: false
-
-# Offense count: 50
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/SpaceAroundEqualsInParameterDefault:
-  Enabled: false
-
-# Offense count: 140
-# Cop supports --auto-correct.
-# Configuration parameters: MultiSpaceAllowedForOperators.
-Style/SpaceAroundOperators:
-  Enabled: false
-
-# Offense count: 3
-# Cop supports --auto-correct.
-Style/SpecialGlobalVars:
-  Enabled: false
-
-# Offense count: 3391
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiterals:
-  Enabled: false
-
-# Offense count: 18
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiteralsInInterpolation:
-  Enabled: false
-
-# Offense count: 37
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
-Style/TrailingComma:
-  Enabled: false
-
-# Offense count: 1
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/VariableName:
-  Enabled: false