cisco_node_utils 1.0.1 → 1.1.0

data/tests/test_snmpcommunity.rb

@@ -12,333 +12,289 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-require File.expand_path("../ciscotest", __FILE__)
-require File.expand_path("../../lib/cisco_node_utils/snmpcommunity", __FILE__)
+require_relative 'ciscotest'
+require_relative '../lib/cisco_node_utils/snmpcommunity'
 
 def cleanup_snmp_communities(snmpcommunities)
-  snmpcommunities.each { |name, snmpcommunity|
-    snmpcommunity.destroy
-  }
+  snmpcommunities.each_value(&:destroy)
 end
 
 def cleanup_snmpcommunity(community)
   community.destroy
 end
 
+# TestSnmpCommunity - Minitest for SnmpCommunity node utility
 class TestSnmpCommunity < CiscoTestCase
   SNMP_COMMUNITY_NAME_STR = 128
   SNMP_GROUP_NAME_STR = 128
-  DEFAULT_SNMP_COMMUNITY_GROUP = "network-operator"
-  DEFAULT_SNMP_COMMUNITY_ACL = ""
+  DEFAULT_SNMP_COMMUNITY_GROUP = 'network-operator'
+  DEFAULT_SNMP_COMMUNITY_ACL = ''
+
+  def setup
+    super
+    @default_show_command = 'show run snmp all | no-more'
+  end
 
   def test_snmpcommunity_collection_empty
-      # This test requires all the snmp communities removed from device
-      s = @device.cmd("show run snmp all | no-more")
-      cmd_prefix = "snmp-server community"
-      # puts "s : #{s}"
-      pattern = /#{cmd_prefix}\s\S+\sgroup\s\S+/
-      until (md = pattern.match(s)).nil?
-        # puts "md : #{md}"
-        ret = @device.cmd("configure terminal")
-        ret = @device.cmd("no #{md}")
-        ret = @device.cmd("end")
-        node.cache_flush
-        s = md.post_match
-      end
-      snmpcommunities = SnmpCommunity.communities()
-      assert_equal(true, snmpcommunities.empty?(),
-                   "SnmpCommunity collection is not empty")
+    # This test requires all the snmp communities removed from device
+    s = @device.cmd('show run snmp all | no-more')
+    cmd_prefix = 'snmp-server community'
+    # puts "s : #{s}"
+    pattern = /#{cmd_prefix}\s\S+\sgroup\s\S+/
+    until (md = pattern.match(s)).nil?
+      # puts "md : #{md}"
+      config("no #{md}")
+      s = md.post_match
+    end
+    snmpcommunities = SnmpCommunity.communities
+    assert_equal(true, snmpcommunities.empty?,
+                 'SnmpCommunity collection is not empty')
   end
 
   def test_snmpcommunity_collection_not_empty
-      # This test require some snmp community exist in device
-      s = @device.cmd("configure terminal")
-      s = @device.cmd("snmp-server community com1 group network-admin")
-      s = @device.cmd("snmp-server community com2")
-      s = @device.cmd("end")
-      node.cache_flush
-      snmpcommunities = SnmpCommunity.communities()
-      assert_equal(false, snmpcommunities.empty?(),
-                   "SnmpCommunity collection is empty")
-      cleanup_snmp_communities(snmpcommunities)
+    # This test require some snmp community exist in device
+    config('snmp-server community com1 group network-admin',
+           'snmp-server community com2')
+    snmpcommunities = SnmpCommunity.communities
+    assert_equal(false, snmpcommunities.empty?,
+                 'SnmpCommunity collection is empty')
+    cleanup_snmp_communities(snmpcommunities)
   end
 
   def test_snmpcommunity_collection_valid
-      # This test require some snmp community exist in device
-      s = @device.cmd("configure terminal")
-      s = @device.cmd("snmp-server community com12 group network-operator")
-      s = @device.cmd("snmp-server community com22 group network-admin")
-      s = @device.cmd("end")
-      node.cache_flush
-      # get collection
-      snmpcommunities = SnmpCommunity.communities()
-      s = @device.cmd("show run snmp all | no-more")
-      cmd = "snmp-server community"
-      snmpcommunities.each do |name, snmpcommunity|
-        line = /#{cmd}\s#{name}\sgroup\s#{snmpcommunity.group}/.match(s)
-        # puts "line: #{line}"
-        assert_equal(false, line.nil?)
-      end
-      cleanup_snmp_communities(snmpcommunities)
-      snmpcommunities = nil
+    # This test require some snmp community exist in device
+    config('snmp-server community com12 group network-operator',
+           'snmp-server community com22 group network-admin')
+    # get collection
+    snmpcommunities = SnmpCommunity.communities
+    s = @device.cmd('show run snmp all | no-more')
+    cmd = 'snmp-server community'
+    snmpcommunities.each do |name, snmpcommunity|
+      line = /#{cmd}\s#{name}\sgroup\s#{snmpcommunity.group}/.match(s)
+      # puts "line: #{line}"
+      assert_equal(false, line.nil?)
+    end
+    cleanup_snmp_communities(snmpcommunities)
   end
 
   def test_snmpcommunity_create_name_nil
     assert_raises(TypeError) do
-      snmpcommunity = SnmpCommunity.new(nil, "network-operator")
+      SnmpCommunity.new(nil, 'network-operator')
     end
   end
 
   def test_snmpcommunity_create_group_nil
     assert_raises(TypeError) do
-      snmpcommunity = SnmpCommunity.new("test", nil)
+      SnmpCommunity.new('test', nil)
     end
   end
 
   def test_snmpcommunity_create_name_zero_length
     assert_raises(Cisco::CliError) do
-      snmpcommunity = SnmpCommunity.new("", "network-operator")
+      SnmpCommunity.new('', 'network-operator')
     end
   end
 
   def test_snmpcommunity_create_group_zero_length
     assert_raises(Cisco::CliError) do
-      snmpcommunity = SnmpCommunity.new("test", "")
+      SnmpCommunity.new('test', '')
     end
   end
 
   def test_snmpcommunity_create_name_too_long
-    name = "co"
-    SNMP_COMMUNITY_NAME_STR.times {
-      name += "c"
-    }
+    name = 'co' + 'c' * SNMP_COMMUNITY_NAME_STR
     assert_raises(Cisco::CliError) do
-      snmpcommunity = SnmpCommunity.new(name,
-                                        "network-operator")
+      SnmpCommunity.new(name, 'network-operator')
     end
   end
 
   def test_snmpcommunity_create_group_too_long
-    group = "gr"
-    SNMP_GROUP_NAME_STR.times {
-      group += "g"
-    }
+    group = 'gr' + 'g' * SNMP_GROUP_NAME_STR
     assert_raises(Cisco::CliError) do
-      snmpcommunity = SnmpCommunity.new("test", group)
+      SnmpCommunity.new('test', group)
     end
   end
 
   def test_snmpcommunity_create_group_invalid
-    name = "ciscotest"
-    group = "network-operator-invalid"
+    name = 'ciscotest'
+    group = 'network-operator-invalid'
     assert_raises(Cisco::CliError) do
-      snmpcommunity = SnmpCommunity.new(name,
-                                        group)
+      SnmpCommunity.new(name, group)
     end
   end
 
   def test_snmpcommunity_create_valid
-    name = "cisco"
-    group = "network-operator"
+    name = 'cisco'
+    group = 'network-operator'
     snmpcommunity = SnmpCommunity.new(name, group)
-    s = @device.cmd("show run snmp all | no-more")
-    cmd = "snmp-server community"
-    line = /#{cmd}\s#{name}\sgroup\s#{group}/.match(s)
-    # puts "line: #{line}"
-    assert_equal(false, line.nil?)
+    assert_show_match(
+      pattern: /snmp-server community\s#{name}\sgroup\s#{group}/)
     cleanup_snmpcommunity(snmpcommunity)
   end
 
   def test_snmpcommunity_create_with_name_alphanumeric_char
-    name = "cisco128lab"
-    group = "network-operator"
+    name = 'cisco128lab'
+    group = 'network-operator'
     snmpcommunity = SnmpCommunity.new(name, group)
-    s = @device.cmd("show run snmp all | no-more")
-    cmd = "snmp-server community"
-    line = /#{cmd}\s#{name}\sgroup\s#{group}/.match(s)
-    # puts "line: #{line}"
-    assert_equal(false, line.nil?)
+    assert_show_match(
+      pattern: /snmp-server community\s#{name}\sgroup\s#{group}/)
     cleanup_snmpcommunity(snmpcommunity)
   end
 
   def test_snmpcommunity_get_group
-    name = "ciscogetgrp"
-    group = "network-operator"
+    name = 'ciscogetgrp'
+    group = 'network-operator'
     snmpcommunity = SnmpCommunity.new(name, group)
     assert_equal(snmpcommunity.group, group)
     cleanup_snmpcommunity(snmpcommunity)
   end
 
   def test_snmpcommunity_group_set_zero_length
-    name = "ciscogroupsetcom"
-    group = "network-operator"
+    name = 'ciscogroupsetcom'
+    group = 'network-operator'
     snmpcommunity = SnmpCommunity.new(name, group)
     assert_raises(Cisco::CliError) do
-      snmpcommunity.group=""
+      snmpcommunity.group = ''
     end
     cleanup_snmpcommunity(snmpcommunity)
   end
 
   def test_snmpcommunity_group_set_too_long
-    name = "ciscogroupsetcom"
-    group = "network-operator"
+    name = 'ciscogroupsetcom'
+    group = 'network-operator'
     snmpcommunity = SnmpCommunity.new(name, group)
     assert_raises(Cisco::CliError) do
-      snmpcommunity.group="group123456789c123456789c123456789c12345"
+      snmpcommunity.group = 'group123456789c123456789c123456789c12345'
     end
     cleanup_snmpcommunity(snmpcommunity)
   end
 
   def test_snmpcommunity_group_set_invalid
-    name = "ciscogroupsetcom"
-    group = "network-operator"
+    name = 'ciscogroupsetcom'
+    group = 'network-operator'
     snmpcommunity = SnmpCommunity.new(name, group)
     assert_raises(Cisco::CliError) do
-      snmpcommunity.group="testgroup"
+      snmpcommunity.group = 'testgroup'
     end
     cleanup_snmpcommunity(snmpcommunity)
   end
 
   def test_snmpcommunity_group_set_valid
-    name = "ciscogroupsetcom"
-    group = "network-operator"
+    name = 'ciscogroupsetcom'
+    group = 'network-operator'
     snmpcommunity = SnmpCommunity.new(name, group)
     # new group
-    group = "network-admin"
+    group = 'network-admin'
     snmpcommunity.group = group
-    s = @device.cmd("show run snmp all | no-more")
-    cmd = "snmp-server community"
-    line = /#{cmd}\s#{name}\sgroup\s#{group}/.match(s)
-    assert_equal(false, line.nil?)
+    assert_show_match(
+      pattern: /snmp-server community\s#{name}\sgroup\s#{group}/)
     cleanup_snmpcommunity(snmpcommunity)
   end
 
   def test_snmpcommunity_group_set_default
-    name = "ciscogroupsetcom"
-    group = "network-operator"
+    name = 'ciscogroupsetcom'
+    group = 'network-operator'
     snmpcommunity = SnmpCommunity.new(name, group)
     # new group identity
-    group = "vdc-admin"
+    group = 'vdc-admin'
     snmpcommunity.group = group
-    s = @device.cmd("show run snmp all | no-more")
-    cmd = "snmp-server community"
-    line = /#{cmd}\s#{name}\sgroup\s#{group}/.match(s)
-    # puts line
-    assert_equal(false, line.nil?)
+    assert_show_match(
+      pattern: /snmp-server community\s#{name}\sgroup\s#{group}/)
 
     # Restore group default
-    group = SnmpCommunity.default_group()
+    group = SnmpCommunity.default_group
     snmpcommunity.group = group
-    s = @device.cmd("show run snmp all | no-more")
-    cmd = "snmp-server community"
-    line = /#{cmd}\s#{name}\sgroup\s#{group}/.match(s)
-    # puts line
-    assert_equal(false, line.nil?)
+    assert_show_match(
+      pattern: /snmp-server community\s#{name}\sgroup\s#{group}/)
 
     cleanup_snmpcommunity(snmpcommunity)
   end
 
   def test_snmpcommunity_destroy_valid
-    name = "ciscotest"
-    group = "network-operator"
+    name = 'ciscotest'
+    group = 'network-operator'
     snmpcommunity = SnmpCommunity.new(name, group)
     snmpcommunity.destroy
-    s = @device.cmd("show run snmp all | no-more")
-    cmd = "snmp-server community"
-    line = /#{cmd}\s#{name}\sgroup\s#{group}/.match(s)
-    assert_equal(true, line.nil?)
+    refute_show_match(
+      pattern: /snmp-server community\s#{name}\sgroup\s#{group}/)
   end
 
   def test_snmpcommunity_acl_get_no_acl
-    name = "cisconoaclget"
-    group = "network-operator"
+    name = 'cisconoaclget'
+    group = 'network-operator'
     snmpcommunity = SnmpCommunity.new(name, group)
-    assert_equal(snmpcommunity.acl, "")
+    assert_equal(snmpcommunity.acl, '')
     cleanup_snmpcommunity(snmpcommunity)
   end
 
   def test_snmpcommunity_acl_get
-    name = "ciscoaclget"
-    group = "network-operator"
+    name = 'ciscoaclget'
+    group = 'network-operator'
     snmpcommunity = SnmpCommunity.new(name, group)
-    snmpcommunity.acl="ciscoacl"
-    s = @device.cmd("show run snmp all | no-more")
-    cmd = "snmp-server community"
-    line = /#{cmd}\s#{name}\suse-acl\s\S+/.match(s)
-    acl = line.to_s.gsub(/#{cmd}\s#{name}\suse-acl\s/, "").strip
+    snmpcommunity.acl = 'ciscoacl'
+    line = assert_show_match(
+      pattern: /snmp-server community\s#{name}\suse-acl\s\S+/)
+    acl = line.to_s.gsub(/snmp-server community\s#{name}\suse-acl\s/, '').strip
     assert_equal(snmpcommunity.acl, acl)
     cleanup_snmpcommunity(snmpcommunity)
   end
 
   def test_snmpcommunity_acl_set_nil
-    name = "cisco"
-    group = "network-operator"
+    name = 'cisco'
+    group = 'network-operator'
     snmpcommunity = SnmpCommunity.new(name, group)
     assert_raises(TypeError) do
-      snmpcommunity.acl=nil
+      snmpcommunity.acl = nil
     end
     cleanup_snmpcommunity(snmpcommunity)
   end
 
   def test_snmpcommunity_acl_set_valid
-    name = "ciscoadmin"
-    group = "network-admin"
-    acl = "ciscoadminacl"
+    name = 'ciscoadmin'
+    group = 'network-admin'
+    acl = 'ciscoadminacl'
     snmpcommunity = SnmpCommunity.new(name, group)
-    snmpcommunity.acl=acl
-    s = @device.cmd("show run snmp all | no-more")
-    cmd = "snmp-server community"
-    line = /#{cmd}\s#{name}\suse-acl\s#{acl}/.match(s)
-    # puts "line: #{line}"
-    assert_equal(false, line.nil?)
+    snmpcommunity.acl = acl
+    assert_show_match(
+      pattern: /snmp-server community\s#{name}\suse-acl\s#{acl}/)
     cleanup_snmpcommunity(snmpcommunity)
   end
 
   def test_snmpcommunity_acl_set_zero_length
-    name = "ciscooper"
-    group = "network-operator"
-    acl = "ciscooperacl"
+    name = 'ciscooper'
+    group = 'network-operator'
+    acl = 'ciscooperacl'
     snmpcommunity = SnmpCommunity.new(name, group)
     # puts "set acl #{acl}"
-    snmpcommunity.acl=acl
-    s = @device.cmd("show run snmp all | no-more")
-    cmd = "snmp-server community"
-    line = /#{cmd}\s#{name}\suse-acl\s#{acl}/.match(s)
-    # puts "line: #{line}"
-    assert_equal(false, line.nil?)
+    snmpcommunity.acl = acl
+    assert_show_match(
+      pattern: /snmp-server community\s#{name}\suse-acl\s#{acl}/)
     # remove acl
-    snmpcommunity.acl=""
-    s = @device.cmd("show run snmp all | no-more")
-    line = /#{cmd}\s#{name}\suse-acl\s#{acl}/.match(s)
-    # puts "line: #{line}"
-    assert_equal(true, line.nil?)
+    snmpcommunity.acl = ''
+    refute_show_match(
+      pattern: /snmp-server community\s#{name}\suse-acl\s#{acl}/)
     cleanup_snmpcommunity(snmpcommunity)
   end
 
   def test_snmpcommunity_acl_set_default
-    name = "cisco"
-    group = "network-operator"
-    acl = "cisco_test_acl"
+    name = 'cisco'
+    group = 'network-operator'
+    acl = 'cisco_test_acl'
     snmpcommunity = SnmpCommunity.new(name, group)
     snmpcommunity.acl = acl
-    s = @device.cmd("show run snmp all | no-more")
-    cmd = "snmp-server community"
-    line = /#{cmd}\s#{name}\suse-acl\s#{acl}/.match(s)
-    # puts "line: #{line}"
-    assert_equal(false, line.nil?)
+    assert_show_match(
+      pattern: /snmp-server community\s#{name}\suse-acl\s#{acl}/)
 
     # Check default_acl
     assert_equal(DEFAULT_SNMP_COMMUNITY_ACL,
-                 SnmpCommunity.default_acl(),
-                 "Error: Snmp Community, default ACL not correct value")
+                 SnmpCommunity.default_acl,
+                 'Error: Snmp Community, default ACL not correct value')
 
     # Set acl to default
-    acl = SnmpCommunity.default_acl()
+    acl = SnmpCommunity.default_acl
     snmpcommunity.acl = acl
-    s = @device.cmd("show run snmp all | no-more")
-    line = /#{cmd}\s#{name}\suse-acl\s#{acl}/.match(s)
-    # puts "line: #{line}"
-    assert_equal(true, line.nil?)
+    refute_show_match(
+      pattern: /snmp-server community\s#{name}\suse-acl\s#{acl}/)
     cleanup_snmpcommunity(snmpcommunity)
   end
 end