cineworld_uk 3.1.0 → 4.1.0

data/test/lib/cineworld_uk/internal/parser/api/film_test.rb

@@ -13,12 +13,12 @@ describe CineworldUk::Internal::Parser::Api::Film do
   describe '#id' do
     subject { described_class.new(data).id }
 
-    it 'is an integer' do
-      subject.must_be_instance_of(Fixnum)
+    it 'is a string' do
+      _(subject).must_be_instance_of(String)
     end
 
     it 'is the film id from the data' do
-      subject.must_equal(data['edi'])
+      _(subject).must_equal(data['id'])
     end
   end
 
@@ -26,42 +26,42 @@ describe CineworldUk::Internal::Parser::Api::Film do
     subject { described_class.new(data).dimension }
 
     it 'is a string' do
-      subject.must_be_instance_of(String)
+      _(subject).must_be_instance_of(String)
     end
 
     it 'is 2d or 3d' do
-      subject.must_match(/[23]d/)
+      _(subject).must_match(/[23]d/)
     end
 
-    describe 'hash["format"] is "2D"' do
-      let(:data) { random_film.merge('format' => '2D') }
+    describe 'attributeIds includes "2d"' do
+      let(:data) { random_film.merge('attributeIds' => ['2d']) }
 
       it 'is 2d' do
-        subject.must_equal('2d')
+        _(subject).must_equal('2d')
       end
     end
 
-    describe 'hash["format"] is "3D"' do
-      let(:data) { random_film.merge('format' => '3D') }
+    describe 'attributeIds includes "3d"' do
+      let(:data) { random_film.merge('attributeIds' => ['3d']) }
 
       it 'is 3d' do
-        subject.must_equal('3d')
+        _(subject).must_equal('3d')
       end
     end
 
-    describe 'hash["format"] is "IMAX"' do
-      let(:data) { random_film.merge('format' => 'IMAX') }
+    describe 'attributeIds with imax but not 3d' do
+      let(:data) { random_film.merge('attributeIds' => ['imax', '2d']) }
 
       it 'is 2d' do
-        subject.must_equal('2d')
+        _(subject).must_equal('2d')
       end
     end
 
-    describe 'hash["format"] is "IMAX3D"' do
-      let(:data) { random_film.merge('format' => 'IMAX3D') }
+    describe 'attributeIds with imax and 3d' do
+      let(:data) { random_film.merge('attributeIds' => ['imax', '3d']) }
 
       it 'is 3d' do
-        subject.must_equal('3d')
+        _(subject).must_equal('3d')
       end
     end
   end
@@ -70,25 +70,24 @@ describe CineworldUk::Internal::Parser::Api::Film do
     subject { described_class.new(data).name }
 
     it 'is a string' do
-      subject.must_be_instance_of(String)
+      _(subject).must_be_instance_of(String)
     end
 
-    describe 'hash["originalTitle"] is different' do
+    describe 'film name' do
       let(:data) do
-        random_film.merge('originalTitle' => 'Original Title',
-                          'title' => 'Title')
+        random_film.merge('name' => 'Test Film Name')
       end
 
-      it 'is the original title' do
-        subject.must_equal('Original Title')
+      it 'is the film name' do
+        _(subject).must_equal('Test Film Name')
       end
     end
 
-    describe 'original title is unsanitized' do
-      let(:data) { random_film.merge('originalTitle' => 'ROH: Something') }
+    describe 'film name is unsanitized' do
+      let(:data) { random_film.merge('name' => 'ROH: Something') }
 
       it 'is sanitized' do
-        subject.must_equal('Royal Opera House: Something')
+        _(subject).must_equal('Royal Opera House: Something')
       end
     end
   end
@@ -97,69 +96,58 @@ describe CineworldUk::Internal::Parser::Api::Film do
     subject { described_class.new(data).variant }
 
     it 'is a sorted array of strings' do
-      subject.must_be_instance_of(Array)
-      subject.each { |element| element.must_be_instance_of(String) }
-      subject.sort.must_equal(subject)
+      _(subject).must_be_instance_of(Array)
+      subject.each { |element| _(element).must_be_instance_of(String) }
+      _(subject.sort).must_equal(subject)
     end
 
-    describe 'hash["title"] includes "Movies For Juniors"' do
+    describe 'attributeIds includes "junior"' do
       let(:data) do
-        random_film.merge('title' => 'Movies For Juniors - Something')
+        random_film.merge('attributeIds' => ['junior'])
       end
 
       it 'includes "kids"' do
-        subject.must_include('kids')
-      end
-    end
-
-    describe 'hash["format"] is "IMAX3D"' do
-      let(:data) do
-        random_film.merge('title' => 'nothing', 'format' => 'IMAX3D')
-      end
-
-      it 'includes "imax"' do
-        subject.must_include('imax')
+        _(subject).must_include('kids')
       end
     end
 
-    describe 'hash["format"] is "IMAX"' do
+    describe 'attributeIds includes "imax"' do
       let(:data) do
-        random_film.merge('format' => 'IMAX')
+        random_film.merge('attributeIds' => ['imax', '3d'])
       end
 
       it 'includes "imax"' do
-        subject.must_include('imax')
+        _(subject).must_include('imax')
       end
     end
 
-    describe 'hash["title"] includes "Unlimited Screening"' do
+    describe 'attributeIds includes "unlimited-screening"' do
       let(:data) do
-        random_film.merge('title' => 'Something Unlimited Screening')
+        random_film.merge('attributeIds' => ['unlimited-screening'])
       end
 
       it 'includes "members"' do
-        subject.must_include('members')
+        _(subject).must_include('members')
       end
     end
 
-    describe 'hash["title"] includes "with Live Q And A"' do
+    describe 'attributeIds includes "qa"' do
       let(:data) do
-        random_film.merge('title' => 'Something With Live Q And A')
+        random_film.merge('attributeIds' => ['qa'])
       end
 
       it 'includes "q&a"' do
-        subject.must_include('q&a')
+        _(subject).must_include('q&a')
       end
     end
 
     describe 'combination' do
       let(:data) do
-        random_film.merge('format' => 'IMAX',
-                          'title' => 'Something Unlimited Screening')
+        random_film.merge('attributeIds' => ['imax', 'unlimited-screening'])
       end
 
       it 'includes "members"' do
-        subject.must_include('imax', 'members')
+        _(subject).must_include('imax', 'members')
       end
     end
   end
@@ -167,6 +155,6 @@ describe CineworldUk::Internal::Parser::Api::Film do
   private
 
   def random_film
-    JSON.parse(film_list_json)['films'].sample
+    JSON.parse(performances_tomorrow_json(14))['body']['films'].sample
   end
 end

data/test/lib/cineworld_uk/internal/parser/api/performance_test.rb

@@ -14,16 +14,15 @@ describe CineworldUk::Internal::Parser::Api::Performance do
     subject { described_class.new(data).booking_url }
 
     it 'should be a url on the cineworld website' do
-      subject.must_match(%r{cineworld.co.uk/booking/\d+/\d+})
+      _(subject).must_match(%r{cineworld.co.uk})
     end
   end
 
   describe '#film_id' do
     subject { described_class.new(data).film_id }
 
-    it 'should be a six digit integer' do
-      subject.must_be_instance_of(Fixnum)
-      subject.must_be :>, 10_000
+    it 'should be a string' do
+      _(subject).must_be_instance_of(String)
     end
   end
 
@@ -31,26 +30,26 @@ describe CineworldUk::Internal::Parser::Api::Performance do
     subject { described_class.new(data).starting_at }
 
     it 'should be a time' do
-      subject.must_be_instance_of(Time)
+      _(subject).must_be_instance_of(Time)
     end
   end
 
   describe '#variant' do
     subject { described_class.new(data).variant }
 
-    describe 'has "ad" => true' do
-      let(:data) { random_performance.merge('ad' => true) }
+    describe 'has "audio-described" in attributeIds' do
+      let(:data) { random_performance.merge('attributeIds' => ['audio-described']) }
 
       it 'includes "audio_described"' do
-        subject.must_include('audio_described')
+        _(subject).must_include('audio_described')
       end
     end
 
-    describe 'has "ss" => true' do
-      let(:data) { random_performance.merge('subtitled' => true) }
+    describe 'has "subbed" in attributeIds' do
+      let(:data) { random_performance.merge('attributeIds' => ['subbed']) }
 
       it 'includes "subtitled"' do
-        subject.must_include('subtitled')
+        _(subject).must_include('subtitled')
       end
     end
   end
@@ -58,6 +57,6 @@ describe CineworldUk::Internal::Parser::Api::Performance do
   private
 
   def random_performance
-    JSON.parse(performances_tomorrow_json(3))['performances'].sample
+    JSON.parse(performances_tomorrow_json(14))['body']['events'].sample
   end
 end

data/test/lib/cineworld_uk/internal/title_sanitizer_test.rb

@@ -10,7 +10,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'Iron Man 3 2D' }
 
       it 'removes dimension' do
-        subject.must_equal('Iron Man 3')
+        _(subject).must_equal('Iron Man 3')
       end
     end
 
@@ -18,7 +18,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'Iron Man 3 3d' }
 
       it 'removes dimension' do
-        subject.must_equal('Iron Man 3')
+        _(subject).must_equal('Iron Man 3')
       end
     end
 
@@ -26,7 +26,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'Bang Bang! (Hindi)' }
 
       it 'removes language' do
-        subject.must_equal('Bang Bang!')
+        _(subject).must_equal('Bang Bang!')
       end
     end
 
@@ -34,7 +34,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'Nightcrawler - Unlimited Screening' }
 
       it 'removes prefix' do
-        subject.must_equal('Nightcrawler')
+        _(subject).must_equal('Nightcrawler')
       end
     end
 
@@ -42,7 +42,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'Autism Friendly Screening: Dolphin Tale 2' }
 
       it 'removes prefix' do
-        subject.must_equal('Dolphin Tale 2')
+        _(subject).must_equal('Dolphin Tale 2')
       end
     end
 
@@ -50,7 +50,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'Bolshoi Ballet: The Legend of Love' }
 
       it 'removes prefix' do
-        subject.must_equal('Bolshoi Ballet: The Legend of Love')
+        _(subject).must_equal('Bolshoi Ballet: The Legend of Love')
       end
     end
 
@@ -58,7 +58,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'ENO: La Traviata ' }
 
       it 'removes prefix' do
-        subject.must_equal('English National Opera: La Traviata')
+        _(subject).must_equal('English National Opera: La Traviata')
       end
     end
 
@@ -66,7 +66,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { '(IMAX) Fury' }
 
       it 'removes prefix' do
-        subject.must_equal('Fury')
+        _(subject).must_equal('Fury')
       end
     end
 
@@ -74,7 +74,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'MET Opera - Le Nozze Di Figaro' }
 
       it 'removes prefix' do
-        subject.must_equal('Met Opera: Le Nozze Di Figaro')
+        _(subject).must_equal('Met Opera: Le Nozze Di Figaro')
       end
     end
 
@@ -82,7 +82,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'NT Live Encore: Frankenstein (starring Benedict Cumberbatch)' }
 
       it 'removes prefix' do
-        subject.must_equal('National Theatre: Frankenstein (starring Benedict Cumberbatch)')
+        _(subject).must_equal('National Theatre: Frankenstein (starring Benedict Cumberbatch)')
       end
     end
 
@@ -90,7 +90,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'NT Live: Treasure Island' }
 
       it 'removes prefix' do
-        subject.must_equal('National Theatre: Treasure Island')
+        _(subject).must_equal('National Theatre: Treasure Island')
       end
     end
 
@@ -98,7 +98,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'NT Live: A Streetcar Named Desire (Young Vic) - Encore' }
 
       it 'removes prefix' do
-        subject.must_equal('National Theatre: A Streetcar Named Desire (Young Vic)')
+        _(subject).must_equal('National Theatre: A Streetcar Named Desire (Young Vic)')
       end
     end
 
@@ -106,7 +106,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'ROH - I Due Foscari' }
 
       it 'removes prefix' do
-        subject.must_equal('Royal Opera House: I Due Foscari')
+        _(subject).must_equal('Royal Opera House: I Due Foscari')
       end
     end
 
@@ -114,7 +114,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { "RSC Live: Love's Labour's Lost" }
 
       it 'removes prefix' do
-        subject.must_equal("Royal Shakespeare Company: Love's Labour's Lost")
+        _(subject).must_equal("Royal Shakespeare Company: Love's Labour's Lost")
       end
     end
 
@@ -122,7 +122,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'SciScreen: Dallas Buyers Club' }
 
       it 'removes prefix' do
-        subject.must_equal('Dallas Buyers Club')
+        _(subject).must_equal('Dallas Buyers Club')
       end
     end
 
@@ -130,7 +130,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'Billy Elliot The Musical Live - Special Performance' }
 
       it 'removes prefix' do
-        subject.must_equal('Billy Elliot The Musical Live')
+        _(subject).must_equal('Billy Elliot The Musical Live')
       end
     end
 
@@ -138,7 +138,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'Take 2 - Boyhood' }
 
       it 'removes prefix' do
-        subject.must_equal('Boyhood')
+        _(subject).must_equal('Boyhood')
       end
     end
 
@@ -146,7 +146,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       let(:title) { 'Frozen Sing-Along - Movies For Juniors' }
 
       it 'removes prefix' do
-        subject.must_equal('Frozen')
+        _(subject).must_equal('Frozen')
       end
     end
   end

data/test/lib/cineworld_uk/performance_test.rb

@@ -11,52 +11,51 @@ describe CineworldUk::Performance do
   after { WebMock.allow_net_connect! }
 
   describe '.at(cinema_id)' do
-    subject { described_class.at(cinema_id) }
+    subject do
+      described_class.at(cinema_id, from: Date.today + 1, to: Date.today + 1)
+    end
 
     before do
       api_response.expect(:cinema_list, cinema_list_json)
-      api_response.expect(:film_list, film_list_json)
-      api_response.expect(:film_list_comingsoon, film_list_comingsoon_json)
-      api_response.expect(:dates, fake_dates_tomorrow_json, [3])
-      api_response.expect(:performances,
-                          performances_tomorrow_json(3),
-                          [3, Date.today + 1])
+      4.times { api_response.expect(:performances,
+                          performances_tomorrow_json(14),
+                          [14, Date.today + 1]) }
     end
 
     describe 'called with integer' do
-      let(:cinema_id) { 3 }
+      let(:cinema_id) { 14 }
 
       it 'returns an array of performances' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_be_instance_of(Array)
+          _(subject).must_be_instance_of(Array)
           subject.each do |performance|
-            performance.must_be_instance_of(described_class)
+            _(performance).must_be_instance_of(described_class)
           end
         end
       end
 
       it 'returns at least a sensible number' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.count.must_be :>, 5
+          _(subject.count).must_be :>, 5
         end
       end
     end
 
     describe 'called with string' do
-      let(:cinema_id) { '3' }
+      let(:cinema_id) { '14' }
 
       it 'returns an array of performances' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_be_instance_of(Array)
+          _(subject).must_be_instance_of(Array)
           subject.each do |performance|
-            performance.must_be_instance_of(described_class)
+            _(performance).must_be_instance_of(described_class)
           end
         end
       end
 
       it 'returns at least a sensible number' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.count.must_be :>, 5
+          _(subject.count).must_be :>, 5
         end
       end
     end
@@ -76,14 +75,14 @@ describe CineworldUk::Performance do
       end
 
       it 'sets cinema name and film name' do
-        subject.film_name.must_equal 'Iron Man 3'
-        subject.cinema_name.must_equal 'Cineworld Brighton'
+        _(subject.film_name).must_equal 'Iron Man 3'
+        _(subject.cinema_name).must_equal 'Cineworld Brighton'
       end
 
       it 'booking url, dimension & varient are set to defaults' do
-        subject.booking_url.must_equal nil
-        subject.dimension.must_equal '2d'
-        subject.variant.must_equal []
+        _(subject.booking_url).must_be_nil
+        _(subject.dimension).must_equal '2d'
+        _(subject.variant).must_equal []
       end
     end
   end
@@ -102,8 +101,8 @@ describe CineworldUk::Performance do
     subject { described_class.new(options).dimension }
 
     it 'returns 2d or 3d' do
-      subject.must_be_instance_of(String)
-      subject.must_equal '3d'
+      _(subject).must_be_instance_of(String)
+      _(subject).must_equal '3d'
     end
   end
 
@@ -121,8 +120,8 @@ describe CineworldUk::Performance do
       end
 
       it 'returns UTC time' do
-        subject.must_be_instance_of Time
-        subject.must_equal Time.utc(2013, 9, 12, 11, 0)
+        _(subject).must_be_instance_of Time
+        _(subject).must_equal Time.utc(2013, 9, 12, 11, 0)
       end
     end
 
@@ -137,9 +136,9 @@ describe CineworldUk::Performance do
       end
 
       it 'returns UTC time' do
-        subject.must_be_instance_of Time
-        subject.must_equal Time.utc(2013, 9, 12, 10, 0)
-        subject.utc?.must_equal(true)
+        _(subject).must_be_instance_of Time
+        _(subject).must_equal Time.utc(2013, 9, 12, 10, 0)
+        _(subject.utc?).must_equal(true)
       end
     end
   end
@@ -157,8 +156,8 @@ describe CineworldUk::Performance do
     subject { described_class.new(options).showing_on }
 
     it 'returns date of showing' do
-      subject.must_be_instance_of(Date)
-      subject.must_equal Date.new(2013, 9, 12)
+      _(subject).must_be_instance_of(Date)
+      _(subject).must_equal Date.new(2013, 9, 12)
     end
   end
 
@@ -176,9 +175,9 @@ describe CineworldUk::Performance do
     end
 
     it 'is an alphabetically ordered array of lower-cased strings' do
-      subject.must_be_instance_of Array
-      subject.each { |element| element.must_be_instance_of String }
-      subject.must_equal %w(kids)
+      _(subject).must_be_instance_of Array
+      subject.each { |element| _(element).must_be_instance_of String }
+      _(subject).must_equal %w(kids)
     end
   end
 end

data/test/lib/cineworld_uk/version_test.rb

@@ -2,6 +2,6 @@ require_relative '../../test_helper'
 
 describe CineworldUk do
   it 'must be defined' do
-    CineworldUk::VERSION.wont_be_nil
+    _(CineworldUk::VERSION).wont_be_nil
   end
 end

data/test/live/integration_test.rb

@@ -6,6 +6,7 @@ Minitest::Reporters.use! [
 ]
 
 require File.expand_path('../../../lib/cineworld_uk.rb', __FILE__)
+CineworldUk.token = ENV.fetch("CINEWORLD_TOKEN")
 
 describe CineworldUk::Cinema do
   let(:described_class) { CineworldUk::Cinema }
@@ -14,19 +15,18 @@ describe CineworldUk::Cinema do
     subject { described_class.all }
 
     it 'returns an Array of CineworldUK::Cinemas' do
-      subject.must_be_instance_of(Array)
+      _(subject).must_be_instance_of(Array)
       subject.each do |value|
-        value.must_be_instance_of(CineworldUk::Cinema)
+        _(value).must_be_instance_of(CineworldUk::Cinema)
       end
     end
 
     it 'returns the correctly sized array' do
-      subject.size.must_be :>, 18
+      _(subject.size).must_be :>, 18
     end
 
     it 'returns the right cinemas' do
-      subject.first.name.must_equal 'Aberdeen: Queens Links'
-      subject.last.name.must_equal 'Yeovil'
+      _(subject.detect { |cinema| cinema.id == 14 }.name).must_equal "Brighton"
     end
   end
 end
@@ -35,17 +35,17 @@ describe CineworldUk::Performance do
   let(:described_class) { CineworldUk::Performance }
 
   describe '.at(cinema_id)' do
-    subject { described_class.at(3) }
+    subject { described_class.at(14, from: Date.today + 1, to: Date.today + 1) }
 
     it 'returns an array of screenings' do
-      subject.must_be_instance_of(Array)
+      _(subject).must_be_instance_of(Array)
       subject.each do |performance|
-        performance.must_be_instance_of(CineworldUk::Performance)
+        _(performance).must_be_instance_of(CineworldUk::Performance)
       end
     end
 
     it 'returns correct number of screenings' do
-      subject.count.must_be :>, 10
+      _(subject.count).must_be :>, 10
     end
   end
 end

data/test/package_test.rb

@@ -0,0 +1,49 @@
+# Run separately after building: CINEWORLD_PACKAGE=pkg/...gem bundle exec ruby test/package_test.rb
+require "minitest/autorun"
+require "rubygems/installer"
+require "tmpdir"
+require "fileutils"
+require "open3"
+require "base64"
+require "json"
+
+describe "Platform package" do
+  before do
+    @directory = Dir.mktmpdir("cineworld-package-test")
+    @spec = Gem::Installer.at(
+      ENV.fetch("CINEWORLD_PACKAGE"), install_dir: @directory, ignore_dependencies: true
+    ).install
+    @vendor = File.join(@spec.full_gem_path, "vendor", "curl-impersonate")
+    @binary = File.join(@vendor, "bin", "curl-impersonate")
+  end
+
+  after do
+    FileUtils.remove_entry(@directory)
+  end
+
+  it "installs a runnable executable with upstream notices and provenance" do
+    assert File.executable?(@binary)
+    output, status = Open3.capture2(@binary, "--version")
+    assert status.success?
+    assert_includes output, "curl"
+    assert File.file?(File.join(@vendor, "licenses", "LICENSE_CURL"))
+    assert_includes File.read(File.join(@vendor, "SOURCE")), "2.2.3"
+  end
+
+  it "acquires a token using the gem-local executable without any curl on PATH" do
+    payload = Base64.urlsafe_encode64(JSON.generate("exp" => Time.now.to_i + 3600), padding: false)
+    token = "header.#{payload}.signature"
+    data = { "props" => { "pageProps" => { "environment" => { "gasToken" => token } } } }
+    page = "<script id='__NEXT_DATA__'>#{JSON.generate(data)}</script>\n200"
+    # Substitute only the network response, not the installed package's path resolution.
+    File.write(@binary, "#!#{RbConfig.ruby}\nSTDOUT.write(#{page.dump})\n")
+    output, error, status = Open3.capture3(
+      { "PATH" => @directory, "RUBYOPT" => nil, "BUNDLER_SETUP" => nil,
+        "GEM_PATH" => Gem.path.join(File::PATH_SEPARATOR) }, RbConfig.ruby,
+      "-I#{File.join(@spec.full_gem_path, 'lib')}", "-rcineworld_uk",
+      "-e", "print CineworldUk.acquire_token!"
+    )
+    assert status.success?, error
+    _(output).must_equal token
+  end
+end