cineworld_uk 3.1.0 → 4.1.0

data/test/lib/cineworld_uk/cinema_test.rb

@@ -17,16 +17,16 @@ describe CineworldUk::Cinema do
 
     it 'returns an Array of CineworldUK::Cinemas' do
       CineworldUk::Internal::ApiResponse.stub :new, api_response do
-        subject.must_be_instance_of(Array)
+        _(subject).must_be_instance_of(Array)
         subject.each do |value|
-          value.must_be_instance_of(CineworldUk::Cinema)
+          _(value).must_be_instance_of(CineworldUk::Cinema)
         end
       end
     end
 
     it 'returns the correctly sized array' do
       CineworldUk::Internal::ApiResponse.stub :new, api_response do
-        subject.size.must_equal(96)
+        _(subject.size).must_equal(87)
       end
     end
   end
@@ -35,15 +35,15 @@ describe CineworldUk::Cinema do
     subject { described_class.new(id).adr }
 
     before do
-      api_response.expect(:cinema_detail, cinema_detail_json(id), [id])
+      api_response.expect(:cinema_list, cinema_list_json)
     end
 
-    describe 'Brighton (3)' do
-      let(:id) { 3 }
+    describe 'Brighton (14)' do
+      let(:id) { 14 }
 
       it 'returns the address hash' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal(
+          _(subject).must_equal(
             street_address: 'Brighton Marina Village',
             extended_address: nil,
             locality: 'Brighton',
@@ -60,15 +60,15 @@ describe CineworldUk::Cinema do
     subject { described_class.new(id).address }
 
     before do
-      api_response.expect(:cinema_detail, cinema_detail_json(id), [id])
+      api_response.expect(:cinema_list, cinema_list_json)
     end
 
-    describe 'Brighton (3)' do
-      let(:id) { 3 }
+    describe 'Brighton (14)' do
+      let(:id) { 14 }
 
       it 'returns the address hash' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal(
+          _(subject).must_equal(
             street_address: 'Brighton Marina Village',
             extended_address: nil,
             locality: 'Brighton',
@@ -85,15 +85,15 @@ describe CineworldUk::Cinema do
     subject { described_class.new(id).extended_address }
 
     before do
-      api_response.expect(:cinema_detail, cinema_detail_json(id), [id])
+      api_response.expect(:cinema_list, cinema_list_json)
     end
 
-    describe 'Brighton (3)' do
-      let(:id) { 3 }
+    describe 'Brighton (14)' do
+      let(:id) { 14 }
 
       it 'returns the address hash' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal('')
+          _(subject).must_equal('')
         end
       end
     end
@@ -105,31 +105,31 @@ describe CineworldUk::Cinema do
     before { api_response.expect(:cinema_list, cinema_list_json) }
 
     describe 'simple name (Brighton)' do
-      let(:id) { 3 }
+      let(:id) { 14 }
 
       it 'returns the brand in the name' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal 'Cineworld Brighton'
+          _(subject).must_equal 'Cineworld Brighton'
         end
       end
     end
 
     describe 'simple name (Brighton) called with String' do
-      let(:id) { '3' }
+      let(:id) { '14' }
 
       it 'returns the brand in the name' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal 'Cineworld Brighton'
+          _(subject).must_equal 'Cineworld Brighton'
         end
       end
     end
 
-    describe 'complex name (Glasgow IMAX)' do
+    describe 'complex name (Glasgow Silverburn)' do
       let(:id) { 88 }
 
       it 'returns the brand in the name' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal 'Cineworld Glasgow: IMAX at GSC'
+          _(subject).must_equal 'Cineworld Glasgow: Silverburn'
         end
       end
     end
@@ -139,25 +139,25 @@ describe CineworldUk::Cinema do
     subject { described_class.new(id).locality }
 
     before do
-      api_response.expect(:cinema_detail, cinema_detail_json(id), [id])
+      api_response.expect(:cinema_list, cinema_list_json)
     end
 
-    describe 'Brighton (3)' do
-      let(:id) { 3 }
+    describe 'Brighton (14)' do
+      let(:id) { 14 }
 
       it 'returns the town/city' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal 'Brighton'
+          _(subject).must_equal 'Brighton'
         end
       end
     end
 
-    describe 'London - 10 (Chelsea)' do
-      let(:id) { 10 }
+    describe 'London - Leicester Square (103)' do
+      let(:id) { 103 }
 
       it 'returns borough of London' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal 'Chelsea'
+          _(subject).must_equal 'London'
         end
       end
     end
@@ -167,15 +167,15 @@ describe CineworldUk::Cinema do
     subject { described_class.new(id).postal_code }
 
     before do
-      api_response.expect(:cinema_detail, cinema_detail_json(id), [id])
+      api_response.expect(:cinema_list, cinema_list_json)
     end
 
-    describe 'Brighton (3)' do
-      let(:id) { 3 }
+    describe 'Brighton (14)' do
+      let(:id) { 14 }
 
       it 'returns the post code' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal 'BN2 5UF'
+          _(subject).must_equal 'BN2 5UF'
         end
       end
     end
@@ -185,25 +185,25 @@ describe CineworldUk::Cinema do
     subject { described_class.new(id).region }
 
     before do
-      api_response.expect(:cinema_detail, cinema_detail_json(id), [id])
+      api_response.expect(:cinema_list, cinema_list_json)
     end
 
-    describe 'no region - Brighton (3)' do
-      let(:id) { 3 }
+    describe 'no region - Brighton (14)' do
+      let(:id) { 14 }
 
       it 'returns the empty string is none exists' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal ''
+          _(subject).must_equal ''
         end
       end
     end
 
-    describe 'London - Chelsea (10)' do
-      let(:id) { 10 }
+    describe 'London - Leicester Square (103)' do
+      let(:id) { 103 }
 
       it 'returns "London"' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal 'London'
+          _(subject).must_equal 'London'
         end
       end
     end
@@ -213,15 +213,15 @@ describe CineworldUk::Cinema do
     subject { described_class.new(id).street_address }
 
     before do
-      api_response.expect(:cinema_detail, cinema_detail_json(id), [id])
+      api_response.expect(:cinema_list, cinema_list_json)
     end
 
-    describe 'Brighton (3)' do
-      let(:id) { 3 }
+    describe 'Brighton (14)' do
+      let(:id) { 14 }
 
       it 'returns the first line of the Address' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal 'Brighton Marina Village'
+          _(subject).must_equal 'Brighton Marina Village'
         end
       end
     end
@@ -231,15 +231,15 @@ describe CineworldUk::Cinema do
     subject { described_class.new(id).url }
 
     before do
-      api_response.expect(:cinema_detail, cinema_detail_json(id), [id])
+      api_response.expect(:cinema_list, cinema_list_json)
     end
 
-    describe 'Brighton (3)' do
-      let(:id) { 3 }
+    describe 'Brighton (14)' do
+      let(:id) { 14 }
 
       it 'returns the url' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal(
+          _(subject).must_equal(
             "http://www.cineworld.co.uk/cinemas/#{id}/information"
           )
         end

data/test/lib/cineworld_uk/internal/api_response_test.rb

@@ -1,88 +1,207 @@
-require_relative '../../../test_helper'
-require_relative '../../../support/fixture_reader'
-
-describe CineworldUk::Internal::ApiResponse do
-  include Support::FixtureReader
+# frozen_string_literal: true
+
+require_relative "../../../test_helper"
+require "tmpdir"
+
+# This block groups independent Minitest cases, not application logic.
+describe "Vista retrieval" do # rubocop:disable Metrics/BlockLength
+  before do
+    CineworldUk.token = "test-guest-token"
+    [CineworldUk::Cinema, CineworldUk::Performance].each do |klass|
+      klass.instance_variables.each do |name|
+        klass.remove_instance_variable(name)
+      end
+    end
+    fixture = "../../../fixtures/api/vista-showtimes-brighton.json"
+    @capture = JSON.parse(File.read(File.expand_path(fixture, __dir__)))
+    @base = "https://digital-api.cineworld.co.uk/ocapi/v1/"
+    sites = @capture.fetch("relatedData").fetch("sites")
+    stub_request(:get, @base + "sites").with(
+      headers: {
+        "Authorization" => "Bearer test-guest-token",
+        "Connect-Region-Code" => "GB"
+      }
+    ).to_return(body: JSON.generate("sites" => sites))
+  end
 
-  let(:described_class) { CineworldUk::Internal::ApiResponse }
-  let(:standard) { 'key=ios&territory=GB' }
+  after do
+    CineworldUk.token = nil
+    [CineworldUk::Cinema, CineworldUk::Performance].each do |klass|
+      klass.instance_variables.each do |name|
+        klass.remove_instance_variable(name)
+      end
+    end
+  end
 
-  before { WebMock.disable_net_connect! }
-  after { WebMock.allow_net_connect! }
+  def stub_day(day, body)
+    stub_request(:get, @base + "showtimes/by-business-date/#{day}").with(
+      query: { "siteIds" => "014" },
+      headers: { "Authorization" => "Bearer test-guest-token",
+                 "Connect-Region-Code" => "GB" }
+    ).to_return(body: JSON.generate(body))
+  end
 
-  describe '#cinema_list' do
-    subject { described_class.new.cinema_list }
+  it "retrieves cinemas and advertised session times from Vista" do
+    stub_day("2026-10-14", @capture)
+    cinema = CineworldUk::Cinema.all.first
+    _(cinema.id).must_equal 14
+    _(cinema.name).must_equal "Brighton"
+    _(cinema.postal_code).must_equal "BN2 5UF"
+    _(cinema.street_address).must_equal "Brighton Marina Village"
+    assert_requested :get, @base + "sites", times: 1
+    performances = CineworldUk::Performance.at(
+      14, from: Date.new(2026, 10, 14), to: Date.new(2026, 10, 14)
+    )
+    _(performances.size).must_equal 17
+    first = performances.first
+    _(first.film_name).must_equal "Other Mommy"
+    _(first.starting_at).must_equal Time.utc(2026, 10, 14, 14, 40)
+    _(first.booking_url).must_equal(
+      "https://web.cineworld.co.uk/order/showtimes/014-165507/seats"
+    )
+    _(first.variant).must_include "audio_described"
+    _(first.dimension).must_equal "2d"
+    assert_requested :get, @base + "sites", times: 1
+    assert_requested :get, @base + "showtimes/by-business-date/2026-10-14",
+                     query: { "siteIds" => "014" }, times: 1
+  end
 
-    before { stub_get("cinema/list?full=true&#{standard}", cinema_list_json) }
+  it "keeps format session-specific and includes the last requested day" do
+    @capture["showtimes"] =
+      [@capture["showtimes"].first,
+       Marshal.load(Marshal.dump(@capture["showtimes"].first))]
+    @capture["showtimes"][1]["id"] = "014-second"
+    @capture["showtimes"][1]["requires3dGlasses"] = true
+    @capture["showtimes"][1]["schedule"]["startsAt"] =
+      "2026-10-25T16:40:00+00:00"
+    stub_day("2026-10-24",
+             "showtimes" => [],
+             "relatedData" => { "films" => [], "attributes" => [],
+                                "sites" => [] })
+    stub_day("2026-10-25", @capture)
+    results = CineworldUk::Performance.at("014", from: Date.new(2026, 10, 24),
+                                                 to: Date.new(2026, 10, 25))
+    _(results.map(&:dimension)).must_equal %w[2d 3d]
+    _(results.last.starting_at).must_equal Time.utc(2026, 10, 25, 16, 40)
+    _(results.first.cinema_name).must_equal "Brighton"
+    assert_not_requested :get, @base + "sites"
+  end
 
-    it 'returns a string' do
-      subject.class.must_equal String
+  it "rejects missing and rejected tokens without exposing credentials" do
+    CineworldUk.token = nil
+    assert_raises(CineworldUk::AuthenticationError) { CineworldUk::Cinema.all }
+    CineworldUk.token = "expired-secret"
+    stub_request(:get, @base + "sites").to_return(status: 401,
+                                                  body: "expired-secret")
+    error = assert_raises(CineworldUk::AuthenticationError) do
+      CineworldUk::Cinema.all
     end
+    refute_includes error.message, "expired-secret"
+    CineworldUk.token = "replacement"
+    stub_request(:get, @base + "sites").with(
+      headers: { "Authorization" => "Bearer replacement" }
+    ).to_return(body: '{"sites":[]}')
+    _(CineworldUk::Cinema.all).must_equal []
   end
 
-  describe '#cinema_detail(cinema_id, date)' do
-    subject { described_class.new.cinema_detail(3) }
-
-    before do
-      stub_get("cinema/detail?cinema=3&#{standard}", cinema_detail_json(3))
+  it "defaults to fourteen days and rejects reversed ranges" do
+    day = Date.new(2026, 10, 14)
+    (day..day + 13).each do |date|
+      stub_day(date.iso8601,
+               "showtimes" => [],
+               "relatedData" => { "films" => [], "attributes" => [],
+                                  "sites" => [] })
     end
-
-    it 'returns a string' do
-      subject.class.must_equal String
+    _(CineworldUk::Performance.at(14, from: day)).must_equal []
+    assert_requested :get, %r{showtimes/by-business-date/}, times: 14
+    assert_raises(ArgumentError) do
+      CineworldUk::Performance.at(14, from: day, to: day - 1)
     end
+    assert_not_requested :get, @base + "sites"
   end
 
-  describe '#dates(cinema_id)' do
-    subject { described_class.new.dates(3) }
-
-    before { stub_get("dates?cinema=3&#{standard}", dates_json(3)) }
-
-    it 'returns a string' do
-      subject.class.must_equal String
+  it "does not follow redirects or hide forbidden responses" do
+    [302, 403].each do |status|
+      stub_request(:get, @base + "sites").to_return(
+        status: status, headers: { "Location" => "https://example.com/" }
+      )
+      error = assert_raises(RuntimeError) { CineworldUk::Cinema.all }
+      assert_includes error.message, status.to_s
     end
   end
+end
 
-  describe '#film_list' do
-    subject { described_class.new.film_list }
-
-    before { stub_get("film/list?full=true&#{standard}", film_list_json) }
+describe "Guest token acquisition" do
+  before do
+    @directory = Dir.mktmpdir("cineworld token ")
+    @curl = File.join(@directory, "curl-impersonate")
+    CineworldUk.token = "existing-token"
+  end
 
-    it 'returns a string' do
-      subject.class.must_equal String
-    end
+  after do
+    FileUtils.remove_entry(@directory)
+    CineworldUk.token = nil
   end
 
-  describe '#film_list_comingsoon' do
-    subject { described_class.new.film_list_comingsoon }
+  def serve_token_page(html, status: 200, exit_code: 0)
+    output = "#{html}\n#{status}"
+    File.write(@curl, "#!#{RbConfig.ruby}\nSTDOUT.write(#{output.dump})\nexit #{exit_code}\n")
+    File.chmod(0o700, @curl)
+  end
 
-    before do
-      stub_get("film/list/comingsoon?full=true&#{standard}",
-               film_list_comingsoon_json)
-    end
+  def token_page(expires)
+    payload = Base64.urlsafe_encode64(JSON.generate("exp" => expires), padding: false)
+    token = "header.#{payload}.signature"
+    data = { "props" => { "pageProps" => { "environment" => { "gasToken" => token } } } }
+    ["<script type='application/json' id='__NEXT_DATA__'>#{JSON.generate(data)}</script>", token]
+  end
 
-    it 'returns a string' do
-      subject.class.must_equal String
+  it "sets and returns the guest JWT from either a 200 or 404 page" do
+    html, token = token_page(Time.now.to_i + 3600)
+    [200, 404].each do |status|
+      serve_token_page(html, status: status)
+      _(CineworldUk.acquire_token!(curl: @curl)).must_equal token
+      _(CineworldUk.token).must_equal token
     end
   end
 
-  describe '#performances(cinema_id, date)' do
-    subject { described_class.new.performances(3, Date.today + 1) }
-
-    before do
-      stub_get("performances?cinema=3&date=#{tomorrow_s}&#{standard}",
-               performances_tomorrow_json(3))
+  it "rejects expired tokens including the expiry boundary without replacing the current token" do
+    now = Time.at(1_800_000_000)
+    Time.stub(:now, now) do
+      [-1, 0, 1].each do |offset|
+        html, token = token_page(now.to_i + offset)
+        serve_token_page(html)
+        if offset.positive?
+          _(CineworldUk.acquire_token!(curl: @curl)).must_equal token
+        else
+          assert_raises(CineworldUk::AuthenticationError) { CineworldUk.acquire_token!(curl: @curl) }
+          _(CineworldUk.token).must_equal "existing-token"
+        end
+      end
     end
+  end
 
-    it 'returns a string' do
-      subject.class.must_equal String
+  it "reports blocked, redirected, missing and malformed page data without exposing the response" do
+    html, token = token_page(Time.now.to_i + 3600)
+    invalid_payload = Base64.urlsafe_encode64("broken-secret", padding: false)
+    [[html, 403], [html, 302], ["Cloudflare block", 200],
+     ["<script id='__NEXT_DATA__'>{</script>", 200],
+     ["<script id='__NEXT_DATA__'>{}</script>", 200],
+     [html.sub(token, "broken-secret"), 200],
+     [html.sub(token, "header.#{invalid_payload}.signature"), 200]].each do |body, status|
+      serve_token_page(body, status: status)
+      error = assert_raises(CineworldUk::AuthenticationError) { CineworldUk.acquire_token!(curl: @curl) }
+      refute_includes error.full_message, token
+      refute_includes error.full_message, "broken-secret"
+      _(CineworldUk.token).must_equal "existing-token"
     end
   end
 
-  private
-
-  def stub_get(site_path, response_body)
-    url      = "https://www.cineworld.co.uk/api/#{site_path}"
-    response = { status: 200, body: response_body, headers: {} }
-    stub_request(:get, url).to_return(response)
+  it "reports a missing executable or curl failure as an authentication error" do
+    error = assert_raises(CineworldUk::AuthenticationError) { CineworldUk.acquire_token!(curl: @curl) }
+    assert_includes error.message, "Install curl-impersonate"
+    serve_token_page("", status: 0, exit_code: 28)
+    error = assert_raises(CineworldUk::AuthenticationError) { CineworldUk.acquire_token!(curl: @curl) }
+    assert_includes error.message, "curl exit 28"
   end
 end

data/test/lib/cineworld_uk/internal/parser/api/cinema_address_test.rb

@@ -14,15 +14,15 @@ describe CineworldUk::Internal::Parser::Api::CinemaAddress do
     subject { described_class.new(id).to_hash }
 
     before do
-      api_response.expect(:cinema_detail, cinema_detail_json(id), [id])
+      api_response.expect(:cinema_list, cinema_list_json)
     end
 
     describe 'passed simple (Brighton)' do
-      let(:id) { 3 }
+      let(:id) { 14 }
 
       it 'returns address hash' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal(street_address:   'Brighton Marina Village',
+          _(subject).must_equal(street_address:   'Brighton Marina Village',
                              extended_address: nil,
                              locality:         'Brighton',
                              region:           nil,
@@ -33,11 +33,11 @@ describe CineworldUk::Internal::Parser::Api::CinemaAddress do
     end
 
     describe 'passed three line (NEC)' do
-      let(:id) { 96 }
+      let(:id) { 90 }
 
       it 'returns address hash' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal(street_address:   'Resorts World',
+          _(subject).must_equal(street_address:   'Resorts World',
                              extended_address: 'Pendigo Way',
                              locality:         'Birmingham',
                              region:           nil,
@@ -48,11 +48,11 @@ describe CineworldUk::Internal::Parser::Api::CinemaAddress do
     end
 
     describe 'passed three line (Edinburgh)' do
-      let(:id) { 21 }
+      let(:id) { 37 }
 
       it 'returns address hash' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal(street_address:   'Fountain Park',
+          _(subject).must_equal(street_address:   'Fountain Park',
                              extended_address: '130/3 Dundee Street',
                              locality:         'Edinburgh',
                              region:           nil,
@@ -62,16 +62,16 @@ describe CineworldUk::Internal::Parser::Api::CinemaAddress do
       end
     end
 
-    describe 'passed three line (Chelsea)' do
-      let(:id) { 10 }
+    describe 'passed two line (Leicester Square)' do
+      let(:id) { 103 }
 
       it 'returns address hash' do
         CineworldUk::Internal::ApiResponse.stub :new, api_response do
-          subject.must_equal(street_address:   '279 Kings Road',
+          _(subject).must_equal(street_address:   '5-6 Leicester Square',
                              extended_address: nil,
-                             locality:         'Chelsea',
+                             locality:         'London',
                              region:           'London',
-                             postal_code:      'SW3 5EW',
+                             postal_code:      'WC2H 7NA',
                              country:          'United Kingdom')
         end
       end
@@ -81,8 +81,8 @@ describe CineworldUk::Internal::Parser::Api::CinemaAddress do
     #   let(:id) { 0 }
     #
     #   it 'returns hash of nils' do
-    #     subject.must_be_instance_of(Hash)
-    #     subject.must_equal(street_address:   nil,
+    #     _(subject).must_be_instance_of(Hash)
+    #     _(subject).must_equal(street_address:   nil,
     #                        extended_address: nil,
     #                        locality:         "not an address",
     #                        region:           nil,