cineworld_uk 1.0.5 → 2.0.0

data/test/lib/cineworld_uk/internal/film_with_screenings_parser_test.rb

@@ -1,127 +1,129 @@
 require_relative '../../../test_helper'
 
 describe CineworldUk::Internal::FilmWithScreeningsParser do
+  let(:described_class) { CineworldUk::Internal::FilmWithScreeningsParser }
 
-  describe '#film_name' do
-    subject { CineworldUk::Internal::FilmWithScreeningsParser.new(film_html).film_name }
+  describe '#cinema_id' do
+    subject { described_class.new(film_html).cinema_id }
 
-    describe 'passed valid film html with simple name' do
-      let(:film_html) { read_film_html('brighton/gravity') }
+    describe 'passed film html from top of page' do
+      let(:film_html) { read_film_html('brighton/film_first') }
 
-      it 'returns the film name' do
-        subject.must_equal('Gravity')
+      it 'returns the id' do
+        subject.must_equal(3)
       end
     end
-  end
-
-  describe '#showings' do
-    subject { CineworldUk::Internal::FilmWithScreeningsParser.new(film_html).showings }
 
-    describe 'passed valid film html in headline position' do
-      let(:film_html) { read_film_html('brighton/gravity') }
+    describe 'passed second html from page' do
+      let(:film_html) { read_film_html('brighton/film_second') }
 
-      it 'returns a hash keyed by type of performance' do
-        subject.must_be_instance_of Hash
-        subject.keys.each { |key| key.must_be_instance_of String }
+      it 'returns the id' do
+        subject.must_equal(3)
       end
+    end
 
-      it 'returns an array of Times for each type of performance' do
-        subject.each do |key, value|
-          value.must_be_instance_of Array
-          value.each do |array|
-            array.must_be_instance_of Array
-            array[0].must_be_instance_of Time
-            array[1].must_be_instance_of String
-          end
-        end
-      end
+    describe 'passed last html from end of page' do
+      let(:film_html) { read_film_html('brighton/film_last') }
 
-      it 'returns the correct number of Times' do
-        subject.keys.must_equal ['2D', '3D']
-        subject['2D'].count.must_equal 49
-        subject['3D'].count.must_equal 89
+      it 'returns the id' do
+        subject.must_equal(3)
       end
+    end
+  end
 
-      it 'returns Times in UTC' do
-        subject['2D'].first[0].must_equal Time.utc(2013, 11, 13, 12, 0, 0)
-        subject['2D'].last[0].must_equal Time.utc(2013, 11, 21, 20, 30, 0)
-
-        subject['3D'].first[0].must_equal Time.utc(2013, 11, 13, 12, 50, 0)
-        subject['3D'].last[0].must_equal Time.utc(2013, 11, 21, 17, 45, 0)
-      end
+  describe '#film_name' do
+    subject { described_class.new(film_html).film_name }
 
-      it 'returns booking urls' do
-        subject['2D'].first[1].must_equal 'http://www.cineworld.co.uk/booking?cinema=3&filmEdi=39755&date=20131113&time=12:00'
-        subject['2D'].last[1].must_equal 'http://www.cineworld.co.uk/booking?cinema=3&filmEdi=43483&date=20131121&time=20:30'
+    describe 'passed film html from top of page' do
+      let(:film_html) { read_film_html('brighton/film_first') }
 
-        subject['3D'].first[1].must_equal 'http://www.cineworld.co.uk/booking?cinema=3&filmEdi=39755&date=20131113&time=12:50'
-        subject['3D'].last[1].must_equal 'http://www.cineworld.co.uk/booking?cinema=3&filmEdi=43483&date=20131121&time=17:45'
+      it 'returns the film name' do
+        subject.must_be_instance_of(String)
+        subject.must_equal('Dawn of the Planet of the Apes')
       end
     end
 
-    describe 'passed valid film html in headline position with crazy screens' do
-      let(:film_html) { read_film_html('the-o2-greenwich/gravity') }
+    describe 'passed film html from page' do
+      let(:film_html) { read_film_html('brighton/film_second') }
 
-      it 'returns the correct number of Times' do
-        subject.keys.sort.must_equal ['2D', '3D', '3D D-BOX']
-        subject['2D'].count.must_equal 5
-        subject['3D'].count.must_equal 24
-        subject['3D D-BOX'].count.must_equal 19
+      it 'returns the film name' do
+        subject.must_be_instance_of(String)
+        subject.must_equal('How To Train Your Dragon 2')
       end
+    end
 
-      it 'returns Times in UTC' do
-        subject['2D'].first[0].must_equal Time.utc(2013, 11, 18, 15, 30, 0)
-        subject['2D'].last[0].must_equal Time.utc(2013, 11, 21, 18, 35, 0)
-
-        subject['3D'].first[0].must_equal Time.utc(2013, 11, 16, 22, 15, 0)
-        subject['3D'].last[0].must_equal Time.utc(2013, 11, 21, 21, 0, 0)
+    describe 'passed film html from end of page' do
+      let(:film_html) { read_film_html('brighton/film_last') }
 
-        subject['3D D-BOX'].first[0].must_equal Time.utc(2013, 11, 17, 11, 30, 0)
-        subject['3D D-BOX'].last[0].must_equal Time.utc(2013, 11, 20, 19, 0, 0)
+      it 'returns the film name' do
+        subject.must_be_instance_of(String)
+        subject.must_equal('The Royal Ballet - Manon')
       end
     end
+  end
 
-    describe 'passed valid film html in headline position with 2d imax' do
-      let(:film_html) { read_film_html('glasgow-imax-at-gsc/the-hunger-games-catching-fire') }
+  describe '#to_a' do
+    subject { described_class.new(film_html).to_a }
 
-      it 'returns the correct number of Times' do
-        subject.keys.sort.must_equal ['2D IMAX']
-        subject['2D IMAX'].count.must_equal 27
+    describe 'passed film html from top of page' do
+      let(:film_html)       { read_film_html('brighton/film_first') }
+      let(:permitted_types) { %w(baby hfr kids) }
+
+      it 'returns a non-zero array of hashes' do
+        subject.must_be_instance_of(Array)
+        subject.size.must_be :>=, 1
+        subject.each do |hash|
+          hash.must_be_instance_of(Hash)
+        end
       end
 
-      it 'returns Times in UTC' do
-        subject['2D IMAX'].first[0].must_equal Time.utc(2013, 11, 20, 00, 30, 0)
-        subject['2D IMAX'].last[0].must_equal Time.utc(2013, 11, 28, 20, 40, 0)
+      it 'contains properly completed hashes' do
+        subject.each do |hash|
+          hash[:booking_url].must_include('http://www.cineworld.co.uk')
+          hash[:dimension].must_match(/\A[23]d\z/)
+          hash[:time].must_be_instance_of(Time)
+          hash[:variant].must_be_instance_of(Array)
+          hash[:variant].each do |type|
+            type.must_be_instance_of(String)
+            permitted_types.must_include(type)
+          end
+        end
       end
     end
 
-    describe 'passed valid film html with H(obbity)FR' do
-      let(:film_html) { read_film_html('the-o2-greenwich/the-hobbit-desolation-of-smaug') }
+    describe 'passed film html from top of dbox cinema page' do
+      let(:film_html)       { read_film_html('the-o2-greenwich/film_first') }
+      let(:permitted_types) { %w(baby dbox hfr kids) }
 
-      it 'returns the correct number of Times' do
-        subject.keys.sort.must_equal ['2D', '3D D-BOX', '3D HFR']
-        subject['2D'].count.must_equal 26
-        subject['3D HFR'].count.must_equal 1
-        subject['3D D-BOX'].count.must_equal 23
+      it 'returns a hash with allowed variants' do
+        subject.each do |hash|
+          hash[:variant].each do |type|
+            type.must_be_instance_of(String)
+            permitted_types.must_include(type)
+          end
+        end
       end
+    end
 
-      it 'returns Times in UTC' do
-        subject['2D'].first[0].must_equal Time.utc(2014, 1, 2, 16, 20, 0)
-        subject['2D'].last[0].must_equal Time.utc(2014, 1, 9, 19, 20, 0)
-
-        subject['3D HFR'].first[0].must_equal Time.utc(2014, 1, 2, 19, 20, 0)
-        subject['3D HFR'].last[0].must_equal Time.utc(2014, 1, 2, 19, 20, 0)
+    describe 'passed film html from top of imax cinema page' do
+      let(:film_html)       { read_film_html('glasgow-imax-at-gsc/film_first') }
+      let(:permitted_types) { %w(baby dbox hfr imax kids) }
 
-        subject['3D D-BOX'].first[0].must_equal Time.utc(2014, 1, 2, 17, 0, 0)
-        subject['3D D-BOX'].last[0].must_equal Time.utc(2014, 1, 9, 20, 20, 0)
+      it 'returns a hash with allowed variants' do
+        subject.each do |hash|
+          hash[:variant].each do |type|
+            type.must_be_instance_of(String)
+            permitted_types.must_include(type)
+          end
+        end
       end
     end
-
   end
 
   private
 
   def read_film_html(filename)
-    File.read(File.expand_path("../../../../fixtures/whatson/#{filename}.html", __FILE__))
+    path = '../../../../fixtures/whatson/'
+    File.read(File.expand_path(path + "#{filename}.html", __FILE__))
   end
 end

data/test/lib/cineworld_uk/internal/titleize_test.rb

@@ -6,8 +6,14 @@ describe CineworldUk::Internal::Titleize do
     subject { CineworldUk::Internal::Titleize.titleize(string) }
 
     [
-      ['star wars: episode iv - a new hope', 'Star Wars: Episode IV - A New Hope'],
-      ['star wars: episode v - the empire strikes back', 'Star Wars: Episode V - The Empire Strikes Back'],
+      [
+        'star wars: episode iv - a new hope',
+        'Star Wars: Episode IV - A New Hope'
+      ],
+      [
+        'star wars: episode v - the empire strikes back',
+        'Star Wars: Episode V - The Empire Strikes Back'
+      ],
       ['2 fast 2 furious', '2 Fast 2 Furious'],
       ['saw iv', 'Saw IV'],
       ['fast & Furious 6', 'Fast & Furious 6'],
@@ -20,7 +26,6 @@ describe CineworldUk::Internal::Titleize do
           subject.must_equal test_case[1]
         end
       end
-
     end
   end
 
@@ -28,7 +33,10 @@ describe CineworldUk::Internal::Titleize do
     subject { CineworldUk::Internal::Titleize.phrases(string) }
 
     [
-      ['star wars: episode iv - a new hope',['star wars:','episode iv -','a new hope']],
+      [
+        'star wars: episode iv - a new hope',
+        ['star wars:', 'episode iv -', 'a new hope']
+      ]
     ].each do |test_case|
 
       describe test_case[0] do
@@ -38,6 +46,5 @@ describe CineworldUk::Internal::Titleize do
         end
       end
     end
-
   end
 end

data/test/lib/cineworld_uk/internal/website_test.rb

@@ -0,0 +1,57 @@
+require_relative '../../../test_helper'
+
+describe CineworldUk::Internal::Website do
+  describe '#cinemas' do
+    subject { CineworldUk::Internal::Website.new.cinemas }
+
+    before { stub_get('cinemas', cinemas_html) }
+
+    it 'returns a string' do
+      subject.class.must_equal String
+    end
+  end
+
+  describe '#cinema_information(id)' do
+    subject { CineworldUk::Internal::Website.new.cinema_information(3) }
+
+    before { stub_get('cinemas/3/information', information_html) }
+
+    it 'returns a string' do
+      subject.class.must_equal String
+    end
+  end
+
+  describe '#whatson(id)' do
+    subject { CineworldUk::Internal::Website.new.whatson(3) }
+
+    before { stub_get('whatson?cinema=3', whatson_html) }
+
+    it 'returns a string' do
+      subject.class.must_equal String
+    end
+  end
+
+  private
+
+  def read_file(filepath)
+    File.read(File.expand_path(filepath, __FILE__))
+  end
+
+  def cinemas_html
+    read_file('../../../../fixtures/cinemas.html')
+  end
+
+  def information_html
+    read_file('../../../../fixtures/information/brighton.html')
+  end
+
+  def stub_get(site_path, response_body)
+    url      = "http://www.cineworld.co.uk/#{site_path}"
+    response = { status: 200, body: response_body, headers: {} }
+    stub_request(:get, url).to_return(response)
+  end
+
+  def whatson_html
+    read_file('../../../../fixtures/whatson/brighton.html')
+  end
+end

data/test/lib/cineworld_uk/internal/whatson_parser_test.rb

@@ -0,0 +1,58 @@
+require_relative '../../../test_helper'
+
+describe CineworldUk::Internal::WhatsonParser do
+  let(:described_class) { CineworldUk::Internal::WhatsonParser }
+
+  let(:website) { Minitest::Mock.new }
+
+  before do
+    WebMock.disable_net_connect!
+  end
+
+  describe '#films_with_screenings' do
+    subject { described_class.new(3).films_with_screenings }
+
+    before do
+      website.expect(:whatson, brighton_whatson_html, [3])
+    end
+
+    it 'returns an non-zero array of film screenings html fragments' do
+      CineworldUk::Internal::Website.stub :new, website do
+        subject.must_be_instance_of(Array)
+        subject.size.must_be :>, 0
+
+        subject.each do |film_html|
+          film_html.must_be_instance_of(String)
+          film_html.size.must_be :>, 0
+        end
+      end
+    end
+
+    it 'returns an array with correct content' do
+      CineworldUk::Internal::Website.stub :new, website do
+        # include primary film
+        subject.first.must_include('class="span4"') # big poster
+        subject.first.must_include('class="span5"') # film info block
+        subject.first.must_include('<h3 class="h1">') # title
+        subject.first.must_include('class="date row"') # showing rows
+
+        subject[1..-1].each do |html|
+          html.must_include('class="span2"') # poster
+          html.must_include('class="span7"') # film info block
+          html.must_include('<h3 class="h1">') # title
+          html.must_include('class="date row"') # showing rows
+        end
+      end
+    end
+  end
+
+  private
+
+  def read_file(filepath)
+    File.read(File.expand_path(filepath, __FILE__))
+  end
+
+  def brighton_whatson_html
+    read_file('../../../../fixtures/whatson/brighton.html')
+  end
+end

data/test/lib/cineworld_uk/screening_test.rb

@@ -1,40 +1,172 @@
 require_relative '../../test_helper'
 
 describe CineworldUk::Screening do
-  describe '#new film_name, cinema_name, date, time, variant' do
-    it 'stores film_name, cinema_name & when (in UTC)' do
-      screening = CineworldUk::Screening.new 'Iron Man 3', "Duke's At Komedia", Time.parse('2013-09-12 11:00')
-      screening.film_name.must_equal 'Iron Man 3'
-      screening.cinema_name.must_equal "Duke's At Komedia"
-      screening.when.must_equal Time.utc(2013, 9, 12, 10, 0)
-      screening.booking_url.must_equal nil
-      screening.variant.must_equal nil
+  let(:website) { Minitest::Mock.new }
+
+  before do
+    WebMock.disable_net_connect!
+  end
+
+  describe '.at(cinema_id)' do
+    subject { CineworldUk::Screening.at(3) }
+
+    before do
+      website.expect(:whatson, whatson_html('brighton'), [3])
+      website.expect(:cinemas, cinemas_html)
+    end
+
+    it 'returns an array of screenings' do
+      CineworldUk::Internal::Website.stub :new, website do
+        subject.must_be_instance_of(Array)
+        subject.each do |screening|
+          screening.must_be_instance_of(CineworldUk::Screening)
+        end
+      end
+    end
+
+    it 'returns correct number of screenings' do
+      CineworldUk::Internal::Website.stub :new, website do
+        subject.count.must_equal 333
+      end
+    end
+  end
+
+  describe '.new' do
+    subject { CineworldUk::Screening.new(options) }
+
+    describe 'simple' do
+      let(:options) do
+        {
+          film_name:   'Iron Man 3',
+          cinema_id:   3,
+          cinema_name: 'Cineworld Brighton',
+          time:        Time.utc(2013, 9, 12, 11, 0)
+        }
+      end
+
+      it 'sets cinema name and film name' do
+        subject.film_name.must_equal 'Iron Man 3'
+        subject.cinema_name.must_equal 'Cineworld Brighton'
+      end
+
+      it 'booking url, dimension & varient are set to defaults' do
+        subject.booking_url.must_equal nil
+        subject.dimension.must_equal '2d'
+        subject.variant.must_equal []
+      end
+    end
+  end
+
+  describe '#dimension' do
+    let(:options) do
+      {
+        film_name:   'Iron Man 3',
+        dimension:   '3d',
+        cinema_id:   3,
+        cinema_name: 'Cineworld Brighton',
+        time:        Time.utc(2013, 9, 12, 11, 0)
+      }
+    end
+
+    subject { CineworldUk::Screening.new(options).dimension }
+
+    it 'returns 2d or 3d' do
+      subject.must_be_instance_of(String)
+      subject.must_equal '3d'
+    end
+  end
+
+  describe '#showing_at' do
+    subject { CineworldUk::Screening.new(options).showing_at }
+
+    describe 'with utc time' do
+      let(:options) do
+        {
+          film_name:   'Iron Man 3',
+          cinema_id:   3,
+          cinema_name: 'Cineworld Brighton',
+          time:        Time.utc(2013, 9, 12, 11, 0)
+        }
+      end
+
+      it 'returns UTC time' do
+        subject.must_be_instance_of Time
+        subject.must_equal Time.utc(2013, 9, 12, 11, 0)
+      end
     end
 
-    it 'stores variant if passed' do
-      screening = CineworldUk::Screening.new 'Iron Man 3', "Duke's At Komedia", Time.utc(2013, 9, 12, 11, 0), 'http://link.com', '2d'
-      screening.film_name.must_equal 'Iron Man 3'
-      screening.cinema_name.must_equal "Duke's At Komedia"
-      screening.when.must_equal Time.utc(2013, 9, 12, 11, 0)
-      screening.booking_url.must_equal 'http://link.com'
-      screening.variant.must_equal '2d'
+    describe 'with non-utc time' do
+      let(:options) do
+        {
+          film_name:   'Iron Man 3',
+          cinema_id:   3,
+          cinema_name: 'Cineworld Brighton',
+          time:        Time.parse('2013-09-12 11:00')
+        }
+      end
+
+      it 'returns UTC time' do
+        subject.must_be_instance_of Time
+        subject.must_equal Time.utc(2013, 9, 12, 10, 0)
+      end
     end
   end
 
-  describe '#date' do
-    subject { CineworldUk::Screening.new('Iron Man 3', "Duke's At Komedia", Time.utc(2013, 9, 12, 11, 0)).date }
-    it 'should return date of showing' do
+  describe '#showing_on' do
+    let(:options) do
+      {
+        film_name:   'Iron Man 3',
+        cinema_id:   3,
+        cinema_name: 'Cineworld Brighton',
+        time:        Time.utc(2013, 9, 12, 11, 0)
+      }
+    end
+
+    subject { CineworldUk::Screening.new(options).showing_on }
+
+    it 'returns date of showing' do
       subject.must_be_instance_of(Date)
       subject.must_equal Date.new(2013, 9, 12)
     end
   end
 
-  describe '#varient (DEPRECATED)' do
-    subject { screening.varient }
-    let(:screening) { CineworldUk::Screening.new 'Iron Man 3', "Duke's At Komedia", Time.utc(2013, 9, 12, 11, 0), 'http://link.com', '2d' }
+  describe '#variant' do
+    subject { CineworldUk::Screening.new(options).variant }
+
+    let(:options) do
+      {
+        film_name:   'Iron Man 3',
+        cinema_id:   3,
+        cinema_name: 'Cineworld Brighton',
+        time:        Time.utc(2013, 9, 12, 11, 0),
+        variant:     'Kids'
+      }
+    end
 
-    it 'should return variant' do
-      subject.must_equal '2d'
+    it 'is an alphabetically ordered array of lower-cased strings' do
+      subject.must_be_instance_of Array
+      subject.each do |tag|
+        tag.must_be_instance_of String
+      end
+      subject.must_equal %w(kids)
     end
   end
+
+  private
+
+  def cinemas_html
+    read_file('../../../fixtures/cinemas.html')
+  end
+
+  def information_html(filename)
+    read_file("../../../fixtures/information/#{filename}.html")
+  end
+
+  def read_file(filepath)
+    File.read(File.expand_path(filepath, __FILE__))
+  end
+
+  def whatson_html(filename)
+    read_file("../../../fixtures/whatson/#{filename}.html")
+  end
 end

data/test/lib/cineworld_uk/version_test.rb

@@ -2,7 +2,7 @@ require_relative '../../test_helper'
 
 describe CineworldUk do
 
-  it "must be defined" do
+  it 'must be defined' do
     CineworldUk::VERSION.wont_be_nil
   end
 

data/test/test_helper.rb

@@ -1,5 +1,7 @@
 require 'minitest/autorun'
-require 'minitest/pride'
+require 'minitest/reporters'
+reporter_options = { color: true, slow_count: 5 }
+Minitest::Reporters.use! [Minitest::Reporters::DefaultReporter.new(reporter_options)]
 
 require 'webmock/minitest'