cineworld_uk 1.0.5 → 2.0.0

data/test/lib/cineworld_uk/cinema_test.rb

@@ -1,60 +1,58 @@
 require_relative '../../test_helper'
 
 describe CineworldUk::Cinema do
+  let(:website) { Minitest::Mock.new }
 
-  before { WebMock.disable_net_connect! }
+  before do
+    WebMock.disable_net_connect!
+  end
 
   describe '.all' do
     subject { CineworldUk::Cinema.all }
 
     before do
-      body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas.html') )
-      stub_request(:get, 'http://www.cineworld.co.uk/cinemas').to_return( status: 200, body: body, headers: {} )
+      website.expect(:cinemas, cinemas_html)
     end
 
     it 'returns an Array of CineworldUK::Cinemas' do
-      subject.must_be_instance_of(Array)
-      subject.each do |value|
-        value.must_be_instance_of(CineworldUk::Cinema)
+      CineworldUk::Internal::Website.stub :new, website do
+        subject.must_be_instance_of(Array)
+        subject.each do |value|
+          value.must_be_instance_of(CineworldUk::Cinema)
+        end
       end
     end
 
     it 'returns the correctly sized array' do
-      subject.size.must_equal 81
+      CineworldUk::Internal::Website.stub :new, website do
+        subject.size.must_equal 82
+      end
     end
   end
 
   describe '.find(id)' do
     subject { CineworldUk::Cinema.find(id) }
 
-    before do
-      body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas.html') )
-      stub_request(:get, 'http://www.cineworld.co.uk/cinemas').to_return( status: 200, body: body, headers: {} )
-    end
-
     describe 'Brighton' do
       let(:id) { 3 }
 
+      before do
+        website.expect(:cinemas, cinemas_html)
+      end
+
       it 'returns a cinema' do
-        subject.must_be_instance_of(CineworldUk::Cinema)
+        CineworldUk::Internal::Website.stub :new, website do
+          subject.must_be_instance_of(CineworldUk::Cinema)
 
-        subject.id.must_equal 3
-        subject.brand.must_equal 'Cineworld'
-        subject.name.must_equal 'Brighton'
+          subject.id.must_equal 3
+          subject.brand.must_equal 'Cineworld'
+          subject.name.must_equal 'Brighton'
+        end
       end
     end
   end
 
-  describe '.new id, name, url' do
-    it 'stores id, name, slug and url' do
-      cinema = CineworldUk::Cinema.new '3', 'Brighton'
-      cinema.id.must_equal 3
-      cinema.brand.must_equal 'Cineworld'
-      cinema.name.must_equal 'Brighton'
-      cinema.slug.must_equal 'brighton'
-      cinema.url.must_equal 'http://www.cineworld.co.uk/cinemas/3/information'
-    end
-
+  describe '.new' do
     it 'removes "London - " name prefix' do
       cinema = CineworldUk::Cinema.new 79, 'London - The O2, Greenwich'
       cinema.id.must_equal 79
@@ -77,19 +75,20 @@ describe CineworldUk::Cinema do
       let(:cinema) { CineworldUk::Cinema.new('3', 'Brighton') }
 
       before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'brighton.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/3/information').to_return( status: 200, body: body, headers: {} )
+        website.expect(:information, information_html('brighton'), [3])
       end
 
       it 'returns the address hash' do
-        subject.must_equal({
-          street_address: 'Brighton Marina',
-          extended_address: nil,
-          locality: 'Brighton',
-          region: 'East Sussex',
-          postal_code: 'BN2 5UF',
-          country: 'United Kingdom'
-        })
+        CineworldUk::Internal::Website.stub :new, website do
+          subject.must_equal(
+            street_address: 'Brighton Marina',
+            extended_address: nil,
+            locality: 'Brighton',
+            region: 'East Sussex',
+            postal_code: 'BN2 5UF',
+            country: 'United Kingdom'
+          )
+        end
       end
     end
 
@@ -97,79 +96,20 @@ describe CineworldUk::Cinema do
       let(:cinema) { CineworldUk::Cinema.new('4', 'Bristol') }
 
       before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'bristol.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/4/information').to_return( status: 200, body: body, headers: {} )
-      end
-
-      it 'returns the address hash' do
-        subject.must_equal({
-          street_address: 'Hengrove Leisure Park',
-          extended_address: 'Hengrove Way',
-          locality: 'Bristol',
-          region: nil,
-          postal_code: 'BS14 0HR',
-          country: 'United Kingdom'
-        })
-      end
-    end
-
-    describe '(bury st edmunds)' do
-      let(:cinema) { CineworldUk::Cinema.new('6', 'Bury St. Edmunds') }
-
-      before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'bury-st-edmunds.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/6/information').to_return( status: 200, body: body, headers: {} )
-      end
-
-      it 'returns the address hash' do
-        subject.must_equal({
-          street_address: 'Parkway',
-          extended_address: nil,
-          locality: 'Bury St. Edmunds',
-          region: nil,
-          postal_code: 'IP33 3BA',
-          country: 'United Kingdom'
-        })
-      end
-    end
-
-    describe '(london chelsea)' do
-      let(:cinema) { CineworldUk::Cinema.new('10', 'London - Chelsea') }
-
-      before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'chelsea.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/10/information').to_return( status: 200, body: body, headers: {} )
-      end
-
-      it 'returns the address hash' do
-        subject.must_equal({
-          street_address: '279 Kings Road',
-          extended_address: 'Chelsea',
-          locality: 'London',
-          region: nil,
-          postal_code: 'SW3 5EW',
-          country: 'United Kingdom'
-        })
-      end
-    end
-
-    describe '(london o2)' do
-      let(:cinema) { CineworldUk::Cinema.new('79', 'The O2, Grenwich') }
-
-      before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'the-o2-grenwich.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/79/information').to_return( status: 200, body: body, headers: {} )
+        website.expect(:information, information_html('bristol'), [4])
       end
 
       it 'returns the address hash' do
-        subject.must_equal({
-          street_address: 'The O2',
-          extended_address: 'Peninsula Square',
-          locality: 'London',
-          region: nil,
-          postal_code: 'SE10 0DX',
-          country: 'United Kingdom'
-        })
+        CineworldUk::Internal::Website.stub :new, website do
+          subject.must_equal(
+            street_address: 'Hengrove Leisure Park',
+            extended_address: 'Hengrove Way',
+            locality: 'Bristol',
+            region: nil,
+            postal_code: 'BS14 0HR',
+            country: 'United Kingdom'
+          )
+        end
       end
     end
   end
@@ -181,12 +121,13 @@ describe CineworldUk::Cinema do
       let(:cinema) { CineworldUk::Cinema.new('3', 'Brighton') }
 
       before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'brighton.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/3/information').to_return( status: 200, body: body, headers: {} )
+        website.expect(:information, information_html('brighton'), [3])
       end
 
       it 'returns nil' do
-        subject.must_be_nil
+        CineworldUk::Internal::Website.stub :new, website do
+          subject.must_be_nil
+        end
       end
     end
 
@@ -194,90 +135,25 @@ describe CineworldUk::Cinema do
       let(:cinema) { CineworldUk::Cinema.new('4', 'Bristol') }
 
       before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'bristol.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/4/information').to_return( status: 200, body: body, headers: {} )
-      end
-
-      it 'returns the second line' do
-        subject.must_equal 'Hengrove Way'
-      end
-    end
-
-    describe '(bury st edmunds)' do
-      let(:cinema) { CineworldUk::Cinema.new('6', 'Bury St. Edmunds') }
-
-      before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'bury-st-edmunds.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/6/information').to_return( status: 200, body: body, headers: {} )
-      end
-
-      it 'returns the town/city' do
-        subject.must_be_nil
-      end
-    end
-
-    describe '(london chelsea)' do
-      let(:cinema) { CineworldUk::Cinema.new('10', 'London - Chelsea') }
-
-      before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'chelsea.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/10/information').to_return( status: 200, body: body, headers: {} )
+        website.expect(:information, information_html('bristol'), [4])
       end
 
       it 'returns the second line' do
-        subject.must_equal 'Chelsea'
-      end
-    end
-
-    describe '(london o2)' do
-      let(:cinema) { CineworldUk::Cinema.new('79', 'The O2, Grenwich') }
-
-      before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'the-o2-grenwich.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/79/information').to_return( status: 200, body: body, headers: {} )
-      end
-
-      it 'returns the second line' do
-        subject.must_equal 'Peninsula Square'
+        CineworldUk::Internal::Website.stub :new, website do
+          subject.must_equal 'Hengrove Way'
+        end
       end
     end
   end
 
   describe '#films' do
-    let(:cinema) { CineworldUk::Cinema.new('3', 'Brighton') }
-    subject { cinema.films }
+    subject { CineworldUk::Cinema.new('3', 'Brighton').films }
 
-    before do
-      body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'whatson', 'brighton.html') )
-      stub_request(:get, 'http://www.cineworld.co.uk/whatson?cinema=3').to_return( status: 200, body: body, headers: {} )
-    end
-
-    it 'returns an array of films' do
-      subject.must_be_instance_of(Array)
-      subject.each do |item|
-        item.must_be_instance_of(CineworldUk::Film)
-      end
-    end
-
-    it 'returns correct number of films' do
-      subject.count.must_equal 24
-    end
-
-    it 'returns uniquely named films' do
-      subject.each_with_index do |item, index|
-        subject.each_with_index do |jtem, i|
-          if index != i
-            item.name.wont_equal jtem.name
-            item.wont_equal jtem
-          end
-        end
+    it 'calls out to Screening object' do
+      CineworldUk::Film.stub :at, [:film] do
+        subject.must_equal([:film])
       end
     end
-
-    it 'returns film objects with correct names' do
-      subject.first.name.must_equal 'Gravity'
-      subject.last.name.must_equal 'Don Jon'
-    end
   end
 
   describe '#full_name' do
@@ -286,11 +162,6 @@ describe CineworldUk::Cinema do
     describe 'simple name (brighton)' do
       let(:cinema) { CineworldUk::Cinema.new('3', 'Brighton') }
 
-      before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'brighton.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/3/information').to_return( status: 200, body: body, headers: {} )
-      end
-
       it 'returns the brand in the name' do
         subject.must_equal 'Cineworld Brighton'
       end
@@ -299,11 +170,6 @@ describe CineworldUk::Cinema do
     describe 'complex name (glasgow imax)' do
       let(:cinema) { CineworldUk::Cinema.new('88', 'Glasgow - IMAX at GSC') }
 
-      before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'glasgow-imax-at-gsc.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/88/information').to_return( status: 200, body: body, headers: {} )
-      end
-
       it 'returns the brand in the name' do
         subject.must_equal 'Cineworld Glasgow: IMAX at GSC'
       end
@@ -317,12 +183,13 @@ describe CineworldUk::Cinema do
       let(:cinema) { CineworldUk::Cinema.new('3', 'Brighton') }
 
       before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'brighton.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/3/information').to_return( status: 200, body: body, headers: {} )
+        website.expect(:information, information_html('brighton'), [3])
       end
 
       it 'returns the town/city' do
-        subject.must_equal 'Brighton'
+        CineworldUk::Internal::Website.stub :new, website do
+          subject.must_equal 'Brighton'
+        end
       end
     end
 
@@ -330,51 +197,13 @@ describe CineworldUk::Cinema do
       let(:cinema) { CineworldUk::Cinema.new('4', 'Bristol') }
 
       before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'bristol.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/4/information').to_return( status: 200, body: body, headers: {} )
+        website.expect(:information, information_html('bristol'), [4])
       end
 
       it 'returns the town/city' do
-        subject.must_equal 'Bristol'
-      end
-    end
-
-    describe '(bury st edmunds)' do
-      let(:cinema) { CineworldUk::Cinema.new('6', 'Bury St. Edmunds') }
-
-      before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'bury-st-edmunds.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/6/information').to_return( status: 200, body: body, headers: {} )
-      end
-
-      it 'returns the town/city' do
-        subject.must_equal 'Bury St. Edmunds'
-      end
-    end
-
-    describe '(london chelsea)' do
-      let(:cinema) { CineworldUk::Cinema.new('10', 'London - Chelsea') }
-
-      before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'chelsea.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/10/information').to_return( status: 200, body: body, headers: {} )
-      end
-
-      it 'returns the town/city' do
-        subject.must_equal 'London'
-      end
-    end
-
-    describe '(london o2)' do
-      let(:cinema) { CineworldUk::Cinema.new('79', 'The O2, Grenwich') }
-
-      before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'the-o2-grenwich.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/79/information').to_return( status: 200, body: body, headers: {} )
-      end
-
-      it 'returns the town/city' do
-        subject.must_equal 'London'
+        CineworldUk::Internal::Website.stub :new, website do
+          subject.must_equal 'Bristol'
+        end
       end
     end
   end
@@ -386,12 +215,13 @@ describe CineworldUk::Cinema do
       let(:cinema) { CineworldUk::Cinema.new('3', 'Brighton') }
 
       before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'brighton.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/3/information').to_return( status: 200, body: body, headers: {} )
+        website.expect(:information, information_html('brighton'), [3])
       end
 
       it 'returns the post code' do
-        subject.must_equal 'BN2 5UF'
+        CineworldUk::Internal::Website.stub :new, website do
+          subject.must_equal 'BN2 5UF'
+        end
       end
     end
   end
@@ -403,12 +233,13 @@ describe CineworldUk::Cinema do
       let(:cinema) { CineworldUk::Cinema.new('3', 'Brighton') }
 
       before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'brighton.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/3/information').to_return( status: 200, body: body, headers: {} )
+        website.expect(:information, information_html('brighton'), [3])
       end
 
       it 'returns the county' do
-        subject.must_equal 'East Sussex'
+        CineworldUk::Internal::Website.stub :new, website do
+          subject.must_equal 'East Sussex'
+        end
       end
     end
 
@@ -416,72 +247,25 @@ describe CineworldUk::Cinema do
       let(:cinema) { CineworldUk::Cinema.new('4', 'Bristol') }
 
       before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'bristol.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/4/information').to_return( status: 200, body: body, headers: {} )
+        website.expect(:information, information_html('bristol'), [4])
       end
 
       it 'returns nil' do
-        subject.must_be_nil
-      end
-    end
-
-    describe '(bury st edmunds)' do
-      let(:cinema) { CineworldUk::Cinema.new('6', 'Bury St. Edmunds') }
-
-      before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'bury-st-edmunds.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/6/information').to_return( status: 200, body: body, headers: {} )
-      end
-
-      it 'returns nil' do
-        subject.must_be_nil
-      end
-    end
-
-    describe '(london o2)' do
-      let(:cinema) { CineworldUk::Cinema.new('79', 'The O2, Grenwich') }
-
-      before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'the-o2-grenwich.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/79/information').to_return( status: 200, body: body, headers: {} )
-      end
-
-      it 'returns nil' do
-        subject.must_be_nil
+        CineworldUk::Internal::Website.stub :new, website do
+          subject.must_be_nil
+        end
       end
     end
-
   end
 
   describe '#screenings' do
-    let(:cinema) { CineworldUk::Cinema.new('3', 'Brighton') }
-    subject { cinema.screenings }
-
-    before do
-      body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'whatson', 'brighton.html') )
-      stub_request(:get, 'http://www.cineworld.co.uk/whatson?cinema=3').to_return( status: 200, body: body, headers: {} )
-    end
+    subject { CineworldUk::Cinema.new('3', 'Brighton').screenings }
 
-    it 'returns an array of screenings' do
-      subject.must_be_instance_of(Array)
-      subject.each do |item|
-        item.must_be_instance_of(CineworldUk::Screening)
+    it 'calls out to Screening object' do
+      CineworldUk::Screening.stub :at, [:screening] do
+        subject.must_equal([:screening])
       end
     end
-
-    it 'returns screening objects with correct film names' do
-      subject.first.film_name.must_equal 'Gravity'
-      subject.last.film_name.must_equal 'Don Jon'
-    end
-
-    it 'returns screening objects with correct cinema name' do
-      subject.each { |screening| screening.cinema_name.must_equal 'Brighton' }
-    end
-
-    it 'returns screening objects with correct UTC times' do
-      subject.first.when.must_equal Time.utc(2013, 11, 13, 12, 0, 0)
-      subject.last.when.must_equal Time.utc(2013, 11, 21, 21, 30, 0)
-    end
   end
 
   describe '#street_address' do
@@ -491,13 +275,32 @@ describe CineworldUk::Cinema do
       let(:cinema) { CineworldUk::Cinema.new('3', 'Brighton') }
 
       before do
-        body = File.read( File.join(File.dirname(__FILE__), '..', '..', 'fixtures', 'cinemas', 'brighton.html') )
-        stub_request(:get, 'http://www.cineworld.co.uk/cinemas/3/information').to_return( status: 200, body: body, headers: {} )
+        website.expect(:information, information_html('brighton'), [3])
       end
 
       it 'returns the street address' do
-        subject.must_equal 'Brighton Marina'
+        CineworldUk::Internal::Website.stub :new, website do
+          subject.must_equal 'Brighton Marina'
+        end
       end
     end
   end
+
+  private
+
+  def read_file(filepath)
+    File.read(File.expand_path(filepath, __FILE__))
+  end
+
+  def cinemas_html
+    read_file('../../../fixtures/cinemas.html')
+  end
+
+  def information_html(filename)
+    read_file("../../../fixtures/information/#{filename}.html")
+  end
+
+  def parse(html)
+    Nokogiri::HTML(html)
+  end
 end

data/test/lib/cineworld_uk/film_test.rb

@@ -11,6 +11,43 @@ describe CineworldUk::Film do
     end
   end
 
+  describe '.at(cinema_id)' do
+    let(:website) { Minitest::Mock.new }
+
+    subject { CineworldUk::Film.at(3) }
+
+    before do
+      website.expect(:whatson, whatson_html('brighton'), [3])
+    end
+
+    it 'returns an array of films' do
+      CineworldUk::Internal::Website.stub :new, website do
+        subject.must_be_instance_of(Array)
+        subject.each do |film|
+          film.must_be_instance_of(CineworldUk::Film)
+        end
+      end
+    end
+
+    it 'returns a decent number of films' do
+      CineworldUk::Internal::Website.stub :new, website do
+        subject.count.must_be :>, 15
+      end
+    end
+
+    it 'returns uniquely named films' do
+      CineworldUk::Internal::Website.stub :new, website do
+        subject.each_with_index do |item, index|
+          subject.each_with_index do |jtem, i|
+            next if index == i
+            item.name.wont_equal jtem.name
+            item.wont_equal jtem
+          end
+        end
+      end
+    end
+  end
+
   describe 'Comparable' do
     it 'includes comparable methods' do
       film = CineworldUk::Film.new 'AAAA'
@@ -47,7 +84,7 @@ describe CineworldUk::Film do
         it 'retuns only one' do
           result = [film, otherfilm].uniq
           result.count.must_equal 1
-          result.must_equal [ CineworldUk::Film.new('AAAA') ]
+          result.must_equal [CineworldUk::Film.new('AAAA')]
         end
       end
     end
@@ -60,7 +97,7 @@ describe CineworldUk::Film do
         let(:otherfilm) { CineworldUk::Film.new 'BBBB' }
 
         it 'retuns -1' do
-          subject.must_equal -1
+          subject.must_equal(-1)
         end
       end
 
@@ -92,4 +129,14 @@ describe CineworldUk::Film do
       end
     end
   end
+
+  private
+
+  def read_file(filepath)
+    File.read(File.expand_path(filepath, __FILE__))
+  end
+
+  def whatson_html(filename)
+    read_file("../../../fixtures/whatson/#{filename}.html")
+  end
 end