chef 18.8.11 → 18.8.54

data/spec/unit/provider/windows_env_spec.rb

@@ -1,385 +0,0 @@
-#
-# Author:: Doug MacEachern (<dougm@vmware.com>)
-# Copyright:: Copyright 2010-2016, VMware, Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe "windows_env provider", :windows_only do
-
-  let(:run_context) do
-    Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new)
-  end
-
-  before do
-    @new_resource = Chef::Resource::WindowsEnv.new("FOO", run_context)
-    @new_resource.value("bar")
-    @new_resource.user("<System>")
-    @provider = @new_resource.provider_for_action(:create)
-  end
-
-  describe "when loading the current status" do
-    before do
-      # @current_resource = @new_resource.clone
-      # Chef::Resource::Env.stub(:new).and_return(@current_resource)
-      @provider.current_resource = @current_resource
-      allow(@provider).to receive(:env_value).with("FOO").and_return("bar")
-      allow(@provider).to receive(:key_exists?).and_return(true)
-    end
-
-    it "should create a current resource with the same name as the new resource" do
-      @provider.load_current_resource
-      expect(@provider.new_resource.name).to eq("FOO")
-    end
-
-    it "should create a current resource with the same user as the new resource" do
-      @provider.load_current_resource
-      expect(@provider.new_resource.user).to eq("<System>")
-    end
-
-    it "should set the key_name to the key name of the new resource" do
-      @provider.load_current_resource
-      expect(@provider.current_resource.key_name).to eq("FOO")
-    end
-
-    it "should return the current resource" do
-      expect(@provider.load_current_resource).to be_a_kind_of(Chef::Resource::WindowsEnv)
-    end
-  end
-
-  describe "action_create" do
-    before do
-      allow(@provider).to receive(:key_exists?).and_return(false)
-      allow(@provider).to receive(:create_env).and_return(true)
-      allow(@provider).to receive(:modify_env).and_return(true)
-    end
-
-    it "should call create_env if the key does not exist with user" do
-      expect(@provider).to receive(:create_env).and_return(true)
-      @provider.action_create
-    end
-
-    it "should set the new_resources updated flag when it creates the key" do
-      @provider.action_create
-      expect(@new_resource).to be_updated
-    end
-
-    it "should check to see if the values are the same if the key exists" do
-      allow(@provider).to receive(:key_exists?).and_return(true)
-      expect(@provider).to receive(:requires_modify_or_create?).and_return(false)
-      @provider.action_create
-    end
-
-    it "should call modify_env if the key exists with provided user and values are not equal" do
-      allow(@provider).to receive(:key_exists?).and_return(true)
-      allow(@provider).to receive(:requires_modify_or_create?).and_return(true)
-      expect(@provider).to receive(:modify_env).and_return(true)
-      @provider.action_create
-    end
-
-    it "should set the new_resources updated flag when it updates an existing value" do
-      allow(@provider).to receive(:key_exists?).and_return(true)
-      allow(@provider).to receive(:requires_modify_or_create?).and_return(true)
-      allow(@provider).to receive(:modify_env).and_return(true)
-      @provider.action_create
-      expect(@new_resource).to be_updated
-    end
-  end
-
-  describe "action_delete" do
-    before(:each) do
-      @provider.current_resource = @current_resource
-      allow(@provider).to receive(:key_exists?).and_return(false)
-      allow(@provider).to receive(:delete_element).and_return(false)
-      allow(@provider).to receive(:delete_env).and_return(true)
-    end
-
-    it "should not call delete_env if the key does not exist" do
-      expect(@provider).not_to receive(:delete_env)
-      @provider.action_delete
-    end
-
-    it "should not call delete_element if the key does not exist" do
-      expect(@provider).not_to receive(:delete_element)
-      @provider.action_delete
-    end
-
-    it "should call delete_env if the key exists" do
-      allow(@provider).to receive(:key_exists?).and_return(true)
-      expect(@provider).to receive(:delete_env)
-      @provider.action_delete
-    end
-
-    it "should set the new_resources updated flag to true if the key is deleted" do
-      allow(@provider).to receive(:key_exists?).and_return(true)
-      @provider.action_delete
-      expect(@new_resource).to be_updated
-    end
-  end
-
-  describe "action_modify" do
-    before(:each) do
-      @provider.current_resource = @current_resource
-      allow(@provider).to receive(:key_exists?).and_return(true)
-      allow(@provider).to receive(:modify_env).and_return(true)
-    end
-
-    it "should call modify_group if the key exists and values are not equal" do
-      expect(@provider).to receive(:requires_modify_or_create?).and_return(true)
-      expect(@provider).to receive(:modify_env).and_return(true)
-      @provider.action_modify
-    end
-
-    it "should call modify_group if the key exists and users are not equal" do
-      expect(@provider).to receive(:requires_modify_or_create?).and_return(true)
-      expect(@provider).to receive(:modify_env).and_return(true)
-      @provider.action_modify
-    end
-
-    it "should set the new resources updated flag to true if modify_env is called" do
-      allow(@provider).to receive(:requires_modify_or_create?).and_return(true)
-      allow(@provider).to receive(:modify_env).and_return(true)
-      @provider.action_modify
-      expect(@new_resource).to be_updated
-    end
-
-    it "should not call modify_env if the key exists with user but the values are equal" do
-      expect(@provider).to receive(:requires_modify_or_create?).and_return(false)
-      expect(@provider).not_to receive(:modify_env)
-      @provider.action_modify
-    end
-
-    it "should raise a Chef::Exceptions::WindowsEnv if the key doesn't exist" do
-      allow(@provider).to receive(:key_exists?).and_return(false)
-      expect { @provider.action_modify }.to raise_error(Chef::Exceptions::WindowsEnv)
-    end
-  end
-
-  describe "delete_element" do
-    before(:each) do
-      @current_resource = Chef::Resource::WindowsEnv.new("FOO")
-
-      @new_resource.delim ";"
-      @new_resource.value "C:/bar/bin"
-
-      @current_resource.user "<System>"
-      @current_resource.value "C:/foo/bin;C:/bar/bin"
-      @provider.current_resource = @current_resource
-    end
-
-    it "should return true if the element is not found" do
-      @new_resource.value("C:/baz/bin")
-      expect(@provider.delete_element).to eql(true)
-    end
-
-    it "should return false if the delim not defined" do
-      @new_resource.delim(nil)
-      expect(@provider.delete_element).to eql(false)
-    end
-
-    it "should return true if the element is deleted" do
-      @new_resource.value("C:/foo/bin")
-      expect(@provider).to receive(:create_env)
-      expect(@provider.delete_element).to eql(true)
-      expect(@new_resource).to be_updated
-    end
-
-    context "when new_resource's value contains the delimiter" do
-      it "should return false if all the elements are deleted" do
-        # This indicates that the entire key needs to be deleted
-        @new_resource.value("C:/foo/bin;C:/bar/bin")
-        expect(@provider.delete_element).to eql(false)
-        expect(@new_resource).not_to be_updated # This will be updated in action_delete
-      end
-
-      it "should return true if any, but not all, of the elements are deleted" do
-        @new_resource.value("C:/foo/bin;C:/notbaz/bin")
-        expect(@provider).to receive(:create_env)
-        expect(@provider.delete_element).to eql(true)
-        expect(@new_resource).to be_updated
-      end
-
-      it "should return true if none of the elements are deleted" do
-        @new_resource.value("C:/notfoo/bin;C:/notbaz/bin")
-        expect(@provider.delete_element).to eql(true)
-        expect(@new_resource).not_to be_updated
-      end
-    end
-  end
-
-  describe "requires_modify_or_create?" do
-    before(:each) do
-      @new_resource.value("C:/bar")
-      @current_resource = @new_resource.clone
-      @provider.current_resource = @current_resource
-    end
-
-    it "should return false if the values are equal" do
-      expect(@provider.requires_modify_or_create?).to be_falsey
-    end
-
-    it "should return true if the values not are equal" do
-      @new_resource.value("C:/elsewhere")
-      expect(@provider.requires_modify_or_create?).to be_truthy
-    end
-
-    it "should return false if the current value contains the element" do
-      @new_resource.delim(";")
-      @current_resource.value("C:/bar;C:/foo;C:/baz")
-
-      expect(@provider.requires_modify_or_create?).to be_falsey
-    end
-
-    it "should return true if the current value does not contain the element" do
-      @new_resource.delim(";")
-      @current_resource.value("C:/biz;C:/foo/bin;C:/baz")
-      expect(@provider.requires_modify_or_create?).to be_truthy
-    end
-
-    context "when new_resource's value contains the delimiter" do
-      it "should return false if all the current values are contained in specified order" do
-        @new_resource.value("C:/biz;C:/baz")
-        @new_resource.delim(";")
-        @current_resource.value("C:/biz;C:/foo/bin;C:/baz")
-        expect(@provider.requires_modify_or_create?).to be_falsey
-      end
-
-      it "should return true if any of the new values are not contained" do
-        @new_resource.value("C:/biz;C:/baz;C:/bin")
-        @new_resource.delim(";")
-        @current_resource.value("C:/biz;C:/foo/bin;C:/baz")
-        expect(@provider.requires_modify_or_create?).to be_truthy
-      end
-
-      it "should return true if values are contained in different order" do
-        @new_resource.value("C:/biz;C:/baz")
-        @new_resource.delim(";")
-        @current_resource.value("C:/baz;C:/foo/bin;C:/biz")
-        expect(@provider.requires_modify_or_create?).to be_truthy
-      end
-    end
-  end
-
-  describe "modify_env" do
-    before(:each) do
-      allow(@provider).to receive(:create_env).and_return(true)
-      @new_resource.delim ";"
-
-      @current_resource = Chef::Resource::WindowsEnv.new("FOO")
-      @current_resource.value "C:/foo/bin"
-      @provider.current_resource = @current_resource
-    end
-
-    it "should not modify the variable passed to the resource" do
-      new_value = "C:/bar/bin"
-      passed_value = new_value.dup
-      @new_resource.value(passed_value)
-      @provider.modify_env
-      expect(passed_value).to eq(new_value)
-    end
-
-    it "should only add values not already contained" do
-      @new_resource.value("C:/foo;C:/bar;C:/baz")
-      @current_resource.value("C:/bar;C:/baz;C:/foo/bar")
-      @provider.modify_env
-      expect(@new_resource.value).to eq("C:/foo;C:/bar;C:/baz;C:/foo/bar")
-    end
-
-    it "should reorder values to keep order which asked" do
-      @new_resource.value("C:/foo;C:/bar;C:/baz")
-      @current_resource.value("C:/foo/bar;C:/baz;C:/bar")
-      @provider.modify_env
-      expect(@new_resource.value).to eq("C:/foo;C:/bar;C:/baz;C:/foo/bar")
-    end
-  end
-
-  context "when environment variable is not PATH" do
-    let(:new_resource) do
-      new_resource = Chef::Resource::WindowsEnv.new("CHEF_WINDOWS_ENV_TEST", run_context)
-      new_resource.value("foo")
-      new_resource
-    end
-    let(:provider) do
-      provider = new_resource.provider_for_action(:create)
-      allow(provider).to receive(:env_obj).and_return(double("null object").as_null_object)
-      provider
-    end
-
-    describe "action_create" do
-      before do
-        ENV.delete("CHEF_WINDOWS_ENV_TEST")
-        allow(provider).to receive(:key_exists?).and_return(false)
-      end
-
-      it "should update the ruby ENV object when it creates the key" do
-        provider.action_create
-        expect(ENV["CHEF_WINDOWS_ENV_TEST"]).to eql("foo")
-      end
-    end
-
-    describe "action_modify" do
-      before do
-        ENV["CHEF_WINDOWS_ENV_TEST"] = "foo"
-      end
-
-      it "should update the ruby ENV object when it updates the value" do
-        expect(provider).to receive(:requires_modify_or_create?).and_return(true)
-        new_resource.value("foobar")
-        provider.action_modify
-        expect(ENV["CHEF_WINDOWS_ENV_TEST"]).to eql("foobar")
-      end
-
-      describe "action_delete" do
-        before do
-          ENV["CHEF_WINDOWS_ENV_TEST"] = "foo"
-        end
-
-        it "should update the ruby ENV object when it deletes the key" do
-          provider.action_delete
-          expect(ENV["CHEF_WINDOWS_ENV_TEST"]).to eql(nil)
-        end
-      end
-    end
-  end
-
-  context "when environment is PATH" do
-    describe "for PATH" do
-      let(:system_root) { "%SystemRoot%" }
-      let(:system_root_value) { "D:\\Windows" }
-      let(:new_resource) do
-        new_resource = Chef::Resource::WindowsEnv.new("PATH", run_context)
-        new_resource.value(system_root)
-        new_resource
-      end
-      let(:provider) do
-        provider = new_resource.provider_for_action(:create)
-        allow(provider).to receive(:env_obj).and_return(double("null object").as_null_object)
-        provider
-      end
-
-      before do
-        stub_const("ENV", { "PATH" => "" })
-      end
-
-      it "replaces Windows system variables" do
-        expect(provider).to receive(:requires_modify_or_create?).and_return(true)
-        expect(provider).to receive(:expand_path).with(system_root).and_return(system_root_value)
-        provider.action_modify
-        expect(ENV["PATH"]).to eql(system_root_value)
-      end
-    end
-  end
-end

data/spec/unit/provider/windows_path_spec.rb

@@ -1,60 +0,0 @@
-#
-# Author:: Nimisha Sharad (<nimisha.sharad@msystechnologies.com>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe "windows_path provider", :windows_only do
-  before(:all) do
-    @old_path = ENV["PATH"].dup
-  end
-
-  after(:all) do
-    ENV["PATH"] = @old_path
-  end
-
-  let(:run_context) { Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new) }
-  let(:new_resource) { Chef::Resource::WindowsPath.new("some_path", run_context) }
-  let(:provider) { new_resource.provider_for_action(:add) }
-
-  describe "#load_current_resource" do
-    it "returns a current_resource" do
-      expect(provider.load_current_resource).to be_kind_of(Chef::Resource::WindowsPath)
-    end
-
-    it "sets the path of current resource as the path of new resource" do
-      current_resource = provider.load_current_resource
-      expect(current_resource.path).to eq("some_path")
-    end
-  end
-
-  describe "#action_add" do
-    it "uses env resource to add 'path' environment variable" do
-      allow(provider).to receive(:expand_env_vars)
-      expect(provider).to receive(:declare_resource).with(:env, "path", hash_including)
-      provider.run_action(:add)
-    end
-  end
-
-  describe "#action_remove" do
-    it "uses env resource to remove 'path' environment variable" do
-      allow(provider).to receive(:expand_env_vars)
-      expect(provider).to receive(:declare_resource).with(:env, "path", hash_including)
-      provider.run_action(:remove)
-    end
-  end
-end