chef 18.8.11 → 18.8.54

data/spec/unit/provider/apt_preference_spec.rb

@@ -1,91 +0,0 @@
-#
-# Author:: Thom May (<thom@chef.io>)
-# Author:: Tim Smith (<tim@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-require "chef/resource/apt_preference"
-
-# FIXME: provider has been moved to a custom resource, should migrate the unit tests
-#
-describe "Chef::Provider::AptPreference" do
-  let(:node) { Chef::Node.new }
-  let(:events) { Chef::EventDispatch::Dispatcher.new }
-  let(:run_context) { Chef::RunContext.new(node, {}, events) }
-  let(:collection) { double("resource collection") }
-  let(:new_resource) { Chef::Resource::AptPreference.new("libmysqlclient16.1*", run_context) }
-  let(:pref_dir) { Dir.mktmpdir("apt_pref_d") }
-  let(:provider) { new_resource.provider_for_action(:add) }
-
-  before do
-    node.automatic["platform_family"] = "debian"
-    Chef::Resource::AptPreference.send(:remove_const, :APT_PREFERENCE_DIR)
-    Chef::Resource::AptPreference.const_set(:APT_PREFERENCE_DIR, pref_dir)
-
-    new_resource.pin = "1.0.1"
-    new_resource.pin_priority 1001
-  end
-
-  it "responds to load_current_resource" do
-    expect(provider).to respond_to(:load_current_resource)
-  end
-
-  context "#action_add" do
-    context "without a preferences.d directory" do
-      before do
-        FileUtils.rmdir pref_dir
-      end
-
-      it "creates the preferences.d directory" do
-        provider.run_action(:add)
-        expect(new_resource).to be_updated_by_last_action
-        expect(File.exist?(pref_dir)).to be true
-        expect(File.directory?(pref_dir)).to be true
-      end
-    end
-
-    context "with a preferences.d directory" do
-      before do
-        FileUtils.mkdir pref_dir unless ::File.exist?(pref_dir)
-        FileUtils.touch("#{pref_dir}/libmysqlclient16.1*.pref")
-        FileUtils.touch("#{pref_dir}/libmysqlclient16.1*")
-      end
-
-      # FileUtils.touch throws "Invalid argument @ utime_failed" in appveyer
-      it "creates a sanitized .pref file and removes the legacy cookbook files", :unix_only do
-        provider.run_action(:add)
-        expect(new_resource).to be_updated_by_last_action
-        expect(File).not_to exist("#{pref_dir}/libmysqlclient16.1*.pref")
-        expect(File).not_to exist("#{pref_dir}/libmysqlclient16.1*")
-        expect(File.read(::File.join(pref_dir, "libmysqlclient16_1wildcard.pref"))).to match(/Package: libmysqlclient16.1*.*Pin: 1.0.1.*Pin-Priority: 1001/m)
-      end
-    end
-  end
-
-  context "#action_delete" do
-    before do
-      FileUtils.mkdir pref_dir unless ::File.exist?(pref_dir)
-      FileUtils.touch("#{pref_dir}/libmysqlclient16_1wildcard.pref")
-    end
-
-    it "deletes the name sanitized .pref file" do
-      provider.run_action(:remove)
-      expect(new_resource).to be_updated_by_last_action
-      expect(File).not_to exist("#{pref_dir}/libmysqlclient16_1wildcard.pref")
-    end
-  end
-end

data/spec/unit/provider/apt_repository_spec.rb

@@ -1,370 +0,0 @@
-#
-# Author:: Thom May (<thom@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe "Chef::Provider::AptRepository" do
-  # Now we are using the option --with-colons that works across old os versions
-  # as well as the latest (16.10). This for both `apt-key` and `gpg` commands
-  #
-  # Output of the command:
-  # => apt-key adv --list-public-keys --with-fingerprint --with-colons
-  APT_KEY_FINGER = <<~EOF.freeze
-    tru:t:1:1488924856:0:3:1:5
-    pub:-:1024:17:40976EAF437D05B5:2004-09-12:::-:Ubuntu Archive Automatic Signing Key <ftpmaster@ubuntu.com>::scESC:
-    fpr:::::::::630239CC130E1A7FD81A27B140976EAF437D05B5:
-    sub:-:2048:16:251BEFF479164387:2004-09-12::::::e:
-    pub:-:1024:17:46181433FBB75451:2004-12-30:::-:Ubuntu CD Image Automatic Signing Key <cdimage@ubuntu.com>::scSC:
-    fpr:::::::::C5986B4F1257FFA86632CBA746181433FBB75451:
-    pub:-:4096:1:3B4FE6ACC0B21F32:2012-05-11:::-:Ubuntu Archive Automatic Signing Key (2012) <ftpmaster@ubuntu.com>::scSC:
-    fpr:::::::::790BC7277767219C42C86F933B4FE6ACC0B21F32:
-    pub:-:4096:1:D94AA3F0EFE21092:2012-05-11:::-:Ubuntu CD Image Automatic Signing Key (2012) <cdimage@ubuntu.com>::scSC:
-    fpr:::::::::843938DF228D22F7B3742BC0D94AA3F0EFE21092:
-  EOF
-
-  # Output of the command:
-  # => gpg --with-fingerprint --with-colons [FILE]
-  APG_GPG_FINGER = <<~EOF.freeze
-    pub:-:1024:17:327574EE02A818DD:2009-04-22:::-:Cloudera Apt Repository:
-    fpr:::::::::F36A89E33CC1BD0F71079007327574EE02A818DD:
-    sub:-:2048:16:84080586D1CA74A1:2009-04-22::::
-  EOF
-
-  # Output of the command:
-  # gpg --no-default-keyring --keyring ${keyring} --list-public-keys ${key}
-  APG_GPG_KEYS_EXPIRED = <<~EOF.freeze
-    pub   dsa1024 2009-04-22 [SC] [expired: 2018-02-22]
-          F36A89E33CC1BD0F71079007327574EE02A818DD
-    uid                      Cloudera Apt Repository
-    sub   elg2048 2009-04-22 [E] [expired: 2018-02-22]
-  EOF
-
-  # Output of the command:
-  # gpg --no-default-keyring --keyring ${keyring} --list-public-keys ${key}
-  APG_GPG_KEYS_REVOKED = <<~EOF.freeze
-    pub   dsa1024 2009-04-22 [SC] [revoked: 2018-02-22]
-          F36A89E33CC1BD0F71079007327574EE02A818DD
-    uid                      Cloudera Apt Repository
-    sub   elg2048 2009-04-22 [E] [revoked: 2018-02-22]
-  EOF
-
-  let(:node) { Chef::Node.new }
-  let(:events) { Chef::EventDispatch::Dispatcher.new }
-  let(:run_context) { Chef::RunContext.new(node, {}, events) }
-  let(:collection) { double("resource collection") }
-  let(:new_resource) { Chef::Resource::AptRepository.new("multiverse", run_context) }
-  let(:provider) { new_resource.provider_for_action(:add) }
-  let(:keyring) { "/etc/apt/keyrings/ring.gpg" }
-  let(:key) { "ASDF1234" }
-  let(:keyserver) { "keyserver.ubuntu.com" }
-
-  let(:apt_key_finger_cmd) do
-    %w{apt-key adv --list-public-keys --with-fingerprint --with-colons}
-  end
-
-  let(:apt_key_finger) do
-    double("shell_out", stdout: APT_KEY_FINGER, exitstatus: 0, error?: false)
-  end
-
-  let(:gpg_finger) do
-    double("shell_out", stdout: APG_GPG_FINGER, exitstatus: 0, error?: false)
-  end
-
-  let(:gpg_shell_out_success) do
-    double("shell_out", stdout: "pub  2048R/7BD9BF62 2011-08-19 nginx signing key <signing-key@nginx.com>",
-                        exitstatus: 0, error?: false)
-  end
-
-  let(:gpg_shell_out_failure) do
-    double("shell_out", stderr: "gpg: keybox '/etc/apt/keyrings/ring.gpg' created\ngpg: error reading key: No public key\n",
-                        stdout: "",
-                        exitstatus: 2, error?: true)
-  end
-
-  let(:gpg_shell_out_expired) do
-    double("shell_out", stdout: APG_GPG_KEYS_EXPIRED, exitstatus: 0, error?: false)
-  end
-
-  let(:gpg_shell_out_revoked) do
-    double("shell_out", stdout: APG_GPG_KEYS_REVOKED, exitstatus: 0, error?: false)
-  end
-
-  let(:apt_fingerprints) do
-    %w{630239CC130E1A7FD81A27B140976EAF437D05B5
-C5986B4F1257FFA86632CBA746181433FBB75451
-790BC7277767219C42C86F933B4FE6ACC0B21F32
-843938DF228D22F7B3742BC0D94AA3F0EFE21092}
-  end
-
-  let(:apt_public_keys) do
-    %w{
-      pub:-:1024:17:40976EAF437D05B5:2004-09-12
-      pub:-:1024:17:46181433FBB75451:2004-12-30
-      pub:-:4096:1:3B4FE6ACC0B21F32:2012-05-11
-      pub:-:4096:1:D94AA3F0EFE21092:2012-05-11
-    }
-  end
-
-  it "responds to load_current_resource" do
-    expect(provider).to respond_to(:load_current_resource)
-  end
-
-  describe "#is_key_id?" do
-    it "detects a key" do
-      expect(provider.is_key_id?("A4FF2279")).to be_truthy
-    end
-    it "detects a key with a hex signifier" do
-      expect(provider.is_key_id?("0xA4FF2279")).to be_truthy
-    end
-    it "rejects a key with the wrong length" do
-      expect(provider.is_key_id?("4FF2279")).to be_falsey
-    end
-    it "rejects a key with non-hex characters" do
-      expect(provider.is_key_id?("A4KF2279")).to be_falsey
-    end
-  end
-
-  describe "#extract_fingerprints_from_cmd" do
-    it "runs the desired command" do
-      expect(provider).to receive(:shell_out).and_return(apt_key_finger)
-      provider.extract_fingerprints_from_cmd(*apt_key_finger_cmd)
-    end
-
-    it "returns a list of key fingerprints" do
-      expect(provider).to receive(:shell_out).and_return(apt_key_finger)
-      expect(provider.extract_fingerprints_from_cmd(*apt_key_finger_cmd)).to eql(apt_fingerprints)
-    end
-  end
-
-  describe "#extract_public_keys_from_cmd" do
-    it "runs the desired command" do
-      expect(provider).to receive(:shell_out).and_return(apt_key_finger)
-      provider.extract_public_keys_from_cmd(*apt_key_finger_cmd)
-    end
-
-    it "returns a list of key fingerprints" do
-      expect(provider).to receive(:shell_out).and_return(apt_key_finger)
-      expect(provider.extract_public_keys_from_cmd(*apt_key_finger_cmd)).to eql(apt_public_keys)
-    end
-  end
-
-  describe "#cookbook_name" do
-    it "returns 'test' when the cookbook property is set" do
-      new_resource.cookbook("test")
-      expect(provider.cookbook_name).to eq("test")
-    end
-  end
-
-  describe "#keyring_key_is_valid?" do
-    it "returns true for a valid key" do
-      expect(provider).to receive(:shell_out).and_return(gpg_shell_out_success)
-      expect(provider.keyring_key_is_valid?(keyring, key)).to eql(true)
-    end
-
-    it "returns false when the key does not exist" do
-      expect(provider).to receive(:shell_out).and_return(gpg_shell_out_failure)
-      expect(provider.keyring_key_is_valid?(keyring, key)).to eql(false)
-    end
-
-    it "returns false when the key is expired" do
-      expect(provider).to receive(:shell_out).and_return(gpg_shell_out_expired)
-      expect(provider.keyring_key_is_valid?(keyring, key)).to eql(false)
-    end
-
-    it "returns false when the key has been revoked" do
-      expect(provider).to receive(:shell_out).and_return(gpg_shell_out_revoked)
-      expect(provider.keyring_key_is_valid?(keyring, key)).to eql(false)
-    end
-  end
-
-  describe "#keyring_key_is_present?" do
-    it "returns true for a key that exists" do
-      expect(provider).to receive(:shell_out).and_return(gpg_shell_out_success)
-      expect(provider.keyring_key_is_present?(keyring, key)).to eql(true)
-    end
-
-    it "returns false when the key is not present in the keyring" do
-      expect(provider).to receive(:shell_out).and_return(gpg_shell_out_failure)
-      expect(provider.keyring_key_is_present?(keyring, key)).to eql(false)
-    end
-  end
-
-  describe "#no_new_keys?" do
-    before do
-      allow(provider).to receive(:extract_public_keys_from_cmd).with(*apt_key_finger_cmd).and_return(apt_public_keys)
-    end
-
-    let(:file) { "/tmp/remote-gpg-keyfile" }
-
-    it "matches a set of keys" do
-      allow(provider).to receive(:extract_public_keys_from_cmd)
-        .with("gpg", "--with-fingerprint", "--with-colons", file)
-        .and_return([apt_public_keys.first])
-      expect(provider.no_new_keys?(file)).to be_truthy
-    end
-
-    it "notices missing keys" do
-      allow(provider).to receive(:extract_public_keys_from_cmd)
-        .with("gpg", "--with-fingerprint", "--with-colons", file)
-        .and_return(%w{pub:-:4096:1:871920D1991BC93C:1537196506})
-      expect(provider.no_new_keys?(file)).to be_falsey
-    end
-  end
-
-  describe "#key_type" do
-    it "returns :remote_file with an http URL" do
-      expect(provider.key_resource_type("https://www.chef.io/key")).to eq(:remote_file)
-    end
-
-    it "returns :cookbook_file with a chef managed file" do
-      expect(provider).to receive(:has_cookbook_file?).and_return(true)
-      expect(provider.key_resource_type("/foo/bar.key")).to eq(:cookbook_file)
-    end
-
-    it "throws exception if an unknown file specified" do
-      expect(provider).to receive(:has_cookbook_file?).and_return(false)
-      expect { provider.key_resource_type("/foo/bar.key") }.to raise_error(Chef::Exceptions::FileNotFound)
-    end
-  end
-
-  describe "#keyserver_install_cmd" do
-    it "returns keyserver install command" do
-      expect(provider.keyserver_install_cmd("ABC", "gpg.mit.edu")).to eq("apt-key adv --no-tty --recv --keyserver hkp://gpg.mit.edu:80 ABC")
-    end
-
-    it "uses proxy if key_proxy property is set" do
-      new_resource.key_proxy("proxy.mycorp.dmz:3128")
-      expect(provider.keyserver_install_cmd("ABC", "gpg.mit.edu")).to eq("apt-key adv --no-tty --recv --keyserver-options http-proxy=proxy.mycorp.dmz:3128 --keyserver hkp://gpg.mit.edu:80 ABC")
-    end
-
-    it "properly handles keyservers passed with hkp:// URIs" do
-      expect(provider.keyserver_install_cmd("ABC", "hkp://gpg.mit.edu")).to eq("apt-key adv --no-tty --recv --keyserver hkp://gpg.mit.edu ABC")
-    end
-  end
-
-  describe "#is_ppa_url" do
-    it "returns true if the URL starts with ppa:" do
-      expect(provider.is_ppa_url?("ppa://example.com")).to be_truthy
-    end
-
-    it "returns false if the URL does not start with ppa:" do
-      expect(provider.is_ppa_url?("example.com")).to be_falsey
-    end
-  end
-
-  describe "#repo_components" do
-    it "returns 'main' if a PPA and components property not set" do
-      expect(provider).to receive(:is_ppa_url?).and_return(true)
-      expect(provider.repo_components).to eq("main")
-    end
-
-    it "returns components property if a PPA and components is set" do
-      new_resource.components(["foo"])
-      expect(provider).to receive(:is_ppa_url?).and_return(true)
-      expect(provider.repo_components).to eq(["foo"])
-    end
-
-    it "returns components property if not a PPA" do
-      new_resource.components(["foo"])
-      expect(provider).to receive(:is_ppa_url?).and_return(false)
-      expect(provider.repo_components).to eq(["foo"])
-    end
-  end
-
-  describe "#install_key_from_keyserver_to_keyring" do
-    it "does not raise an error when the key is valid" do
-      expect(provider).to receive(:execute).and_return(nil)
-      expect(provider).to receive(:keyring_key_is_valid?).and_return(true)
-      expect { provider.install_key_from_keyserver_to_keyring(key, keyserver, keyring) }.not_to raise_error
-    end
-
-    it "raises an error with the key is invalid" do
-      expect(provider).to receive(:execute).and_return(nil)
-      expect(provider).to receive(:keyring_key_is_valid?).and_return(false)
-      expect { provider.install_key_from_keyserver_to_keyring(key, keyserver, keyring) }.to raise_error(RuntimeError)
-    end
-  end
-
-  describe "#install_ppa_key" do
-    let(:url) { "https://launchpad.net/api/1.0/~chef/+archive/main" }
-    let(:key) { "C5986B4F1257FFA86632CBA746181433FBB75451" }
-
-    it "gets a key" do
-      simples = double("HTTP")
-      allow(simples).to receive(:get).and_return("\"#{key}\"")
-      expect(Chef::HTTP::Simple).to receive(:new).with(url, {}).and_return(simples)
-      expect(provider).to receive(:install_key_from_keyserver).with(key, keyserver)
-      provider.install_ppa_key("chef", "main")
-    end
-  end
-
-  describe "#make_ppa_url" do
-    it "creates a URL" do
-      expect(provider).to receive(:install_ppa_key).with("chef", "main").and_return(true)
-      expect(provider.make_ppa_url("ppa:chef/main")).to eql("http://ppa.launchpad.net/chef/main/ubuntu")
-    end
-  end
-
-  describe "#build_repo" do
-    it "creates a repository string" do
-      target = "deb      http://test/uri unstable main\n"
-      expect(provider.build_repo("http://test/uri", "unstable", "main", false, nil, nil, [])).to eql(target)
-    end
-
-    it "creates a repository string with spaces" do
-      target = "deb      http://test/uri%20with%20spaces unstable main\n"
-      expect(provider.build_repo("http://test/uri with spaces", "unstable", "main", false, nil, nil, [])).to eql(target)
-    end
-
-    it "creates a repository string with no distribution" do
-      target = "deb      http://test/uri main\n"
-      expect(provider.build_repo("http://test/uri", nil, "main", false, nil, nil, [])).to eql(target)
-    end
-
-    it "creates a repository string with source" do
-      target = "deb      http://test/uri unstable main\ndeb-src  http://test/uri unstable main\n"
-      expect(provider.build_repo("http://test/uri", "unstable", "main", false, nil, nil, [], true)).to eql(target)
-    end
-
-    it "creates a repository string with trusted" do
-      target = "deb      [trusted=yes] http://test/uri unstable main\n"
-      expect(provider.build_repo("http://test/uri", "unstable", "main", true, nil, nil, [])).to eql(target)
-    end
-
-    it "creates a repository string with signed-by" do
-      target = "deb      [signed-by=/etc/apt/keyrings/test.gpg] http://test/uri unstable main\n"
-      expect(provider.build_repo("http://test/uri", "unstable", "main", false, nil, "/etc/apt/keyrings/test.gpg", [])).to eql(target)
-    end
-
-    it "creates a repository string with custom options" do
-      target = "deb      [by-hash=no] http://test/uri unstable main\n"
-      expect(provider.build_repo("http://test/uri", "unstable", "main", false, nil, nil, ["by-hash=no"])).to eql(target)
-    end
-
-    it "creates a repository string with trusted, arch, and custom options" do
-      target = "deb      [arch=amd64 trusted=yes by-hash=no] http://test/uri unstable main\n"
-      expect(provider.build_repo("http://test/uri", "unstable", "main", true, "amd64", nil, ["by-hash=no"])).to eql(target)
-    end
-
-    it "handles a ppa repo" do
-      target = "deb      http://ppa.launchpad.net/chef/main/ubuntu unstable main\n"
-      expect(provider).to receive(:make_ppa_url).with("ppa:chef/main").and_return("http://ppa.launchpad.net/chef/main/ubuntu")
-      expect(provider.build_repo("ppa:chef/main", "unstable", "main", false, nil, nil, [])).to eql(target)
-    end
-  end
-end

data/spec/unit/provider/apt_update_spec.rb

@@ -1,119 +0,0 @@
-#
-# Author:: Thom May (<thom@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe "Chef::Provider::AptUpdate" do
-  let(:node) { Chef::Node.new }
-  let(:events) { Chef::EventDispatch::Dispatcher.new }
-  let(:run_context) { Chef::RunContext.new(node, {}, events) }
-  let(:collection) { double("resource collection") }
-  let(:new_resource) { Chef::Resource::AptUpdate.new("update", run_context) }
-  let(:provider) { new_resource.provider_for_action(:update) }
-
-  let(:config_dir) { Dir.mktmpdir("apt_update_apt_conf_d") }
-  let(:config_file) { File.join(config_dir, "15update-stamp") }
-  let(:stamp_dir) { Dir.mktmpdir("apt_update_periodic") }
-
-  before do
-    new_resource.class.send(:remove_const, :APT_CONF_DIR)
-    new_resource.class.send(:const_set, :APT_CONF_DIR, config_dir)
-    new_resource.class.send(:remove_const, :STAMP_DIR)
-    new_resource.class.send(:const_set, :STAMP_DIR, stamp_dir)
-    node.automatic["platform_family"] = "debian"
-  end
-
-  let(:apt_update_cmd) { %w{apt-get -q update} }
-
-  it "responds to load_current_resource" do
-    expect(provider).to respond_to(:load_current_resource)
-  end
-
-  context "when the apt config directory does not exist" do
-    before do
-      FileUtils.rmdir config_dir
-      expect(File.exist?(config_dir)).to be false
-      allow_any_instance_of(Chef::Provider::Execute).to receive(:shell_out_compacted!).with(*apt_update_cmd, anything)
-    end
-
-    it "should create the directory" do
-      provider.run_action(:update)
-      expect(File.exist?(config_dir)).to be true
-      expect(File.directory?(config_dir)).to be true
-    end
-
-    it "should create the config file" do
-      provider.run_action(:update)
-      expect(File.exist?(config_file)).to be true
-      expect(File.read(config_file)).to match(/^APT::Update.*#{stamp_dir}/)
-    end
-  end
-
-  describe "#action_update" do
-    it "should update the apt cache" do
-      provider.load_current_resource
-      expect_any_instance_of(Chef::Provider::Execute).to receive(:shell_out_compacted!).with(*apt_update_cmd, anything)
-      provider.run_action(:update)
-      expect(new_resource).to be_updated_by_last_action
-    end
-  end
-
-  describe "#action_periodic" do
-    before do
-      allow(File).to receive(:exist?).with(config_file).and_return(true)
-      allow(File).to receive(:exist?).with(config_dir).and_return(true)
-      allow(File).to receive(:exist?).with(stamp_dir).and_return(true)
-      allow(File).to receive(:exist?).with(Dir.tmpdir).and_return(true)
-      expect(File).to receive(:exist?).with("#{stamp_dir}/update-success-stamp").and_return(true)
-    end
-
-    it "should run if the time stamp is old" do
-      expect(File).to receive(:mtime).with("#{stamp_dir}/update-success-stamp").and_return(Time.now - 86_500)
-      expect_any_instance_of(Chef::Provider::Execute).to receive(:shell_out_compacted!).with(*apt_update_cmd, anything)
-      provider.run_action(:periodic)
-      expect(new_resource).to be_updated_by_last_action
-    end
-
-    it "should not run if the time stamp is new" do
-      expect(File).to receive(:mtime).with("#{stamp_dir}/update-success-stamp").and_return(Time.now)
-      expect_any_instance_of(Chef::Provider::Execute).not_to receive(:shell_out_compacted!).with(*apt_update_cmd, anything)
-      provider.run_action(:periodic)
-      expect(new_resource).to_not be_updated_by_last_action
-    end
-
-    context "with a different frequency" do
-      before do
-        new_resource.frequency(400)
-      end
-
-      it "should run if the time stamp is old" do
-        expect(File).to receive(:mtime).with("#{stamp_dir}/update-success-stamp").and_return(Time.now - 500)
-        expect_any_instance_of(Chef::Provider::Execute).to receive(:shell_out_compacted!).with(*apt_update_cmd, anything)
-        provider.run_action(:periodic)
-        expect(new_resource).to be_updated_by_last_action
-      end
-
-      it "should not run if the time stamp is new" do
-        expect(File).to receive(:mtime).with("#{stamp_dir}/update-success-stamp").and_return(Time.now - 300)
-        expect_any_instance_of(Chef::Provider::Execute).not_to receive(:shell_out_compacted!).with(*apt_update_cmd, anything)
-        provider.run_action(:periodic)
-        expect(new_resource).to_not be_updated_by_last_action
-      end
-    end
-  end
-end