chef 16.16.13 → 17.0.242

data/spec/unit/knife/key_delete_spec.rb

@@ -1,133 +0,0 @@
-#
-# Author:: Tyler Cloke (<tyler@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-require "chef/knife/user_key_delete"
-require "chef/knife/client_key_delete"
-require "chef/knife/key_delete"
-require "chef/key"
-
-describe "key delete commands that inherit knife" do
-  shared_examples_for "a key delete command" do
-    let(:stderr) { StringIO.new }
-    let(:params) { [] }
-    let(:service_object) { instance_double(Chef::Knife::KeyDelete) }
-    let(:command) do
-      c = described_class.new([])
-      c.ui.config[:disable_editing] = true
-      allow(c.ui).to receive(:stderr).and_return(stderr)
-      allow(c.ui).to receive(:stdout).and_return(stderr)
-      allow(c).to receive(:show_usage)
-      c
-    end
-
-    context "after apply_params! is called with valid args" do
-      let(:params) { %w{charmander charmander-key} }
-      before do
-        command.apply_params!(params)
-      end
-
-      context "when the service object is called" do
-        it "creates a new instance of Chef::Knife::KeyDelete with the correct args" do
-          expect(Chef::Knife::KeyDelete).to receive(:new)
-            .with("charmander-key", "charmander", command.actor_field_name, command.ui)
-            .and_return(service_object)
-          command.service_object
-        end
-      end # when the service object is called
-    end # after apply_params! is called with valid args
-  end # a key delete command
-
-  describe Chef::Knife::UserKeyDelete do
-    it_should_behave_like "a key delete command"
-    # defined in key_helpers.rb
-    it_should_behave_like "a knife key command with a keyname as the second arg"
-    it_should_behave_like "a knife key command" do
-      let(:service_object) { instance_double(Chef::Knife::KeyDelete) }
-      let(:params) { %w{charmander charmander-key} }
-    end
-  end
-
-  describe Chef::Knife::ClientKeyDelete do
-    it_should_behave_like "a key delete command"
-    # defined in key_helpers.rb
-    it_should_behave_like "a knife key command with a keyname as the second arg"
-    it_should_behave_like "a knife key command" do
-      let(:service_object) { instance_double(Chef::Knife::KeyDelete) }
-      let(:params) { %w{charmander charmander-key} }
-    end
-  end
-end
-
-describe Chef::Knife::KeyDelete do
-  let(:actor) { "charmander" }
-  let(:keyname) { "charmander-key" }
-  let(:ui) { instance_double("Chef::Knife::UI") }
-
-  shared_examples_for "key delete run command" do
-    let(:key_delete_object) do
-      described_class.new(keyname, actor, actor_field_name, ui)
-    end
-
-    before do
-      allow_any_instance_of(Chef::Key).to receive(:destroy)
-      allow(key_delete_object).to receive(:print_destroyed)
-      allow(key_delete_object).to receive(:confirm!)
-    end
-
-    context "when the command is run" do
-      it "calls Chef::Key.new with the proper input" do
-        expect(Chef::Key).to receive(:new).with(actor, actor_field_name).and_call_original
-        key_delete_object.run
-      end
-
-      it "calls name on the Chef::Key instance with the proper input" do
-        expect_any_instance_of(Chef::Key).to receive(:name).with(keyname)
-        key_delete_object.run
-      end
-
-      it "calls destroy on the Chef::Key instance" do
-        expect_any_instance_of(Chef::Key).to receive(:destroy).once
-        key_delete_object.run
-      end
-
-      it "calls confirm!" do
-        expect(key_delete_object).to receive(:confirm!)
-        key_delete_object.run
-      end
-
-      it "calls print_destroyed" do
-        expect(key_delete_object).to receive(:print_destroyed)
-        key_delete_object.run
-      end
-    end # when the command is run
-
-  end # key delete run command
-
-  context "when actor_field_name is 'user'" do
-    it_should_behave_like "key delete run command" do
-      let(:actor_field_name) { "user" }
-    end
-  end
-
-  context "when actor_field_name is 'client'" do
-    it_should_behave_like "key delete run command" do
-      let(:actor_field_name) { "client" }
-    end
-  end
-end

data/spec/unit/knife/key_edit_spec.rb

@@ -1,264 +0,0 @@
-#
-# Author:: Tyler Cloke (<tyler@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-require "chef/knife/user_key_edit"
-require "chef/knife/client_key_edit"
-require "chef/knife/key_edit"
-require "chef/key"
-
-describe "key edit commands that inherit knife" do
-  shared_examples_for "a key edit command" do
-    let(:stderr) { StringIO.new }
-    let(:params) { [] }
-    let(:service_object) { instance_double(Chef::Knife::KeyEdit) }
-    let(:command) do
-      c = described_class.new([])
-      c.ui.config[:disable_editing] = true
-      allow(c.ui).to receive(:stderr).and_return(stderr)
-      allow(c.ui).to receive(:stdout).and_return(stderr)
-      allow(c).to receive(:show_usage)
-      c
-    end
-
-    context "after apply_params! is called with valid args" do
-      let(:params) { %w{charmander charmander-key} }
-      before do
-        command.apply_params!(params)
-      end
-
-      context "when the service object is called" do
-        it "creates a new instance of Chef::Knife::KeyEdit with the correct args" do
-          expect(Chef::Knife::KeyEdit).to receive(:new)
-            .with("charmander-key", "charmander", command.actor_field_name, command.ui, command.config)
-            .and_return(service_object)
-          command.service_object
-        end
-      end # when the service object is called
-    end # after apply_params! is called with valid args
-  end # a key edit command
-
-  describe Chef::Knife::UserKeyEdit do
-    it_should_behave_like "a key edit command"
-    # defined in key_helpers.rb
-    it_should_behave_like "a knife key command with a keyname as the second arg"
-    it_should_behave_like "a knife key command" do
-      let(:service_object) { instance_double(Chef::Knife::KeyEdit) }
-      let(:params) { %w{charmander charmander-key} }
-    end
-  end
-
-  describe Chef::Knife::ClientKeyEdit do
-    it_should_behave_like "a key edit command"
-    # defined in key_helpers.rb
-    it_should_behave_like "a knife key command with a keyname as the second arg"
-    it_should_behave_like "a knife key command" do
-      let(:service_object) { instance_double(Chef::Knife::KeyEdit) }
-      let(:params) { %w{charmander charmander-key} }
-    end
-  end
-end
-
-describe Chef::Knife::KeyEdit do
-  let(:public_key) do
-    "-----BEGIN PUBLIC KEY-----
-MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAvPo+oNPB7uuNkws0fC02
-KxSwdyqPLu0fhI1pOweNKAZeEIiEz2PkybathHWy8snSXGNxsITkf3eyvIIKa8OZ
-WrlqpI3yv/5DOP8HTMCxnFuMJQtDwMcevlqebX4bCxcByuBpNYDcAHjjfLGSfMjn
-E5lZpgYWwnpic4kSjYcL9ORK9nYvlWV9P/kCYmRhIjB4AhtpWRiOfY/TKi3P2LxT
-IjSmiN/ihHtlhV/VSnBJ5PzT/lRknlrJ4kACoz7Pq9jv+aAx5ft/xE9yDa2DYs0q
-Tfuc9dUYsFjptWYrV6pfEQ+bgo1OGBXORBFcFL+2D7u9JYquKrMgosznHoEkQNLo
-0wIDAQAB
------END PUBLIC KEY-----"
-  end
-  let(:config) { {} }
-  let(:actor) { "charmander" }
-  let(:keyname) { "charmander-key" }
-  let(:ui) { instance_double("Chef::Knife::UI") }
-
-  shared_examples_for "key edit run command" do
-    let(:key_edit_object) do
-      described_class.new(keyname, actor, actor_field_name, ui, config)
-    end
-
-    context "when the command is run" do
-      let(:expected_hash) do
-        {
-          actor_field_name => "charmander",
-        }
-      end
-      let(:new_keyname) { "charizard-key" }
-
-      before do
-        allow(File).to receive(:read).and_return(public_key)
-        allow(File).to receive(:expand_path)
-
-        allow(key_edit_object).to receive(:output_private_key_to_file)
-        allow(key_edit_object).to receive(:display_private_key)
-        allow(key_edit_object).to receive(:edit_hash).and_return(expected_hash)
-        allow(key_edit_object).to receive(:display_info)
-      end
-
-      context "when public_key and create_key are passed" do
-        before do
-          key_edit_object.config[:public_key] = "public_key_path"
-          key_edit_object.config[:create_key] = true
-        end
-
-        it "raises a Chef::Exceptions::KeyCommandInputError with the proper error message" do
-          expect { key_edit_object.run }.to raise_error(Chef::Exceptions::KeyCommandInputError, key_edit_object.public_key_and_create_key_error_msg)
-        end
-      end
-
-      context "when key_name is passed" do
-        let(:expected_hash) do
-          {
-            actor_field_name => "charmander",
-            "name" => new_keyname,
-          }
-        end
-        before do
-          key_edit_object.config[:key_name] = new_keyname
-          allow_any_instance_of(Chef::Key).to receive(:update)
-        end
-
-        it "update_key_from_hash gets passed a hash with new key name" do
-          expect(key_edit_object).to receive(:update_key_from_hash).with(expected_hash).and_return(Chef::Key.from_hash(expected_hash))
-          key_edit_object.run
-        end
-
-        it "Chef::Key.update is passed a string containing the original keyname" do
-          expect_any_instance_of(Chef::Key).to receive(:update).with(/#{keyname}/).and_return(Chef::Key.from_hash(expected_hash))
-          key_edit_object.run
-        end
-
-        it "Chef::Key.update is not passed a string containing the new keyname" do
-          expect_any_instance_of(Chef::Key).not_to receive(:update).with(/#{new_keyname}/)
-          allow_any_instance_of(Chef::Key).to receive(:update).and_return(Chef::Key.from_hash(expected_hash))
-          key_edit_object.run
-        end
-      end
-
-      context "when public_key, key_name, and expiration_date are passed" do
-        let(:expected_hash) do
-          {
-            actor_field_name => "charmander",
-            "public_key" => public_key,
-            "name" => new_keyname,
-            "expiration_date" => "infinity",
-          }
-        end
-        before do
-          key_edit_object.config[:public_key] = "this-public-key"
-          key_edit_object.config[:key_name] = new_keyname
-          key_edit_object.config[:expiration_date] = "infinity"
-          allow(key_edit_object).to receive(:update_key_from_hash).and_return(Chef::Key.from_hash(expected_hash))
-        end
-
-        it "passes the right hash to update_key_from_hash" do
-          expect(key_edit_object).to receive(:update_key_from_hash).with(expected_hash)
-          key_edit_object.run
-        end
-      end
-
-      context "when create_key is passed" do
-        let(:expected_hash) do
-          {
-            actor_field_name => "charmander",
-            "create_key" => true,
-          }
-        end
-
-        before do
-          key_edit_object.config[:create_key] = true
-          allow(key_edit_object).to receive(:update_key_from_hash).and_return(Chef::Key.from_hash(expected_hash))
-        end
-
-        it "passes the right hash to update_key_from_hash" do
-          expect(key_edit_object).to receive(:update_key_from_hash).with(expected_hash)
-          key_edit_object.run
-        end
-      end
-
-      context "when public_key is passed" do
-        let(:expected_hash) do
-          {
-            actor_field_name => "charmander",
-            "public_key" => public_key,
-          }
-        end
-        before do
-          allow(key_edit_object).to receive(:update_key_from_hash).and_return(Chef::Key.from_hash(expected_hash))
-          key_edit_object.config[:public_key] = "public_key_path"
-        end
-
-        it "calls File.expand_path with the public_key input" do
-          expect(File).to receive(:expand_path).with("public_key_path")
-          key_edit_object.run
-        end
-      end # when public_key is passed
-
-      context "when the server returns a private key" do
-        let(:expected_hash) do
-          {
-            actor_field_name => "charmander",
-            "public_key" => public_key,
-            "private_key" => "super_private",
-          }
-        end
-
-        before do
-          allow(key_edit_object).to receive(:update_key_from_hash).and_return(Chef::Key.from_hash(expected_hash))
-          key_edit_object.config[:public_key] = "public_key_path"
-        end
-
-        context "when file is not passed" do
-          it "calls display_private_key with the private_key" do
-            expect(key_edit_object).to receive(:display_private_key).with("super_private")
-            key_edit_object.run
-          end
-        end
-
-        context "when file is passed" do
-          before do
-            key_edit_object.config[:file] = "/fake/file"
-          end
-
-          it "calls output_private_key_to_file with the private_key" do
-            expect(key_edit_object).to receive(:output_private_key_to_file).with("super_private")
-            key_edit_object.run
-          end
-        end
-      end # when the server returns a private key
-
-    end # when the command is run
-
-  end # key edit run command
-
-  context "when actor_field_name is 'user'" do
-    it_should_behave_like "key edit run command" do
-      let(:actor_field_name) { "user" }
-    end
-  end
-
-  context "when actor_field_name is 'client'" do
-    it_should_behave_like "key edit run command" do
-      let(:actor_field_name) { "client" }
-    end
-  end
-end

data/spec/unit/knife/key_helper.rb

@@ -1,74 +0,0 @@
-#
-# Author:: Tyler Cloke (<tyler@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-shared_examples_for "a knife key command" do
-  let(:stderr) { StringIO.new }
-  let(:params) { [] }
-  let(:command) do
-    c = described_class.new([])
-    c.ui.config[:disable_editing] = true
-    allow(c.ui).to receive(:stderr).and_return(stderr)
-    allow(c.ui).to receive(:stdout).and_return(stderr)
-    allow(c).to receive(:show_usage)
-    c
-  end
-
-  context "before apply_params! is called" do
-    context "when apply_params! is called with invalid args" do
-      it "shows the usage" do
-        expect(command).to receive(:show_usage)
-        expect { command.apply_params!(params) }.to exit_with_code(1)
-      end
-
-      it "outputs the proper error" do
-        expect { command.apply_params!(params) }.to exit_with_code(1)
-        expect(stderr.string).to include(command.actor_missing_error)
-      end
-
-      it "exits 1" do
-        expect { command.apply_params!(params) }.to exit_with_code(1)
-      end
-    end
-  end # before apply_params! is called
-
-  context "after apply_params! is called with valid args" do
-    let(:params) { ["charmander"] }
-    before do
-      command.apply_params!(params)
-    end
-
-    it "properly defines the actor" do
-      expect(command.actor).to eq("charmander")
-    end
-  end # after apply_params! is called with valid args
-
-  context "when the command is run" do
-    before do
-      allow(command).to receive(:service_object).and_return(service_object)
-      allow(command).to receive(:name_args).and_return(["charmander"])
-    end
-
-    context "when the command is successful" do
-      before do
-        expect(service_object).to receive(:run)
-      end
-    end
-  end
-end # a knife key command

data/spec/unit/knife/key_list_spec.rb

@@ -1,216 +0,0 @@
-#
-# Author:: Tyler Cloke (<tyler@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-require "chef/knife/user_key_list"
-require "chef/knife/client_key_list"
-require "chef/knife/key_list"
-require "chef/key"
-
-describe "key list commands that inherit knife" do
-  shared_examples_for "a key list command" do
-    let(:stderr) { StringIO.new }
-    let(:params) { [] }
-    let(:service_object) { instance_double(Chef::Knife::KeyList) }
-    let(:command) do
-      c = described_class.new([])
-      c.ui.config[:disable_editing] = true
-      allow(c.ui).to receive(:stderr).and_return(stderr)
-      allow(c.ui).to receive(:stdout).and_return(stderr)
-      allow(c).to receive(:show_usage)
-      c
-    end
-
-    context "after apply_params! is called with valid args" do
-      let(:params) { ["charmander"] }
-      before do
-        command.apply_params!(params)
-      end
-
-      context "when the service object is called" do
-        it "creates a new instance of Chef::Knife::KeyList with the correct args" do
-          expect(Chef::Knife::KeyList).to receive(:new)
-            .with("charmander", command.list_method, command.ui, command.config)
-            .and_return(service_object)
-          command.service_object
-        end
-      end # when the service object is called
-    end # after apply_params! is called with valid args
-  end # a key list command
-
-  describe Chef::Knife::UserKeyList do
-    it_should_behave_like "a key list command"
-    # defined in key_helpers.rb
-    it_should_behave_like "a knife key command" do
-      let(:service_object) { instance_double(Chef::Knife::KeyList) }
-      let(:params) { ["charmander"] }
-    end
-  end
-
-  describe Chef::Knife::ClientKeyList do
-    it_should_behave_like "a key list command"
-    # defined in key_helpers.rb
-    it_should_behave_like "a knife key command" do
-      let(:service_object) { instance_double(Chef::Knife::KeyList) }
-      let(:params) { ["charmander"] }
-    end
-  end
-end
-
-describe Chef::Knife::KeyList do
-  let(:config) { {} }
-  let(:actor) { "charmander" }
-  let(:ui) { instance_double("Chef::Knife::UI") }
-
-  shared_examples_for "key list run command" do
-    let(:key_list_object) do
-      described_class.new(actor, list_method, ui, config)
-    end
-
-    before do
-      allow(Chef::Key).to receive(list_method).and_return(http_response)
-      allow(key_list_object).to receive(:display_info)
-      # simply pass the string though that colorize takes in
-      allow(key_list_object).to receive(:colorize).with(kind_of(String)) do |input|
-        input
-      end
-    end
-
-    context "when only_expired and only_non_expired were both passed" do
-      before do
-        key_list_object.config[:only_expired] = true
-        key_list_object.config[:only_non_expired] = true
-      end
-
-      it "raises a Chef::Exceptions::KeyCommandInputError with the proper error message" do
-        expect { key_list_object.run }.to raise_error(Chef::Exceptions::KeyCommandInputError, key_list_object.expired_and_non_expired_msg)
-      end
-    end
-
-    context "when the command is run" do
-      before do
-        key_list_object.config[:only_expired] = false
-        key_list_object.config[:only_non_expired] = false
-        key_list_object.config[:with_details] = false
-      end
-
-      it "calls Chef::Key with the proper list command and input" do
-        expect(Chef::Key).to receive(list_method).with(actor)
-        key_list_object.run
-      end
-
-      it "displays all the keys" do
-        expect(key_list_object).to receive(:display_info).with(/non-expired/).twice
-        expect(key_list_object).to receive(:display_info).with(/out-of-date/).once
-        key_list_object.run
-      end
-
-      context "when only_expired is called" do
-        before do
-          key_list_object.config[:only_expired] = true
-        end
-
-        it "excludes displaying non-expired keys" do
-          expect(key_list_object).to receive(:display_info).with(/non-expired/).exactly(0).times
-          key_list_object.run
-        end
-
-        it "displays the expired keys" do
-          expect(key_list_object).to receive(:display_info).with(/out-of-date/).once
-          key_list_object.run
-        end
-      end # when only_expired is called
-
-      context "when only_non_expired is called" do
-        before do
-          key_list_object.config[:only_non_expired] = true
-        end
-
-        it "excludes displaying expired keys" do
-          expect(key_list_object).to receive(:display_info).with(/out-of-date/).exactly(0).times
-          key_list_object.run
-        end
-
-        it "displays the non-expired keys" do
-          expect(key_list_object).to receive(:display_info).with(/non-expired/).twice
-          key_list_object.run
-        end
-      end # when only_expired is called
-
-      context "when with_details is false" do
-        before do
-          key_list_object.config[:with_details] = false
-        end
-
-        it "does not display the uri" do
-          expect(key_list_object).to receive(:display_info).with(/https/).exactly(0).times
-          key_list_object.run
-        end
-
-        it "does not display the expired status" do
-          expect(key_list_object).to receive(:display_info).with(/\(expired\)/).exactly(0).times
-          key_list_object.run
-        end
-      end # when with_details is false
-
-      context "when with_details is true" do
-        before do
-          key_list_object.config[:with_details] = true
-        end
-
-        it "displays the uri" do
-          expect(key_list_object).to receive(:display_info).with(/https/).exactly(3).times
-          key_list_object.run
-        end
-
-        it "displays the expired status" do
-          expect(key_list_object).to receive(:display_info).with(/\(expired\)/).once
-          key_list_object.run
-        end
-      end # when with_details is true
-
-    end # when the command is run
-
-  end # key list run command
-
-  context "when list_method is :list_by_user" do
-    it_should_behave_like "key list run command" do
-      let(:list_method) { :list_by_user }
-      let(:http_response) do
-        [
-          { "uri" => "https://api.opscode.piab/users/charmander/keys/non-expired1", "name" => "non-expired1", "expired" => false },
-          { "uri" => "https://api.opscode.piab/users/charmander/keys/non-expired2", "name" => "non-expired2", "expired" => false },
-          { "uri" => "https://api.opscode.piab/users/mary/keys/out-of-date",        "name" => "out-of-date", "expired" => true },
-        ]
-      end
-    end
-  end
-
-  context "when list_method is :list_by_client" do
-    it_should_behave_like "key list run command" do
-      let(:list_method) { :list_by_client }
-      let(:http_response) do
-        [
-          { "uri" => "https://api.opscode.piab/organizations/pokemon/clients/charmander/keys/non-expired1", "name" => "non-expired1", "expired" => false },
-          { "uri" => "https://api.opscode.piab/organizations/pokemon/clients/charmander/keys/non-expired2", "name" => "non-expired2", "expired" => false },
-          { "uri" => "https://api.opscode.piab/organizations/pokemon/clients/mary/keys/out-of-date",        "name" => "out-of-date", "expired" => true },
-        ]
-      end
-    end
-  end
-end