chef 16.16.13 → 17.0.242

data/spec/integration/knife/client_create_spec.rb

@@ -1,70 +0,0 @@
-#
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-require "spec_helper"
-require "support/shared/integration/integration_helper"
-require "support/shared/context/config"
-require "openssl"
-
-describe "knife client create", :workstation do
-  include IntegrationSupport
-  include KnifeSupport
-
-  include_context "default config options"
-
-  let(:out) { "Created client[bah]\n" }
-
-  when_the_chef_server "is empty" do
-    it "creates a new client" do
-      knife("client create -k bah").should_succeed stderr: out
-    end
-
-    it "creates a new validator client" do
-      knife("client create -k --validator bah").should_succeed stderr: out
-      knife("client show bah").should_succeed <<~EOM
-        admin:     false
-        chef_type: client
-        name:      bah
-        validator: true
-      EOM
-    end
-
-    it "refuses to add an existing client" do
-      pending "Knife client create must not blindly overwrite an existing client"
-      knife("client create -k bah").should_succeed stderr: out
-      expect { knife("client create -k bah") }.to raise_error(Net::HTTPClientException)
-    end
-
-    it "saves the private key to a file" do
-      Dir.mktmpdir do |tgt|
-        knife("client create -f #{tgt}/bah.pem bah").should_succeed stderr: out
-        expect(File).to exist("#{tgt}/bah.pem")
-      end
-    end
-
-    it "reads the public key from a file" do
-      Dir.mktmpdir do |tgt|
-        key = OpenSSL::PKey::RSA.generate(1024)
-        File.open("#{tgt}/public.pem", "w") { |pub| pub.write(key.public_key.to_pem) }
-        knife("client create -p #{tgt}/public.pem bah").should_succeed stderr: out
-      end
-    end
-
-    it "refuses to run if conflicting options are passed" do
-      knife("client create -p public.pem --prevent-keygen blah").should_fail stderr: "FATAL: You cannot pass --public-key and --prevent-keygen\n", stdout: /^USAGE.*/
-    end
-  end
-end

data/spec/integration/knife/client_delete_spec.rb

@@ -1,64 +0,0 @@
-#
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-require "spec_helper"
-require "support/shared/integration/integration_helper"
-require "support/shared/context/config"
-
-describe "knife client delete", :workstation do
-  include IntegrationSupport
-  include KnifeSupport
-
-  include_context "default config options"
-
-  when_the_chef_server "has some clients" do
-    before do
-      client "cons", {}
-      client "car", {}
-      client "car-validator", { validator: true }
-      client "cdr", {}
-      client "cat", {}
-    end
-
-    it "deletes a client" do
-      knife("client delete car", input: "Y").should_succeed <<~EOM
-        Do you really want to delete car? (Y/N) Deleted client[car]
-      EOM
-
-      knife("client list").should_succeed <<~EOM
-        car-validator
-        cat
-        cdr
-        chef-validator
-        chef-webui
-        cons
-      EOM
-    end
-
-    it "refuses to delete a validator normally" do
-      knife("client delete car-validator", input: "Y").should_fail exit_code: 2, stdout: "Do you really want to delete car-validator? (Y/N) ", stderr: <<~EOM
-        FATAL: You must specify --delete-validators to delete the validator client car-validator
-      EOM
-    end
-
-    it "deletes a validator correctly" do
-      knife("client delete car-validator -D", input: "Y").should_succeed <<~EOM
-        Do you really want to delete car-validator? (Y/N) Deleted client[car-validator]
-      EOM
-    end
-
-  end
-end

data/spec/integration/knife/client_key_create_spec.rb

@@ -1,66 +0,0 @@
-#
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-require "spec_helper"
-require "support/shared/integration/integration_helper"
-require "support/shared/context/config"
-require "openssl"
-
-describe "knife client key create", :workstation do
-  include IntegrationSupport
-  include KnifeSupport
-
-  include_context "default config options"
-
-  let(:out) { "Created key: new" }
-
-  when_the_chef_server "has a client" do
-    before do
-      client "bah", {}
-    end
-
-    it "creates a new client key" do
-      knife("client key create -k new bah").should_succeed stderr: /^#{out}/, stdout: /.*BEGIN RSA PRIVATE KEY/
-    end
-
-    it "creates a new client key with an expiration date" do
-      date = "2017-12-31T23:59:59Z"
-      knife("client key create -k new -e #{date} bah").should_succeed stderr: /^#{out}/, stdout: /.*BEGIN RSA PRIVATE KEY/
-      knife("client key show bah new").should_succeed(/expiration_date:.*#{date}/)
-    end
-
-    it "refuses to add an already existing key" do
-      knife("client key create -k new bah")
-      expect { knife("client key create -k new bah") }.to raise_error(Net::HTTPClientException)
-    end
-
-    it "saves the private key to a file" do
-      Dir.mktmpdir do |tgt|
-        knife("client key create -f #{tgt}/bah.pem -k new bah").should_succeed stderr: /^#{out}/
-        expect(File).to exist("#{tgt}/bah.pem")
-      end
-    end
-
-    it "reads the public key from a file" do
-      Dir.mktmpdir do |tgt|
-        key = OpenSSL::PKey::RSA.generate(1024)
-        File.open("#{tgt}/public.pem", "w") { |pub| pub.write(key.public_key.to_pem) }
-        knife("client key create -p #{tgt}/public.pem -k new bah").should_succeed stderr: /^#{out}/
-      end
-    end
-
-  end
-end

data/spec/integration/knife/client_key_delete_spec.rb

@@ -1,43 +0,0 @@
-#
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-require "spec_helper"
-require "support/shared/integration/integration_helper"
-require "support/shared/context/config"
-
-describe "knife client key delete", :workstation do
-  include IntegrationSupport
-  include KnifeSupport
-
-  include_context "default config options"
-
-  when_the_chef_server "has a client" do
-    before do
-      client "car", {}
-    end
-
-    it "deletes a client" do
-      out = "Do you really want to delete the key named new for the client named car? (Y/N) "
-      knife("client key create -k new car")
-      knife("client key delete car new", input: "Y").should_succeed stdout: out, stderr: <<~EOM
-        Deleted key named new for the client named car
-      EOM
-
-      knife("client key list car").should_succeed ""
-    end
-
-  end
-end

data/spec/integration/knife/client_key_list_spec.rb

@@ -1,61 +0,0 @@
-#
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-require "spec_helper"
-require "support/shared/integration/integration_helper"
-require "support/shared/context/config"
-require "date"
-
-describe "knife client key list", :workstation do
-  include IntegrationSupport
-  include KnifeSupport
-
-  include_context "default config options"
-
-  let(:now) { DateTime.now }
-  let(:last_month) { (now << 1).strftime("%FT%TZ") }
-  let(:next_month) { (now >> 1).strftime("%FT%TZ") }
-
-  when_the_chef_server "has a client" do
-    before do
-      client "cons", {}
-      knife("client key create cons -k new")
-      knife("client key create cons -k next_month -e #{next_month}")
-      knife("client key create cons -k expired -e #{last_month}")
-    end
-
-    it "lists the keys for a client" do
-      knife("client key list cons").should_succeed "expired\nnew\nnext_month\n"
-    end
-
-    it "shows detailed output" do
-      knife("client key list -w cons").should_succeed <<~EOM
-        expired:    http://127.0.0.1:8900/clients/cons/keys/expired (expired)
-        new:        http://127.0.0.1:8900/clients/cons/keys/new
-        next_month: http://127.0.0.1:8900/clients/cons/keys/next_month
-      EOM
-    end
-
-    it "lists the expired keys for a client" do
-      knife("client key list -e cons").should_succeed "expired\n"
-    end
-
-    it "lists the unexpired keys for a client" do
-      knife("client key list -n cons").should_succeed "new\nnext_month\n"
-    end
-
-  end
-end

data/spec/integration/knife/client_key_show_spec.rb

@@ -1,45 +0,0 @@
-#
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-require "spec_helper"
-require "support/shared/integration/integration_helper"
-require "support/shared/context/config"
-require "date"
-
-describe "knife client key show", :workstation do
-  include IntegrationSupport
-  include KnifeSupport
-
-  include_context "default config options"
-
-  let(:now) { DateTime.now }
-  let(:last_month) { (now << 1).strftime("%FT%TZ") }
-  let(:next_month) { (now >> 1).strftime("%FT%TZ") }
-
-  when_the_chef_server "has a client" do
-    before do
-      client "cons", {}
-      knife("client key create cons -k new")
-      knife("client key create cons -k next_month -e #{next_month}")
-      knife("client key create cons -k expired -e #{last_month}")
-    end
-
-    it "shows a key for a client" do
-      knife("client key show cons new").should_succeed stdout: /.*name:.*new/
-    end
-
-  end
-end

data/spec/integration/knife/client_list_spec.rb

@@ -1,49 +0,0 @@
-#
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-require "spec_helper"
-require "support/shared/integration/integration_helper"
-require "support/shared/context/config"
-
-describe "knife client list", :workstation do
-  include IntegrationSupport
-  include KnifeSupport
-
-  include_context "default config options"
-
-  when_the_chef_server "has some clients" do
-    before do
-      client "cons", {}
-      client "car", {}
-      client "car-validator", { validator: true }
-      client "cdr", {}
-      client "cat", {}
-    end
-
-    it "lists the clients" do
-      knife("client list").should_succeed <<~EOM
-        car
-        car-validator
-        cat
-        cdr
-        chef-validator
-        chef-webui
-        cons
-      EOM
-    end
-
-  end
-end

data/spec/integration/knife/client_show_spec.rb

@@ -1,37 +0,0 @@
-#
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-require "spec_helper"
-require "support/shared/integration/integration_helper"
-require "support/shared/context/config"
-
-describe "knife client show", :workstation do
-  include IntegrationSupport
-  include KnifeSupport
-
-  include_context "default config options"
-
-  when_the_chef_server "has a client" do
-    before do
-      client "cons", {}
-    end
-
-    it "shows a client" do
-      knife("client show cons").should_succeed stdout: /.*name:.*cons/
-    end
-
-  end
-end

data/spec/integration/knife/common_options_spec.rb

@@ -1,174 +0,0 @@
-#
-# Author:: John Keiser (<jkeiser@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-require "spec_helper"
-require "support/shared/integration/integration_helper"
-require "chef/knife/raw"
-
-describe "knife common options", :workstation do
-  include IntegrationSupport
-  include KnifeSupport
-
-  before do
-    # Allow this for testing the various port binding stuffs. Remove when
-    # we kill off --listen.
-    Chef::Config.treat_deprecation_warnings_as_errors(false)
-  end
-
-  let(:local_listen_warning) { /\Awarn:.*local.*listen.*$/im }
-
-  when_the_repository "has a node" do
-    before { file "nodes/x.json", {} }
-
-    context "When chef_zero.enabled is true" do
-      before(:each) do
-        Chef::Config.chef_zero.enabled = true
-      end
-
-      it "knife raw /nodes/x should retrieve the node in socketless mode" do
-        Chef::Config.treat_deprecation_warnings_as_errors(true)
-        knife("raw /nodes/x").should_succeed( /"name": "x"/ )
-      end
-
-      it "knife raw /nodes/x should retrieve the node" do
-        knife("raw --listen /nodes/x").should_succeed( /"name": "x"/, stderr: local_listen_warning )
-      end
-
-      context "And chef_zero.port is 9999" do
-        before(:each) { Chef::Config.chef_zero.port = 9999 }
-
-        it "knife raw /nodes/x should retrieve the node" do
-          knife("raw --listen /nodes/x").should_succeed( /"name": "x"/, stderr: local_listen_warning )
-          expect(Chef::Config.chef_server_url).to eq("chefzero://localhost:9999")
-        end
-      end
-
-      # 0.0.0.0 is not a valid address to bind to on windows.
-      context "And chef_zero.host is 0.0.0.0", :unix_only do
-        before(:each) { Chef::Config.chef_zero.host = "0.0.0.0" }
-
-        it "knife raw /nodes/x should retrieve the role" do
-          knife("raw --listen /nodes/x").should_succeed( /"name": "x"/, stderr: local_listen_warning )
-        end
-      end
-
-      context "and there is a private key" do
-        before do
-          file "mykey.pem", <<~EOM
-            -----BEGIN RSA PRIVATE KEY-----
-            MIIEogIBAAKCAQEApubutqtYYQ5UiA9QhWP7UvSmsfHsAoPKEVVPdVW/e8Svwpyf
-            0Xef6OFWVmBE+W442ZjLOe2y6p2nSnaq4y7dg99NFz6X+16mcKiCbj0RCiGqCvCk
-            NftHhTgO9/RFvCbmKZ1RKNob1YzLrFpxBHaSh9po+DGWhApcd+I+op+ZzvDgXhNn
-            0nauZu3rZmApI/r7EEAOjFedAXs7VPNXhhtZAiLSAVIrwU3ZajtSzgXOxbNzgj5O
-            AAAMmThK+71qPdffAdO4J198H6/MY04qgtFo7vumzCq0UCaGZfmeI1UNE4+xQWwP
-            HJ3pDAP61C6Ebx2snI2kAd9QMx9Y78nIedRHPwIDAQABAoIBAHssRtPM1GacWsom
-            8zfeN6ZbI4KDlbetZz0vhnqDk9NVrpijWlcOP5dwZXVNitnB/HaqCqFvyPDY9JNB
-            zI/pEFW4QH59FVDP42mVEt0keCTP/1wfiDDGh1vLqVBYl/ZphscDcNgDTzNkuxMx
-            k+LFVxKnn3w7rGc59lALSkpeGvbbIDjp3LUMlUeCF8CIFyYZh9ZvXe4OCxYdyjxb
-            i8tnMLKvJ4Psbh5jMapsu3rHQkfPdqzztQUz8vs0NYwP5vWge46FUyk+WNm/IhbJ
-            G3YM22nwUS8Eu2bmTtADSJolATbCSkOwQ1D+Fybz/4obfYeGaCdOqB05ttubhenV
-            ShsAb7ECgYEA20ecRVxw2S7qA7sqJ4NuYOg9TpfGooptYNA1IP971eB6SaGAelEL
-            awYkGNuu2URmm5ElZpwJFFTDLGA7t2zB2xI1FeySPPIVPvJGSiZoFQOVlIg9WQzK
-            7jTtFQ/tOMrF+bigEUJh5bP1/7HzqSpuOsPjEUb2aoCTp+tpiRGL7TUCgYEAwtns
-            g3ysrSEcTzpSv7fQRJRk1lkBhatgNd0oc+ikzf74DaVLhBg1jvSThDhiDCdB59mr
-            Jh41cnR1XqE8jmdQbCDRiFrI1Pq6TPaDZFcovDVE1gue9x86v3FOH2ukPG4d2/Xy
-            HevXjThtpMMsWFi0JYXuzXuV5HOvLZiP8sN3lSMCgYANpdxdGM7RRbE9ADY0dWK2
-            V14ReTLcxP7fyrWz0xLzEeCqmomzkz3BsIUoouu0DCTSw+rvAwExqcDoDylIVlWO
-            fAifz7SeZHbcDxo+3TsXK7zwnLYsx7YNs2+aIv6hzUUbMNmNmXMcZ+IEwx+mRMTN
-            lYmZdrA5mr0V83oDFPt/jQKBgC74RVE03pMlZiObFZNtheDiPKSG9Bz6wMh7NWMr
-            c37MtZLkg52mEFMTlfPLe6ceV37CM8WOhqe+dwSGrYhOU06dYqUR7VOZ1Qr0aZvo
-            fsNPu/Y0+u7rMkgv0fs1AXQnvz7kvKaF0YITVirfeXMafuKEtJoH7owRbur42cpV
-            YCAtAoGAP1rHOc+w0RUcBK3sY7aErrih0OPh9U5bvJsrw1C0FIZhCEoDVA+fNIQL
-            syHLXYFNy0OxMtH/bBAXBGNHd9gf5uOnqh0pYcbe/uRAxumC7Rl0cL509eURiA2T
-            +vFmf54y9YdnLXaqv+FhJT6B6V7WX7IpU9BMqJY1cJYXHuHG2KA=
-            -----END RSA PRIVATE KEY-----
-          EOM
-        end
-
-        it "knife raw /nodes/x should retrieve the node" do
-          knife("raw --listen /nodes/x").should_succeed( /"name": "x"/, stderr: local_listen_warning )
-        end
-      end
-    end
-
-    it "knife raw -z /nodes/x retrieves the node in socketless mode" do
-      Chef::Config.treat_deprecation_warnings_as_errors(true)
-      knife("raw -z /nodes/x").should_succeed( /"name": "x"/ )
-    end
-
-    it "knife raw -z /nodes/x retrieves the node" do
-      knife("raw -z --listen /nodes/x").should_succeed( /"name": "x"/, stderr: local_listen_warning )
-    end
-
-    it "knife raw --local-mode /nodes/x retrieves the node" do
-      knife("raw --local-mode --listen /nodes/x").should_succeed( /"name": "x"/, stderr: local_listen_warning )
-    end
-
-    it "knife raw -z --chef-zero-port=9999 /nodes/x retrieves the node" do
-      knife("raw -z --chef-zero-port=9999 --listen /nodes/x").should_succeed( /"name": "x"/, stderr: local_listen_warning )
-      expect(Chef::Config.chef_server_url).to eq("chefzero://localhost:9999")
-    end
-
-    context "when the default port (8889) is already bound" do
-      before :each do
-
-        @server = ChefZero::Server.new(host: "localhost", port: 8889)
-        @server.start_background
-      rescue Errno::EADDRINUSE
-        # OK.  Don't care who has it in use, as long as *someone* does.
-
-      end
-      after :each do
-        @server.stop if @server
-      end
-
-      it "knife raw -z /nodes/x retrieves the node" do
-        knife("raw -z --listen /nodes/x").should_succeed( /"name": "x"/, stderr: local_listen_warning )
-        expect(URI(Chef::Config.chef_server_url).port).to be > 8889
-      end
-    end
-
-    context "when port 9999 is already bound" do
-      before :each do
-
-        @server = ChefZero::Server.new(host: "localhost", port: 9999)
-        @server.start_background
-      rescue Errno::EADDRINUSE
-        # OK.  Don't care who has it in use, as long as *someone* does.
-
-      end
-      after :each do
-        @server.stop if @server
-      end
-
-      it "knife raw -z --chef-zero-port=9999-20000 /nodes/x" do
-        knife("raw -z --chef-zero-port=9999-20000 --listen /nodes/x").should_succeed( /"name": "x"/, stderr: local_listen_warning )
-        expect(URI(Chef::Config.chef_server_url).port).to be > 9999
-      end
-
-      it "knife raw -z --chef-zero-port=9999-9999,19423" do
-        knife("raw -z --chef-zero-port=9999-9999,19423 --listen /nodes/x").should_succeed( /"name": "x"/, stderr: local_listen_warning )
-        expect(URI(Chef::Config.chef_server_url).port).to be == 19423
-      end
-    end
-
-    it "knife raw -z --chef-zero-port=9999 /nodes/x retrieves the node" do
-      knife("raw -z --chef-zero-port=9999 --listen /nodes/x").should_succeed( /"name": "x"/, stderr: local_listen_warning )
-      expect(Chef::Config.chef_server_url).to eq("chefzero://localhost:9999")
-    end
-  end
-end