chef 15.17.4 → 16.0.257

data/spec/unit/resource/ohai_spec.rb

@@ -19,8 +19,11 @@
 require "spec_helper"
 
 describe Chef::Resource::Ohai do
-
-  let(:resource) { Chef::Resource::Ohai.new("fakey_fakerton") }
+  let(:node) { Chef::Node.new }
+  let(:events) { Chef::EventDispatch::Dispatcher.new }
+  let(:run_context) { Chef::RunContext.new(node, {}, events) }
+  let(:resource) { Chef::Resource::Ohai.new("fakey_fakerton", run_context) }
+  let(:provider) { resource.provider_for_action(:reload) }
 
   it "has a resource name of :ohai" do
     expect(resource.resource_name).to eql(:ohai)
@@ -55,4 +58,55 @@ describe Chef::Resource::Ohai do
     end
   end
 
+  describe "reload action" do
+    before(:each) do
+      # Copied from client_spec
+      @fqdn = "hostname.domainname"
+      @hostname = "hostname"
+      @platform = "example-platform"
+      @platform_version = "example-platform"
+      Chef::Config[:node_name] = @fqdn
+      mock_ohai = {
+        fqdn: @fqdn,
+        hostname: @hostname,
+        platform: @platform,
+        platform_version: @platform_version,
+        data: {
+          origdata: "somevalue",
+        },
+        data2: {
+          origdata: "somevalue",
+          newdata: "somevalue",
+        },
+      }
+      allow(mock_ohai).to receive(:all_plugins).and_return(true)
+      allow(mock_ohai).to receive(:data).and_return(mock_ohai[:data],
+        mock_ohai[:data2])
+      allow(Ohai::System).to receive(:new).and_return(mock_ohai)
+      allow(Chef::Platform).to receive(:find_platform_and_version).and_return({ "platform" => @platform,
+                                                                                "platform_version" => @platform_version })
+      # Fake node with a dummy save
+      node.name(@fqdn)
+      allow(node).to receive(:save).and_return(node)
+      ohai = Ohai::System.new
+      ohai.all_plugins
+      node.consume_external_attrs(ohai.data, {})
+      node.automatic_attrs[:origdata] = "somevalue"
+    end
+
+    it "applies updated ohai data to the node" do
+      expect(node[:origdata]).to eq("somevalue")
+      expect(node[:newdata]).to be_nil
+      provider.run_action(:reload)
+      expect(node[:origdata]).to eq("somevalue")
+      expect(node[:newdata]).to eq("somevalue")
+    end
+
+    it "supports reloading a specific plugin and causes node to pick up new values" do
+      resource.plugin "someplugin"
+      provider.run_action(:reload)
+      expect(node[:origdata]).to eq("somevalue")
+      expect(node[:newdata]).to eq("somevalue")
+    end
+  end
 end

data/spec/unit/resource/plist_spec.rb

@@ -0,0 +1,130 @@
+#
+# Author:: Tim Smith (<tsmith@chef.io>)
+# Copyright:: Copyright (c) Chef Software Inc.
+# Copyright:: 2017-2020, Microsoft Corporation
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::PlistResource do
+  let(:resource) { Chef::Resource::PlistResource.new("fakey_fakerton") }
+
+  it "sets the default action as :set" do
+    expect(resource.action).to eql([:set])
+  end
+
+  it "path is the name property" do
+    expect(resource.path).to eql("fakey_fakerton")
+  end
+
+  describe "#plistbuddy_command" do
+    it "the bool arguments contain the data type" do
+      expect(resource.plistbuddy_command(:add, "FooEntry", "path/to/file.plist", true)).to eq "/usr/libexec/PlistBuddy -c 'Add :\"FooEntry\" bool' \"path/to/file.plist\""
+    end
+
+    it "the add command only adds the data type" do
+      expect(resource.plistbuddy_command(:add, "QuuxEntry", "path/to/file.plist", 50)).to eq "/usr/libexec/PlistBuddy -c 'Add :\"QuuxEntry\" integer' \"path/to/file.plist\""
+    end
+
+    it "the delete command is formatted properly" do
+      expect(resource.plistbuddy_command(:delete, "BarEntry", "path/to/file.plist")).to eq "/usr/libexec/PlistBuddy -c 'Delete :\"BarEntry\"' \"path/to/file.plist\""
+    end
+
+    it "the set command is formatted properly" do
+      expect(resource.plistbuddy_command(:set, "BazEntry", "path/to/file.plist", false)).to eq "/usr/libexec/PlistBuddy -c 'Set :\"BazEntry\" false' \"path/to/file.plist\""
+    end
+
+    it "the print command is formatted properly" do
+      expect(resource.plistbuddy_command(:print, "QuxEntry", "path/to/file.plist")).to eq "/usr/libexec/PlistBuddy -c 'Print :\"QuxEntry\"' \"path/to/file.plist\""
+    end
+
+    it "the command to set a dictionary data type is formatted properly" do
+      expect(resource.plistbuddy_command(:set, "AppleFirstWeekday", "path/to/file.plist", gregorian: 4)).to eq "/usr/libexec/PlistBuddy -c 'Set :\"AppleFirstWeekday\":gregorian 4' \"path/to/file.plist\""
+    end
+
+    it "returns the value properly formatted with double quotes when the value has spaces" do
+      expect(resource.plistbuddy_command(:print, "Foo Bar Baz", "path/to/file.plist")).to eq "/usr/libexec/PlistBuddy -c 'Print :\"Foo Bar Baz\"' \"path/to/file.plist\""
+    end
+
+    it "returns the value properly formatted with double quotes when The value to be added contains spaces" do
+      expect(resource.plistbuddy_command(:add, "Foo Bar Baz", "path/to/file.plist", true)).to eq "/usr/libexec/PlistBuddy -c 'Add :\"Foo Bar Baz\" bool' \"path/to/file.plist\""
+    end
+
+    it "returns the value properly formatted with double quotes when the plist itself contains spaces" do
+      expect(resource.plistbuddy_command(:print, "Foo Bar Baz", "Library/Preferences/com.parallels.Parallels Desktop.plist")).to eq "/usr/libexec/PlistBuddy -c 'Print :\"Foo Bar Baz\"' \"Library/Preferences/com.parallels.Parallels Desktop.plist\""
+    end
+  end
+
+  describe "#convert_to_data_type_from_string" do
+    it "returns true if entry is 1 and the type is boolean" do
+      expect(resource.convert_to_data_type_from_string("boolean", "1")).to eq true
+    end
+
+    it "returns false if entry is 0 and the type is boolean" do
+      expect(resource.convert_to_data_type_from_string("boolean", "0")).to eq false
+    end
+
+    it "returns the value as an integer when the type is integer and the value is 1" do
+      expect(resource.convert_to_data_type_from_string("integer", "1")).to eq 1
+    end
+
+    it "returns the value as an integer when the type is integer and the value is 0" do
+      expect(resource.convert_to_data_type_from_string("integer", "0")).to eq 0
+    end
+
+    it "returns the correct value as an integer when the type is integer and the value is 950224" do
+      expect(resource.convert_to_data_type_from_string("integer", "950224")).to eq 950224
+    end
+
+    it "returns the correct value still as a string when the type is string and the value is also a string" do
+      expect(resource.convert_to_data_type_from_string("string", "corge")).to eq "corge"
+    end
+
+    it "returns the correct value as a float when the type is float and the value is 3.14159265359" do
+      expect(resource.convert_to_data_type_from_string("float", "3.14159265359")).to eq 3.14159265359
+    end
+
+    it "returns an empty string when the type nor the value is given" do
+      expect(resource.convert_to_data_type_from_string(nil, "")).to eq ""
+    end
+  end
+
+  describe "#type_to_commandline_string" do
+    it "returns the required boolean entry type as a string" do
+      expect(resource.type_to_commandline_string(true)).to eq "bool"
+    end
+
+    it "returns the required array entry type as a string" do
+      expect(resource.type_to_commandline_string(%w{foo bar})).to eq "array"
+    end
+
+    it "returns the required dictionary entry type as a string" do
+      expect(resource.type_to_commandline_string("baz" => "qux")).to eq "dict"
+    end
+
+    it "returns the required string entry type as a string" do
+      expect(resource.type_to_commandline_string("quux")).to eq "string"
+    end
+
+    it "returns the required integer entry type as a string" do
+      expect(resource.type_to_commandline_string(1)).to eq "integer"
+    end
+
+    it "returns the required float entry type as a string" do
+      expect(resource.type_to_commandline_string(1.0)).to eq "float"
+    end
+  end
+end

data/spec/unit/resource/powershell_script_spec.rb

@@ -47,11 +47,6 @@ describe Chef::Resource::PowershellScript do
     expect(@resource.convert_boolean_return).to eq(false)
   end
 
-  it "raises an error when architecture is i386 on Windows Nano Server" do
-    allow(Chef::Platform).to receive(:windows_nano_server?).and_return(true)
-    expect { @resource.architecture(:i386) }.to raise_error(Chef::Exceptions::Win32ArchitectureIncorrect, "cannot execute script with requested architecture 'i386' on Windows Nano Server")
-  end
-
   context "when using guards" do
     let(:resource) { @resource }
     before(:each) do

data/spec/unit/resource/{git_spec.rb → scm/git_spec.rb}

@@ -17,6 +17,7 @@
 #
 
 require "spec_helper"
+require_relative "scm"
 
 describe Chef::Resource::Git do
 
@@ -29,8 +30,55 @@ describe Chef::Resource::Git do
 
   let(:resource) { Chef::Resource::Git.new("fakey_fakerton") }
 
-  it "is a subclass of Chef::Resource::Scm" do
-    expect(resource).to be_a_kind_of(Chef::Resource::Scm)
+  it_behaves_like "an SCM resource"
+
+  it "takes the depth as an integer for shallow clones" do
+    resource.depth 5
+    expect(resource.depth).to eq(5)
+    expect { resource.depth "five" }.to raise_error(ArgumentError)
+  end
+
+  it "defaults to nil depth for a full clone" do
+    expect(resource.depth).to be_nil
+  end
+
+  it "takes a boolean for #enable_submodules" do
+    resource.enable_submodules true
+    expect(resource.enable_submodules).to be_truthy
+    expect { resource.enable_submodules "lolz" }.to raise_error(ArgumentError)
+  end
+
+  it "defaults to not enabling submodules" do
+    expect(resource.enable_submodules).to be_falsey
+  end
+
+  it "takes a boolean for #enable_checkout" do
+    resource.enable_checkout true
+    expect(resource.enable_checkout).to be_truthy
+    expect { resource.enable_checkout "lolz" }.to raise_error(ArgumentError)
+  end
+
+  it "defaults to enabling checkout" do
+    expect(resource.enable_checkout).to be_truthy
+  end
+
+  it "takes a string for the remote" do
+    resource.remote "opscode"
+    expect(resource.remote).to eql("opscode")
+    expect { resource.remote 1337 }.to raise_error(ArgumentError)
+  end
+
+  it "defaults to ``origin'' for the remote" do
+    expect(resource.remote).to eq("origin")
+  end
+
+  it "takes a string for the ssh wrapper" do
+    resource.ssh_wrapper "with_ssh_fu"
+    expect(resource.ssh_wrapper).to eql("with_ssh_fu")
+  end
+
+  it "defaults to nil for the ssh wrapper" do
+    expect(resource.ssh_wrapper).to be_nil
   end
 
   it "uses aliases revision as branch" do

data/spec/unit/resource/{scm_spec.rb → scm/scm.rb}

@@ -19,9 +19,7 @@
 
 require "spec_helper"
 
-describe Chef::Resource::Scm do
-  let(:resource) { Chef::Resource::Scm.new("fakey_fakerton") }
-
+shared_examples_for "an SCM resource" do
   it "the destination property is the name_property" do
     expect(resource.destination).to eql("fakey_fakerton")
   end
@@ -78,55 +76,6 @@ describe Chef::Resource::Scm do
     expect(resource.group).to eq(23)
   end
 
-  it "takes the depth as an integer for shallow clones" do
-    resource.depth 5
-    expect(resource.depth).to eq(5)
-    expect { resource.depth "five" }.to raise_error(ArgumentError)
-  end
-
-  it "defaults to nil depth for a full clone" do
-    expect(resource.depth).to be_nil
-  end
-
-  it "takes a boolean for #enable_submodules" do
-    resource.enable_submodules true
-    expect(resource.enable_submodules).to be_truthy
-    expect { resource.enable_submodules "lolz" }.to raise_error(ArgumentError)
-  end
-
-  it "defaults to not enabling submodules" do
-    expect(resource.enable_submodules).to be_falsey
-  end
-
-  it "takes a boolean for #enable_checkout" do
-    resource.enable_checkout true
-    expect(resource.enable_checkout).to be_truthy
-    expect { resource.enable_checkout "lolz" }.to raise_error(ArgumentError)
-  end
-
-  it "defaults to enabling checkout" do
-    expect(resource.enable_checkout).to be_truthy
-  end
-
-  it "takes a string for the remote" do
-    resource.remote "opscode"
-    expect(resource.remote).to eql("opscode")
-    expect { resource.remote 1337 }.to raise_error(ArgumentError)
-  end
-
-  it "defaults to ``origin'' for the remote" do
-    expect(resource.remote).to eq("origin")
-  end
-
-  it "takes a string for the ssh wrapper" do
-    resource.ssh_wrapper "with_ssh_fu"
-    expect(resource.ssh_wrapper).to eql("with_ssh_fu")
-  end
-
-  it "defaults to nil for the ssh wrapper" do
-    expect(resource.ssh_wrapper).to be_nil
-  end
-
   it "defaults to nil for the environment" do
     expect(resource.environment).to be_nil
   end

data/spec/unit/resource/{subversion_spec.rb → scm/subversion_spec.rb}

@@ -17,6 +17,7 @@
 #
 
 require "spec_helper"
+require_relative "scm"
 
 describe Chef::Resource::Subversion do
   static_provider_resolution(
@@ -28,9 +29,7 @@ describe Chef::Resource::Subversion do
 
   let(:resource) { Chef::Resource::Subversion.new("fakey_fakerton") }
 
-  it "is a subclass of Resource::Scm" do
-    expect(resource).to be_a_kind_of(Chef::Resource::Scm)
-  end
+  it_behaves_like "an SCM resource"
 
   it "the destination property is the name_property" do
     expect(resource.destination).to eql("fakey_fakerton")

data/spec/unit/resource/service_spec.rb

@@ -145,6 +145,10 @@ describe Chef::Resource::Service do
     expect(resource.timeout).to eql(1)
   end
 
+  it "defaults the timeout property to 900 (seconds)" do
+    expect(resource.timeout).to eql(900)
+  end
+
   %w{enabled running}.each do |prop|
     it "accepts true for #{prop} property" do
       resource.send(prop, true)

data/spec/unit/resource/user_spec.rb

@@ -21,8 +21,8 @@ require "spec_helper"
 describe Chef::Resource::User, "initialize" do
   let(:resource) { Chef::Resource::User.new("notarealuser") }
 
-  it "sets the resource_name to :user_resource_abstract_base_class" do
-    expect(resource.resource_name).to eql(:user_resource_abstract_base_class)
+  it "sets the resource_name to nil" do
+    expect(resource.resource_name).to eql(nil)
   end
 
   it "username property is the name property" do

data/spec/unit/resource/user_ulimit_spec.rb

@@ -0,0 +1,53 @@
+#
+# Author:: Tim Smith (<tsmith@chef.io>)
+# Copyright:: Copyright (c) Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::UserUlimit do
+  let(:node) { Chef::Node.new }
+  let(:events) { Chef::EventDispatch::Dispatcher.new }
+  let(:run_context) { Chef::RunContext.new(node, {}, events) }
+  let(:resource) { Chef::Resource::UserUlimit.new("fakey_fakerton", run_context) }
+
+  it "the username property is the name_property" do
+    expect(resource.username).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :create" do
+    expect(resource.action).to eql([:create])
+  end
+
+  it "coerces filename value to end in .conf" do
+    resource.filename("foo")
+    expect(resource.filename).to eql("foo.conf")
+  end
+
+  it "if username is * then the filename defaults to 00_all_limits.conf" do
+    resource.username("*")
+    expect(resource.filename).to eql("00_all_limits.conf")
+  end
+
+  it "if username is NOT * then the filename defaults to USERNAME_limits.conf" do
+    expect(resource.filename).to eql("fakey_fakerton_limits.conf")
+  end
+
+  it "supports :create and :delete actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :delete }.not_to raise_error
+  end
+end

data/spec/unit/resource/windows_dns_record_spec.rb

@@ -29,15 +29,15 @@ describe Chef::Resource::WindowsDnsRecord do
   end
 
   it "the record_type property accepts 'CNAME'" do
-    expect { resource.record_type "CNAME" }.not_to raise_error
+    expect { resource.record_type "CNAME" }.not_to raise_error(ArgumentError)
   end
 
   it "the record_type property accepts 'ARecord'" do
-    expect { resource.record_type "ARecord" }.not_to raise_error
+    expect { resource.record_type "ARecord" }.not_to raise_error(ArgumentError)
   end
 
   it "the record_type property accepts 'PTR'" do
-    expect { resource.record_type "PTR" }.not_to raise_error
+    expect { resource.record_type "PTR" }.not_to raise_error(ArgumentError)
   end
 
   it "the resource raises an ArgumentError if invalid record_type is set" do