chef 15.17.4 → 16.0.257

data/spec/unit/resource/chef_client_scheduled_task_spec.rb

@@ -0,0 +1,102 @@
+#
+# Author:: Tim Smith (<tsmith@chef.io>)
+# Copyright:: Copyright (c) Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::ChefClientScheduledTask do
+  let(:node) { Chef::Node.new }
+  let(:events) { Chef::EventDispatch::Dispatcher.new }
+  let(:run_context) { Chef::RunContext.new(node, {}, events) }
+  let(:resource) { Chef::Resource::ChefClientScheduledTask.new("fakey_fakerton", run_context) }
+  let(:provider) { resource.provider_for_action(:add) }
+
+  it "sets the default action as :add" do
+    expect(resource.action).to eql([:add])
+  end
+
+  it "coerces splay to an Integer" do
+    resource.splay "10"
+    expect(resource.splay).to eql(10)
+  end
+
+  it "raises an error if splay is not a positive number" do
+    expect { resource.splay("-10") }.to raise_error(Chef::Exceptions::ValidationFailed)
+  end
+
+  it "coerces frequency_modifier to an Integer" do
+    resource.frequency_modifier "10"
+    expect(resource.frequency_modifier).to eql(10)
+  end
+
+  it "validates the start_time property input" do
+    expect { resource.start_time("8:00 am") }.to raise_error(Chef::Exceptions::ValidationFailed)
+    expect { resource.start_time("8:00") }.to raise_error(Chef::Exceptions::ValidationFailed)
+    expect { resource.start_time("08:00") }.not_to raise_error(Chef::Exceptions::ValidationFailed)
+  end
+
+  it "validates the start_date property input" do
+    expect { resource.start_date("2/1/20") }.to raise_error(Chef::Exceptions::ValidationFailed)
+    expect { resource.start_date("02/01/20") }.to raise_error(Chef::Exceptions::ValidationFailed)
+    expect { resource.start_date("02/01/2020") }.not_to raise_error(Chef::Exceptions::ValidationFailed)
+  end
+
+  it "raises an error if frequency_modifier is not a positive number" do
+    expect { resource.frequency_modifier("-10") }.to raise_error(Chef::Exceptions::ValidationFailed)
+  end
+
+  it "builds a default value for chef_binary_path dist values" do
+    expect(resource.chef_binary_path).to eql("C:/opscode/chef/bin/chef-client")
+  end
+
+  it "supports :add and :remove actions" do
+    expect { resource.action :add }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+  end
+
+  describe "#client_cmd" do
+    it "creates a valid command if using all default properties" do
+      expect(provider.client_cmd).to eql("C:/opscode/chef/bin/chef-client -L /etc/chef/log/client.log -c /etc/chef/client.rb")
+    end
+
+    it "uses daemon_options if set" do
+      resource.daemon_options ["--foo 1", "--bar 2"]
+      expect(provider.client_cmd).to eql("C:/opscode/chef/bin/chef-client -L /etc/chef/log/client.log -c /etc/chef/client.rb --foo 1 --bar 2")
+    end
+
+    it "uses custom config dir if set" do
+      resource.config_directory "C:/foo/bar"
+      expect(provider.client_cmd).to eql("C:/opscode/chef/bin/chef-client -L C:/foo/bar/log/client.log -c C:/foo/bar/client.rb")
+    end
+
+    it "uses custom log files / paths if set" do
+      resource.log_file_name "my-client.log"
+      resource.log_directory "C:/foo/bar"
+      expect(provider.client_cmd).to eql("C:/opscode/chef/bin/chef-client -L C:/foo/bar/my-client.log -c /etc/chef/client.rb")
+    end
+
+    it "uses custom chef-client binary if set" do
+      resource.chef_binary_path "C:/foo/bar/chef-client"
+      expect(provider.client_cmd).to eql("C:/foo/bar/chef-client -L /etc/chef/log/client.log -c /etc/chef/client.rb")
+    end
+
+    it "sets the license acceptance flag if set" do
+      resource.accept_chef_license true
+      expect(provider.client_cmd).to eql("C:/opscode/chef/bin/chef-client -L /etc/chef/log/client.log -c /etc/chef/client.rb --chef-license accept")
+    end
+  end
+end

data/spec/unit/resource/chef_client_systemd_timer_spec.rb

@@ -0,0 +1,70 @@
+#
+# Author:: Tim Smith (<tsmith@chef.io>)
+# Copyright:: Copyright (c) Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::ChefClientSystemdTimer do
+  let(:node) { Chef::Node.new }
+  let(:events) { Chef::EventDispatch::Dispatcher.new }
+  let(:run_context) { Chef::RunContext.new(node, {}, events) }
+  let(:resource) { Chef::Resource::ChefClientSystemdTimer.new("fakey_fakerton", run_context) }
+  let(:provider) { resource.provider_for_action(:add) }
+
+  it "sets the default action as :add" do
+    expect(resource.action).to eql([:add])
+  end
+
+  it "user defaults to root" do
+    expect(resource.user).to eql("root")
+  end
+
+  it "builds a default value for chef_binary_path dist values" do
+    expect(resource.chef_binary_path).to eql("/opt/chef/bin/chef-client")
+  end
+
+  it "supports :add and :remove actions" do
+    expect { resource.action :add }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+  end
+
+  describe "#chef_client_cmd" do
+    it "creates a valid command if using all default properties" do
+      expect(provider.chef_client_cmd).to eql("/opt/chef/bin/chef-client -c /etc/chef/client.rb")
+    end
+
+    it "uses daemon_options if set" do
+      resource.daemon_options ["--foo 1", "--bar 2"]
+      expect(provider.chef_client_cmd).to eql("/opt/chef/bin/chef-client --foo 1 --bar 2 -c /etc/chef/client.rb")
+    end
+
+    it "uses custom config dir if set" do
+      resource.config_directory "/etc/some_other_dir"
+      expect(provider.chef_client_cmd).to eql("/opt/chef/bin/chef-client -c /etc/some_other_dir/client.rb")
+    end
+
+    it "uses custom chef-client binary if set" do
+      resource.chef_binary_path "/usr/local/bin/chef-client"
+      expect(provider.chef_client_cmd).to eql("/usr/local/bin/chef-client -c /etc/chef/client.rb")
+    end
+
+    it "sets the license acceptance flag if set" do
+      resource.accept_chef_license true
+      expect(provider.chef_client_cmd).to eql("/opt/chef/bin/chef-client --chef-license accept -c /etc/chef/client.rb")
+    end
+  end
+end

data/spec/unit/resource/chef_vault_secret_spec.rb

@@ -0,0 +1,40 @@
+#
+# Copyright:: Copyright (c) Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::ChefVaultSecret do
+  let(:resource) { Chef::Resource::ChefVaultSecret.new("foo") }
+
+  it "has a resource name of :chef_vault_secret" do
+    expect(resource.resource_name).to eql(:chef_vault_secret)
+  end
+
+  it "sets the default action as :create" do
+    expect(resource.action).to eql([:create])
+  end
+
+  it "id is the name property" do
+    expect(resource.id).to eql("foo")
+  end
+
+  it "supports :create, :create_if_missing, and :delete actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :create_if_missing }.not_to raise_error
+    expect { resource.action :delete }.not_to raise_error
+  end
+end

data/spec/unit/resource/chocolatey_source_spec.rb

@@ -49,9 +49,10 @@ describe Chef::Resource::ChocolateySource do
   before(:each) do
     disable_provider # vivify before mocking
     enable_provider
+    current_resource
     allow(resource).to receive(:provider_for_action).and_return(disable_provider)
     allow(resource).to receive(:provider_for_action).and_return(enable_provider)
-    allow(resource).to receive(:dup).and_return(current_resource)
+    allow(resource.class).to receive(:new).and_return(current_resource)
     @original_env = ENV.to_hash
     ENV["ALLUSERSPROFILE"] = 'C:\ProgramData'
   end

data/spec/unit/resource/cron_d_spec.rb

@@ -34,57 +34,15 @@ describe Chef::Resource::CronD do
     expect(resource.cron_name).to eql("cronify")
   end
 
-  context "#validate_dow" do
-    it "it accepts a string day" do
-      expect(Chef::Resource::CronD.validate_dow("mon")).to be true
-    end
-
-    it "it accepts an integer day" do
-      expect(Chef::Resource::CronD.validate_dow(0)).to be true
-    end
-
-    it "it accepts the string of *" do
-      expect(Chef::Resource::CronD.validate_dow("*")).to be true
-    end
-
-    it "returns false for an out of range integer" do
-      expect(Chef::Resource::CronD.validate_dow(8)).to be false
-    end
-
-    it "returns false for an invalid string" do
-      expect(Chef::Resource::CronD.validate_dow("monday")).to be false
-    end
+  it "the mode property defaults to '0600'" do
+    expect(resource.mode).to eql("0600")
   end
 
-  context "#validate_month" do
-    it "it accepts a string month" do
-      expect(Chef::Resource::CronD.validate_month("feb")).to be true
-    end
-
-    it "it accepts an integer month" do
-      expect(Chef::Resource::CronD.validate_month(2)).to be true
-    end
-
-    it "it accepts the string of *" do
-      expect(Chef::Resource::CronD.validate_month("*")).to be true
-    end
-
-    it "returns false for an out of range integer" do
-      expect(Chef::Resource::CronD.validate_month(13)).to be false
-    end
-
-    it "returns false for an invalid string" do
-      expect(Chef::Resource::CronD.validate_month("janurary")).to be false
-    end
+  it "the user property defaults to 'root'" do
+    expect(resource.user).to eql("root")
   end
 
-  context "#validate_numeric" do
-    it "returns true if the value is in the allowed range" do
-      expect(Chef::Resource::CronD.validate_numeric(5, 1, 100)).to be true
-    end
-
-    it "returns false if the value is out of the allowed range" do
-      expect(Chef::Resource::CronD.validate_numeric(-1, 1, 100)).to be false
-    end
+  it "the command property is required" do
+    expect { resource.command nil }.to raise_error(Chef::Exceptions::ValidationFailed)
   end
 end

data/spec/unit/resource/cron_spec.rb

@@ -115,19 +115,19 @@ describe Chef::Resource::Cron do
   end
 
   it "rejects any minute over 59" do
-    expect { resource.minute "60" }.to raise_error(RangeError)
+    expect { resource.minute "60" }.to raise_error(Chef::Exceptions::ValidationFailed)
   end
 
   it "rejects any hour over 23" do
-    expect { resource.hour "24" }.to raise_error(RangeError)
+    expect { resource.hour "24" }.to raise_error(Chef::Exceptions::ValidationFailed)
   end
 
   it "rejects any day over 31" do
-    expect { resource.day "32" }.to raise_error(RangeError)
+    expect { resource.day "32" }.to raise_error(Chef::Exceptions::ValidationFailed)
   end
 
   it "rejects any month over 12" do
-    expect { resource.month "13" }.to raise_error(RangeError)
+    expect { resource.month "13" }.to raise_error(Chef::Exceptions::ValidationFailed)
   end
 
   describe "weekday" do
@@ -139,12 +139,6 @@ describe Chef::Resource::Cron do
     end
   end
 
-  it "converts integer schedule values to a string" do
-    %w{minute hour day month weekday}.each do |x|
-      expect(resource.send(x, 5)).to eql("5")
-    end
-  end
-
   describe "when it has a time (minute, hour, day, month, weekend) and user" do
     before do
       resource.command("tackle")

data/spec/unit/resource/gem_package_spec.rb

@@ -53,11 +53,11 @@ describe Chef::Resource::GemPackage, "gem_binary" do
   end
 end
 
-describe Chef::Resource::GemPackage, "clear_gem_sources" do
+describe Chef::Resource::GemPackage, "clear_sources" do
   let(:resource) { Chef::Resource::GemPackage.new("foo") }
 
-  it "is false by default" do
-    expect(resource.clear_sources).to be false
+  it "is nil by default" do
+    expect(resource.clear_sources).to be_nil
   end
 
   it "sets the default of clear_sources to the config value" do

data/spec/unit/resource/helpers/cron_validations_spec.rb

@@ -0,0 +1,77 @@
+#
+# Copyright:: Copyright (c) Chef Software Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require "spec_helper"
+require "chef/resource/helpers/cron_validations"
+
+describe Chef::ResourceHelpers::CronValidations do
+  context "#validate_dow" do
+    it "it accepts a string day" do
+      expect(Chef::ResourceHelpers::CronValidations.validate_dow("mon")).to be true
+    end
+
+    it "it accepts an integer day" do
+      expect(Chef::ResourceHelpers::CronValidations.validate_dow(0)).to be true
+    end
+
+    it "it accepts the string of *" do
+      expect(Chef::ResourceHelpers::CronValidations.validate_dow("*")).to be true
+    end
+
+    it "returns false for an out of range integer" do
+      expect(Chef::ResourceHelpers::CronValidations.validate_dow(8)).to be false
+    end
+
+    it "returns false for an invalid string" do
+      expect(Chef::ResourceHelpers::CronValidations.validate_dow("monday")).to be false
+    end
+  end
+
+  context "#validate_month" do
+    it "it accepts a string month" do
+      expect(Chef::ResourceHelpers::CronValidations.validate_month("feb")).to be true
+    end
+
+    it "it accepts an integer month" do
+      expect(Chef::ResourceHelpers::CronValidations.validate_month(2)).to be true
+    end
+
+    it "it accepts the string of *" do
+      expect(Chef::ResourceHelpers::CronValidations.validate_month("*")).to be true
+    end
+
+    it "returns false for an out of range integer" do
+      expect(Chef::ResourceHelpers::CronValidations.validate_month(13)).to be false
+    end
+
+    it "returns false for an invalid string (typo)" do
+      expect(Chef::ResourceHelpers::CronValidations.validate_month("janurary")).to be false
+    end
+  end
+
+  context "#validate_numeric" do
+    it "returns true if the value is in the allowed range" do
+      expect(Chef::ResourceHelpers::CronValidations.validate_numeric(5, 1, 100)).to be true
+    end
+
+    it "returns false if the value less than the allowed range" do
+      expect(Chef::ResourceHelpers::CronValidations.validate_numeric(-1, 1, 100)).to be false
+    end
+
+    it "returns false if the value more than the allowed range" do
+      expect(Chef::ResourceHelpers::CronValidations.validate_numeric(101, 1, 100)).to be false
+    end
+  end
+end

data/spec/unit/resource/link_spec.rb

@@ -22,10 +22,6 @@ require "spec_helper"
 describe Chef::Resource::Link do
   let(:resource) { Chef::Resource::Link.new("fakey_fakerton") }
 
-  before(:each) do
-    expect_any_instance_of(Chef::Resource::Link).to receive(:verify_links_supported!).and_return(true)
-  end
-
   it "the target_file property is the name_property" do
     expect(resource.target_file).to eql("fakey_fakerton")
   end

data/spec/unit/resource/locale_spec.rb

@@ -186,38 +186,4 @@ describe Chef::Resource::Locale do
       end
     end
   end
-
-  describe "#up_to_date?" do
-    context "when file does not exists" do
-      it "returns false" do
-        allow(File).to receive(:read).and_raise(Errno::ENOENT, "No such file or directory")
-        expect(provider.up_to_date?).to be_falsy
-      end
-    end
-
-    context "when file exists" do
-      let(:content) { "LANG=en_US\nLC_MESSAGES=en_AG.utf8\nLC_TIME=en_AG.utf8\n" }
-      before do
-        allow(provider).to receive(:new_content).and_return(content)
-      end
-      context "but is empty" do
-        it "returns false" do
-          allow(File).to receive(:read).and_return("")
-          expect(provider.up_to_date?).to be_falsy
-        end
-      end
-      context "and contains old key-vals" do
-        it "returns false" do
-          allow(File).to receive(:read).and_return("LC_MESSAGES=en_AG.utf8\n")
-          expect(provider.up_to_date?).to be_falsy
-        end
-      end
-      context "and contains new key-vals" do
-        it "returns true" do
-          allow(File).to receive(:read).and_return(content)
-          expect(provider.up_to_date?).to be_truthy
-        end
-      end
-    end
-  end
 end