chef 14.5.33 → 14.6.47

data/spec/unit/provider/user/windows_spec.rb

@@ -53,7 +53,8 @@ describe Chef::Provider::User::Windows do
 
   describe "when comparing the user's current properties to the desired properties" do
     before do
-      @new_resource.comment   "Adam Jacob"
+      @new_resource.full_name "Adam Jacob"
+      @new_resource.comment   "Some comments"
       @new_resource.uid       1000
       @new_resource.gid       1000
       @new_resource.home      "/home/adam"
@@ -88,12 +89,16 @@ describe Chef::Provider::User::Windows do
         expect(@provider.set_options).not_to have_key(:password)
       end
 
+      it "doesn't set the full_name to be updated" do
+        expect(@provider.set_options).not_to have_key(:full_name)
+      end
     end
 
     describe "and the properties do not match" do
       before do
         @current_resource = Chef::Resource::User::WindowsUser.new("adam")
-        @current_resource.comment   "Adam Jacob-foo"
+        @current_resource.full_name "Adam Jacob-foo"
+        @current_resource.comment   "some comments"
         @current_resource.uid       1111
         @current_resource.gid       1111
         @current_resource.home      "/home/adam-foo"
@@ -102,8 +107,12 @@ describe Chef::Provider::User::Windows do
         @provider.current_resource = @current_resource
       end
 
+      it "marks the full_name field to be updated" do
+        expect(@provider.set_options[:full_name]).to eq("Adam Jacob")
+      end
+
       it "marks the comment field to be updated" do
-        expect(@provider.set_options[:comment]).to eq("Adam Jacob")
+        expect(@provider.set_options[:comment]).to eq("Some comments")
       end
 
       it "marks the home_dir property to be updated" do

data/spec/unit/provider/windows_task_spec.rb

@@ -416,6 +416,7 @@ describe Chef::Provider::WindowsTask, :windows_only do
     end
 
     it "return logon_type bindary value as 1 as if password is not nil" do
+      new_resource.user = "Administrator"
       new_resource.password = "abc"
       expect(provider.send(:logon_type)).to be(1)
     end

data/spec/unit/resource/timezone.rb

@@ -0,0 +1,39 @@
+#
+# Copyright:: Copyright 2018, Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::Timezone do
+  let(:resource) { Chef::Resource::Timezone.new("fakey_fakerton") }
+
+  it "sets resource name as :timezone" do
+    expect(resource.resource_name).to eql(:timezone)
+  end
+
+  it "the timezone property is the name_property" do
+    expect(resource.timezone).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :set" do
+    expect(resource.action).to eql([:set])
+  end
+
+  it "supports the :set action only" do
+    expect { resource.action :set }.not_to raise_error
+    expect { resource.action :unset }.to raise_error
+  end
+end

data/spec/unit/resource/windows_task_spec.rb

@@ -73,7 +73,7 @@ describe Chef::Resource::WindowsTask, :windows_only do
     end
     it "raises an error if the user is a non-system user" do
       resource.user "bob"
-      expect { resource.after_created }.to raise_error(ArgumentError, %q{Cannot specify a user other than the system users without specifying a password!. Valid passwordless users: 'NT AUTHORITY\SYSTEM', 'SYSTEM', 'NT AUTHORITY\LOCALSERVICE', 'NT AUTHORITY\NETWORKSERVICE', 'BUILTIN\USERS', 'USERS'})
+      expect { resource.after_created }.to raise_error(ArgumentError, %q{Cannot specify a user other than the system users without specifying a password!. Valid passwordless users: 'SYSTEM', 'NT AUTHORITY\SYSTEM', 'LOCAL SERVICE', 'NT AUTHORITY\LOCAL SERVICE', 'NETWORK SERVICE', 'NT AUTHORITY\NETWORK SERVICE', 'ADMINISTRATORS', 'BUILTIN\ADMINISTRATORS', 'USERS', 'BUILTIN\USERS', 'GUESTS', 'BUILTIN\GUESTS'})
     end
 
     it "does not raise an error if the user is a system user" do

data/spec/unit/resource_collection_spec.rb

@@ -1,7 +1,7 @@
 #
 # Author:: Adam Jacob (<adam@chef.io>)
 # Author:: Christopher Walters (<cw@chef.io>)
-# Copyright:: Copyright 2008-2017, Chef Software Inc.
+# Copyright:: Copyright 2008-2018, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

data/spec/unit/run_context/child_run_context_spec.rb

@@ -2,7 +2,7 @@
 # Author:: Adam Jacob (<adam@chef.io>)
 # Author:: Tim Hinderliter (<tim@chef.io>)
 # Author:: Christopher Walters (<cw@chef.io>)
-# Copyright:: Copyright 2008-2016, Chef Software Inc.
+# Copyright:: Copyright 2008-2018, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -55,8 +55,8 @@ describe Chef::RunContext::ChildRunContext do
         expect(child.resource_collection.object_id).not_to eq run_context.resource_collection.object_id
         f = Chef::Resource::File.new("hi", child)
         child.resource_collection.insert(f)
-        expect(child.resource_collection).to include f
-        expect(run_context.resource_collection).not_to include f
+        expect(child.resource_collection.include?(f)).to be true
+        expect(run_context.resource_collection.include?(f)).to be false
       end
 
       it "immediate_notification_collection is not the same as the parent" do

data/spec/unit/shell/shell_session_spec.rb

@@ -204,7 +204,7 @@ describe Shell::SoloLegacySession do
     allow(@session).to receive(:node_built?).and_return(true)
     kitteh = Chef::Resource::Cat.new("keyboard")
     @recipe.run_context.resource_collection << kitteh
-    expect(@session.resource_collection).to include(kitteh)
+    expect(@session.resource_collection.include?(kitteh)).to be true
   end
 
   it "returns definitions from its compilation object" do
@@ -224,7 +224,8 @@ describe Shell::SoloLegacySession do
     keyboard_cat = Chef::Resource::Cat.new("keyboard_cat")
     @recipe.run_context.resource_collection << keyboard_cat
     # @session.rebuild_collection
-    expect(@session.resource_collection).to include(kitteh_cat, keyboard_cat)
+    expect(@session.resource_collection.include?(kitteh_cat)).to be true
+    expect(@session.resource_collection.include?(keyboard_cat)).to be true
   end
 
   it "runs chef with a resource collection from the compiled cookbooks" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chef
 version: !ruby/object:Gem::Version
-  version: 14.5.33
+  version: 14.6.47
 platform: ruby
 authors:
 - Adam Jacob
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-22 00:00:00.000000000 Z
+date: 2018-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chef-config
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 14.5.33
+        version: 14.6.47
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 14.5.33
+        version: 14.6.47
 - !ruby/object:Gem::Dependency
   name: mixlib-cli
   requirement: !ruby/object:Gem::Requirement
@@ -312,20 +312,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: iso8601
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.11.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.11.0
 - !ruby/object:Gem::Dependency
   name: rspec-core
   requirement: !ruby/object:Gem::Requirement
@@ -333,9 +319,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.5'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -343,9 +326,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.5'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.8'
 - !ruby/object:Gem::Dependency
   name: rspec-expectations
   requirement: !ruby/object:Gem::Requirement
@@ -353,9 +333,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.5'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -363,9 +340,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.5'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.8'
 - !ruby/object:Gem::Dependency
   name: rspec-mocks
   requirement: !ruby/object:Gem::Requirement
@@ -373,9 +347,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.5'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -383,9 +354,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.5'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.8'
 - !ruby/object:Gem::Dependency
   name: rspec_junit_formatter
   requirement: !ruby/object:Gem::Requirement
@@ -497,15 +465,12 @@ executables:
 extensions: []
 extra_rdoc_files:
 - README.md
-- CONTRIBUTING.md
 - LICENSE
 files:
-- CONTRIBUTING.md
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
-- VERSION
 - bin/chef-apply
 - bin/chef-client
 - bin/chef-resource-inspector
@@ -514,10 +479,6 @@ files:
 - bin/knife
 - chef-universal-mingw32.gemspec
 - chef.gemspec
-- distro/powershell/chef/chef.psm1
-- distro/ruby_bin_folder/Chef.PowerShell.Wrapper.dll
-- distro/ruby_bin_folder/Chef.PowerShell.dll
-- distro/ruby_bin_folder/Newtonsoft.Json.dll
 - lib/chef.rb
 - lib/chef/api_client.rb
 - lib/chef/api_client/registration.rb
@@ -1257,6 +1218,7 @@ files:
 - lib/chef/resource/sysctl.rb
 - lib/chef/resource/systemd_unit.rb
 - lib/chef/resource/template.rb
+- lib/chef/resource/timezone.rb
 - lib/chef/resource/user.rb
 - lib/chef/resource/user/aix_user.rb
 - lib/chef/resource/user/dscl_user.rb
@@ -1762,6 +1724,20 @@ files:
 - spec/functional/assets/yumrepo/repodata/other.xml.gz
 - spec/functional/assets/yumrepo/repodata/primary.xml.gz
 - spec/functional/assets/yumrepo/repodata/repomd.xml
+- spec/functional/assets/zypprepo/chef_rpm-1.10-1.aarch64.rpm
+- spec/functional/assets/zypprepo/chef_rpm-1.10-1.i686.rpm
+- spec/functional/assets/zypprepo/chef_rpm-1.10-1.ppc64.rpm
+- spec/functional/assets/zypprepo/chef_rpm-1.10-1.ppc64le.rpm
+- spec/functional/assets/zypprepo/chef_rpm-1.10-1.s390x.rpm
+- spec/functional/assets/zypprepo/chef_rpm-1.10-1.src.rpm
+- spec/functional/assets/zypprepo/chef_rpm-1.10-1.x86_64.rpm
+- spec/functional/assets/zypprepo/chef_rpm-1.2-1.aarch64.rpm
+- spec/functional/assets/zypprepo/chef_rpm-1.2-1.i686.rpm
+- spec/functional/assets/zypprepo/chef_rpm-1.2-1.ppc64.rpm
+- spec/functional/assets/zypprepo/chef_rpm-1.2-1.ppc64le.rpm
+- spec/functional/assets/zypprepo/chef_rpm-1.2-1.s390x.rpm
+- spec/functional/assets/zypprepo/chef_rpm-1.2-1.src.rpm
+- spec/functional/assets/zypprepo/chef_rpm-1.2-1.x86_64.rpm
 - spec/functional/audit/rspec_formatter_spec.rb
 - spec/functional/audit/runner_spec.rb
 - spec/functional/dsl/reboot_pending_spec.rb
@@ -1822,6 +1798,7 @@ files:
 - spec/functional/resource/windows_service_spec.rb
 - spec/functional/resource/windows_task_spec.rb
 - spec/functional/resource/yum_package_spec.rb
+- spec/functional/resource/zypper_package_spec.rb
 - spec/functional/root_alias_spec.rb
 - spec/functional/run_lock_spec.rb
 - spec/functional/shell_spec.rb
@@ -2458,6 +2435,7 @@ files:
 - spec/unit/resource/sysctl_spec.rb
 - spec/unit/resource/systemd_unit_spec.rb
 - spec/unit/resource/template_spec.rb
+- spec/unit/resource/timezone.rb
 - spec/unit/resource/user_spec.rb
 - spec/unit/resource/windows_ad_join_spec.rb
 - spec/unit/resource/windows_auto_run_spec.rb

data/CONTRIBUTING.md

@@ -1,152 +0,0 @@
-# Contributing to Chef Projects
-
-We're glad you want to contribute to a Chef project! This document will help answer common questions you may have during your first contribution.
-
-## Submitting Issues
-
-Not every contribution comes in the form of code. Submitting, confirming, and triaging issues is an important task for any project. At Chef we use GitHub to track all project issues.
-
-If you are familiar with Chef and know the component that is causing you a problem, you can file an issue in the corresponding GitHub project. All of our Open Source Software can be found in our [Chef GitHub organization](https://github.com/chef/). All projects include GitHub issue templates to help gather information needed for a thorough review.
-
-We ask you not to submit security concerns via GitHub. For details on submitting potential security issues please see <https://www.chef.io/security/>
-
-In addition to GitHub issues, we also utilize a feedback site that helps our product team track and rank feature requests. If you have a feature request, this is an excellent place to start <https://www.chef.io/feedback/>
-
-## Contribution Process
-
-We have a 3 step process for contributions:
-
-1. Commit changes to a git branch, making sure to sign-off those changes for the [Developer Certificate of Origin](#developer-certification-of-origin-dco).
-2. Create a GitHub Pull Request for your change, following the instructions in the pull request template.
-3. Perform a [Code Review](#code-review-process) with the project maintainers on the pull request.
-
-### Pull Request Requirements
-
-Chef Projects are built to last. We strive to ensure high quality throughout the experience. In order to ensure this, we require that all pull requests to Chef projects meet these specifications:
-
-1. **Tests:** To ensure high quality code and protect against future regressions, we require all the code in Chef Projects to have at least unit test coverage. We use [RSpec](http://rspec.info/) for unit testing.
-2. **Green CI Tests:** We use [Travis CI](https://travis-ci.org/) and/or [AppVeyor](https://www.appveyor.com/) CI systems to test all pull requests. We require these test runs to succeed on every pull request before being merged.
-
-### Code Review Process
-
-Code review takes place in GitHub pull requests. See [this article](https://help.github.com/articles/about-pull-requests/) if you're not familiar with GitHub Pull Requests.
-
-Once you open a pull request, project maintainers will review your code and respond to your pull request with any feedback they might have. The process at this point is as follows:
-
-1. Two thumbs-up (:+1:) are required from project maintainers. See the master maintainers document for Chef projects at <https://github.com/chef/chef/blob/master/MAINTAINERS.md>.
-2. Your change will be merged into the project's `master` branch
-3. Our Expeditor bot will automatically update the project's changelog with your contribution. For projects such as Chef and Chef-DK the version will be automatically incremented and a build kicked off to the project's `current` channel.
-
-If you would like to learn about when your code will be available in a release of Chef, read more about [Chef Release Cycles](#release-cycles).
-
-### Developer Certification of Origin (DCO)
-
-Licensing is very important to open source projects. It helps ensure the software continues to be available under the terms that the author desired.
-
-Chef uses [the Apache 2.0 license](https://github.com/chef/chef/blob/master/LICENSE) to strike a balance between open contribution and allowing you to use the software however you would like to.
-
-The license tells you what rights you have that are provided by the copyright holder. It is important that the contributor fully understands what rights they are licensing and agrees to them. Sometimes the copyright holder isn't the contributor, such as when the contributor is doing work on behalf of a company.
-
-To make a good faith effort to ensure these criteria are met, Chef requires the Developer Certificate of Origin (DCO) process to be followed.
-
-The DCO is an attestation attached to every contribution made by every developer. In the commit message of the contribution, the developer simply adds a Signed-off-by statement and thereby agrees to the DCO, which you can find below or at <http://developercertificate.org/>.
-
-```
-Developer's Certificate of Origin 1.1
-
-By making a contribution to this project, I certify that:
-
-(a) The contribution was created in whole or in part by me and I
-    have the right to submit it under the open source license
-    indicated in the file; or
-
-(b) The contribution is based upon previous work that, to the
-    best of my knowledge, is covered under an appropriate open
-    source license and I have the right under that license to   
-    submit that work with modifications, whether created in whole
-    or in part by me, under the same open source license (unless
-    I am permitted to submit under a different license), as
-    Indicated in the file; or
-
-(c) The contribution was provided directly to me by some other
-    person who certified (a), (b) or (c) and I have not modified
-    it.
-
-(d) I understand and agree that this project and the contribution
-    are public and that a record of the contribution (including
-    all personal information I submit with it, including my
-    sign-off) is maintained indefinitely and may be redistributed
-    consistent with this project or the open source license(s)
-    involved.
-```
-
-For more information on the change see the Chef Blog post [Introducing Developer Certificate of Origin](https://blog.chef.io/2016/09/19/introducing-developer-certificate-of-origin/)
-
-#### DCO Sign-Off Methods
-
-The DCO requires a sign-off message in the following format appear on each commit in the pull request:
-
-```
-Signed-off-by: Julia Child <juliachild@chef.io>
-```
-
-The DCO text can either be manually added to your commit body, or you can add either **-s** or **--signoff** to your usual git commit commands. If you forget to add the sign-off you can also amend a previous commit with the sign-off by running **git commit --amend -s**. If you've pushed your changes to GitHub already you'll need to force push your branch after this with **git push -f**.
-
-### Chef Obvious Fix Policy
-
-Small contributions, such as fixing spelling errors, where the content is small enough to not be considered intellectual property, can be submitted without signing the contribution for the DCO.
-
-As a rule of thumb, changes are obvious fixes if they do not introduce any new functionality or creative thinking. Assuming the change does not affect functionality, some common obvious fix examples include the following:
-
-- Spelling / grammar fixes
-- Typo correction, white space and formatting changes
-- Comment clean up
-- Bug fixes that change default return values or error codes stored in constants
-- Adding logging messages or debugging output
-- Changes to 'metadata' files like Gemfile, .gitignore, build scripts, etc.
-- Moving source files from one directory or package to another
-
-**Whenever you invoke the "obvious fix" rule, please say so in your commit message:**
-
-```
-------------------------------------------------------------------------
-commit 370adb3f82d55d912b0cf9c1d1e99b132a8ed3b5
-Author: Julia Child <juliachild@chef.io>
-Date:   Wed Sep 18 11:44:40 2015 -0700
-
-  Fix typo in the README.
-
-  Obvious fix.
-
-------------------------------------------------------------------------
-```
-
-## Release Cycles
-
-Our primary shipping vehicle is operating system specific packages that includes all the requirements of Chef. The packages are built with our [Omnibus](https://github.com/chef/omnibus) packing project.
-
-We also release our software as gems to [Rubygems](https://rubygems.org/) but we strongly recommend using Chef packages since they are the only combination of native libraries & gems required by Chef that we test throughly.
-
-Our version numbering roughly follows [Semantic Versioning](http://semver.org/) standard. Our standard version numbers look like X.Y.Z which mean:
-
-- X is a major release, which may not be fully compatible with prior major releases
-- Y is a minor release, which adds both new features and bug fixes
-- Z is a patch release, which adds just bug fixes
-
-After shipping a release of Chef we bump the `Minor` version by one to start development of the next minor release. All merges to master trigger an increment of the `Patch` version, and a build through our internal testing pipeline. We do a `Minor` release approximately every month, which consist of shipping one of the already auto-incremented and tested `Patch` versions. For example after shiping 12.10.24, we incremented Chef to 12.11.0\. From there 18 commits where merged bringing the version to 12.11.18, which we shipped as an omnibus package.
-
-Announcements of releases are made to the [chef mailing list](https://discourse.chef.io/c/chef-release) when they are available and are mirrored to the #announcements channel on the [Chef Community Slack](https://community-slack.chef.io/).
-
-## Chef Community
-
-Chef is made possible by a strong community of developers and system administrators. If you have any questions or if you would like to get involved in the Chef community you can check out:
-
-- [Chef Mailing List](https://discourse.chef.io/)
-- [Chef Community Slack](https://community-slack.chef.io/)
-
-Also here are some additional pointers to some awesome Chef content:
-
-- [Chef Docs](https://docs.chef.io/)
-- [Learn Chef](https://learn.chef.io/)
-- [Chef Software Inc. Website](https://www.chef.io/)
-- [Chef Project Website](https://www.chef.sh/)