chef 14.5.33 → 14.6.47

data/lib/chef/provider/package.rb

@@ -361,9 +361,14 @@ class Chef
       #
       # By default, this function will use Gem::Version comparison. Subclasses can reimplement this method
       # for package-management system specific versions.
+      #
+      # (In other words, pull requests to introduce domain specific mangling of versions into this method
+      # will be closed -- that logic must go into the subclass -- we understand that this is far from perfect
+      # but it is a better default than outright buggy things like v1.to_f <=> v2.to_f)
+      #
       def version_compare(v1, v2)
-        gem_v1 = Gem::Version.new(v1)
-        gem_v2 = Gem::Version.new(v2)
+        gem_v1 = Gem::Version.new(v1.gsub(/\A\s*(#{Gem::Version::VERSION_PATTERN}).*/, '\1'))
+        gem_v2 = Gem::Version.new(v2.gsub(/\A\s*(#{Gem::Version::VERSION_PATTERN}).*/, '\1'))
 
         gem_v1 <=> gem_v2
       end
@@ -491,7 +496,7 @@ class Chef
                 elsif current_version.nil?
                   logger.trace("#{new_resource} has no existing installed version. Installing install #{candidate_version}")
                   target_version_array.push(candidate_version)
-                elsif version_compare(current_version, candidate_version) == 1 && !allow_downgrade
+                elsif !allow_downgrade && version_compare(current_version, candidate_version) == 1
                   logger.trace("#{new_resource} #{package_name} has installed version #{current_version}, which is newer than available version #{candidate_version}. Skipping...)")
                   target_version_array.push(nil)
                 else
@@ -666,7 +671,7 @@ class Chef
         if new_resource.respond_to?("allow_downgrade")
           new_resource.allow_downgrade
         else
-          false
+          true
         end
       end
 

data/lib/chef/provider/package/windows.rb

@@ -1,6 +1,6 @@
 #
 # Author:: Bryan McLellan <btm@loftninjas.org>
-# Copyright:: Copyright 2014-2016, Chef Software, Inc.
+# Copyright:: Copyright 2014-2018, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -54,6 +54,16 @@ class Chef
           @current_resource = Chef::Resource::WindowsPackage.new(new_resource.name)
           if downloadable_file_missing?
             logger.trace("We do not know the version of #{new_resource.source} because the file is not downloaded")
+            # FIXME: this label should not be used.  It could be set to nil.  Probably what should happen is that
+            # if the file hasn't been downloaded then load_current_resource must download the file here, and then
+            # the else clause to set current_resource.version can always be run.  Relying on a side-effect here
+            # produces at least less readable code, if not outright buggy...  (and I'm assuming that this isn't
+            # wholly just a bug -- since if we only need the package_name to determine if its installed then we
+            # need this, so I'm assuming we need to download the file to pull out the name in order to check
+            # the registry -- which it still feels like we get wrong in the sense we're forcing always downloading
+            # and then always installing(?) which violates idempotency -- and I'm having to think way too hard
+            # about this and would need to go surfing around the code to determine what actually happens, probably
+            # in every different package_provider...)
             current_resource.version(:unknown.to_s)
           else
             current_resource.version(package_provider.installed_version)
@@ -164,6 +174,18 @@ class Chef
         # this package provider does not support package arrays
         # However, There may be multiple versions for a single
         # package so the first element may be a nested array
+        #
+        # FIXME: this breaks the semantics of the superclass and needs to get unwound.  Since these package
+        # providers don't support multipackage they can't put multiple versions into this array.  The windows
+        # package managers need this in order to uninstall multiple installed version, and they should track
+        # that in something like an `uninstall_version_array` of their own.  The superclass does not implement
+        # this kind of feature.  Doing this here breaks LSP and will create bugs since the superclass will not
+        # expect it at all.  The `current_resource.version` also MUST NOT be an array if the package provider
+        # is not multipackage.  The existing implementation of package_provider.installed_version should probably
+        # be what `uninstall_version_array` is, and then that list should be sorted and last/first'd into the
+        # current_resource.version.  The current_version_array method was not intended to be overwritten by
+        # sublasses (but ruby provides no feature to block doing so -- it is already marked as private).
+        #
         def current_version_array
           [ current_resource.version ]
         end

data/lib/chef/provider/package/yum/yum_helper.py

@@ -125,8 +125,9 @@ def query(command):
     #   - in order to fix this, something would have to happen where getProvides was called first and
     #     then the result was searchNevra'd.  please be extremely careful if attempting to fix that
     #     since searchNevra does not support prco tuples.
-    if any(elem in command['provides'] for elem in r"<=>"):
-        # handles flags (<, >, =, etc) and versions, but no wildcareds 
+    if bool(re.search('\\s+', command['provides'])):
+        # handles flags (<, >, =, etc) and versions, but no wildcareds
+        # raises error for any invalid input like: 'FOO BAR BAZ' 
         pkgs = obj.getProvides(*string_to_prco_tuple(command['provides']))
     elif do_nevra:
         # now if we're given version or arch properties explicitly, then we do a SearchNevra.

data/lib/chef/provider/package/zypper.rb

@@ -109,7 +109,7 @@ class Chef
         end
 
         def install_package(name, version)
-          zypper_package("install", *options, "--auto-agree-with-licenses", allow_downgrade, name, version)
+          zypper_package("install", global_options, *options, "--auto-agree-with-licenses", allow_downgrade, name, version)
         end
 
         def upgrade_package(name, version)
@@ -118,19 +118,19 @@ class Chef
         end
 
         def remove_package(name, version)
-          zypper_package("remove", *options, name, version)
+          zypper_package("remove", global_options, *options, name, version)
         end
 
         def purge_package(name, version)
-          zypper_package("remove", *options, "--clean-deps", name, version)
+          zypper_package("remove", global_options, *options, "--clean-deps", name, version)
         end
 
         def lock_package(name, version)
-          zypper_package("addlock", *options, name, version)
+          zypper_package("addlock", global_options, *options, name, version)
         end
 
         def unlock_package(name, version)
-          zypper_package("removelock", *options, name, version)
+          zypper_package("removelock", global_options, *options, name, version)
         end
 
         private
@@ -141,12 +141,12 @@ class Chef
           end
         end
 
-        def zypper_package(command, *options, names, versions)
+        def zypper_package(command, global_options, *options, names, versions)
           zipped_names = zip(names, versions)
           if zypper_version < 1.0
-            shell_out!("zypper", gpg_checks, command, *options, "-y", names)
+            shell_out!("zypper", global_options, gpg_checks, command, *options, "-y", names)
           else
-            shell_out!("zypper", "--non-interactive", gpg_checks, command, *options, zipped_names)
+            shell_out!("zypper", global_options, "--non-interactive", gpg_checks, command, *options, zipped_names)
           end
         end
 
@@ -157,6 +157,10 @@ class Chef
         def allow_downgrade
           "--oldpackage" if new_resource.allow_downgrade
         end
+
+        def global_options
+          new_resource.global_options if new_resource.global_options
+        end
       end
     end
   end

data/lib/chef/provider/registry_key.rb

@@ -126,16 +126,22 @@ class Chef
               value[:data] = value[:data].to_i
             end
             unless current_value[:type] == value[:type] && current_value[:data] == value[:data]
-              converge_by_value = value
-              converge_by_value[:data] = "*sensitive value suppressed*" if new_resource.sensitive
+              converge_by_value = if new_resource.sensitive
+                                    value.merge(data: "*sensitive value suppressed*")
+                                  else
+                                    value
+                                  end
 
               converge_by("set value #{converge_by_value}") do
                 registry.set_value(new_resource.key, value)
               end
             end
           else
-            converge_by_value = value
-            converge_by_value[:data] = "*sensitive value suppressed*" if new_resource.sensitive
+            converge_by_value = if new_resource.sensitive
+                                  value.merge(data: "*sensitive value suppressed*")
+                                else
+                                  value
+                                end
 
             converge_by("set value #{converge_by_value}") do
               registry.set_value(new_resource.key, value)
@@ -152,8 +158,11 @@ class Chef
         end
         new_resource.unscrubbed_values.each do |value|
           unless @name_hash.key?(value[:name].downcase)
-            converge_by_value = value
-            converge_by_value[:data] = "*sensitive value suppressed*" if new_resource.sensitive
+            converge_by_value = if new_resource.sensitive
+                                  value.merge(data: "*sensitive value suppressed*")
+                                else
+                                  value
+                                end
 
             converge_by("create value #{converge_by_value}") do
               registry.set_value(new_resource.key, value)

data/lib/chef/provider/user/windows.rb

@@ -39,12 +39,12 @@ class Chef
             logger.warn("The 'gid' (or 'group') property is not implemented on the Windows platform. Please use the `members` property of the  'group' resource to assign a user to a group.")
           end
 
-          @current_resource = Chef::Resource::User.new(new_resource.name)
+          @current_resource = Chef::Resource::User::WindowsUser.new(new_resource.name)
           current_resource.username(new_resource.username)
           begin
             user_info = @net_user.get_info
-
             current_resource.uid(user_info[:user_id])
+            current_resource.full_name(user_info[:full_name])
             current_resource.comment(user_info[:comment])
             current_resource.home(user_info[:home_dir])
             current_resource.shell(user_info[:script_path])
@@ -67,7 +67,7 @@ class Chef
             logger.trace("#{new_resource} password has changed")
             return true
           end
-          [ :uid, :comment, :home, :shell ].any? do |user_attrib|
+          [ :uid, :comment, :home, :shell, :full_name ].any? do |user_attrib|
             !new_resource.send(user_attrib).nil? && new_resource.send(user_attrib) != current_resource.send(user_attrib)
           end
         end
@@ -100,6 +100,7 @@ class Chef
           opts = { name: new_resource.username }
 
           field_list = {
+            "full_name" => "full_name",
             "comment" => "comment",
             "home" => "home_dir",
             "uid" => "user_id",

data/lib/chef/provider/windows_task.rb

@@ -18,7 +18,7 @@
 
 require "chef/mixin/shell_out"
 require "rexml/document"
-require "iso8601"
+require "iso8601" if Chef::Platform.windows?
 require "chef/mixin/powershell_out"
 require "chef/provider"
 require "chef/util/path_helper"
@@ -570,7 +570,16 @@ class Chef
         def logon_type
           # Ref: https://msdn.microsoft.com/en-us/library/windows/desktop/aa383566(v=vs.85).aspx
           # if nothing is passed as logon_type the TASK_LOGON_SERVICE_ACCOUNT is getting set as default so using that for comparision.
-          new_resource.password.nil? ? TaskScheduler::TASK_LOGON_SERVICE_ACCOUNT : TaskScheduler::TASK_LOGON_PASSWORD
+          user_id = new_resource.user
+          if Chef::ReservedNames::Win32::Security::SID.service_account_user?(user_id)
+            TaskScheduler::TASK_LOGON_SERVICE_ACCOUNT
+          elsif Chef::ReservedNames::Win32::Security::SID.group_user?(user_id)
+            TaskScheduler::TASK_LOGON_GROUP
+          elsif !new_resource.password.to_s.empty? # password is present
+            TaskScheduler::TASK_LOGON_PASSWORD
+          else
+            TaskScheduler::TASK_LOGON_INTERACTIVE_TOKEN
+          end
         end
 
         # This method checks if task and command properties exist since those two are mandatory properties to create a schedules task.

data/lib/chef/resource.rb

@@ -682,7 +682,7 @@ class Chef
       Chef::JSONCompat.to_json(results, *a)
     end
 
-    def to_hash
+    def to_h
       # Grab all current state, then any other ivars (backcompat)
       result = {}
       self.class.state_properties.each do |p|
@@ -697,6 +697,8 @@ class Chef
       result
     end
 
+    alias_method :to_hash, :to_h
+
     def self.from_hash(o)
       resource = new(o["instance_vars"]["@name"])
       o["instance_vars"].each do |k, v|

data/lib/chef/resource/locale.rb

@@ -61,7 +61,7 @@ class Chef
           end
 
           execute "reload root's lang profile script" do
-            command "source source /etc/sysconfig/i18n; source /etc/profile.d/lang.sh"
+            command "source /etc/sysconfig/i18n; source /etc/profile.d/lang.sh"
             not_if { updated }
           end
         elsif ::File.exist?("/usr/sbin/update-locale")

data/lib/chef/resource/ohai_hint.rb

@@ -40,12 +40,12 @@ class Chef
       action :create do
         description "Create an Ohai hint file."
 
-        declare_resource(:directory, ::Ohai::Config.ohai.hints_path.first) do
+        directory ::Ohai::Config.ohai.hints_path.first do
           action :create
           recursive true
         end
 
-        declare_resource(:file, ohai_hint_file_path(new_resource.hint_name)) do
+        file ohai_hint_file_path(new_resource.hint_name) do
           action :create
           content format_content(new_resource.content)
         end
@@ -54,12 +54,12 @@ class Chef
       action :delete do
         description "Delete an Ohai hint file."
 
-        declare_resource(:file, ohai_hint_file_path(new_resource.hint_name)) do
+        file ohai_hint_file_path(new_resource.hint_name) do
           action :delete
           notifies :reload, ohai[reload ohai post hint removal]
         end
 
-        declare_resource(:ohai, "reload ohai post hint removal") do
+        ohai "reload ohai post hint removal" do
           action :nothing
         end
       end

data/lib/chef/resource/rhsm_errata_level.rb

@@ -33,7 +33,7 @@ class Chef
                name_property: true
 
       action :install do
-        descripton "Install all packages of the specified errata level."
+        description "Install all packages of the specified errata level."
 
         yum_package "yum-plugin-security" do
           action :install

data/lib/chef/resource/timezone.rb

@@ -0,0 +1,91 @@
+#
+# Author:: Kirill Kouznetsov <agon.smith@gmail.com>
+#
+# Copyright 2018, Kirill Kouznetsov.
+# Copyright 2018, Chef Software, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "chef/resource"
+
+class Chef
+  class Resource
+    class Timezone < Chef::Resource
+      preview_resource true
+      resource_name :timezone
+
+      description "Use the timezone resource to change the system timezone."
+      introduced "14.6"
+
+      property :timezone, String,
+               description: "The timezone value to set.",
+               name_property: true
+
+      action :set do
+        description "Set the timezone."
+
+        package "tzdata" do
+          package_name platform_family?("suse") ? "timezone" : "tzdata"
+        end
+
+        if node["init_package"] == "systemd"
+          # Modern Amazon, Fedora, CentOS, RHEL, Ubuntu & Debian
+          cmd_set_tz = "/usr/bin/timedatectl --no-ask-password set-timezone #{new_resource.timezone}"
+
+          cmd_check_if_set = "/usr/bin/timedatectl status"
+          cmd_check_if_set += " | /usr/bin/awk '/Time.*zone/{print}'"
+          cmd_check_if_set += " | grep -q #{new_resource.timezone}"
+
+          execute cmd_set_tz do
+            action :run
+            not_if cmd_check_if_set
+          end
+        elsif platform_family?("rhel", "amazon")
+          # Old version of RHEL & CentOS
+          file "/etc/sysconfig/clock" do
+            owner "root"
+            group "root"
+            mode "0644"
+            action :create
+            content %{ZONE="#{new_resource.timezone}"\nUTC="true"\n}
+          end
+
+          execute "tzdata-update" do
+            command "/usr/sbin/tzdata-update"
+            action :nothing
+            only_if { ::File.executable?("/usr/sbin/tzdata-update") }
+            subscribes :run, "file[/etc/sysconfig/clock]", :immediately
+          end
+
+          link "/etc/localtime" do
+            to "/usr/share/zoneinfo/#{new_resource.timezone}"
+            not_if { ::File.executable?("/usr/sbin/tzdata-update") }
+          end
+        elsif platform_family?("debian")
+          file "/etc/timezone" do
+            action :create
+            content "#{new_resource.timezone}\n"
+          end
+
+          bash "dpkg-reconfigure tzdata" do
+            user "root"
+            code "/usr/sbin/dpkg-reconfigure -f noninteractive tzdata"
+            action :nothing
+            subscribes :run, "file[/etc/timezone]", :immediately
+          end
+        end
+      end
+    end
+  end
+end

data/lib/chef/resource/user/windows_user.rb

@@ -25,6 +25,10 @@ class Chef
 
         provides :windows_user
         provides :user, os: "windows"
+
+        property :full_name, String,
+                  description: "The full name of the user.",
+                  introduced: "14.6"
       end
     end
   end

data/lib/chef/resource/windows_task.rb

@@ -17,318 +17,320 @@
 #
 
 require "chef/resource"
+require "chef/win32/security" if Chef::Platform.windows?
 
 class Chef
   class Resource
     class WindowsTask < Chef::Resource
-      resource_name :windows_task
-      provides(:windows_task) { true }
+      if Chef::Platform.windows?
+        resource_name :windows_task
+        provides(:windows_task) { true }
 
-      description "Use the windows_task resource to create, delete or run a Windows scheduled task. Requires Windows Server 2008 or later due to API usage."
-      introduced "13.0"
+        description "Use the windows_task resource to create, delete or run a Windows scheduled task. Requires Windows Server 2008 or later due to API usage."
+        introduced "13.0"
 
-      allowed_actions :create, :delete, :run, :end, :enable, :disable, :change
-      default_action :create
+        allowed_actions :create, :delete, :run, :end, :enable, :disable, :change
+        default_action :create
 
-      property :task_name, String, regex: [/\A[^\/\:\*\?\<\>\|]+\z/],
-               description: "The task name, such as 'Task Name' or '/Task Name'",
-               name_property: true
+        property :task_name, String, regex: [/\A[^\/\:\*\?\<\>\|]+\z/],
+                 description: "The task name, such as 'Task Name' or '/Task Name'",
+                 name_property: true
 
-      property :command, String,
-               description: "The command to be executed by the windows scheduled task."
+        property :command, String,
+                 description: "The command to be executed by the windows scheduled task."
 
-      property :cwd, String,
-               description: "The directory the task will be run from."
+        property :cwd, String,
+                 description: "The directory the task will be run from."
 
-      property :user, String,
-               description: "The user to run the task as.",
-               default: "SYSTEM"
+        property :user, String,
+                 description: "The user to run the task as.",
+                 default: Chef::ReservedNames::Win32::Security::SID.LocalSystem.account_simple_name
 
-      property :password, String,
-               description: "The user’s password. The user property must be set if using this property."
+        property :password, String,
+                 description: "The user’s password. The user property must be set if using this property."
 
-      property :run_level, Symbol, equal_to: [:highest, :limited],
-               description: "Run with ':limited' or ':highest' privileges.",
-               default: :limited
+        property :run_level, Symbol, equal_to: [:highest, :limited],
+                 description: "Run with ':limited' or ':highest' privileges.",
+                 default: :limited
 
-      property :force, [TrueClass, FalseClass],
-               description: "When used with create, will update the task.",
-               default: false
+        property :force, [TrueClass, FalseClass],
+                 description: "When used with create, will update the task.",
+                 default: false
 
-      property :interactive_enabled, [TrueClass, FalseClass],
-               description: "Allow task to run interactively or non-interactively. Requires user and password to also be set.",
-               default: false
+        property :interactive_enabled, [TrueClass, FalseClass],
+                 description: "Allow task to run interactively or non-interactively. Requires user and password to also be set.",
+                 default: false
 
-      property :frequency_modifier, [Integer, String],
-               default: 1
+        property :frequency_modifier, [Integer, String],
+                 default: 1
 
-      property :frequency, Symbol, equal_to: [:minute,
-                                              :hourly,
-                                              :daily,
-                                              :weekly,
-                                              :monthly,
-                                              :once,
-                                              :on_logon,
-                                              :onstart,
-                                              :on_idle,
-                                              :none],
-               description: "The frequency with which to run the task."
+        property :frequency, Symbol, equal_to: [:minute,
+                                                :hourly,
+                                                :daily,
+                                                :weekly,
+                                                :monthly,
+                                                :once,
+                                                :on_logon,
+                                                :onstart,
+                                                :on_idle,
+                                                :none],
+                 description: "The frequency with which to run the task."
 
-      property :start_day, String,
-               description: "Specifies the first date on which the task runs in MM/DD/YYYY format."
+        property :start_day, String,
+                 description: "Specifies the first date on which the task runs in MM/DD/YYYY format."
 
-      property :start_time, String,
-               description: "Specifies the start time to run the task, in HH:mm format."
+        property :start_time, String,
+                 description: "Specifies the start time to run the task, in HH:mm format."
 
-      property :day, [String, Integer],
-               description: "The day(s) on which the task runs."
+        property :day, [String, Integer],
+                 description: "The day(s) on which the task runs."
 
-      property :months, String,
-               description: "The Months of the year on which the task runs, such as: 'JAN, FEB' or '\*'. Multiple months should be comma delimited. e.g. 'Jan, Feb, Mar, Dec'."
+        property :months, String,
+                 description: "The Months of the year on which the task runs, such as: 'JAN, FEB' or '\*'. Multiple months should be comma delimited. e.g. 'Jan, Feb, Mar, Dec'."
 
-      property :idle_time, Integer,
-               description: "For :on_idle frequency, the time (in minutes) without user activity that must pass to trigger the task, from 1 - 999."
+        property :idle_time, Integer,
+                 description: "For :on_idle frequency, the time (in minutes) without user activity that must pass to trigger the task, from 1 - 999."
 
-      property :random_delay, [String, Integer],
-               description: "Delays the task up to a given time (in seconds)."
+        property :random_delay, [String, Integer],
+                 description: "Delays the task up to a given time (in seconds)."
 
-      property :execution_time_limit, [String, Integer],
-               description: "The maximum time (in seconds) the task will run.",
-               default: "PT72H" # 72 hours in ISO8601 duration format
+        property :execution_time_limit, [String, Integer],
+                 description: "The maximum time (in seconds) the task will run.",
+                 default: "PT72H" # 72 hours in ISO8601 duration format
 
-      property :minutes_duration, [String, Integer],
-               description: ""
+        property :minutes_duration, [String, Integer],
+                 description: ""
 
-      property :minutes_interval, [String, Integer],
-               description: ""
+        property :minutes_interval, [String, Integer],
+                 description: ""
 
-      property :priority, Integer,
-               description: "Use to set Priority Levels range from 0 to 10.",
-               default: 7, callbacks: { "should be in range of 0 to 10" => proc { |v| v >= 0 && v <= 10 } }
+        property :priority, Integer,
+                 description: "Use to set Priority Levels range from 0 to 10.",
+                 default: 7, callbacks: { "should be in range of 0 to 10" => proc { |v| v >= 0 && v <= 10 } }
 
-      property :disallow_start_if_on_batteries, [TrueClass, FalseClass],
-               introduced: "14.4", default: false,
-               description: "Disallow start of the task if the system is running on battery power."
+        property :disallow_start_if_on_batteries, [TrueClass, FalseClass],
+                 introduced: "14.4", default: false,
+                 description: "Disallow start of the task if the system is running on battery power."
 
-      property :stop_if_going_on_batteries, [TrueClass, FalseClass],
-               introduced: "14.4", default: false,
-               description: "Scheduled task option when system is switching on battery."
+        property :stop_if_going_on_batteries, [TrueClass, FalseClass],
+                 introduced: "14.4", default: false,
+                 description: "Scheduled task option when system is switching on battery."
 
-      attr_accessor :exists, :task, :command_arguments
+        attr_accessor :exists, :task, :command_arguments
 
-      SYSTEM_USERS = ['NT AUTHORITY\SYSTEM', "SYSTEM", 'NT AUTHORITY\LOCALSERVICE', 'NT AUTHORITY\NETWORKSERVICE', 'BUILTIN\USERS', "USERS"].freeze
-      VALID_WEEK_DAYS = %w{ mon tue wed thu fri sat sun * }.freeze
-      VALID_DAYS_OF_MONTH = ("1".."31").to_a << "last" << "lastday"
-      VALID_MONTHS = %w{JAN FEB MAR APR MAY JUN JUL AUG SEP OCT NOV DEC *}.freeze
-      VALID_WEEKS = %w{FIRST SECOND THIRD FOURTH LAST LASTDAY}.freeze
+        VALID_WEEK_DAYS = %w{ mon tue wed thu fri sat sun * }.freeze
+        VALID_DAYS_OF_MONTH = ("1".."31").to_a << "last" << "lastday"
+        VALID_MONTHS = %w{JAN FEB MAR APR MAY JUN JUL AUG SEP OCT NOV DEC *}.freeze
+        VALID_WEEKS = %w{FIRST SECOND THIRD FOURTH LAST LASTDAY}.freeze
 
-      def after_created
-        if random_delay
-          validate_random_delay(random_delay, frequency)
-          random_delay(sec_to_min(random_delay))
-        end
+        def after_created
+          if random_delay
+            validate_random_delay(random_delay, frequency)
+            random_delay(sec_to_min(random_delay))
+          end
 
-        if execution_time_limit
-          execution_time_limit(259200) if execution_time_limit == "PT72H"
-          raise ArgumentError, "Invalid value passed for `execution_time_limit`. Please pass seconds as an Integer (e.g. 60) or a String with numeric values only (e.g. '60')." unless numeric_value_in_string?(execution_time_limit)
-          execution_time_limit(sec_to_min(execution_time_limit))
-        end
+          if execution_time_limit
+            execution_time_limit(259200) if execution_time_limit == "PT72H"
+            raise ArgumentError, "Invalid value passed for `execution_time_limit`. Please pass seconds as an Integer (e.g. 60) or a String with numeric values only (e.g. '60')." unless numeric_value_in_string?(execution_time_limit)
+            execution_time_limit(sec_to_min(execution_time_limit))
+          end
 
-        validate_frequency(frequency) if action.include?(:create) || action.include?(:change)
-        validate_start_time(start_time, frequency)
-        validate_start_day(start_day, frequency) if start_day
-        validate_user_and_password(user, password)
-        validate_interactive_setting(interactive_enabled, password)
-        validate_create_frequency_modifier(frequency, frequency_modifier) if frequency_modifier
-        validate_create_day(day, frequency, frequency_modifier) if day
-        validate_create_months(months, frequency) if months
-        validate_frequency_monthly(frequency_modifier, months, day) if frequency == :monthly
-        validate_idle_time(idle_time, frequency)
-        idempotency_warning_for_frequency_weekly(day, start_day) if frequency == :weekly
-      end
+          validate_frequency(frequency) if action.include?(:create) || action.include?(:change)
+          validate_start_time(start_time, frequency)
+          validate_start_day(start_day, frequency) if start_day
+          validate_user_and_password(user, password)
+          validate_interactive_setting(interactive_enabled, password)
+          validate_create_frequency_modifier(frequency, frequency_modifier) if frequency_modifier
+          validate_create_day(day, frequency, frequency_modifier) if day
+          validate_create_months(months, frequency) if months
+          validate_frequency_monthly(frequency_modifier, months, day) if frequency == :monthly
+          validate_idle_time(idle_time, frequency)
+          idempotency_warning_for_frequency_weekly(day, start_day) if frequency == :weekly
+        end
 
-      private
+        private
 
-      ## Resource is not idempotent when day, start_day is not provided with frequency :weekly
-      ## we set start_day when not given by user as current date based on which we set the day property for current current date day is monday ..
-      ## we set the monday as the day so at next run when  new_resource.day is nil and current_resource day is monday due to which udpate gets called
-      def idempotency_warning_for_frequency_weekly(day, start_day)
-        if start_day.nil? && day.nil?
-          logger.warn "To maintain idempotency for frequency :weekly provide start_day, start_time and day."
+        ## Resource is not idempotent when day, start_day is not provided with frequency :weekly
+        ## we set start_day when not given by user as current date based on which we set the day property for current current date day is monday ..
+        ## we set the monday as the day so at next run when  new_resource.day is nil and current_resource day is monday due to which udpate gets called
+        def idempotency_warning_for_frequency_weekly(day, start_day)
+          if start_day.nil? && day.nil?
+            logger.warn "To maintain idempotency for frequency :weekly provide start_day, start_time and day."
+          end
         end
-      end
 
-      # Validate the passed value is numeric values only if it is a string
-      def numeric_value_in_string?(val)
-        return true if Integer(val)
-      rescue ArgumentError
-        false
-      end
+        # Validate the passed value is numeric values only if it is a string
+        def numeric_value_in_string?(val)
+          return true if Integer(val)
+        rescue ArgumentError
+          false
+        end
 
-      def validate_frequency(frequency)
-        if frequency.nil? || !([:minute, :hourly, :daily, :weekly, :monthly, :once, :on_logon, :onstart, :on_idle, :none].include?(frequency))
-          raise ArgumentError, "Frequency needs to be provided. Valid frequencies are :minute, :hourly, :daily, :weekly, :monthly, :once, :on_logon, :onstart, :on_idle, :none."
+        def validate_frequency(frequency)
+          if frequency.nil? || !([:minute, :hourly, :daily, :weekly, :monthly, :once, :on_logon, :onstart, :on_idle, :none].include?(frequency))
+            raise ArgumentError, "Frequency needs to be provided. Valid frequencies are :minute, :hourly, :daily, :weekly, :monthly, :once, :on_logon, :onstart, :on_idle, :none."
+          end
         end
-      end
 
-      def validate_frequency_monthly(frequency_modifier, months, day)
-        # validates the frequency :monthly and raises error if frequency_modifier is first, second, thrid etc and day is not provided
-        if (frequency_modifier != 1) && (frequency_modifier_includes_days_of_weeks?(frequency_modifier)) && !(day)
-          raise ArgumentError, "Please select day on which you want to run the task e.g. 'Mon, Tue'. Multiple values must be seprated by comma."
+        def validate_frequency_monthly(frequency_modifier, months, day)
+          # validates the frequency :monthly and raises error if frequency_modifier is first, second, thrid etc and day is not provided
+          if (frequency_modifier != 1) && (frequency_modifier_includes_days_of_weeks?(frequency_modifier)) && !(day)
+            raise ArgumentError, "Please select day on which you want to run the task e.g. 'Mon, Tue'. Multiple values must be seprated by comma."
+          end
+
+          # frequency_modifer 2-12 is used to set every (n) months, so using :months propety with frequency_modifer is not valid since they both used to set months.
+          # Not checking value 1 here for frequecy_modifier since we are setting that as default value it won't break anything since preference is given to months property
+          if (frequency_modifier.to_i.between?(2, 12)) && !(months.nil?)
+            raise ArgumentError, "For frequency :monthly either use property months or frequency_modifier to set months."
+          end
         end
 
-        # frequency_modifer 2-12 is used to set every (n) months, so using :months propety with frequency_modifer is not valid since they both used to set months.
-        # Not checking value 1 here for frequecy_modifier since we are setting that as default value it won't break anything since preference is given to months property
-        if (frequency_modifier.to_i.between?(2, 12)) && !(months.nil?)
-          raise ArgumentError, "For frequency :monthly either use property months or frequency_modifier to set months."
+        # returns true if frequency_modifer has values First, second, third, fourth, last, lastday
+        def frequency_modifier_includes_days_of_weeks?(frequency_modifier)
+          frequency_modifier = frequency_modifier.to_s.split(",")
+          frequency_modifier.map! { |value| value.strip.upcase }
+          (frequency_modifier - VALID_WEEKS).empty?
         end
-      end
 
-      # returns true if frequency_modifer has values First, second, third, fourth, last, lastday
-      def frequency_modifier_includes_days_of_weeks?(frequency_modifier)
-        frequency_modifier = frequency_modifier.to_s.split(",")
-        frequency_modifier.map! { |value| value.strip.upcase }
-        (frequency_modifier - VALID_WEEKS).empty?
-      end
+        def validate_random_delay(random_delay, frequency)
+          if [:on_logon, :onstart, :on_idle, :none].include? frequency
+            raise ArgumentError, "`random_delay` property is supported only for frequency :once, :minute, :hourly, :daily, :weekly and :monthly"
+          end
 
-      def validate_random_delay(random_delay, frequency)
-        if [:on_logon, :onstart, :on_idle, :none].include? frequency
-          raise ArgumentError, "`random_delay` property is supported only for frequency :once, :minute, :hourly, :daily, :weekly and :monthly"
+          raise ArgumentError, "Invalid value passed for `random_delay`. Please pass seconds as an Integer (e.g. 60) or a String with numeric values only (e.g. '60')." unless numeric_value_in_string?(random_delay)
         end
 
-        raise ArgumentError, "Invalid value passed for `random_delay`. Please pass seconds as an Integer (e.g. 60) or a String with numeric values only (e.g. '60')." unless numeric_value_in_string?(random_delay)
-      end
+        # @todo when we drop ruby 2.3 support this should be converted to .match?() instead of =~f
+        def validate_start_day(start_day, frequency)
+          if start_day && frequency == :none
+            raise ArgumentError, "`start_day` property is not supported with frequency: #{frequency}"
+          end
 
-      # @todo when we drop ruby 2.3 support this should be converted to .match?() instead of =~f
-      def validate_start_day(start_day, frequency)
-        if start_day && frequency == :none
-          raise ArgumentError, "`start_day` property is not supported with frequency: #{frequency}"
+          # make sure the start_day is in MM/DD/YYYY format: http://rubular.com/r/cgjHemtWl5
+          if start_day
+            raise ArgumentError, "`start_day` property must be in the MM/DD/YYYY format." unless /^(0[1-9]|1[012])[- \/.](0[1-9]|[12][0-9]|3[01])[- \/.](19|20)\d\d$/ =~ start_day
+          end
         end
 
-        # make sure the start_day is in MM/DD/YYYY format: http://rubular.com/r/cgjHemtWl5
-        if start_day
-          raise ArgumentError, "`start_day` property must be in the MM/DD/YYYY format." unless /^(0[1-9]|1[012])[- \/.](0[1-9]|[12][0-9]|3[01])[- \/.](19|20)\d\d$/ =~ start_day
+        # @todo when we drop ruby 2.3 support this should be converted to .match?() instead of =~
+        def validate_start_time(start_time, frequency)
+          if start_time
+            raise ArgumentError, "`start_time` property is not supported with `frequency :none`" if frequency == :none
+            raise ArgumentError, "`start_time` property must be in the HH:mm format (e.g. 6:20pm -> 18:20)." unless /^[0-2][0-9]:[0-5][0-9]$/ =~ start_time
+          else
+            raise ArgumentError, "`start_time` needs to be provided with `frequency :once`" if frequency == :once
+          end
         end
-      end
 
-      # @todo when we drop ruby 2.3 support this should be converted to .match?() instead of =~
-      def validate_start_time(start_time, frequency)
-        if start_time
-          raise ArgumentError, "`start_time` property is not supported with `frequency :none`" if frequency == :none
-          raise ArgumentError, "`start_time` property must be in the HH:mm format (e.g. 6:20pm -> 18:20)." unless /^[0-2][0-9]:[0-5][0-9]$/ =~ start_time
-        else
-          raise ArgumentError, "`start_time` needs to be provided with `frequency :once`" if frequency == :once
+        def validate_user_and_password(user, password)
+          if password_required?(user) && password.nil?
+            raise ArgumentError, "Cannot specify a user other than the system users without specifying a password!. Valid passwordless users: '#{Chef::ReservedNames::Win32::Security::SID::SYSTEM_USER.join("', '")}'"
+          end
         end
-      end
 
-      def validate_user_and_password(user, password)
-        if password_required?(user) && password.nil?
-          raise ArgumentError, %q{Cannot specify a user other than the system users without specifying a password!. Valid passwordless users: 'NT AUTHORITY\SYSTEM', 'SYSTEM', 'NT AUTHORITY\LOCALSERVICE', 'NT AUTHORITY\NETWORKSERVICE', 'BUILTIN\USERS', 'USERS'}
+        def password_required?(user)
+          return false if user.nil?
+          @password_required ||= !Chef::ReservedNames::Win32::Security::SID.system_user?(user)
         end
-      end
-
-      def password_required?(user)
-        return false if user.nil?
-        @password_required ||= !SYSTEM_USERS.include?(user.upcase)
-      end
 
-      def validate_interactive_setting(interactive_enabled, password)
-        raise ArgumentError, "Please provide the password when attempting to set interactive/non-interactive." if interactive_enabled && password.nil?
-      end
-
-      def validate_create_frequency_modifier(frequency, frequency_modifier)
-        if ([:on_logon, :onstart, :on_idle, :none].include?(frequency)) && ( frequency_modifier != 1)
-          raise ArgumentError, "frequency_modifier property not supported with frequency :#{frequency}"
+        def validate_interactive_setting(interactive_enabled, password)
+          raise ArgumentError, "Please provide the password when attempting to set interactive/non-interactive." if interactive_enabled && password.nil?
         end
 
-        if frequency == :monthly
-          unless (1..12).cover?(frequency_modifier.to_i) || frequency_modifier_includes_days_of_weeks?(frequency_modifier)
-            raise ArgumentError, "frequency_modifier value #{frequency_modifier} is invalid. Valid values for :monthly frequency are 1 - 12, 'FIRST', 'SECOND', 'THIRD', 'FOURTH', 'LAST'."
+        def validate_create_frequency_modifier(frequency, frequency_modifier)
+          if ([:on_logon, :onstart, :on_idle, :none].include?(frequency)) && ( frequency_modifier != 1)
+            raise ArgumentError, "frequency_modifier property not supported with frequency :#{frequency}"
           end
-        else
-          unless frequency.nil? || frequency_modifier.nil?
-            frequency_modifier = frequency_modifier.to_i
-            min = 1
-            max = case frequency
-                    when :minute
-                      1439
-                    when :hourly
-                      23
-                    when :daily
-                      365
-                    when :weekly
-                      52
-                    else
-                      min
-                  end
-            unless frequency_modifier.between?(min, max)
-              raise ArgumentError, "frequency_modifier value #{frequency_modifier} is invalid. Valid values for :#{frequency} frequency are #{min} - #{max}."
+
+          if frequency == :monthly
+            unless (1..12).cover?(frequency_modifier.to_i) || frequency_modifier_includes_days_of_weeks?(frequency_modifier)
+              raise ArgumentError, "frequency_modifier value #{frequency_modifier} is invalid. Valid values for :monthly frequency are 1 - 12, 'FIRST', 'SECOND', 'THIRD', 'FOURTH', 'LAST'."
+            end
+          else
+            unless frequency.nil? || frequency_modifier.nil?
+              frequency_modifier = frequency_modifier.to_i
+              min = 1
+              max = case frequency
+                      when :minute
+                        1439
+                      when :hourly
+                        23
+                      when :daily
+                        365
+                      when :weekly
+                        52
+                      else
+                        min
+                    end
+              unless frequency_modifier.between?(min, max)
+                raise ArgumentError, "frequency_modifier value #{frequency_modifier} is invalid. Valid values for :#{frequency} frequency are #{min} - #{max}."
+              end
             end
           end
         end
-      end
-
-      def validate_create_day(day, frequency, frequency_modifier)
-        raise ArgumentError, "day property is only valid for tasks that run monthly or weekly" unless [:weekly, :monthly].include?(frequency)
 
-        # This has been verified with schtask.exe https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/schtasks#d-dayday--
-        # verified with earlier code if day "*" is given with frequency it raised exception Invalid value for /D option
-        raise ArgumentError, "day wild card (*) is only valid with frequency :weekly" if frequency == :monthly && day == "*"
-
-        if day.is_a?(String) && day.to_i.to_s != day
-          days = day.split(",")
-          if days_includes_days_of_months?(days)
-            # Following error will be raise if day is set as 1-31 and frequency is selected as :weekly since those values are valid with only frequency :monthly
-            raise ArgumentError, "day values 1-31 or last is only valid with frequency :monthly" if frequency == :weekly
-          else
-            days.map! { |day| day.to_s.strip.downcase }
-            unless (days - VALID_WEEK_DAYS).empty?
-              raise ArgumentError, "day property invalid. Only valid values are: #{VALID_WEEK_DAYS.map(&:upcase).join(', ')}. Multiple values must be separated by a comma."
+        def validate_create_day(day, frequency, frequency_modifier)
+          raise ArgumentError, "day property is only valid for tasks that run monthly or weekly" unless [:weekly, :monthly].include?(frequency)
+
+          # This has been verified with schtask.exe https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/schtasks#d-dayday--
+          # verified with earlier code if day "*" is given with frequency it raised exception Invalid value for /D option
+          raise ArgumentError, "day wild card (*) is only valid with frequency :weekly" if frequency == :monthly && day == "*"
+
+          if day.is_a?(String) && day.to_i.to_s != day
+            days = day.split(",")
+            if days_includes_days_of_months?(days)
+              # Following error will be raise if day is set as 1-31 and frequency is selected as :weekly since those values are valid with only frequency :monthly
+              raise ArgumentError, "day values 1-31 or last is only valid with frequency :monthly" if frequency == :weekly
+            else
+              days.map! { |day| day.to_s.strip.downcase }
+              unless (days - VALID_WEEK_DAYS).empty?
+                raise ArgumentError, "day property invalid. Only valid values are: #{VALID_WEEK_DAYS.map(&:upcase).join(', ')}. Multiple values must be separated by a comma."
+              end
             end
           end
         end
-      end
 
-      def validate_create_months(months, frequency)
-        raise ArgumentError, "months property is only valid for tasks that run monthly" if frequency != :monthly
-        if months.is_a?(String)
-          months = months.split(",")
-          months.map! { |month| month.strip.upcase }
-          unless (months - VALID_MONTHS).empty?
-            raise ArgumentError, "months property invalid. Only valid values are: #{VALID_MONTHS.join(', ')}. Multiple values must be separated by a comma."
+        def validate_create_months(months, frequency)
+          raise ArgumentError, "months property is only valid for tasks that run monthly" if frequency != :monthly
+          if months.is_a?(String)
+            months = months.split(",")
+            months.map! { |month| month.strip.upcase }
+            unless (months - VALID_MONTHS).empty?
+              raise ArgumentError, "months property invalid. Only valid values are: #{VALID_MONTHS.join(', ')}. Multiple values must be separated by a comma."
+            end
           end
         end
-      end
-
-      # This method returns true if day has values from 1-31 which is a days of moths and used with frequency :monthly
-      def days_includes_days_of_months?(days)
-        days.map! { |day| day.to_s.strip.downcase }
-        (days - VALID_DAYS_OF_MONTH).empty?
-      end
 
-      def validate_idle_time(idle_time, frequency)
-        if !idle_time.nil? && frequency != :on_idle
-          raise ArgumentError, "idle_time property is only valid for tasks that run on_idle"
+        # This method returns true if day has values from 1-31 which is a days of moths and used with frequency :monthly
+        def days_includes_days_of_months?(days)
+          days.map! { |day| day.to_s.strip.downcase }
+          (days - VALID_DAYS_OF_MONTH).empty?
         end
-        if idle_time.nil? && frequency == :on_idle
-          raise ArgumentError, "idle_time value should be set for :on_idle frequency."
-        end
-        unless idle_time.nil? || idle_time > 0 && idle_time <= 999
-          raise ArgumentError, "idle_time value #{idle_time} is invalid. Valid values for :on_idle frequency are 1 - 999."
+
+        def validate_idle_time(idle_time, frequency)
+          if !idle_time.nil? && frequency != :on_idle
+            raise ArgumentError, "idle_time property is only valid for tasks that run on_idle"
+          end
+          if idle_time.nil? && frequency == :on_idle
+            raise ArgumentError, "idle_time value should be set for :on_idle frequency."
+          end
+          unless idle_time.nil? || idle_time > 0 && idle_time <= 999
+            raise ArgumentError, "idle_time value #{idle_time} is invalid. Valid values for :on_idle frequency are 1 - 999."
+          end
         end
-      end
 
-      # Converts the number of seconds to an ISO8601 duration format and returns it.
-      # Ref : https://github.com/arnau/ISO8601/blob/master/lib/iso8601/duration.rb#L18-L23
-      # e.g.
-      # ISO8601::Duration.new(65707200).to_s
-      # returns 'PT65707200S'
-      def sec_to_dur(seconds)
-        ISO8601::Duration.new(seconds.to_i).to_s
-      end
+        # Converts the number of seconds to an ISO8601 duration format and returns it.
+        # Ref : https://github.com/arnau/ISO8601/blob/master/lib/iso8601/duration.rb#L18-L23
+        # e.g.
+        # ISO8601::Duration.new(65707200).to_s
+        # returns 'PT65707200S'
+        def sec_to_dur(seconds)
+          ISO8601::Duration.new(seconds.to_i).to_s
+        end
 
-      def sec_to_min(seconds)
-        seconds.to_i / 60
+        def sec_to_min(seconds)
+          seconds.to_i / 60
+        end
       end
     end
   end