chef 14.5.27-universal-mingw32 → 14.5.33-universal-mingw32

data/spec/unit/cookbook_uploader_spec.rb

@@ -1,199 +1,199 @@
-#
-# Author:: Daniel DeLeo (<dan@chef.io>)
-# Copyright:: Copyright 2014-2016, Chef Software, Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::CookbookUploader do
-
-  let(:http_client) { double("Chef::ServerAPI") }
-
-  let(:cookbook_loader) do
-    loader = Chef::CookbookLoader.new(File.join(CHEF_SPEC_DATA, "cookbooks"))
-    loader.load_cookbooks
-    loader.cookbooks_by_name["apache2"].identifier = apache2_identifier
-    loader.cookbooks_by_name["java"].identifier = java_identifier
-    loader
-  end
-
-  let(:apache2_identifier) { "6644e6cb2ade90b8aff2ebb44728958fbc939ebf" }
-
-  let(:apache2_cookbook) { cookbook_loader.cookbooks_by_name["apache2"] }
-
-  let(:java_identifier) { "edd40c30c4e0ebb3658abde4620597597d2e9c17" }
-
-  let(:java_cookbook) { cookbook_loader.cookbooks_by_name["java"] }
-
-  let(:cookbooks_to_upload) { [apache2_cookbook, java_cookbook] }
-
-  let(:checksums_of_cookbook_files) { apache2_cookbook.checksums.merge(java_cookbook.checksums) }
-
-  let(:checksums_set) do
-    checksums_of_cookbook_files.keys.inject({}) do |set, cksum|
-      set[cksum] = nil
-      set
-    end
-  end
-
-  let(:sandbox_commit_uri) { "https://chef.example.org/sandboxes/abc123" }
-
-  let(:policy_mode) { false }
-
-  let(:uploader) { described_class.new(cookbooks_to_upload, rest: http_client, policy_mode: policy_mode) }
-
-  it "defaults to not enabling policy mode" do
-    expect(described_class.new(cookbooks_to_upload, rest: http_client).policy_mode?).to be(false)
-  end
-
-  it "has a list of cookbooks to upload" do
-    expect(uploader.cookbooks).to eq(cookbooks_to_upload)
-  end
-
-  it "creates an HTTP client with default configuration when not initialized with one" do
-    default_http_client = double("Chef::ServerAPI")
-    expect(Chef::ServerAPI).to receive(:new).with(Chef::Config[:chef_server_url], version_class: Chef::CookbookManifestVersions).and_return(default_http_client)
-    uploader = described_class.new(cookbooks_to_upload)
-    expect(uploader.rest).to eq(default_http_client)
-  end
-
-  describe "uploading cookbooks" do
-
-    def url_for(cksum)
-      "https://storage.example.com/#{cksum}"
-    end
-
-    let(:sandbox_response) do
-      sandbox_checksums = cksums_not_on_remote.inject({}) do |cksum_map, cksum|
-        cksum_map[cksum] = { "needs_upload" => true, "url" => url_for(cksum) }
-        cksum_map
-      end
-      { "checksums" => sandbox_checksums, "uri" => sandbox_commit_uri }
-    end
-
-    def expect_sandbox_create
-      expect(http_client).to receive(:post)
-        .with("sandboxes", { checksums: checksums_set })
-        .and_return(sandbox_response)
-    end
-
-    def expect_checksum_upload
-      checksums_of_cookbook_files.each do |md5, file_path|
-        next unless cksums_not_on_remote.include?(md5)
-
-        upload_headers = {
-          "content-type" => "application/x-binary",
-          "content-md5"  => an_instance_of(String),
-          "accept"       => "application/json",
-        }
-
-        expect(http_client).to receive(:put)
-          .with(url_for(md5), IO.binread(file_path), upload_headers)
-
-      end
-    end
-
-    def expected_save_url(cookbook)
-      "cookbooks/#{cookbook.name}/#{cookbook.version}"
-    end
-
-    def expect_sandbox_commit
-      expect(http_client).to receive(:put).with(sandbox_commit_uri, { is_completed: true })
-    end
-
-    def expect_cookbook_create
-      cookbooks_to_upload.each do |cookbook|
-
-        expect(http_client).to receive(:put)
-          .with(expected_save_url(cookbook), cookbook)
-
-      end
-    end
-
-    context "when no files exist on the server" do
-
-      let(:cksums_not_on_remote) do
-        checksums_of_cookbook_files.keys
-      end
-
-      it "uploads all files in a sandbox transaction, then creates cookbooks on the server" do
-        expect_sandbox_create
-        expect_checksum_upload
-        expect_sandbox_commit
-        expect_cookbook_create
-
-        uploader.upload_cookbooks
-      end
-
-    end
-
-    context "when some files exist on the server" do
-
-      let(:cksums_not_on_remote) do
-        checksums_of_cookbook_files.keys[0, 1]
-      end
-
-      it "uploads all files in a sandbox transaction, then creates cookbooks on the server" do
-        expect_sandbox_create
-        expect_checksum_upload
-        expect_sandbox_commit
-        expect_cookbook_create
-
-        uploader.upload_cookbooks
-      end
-
-    end
-
-    context "when all files already exist on the server" do
-
-      let(:cksums_not_on_remote) { [] }
-
-      it "uploads all files in a sandbox transaction, then creates cookbooks on the server" do
-        expect_sandbox_create
-        expect_checksum_upload
-        expect_sandbox_commit
-        expect_cookbook_create
-
-        uploader.upload_cookbooks
-      end
-
-    end
-
-    context "when policy_mode is specified" do
-
-      let(:cksums_not_on_remote) do
-        checksums_of_cookbook_files.keys
-      end
-
-      let(:policy_mode) { true }
-
-      def expected_save_url(cookbook)
-        "cookbook_artifacts/#{cookbook.name}/#{cookbook.identifier}"
-      end
-
-      it "uploads all files in a sandbox transaction, then creates cookbooks on the server using cookbook_artifacts API" do
-        expect_sandbox_create
-        expect_checksum_upload
-        expect_sandbox_commit
-        expect_cookbook_create
-
-        uploader.upload_cookbooks
-      end
-
-    end
-  end
-
-end
+#
+# Author:: Daniel DeLeo (<dan@chef.io>)
+# Copyright:: Copyright 2014-2016, Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::CookbookUploader do
+
+  let(:http_client) { double("Chef::ServerAPI") }
+
+  let(:cookbook_loader) do
+    loader = Chef::CookbookLoader.new(File.join(CHEF_SPEC_DATA, "cookbooks"))
+    loader.load_cookbooks
+    loader.cookbooks_by_name["apache2"].identifier = apache2_identifier
+    loader.cookbooks_by_name["java"].identifier = java_identifier
+    loader
+  end
+
+  let(:apache2_identifier) { "6644e6cb2ade90b8aff2ebb44728958fbc939ebf" }
+
+  let(:apache2_cookbook) { cookbook_loader.cookbooks_by_name["apache2"] }
+
+  let(:java_identifier) { "edd40c30c4e0ebb3658abde4620597597d2e9c17" }
+
+  let(:java_cookbook) { cookbook_loader.cookbooks_by_name["java"] }
+
+  let(:cookbooks_to_upload) { [apache2_cookbook, java_cookbook] }
+
+  let(:checksums_of_cookbook_files) { apache2_cookbook.checksums.merge(java_cookbook.checksums) }
+
+  let(:checksums_set) do
+    checksums_of_cookbook_files.keys.inject({}) do |set, cksum|
+      set[cksum] = nil
+      set
+    end
+  end
+
+  let(:sandbox_commit_uri) { "https://chef.example.org/sandboxes/abc123" }
+
+  let(:policy_mode) { false }
+
+  let(:uploader) { described_class.new(cookbooks_to_upload, rest: http_client, policy_mode: policy_mode) }
+
+  it "defaults to not enabling policy mode" do
+    expect(described_class.new(cookbooks_to_upload, rest: http_client).policy_mode?).to be(false)
+  end
+
+  it "has a list of cookbooks to upload" do
+    expect(uploader.cookbooks).to eq(cookbooks_to_upload)
+  end
+
+  it "creates an HTTP client with default configuration when not initialized with one" do
+    default_http_client = double("Chef::ServerAPI")
+    expect(Chef::ServerAPI).to receive(:new).with(Chef::Config[:chef_server_url], version_class: Chef::CookbookManifestVersions).and_return(default_http_client)
+    uploader = described_class.new(cookbooks_to_upload)
+    expect(uploader.rest).to eq(default_http_client)
+  end
+
+  describe "uploading cookbooks" do
+
+    def url_for(cksum)
+      "https://storage.example.com/#{cksum}"
+    end
+
+    let(:sandbox_response) do
+      sandbox_checksums = cksums_not_on_remote.inject({}) do |cksum_map, cksum|
+        cksum_map[cksum] = { "needs_upload" => true, "url" => url_for(cksum) }
+        cksum_map
+      end
+      { "checksums" => sandbox_checksums, "uri" => sandbox_commit_uri }
+    end
+
+    def expect_sandbox_create
+      expect(http_client).to receive(:post)
+        .with("sandboxes", { checksums: checksums_set })
+        .and_return(sandbox_response)
+    end
+
+    def expect_checksum_upload
+      checksums_of_cookbook_files.each do |md5, file_path|
+        next unless cksums_not_on_remote.include?(md5)
+
+        upload_headers = {
+          "content-type" => "application/x-binary",
+          "content-md5"  => an_instance_of(String),
+          "accept"       => "application/json",
+        }
+
+        expect(http_client).to receive(:put)
+          .with(url_for(md5), IO.binread(file_path), upload_headers)
+
+      end
+    end
+
+    def expected_save_url(cookbook)
+      "cookbooks/#{cookbook.name}/#{cookbook.version}"
+    end
+
+    def expect_sandbox_commit
+      expect(http_client).to receive(:put).with(sandbox_commit_uri, { is_completed: true })
+    end
+
+    def expect_cookbook_create
+      cookbooks_to_upload.each do |cookbook|
+
+        expect(http_client).to receive(:put)
+          .with(expected_save_url(cookbook), cookbook)
+
+      end
+    end
+
+    context "when no files exist on the server" do
+
+      let(:cksums_not_on_remote) do
+        checksums_of_cookbook_files.keys
+      end
+
+      it "uploads all files in a sandbox transaction, then creates cookbooks on the server" do
+        expect_sandbox_create
+        expect_checksum_upload
+        expect_sandbox_commit
+        expect_cookbook_create
+
+        uploader.upload_cookbooks
+      end
+
+    end
+
+    context "when some files exist on the server" do
+
+      let(:cksums_not_on_remote) do
+        checksums_of_cookbook_files.keys[0, 1]
+      end
+
+      it "uploads all files in a sandbox transaction, then creates cookbooks on the server" do
+        expect_sandbox_create
+        expect_checksum_upload
+        expect_sandbox_commit
+        expect_cookbook_create
+
+        uploader.upload_cookbooks
+      end
+
+    end
+
+    context "when all files already exist on the server" do
+
+      let(:cksums_not_on_remote) { [] }
+
+      it "uploads all files in a sandbox transaction, then creates cookbooks on the server" do
+        expect_sandbox_create
+        expect_checksum_upload
+        expect_sandbox_commit
+        expect_cookbook_create
+
+        uploader.upload_cookbooks
+      end
+
+    end
+
+    context "when policy_mode is specified" do
+
+      let(:cksums_not_on_remote) do
+        checksums_of_cookbook_files.keys
+      end
+
+      let(:policy_mode) { true }
+
+      def expected_save_url(cookbook)
+        "cookbook_artifacts/#{cookbook.name}/#{cookbook.identifier}"
+      end
+
+      it "uploads all files in a sandbox transaction, then creates cookbooks on the server using cookbook_artifacts API" do
+        expect_sandbox_create
+        expect_checksum_upload
+        expect_sandbox_commit
+        expect_cookbook_create
+
+        uploader.upload_cookbooks
+      end
+
+    end
+  end
+
+end

data/spec/unit/cookbook_version_file_specificity_spec.rb

@@ -1,623 +1,623 @@
-#
-# Author:: Tim Hinderliter (<tim@chef.io>)
-# Author:: Christopher Walters (<cw@chef.io>)
-# Copyright:: Copyright 2010-2016, Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::CookbookVersion, "file specificity" do
-  before(:each) do
-    @cookbook = Chef::CookbookVersion.new("test-cookbook", "/cookbook-folder")
-    @cookbook.manifest = {
-      "all_files" =>
-      [
-       # afile.rb
-       {
-         name: "files/afile.rb",
-         path: "files/host-examplehost.example.org/afile.rb",
-         full_path: "/cookbook-folder/files/host-examplehost.example.org/afile.rb",
-         checksum: "csum-host",
-         specificity: "host-examplehost.example.org",
-       },
-       {
-         name: "files/afile.rb",
-         path: "files/ubuntu-9.10/afile.rb",
-         full_path: "/cookbook-folder/files/ubuntu-9.10/afile.rb",
-         checksum: "csum-platver-full",
-         specificity: "ubuntu-9.10",
-       },
-       {
-         name: "files/afile.rb",
-         path: "files/newubuntu-9/afile.rb",
-         full_path: "/cookbook-folder/files/newubuntu-9/afile.rb",
-         checksum: "csum-platver-partial",
-         specificity: "newubuntu-9",
-       },
-       {
-         name: "files/afile.rb",
-         path: "files/ubuntu/afile.rb",
-         full_path: "/cookbook-folder/files/ubuntu/afile.rb",
-         checksum: "csum-plat",
-         specificity: "ubuntu",
-       },
-       {
-         name: "files/afile.rb",
-         path: "files/default/afile.rb",
-         full_path: "/cookbook-folder/files/default/afile.rb",
-         checksum: "csum-default",
-         specificity: "default",
-       },
-
-       # for different/odd platform_versions
-       {
-         name: "files/bfile.rb",
-         path: "files/fakeos-2.0.rc.1/bfile.rb",
-         full_path: "/cookbook-folder/files/fakeos-2.0.rc.1/bfile.rb",
-         checksum: "csum2-platver-full",
-         specificity: "fakeos-2.0.rc.1",
-       },
-       {
-         name: "files/bfile.rb",
-         path: "files/newfakeos-2.0.rc/bfile.rb",
-         full_path: "/cookbook-folder/files/newfakeos-2.0.rc/bfile.rb",
-         checksum: "csum2-platver-partial",
-         specificity: "newfakeos-2.0.rc",
-       },
-       {
-         name: "files/bfile.rb",
-         path: "files/fakeos-maple tree/bfile.rb",
-         full_path: "/cookbook-folder/files/fakeos-maple tree/bfile.rb",
-         checksum: "csum3-platver-full",
-         specificity: "maple tree",
-       },
-       {
-         name: "files/bfile.rb",
-         path: "files/fakeos-1/bfile.rb",
-         full_path: "/cookbook-folder/files/fakeos-1/bfile.rb",
-         checksum: "csum4-platver-full",
-         specificity: "fakeos-1",
-       },
-
-       # directory adirectory
-       {
-         name: "files/anotherfile1.rb",
-         path: "files/root_directory/anotherfile1.rb.root",
-         checksum: "csum-root-directory",
-         specificity: "root_directory",
-       },
-
-       {
-         name: "files/anotherfile1.rb",
-         path: "files/host-examplehost.example.org/adirectory/anotherfile1.rb.host",
-         full_path: "/cookbook-folder/files/host-examplehost.example.org/adirectory/anotherfile1.rb.host",
-         checksum: "csum-host-1",
-         specificity: "host-examplehost.example.org",
-       },
-       {
-         name: "files/anotherfile2.rb",
-         path: "files/host-examplehost.example.org/adirectory/anotherfile2.rb.host",
-         full_path: "/cookbook-folder/files/host-examplehost.example.org/adirectory/anotherfile2.rb.host",
-         checksum: "csum-host-2",
-         specificity: "host-examplehost.example.org",
-       },
-
-       {
-         name: "files/anotherfile1.rb",
-         path: "files/ubuntu-9.10/adirectory/anotherfile1.rb.platform-full-version",
-         full_path: "/cookbook-folder/files/ubuntu-9.10/adirectory/anotherfile1.rb.platform-full-version",
-         checksum: "csum-platver-full-1",
-         specificity: "ubuntu-9.10",
-       },
-       {
-         name: "files/anotherfile2.rb",
-         path: "files/ubuntu-9.10/adirectory/anotherfile2.rb.platform-full-version",
-         full_path: "/cookbook-folder/files/ubuntu-9.10/adirectory/anotherfile2.rb.platform-full-version",
-         checksum: "csum-platver-full-2",
-         specificity: "ubuntu-9.10",
-       },
-
-       {
-         name: "files/anotherfile1.rb",
-         path: "files/newubuntu-9/adirectory/anotherfile1.rb.platform-partial-version",
-         full_path: "/cookbook-folder/files/newubuntu-9/adirectory/anotherfile1.rb.platform-partial-version",
-         checksum: "csum-platver-partial-1",
-         specificity: "newubuntu-9",
-       },
-       {
-         name: "files/anotherfile2.rb",
-         path: "files/newubuntu-9/adirectory/anotherfile2.rb.platform-partial-version",
-         full_path: "/cookbook-folder/files/newubuntu-9/adirectory/anotherfile2.rb.platform-partial-version",
-         checksum: "csum-platver-partial-2",
-         specificity: "nweubuntu-9",
-       },
-
-       {
-         name: "files/anotherfile1.rb",
-         path: "files/ubuntu/adirectory/anotherfile1.rb.platform",
-         full_path: "/cookbook-folder/files/ubuntu/adirectory/anotherfile1.rb.platform",
-         checksum: "csum-plat-1",
-         specificity: "ubuntu",
-       },
-       {
-         name: "files/anotherfile2.rb",
-         path: "files/ubuntu/adirectory/anotherfile2.rb.platform",
-         full_path: "/cookbook-folder/files/ubuntu/adirectory/anotherfile2.rb.platform",
-         checksum: "csum-plat-2",
-         specificity: "ubuntu",
-       },
-
-       {
-         name: "files/anotherfile1.rb",
-         path: "files/default/adirectory/anotherfile1.rb.default",
-         full_path: "/cookbook-folder/files/default/adirectory/anotherfile1.rb.default",
-         checksum: "csum-default-1",
-         specificity: "default",
-       },
-       {
-         name: "files/anotherfile2.rb",
-         path: "files/default/adirectory/anotherfile2.rb.default",
-         full_path: "/cookbook-folder/files/default/adirectory/anotherfile2.rb.default",
-         checksum: "csum-default-2",
-         specificity: "default",
-       },
-       # for different/odd platform_versions
-       {
-         name: "files/anotherfile1.rb",
-         path: "files/fakeos-2.0.rc.1/adirectory/anotherfile1.rb.platform-full-version",
-         full_path: "/cookbook-folder/files/fakeos-2.0.rc.1/adirectory/anotherfile1.rb.platform-full-version",
-         checksum: "csum2-platver-full-1",
-         specificity: "fakeos-2.0.rc.1",
-       },
-       {
-         name: "files/anotherfile2.rb",
-         path: "files/fakeos-2.0.rc.1/adirectory/anotherfile2.rb.platform-full-version",
-         full_path: "/cookbook-folder/files/fakeos-2.0.rc.1/adirectory/anotherfile2.rb.platform-full-version",
-         checksum: "csum2-platver-full-2",
-         specificity: "fakeos-2.0.rc.1",
-       },
-       {
-         name: "files/anotherfile1.rb",
-         path: "files/newfakeos-2.0.rc.1/adirectory/anotherfile1.rb.platform-partial-version",
-         full_path: "/cookbook-folder/files/newfakeos-2.0.rc.1/adirectory/anotherfile1.rb.platform-partial-version",
-         checksum: "csum2-platver-partial-1",
-         specificity: "newfakeos-2.0.rc",
-       },
-       {
-         name: "files/anotherfile2.rb",
-         path: "files/newfakeos-2.0.rc.1/adirectory/anotherfile2.rb.platform-partial-version",
-         full_path: "/cookbook-folder/files/newfakeos-2.0.rc.1/adirectory/anotherfile2.rb.platform-partial-version",
-         checksum: "csum2-platver-partial-2",
-         specificity: "newfakeos-2.0.rc",
-       },
-       {
-         name: "files/anotherfile1.rb",
-         path: "files/fakeos-maple tree/adirectory/anotherfile1.rb.platform-full-version",
-         full_path: "/cookbook-folder/files/fakeos-maple tree/adirectory/anotherfile1.rb.platform-full-version",
-         checksum: "csum3-platver-full-1",
-         specificity: "fakeos-maple tree",
-       },
-       {
-         name: "files/anotherfile2.rb",
-         path: "files/fakeos-maple tree/adirectory/anotherfile2.rb.platform-full-version",
-         full_path: "/cookbook-folder/files/fakeos-maple tree/adirectory/anotherfile2.rb.platform-full-version",
-         checksum: "csum3-platver-full-2",
-         specificity: "fakeos-maple tree",
-       },
-       {
-         name: "files/anotherfile1.rb",
-         path: "files/fakeos-1/adirectory/anotherfile1.rb.platform-full-version",
-         full_path: "/cookbook-folder/files/fakeos-1/adirectory/anotherfile1.rb.platform-full-version",
-         checksum: "csum4-platver-full-1",
-         specificity: "fakeos-1",
-       },
-       {
-         name: "files/anotherfile2.rb",
-         path: "files/fakeos-1/adirectory/anotherfile2.rb.platform-full-version",
-         full_path: "/cookbook-folder/files/fakeos-1/adirectory/anotherfile2.rb.platform-full-version",
-         checksum: "csum4-platver-full-2",
-         specificity: "fakeos-1",
-       },
-      ],
-    }
-
-  end
-
-  it "should return a manifest record based on priority preference: host" do
-    node = Chef::Node.new
-    node.automatic_attrs[:platform] = "ubuntu"
-    node.automatic_attrs[:platform_version] = "9.10"
-    node.automatic_attrs[:fqdn] = "examplehost.example.org"
-
-    manifest_record = @cookbook.preferred_manifest_record(node, :files, "afile.rb")
-    expect(manifest_record).not_to be_nil
-    expect(manifest_record[:checksum]).to eq("csum-host")
-  end
-
-  it "should return a manifest record based on priority preference: platform & full version" do
-    node = Chef::Node.new
-    node.automatic_attrs[:platform] = "ubuntu"
-    node.automatic_attrs[:platform_version] = "9.10"
-    node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-    manifest_record = @cookbook.preferred_manifest_record(node, :files, "afile.rb")
-    expect(manifest_record).not_to be_nil
-    expect(manifest_record[:checksum]).to eq("csum-platver-full")
-  end
-
-  it "should return a manifest record based on priority preference: platform & partial version" do
-    node = Chef::Node.new
-    node.automatic_attrs[:platform] = "newubuntu"
-    node.automatic_attrs[:platform_version] = "9.10"
-    node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-    manifest_record = @cookbook.preferred_manifest_record(node, :files, "afile.rb")
-    expect(manifest_record).not_to be_nil
-    expect(manifest_record[:checksum]).to eq("csum-platver-partial")
-  end
-
-  it "should return a manifest record based on priority preference: platform only" do
-    node = Chef::Node.new
-    node.automatic_attrs[:platform] = "ubuntu"
-    node.automatic_attrs[:platform_version] = "1.0"
-    node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-    manifest_record = @cookbook.preferred_manifest_record(node, :files, "afile.rb")
-    expect(manifest_record).not_to be_nil
-    expect(manifest_record[:checksum]).to eq("csum-plat")
-  end
-
-  it "should return a manifest record based on priority preference: default" do
-    node = Chef::Node.new
-    node.automatic_attrs[:platform] = "notubuntu"
-    node.automatic_attrs[:platform_version] = "1.0"
-    node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-    manifest_record = @cookbook.preferred_manifest_record(node, :files, "afile.rb")
-    expect(manifest_record).not_to be_nil
-    expect(manifest_record[:checksum]).to eq("csum-default")
-  end
-
-  it "should return a manifest record based on priority preference: platform & full version - platform_version variant 1" do
-    node = Chef::Node.new
-    node.automatic_attrs[:platform] = "fakeos"
-    node.automatic_attrs[:platform_version] = "2.0.rc.1"
-    node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-    manifest_record = @cookbook.preferred_manifest_record(node, :files, "bfile.rb")
-    expect(manifest_record).not_to be_nil
-    expect(manifest_record[:checksum]).to eq("csum2-platver-full")
-  end
-
-  it "should return a manifest record based on priority preference: platform & partial version - platform_version variant 1" do
-    node = Chef::Node.new
-    node.automatic_attrs[:platform] = "newfakeos"
-    node.automatic_attrs[:platform_version] = "2.0.rc.1"
-    node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-    manifest_record = @cookbook.preferred_manifest_record(node, :files, "bfile.rb")
-    expect(manifest_record).not_to be_nil
-    expect(manifest_record[:checksum]).to eq("csum2-platver-partial")
-  end
-
-  it "should return a manifest record based on priority preference: platform & full version - platform_version variant 2" do
-    node = Chef::Node.new
-    node.automatic_attrs[:platform] = "fakeos"
-    node.automatic_attrs[:platform_version] = "maple tree"
-    node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-    manifest_record = @cookbook.preferred_manifest_record(node, :files, "bfile.rb")
-    expect(manifest_record).not_to be_nil
-    expect(manifest_record[:checksum]).to eq("csum3-platver-full")
-  end
-
-  it "should return a manifest record based on priority preference: platform & full version - platform_version variant 3" do
-    node = Chef::Node.new
-    node.automatic_attrs[:platform] = "fakeos"
-    node.automatic_attrs[:platform_version] = "1"
-    node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-    manifest_record = @cookbook.preferred_manifest_record(node, :files, "bfile.rb")
-    expect(manifest_record).not_to be_nil
-    expect(manifest_record[:checksum]).to eq("csum4-platver-full")
-  end
-
-  it "should raise a FileNotFound exception without match" do
-    node = Chef::Node.new
-
-    expect do
-      @cookbook.preferred_manifest_record(node, :files, "doesn't_exist.rb")
-    end.to raise_error(Chef::Exceptions::FileNotFound)
-  end
-  it "should raise a FileNotFound exception consistently without match" do
-    node = Chef::Node.new
-
-    expect do
-      @cookbook.preferred_manifest_record(node, :files, "doesn't_exist.rb")
-    end.to raise_error(Chef::Exceptions::FileNotFound)
-
-    expect do
-      @cookbook.preferred_manifest_record(node, :files, "doesn't_exist.rb")
-    end.to raise_error(Chef::Exceptions::FileNotFound)
-
-    expect do
-      @cookbook.preferred_manifest_record(node, :files, "doesn't_exist.rb")
-    end.to raise_error(Chef::Exceptions::FileNotFound)
-  end
-
-  describe "when fetching the contents of a directory by file specificity" do
-
-    it "should return a directory of manifest records based on priority preference: host" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "ubuntu"
-      node.automatic_attrs[:platform_version] = "9.10"
-      node.automatic_attrs[:fqdn] = "examplehost.example.org"
-
-      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
-      expect(manifest_records).not_to be_nil
-      expect(manifest_records.size).to eq(2)
-
-      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
-      expect(checksums.sort).to eq(["csum-host-1", "csum-host-2"])
-    end
-
-    it "should return a directory of manifest records based on priority preference: platform & full version" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "ubuntu"
-      node.automatic_attrs[:platform_version] = "9.10"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
-      expect(manifest_records).not_to be_nil
-      expect(manifest_records.size).to eq(2)
-
-      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
-      expect(checksums.sort).to eq(["csum-platver-full-1", "csum-platver-full-2"])
-    end
-
-    it "should return a directory of manifest records based on priority preference: platform & partial version" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "newubuntu"
-      node.automatic_attrs[:platform_version] = "9.10"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
-      expect(manifest_records).not_to be_nil
-      expect(manifest_records.size).to eq(2)
-
-      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
-      expect(checksums.sort).to eq(["csum-platver-partial-1", "csum-platver-partial-2"])
-    end
-
-    it "should return a directory of manifest records based on priority preference: platform only" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "ubuntu"
-      node.automatic_attrs[:platform_version] = "1.0"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
-      expect(manifest_records).not_to be_nil
-      expect(manifest_records.size).to eq(2)
-
-      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
-      expect(checksums.sort).to eq(["csum-plat-1", "csum-plat-2"])
-    end
-
-    it "should return a directory of manifest records based on priority preference: default" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "notubuntu"
-      node.automatic_attrs[:platform_version] = "1.0"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
-      expect(manifest_records).not_to be_nil
-      expect(manifest_records.size).to eq(2)
-
-      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
-      expect(checksums.sort).to eq(["csum-default-1", "csum-default-2"])
-    end
-
-    it "should return a manifest record based on priority preference: platform & full version - platform_version variant 1" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "fakeos"
-      node.automatic_attrs[:platform_version] = "2.0.rc.1"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
-      expect(manifest_records).not_to be_nil
-      expect(manifest_records.size).to eq(2)
-
-      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
-      expect(checksums.sort).to eq(["csum2-platver-full-1", "csum2-platver-full-2"])
-    end
-
-    it "should return a manifest record based on priority preference: platform & partial version - platform_version variant 1" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "newfakeos"
-      node.automatic_attrs[:platform_version] = "2.0.rc.1"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
-      expect(manifest_records).not_to be_nil
-      expect(manifest_records.size).to eq(2)
-
-      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
-      expect(checksums.sort).to eq(["csum2-platver-partial-1", "csum2-platver-partial-2"])
-    end
-
-    it "should return a manifest record based on priority preference: platform & full version - platform_version variant 2" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "fakeos"
-      node.automatic_attrs[:platform_version] = "maple tree"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
-      expect(manifest_records).not_to be_nil
-      expect(manifest_records.size).to eq(2)
-
-      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
-      expect(checksums.sort).to eq(["csum3-platver-full-1", "csum3-platver-full-2"])
-    end
-
-    it "should return a manifest record based on priority preference: platform & full version - platform_version variant 3" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "fakeos"
-      node.automatic_attrs[:platform_version] = "1"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
-      expect(manifest_records).not_to be_nil
-      expect(manifest_records.size).to eq(2)
-
-      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
-      expect(checksums.sort).to eq(["csum4-platver-full-1", "csum4-platver-full-2"])
-    end
-  end
-
-  ## Globbing the relative paths out of the manifest records ##
-
-  describe "when globbing for relative file paths based on filespecificity" do
-    it "should return a list of relative paths based on priority preference: root directory" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "ubuntu"
-      node.automatic_attrs[:platform_version] = "9.10"
-      node.automatic_attrs[:fqdn] = "examplehost.example.org"
-
-      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "root_directory")
-      expect(filenames).not_to be_nil
-      expect(filenames.size).to eq(1)
-
-      expect(filenames.sort).to eq(["anotherfile1.rb.root"])
-    end
-
-    it "should return a list of relative paths based on priority preference: host" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "ubuntu"
-      node.automatic_attrs[:platform_version] = "9.10"
-      node.automatic_attrs[:fqdn] = "examplehost.example.org"
-
-      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
-      expect(filenames).not_to be_nil
-      expect(filenames.size).to eq(2)
-
-      expect(filenames.sort).to eq(["anotherfile1.rb.host", "anotherfile2.rb.host"])
-    end
-
-    it "should return a list of relative paths based on priority preference: platform & full version" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "ubuntu"
-      node.automatic_attrs[:platform_version] = "9.10"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
-      expect(filenames).not_to be_nil
-      expect(filenames.size).to eq(2)
-
-      expect(filenames.sort).to eq(["anotherfile1.rb.platform-full-version", "anotherfile2.rb.platform-full-version"])
-    end
-
-    it "should return a list of relative paths based on priority preference: platform & partial version" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "newubuntu"
-      node.automatic_attrs[:platform_version] = "9.10"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
-      expect(filenames).not_to be_nil
-      expect(filenames.size).to eq(2)
-
-      expect(filenames.sort).to eq(["anotherfile1.rb.platform-partial-version", "anotherfile2.rb.platform-partial-version"])
-    end
-
-    it "should return a list of relative paths based on priority preference: platform only" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "ubuntu"
-      node.automatic_attrs[:platform_version] = "1.0"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
-      expect(filenames).not_to be_nil
-      expect(filenames.size).to eq(2)
-
-      expect(filenames.sort).to eq(["anotherfile1.rb.platform", "anotherfile2.rb.platform"])
-    end
-
-    it "should return a list of relative paths based on priority preference: default" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "notubuntu"
-      node.automatic_attrs[:platform_version] = "1.0"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
-      expect(filenames).not_to be_nil
-      expect(filenames.size).to eq(2)
-
-      expect(filenames.sort).to eq(["anotherfile1.rb.default", "anotherfile2.rb.default"])
-    end
-
-    it "should return a list of relative paths based on priority preference: platform & full version - platform_version variant 1" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "fakeos"
-      node.automatic_attrs[:platform_version] = "2.0.rc.1"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
-      expect(filenames).not_to be_nil
-      expect(filenames.size).to eq(2)
-
-      expect(filenames.sort).to eq(["anotherfile1.rb.platform-full-version", "anotherfile2.rb.platform-full-version"])
-    end
-
-    it "should return a list of relative paths based on priority preference: platform & partial version - platform_version variant 1" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "newfakeos"
-      node.automatic_attrs[:platform_version] = "2.0.rc.1"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
-      expect(filenames).not_to be_nil
-      expect(filenames.size).to eq(2)
-
-      expect(filenames.sort).to eq(["anotherfile1.rb.platform-partial-version", "anotherfile2.rb.platform-partial-version"])
-    end
-
-    it "should return a list of relative paths based on priority preference: platform & full version - platform_version variant 2" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "fakeos"
-      node.automatic_attrs[:platform_version] = "maple tree"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
-      expect(filenames).not_to be_nil
-      expect(filenames.size).to eq(2)
-
-      expect(filenames.sort).to eq(["anotherfile1.rb.platform-full-version", "anotherfile2.rb.platform-full-version"])
-    end
-
-    it "should return a list of relative paths based on priority preference: platform & full version - platform_version variant 3" do
-      node = Chef::Node.new
-      node.automatic_attrs[:platform] = "fakeos"
-      node.automatic_attrs[:platform_version] = "1"
-      node.automatic_attrs[:fqdn] = "differenthost.example.org"
-
-      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
-      expect(filenames).not_to be_nil
-      expect(filenames.size).to eq(2)
-
-      expect(filenames.sort).to eq(["anotherfile1.rb.platform-full-version", "anotherfile2.rb.platform-full-version"])
-    end
-  end
-end
+#
+# Author:: Tim Hinderliter (<tim@chef.io>)
+# Author:: Christopher Walters (<cw@chef.io>)
+# Copyright:: Copyright 2010-2016, Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::CookbookVersion, "file specificity" do
+  before(:each) do
+    @cookbook = Chef::CookbookVersion.new("test-cookbook", "/cookbook-folder")
+    @cookbook.manifest = {
+      "all_files" =>
+      [
+       # afile.rb
+       {
+         name: "files/afile.rb",
+         path: "files/host-examplehost.example.org/afile.rb",
+         full_path: "/cookbook-folder/files/host-examplehost.example.org/afile.rb",
+         checksum: "csum-host",
+         specificity: "host-examplehost.example.org",
+       },
+       {
+         name: "files/afile.rb",
+         path: "files/ubuntu-9.10/afile.rb",
+         full_path: "/cookbook-folder/files/ubuntu-9.10/afile.rb",
+         checksum: "csum-platver-full",
+         specificity: "ubuntu-9.10",
+       },
+       {
+         name: "files/afile.rb",
+         path: "files/newubuntu-9/afile.rb",
+         full_path: "/cookbook-folder/files/newubuntu-9/afile.rb",
+         checksum: "csum-platver-partial",
+         specificity: "newubuntu-9",
+       },
+       {
+         name: "files/afile.rb",
+         path: "files/ubuntu/afile.rb",
+         full_path: "/cookbook-folder/files/ubuntu/afile.rb",
+         checksum: "csum-plat",
+         specificity: "ubuntu",
+       },
+       {
+         name: "files/afile.rb",
+         path: "files/default/afile.rb",
+         full_path: "/cookbook-folder/files/default/afile.rb",
+         checksum: "csum-default",
+         specificity: "default",
+       },
+
+       # for different/odd platform_versions
+       {
+         name: "files/bfile.rb",
+         path: "files/fakeos-2.0.rc.1/bfile.rb",
+         full_path: "/cookbook-folder/files/fakeos-2.0.rc.1/bfile.rb",
+         checksum: "csum2-platver-full",
+         specificity: "fakeos-2.0.rc.1",
+       },
+       {
+         name: "files/bfile.rb",
+         path: "files/newfakeos-2.0.rc/bfile.rb",
+         full_path: "/cookbook-folder/files/newfakeos-2.0.rc/bfile.rb",
+         checksum: "csum2-platver-partial",
+         specificity: "newfakeos-2.0.rc",
+       },
+       {
+         name: "files/bfile.rb",
+         path: "files/fakeos-maple tree/bfile.rb",
+         full_path: "/cookbook-folder/files/fakeos-maple tree/bfile.rb",
+         checksum: "csum3-platver-full",
+         specificity: "maple tree",
+       },
+       {
+         name: "files/bfile.rb",
+         path: "files/fakeos-1/bfile.rb",
+         full_path: "/cookbook-folder/files/fakeos-1/bfile.rb",
+         checksum: "csum4-platver-full",
+         specificity: "fakeos-1",
+       },
+
+       # directory adirectory
+       {
+         name: "files/anotherfile1.rb",
+         path: "files/root_directory/anotherfile1.rb.root",
+         checksum: "csum-root-directory",
+         specificity: "root_directory",
+       },
+
+       {
+         name: "files/anotherfile1.rb",
+         path: "files/host-examplehost.example.org/adirectory/anotherfile1.rb.host",
+         full_path: "/cookbook-folder/files/host-examplehost.example.org/adirectory/anotherfile1.rb.host",
+         checksum: "csum-host-1",
+         specificity: "host-examplehost.example.org",
+       },
+       {
+         name: "files/anotherfile2.rb",
+         path: "files/host-examplehost.example.org/adirectory/anotherfile2.rb.host",
+         full_path: "/cookbook-folder/files/host-examplehost.example.org/adirectory/anotherfile2.rb.host",
+         checksum: "csum-host-2",
+         specificity: "host-examplehost.example.org",
+       },
+
+       {
+         name: "files/anotherfile1.rb",
+         path: "files/ubuntu-9.10/adirectory/anotherfile1.rb.platform-full-version",
+         full_path: "/cookbook-folder/files/ubuntu-9.10/adirectory/anotherfile1.rb.platform-full-version",
+         checksum: "csum-platver-full-1",
+         specificity: "ubuntu-9.10",
+       },
+       {
+         name: "files/anotherfile2.rb",
+         path: "files/ubuntu-9.10/adirectory/anotherfile2.rb.platform-full-version",
+         full_path: "/cookbook-folder/files/ubuntu-9.10/adirectory/anotherfile2.rb.platform-full-version",
+         checksum: "csum-platver-full-2",
+         specificity: "ubuntu-9.10",
+       },
+
+       {
+         name: "files/anotherfile1.rb",
+         path: "files/newubuntu-9/adirectory/anotherfile1.rb.platform-partial-version",
+         full_path: "/cookbook-folder/files/newubuntu-9/adirectory/anotherfile1.rb.platform-partial-version",
+         checksum: "csum-platver-partial-1",
+         specificity: "newubuntu-9",
+       },
+       {
+         name: "files/anotherfile2.rb",
+         path: "files/newubuntu-9/adirectory/anotherfile2.rb.platform-partial-version",
+         full_path: "/cookbook-folder/files/newubuntu-9/adirectory/anotherfile2.rb.platform-partial-version",
+         checksum: "csum-platver-partial-2",
+         specificity: "nweubuntu-9",
+       },
+
+       {
+         name: "files/anotherfile1.rb",
+         path: "files/ubuntu/adirectory/anotherfile1.rb.platform",
+         full_path: "/cookbook-folder/files/ubuntu/adirectory/anotherfile1.rb.platform",
+         checksum: "csum-plat-1",
+         specificity: "ubuntu",
+       },
+       {
+         name: "files/anotherfile2.rb",
+         path: "files/ubuntu/adirectory/anotherfile2.rb.platform",
+         full_path: "/cookbook-folder/files/ubuntu/adirectory/anotherfile2.rb.platform",
+         checksum: "csum-plat-2",
+         specificity: "ubuntu",
+       },
+
+       {
+         name: "files/anotherfile1.rb",
+         path: "files/default/adirectory/anotherfile1.rb.default",
+         full_path: "/cookbook-folder/files/default/adirectory/anotherfile1.rb.default",
+         checksum: "csum-default-1",
+         specificity: "default",
+       },
+       {
+         name: "files/anotherfile2.rb",
+         path: "files/default/adirectory/anotherfile2.rb.default",
+         full_path: "/cookbook-folder/files/default/adirectory/anotherfile2.rb.default",
+         checksum: "csum-default-2",
+         specificity: "default",
+       },
+       # for different/odd platform_versions
+       {
+         name: "files/anotherfile1.rb",
+         path: "files/fakeos-2.0.rc.1/adirectory/anotherfile1.rb.platform-full-version",
+         full_path: "/cookbook-folder/files/fakeos-2.0.rc.1/adirectory/anotherfile1.rb.platform-full-version",
+         checksum: "csum2-platver-full-1",
+         specificity: "fakeos-2.0.rc.1",
+       },
+       {
+         name: "files/anotherfile2.rb",
+         path: "files/fakeos-2.0.rc.1/adirectory/anotherfile2.rb.platform-full-version",
+         full_path: "/cookbook-folder/files/fakeos-2.0.rc.1/adirectory/anotherfile2.rb.platform-full-version",
+         checksum: "csum2-platver-full-2",
+         specificity: "fakeos-2.0.rc.1",
+       },
+       {
+         name: "files/anotherfile1.rb",
+         path: "files/newfakeos-2.0.rc.1/adirectory/anotherfile1.rb.platform-partial-version",
+         full_path: "/cookbook-folder/files/newfakeos-2.0.rc.1/adirectory/anotherfile1.rb.platform-partial-version",
+         checksum: "csum2-platver-partial-1",
+         specificity: "newfakeos-2.0.rc",
+       },
+       {
+         name: "files/anotherfile2.rb",
+         path: "files/newfakeos-2.0.rc.1/adirectory/anotherfile2.rb.platform-partial-version",
+         full_path: "/cookbook-folder/files/newfakeos-2.0.rc.1/adirectory/anotherfile2.rb.platform-partial-version",
+         checksum: "csum2-platver-partial-2",
+         specificity: "newfakeos-2.0.rc",
+       },
+       {
+         name: "files/anotherfile1.rb",
+         path: "files/fakeos-maple tree/adirectory/anotherfile1.rb.platform-full-version",
+         full_path: "/cookbook-folder/files/fakeos-maple tree/adirectory/anotherfile1.rb.platform-full-version",
+         checksum: "csum3-platver-full-1",
+         specificity: "fakeos-maple tree",
+       },
+       {
+         name: "files/anotherfile2.rb",
+         path: "files/fakeos-maple tree/adirectory/anotherfile2.rb.platform-full-version",
+         full_path: "/cookbook-folder/files/fakeos-maple tree/adirectory/anotherfile2.rb.platform-full-version",
+         checksum: "csum3-platver-full-2",
+         specificity: "fakeos-maple tree",
+       },
+       {
+         name: "files/anotherfile1.rb",
+         path: "files/fakeos-1/adirectory/anotherfile1.rb.platform-full-version",
+         full_path: "/cookbook-folder/files/fakeos-1/adirectory/anotherfile1.rb.platform-full-version",
+         checksum: "csum4-platver-full-1",
+         specificity: "fakeos-1",
+       },
+       {
+         name: "files/anotherfile2.rb",
+         path: "files/fakeos-1/adirectory/anotherfile2.rb.platform-full-version",
+         full_path: "/cookbook-folder/files/fakeos-1/adirectory/anotherfile2.rb.platform-full-version",
+         checksum: "csum4-platver-full-2",
+         specificity: "fakeos-1",
+       },
+      ],
+    }
+
+  end
+
+  it "should return a manifest record based on priority preference: host" do
+    node = Chef::Node.new
+    node.automatic_attrs[:platform] = "ubuntu"
+    node.automatic_attrs[:platform_version] = "9.10"
+    node.automatic_attrs[:fqdn] = "examplehost.example.org"
+
+    manifest_record = @cookbook.preferred_manifest_record(node, :files, "afile.rb")
+    expect(manifest_record).not_to be_nil
+    expect(manifest_record[:checksum]).to eq("csum-host")
+  end
+
+  it "should return a manifest record based on priority preference: platform & full version" do
+    node = Chef::Node.new
+    node.automatic_attrs[:platform] = "ubuntu"
+    node.automatic_attrs[:platform_version] = "9.10"
+    node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+    manifest_record = @cookbook.preferred_manifest_record(node, :files, "afile.rb")
+    expect(manifest_record).not_to be_nil
+    expect(manifest_record[:checksum]).to eq("csum-platver-full")
+  end
+
+  it "should return a manifest record based on priority preference: platform & partial version" do
+    node = Chef::Node.new
+    node.automatic_attrs[:platform] = "newubuntu"
+    node.automatic_attrs[:platform_version] = "9.10"
+    node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+    manifest_record = @cookbook.preferred_manifest_record(node, :files, "afile.rb")
+    expect(manifest_record).not_to be_nil
+    expect(manifest_record[:checksum]).to eq("csum-platver-partial")
+  end
+
+  it "should return a manifest record based on priority preference: platform only" do
+    node = Chef::Node.new
+    node.automatic_attrs[:platform] = "ubuntu"
+    node.automatic_attrs[:platform_version] = "1.0"
+    node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+    manifest_record = @cookbook.preferred_manifest_record(node, :files, "afile.rb")
+    expect(manifest_record).not_to be_nil
+    expect(manifest_record[:checksum]).to eq("csum-plat")
+  end
+
+  it "should return a manifest record based on priority preference: default" do
+    node = Chef::Node.new
+    node.automatic_attrs[:platform] = "notubuntu"
+    node.automatic_attrs[:platform_version] = "1.0"
+    node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+    manifest_record = @cookbook.preferred_manifest_record(node, :files, "afile.rb")
+    expect(manifest_record).not_to be_nil
+    expect(manifest_record[:checksum]).to eq("csum-default")
+  end
+
+  it "should return a manifest record based on priority preference: platform & full version - platform_version variant 1" do
+    node = Chef::Node.new
+    node.automatic_attrs[:platform] = "fakeos"
+    node.automatic_attrs[:platform_version] = "2.0.rc.1"
+    node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+    manifest_record = @cookbook.preferred_manifest_record(node, :files, "bfile.rb")
+    expect(manifest_record).not_to be_nil
+    expect(manifest_record[:checksum]).to eq("csum2-platver-full")
+  end
+
+  it "should return a manifest record based on priority preference: platform & partial version - platform_version variant 1" do
+    node = Chef::Node.new
+    node.automatic_attrs[:platform] = "newfakeos"
+    node.automatic_attrs[:platform_version] = "2.0.rc.1"
+    node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+    manifest_record = @cookbook.preferred_manifest_record(node, :files, "bfile.rb")
+    expect(manifest_record).not_to be_nil
+    expect(manifest_record[:checksum]).to eq("csum2-platver-partial")
+  end
+
+  it "should return a manifest record based on priority preference: platform & full version - platform_version variant 2" do
+    node = Chef::Node.new
+    node.automatic_attrs[:platform] = "fakeos"
+    node.automatic_attrs[:platform_version] = "maple tree"
+    node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+    manifest_record = @cookbook.preferred_manifest_record(node, :files, "bfile.rb")
+    expect(manifest_record).not_to be_nil
+    expect(manifest_record[:checksum]).to eq("csum3-platver-full")
+  end
+
+  it "should return a manifest record based on priority preference: platform & full version - platform_version variant 3" do
+    node = Chef::Node.new
+    node.automatic_attrs[:platform] = "fakeos"
+    node.automatic_attrs[:platform_version] = "1"
+    node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+    manifest_record = @cookbook.preferred_manifest_record(node, :files, "bfile.rb")
+    expect(manifest_record).not_to be_nil
+    expect(manifest_record[:checksum]).to eq("csum4-platver-full")
+  end
+
+  it "should raise a FileNotFound exception without match" do
+    node = Chef::Node.new
+
+    expect do
+      @cookbook.preferred_manifest_record(node, :files, "doesn't_exist.rb")
+    end.to raise_error(Chef::Exceptions::FileNotFound)
+  end
+  it "should raise a FileNotFound exception consistently without match" do
+    node = Chef::Node.new
+
+    expect do
+      @cookbook.preferred_manifest_record(node, :files, "doesn't_exist.rb")
+    end.to raise_error(Chef::Exceptions::FileNotFound)
+
+    expect do
+      @cookbook.preferred_manifest_record(node, :files, "doesn't_exist.rb")
+    end.to raise_error(Chef::Exceptions::FileNotFound)
+
+    expect do
+      @cookbook.preferred_manifest_record(node, :files, "doesn't_exist.rb")
+    end.to raise_error(Chef::Exceptions::FileNotFound)
+  end
+
+  describe "when fetching the contents of a directory by file specificity" do
+
+    it "should return a directory of manifest records based on priority preference: host" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "ubuntu"
+      node.automatic_attrs[:platform_version] = "9.10"
+      node.automatic_attrs[:fqdn] = "examplehost.example.org"
+
+      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
+      expect(manifest_records).not_to be_nil
+      expect(manifest_records.size).to eq(2)
+
+      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
+      expect(checksums.sort).to eq(["csum-host-1", "csum-host-2"])
+    end
+
+    it "should return a directory of manifest records based on priority preference: platform & full version" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "ubuntu"
+      node.automatic_attrs[:platform_version] = "9.10"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
+      expect(manifest_records).not_to be_nil
+      expect(manifest_records.size).to eq(2)
+
+      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
+      expect(checksums.sort).to eq(["csum-platver-full-1", "csum-platver-full-2"])
+    end
+
+    it "should return a directory of manifest records based on priority preference: platform & partial version" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "newubuntu"
+      node.automatic_attrs[:platform_version] = "9.10"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
+      expect(manifest_records).not_to be_nil
+      expect(manifest_records.size).to eq(2)
+
+      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
+      expect(checksums.sort).to eq(["csum-platver-partial-1", "csum-platver-partial-2"])
+    end
+
+    it "should return a directory of manifest records based on priority preference: platform only" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "ubuntu"
+      node.automatic_attrs[:platform_version] = "1.0"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
+      expect(manifest_records).not_to be_nil
+      expect(manifest_records.size).to eq(2)
+
+      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
+      expect(checksums.sort).to eq(["csum-plat-1", "csum-plat-2"])
+    end
+
+    it "should return a directory of manifest records based on priority preference: default" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "notubuntu"
+      node.automatic_attrs[:platform_version] = "1.0"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
+      expect(manifest_records).not_to be_nil
+      expect(manifest_records.size).to eq(2)
+
+      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
+      expect(checksums.sort).to eq(["csum-default-1", "csum-default-2"])
+    end
+
+    it "should return a manifest record based on priority preference: platform & full version - platform_version variant 1" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "fakeos"
+      node.automatic_attrs[:platform_version] = "2.0.rc.1"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
+      expect(manifest_records).not_to be_nil
+      expect(manifest_records.size).to eq(2)
+
+      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
+      expect(checksums.sort).to eq(["csum2-platver-full-1", "csum2-platver-full-2"])
+    end
+
+    it "should return a manifest record based on priority preference: platform & partial version - platform_version variant 1" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "newfakeos"
+      node.automatic_attrs[:platform_version] = "2.0.rc.1"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
+      expect(manifest_records).not_to be_nil
+      expect(manifest_records.size).to eq(2)
+
+      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
+      expect(checksums.sort).to eq(["csum2-platver-partial-1", "csum2-platver-partial-2"])
+    end
+
+    it "should return a manifest record based on priority preference: platform & full version - platform_version variant 2" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "fakeos"
+      node.automatic_attrs[:platform_version] = "maple tree"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
+      expect(manifest_records).not_to be_nil
+      expect(manifest_records.size).to eq(2)
+
+      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
+      expect(checksums.sort).to eq(["csum3-platver-full-1", "csum3-platver-full-2"])
+    end
+
+    it "should return a manifest record based on priority preference: platform & full version - platform_version variant 3" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "fakeos"
+      node.automatic_attrs[:platform_version] = "1"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      manifest_records = @cookbook.preferred_manifest_records_for_directory(node, :files, "adirectory")
+      expect(manifest_records).not_to be_nil
+      expect(manifest_records.size).to eq(2)
+
+      checksums = manifest_records.map { |manifest_record| manifest_record[:checksum] }
+      expect(checksums.sort).to eq(["csum4-platver-full-1", "csum4-platver-full-2"])
+    end
+  end
+
+  ## Globbing the relative paths out of the manifest records ##
+
+  describe "when globbing for relative file paths based on filespecificity" do
+    it "should return a list of relative paths based on priority preference: root directory" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "ubuntu"
+      node.automatic_attrs[:platform_version] = "9.10"
+      node.automatic_attrs[:fqdn] = "examplehost.example.org"
+
+      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "root_directory")
+      expect(filenames).not_to be_nil
+      expect(filenames.size).to eq(1)
+
+      expect(filenames.sort).to eq(["anotherfile1.rb.root"])
+    end
+
+    it "should return a list of relative paths based on priority preference: host" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "ubuntu"
+      node.automatic_attrs[:platform_version] = "9.10"
+      node.automatic_attrs[:fqdn] = "examplehost.example.org"
+
+      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
+      expect(filenames).not_to be_nil
+      expect(filenames.size).to eq(2)
+
+      expect(filenames.sort).to eq(["anotherfile1.rb.host", "anotherfile2.rb.host"])
+    end
+
+    it "should return a list of relative paths based on priority preference: platform & full version" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "ubuntu"
+      node.automatic_attrs[:platform_version] = "9.10"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
+      expect(filenames).not_to be_nil
+      expect(filenames.size).to eq(2)
+
+      expect(filenames.sort).to eq(["anotherfile1.rb.platform-full-version", "anotherfile2.rb.platform-full-version"])
+    end
+
+    it "should return a list of relative paths based on priority preference: platform & partial version" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "newubuntu"
+      node.automatic_attrs[:platform_version] = "9.10"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
+      expect(filenames).not_to be_nil
+      expect(filenames.size).to eq(2)
+
+      expect(filenames.sort).to eq(["anotherfile1.rb.platform-partial-version", "anotherfile2.rb.platform-partial-version"])
+    end
+
+    it "should return a list of relative paths based on priority preference: platform only" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "ubuntu"
+      node.automatic_attrs[:platform_version] = "1.0"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
+      expect(filenames).not_to be_nil
+      expect(filenames.size).to eq(2)
+
+      expect(filenames.sort).to eq(["anotherfile1.rb.platform", "anotherfile2.rb.platform"])
+    end
+
+    it "should return a list of relative paths based on priority preference: default" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "notubuntu"
+      node.automatic_attrs[:platform_version] = "1.0"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
+      expect(filenames).not_to be_nil
+      expect(filenames.size).to eq(2)
+
+      expect(filenames.sort).to eq(["anotherfile1.rb.default", "anotherfile2.rb.default"])
+    end
+
+    it "should return a list of relative paths based on priority preference: platform & full version - platform_version variant 1" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "fakeos"
+      node.automatic_attrs[:platform_version] = "2.0.rc.1"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
+      expect(filenames).not_to be_nil
+      expect(filenames.size).to eq(2)
+
+      expect(filenames.sort).to eq(["anotherfile1.rb.platform-full-version", "anotherfile2.rb.platform-full-version"])
+    end
+
+    it "should return a list of relative paths based on priority preference: platform & partial version - platform_version variant 1" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "newfakeos"
+      node.automatic_attrs[:platform_version] = "2.0.rc.1"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
+      expect(filenames).not_to be_nil
+      expect(filenames.size).to eq(2)
+
+      expect(filenames.sort).to eq(["anotherfile1.rb.platform-partial-version", "anotherfile2.rb.platform-partial-version"])
+    end
+
+    it "should return a list of relative paths based on priority preference: platform & full version - platform_version variant 2" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "fakeos"
+      node.automatic_attrs[:platform_version] = "maple tree"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
+      expect(filenames).not_to be_nil
+      expect(filenames.size).to eq(2)
+
+      expect(filenames.sort).to eq(["anotherfile1.rb.platform-full-version", "anotherfile2.rb.platform-full-version"])
+    end
+
+    it "should return a list of relative paths based on priority preference: platform & full version - platform_version variant 3" do
+      node = Chef::Node.new
+      node.automatic_attrs[:platform] = "fakeos"
+      node.automatic_attrs[:platform_version] = "1"
+      node.automatic_attrs[:fqdn] = "differenthost.example.org"
+
+      filenames = @cookbook.relative_filenames_in_preferred_directory(node, :files, "adirectory")
+      expect(filenames).not_to be_nil
+      expect(filenames.size).to eq(2)
+
+      expect(filenames.sort).to eq(["anotherfile1.rb.platform-full-version", "anotherfile2.rb.platform-full-version"])
+    end
+  end
+end