chef 13.12.14-universal-mingw32 → 14.0.190-universal-mingw32

data/spec/unit/resource/windows_printer_port_spec.rb

@@ -0,0 +1,45 @@
+#
+# Copyright:: Copyright 2018, Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::WindowsPrinterPort do
+  let(:resource) { Chef::Resource::WindowsPrinterPort.new("63.192.209.236") }
+
+  it "sets resource name as :windows_printer_port" do
+    expect(resource.resource_name).to eql(:windows_printer_port)
+  end
+
+  it "sets the ipv4_address as its name" do
+    expect(resource.ipv4_address).to eql("63.192.209.236")
+  end
+
+  it "sets the default action as :create" do
+    expect(resource.action).to eql([:create])
+  end
+
+  it "supports :create and :delete actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :delete }.not_to raise_error
+    expect { resource.action :remove }.to raise_error(ArgumentError)
+  end
+
+  it "raises an error if ipv4_address isn't in X.X.X.X format" do
+    expect { resource.ipv4_address "63.192.209.236" }.not_to raise_error
+    expect { resource.ipv4_address "a.b.c.d" }.to raise_error(ArgumentError)
+  end
+end

data/spec/unit/resource/windows_printer_spec.rb

@@ -0,0 +1,45 @@
+#
+# Copyright:: Copyright 2018, Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::WindowsPrinter do
+  let(:resource) { Chef::Resource::WindowsPrinter.new("some_printer") }
+
+  it "sets resource name as :windows_printer" do
+    expect(resource.resource_name).to eql(:windows_printer)
+  end
+
+  it "sets the device_id as its name" do
+    expect(resource.device_id).to eql("some_printer")
+  end
+
+  it "sets the default action as :create" do
+    expect(resource.action).to eql([:create])
+  end
+
+  it "supports :create and :delete actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :delete }.not_to raise_error
+    expect { resource.action :remove }.to raise_error(ArgumentError)
+  end
+
+  it "raises an error if ipv4_address isn't in X.X.X.X format" do
+    expect { resource.ipv4_address "63.192.209.236" }.not_to raise_error
+    expect { resource.ipv4_address "a.b.c.d" }.to raise_error(ArgumentError)
+  end
+end

data/spec/unit/resource/windows_service_spec.rb

@@ -29,10 +29,6 @@ describe Chef::Resource::WindowsService, "initialize" do
 
   let(:resource) { Chef::Resource::WindowsService.new("BITS") }
 
-  it "returns a Chef::Resource::WindowsService" do
-    expect(resource).to be_a_kind_of(Chef::Resource::WindowsService)
-  end
-
   it "sets the resource_name to :windows_service" do
     expect(resource.resource_name).to eql(:windows_service)
   end
@@ -46,4 +42,29 @@ describe Chef::Resource::WindowsService, "initialize" do
     resource.action :configure_startup
     expect(resource.action).to eq([:configure_startup])
   end
+
+  # Attributes that are Strings
+  %i{description service_name binary_path_name load_order_group dependencies
+     run_as_user run_as_password display_name}.each do |prop|
+    it "support setting #{prop}" do
+      resource.send("#{prop}=", "some value")
+      expect(resource.send(prop)).to eq("some value")
+    end
+  end
+
+  # Attributes that are Integers
+  %i{desired_access error_control service_type}.each do |prop|
+    it "support setting #{prop}" do
+      resource.send("#{prop}=", 1)
+      expect(resource.send(prop)).to eq(1)
+    end
+  end
+
+  # Attributes that are Booleans
+  %i{delayed_start}.each do |prop|
+    it "support setting #{prop}" do
+      resource.send("#{prop}=", true)
+      expect(resource.send(prop)).to eq(true)
+    end
+  end
 end

data/spec/unit/resource/windows_shortcut_spec.rb

@@ -0,0 +1,39 @@
+#
+# Copyright:: Copyright 2018, Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::WindowsShortcut do
+  let(:resource) { Chef::Resource::WindowsShortcut.new("some_path") }
+
+  it "sets resource name as :windows_shortcut" do
+    expect(resource.resource_name).to eql(:windows_shortcut)
+  end
+
+  it "sets the shortcut_name property as its name" do
+    expect(resource.shortcut_name).to eql("some_path")
+  end
+
+  it "sets the default action as :create" do
+    expect(resource.action).to eql([:create])
+  end
+
+  it "supports :create action only" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :delete }.to raise_error(ArgumentError)
+  end
+end

data/spec/unit/resource/windows_task_spec.rb

@@ -21,11 +21,6 @@ require "spec_helper"
 describe Chef::Resource::WindowsTask do
   let(:resource) { Chef::Resource::WindowsTask.new("sample_task") }
 
-  it "creates a new Chef::Resource::WindowsTask" do
-    expect(resource).to be_a_kind_of(Chef::Resource)
-    expect(resource).to be_a_instance_of(Chef::Resource::WindowsTask)
-  end
-
   it "sets resource name as :windows_task" do
     expect(resource.resource_name).to eql(:windows_task)
   end

data/spec/unit/resource/yum_repository_spec.rb

@@ -32,6 +32,10 @@ describe Chef::Resource::YumRepository do
     expect(resource.repositoryid).to eq("multiverse")
   end
 
+  it "fails if the user provides a repositoryid with a forward slash" do
+    expect { resource.repositoryid "foo/bar" }.to raise_error(ArgumentError)
+  end
+
   it "the timeout property expects numeric Strings" do
     expect { resource.timeout "123" }.not_to raise_error(ArgumentError)
     expect { resource.timeout "123foo" }.to raise_error(ArgumentError)

data/spec/unit/resource/zypper_repository_spec.rb

@@ -32,6 +32,10 @@ describe Chef::Resource::ZypperRepository do
     expect(resource.repo_name).to eql("repo-source")
   end
 
+  it "fails if the user provides a repo_name with a forward slash" do
+    expect { resource.repo_name "foo/bar" }.to raise_error(ArgumentError)
+  end
+
   it "has a default action of create" do
     expect(resource.action).to eql([:create])
   end

data/spec/unit/resource_inspector_spec.rb

@@ -0,0 +1,60 @@
+# Copyright:: Copyright 2018, Chef Software, Inc
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+require "chef/resource_inspector"
+
+class DummyResource < Chef::Resource
+  resource_name :dummy
+  description "A dummy resource"
+  examples <<~EOH
+  dummy "foo" do
+    first "yes"
+  end
+  EOH
+  introduced "14.0"
+  property :first, String, description: "My First Property", introduced: "14.0"
+
+  action :dummy do
+    return true
+  end
+end
+
+describe ResourceInspector do
+  describe "inspecting a resource" do
+    subject { ResourceInspector.extract_resource(DummyResource, false) }
+
+    it "returns a hash with required data" do
+      expect(subject[:description]).to eq "A dummy resource"
+      expect(subject[:actions]).to match_array [:nothing, :dummy]
+    end
+
+    context "excluding built in properties" do
+      it "returns a single property" do
+        expect(subject[:properties].count).to eq 1
+        expect(subject[:properties].first[:name]).to eq :first
+      end
+    end
+
+    context "including built in properties" do
+      subject { ResourceInspector.extract_resource(DummyResource, true) }
+      it "returns many properties" do
+        expect(subject[:properties].count).to be > 1
+        expect(subject[:properties].map { |n| n[:name] }).to include(:name, :first, :sensitive)
+      end
+    end
+  end
+end

data/spec/unit/resource_reporter_spec.rb

@@ -285,7 +285,7 @@ describe Chef::ResourceReporter do
       end
 
       it "resource_command in prepared_run_data should be blank" do
-        expect(@first_update_report["after"]).to eq({ :command => "sensitive-resource", :user => nil })
+        expect(@first_update_report["after"]).to eq({ :command => "sensitive-resource" })
       end
     end
 
@@ -635,7 +635,7 @@ describe Chef::ResourceReporter do
       end
 
       it "prints an error about the 404" do
-        expect(Chef::Log).to receive(:debug).with(/404/)
+        expect(Chef::Log).to receive(:trace).with(/404/)
         @resource_reporter.run_started(@run_status)
       end
 

data/spec/unit/resource_spec.rb

@@ -555,11 +555,6 @@ end
       resource.ignore_failure(true)
       expect(resource.ignore_failure).to eq(true)
     end
-
-    it "should allow you to epic_fail" do
-      resource.epic_fail(true)
-      expect(resource.epic_fail).to eq(true)
-    end
   end
 
   describe "retries" do

data/spec/unit/shell/shell_session_spec.rb

@@ -229,7 +229,6 @@ describe Shell::SoloLegacySession do
 
   it "runs chef with a resource collection from the compiled cookbooks" do
     allow(@session).to receive(:node_built?).and_return(true)
-    allow(Chef::Log).to receive(:level)
     chef_runner = double("Chef::Runner.new", :converge => :converged)
     expect(Chef::Runner).to receive(:new).with(an_instance_of(Chef::RunContext)).and_return(chef_runner)
 

data/spec/unit/user_spec.rb

@@ -17,7 +17,7 @@
 #
 
 # DEPRECATION NOTE
-# This code only remains to support users still	operating with
+# This code only remains to support users still  operating with
 # Open Source Chef Server 11 and should be removed once support
 # for OSC 11 ends. New development should occur in user_spec.rb.
 

data/spec/unit/util/windows/logon_session_spec.rb

@@ -27,7 +27,8 @@ describe ::Chef::Util::Windows::LogonSession do
     stub_const("Chef::ReservedNames::Win32::API::System", Class.new )
   end
 
-  let(:session) { ::Chef::Util::Windows::LogonSession.new(session_user, password, session_domain) }
+  let(:session) { ::Chef::Util::Windows::LogonSession.new(session_user, password, session_domain, authentication) }
+  let(:authentication) { :remote }
 
   shared_examples_for "it received syntactically invalid credentials" do
     it "does not raisees an exception when it is initialized" do

data/spec/unit/win32/security_spec.rb

@@ -59,8 +59,51 @@ describe "Chef::Win32::Security", :windows_only do
         expect(Chef::ReservedNames::Win32::Security).to receive(:SetNamedSecurityInfoW).and_return(
           Chef::ReservedNames::Win32::API::Error::ERROR_USER_NOT_FOUND
         )
-        expect { Chef::ReservedNames::Win32::Security.set_named_security_info "/temp_path", :SE_FILE_OBJECT, {} }.to raise_error Chef::Exceptions::Chef::Exceptions::UserIDNotFound
+        expect { Chef::ReservedNames::Win32::Security.set_named_security_info "/temp_path", :SE_FILE_OBJECT, {} }.to raise_error Chef::Exceptions::UserIDNotFound
       end
     end
   end
+
+  describe "self.has_admin_privileges?" do
+    context "when the user doesn't have admin privileges" do
+      it "returns false" do
+        allow(Chef::ReservedNames::Win32::Security).to receive(:open_current_process_token).and_raise("Access is denied.")
+        expect(Chef::ReservedNames::Win32::Security.has_admin_privileges?).to be false
+      end
+    end
+
+    context "when open_current_process_token fails with some other error than `Access is Denied`" do
+      it "raises error" do
+        allow(Chef::ReservedNames::Win32::Security).to receive(:open_current_process_token).and_raise("boom")
+        expect { Chef::ReservedNames::Win32::Security.has_admin_privileges? }.to raise_error(Chef::Exceptions::Win32APIError)
+      end
+    end
+
+    context "when the user has admin privileges" do
+      it "returns true" do
+        allow(Chef::ReservedNames::Win32::Security).to receive(:open_current_process_token)
+        token = Chef::ReservedNames::Win32::Security.open_current_process_token
+        allow(token).to receive_message_chain(:handle, :handle)
+        allow(Chef::ReservedNames::Win32::Security).to receive(:get_token_information_elevation_type)
+        allow(Chef::ReservedNames::Win32::Security).to receive(:GetTokenInformation).and_return(true)
+        allow_any_instance_of(FFI::Buffer).to receive(:read_ulong).and_return(1)
+        expect(Chef::ReservedNames::Win32::Security.has_admin_privileges?).to be true
+      end
+    end
+  end
+
+  describe "self.get_token_information_elevation_type" do
+    let(:token_rights) { Chef::ReservedNames::Win32::Security::TOKEN_READ }
+
+    let(:token) do
+      Chef::ReservedNames::Win32::Security.open_process_token(
+        Chef::ReservedNames::Win32::Process.get_current_process,
+        token_rights)
+    end
+
+    it "raises error if GetTokenInformation fails" do
+      allow(Chef::ReservedNames::Win32::Security).to receive(:GetTokenInformation).and_return(false)
+      expect { Chef::ReservedNames::Win32::Security.get_token_information_elevation_type(token) }.to raise_error(Chef::Exceptions::Win32APIError)
+    end
+  end
 end

data/spec/unit/windows_service_spec.rb

@@ -38,10 +38,12 @@ describe "Chef::Application::WindowsService", :windows_only do
   end
 
   before do
+    monologger = instance_double("MonoLogger", :level= => nil, :add => nil, :formatter= => nil, :formatter => nil)
+    allow(MonoLogger).to receive(:new).and_return(monologger)
+
     Chef::Config.merge!(config_options)
     allow(subject).to receive(:configure_chef)
     allow(subject).to receive(:parse_options)
-    allow(MonoLogger).to receive(:new)
     allow(subject).to receive(:running?).and_return(true, false)
     allow(subject).to receive(:state).and_return(4)
     subject.service_init
@@ -98,7 +100,7 @@ describe "Chef::Application::WindowsService", :windows_only do
     end
   end
 
-  context "configueres a watchdog timeout" do
+  context "configures a watchdog timeout" do
     let(:timeout) { 10 }
 
     before do

data/tasks/announce.rb

@@ -1,5 +1,5 @@
 #
-# Copyright:: Copyright 2016-2018, Chef Software Inc.
+# Copyright:: Copyright (c) 2016 Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

data/tasks/cbgb.rb

@@ -0,0 +1,84 @@
+#
+# Author:: Thom May (tmay@chef.io)
+# Author:: Nathen Harvey (nharvey@chef.io)
+# Copyright:: Copyright 2015-2016, Chef Software, Inc
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "rake"
+
+CBGB_SOURCE = File.join(File.dirname(__FILE__), "..", "CBGB.toml")
+CBGB_TARGET = File.join(File.dirname(__FILE__), "..", "CBGB.md")
+
+begin
+  require "tomlrb"
+
+  task :default => :generate
+
+  namespace :cbgb do
+    desc "Generate MarkDown version of CBGB file"
+    task :generate do
+      cbgb = Tomlrb.load_file CBGB_SOURCE
+      out = "<!-- This is a generated file. Please do not edit directly -->\n"
+      out << "<!-- Modify CBGB.toml file and run `rake cbgb:generate` to regenerate -->\n\n"
+      out << "# " + cbgb["Preamble"]["title"] + "\n\n"
+      out << cbgb["Preamble"]["text"] + "\n"
+      out << "# Board of Governors\n\n"
+      out << "## " + cbgb["Org"]["Lead"]["title"] + "\n\n"
+      out << person(cbgb["people"], cbgb["Org"]["Lead"]["person"]) + "\n\n"
+      out << "### " + cbgb["Org"]["Contributors"]["title"] + "\n\n"
+      out << cbgb(cbgb["people"], cbgb["Org"]["Contributors"]["governers"]) + "\n\n"
+      out << "### " + cbgb["Org"]["Corporate-Contributors"]["title"] + "\n\n"
+      out << cbgb(cbgb["corporations"], cbgb["Org"]["Corporate-Contributors"]["governers"]) + "\n\n"
+      out << "### " + cbgb["Org"]["Lieutenants"]["title"] + "\n\n"
+      out << cbgb(cbgb["people"], cbgb["Org"]["Lieutenants"]["governers"]) + "\n\n"
+      File.open(CBGB_TARGET, "w") do |fn|
+        fn.write out
+      end
+    end
+  end
+
+  def components(list, cmp)
+    out = ""
+    cmp.each_value do |v|
+      out << "\n#### #{v['title'].gsub('#', '\\#')}\n"
+      out << cbgb(list, v["cbgb"])
+    end
+    out
+  end
+
+  def cbgb(list, people)
+    o = ""
+    people.each do |p|
+      o << person(list, p) + "\n"
+    end
+    o
+  end
+
+  def person(list, person)
+    if list[person].has_key?("GitHub")
+      out = "* [#{list[person]["Name"]}](https://github.com/#{list[person]["GitHub"]})"
+    else
+      out =  "* #{list[person]["Name"]}"
+    end
+    if list[person].has_key?("Person")
+      out << " - #{list[person]["Person"]}"
+    end
+    out
+  end
+
+rescue LoadError
+  STDERR.puts "\n*** TomlRb not available.\n\n"
+end