chef 13.12.14-universal-mingw32 → 14.0.190-universal-mingw32

data/spec/unit/resource/gem_package_spec.rb

@@ -31,12 +31,10 @@ describe Chef::Resource::GemPackage, "initialize" do
 end
 
 describe Chef::Resource::GemPackage, "gem_binary" do
-  before(:each) do
-    @resource = Chef::Resource::GemPackage.new("foo")
-  end
+  let(:resource) { Chef::Resource::GemPackage.new("foo") }
 
   it "sets the gem_binary variable to whatever is passed in" do
-    @resource.gem_binary("/opt/local/bin/gem")
-    expect(@resource.gem_binary).to eql("/opt/local/bin/gem")
+    resource.gem_binary("/opt/local/bin/gem")
+    expect(resource.gem_binary).to eql("/opt/local/bin/gem")
   end
 end

data/spec/unit/resource/git_spec.rb

@@ -30,9 +30,8 @@ describe Chef::Resource::Git do
 
   let(:resource) { Chef::Resource::Git.new("my awesome webapp") }
 
-  it "is a kind of Scm Resource" do
+  it "is a subclass of Chef::Resource::Scm" do
     expect(resource).to be_a_kind_of(Chef::Resource::Scm)
-    expect(resource).to be_an_instance_of(Chef::Resource::Git)
   end
 
   it "uses aliases revision as branch" do

data/spec/unit/resource/group_spec.rb

@@ -22,11 +22,6 @@ require "spec_helper"
 describe Chef::Resource::Group, "initialize" do
   let(:resource) { Chef::Resource::Group.new("admin") }
 
-  it "creates a new Chef::Resource::Group" do
-    expect(resource).to be_a_kind_of(Chef::Resource)
-    expect(resource).to be_a_kind_of(Chef::Resource::Group)
-  end
-
   it "sets the resource_name to :group" do
     expect(resource.resource_name).to eql(:group)
   end

data/spec/unit/resource/homebrew_cask_spec.rb

@@ -0,0 +1,35 @@
+#
+# Copyright:: Copyright 2018, Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::HomebrewCask do
+
+  let(:resource) { Chef::Resource::HomebrewCask.new("myapp") }
+
+  it "has a resource name of :homebrew_cask" do
+    expect(resource.resource_name).to eql(:homebrew_cask)
+  end
+
+  it "has a default action of install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "the cask_name property is the name property" do
+    expect(resource.cask_name).to eql("myapp")
+  end
+end

data/spec/unit/resource/homebrew_package_spec.rb

@@ -30,6 +30,10 @@ describe Chef::Resource::HomebrewPackage, "initialize" do
 
   let(:resource) { Chef::Resource::HomebrewPackage.new("emacs") }
 
+  it "is a subclass of Chef::Resource::Package" do
+    expect(resource).to be_a_kind_of(Chef::Resource::Package)
+  end
+
   shared_examples "home_brew user set and returned" do
     it "returns the configured homebrew_user" do
       resource.homebrew_user user

data/spec/unit/resource/homebrew_tap_spec.rb

@@ -0,0 +1,39 @@
+#
+# Copyright:: Copyright 2018, Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::HomebrewTap do
+
+  let(:resource) { Chef::Resource::HomebrewTap.new("user/mytap") }
+
+  it "has a resource name of :homebrew_tap" do
+    expect(resource.resource_name).to eql(:homebrew_tap)
+  end
+
+  it "has a default action of tap" do
+    expect(resource.action).to eql([:tap])
+  end
+
+  it "the tap_name property is the name property" do
+    expect(resource.tap_name).to eql("user/mytap")
+  end
+
+  it "fails if tap_name isn't in the USER/TAP format" do
+    expect { resource.tap_name "mytap" }.to raise_error(ArgumentError)
+  end
+end

data/spec/unit/resource/hostname_spec.rb

@@ -0,0 +1,43 @@
+#
+# Copyright:: Copyright 2018, Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::Hostname do
+
+  let(:resource) { Chef::Resource::Hostname.new("foo") }
+
+  it "has a resource name of :hostname" do
+    expect(resource.resource_name).to eql(:hostname)
+  end
+
+  it "has a default action of set" do
+    expect(resource.action).to eql([:set])
+  end
+
+  it "runs at compile_time by default" do
+    expect(resource.compile_time).to eql(true)
+  end
+
+  it "reboots windows nodes by default" do
+    expect(resource.windows_reboot).to eql(true)
+  end
+
+  it "the hostname property is the name property" do
+    expect(resource.hostname).to eql("foo")
+  end
+end

data/spec/unit/resource/http_request_spec.rb

@@ -22,11 +22,6 @@ require "spec_helper"
 describe Chef::Resource::HttpRequest do
   let(:resource) { Chef::Resource::HttpRequest.new("fakey_fakerton") }
 
-  it "creates a new Chef::Resource::HttpRequest" do
-    expect(resource).to be_a_kind_of(Chef::Resource)
-    expect(resource).to be_a_kind_of(Chef::Resource::HttpRequest)
-  end
-
   it "sets url to a string" do
     resource.url "http://slashdot.org"
     expect(resource.url).to eql("http://slashdot.org")

data/spec/unit/resource/ips_package_spec.rb

@@ -31,6 +31,10 @@ describe Chef::Resource::IpsPackage, "initialize" do
 
   let(:resource) { Chef::Resource::IpsPackage.new("crypto/gnupg") }
 
+  it "is a subclass of Chef::Resource::Package" do
+    expect(resource).to be_a_kind_of(Chef::Resource::Package)
+  end
+
   it "should support accept_license" do
     resource.accept_license(true)
     expect(resource.accept_license).to eql(true)

data/spec/unit/resource/ksh_spec.rb

@@ -22,9 +22,8 @@ describe Chef::Resource::Ksh do
 
   let(:resource) { Chef::Resource::Ksh.new("fakey_fakerton") }
 
-  it "creates a new Chef::Resource::Ksh" do
-    expect(resource).to be_a_kind_of(Chef::Resource)
-    expect(resource).to be_a_kind_of(Chef::Resource::Ksh)
+  it "is a subclass of Chef::Resource::Script" do
+    expect(resource).to be_a_kind_of(Chef::Resource::Script)
   end
 
   it "has a resource name of :ksh" do

data/spec/unit/resource/launchd_spec.rb

@@ -17,11 +17,6 @@ require "spec_helper"
 describe Chef::Resource::Launchd do
   let(:resource) { Chef::Resource::Launchd.new("io.chef.chef-client" ) }
 
-  it "creates a new Chef::Resource::Launchd" do
-    expect(resource).to be_a_kind_of(Chef::Resource)
-    expect(resource).to be_a_kind_of(Chef::Resource::Launchd)
-  end
-
   it "has a resource name of Launchd" do
     expect(resource.resource_name).to eql(:launchd)
   end

data/spec/unit/resource/link_spec.rb

@@ -26,12 +26,7 @@ describe Chef::Resource::Link do
     expect_any_instance_of(Chef::Resource::Link).to receive(:verify_links_supported!).and_return(true)
   end
 
-  it "creates a new Chef::Resource::Link" do
-    expect(resource).to be_a_kind_of(Chef::Resource)
-    expect(resource).to be_a_kind_of(Chef::Resource::Link)
-  end
-
-  it "has a name" do
+  it "has a name property" do
     expect(resource.name).to eql("fakey_fakerton")
   end
 

data/spec/unit/resource/log_spec.rb

@@ -24,11 +24,6 @@ describe Chef::Resource::Log do
   let(:log_str) { "this is my string to log" }
   let(:resource) { Chef::Resource::Log.new(log_str) }
 
-  it "creates a new Chef::Resource::Log" do
-    expect(resource).to be_a_kind_of(Chef::Resource)
-    expect(resource).to be_a_kind_of(Chef::Resource::Log)
-  end
-
   it "supports the :write actions" do
     expect(resource.allowed_actions).to include(:write)
   end

data/spec/unit/resource/macos_user_defaults_spec.rb

@@ -0,0 +1,45 @@
+#
+# Copyright:: Copyright 2018, Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::MacosUserDefaults do
+
+  let(:resource) { Chef::Resource::MacosUserDefaults.new("foo") }
+
+  it "has a resource name of :macos_userdefaults" do
+    expect(resource.resource_name).to eql(:macos_userdefaults)
+  end
+
+  it "has a default action of install" do
+    expect(resource.action).to eql([:write])
+  end
+
+  [true, "TRUE", "1", "true", "YES", "yes"].each do |val|
+    it "coerces value property from #{val} to 1" do
+      resource.value val
+      expect(resource.value).to eql(1)
+    end
+  end
+
+  [false, "FALSE", "0", "false", "NO", "no"].each do |val|
+    it "coerces value property from #{val} to 0" do
+      resource.value val
+      expect(resource.value).to eql(0)
+    end
+  end
+end

data/spec/unit/resource/mdadm_spec.rb

@@ -23,11 +23,6 @@ describe Chef::Resource::Mdadm do
 
   let(:resource) { Chef::Resource::Mdadm.new("fakey_fakerton") }
 
-  it "creates a new Chef::Resource::Mdadm" do
-    expect(resource).to be_a_kind_of(Chef::Resource)
-    expect(resource).to be_a_kind_of(Chef::Resource::Mdadm)
-  end
-
   it "has a resource name of :mdadm" do
     expect(resource.resource_name).to eql(:mdadm)
   end

data/spec/unit/resource/mount_spec.rb

@@ -22,12 +22,7 @@ require "spec_helper"
 describe Chef::Resource::Mount do
   let(:resource) { Chef::Resource::Mount.new("filesystem") }
 
-  it "creates a new Chef::Resource::Mount" do
-    expect(resource).to be_a_kind_of(Chef::Resource)
-    expect(resource).to be_a_kind_of(Chef::Resource::Mount)
-  end
-
-  it "has a name" do
+  it "has a name property" do
     expect(resource.name).to eql("filesystem")
   end
 

data/spec/unit/resource/msu_package_spec.rb

@@ -21,10 +21,8 @@ require "spec_helper"
 describe Chef::Resource::MsuPackage do
   let(:resource) { Chef::Resource::MsuPackage.new("test_pkg") }
 
-  it "creates a new Chef::Resource::MsuPackage" do
-    expect(resource).to be_a_kind_of(Chef::Resource)
+  it "is a subclass of Chef::Resource::Package" do
     expect(resource).to be_a_kind_of(Chef::Resource::Package)
-    expect(resource).to be_a_instance_of(Chef::Resource::MsuPackage)
   end
 
   it "sets resource name as :msu_package" do

data/spec/unit/resource/ohai_hint_spec.rb

@@ -0,0 +1,43 @@
+#
+# Copyright:: Copyright 2018, Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::OhaiHint do
+
+  let(:resource) { Chef::Resource::OhaiHint.new("foo") }
+
+  it "has a resource name of :ohai_hint" do
+    expect(resource.resource_name).to eql(:ohai_hint)
+  end
+
+  it "has a default action of create" do
+    expect(resource.action).to eql([:create])
+  end
+
+  it "supports the :nothing, :create and :delete actions" do
+    expect(resource.allowed_actions).to include(:nothing, :create, :delete)
+  end
+
+  it "runs at compile_time by default" do
+    expect(resource.compile_time).to eql(true)
+  end
+
+  it "the hint_name property is the name property" do
+    expect(resource.hint_name).to eql("foo")
+  end
+end

data/spec/unit/resource/ohai_spec.rb

@@ -22,11 +22,6 @@ describe Chef::Resource::Ohai do
 
   let(:resource) { Chef::Resource::Ohai.new("ohai_reload") }
 
-  it "creates a new Chef::Resource::Ohai" do
-    expect(resource).to be_a_kind_of(Chef::Resource)
-    expect(resource).to be_a_kind_of(Chef::Resource::Ohai)
-  end
-
   it "has a resource name of :ohai" do
     expect(resource.resource_name).to eql(:ohai)
   end

data/spec/unit/resource/openbsd_package_spec.rb

@@ -20,28 +20,24 @@
 #
 
 require "spec_helper"
-require "ostruct"
 
 describe Chef::Resource::OpenbsdPackage do
-
-  before(:each) do
-    @node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-    @resource = Chef::Resource::OpenbsdPackage.new("foo", @run_context)
-  end
+  let(:node) { Chef::Node.new }
+  let(:events) { Chef::EventDispatch::Dispatcher.new }
+  let(:run_context) { Chef::RunContext.new(node, {}, events) }
+  let(:resource) { Chef::Resource::OpenbsdPackage.new("foo", run_context) }
 
   describe "Initialization" do
-    it "returns a Chef::Resource::OpenbsdPackage" do
-      expect(@resource).to be_a_kind_of(Chef::Resource::OpenbsdPackage)
+    it "is a subclass of Chef::Resource::Package" do
+      expect(resource).to be_a_kind_of(Chef::Resource::Package)
     end
 
     it "sets the resource_name to :openbsd_package" do
-      expect(@resource.resource_name).to eql(:openbsd_package)
+      expect(resource.resource_name).to eql(:openbsd_package)
     end
 
     it "does not set the provider" do
-      expect(@resource.provider).to be_nil
+      expect(resource.provider).to be_nil
     end
   end
 

data/spec/unit/resource/openssl_dhparam.rb

@@ -0,0 +1,51 @@
+#
+# Copyright:: Copyright 2018, Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::OpensslDhparam do
+
+  let(:resource) { Chef::Resource::OpensslDhparam.new("dhparam") }
+
+  it "has a resource name of :openssl_dhparam" do
+    expect(resource.resource_name).to eql(:openssl_dhparam)
+  end
+
+  it "has a default action of create" do
+    expect(resource.action).to eql([:create])
+  end
+
+  it "has a default mode of '0640'" do
+    expect(resource.mode).to eql("0640")
+  end
+
+  it "has a default generator of 2" do
+    expect(resource.generator).to eql(2)
+  end
+
+  it "has a default key_length of 2048" do
+    expect(resource.key_length).to eql(2048)
+  end
+
+  it "only accepts valid key length" do
+    expect { resource.key_length 1234 }.to raise_error(ArgumentError)
+  end
+
+  it "the path property is the name property" do
+    expect(resource.path).to eql("dhparam")
+  end
+end