chef-provisioning-oneview 1.0.1 → 1.1.0

data/spec/unit/oneview_login_spec.rb

@@ -0,0 +1,23 @@
+require_relative './../spec_helper'
+
+RSpec.describe Chef::Provisioning::OneViewDriver do
+  include_context 'shared context'
+
+  describe 'login functions' do
+
+    it 'can parse the oneview sessionID' do
+      expect(@instance.instance_eval { login_to_oneview }).to match(@oneview_key)
+    end
+
+    it 'can parse the icsp sessionID' do
+      expect(@instance.instance_eval { login_to_icsp }).to match(@icsp_key)
+    end
+
+    it 'gets both auth tokens via the auth_tokens method' do
+      @instance.instance_eval { auth_tokens }
+      expect(@instance.instance_variable_get('@oneview_key')).to match(@oneview_key)
+      expect(@instance.instance_variable_get('@icsp_key')).to match(@icsp_key)
+    end
+  end
+
+end

data/spec/unit/oneview_power_spec.rb

@@ -0,0 +1,51 @@
+require_relative './../spec_helper'
+
+RSpec.describe Chef::Provisioning::OneViewDriver do
+  include_context 'shared context'
+
+  describe '#power_on' do
+    it 'calls set_power_state with correct params' do
+      a = action_handler
+      m = machine_spec
+      ret_val = @instance.instance_eval { power_on(a, m) }
+      expect(a_request(:get, %r{/rest/server-hardware/.*})).to have_been_made
+      expect(a_request(:put, %r{/rest/server-hardware/.*/powerState}).with(body: '{"powerState":"On","powerControl":"MomentaryPress"}')).to have_been_made
+      expect(ret_val).to match(%r{\/rest\/server-hardware\/.+})
+    end
+
+    it 'allows hardware_uri to be passed in' do
+      a = action_handler
+      m = machine_spec
+      @instance.instance_eval { power_on(a, m, '/rest/server-hardware/31363636-3136-584D-5132-333230314D38') }
+      expect(a_request(:get, %r{/rest/server-profiles})).to_not have_been_made
+    end
+  end
+
+  describe '#power_off' do
+    it 'calls set_power_state with correct params' do
+      a = action_handler
+      m = machine_spec
+      ret_val = @instance.instance_eval { power_off(a, m) }
+      expect(ret_val).to match(%r{\/rest\/server-hardware\/.+})
+      expect(a_request(:put, %r{/rest/server-hardware/.*/powerState}).with(body: '{"powerState":"Off","powerControl":"MomentaryPress"}')).to have_been_made
+    end
+
+    it 'allows hardware_uri to be passed in' do
+      a = action_handler
+      m = machine_spec
+      @instance.instance_eval { power_off(a, m, '/rest/server-hardware/31363636-3136-584D-5132-333230314D38') }
+      expect(a_request(:get, %r{/rest/server-profiles})).to_not have_been_made
+    end
+  end
+
+  describe '#set_power_state' do
+
+    it 'fails when an invalid state is requested' do
+      a = action_handler
+      m = machine_spec
+      expect { @instance.instance_eval { set_power_state(a, m, :invalid) } }.to raise_error('Invalid power state invalid')
+    end
+
+  end
+
+end

data/spec/unit/oneview_san_spec.rb

@@ -0,0 +1,86 @@
+require_relative './../spec_helper'
+
+RSpec.describe Chef::Provisioning::OneViewDriver do
+  include_context 'shared context'
+
+  describe '#fill_volume_details' do
+    it 'fills the correct volume details' do
+      profile = @instance.instance_eval { get_oneview_template('Template - Web Server with SAN') }
+      v = profile['sanStorage']['volumeAttachments'].first
+      expect(v['volumeName']).to be_nil
+      expect(v['volumeShareable']).to be_nil
+      @instance.instance_eval { fill_volume_details(v) }
+      expect(a_request(:get, /#{v['volumeUri']}/)).to have_been_made
+      expect(v['volumeName']).to eq('bootVol')
+      expect(v['volumeShareable']).to be false
+    end
+  end
+
+  describe '#update_san_info' do
+    context 'profile coppies (OV 1.2)' do
+      it 'prepares copies of profiles for SAN storage' do
+        m = machine_spec
+        profile = @instance.instance_eval { get_oneview_template('Template - Web Server with SAN') }
+        profile['name'] = 'web01'
+        ret_val = @instance.instance_eval { update_san_info(m, profile) }
+        v = ret_val['sanStorage']['volumeAttachments'].first
+        expect(v['uri']).to be_nil
+        expect(v['volumeName']).to eq('bootVol web01')
+        expect(v['lun']).to eq('0')
+      end
+    end
+
+    context 'Server Profile Templates (OV 2.0)' do
+      before :each do
+        @instance.instance_variable_set('@current_oneview_api_version', 200)
+      end
+
+      it 'leaves profiles from Templates largely the same' do
+        m = machine_spec
+        profile = @instance.instance_eval { get_oneview_template('Web Server Template with SAN') }
+        ret_val = @instance.instance_eval { update_san_info(m, profile) }
+        expect(ret_val['sanStorage']['volumeAttachments'].first['storagePaths'].first.key?('state')).to be false
+      end
+
+      it 'appends the profile name to the volume name' do
+        m = machine_spec
+        profile = @instance.instance_eval { get_oneview_template('Web Server Template with SAN') }
+        profile['name'] = 'web01'
+        ret_val = @instance.instance_eval { update_san_info(m, profile) }
+        expect(ret_val['sanStorage']['volumeAttachments'].first['volumeName']).to eq('bootVol web01')
+      end
+
+      it 'requires profiles to specify the volumeShareable attribute' do
+        m = machine_spec
+        profile = @instance.instance_eval { get_oneview_template('Web Server Template with SAN') }
+        profile['sanStorage']['volumeAttachments'].first.delete('volumeShareable')
+        expect { @instance.instance_eval { update_san_info(m, profile) } }.to raise_error(/Should know if volume is sharable/)
+      end
+
+      it 'only allows 1 SAN boot volume' do
+        m = machine_spec
+        profile = @instance.instance_eval { get_oneview_template('Web Server Template with SAN') }
+        profile['sanStorage']['volumeAttachments'].push('id' => 2, 'volumeName' => 'bootVol2', 'volumeShareable' => true)
+        expect { @instance.instance_eval { update_san_info(m, profile) } }.to raise_error(/should only be 1 SAN boot volume/)
+      end
+    end
+  end
+
+  describe '#enable_boot_from_san' do
+    context 'Server Profile Templates (OV 2.0)' do
+      before :each do
+        @instance.instance_variable_set('@current_oneview_api_version', 200)
+      end
+
+      it 'configures connections to boot from a SAN volume' do
+        a = action_handler
+        m = machine_spec
+        profile = @instance.instance_eval { get_oneview_profile_by_sn('VCGE9KB042') }
+        ret_val = @instance.instance_eval { enable_boot_from_san(a, m, profile) }
+        expect(a_request(:get, /#{profile['sanStorage']['volumeAttachments'].first['volumeUri']}/)).to have_been_made
+        expect(ret_val['connections'].last['boot']['targets'].first['arrayWwpn']).to eq('21210002AC00159E')
+      end
+    end
+  end
+
+end

data/spec/unit/oneview_search_spec.rb

@@ -0,0 +1,63 @@
+require_relative './../spec_helper'
+
+RSpec.describe Chef::Provisioning::OneViewDriver do
+  include_context 'shared context'
+
+  describe '#get_oneview_profile_by_sn' do
+
+    it 'gets profile for a valid SN' do
+      ret_val = @instance.instance_eval { get_oneview_profile_by_sn('VCGE9KB041') }
+      expect(ret_val).to_not be_nil
+    end
+
+    it 'returns nil for fake SN' do
+      ret_val = @instance.instance_eval { get_oneview_profile_by_sn('11111BBBBB') }
+      expect(ret_val).to be_nil
+    end
+
+    it 'fails when an empty SN is given' do
+      expect { @instance.instance_eval { get_oneview_profile_by_sn('') } }.to raise_error('Must specify a serialNumber!')
+    end
+
+    it 'fails when an invalid filter is specified' do
+      expect { @instance.instance_eval { get_oneview_profile_by_sn('INVALIDFILTER') } }.to raise_error(/Failed to get oneview profile by serialNumber/)
+    end
+  end
+
+  describe '#get_oneview_template' do
+
+    context 'OneView 120' do
+      it 'gets profile template by name' do
+        ret_val = @instance.instance_eval { get_oneview_template('Template - Web Server') }
+        expect(ret_val['name']).to eq('Template - Web Server')
+      end
+
+      it 'clears necessary attributes from profile' do
+        ret_val = @instance.instance_eval { get_oneview_template('Template - Web Server') }
+        expect(ret_val['name']).to_not be_nil
+        %w(uri serialNumber uuid taskUri).each { |key| expect(ret_val[key]).to be_nil }
+        ret_val['connections'].each do |c|
+          %w(wwnn wwpn mac deploymentStatus interconnectUri wwpnType macType).each { |key| expect(c[key]).to be_nil }
+        end
+      end
+    end
+
+    context 'OneView 200' do
+      before :each do
+        @instance.instance_variable_set('@current_oneview_api_version', 200)
+      end
+
+      it 'gets template by name' do
+        ret_val = @instance.instance_eval { get_oneview_template('Web Server Template') }
+        expect(ret_val['uri']).to be_nil
+        expect(ret_val['serverProfileTemplateUri']).to_not be_nil
+      end
+
+      it 'gets profile template by name' do
+        ret_val = @instance.instance_eval { get_oneview_template('Template - Web Server') }
+        expect(ret_val['name']).to eq('Template - Web Server')
+        expect(ret_val['uri']).to be_nil
+      end
+    end
+  end
+end

data/spec/unit/rest_api_spec.rb

@@ -0,0 +1,115 @@
+require_relative './../spec_helper'
+
+RSpec.describe Chef::Provisioning::OneViewDriver do
+  include_context 'shared context'
+
+  describe '#rest_api' do
+
+    context 'fake_oneview' do
+      it 'completes get request with correct parameters' do
+        resp = @instance.instance_eval { rest_api(:oneview, :get, '/', {}) }
+        expect(resp['method']).to eq('GET')
+        expect(resp['message']).to eq('Fake OneView works!')
+        expect(resp['content_type']).to eq('application/json')
+        expect(resp['api_version']).to eq(@instance.instance_variable_get('@oneview_api_version'))
+        expect(resp['auth']).to eq(@oneview_key)
+      end
+
+      it 'completes post request with correct parameters' do
+        resp = @instance.instance_eval { rest_api(:oneview, :post, '/', {}) }
+        expect(resp['method']).to eq('POST')
+        expect(resp['message']).to eq('Fake OneView works!')
+        expect(resp['content_type']).to eq('application/json')
+        expect(resp['api_version']).to eq(@instance.instance_variable_get('@oneview_api_version'))
+        expect(resp['auth']).to eq(@oneview_key)
+      end
+
+      it 'completes put request with correct parameters' do
+        resp = @instance.instance_eval { rest_api(:oneview, :put, '/', {}) }
+        expect(resp['method']).to eq('PUT')
+        expect(resp['message']).to eq('Fake OneView works!')
+        expect(resp['content_type']).to eq('application/json')
+        expect(resp['api_version']).to eq(@instance.instance_variable_get('@oneview_api_version'))
+        expect(resp['auth']).to eq(@oneview_key)
+      end
+
+      it 'completes delete request with correct parameters' do
+        resp = @instance.instance_eval { rest_api(:oneview, :delete, '/', {}) }
+        expect(resp['method']).to eq('DELETE')
+        expect(resp['message']).to eq('Fake OneView works!')
+        expect(resp['content_type']).to eq('application/json')
+        expect(resp['api_version']).to eq(@instance.instance_variable_get('@oneview_api_version'))
+        expect(resp['auth']).to eq(@oneview_key)
+      end
+
+      it 'returns 404 error for invalid get request' do
+        resp = @instance.instance_eval { rest_api(:oneview, :get, '/invalid_path', {}) }
+        expect(resp['errorCode']).to eq('GENERIC_HTTP_404')
+      end
+    end
+
+    context 'fake_icsp' do
+      it 'completes get request with correct parameters' do
+        resp = @instance.instance_eval { rest_api(:icsp, :get, '/', {}) }
+        expect(resp['method']).to eq('GET')
+        expect(resp['message']).to eq('Fake ICsp works!')
+        expect(resp['content_type']).to eq('application/json')
+        expect(resp['api_version']).to eq(@instance.instance_variable_get('@icsp_api_version'))
+        expect(resp['auth']).to eq(@icsp_key)
+      end
+
+      it 'completes post request with correct parameters' do
+        resp = @instance.instance_eval { rest_api(:icsp, :post, '/', {}) }
+        expect(resp['method']).to eq('POST')
+        expect(resp['message']).to eq('Fake ICsp works!')
+        expect(resp['content_type']).to eq('application/json')
+        expect(resp['api_version']).to eq(@instance.instance_variable_get('@icsp_api_version'))
+        expect(resp['auth']).to eq(@icsp_key)
+      end
+
+      it 'completes put request with correct parameters' do
+        resp = @instance.instance_eval { rest_api(:icsp, :put, '/', {}) }
+        expect(resp['method']).to eq('PUT')
+        expect(resp['message']).to eq('Fake ICsp works!')
+        expect(resp['content_type']).to eq('application/json')
+        expect(resp['api_version']).to eq(nil)
+        expect(resp['auth']).to eq(@icsp_key)
+      end
+
+      it 'completes delete request with correct parameters' do
+        resp = @instance.instance_eval { rest_api(:icsp, :delete, '/', {}) }
+        expect(resp['method']).to eq('DELETE')
+        expect(resp['message']).to eq('Fake ICsp works!')
+        expect(resp['content_type']).to eq('application/json')
+        expect(resp['api_version']).to eq(@instance.instance_variable_get('@icsp_api_version'))
+        expect(resp['auth']).to eq(@icsp_key)
+      end
+
+      it 'returns 404 error for invalid get request' do
+        resp = @instance.instance_eval { rest_api(:icsp, :get, '/invalid_path', {}) }
+        expect(resp['errorCode']).to eq('GENERIC_HTTP_404')
+      end
+    end
+
+    it 'only accepts oneview or icsp hosts parameter' do
+      expect { @instance.instance_eval { rest_api(:invalid, :get, '/', {}) } }.to raise_error(/Invalid rest host/)
+    end
+
+    it 'only accepts rest action parameters' do
+      expect { @instance.instance_eval { rest_api(:oneview, :invalid, '/', {}) } }.to raise_error(/Invalid rest call/)
+    end
+
+  end
+
+  describe 'get api versions' do
+
+    it 'can parse the oneview api version' do
+      expect(@instance.instance_eval { get_oneview_api_version }).to match(120)
+    end
+
+    it 'can parse the icsp api version' do
+      expect(@instance.instance_eval { get_icsp_api_version }).to match(102)
+    end
+  end
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chef-provisioning-oneview
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Hewlett Packard Enterprise
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-19 00:00:00.000000000 Z
+date: 2015-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chef
@@ -94,6 +94,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Chef Provisioning driver for creating and managing OneView infrastructure.
 email:
 - jared.smartt@hp.com
@@ -108,29 +150,68 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- lib/chef/provisioning/create_machine.rb
+- lib/chef/provisioning/customize_machine.rb
 - lib/chef/provisioning/driver_init/oneview.rb
+- lib/chef/provisioning/icsp/api_v104.rb
+- lib/chef/provisioning/icsp/icsp_api.rb
 - lib/chef/provisioning/oneview/oneview_api.rb
-- lib/chef/provisioning/oneview/v1.20/api.rb
+- lib/chef/provisioning/oneview/san_storage.rb
+- lib/chef/provisioning/oneview/v1.2/api.rb
 - lib/chef/provisioning/oneview/v2.0/api.rb
-- lib/chef/provisioning/oneview/version.rb
 - lib/chef/provisioning/oneview_driver.rb
+- lib/chef/provisioning/rest.rb
+- lib/chef/provisioning/version.rb
+- spec/shared_context.rb
 - spec/spec_helper.rb
+- spec/support/fake_action_handler.rb
 - spec/support/fake_icsp.rb
+- spec/support/fake_machine_spec.rb
 - spec/support/fake_oneview.rb
 - spec/support/fixtures/icsp/v102/error_404.json
 - spec/support/fixtures/icsp/v102/login.json
 - spec/support/fixtures/icsp/v102/os-deployment-build-plans.json
-- spec/support/fixtures/icsp/v102/os-deployment-servers_managed.json
-- spec/support/fixtures/icsp/v102/server_by_sn.json
+- spec/support/fixtures/icsp/v102/os-deployment-servers.json
+- spec/support/fixtures/icsp/v102/os-deployment-servers_1670001.json
+- spec/support/fixtures/icsp/v102/os-deployment-servers_fakesn.json
+- spec/support/fixtures/icsp/v102/server_by_sn_VCGE9KB041.json
+- spec/support/fixtures/icsp/v102/server_by_sn_empty.json
 - spec/support/fixtures/icsp/v102/version.json
 - spec/support/fixtures/oneview/v120/error_404.json
 - spec/support/fixtures/oneview/v120/login.json
 - spec/support/fixtures/oneview/v120/server-hardware.json
+- spec/support/fixtures/oneview/v120/server-hardware_Template-WebServer.json
+- spec/support/fixtures/oneview/v120/server-hardware_specific.json
 - spec/support/fixtures/oneview/v120/server-profiles.json
-- spec/support/fixtures/oneview/v120/server-profiles_specific.json
+- spec/support/fixtures/oneview/v120/server-profiles_invalid_filter.json
+- spec/support/fixtures/oneview/v120/server-profiles_name_Template-WebServer.json
+- spec/support/fixtures/oneview/v120/server-profiles_name_Template-WebServerWithSAN.json
+- spec/support/fixtures/oneview/v120/server-profiles_name_chef-web01.json
+- spec/support/fixtures/oneview/v120/server-profiles_name_chef-web03.json
+- spec/support/fixtures/oneview/v120/server-profiles_name_empty.json
+- spec/support/fixtures/oneview/v120/server-profiles_sn_VCGE9KB041.json
+- spec/support/fixtures/oneview/v120/server-profiles_sn_VCGE9KB042.json
+- spec/support/fixtures/oneview/v120/server-profiles_sn_empty.json
+- spec/support/fixtures/oneview/v120/storage-volumes_1B5D3CA2-6C5B-41C2-8B97-1821F1883F22.json
+- spec/support/fixtures/oneview/v120/tasks_fake_active.json
+- spec/support/fixtures/oneview/v120/tasks_fake_complete.json
 - spec/support/fixtures/oneview/v120/version.json
+- spec/support/fixtures/oneview/v200/server-profile-templates_WebServerTemplate.json
+- spec/support/fixtures/oneview/v200/server-profile-templates_WebServerTemplateWithSAN.json
+- spec/support/fixtures/oneview/v200/server-profile-templates_invalid.json
+- spec/support/fixtures/oneview/v200/server-profile-templates_new-profile_WebServerTemplate.json
+- spec/support/fixtures/oneview/v200/server-profile-templates_new-profile_WebServerTemplateWithSAN.json
+- spec/support/fixtures/oneview/v200/version.json
+- spec/unit/create_machine_spec.rb
+- spec/unit/destroy_spec.rb
+- spec/unit/icsp_nic_teams_spec.rb
+- spec/unit/icsp_search_spec.rb
 - spec/unit/oneview_driver_spec.rb
-- spec/unit/support/fake_action_handler.rb
+- spec/unit/oneview_login_spec.rb
+- spec/unit/oneview_power_spec.rb
+- spec/unit/oneview_san_spec.rb
+- spec/unit/oneview_search_spec.rb
+- spec/unit/rest_api_spec.rb
 homepage: https://github.com/HewlettPackard/chef-provisioning-oneview
 licenses:
 - Apache-2.0
@@ -151,7 +232,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.4.4
 signing_key: 
 specification_version: 4
 summary: Chef Provisioning driver for OneView