chef-provisioning-oneview 1.0.1 → 1.1.0

data/spec/support/fixtures/oneview/v200/server-profile-templates_new-profile_WebServerTemplateWithSAN.json

@@ -0,0 +1,178 @@
+{
+  "type": "ServerProfileV5",
+  "uri": null,
+  "name": null,
+  "description": "Web server template with SAN",
+  "serialNumber": null,
+  "uuid": null,
+  "serverProfileTemplateUri": "/rest/server-profile-templates/d64da635-f08a-41d4-b6eb-6517206a8baf",
+  "templateCompliance": "Unknown",
+  "serverHardwareUri": null,
+  "serverHardwareTypeUri": "/rest/server-hardware-types/5B42EABE-5140-4E38-91F0-68367B529DE9",
+  "enclosureGroupUri": "/rest/enclosure-groups/c0f86584-5a82-4480-ad13-8ed6544d6c98",
+  "enclosureUri": null,
+  "enclosureBay": null,
+  "affinity": "Bay",
+  "associatedServer": null,
+  "hideUnusedFlexNics": true,
+  "firmware": {
+    "firmwareInstallType": null,
+    "forceInstallFirmware": false,
+    "manageFirmware": false,
+    "firmwareBaselineUri": null
+  },
+  "macType": "Virtual",
+  "wwnType": "Virtual",
+  "serialNumberType": "Virtual",
+  "category": "server-profiles",
+  "created": null,
+  "modified": null,
+  "status": "OK",
+  "state": "Creating",
+  "inProgress": false,
+  "taskUri": null,
+  "connections": [
+    {
+      "id": 7,
+      "name": "Altair PXE",
+      "functionType": "Ethernet",
+      "deploymentStatus": null,
+      "networkUri": "/rest/ethernet-networks/7984a764-69ae-48c0-aec2-780d4f0366f8",
+      "portId": "Flb 1:1-a",
+      "requestedVFs": "Auto",
+      "allocatedVFs": null,
+      "interconnectUri": null,
+      "macType": null,
+      "wwpnType": null,
+      "mac": null,
+      "wwnn": null,
+      "wwpn": null,
+      "requestedMbps": "1000",
+      "allocatedMbps": 0,
+      "maximumMbps": 0,
+      "boot": {
+        "priority": "Primary"
+      }
+    },
+    {
+      "id": 8,
+      "name": "Corpnet",
+      "functionType": "Ethernet",
+      "deploymentStatus": null,
+      "networkUri": "/rest/ethernet-networks/52b6f044-f51b-4d4c-8d59-497c14c4681c",
+      "portId": "Flb 1:1-c",
+      "requestedVFs": "Auto",
+      "allocatedVFs": null,
+      "interconnectUri": null,
+      "macType": null,
+      "wwpnType": null,
+      "mac": null,
+      "wwnn": null,
+      "wwpn": null,
+      "requestedMbps": "2500",
+      "allocatedMbps": 0,
+      "maximumMbps": 0,
+      "boot": {
+        "priority": "NotBootable"
+      }
+    },
+    {
+      "id": 9,
+      "name": "san1",
+      "functionType": "FibreChannel",
+      "deploymentStatus": null,
+      "networkUri": "/rest/fc-networks/2c04a682-66b4-4a64-8c2d-3095937a8e7e",
+      "portId": "Flb 1:1-b",
+      "requestedVFs": null,
+      "allocatedVFs": null,
+      "interconnectUri": null,
+      "macType": null,
+      "wwpnType": null,
+      "mac": null,
+      "wwnn": null,
+      "wwpn": null,
+      "requestedMbps": "4000",
+      "allocatedMbps": 0,
+      "maximumMbps": 0,
+      "boot": {
+        "priority": "Primary"
+      }
+    },
+    {
+      "id": 10,
+      "name": "san2",
+      "functionType": "FibreChannel",
+      "deploymentStatus": null,
+      "networkUri": "/rest/fc-networks/93c97ad9-3e6d-4cc4-8b37-3ef3a6a9cf77",
+      "portId": "Flb 1:2-b",
+      "requestedVFs": null,
+      "allocatedVFs": null,
+      "interconnectUri": null,
+      "macType": null,
+      "wwpnType": null,
+      "mac": null,
+      "wwnn": null,
+      "wwpn": null,
+      "requestedMbps": "4000",
+      "allocatedMbps": 0,
+      "maximumMbps": 0,
+      "boot": {
+        "priority": "Secondary"
+      }
+    }
+  ],
+  "bootMode": null,
+  "boot": {
+    "order": [
+      "HardDisk",
+      "PXE",
+      "CD",
+      "Floppy",
+      "USB"
+    ],
+    "manageBoot": true
+  },
+  "bios": {
+    "overriddenSettings": [
+
+    ],
+    "manageBios": false
+  },
+  "localStorage": {
+    "controllers": []
+  },
+  "sanStorage": {
+    "volumeAttachments": [
+      {
+        "permanent": false,
+        "storagePaths": [
+          {
+            "storageTargets": [],
+            "storageTargetType": "Auto",
+            "connectionId": 3,
+            "isEnabled": true
+          },
+          {
+            "storageTargets": [],
+            "storageTargetType": "Auto",
+            "connectionId": 4,
+            "isEnabled": true
+          }
+        ],
+        "volumeStoragePoolUri": "/rest/storage-pools/707E383B-56F6-48A1-BFF1-782BB2AC6BA7",
+        "volumeStorageSystemUri": "/rest/storage-systems/1405534",
+        "volumeDescription": "",
+        "volumeShareable": false,
+        "volumeProvisionType": "Thin",
+        "volumeProvisionedCapacityBytes": "53687091200",
+        "lun": "0",
+        "lunType": "Manual",
+        "volumeName": "bootVol",
+        "id": 1
+      }
+    ],
+    "hostOSType": "RHE Linux (5.x, 6.x)",
+    "manageSanStorage": true
+  },
+  "eTag": null
+}

data/spec/support/fixtures/oneview/v200/version.json

@@ -0,0 +1,4 @@
+{
+  "minimumVersion": 1,
+  "currentVersion": 200
+}

data/spec/unit/create_machine_spec.rb

@@ -0,0 +1,78 @@
+require_relative './../spec_helper'
+
+RSpec.describe Chef::Provisioning::OneViewDriver do
+  include_context 'shared context'
+
+  describe '#create_machine' do
+    before :each do
+      $server_created = nil
+    end
+
+    context 'OneView 120' do
+      it 'skips creating machines that already exist' do
+        a = action_handler
+        m = machine_spec
+        o = valid_machine_options
+        ret_val = @instance.instance_eval { create_machine(a, m, o) }
+        expect(a_request(:post, %r{/rest/server-profiles})).to_not have_been_made
+        expect(ret_val['name']).to eq('chef-web01')
+      end
+
+      it 'creates a machine from a Profile Template if it does not exist' do
+        a = action_handler
+        m = machine_spec
+        o = valid_machine_options
+        o[:driver_options][:host_name] = 'chef-web03'
+        @instance.instance_eval { create_machine(a, m, o) }
+        expect(a_request(:post, %r{/rest/server-profiles})).to have_been_made.times(1)
+      end
+
+      it 'sets the correct HW uri to create a machine if it does not exist' do
+        a = action_handler
+        m = machine_spec
+        o = valid_machine_options
+        o[:driver_options][:host_name] = 'chef-web03'
+        @instance.instance_eval { create_machine(a, m, o) }
+        expect(a_request(:post, %r{/rest/server-profiles}).with do |req|
+          req.body.match('"serverHardwareUri":"/rest/server-hardware/31363636-3136-584D-5132-333230314D38"') &&
+          req.body.match('"serverHardwareTypeUri":"/rest/server-hardware-types/2947DC35-BE48-4075-A3FD-254A9B42F5BD"') &&
+          req.body.match('"enclosureGroupUri":"/rest/enclosure-groups/3a11ccdd-b352-4046-a568-a8b0faa6cc39"') &&
+          !req.body.match('"enclosureUri":"') &&
+          !req.body.match('"enclosureBay":"')
+        end).to have_been_made
+      end
+    end
+
+    context 'OneView 200' do
+      before :each do
+        @instance.instance_variable_set('@current_oneview_api_version', 200)
+      end
+
+      it 'creates a machine from a Template if it does not exist' do
+        a = action_handler
+        m = machine_spec
+        o = valid_machine_options
+        o[:driver_options][:host_name] = 'chef-web03'
+        o[:driver_options][:server_template] = 'Web Server Template'
+        @instance.instance_eval { create_machine(a, m, o) }
+        expect(a_request(:post, %r{/rest/server-profiles})).to have_been_made.times(1)
+      end
+
+      it 'sets the correct HW uri from a Template to create a machine if it does not exist' do
+        a = action_handler
+        m = machine_spec
+        o = valid_machine_options
+        o[:driver_options][:host_name] = 'chef-web03'
+        o[:driver_options][:server_template] = 'Web Server Template'
+        @instance.instance_eval { create_machine(a, m, o) }
+        expect(a_request(:post, %r{/rest/server-profiles}).with do |req|
+          req.body.match('"serverHardwareUri":"/rest/server-hardware/37333036-3831-584D-5131-303030323037"') &&
+          req.body.match('"serverHardwareTypeUri":"/rest/server-hardware-types/5B42EABE-5140-4E38-91F0-68367B529DE9"') &&
+          req.body.match('"enclosureGroupUri":"/rest/enclosure-groups/c0f86584-5a82-4480-ad13-8ed6544d6c98"') &&
+          !req.body.match('"enclosureUri":"') &&
+          !req.body.match('"enclosureBay":"')
+        end).to have_been_made
+      end
+    end
+  end
+end

data/spec/unit/destroy_spec.rb

@@ -0,0 +1,26 @@
+require_relative './../spec_helper'
+
+RSpec.describe Chef::Provisioning::OneViewDriver do
+  include_context 'shared context'
+
+  describe '#destroy_oneview_profile' do
+    it 'destroys the profile' do
+      a = action_handler
+      m = machine_spec
+      @instance.instance_eval { destroy_oneview_profile(a, m) }
+      expect(a_request(:get, %r{/rest/server-hardware/.*})).to have_been_made
+      expect(a_request(:get, %r{/rest/tasks/.*})).to have_been_made
+      expect(a_request(:delete, %r{/rest/server-profiles/.*})).to have_been_made
+    end
+  end
+
+  describe '#destroy_icsp_server' do
+    it 'destroys the server' do
+      a = action_handler
+      m = machine_spec
+      @instance.instance_eval { destroy_icsp_server(a, m) }
+      expect(a_request(:delete, %r{/rest/os-deployment-servers/.*})).to have_been_made
+    end
+  end
+
+end

data/spec/unit/icsp_nic_teams_spec.rb

@@ -0,0 +1,38 @@
+require_relative './../spec_helper'
+
+RSpec.describe Chef::Provisioning::OneViewDriver do
+  include_context 'shared context'
+
+  describe '#icsp_configure_nic_teams' do
+
+    it 'configures nic teams properly' do
+      machine_options = valid_machine_options
+      profile = @instance.instance_eval { get_oneview_profile_by_sn('VCGE9KB041') }
+      ret_val = @instance.instance_eval { icsp_configure_nic_teams(machine_options, profile) }
+      expect(ret_val).to eq('team1-11:11:11:11:01:14,11:11:11:11:01:15')
+    end
+
+    it 'requires connection IDs to map to valid OneView connection IDs' do
+      machine_options = valid_machine_options
+      profile = @instance.instance_eval { get_oneview_profile_by_sn('VCGE9KB041') }
+      machine_options[:driver_options][:connections][3] = { team: 'team2' }
+      expect { @instance.instance_eval { icsp_configure_nic_teams(machine_options, profile) } }.to raise_error(/make sure the connection ids map to those on OneView/)
+    end
+
+    it 'does not allow nic teams with hyphens' do
+      machine_options = valid_machine_options
+      profile = @instance.instance_eval { get_oneview_profile_by_sn('VCGE9KB041') }
+      machine_options[:driver_options][:connections][1][:team] = 'team-1'
+      expect { @instance.instance_eval { icsp_configure_nic_teams(machine_options, profile) } }.to raise_error(/must not include hyphens/)
+    end
+
+    it 'requires at least 2 connections per team' do
+      machine_options = valid_machine_options
+      profile = @instance.instance_eval { get_oneview_profile_by_sn('VCGE9KB041') }
+      machine_options[:driver_options][:connections].delete(2)
+      expect { @instance.instance_eval { icsp_configure_nic_teams(machine_options, profile) } }.to raise_error(/must have at least 2 associated connections/)
+    end
+
+  end
+
+end

data/spec/unit/icsp_search_spec.rb

@@ -0,0 +1,25 @@
+require_relative './../spec_helper'
+
+RSpec.describe Chef::Provisioning::OneViewDriver do
+  include_context 'shared context'
+
+  describe '#get_icsp_server_by_sn' do
+
+    it 'gets info for a valid SN' do
+      ret_val = @instance.instance_eval { get_icsp_server_by_sn('VCGE9KB041') }
+      expect(ret_val['serialNumber']).to eq('VCGE9KB041')
+      expect(ret_val['uri']).to match(%r{\/rest\/os-deployment-servers\/.+})
+    end
+
+    it 'returns nil for fake SN' do
+      ret_val = @instance.instance_eval { get_icsp_server_by_sn('FAKESN') }
+      expect(ret_val).to be_nil
+    end
+
+    it 'fails when an empty SN is given' do
+      expect { @instance.instance_eval { get_icsp_server_by_sn('') } }.to raise_error('Must specify a serialNumber!')
+    end
+
+  end
+
+end

data/spec/unit/oneview_driver_spec.rb

@@ -1,62 +1,7 @@
 require_relative './../spec_helper'
-require_relative 'support/fake_action_handler'
 
 RSpec.describe Chef::Provisioning::OneViewDriver do
-  let(:knife_config) do
-    { knife: {
-      oneview_url: 'https://my-oneview.my-domain.com',
-      oneview_username: 'Administrator',
-      oneview_password: 'password12',
-      oneview_ignore_ssl: true,
-
-      icsp_url: 'https://my-icsp.my-domain.com',
-      icsp_username: 'administrator',
-      icsp_password: 'password123'
-    } }
-  end
-
-  let(:valid_machine_options) do
-    {
-      convergence_options: {
-        ssl_verify_mode: :verify_none,
-        bootstrap_proxy: 'http://proxy.my-domain.com:8080',
-        chef_server: {
-          chef_server_url: 'https://my-chef-server.my-domain.com/organizations/oneview',
-          options: {
-            client_name: 'user',
-            signing_key_filename: 'spec/fixtures/.chef/user.pem'
-          }
-        }
-      },
-      driver_options: {
-        server_template: 'Template - Web Server',
-        os_build: 'CHEF-RHEL-6.5-x64',
-        host_name: 'chef-web03',
-        ip_address: '192.168.1.2',
-        domainType: 'workgroup',
-        domainName: 'my-domain.com',
-        gateway: '192.168.1.1',
-        dns: '192.168.1.1,10.1.1.1',
-        connections: {
-          2 => { ip4Address: '192.168.1.2', mask: '255.255.254.0', dhcp: false }
-        }
-      },
-      custom_attributes: {
-
-      },
-      transport_options: {
-        ssh_options: { password: 'password1234' }
-      }
-    }
-  end
-
-  let(:action_handler) do
-    @handler ||= ChefProvisioningOneviewHelpers::FakeActionHandler.new
-  end
-
-  let(:machine_spec) do
-    # TODO
-  end
+  include_context 'shared context'
 
   describe '#canonicalize_url' do
     it 'canonicalizes the url' do
@@ -73,26 +18,54 @@ RSpec.describe Chef::Provisioning::OneViewDriver do
   end
 
   describe '#initialize' do
-    before :each do
-      @url = 'https://oneview.domain.com'
-      canonical_url = "oneview:#{@url}"
-      @instance = Chef::Provisioning::OneViewDriver.new(canonical_url, knife_config)
-    end
 
     it 'reads all necessary values from knife config during initialization' do
       expect(@instance.instance_variable_get('@oneview_base_url')).to eq('https://my-oneview.my-domain.com')
       expect(@instance.instance_variable_get('@oneview_username')).to eq('Administrator')
       expect(@instance.instance_variable_get('@oneview_password')).to eq('password12')
       expect(@instance.instance_variable_get('@oneview_disable_ssl')).to eq(true)
-      expect(@instance.instance_variable_get('@oneview_api_version')).to eq(120)
-      expect(@instance.instance_variable_get('@oneview_key')).to eq('long_oneview_key')
 
       expect(@instance.instance_variable_get('@icsp_base_url')).to eq('https://my-icsp.my-domain.com')
       expect(@instance.instance_variable_get('@icsp_username')).to eq('administrator')
       expect(@instance.instance_variable_get('@icsp_password')).to eq('password123')
       expect(@instance.instance_variable_get('@icsp_disable_ssl')).to eq(nil)
+    end
+
+    it 'uses the correct api versions' do
+      expect(@instance.instance_variable_get('@oneview_api_version')).to eq(120)
       expect(@instance.instance_variable_get('@icsp_api_version')).to eq(102)
-      expect(@instance.instance_variable_get('@icsp_key')).to eq('long_icsp_key')
+      expect(@instance.instance_variable_get('@current_oneview_api_version')).to eq(120)
+      expect(@instance.instance_variable_get('@current_icsp_api_version')).to eq(102)
+    end
+
+    it 'requires the oneview_url knife param' do
+      knife_config[:knife].delete(:oneview_url)
+      expect { Chef::Provisioning::OneViewDriver.new(@canonical_url, knife_config) }.to raise_error('Must set the knife[:oneview_url] attribute!')
+    end
+
+    it 'requires the oneview_username knife param' do
+      knife_config[:knife].delete(:oneview_username)
+      expect { Chef::Provisioning::OneViewDriver.new(@canonical_url, knife_config) }.to raise_error('Must set the knife[:oneview_username] attribute!')
+    end
+
+    it 'requires the oneview_password knife param' do
+      knife_config[:knife].delete(:oneview_password)
+      expect { Chef::Provisioning::OneViewDriver.new(@canonical_url, knife_config) }.to raise_error('Must set the knife[:oneview_password] attribute!')
+    end
+
+    it 'requires the icsp_url knife param' do
+      knife_config[:knife].delete(:icsp_url)
+      expect { Chef::Provisioning::OneViewDriver.new(@canonical_url, knife_config) }.to raise_error('Must set the knife[:icsp_url] attribute!')
+    end
+
+    it 'requires the icsp_username knife param' do
+      knife_config[:knife].delete(:icsp_username)
+      expect { Chef::Provisioning::OneViewDriver.new(@canonical_url, knife_config) }.to raise_error('Must set the knife[:icsp_username] attribute!')
+    end
+
+    it 'requires the icsp_password knife param' do
+      knife_config[:knife].delete(:icsp_password)
+      expect { Chef::Provisioning::OneViewDriver.new(@canonical_url, knife_config) }.to raise_error('Must set the knife[:icsp_password] attribute!')
     end
   end
 end