chef-handler-sns 1.2.0 → 2.0.0

data/test/test_chef_handler_sns_config.rb

@@ -1,3 +1,22 @@
+#
+# Author:: Xabier de Zuazo (<xabier@zuazo.org>)
+# Copyright:: Copyright (c) 2015 Xabier de Zuazo
+# Copyright:: Copyright (c) 2014 Onddo Labs, SL.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 require 'helper'
 require 'chef/exceptions'
 
@@ -5,146 +24,145 @@ class SnsConfig
   include Chef::Handler::Sns::Config
 end
 
-module Chef::Handler::Sns::Config
-  class FakeOhai < Chef::Handler::Sns::Config::Ohai
-    def intialize
-    end
+class ChefFakeOhai < Chef::Handler::Sns::Config::Ohai
+  def intialize
   end
 end
 
 describe Chef::Handler::Sns::Config do
-  before do
-    @config_params = {
-      :access_key => '***AMAZON-KEY***',
-      :secret_key => '***AMAZON-SECRET***',
-      :token => '***AMAZON-TOKEN***',
-      :topic_arn => 'arn:aws:sns:***',
+  let(:node) do
+    node = Chef::Node.new
+    node.name('test')
+    node
+  end
+  let(:sns_config) { SnsConfig.new }
+  let(:config_params) do
+    {
+      access_key: '***AMAZON-KEY***',
+      secret_key: '***AMAZON-SECRET***',
+      token: '***AMAZON-TOKEN***',
+      topic_arn: 'arn:aws:sns:***'
     }
-    @node = Chef::Node.new
-    @node.name('test')
-    @sns_config = SnsConfig.new
   end
 
-  it 'should read the configuration options on config initialization' do
-    @sns_config.config_init(@config_params)
+  it 'reads the configuration options on config initialization' do
+    sns_config.config_init(config_params)
 
-    assert_equal @sns_config.access_key, @config_params[:access_key]
-    assert_equal @sns_config.secret_key, @config_params[:secret_key]
+    assert_equal config_params[:access_key], sns_config.access_key
+    assert_equal config_params[:secret_key], sns_config.secret_key
   end
 
-  it 'should be able to change configuration options using method calls' do
-    @sns_config.access_key(@config_params[:access_key])
-    @sns_config.secret_key(@config_params[:secret_key])
+  it 'is able to change configuration options using method calls' do
+    sns_config.access_key(config_params[:access_key])
+    sns_config.secret_key(config_params[:secret_key])
 
-    assert_equal @sns_config.access_key, @config_params[:access_key]
-    assert_equal @sns_config.secret_key, @config_params[:secret_key]
+    assert_equal config_params[:access_key], sns_config.access_key
+    assert_equal config_params[:secret_key], sns_config.secret_key
   end
 
-  [ :access_key, :secret_key, :topic_arn ].each do |required|
-    it "should throw an exception when '#{required}' required field is not set" do
-      @config_params.delete(required)
-      @config_params.each { |key, value| @sns_config.send(key, value) }
+  [:access_key, :secret_key, :topic_arn].each do |required|
+    it "throws an exception when '#{required}' required field is not set" do
+      config_params.delete(required)
+      config_params.each { |key, value| sns_config.send(key, value) }
 
-      assert_raises(Chef::Exceptions::ValidationFailed) { @sns_config.config_check }
+      assert_raises(Chef::Exceptions::ValidationFailed) do
+        sns_config.config_check
+      end
     end
   end
 
-  [ :access_key, :secret_key, :region, :token, :topic_arn ].each do |option|
-
-    it "should accept string values in '#{option}' option" do
-      @sns_config.send(option, "test")
+  [:access_key, :secret_key, :region, :token, :topic_arn].each do |option|
+    it "accepts string values in '#{option}' option" do
+      sns_config.send(option, 'test')
     end
 
-    it "should set '#{option}' option correctly" do
-      @sns_config.send(option, "test")
+    it "sets '#{option}' option correctly" do
+      sns_config.send(option, 'test')
 
-      assert_equal @sns_config.send(option), "test"
+      assert_equal 'test', sns_config.send(option)
     end
 
-    [ true, 25, Object.new ].each do |bad_value|
-      it "should throw and exception wen '#{option}' option is set to #{bad_value.to_s}" do
-        assert_raises(Chef::Exceptions::ValidationFailed) { @sns_config.send(option, bad_value) }
+    [true, 25, Object.new].each do |bad_value|
+      it "throws and exception wen '#{option}' option is set to #{bad_value}" do
+        assert_raises(Chef::Exceptions::ValidationFailed) do
+          sns_config.send(option, bad_value)
+        end
       end
     end
   end
 
-  it 'should accept false value to reset the token' do
-    @sns_config.token(false)
-    assert_equal @sns_config.token, false
+  it 'accepts false value to reset the token' do
+    sns_config.token(false)
+    assert_equal false, sns_config.token
   end
 
-  it 'should throw an exception when the body template file does not exist' do
-    @sns_config.body_template('/tmp/nonexistent-template.erb')
-    ::File.stubs(:exists?).with(@sns_config.body_template).returns(false)
+  it 'throws an exception when the body template file does not exist' do
+    sns_config.body_template('/tmp/nonexistent-template.erb')
+    ::File.stubs(:exist?).with(sns_config.body_template).returns(false)
 
-    assert_raises(Chef::Exceptions::ValidationFailed) { @sns_config.config_check }
+    assert_raises(Chef::Exceptions::ValidationFailed) do
+      sns_config.config_check
+    end
   end
 
   describe 'config_init' do
-
-    it 'should accept valid config options' do
+    it 'accepts valid config options' do
       option = :access_key
       Chef::Log.expects(:warn).never
 
-      @sns_config.config_init({ option => 'valid' })
+      sns_config.config_init(option => 'valid')
     end
 
-    it 'should not accept invalid config options' do
+    it 'does not accept invalid config options' do
       option = :invalid_option
-      assert !@sns_config.respond_to?(option)
+      assert !sns_config.respond_to?(option)
       Chef::Log.expects(:warn).once
 
-      @sns_config.config_init({ option => 'none' })
+      sns_config.config_init(option => 'none')
     end
 
-    it 'should not accept config options starting by "config_"' do
+    it 'does not accept config options starting by "config_"' do
       option = :config_check
-      assert @sns_config.respond_to?(option)
+      assert sns_config.respond_to?(option)
       Chef::Log.expects(:warn).once
 
-      @sns_config.config_init({ option => 'exists but not configurable' })
+      sns_config.config_init(option => 'exists but not configurable')
     end
-
   end
 
   describe 'config_check' do
+    it 'calls #config_from_ohai method' do
+      sns_config.access_key(config_params[:access_key])
+      sns_config.secret_key(config_params[:secret_key])
+      sns_config.topic_arn(config_params[:topic_arn])
+      sns_config.expects(:config_from_ohai).once
 
-    it 'should call #config_from_ohai method' do
-      @sns_config.access_key(@config_params[:access_key])
-      @sns_config.secret_key(@config_params[:secret_key])
-      @sns_config.topic_arn(@config_params[:topic_arn])
-      @sns_config.expects(:config_from_ohai).once
-
-      @sns_config.config_check(@node)
+      sns_config.config_check(node)
     end
-
   end
 
   describe 'config_from_ohai' do
     before do
-      @fake_ohai = Chef::Handler::Sns::Config::FakeOhai.new(@node)
+      @fake_ohai = ChefFakeOhai.new(node)
       Chef::Handler::Sns::Config::Ohai.stubs(:new).returns(@fake_ohai)
     end
 
-    it 'should create Config::Ohai object' do
+    it 'creates Config::Ohai object' do
       Chef::Handler::Sns::Config::Ohai.expects(:new).once.returns(@fake_ohai)
 
-      @sns_config.config_from_ohai(@node)
+      sns_config.config_from_ohai(node)
     end
 
     [
-      :region,
       :access_key,
       :secret_key,
-      :token,
+      :token
     ].each do |method|
-      it "should call Config::Ohai##{method} method" do
+      it "calls Config::Ohai##{method} method" do
         @fake_ohai.expects(method).once
 
-        @sns_config.config_from_ohai(@node)
+        sns_config.config_from_ohai(node)
       end
     end
-
   end
-
 end

data/test/test_chef_handler_sns_config_ohai.rb

@@ -1,75 +1,85 @@
+#
+# Author:: Xabier de Zuazo (<xabier@zuazo.org>)
+# Copyright:: Copyright (c) 2015 Xabier de Zuazo
+# Copyright:: Copyright (c) 2014 Onddo Labs, SL.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 require 'helper'
 
 describe Chef::Handler::Sns::Config::Ohai do
-  before do
-    @node = Chef::Node.new
-    @node.name('test')
-    @node.set['ec2'] = {
-      'placement_availability_zone' => 'region1a',
-      'iam' => {
-        'security-credentials' => {
-          'iam-role1' => {
-            'AccessKeyId' => 'access_key1',
-            'SecretAccessKey' => 'secret_key1',
-            'Token' => 'token1',
+  let(:node) do
+    Chef::Node.new.tap do |node|
+      node.name('test')
+      node.set['ec2'] = {
+        'placement_availability_zone' => 'region1a',
+        'iam' => {
+          'security-credentials' => {
+            'iam-role1' => {
+              'AccessKeyId' => 'access_key1',
+              'SecretAccessKey' => 'secret_key1',
+              'Token' => 'token1'
+            }
           }
         }
       }
-    }
+    end
   end
+  let(:config) { Chef::Handler::Sns::Config::Ohai.new(node) }
+  let(:node_set_iam_roles) { node.set['ec2']['iam']['security-credentials'] }
 
   describe 'read_config' do
-
-    it 'should read the region' do
-      config = Chef::Handler::Sns::Config::Ohai.new(@node)
-      assert_equal config.region, 'region1'
+    it 'reads the region' do
+      assert_equal 'region1', config.region
     end
 
-    it 'should not read the region when not set' do
-      @node.set['ec2']['placement_availability_zone'] = nil
-      config = Chef::Handler::Sns::Config::Ohai.new(@node)
-      assert_equal config.region, nil
+    it 'does not read the region when not set' do
+      node.set['ec2']['placement_availability_zone'] = nil
+      assert_equal nil, config.region
     end
 
-    it 'should not read the credentials when has not IAM role' do
-      @node.set['ec2'] = {}
-      config = Chef::Handler::Sns::Config::Ohai.new(@node)
-      assert_equal config.access_key, nil
+    it 'does not read the credentials when has not IAM role' do
+      node.set['ec2'] = {}
+      assert_equal nil, config.access_key
     end
 
-    it 'should read the access_key' do
-      config = Chef::Handler::Sns::Config::Ohai.new(@node)
-      assert_equal config.access_key, 'access_key1'
+    it 'reads the access_key' do
+      assert_equal 'access_key1', config.access_key
     end
 
-    it 'should not read the access_key when not set' do
-      @node.set['ec2']['iam']['security-credentials']['iam-role1']['AccessKeyId'] = nil
-      config = Chef::Handler::Sns::Config::Ohai.new(@node)
-      assert_equal config.access_key, nil
+    it 'does not read the access_key when not set' do
+      node_set_iam_roles['iam-role1']['AccessKeyId'] = nil
+      assert_equal nil, config.access_key
     end
 
-    it 'should read the secret_key' do
-      config = Chef::Handler::Sns::Config::Ohai.new(@node)
-      assert_equal config.secret_key, 'secret_key1'
+    it 'reads the secret_key' do
+      assert_equal 'secret_key1', config.secret_key
     end
 
-    it 'should not read the secret_key when not set' do
-      @node.set['ec2']['iam']['security-credentials']['iam-role1']['SecretAccessKey'] = nil
-      config = Chef::Handler::Sns::Config::Ohai.new(@node)
-      assert_equal config.secret_key, nil
+    it 'does not read the secret_key when not set' do
+      node_set_iam_roles['iam-role1']['SecretAccessKey'] = nil
+      assert_equal nil, config.secret_key
     end
 
-    it 'should read the security token' do
-      config = Chef::Handler::Sns::Config::Ohai.new(@node)
-      assert_equal config.token, 'token1'
+    it 'reads the security token' do
+      assert_equal 'token1', config.token
     end
 
-    it 'should not read the security token when not set' do
-      @node.set['ec2']['iam']['security-credentials']['iam-role1']['Token'] = nil
-      config = Chef::Handler::Sns::Config::Ohai.new(@node)
-      assert_equal config.token, nil
+    it 'does not read the security token when not set' do
+      node_set_iam_roles['iam-role1']['Token'] = nil
+      assert_equal nil, config.token
     end
-
   end
-
 end

metadata

@@ -1,130 +1,186 @@
 --- !ruby/object:Gem::Specification
 name: chef-handler-sns
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 2.0.0
 platform: ruby
 authors:
-- Onddo Labs, SL.
+- Xabier de Zuazo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-04 00:00:00.000000000 Z
+date: 2015-12-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: erubis
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: chef
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.9.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.7'
+- !ruby/object:Gem::Dependency
+  name: minitest-stub-const
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.5.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.5.0
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.35.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.35.0
+- !ruby/object:Gem::Dependency
+  name: should_not
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.1'
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
 description: Chef report handler to send Amazon SNS notifications on failures or changes,
-  includes IAM roles support
-email: team@onddo.com
+  includes IAM roles support.
+email: xabier@zuazo.org
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -132,15 +188,15 @@ files:
 - LICENSE
 - README.md
 - lib/chef/handler/sns.rb
-- lib/chef/handler/sns/templates/body.erb
 - lib/chef/handler/sns/config.rb
 - lib/chef/handler/sns/config/ohai.rb
+- lib/chef/handler/sns/templates/body.erb
 - lib/chef/handler/sns/version.rb
 - test/helper.rb
 - test/test_chef_handler_sns.rb
-- test/test_chef_handler_sns_config_ohai.rb
 - test/test_chef_handler_sns_config.rb
-homepage: http://onddo.github.io/chef-handler-sns
+- test/test_chef_handler_sns_config_ohai.rb
+homepage: http://zuazo.github.io/chef-handler-sns
 licenses:
 - Apache-2.0
 metadata: {}
@@ -150,22 +206,23 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.6
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Chef SNS reports
 test_files:
-- test/helper.rb
 - test/test_chef_handler_sns.rb
+- test/helper.rb
 - test/test_chef_handler_sns_config_ohai.rb
 - test/test_chef_handler_sns_config.rb
+has_rdoc: