chef-handler-sns 1.2.0 → 2.0.0

data/lib/chef/handler/sns/config/ohai.rb

@@ -1,5 +1,6 @@
 #
-# Author:: Xabier de Zuazo (<xabier@onddo.com>)
+# Author:: Xabier de Zuazo (<xabier@zuazo.org>)
+# Copyright:: Copyright (c) 2015 Xabier de Zuazo
 # Copyright:: Copyright (c) 2014 Onddo Labs, SL.
 # License:: Apache License, Version 2.0
 #
@@ -20,46 +21,108 @@ class Chef
   class Handler
     class Sns < ::Chef::Handler
       module Config
+        #
+        # Gets Chef Handler SNS default configuration from
+        # [Ohai](https://docs.chef.io/ohai.html) information.
+        #
         class Ohai
+          #
+          # AWS region name.
+          #
+          # Not used, read from the topic ARN.
+          #
+          # @return [String] Region.
+          #
+          attr_reader :region
 
+          #
+          # AWS access key.
+          #
+          # @return [String] Access key.
+          #
+          attr_reader :access_key
+
+          #
+          # AWS secret key.
+          #
+          # @return [String] Secret key.
+          #
+          attr_reader :secret_key
+
+          #
+          # AWS token.
+          #
+          # @return [String] token.
+          #
+          attr_reader :token
+
+          #
+          # Constructs a {Chef::Handler::Sns::Config::Ohai} object.
+          #
+          # @param node [Chef::Node] Node object to read Ohai information from.
+          #
+          # @api public
+          #
           def initialize(node)
             read_config(node)
           end
 
-          def region
-            @region
-          end
-
-          def access_key
-            @access_key
-          end
+          protected
 
-          def secret_key
-            @secret_key
+          #
+          # Reads AWS region information from Ohai.
+          #
+          # Old code. This is currently not used. We are reading region
+          # information from Topic ARN.
+          #
+          # @param ec2 [Hash] These are attributes below `node['ec2']`.
+          #
+          # @return void
+          #
+          # @api private
+          #
+          def read_region_config(ec2)
+            return unless ec2.attribute?('placement_availability_zone') &&
+                          ec2['placement_availability_zone'].is_a?(String)
+            @region = ec2['placement_availability_zone'].chop
           end
 
-          def token
-            @token
+          #
+          # Reads the IAM credentials from Ohai.
+          #
+          # @param ec2 [Hash] These are attributes below `node['ec2']`.
+          #
+          # @return void
+          #
+          # @api private
+          #
+          def read_iam_config(ec2)
+            return unless ec2.attribute?('iam') &&
+                          ec2['iam'].attribute?('security-credentials')
+            _iam_role, credentials =
+              ec2['iam']['security-credentials'].to_hash.first
+            return if credentials.nil?
+            @access_key = credentials['AccessKeyId']
+            @secret_key = credentials['SecretAccessKey']
+            @token = credentials['Token']
           end
 
-          protected
-
+          #
+          # Reads configuration information from Ohai.
+          #
+          # Reads both region information and IAM credentials.
+          #
+          # @param node [Chef::Node] Node object to read information from.
+          #
+          # @return void
+          #
+          # @api private
+          #
           def read_config(node)
             return unless node.attribute?('ec2')
-            if node.ec2.attribute?('placement_availability_zone') and
-              node.ec2.placement_availability_zone.kind_of?(String)
-              @region = node.ec2.placement_availability_zone.chop
-            end
-            if node.ec2.attribute?('iam') and node.ec2.iam.attribute?('security-credentials')
-              iam_role, credentials = node.ec2.iam['security-credentials'].first
-              unless credentials.nil?
-                @access_key = credentials['AccessKeyId']
-                @secret_key = credentials['SecretAccessKey']
-                @token = credentials['Token']
-              end
-            end
+            read_region_config(node['ec2'])
+            read_iam_config(node['ec2'])
           end
-
         end
       end
     end

data/lib/chef/handler/sns/version.rb

@@ -1,9 +1,36 @@
+#
+# Author:: Xabier de Zuazo (<xabier@zuazo.org>)
+# Copyright:: Copyright (c) 2015 Xabier de Zuazo
+# Copyright:: Copyright (c) 2014 Onddo Labs, SL.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
 
 class Chef
   class Handler
+    #
+    # Chef Handler SNS main class.
+    #
+    # A simple Chef report handler that reports status of a Chef run through
+    # [Amazon SNS](http://aws.amazon.com/sns/),
+    # [including IAM roles support](#usage-with-amazon-iam-roles).
+    #
     class Sns < ::Chef::Handler
-      VERSION = '1.2.0'
+      #
+      # chef-handler-sns Ruby Gem version.
+      #
+      VERSION = '2.0.0'
     end
   end
 end
-

data/test/helper.rb

@@ -1,14 +1,35 @@
+#
+# Author:: Xabier de Zuazo (<xabier@zuazo.org>)
+# Copyright:: Copyright (c) 2015 Xabier de Zuazo
+# Copyright:: Copyright (c) 2014 Onddo Labs, SL.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 
 require 'simplecov'
-if ENV['TRAVIS']
+if ENV['TRAVIS'] && RUBY_VERSION >= '2.1.0'
   require 'coveralls'
   SimpleCov.formatter = Coveralls::SimpleCov::Formatter
 end
 SimpleCov.start
 
-gem 'minitest' # ensures you're using the gem, and not the built in MT
+gem 'minitest' # Ensures you're using the gem, and not the built in MT
 require 'minitest/autorun'
+require 'minitest/stub_const'
 require 'mocha/setup'
 require 'chef/handler/sns'
+require 'should_not/minitest'

data/test/test_chef_handler_sns.rb

@@ -1,211 +1,303 @@
+#
+# Author:: Xabier de Zuazo (<xabier@zuazo.org>)
+# Copyright:: Copyright (c) 2015 Xabier de Zuazo
+# Copyright:: Copyright (c) 2014 Onddo Labs, SL.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 require 'helper'
 require 'chef/node'
 require 'chef/run_status'
 
-class AWS::FakeSNS
-  attr_reader :sns_new
+module Aws
+  class FakeSNS
+    attr_reader :sns_new
+
+    def initialize(*_args)
+      @sns_new = true
+      self
+    end
 
-  def initialize(config)
-    @sns_new = true
-    return self
+    def publish(*_args)
+      true
+    end
+
+    def config
+      @config ||= Seahorse::Client::Configuration.new
+    end
   end
+end
 
-  def topics
+describe Chef::Handler::Sns do
+  let(:data_dir) { ::File.join(::File.dirname(__FILE__), 'data') }
+  let(:node) do
+    node = Chef::Node.new
+    node.name('test')
+    node
+  end
+  let(:run_status) do
+    run_status =
+      if Gem.loaded_specs['chef'].version > Gem::Version.new('0.12.0')
+        Chef::RunStatus.new(node, {})
+      else
+        Chef::RunStatus.new(node)
+      end
+
+    run_status.start_clock
+    run_status.stop_clock
+    run_status
+  end
+  let(:config) do
     {
-      'arn:aws:sns:***' => AWS::SNS::Topic.new('arn:aws:sns:***')
+      access_key: '***AMAZON-KEY***',
+      secret_key: '***AMAZON-SECRET***',
+      topic_arn: 'arn:aws:sns:***'
     }
   end
+  let(:sns_handler) { Chef::Handler::Sns.new(config) }
+  let(:fake_sns) do
+    Aws::FakeSNS.new(
+      access_key_id: config[:access_key],
+      secret_access_key: config[:secret_key],
+      region: config[:region],
+      logger: Chef::Log
+    )
+  end
+  before do
+    Aws::SNS::Client.stubs(:new).returns(fake_sns)
 
-end
+    Chef::Handler::Sns.any_instance.stubs(:node).returns(node)
+  end
 
-class Chef::Handler::FakeSns < Chef::Handler::Sns
+  it 'reads the configuration options on initialization' do
+    assert_equal config[:access_key], sns_handler.access_key
+    assert_equal config[:secret_key], sns_handler.secret_key
+  end
+
+  it 'is able to change configuration options using method calls' do
+    sns_handler = Chef::Handler::Sns.new
+    sns_handler.access_key(config[:access_key])
+    sns_handler.secret_key(config[:secret_key])
 
-  def get_sns_subject
-    sns_subject
+    assert_equal config[:access_key], sns_handler.access_key
+    assert_equal config[:secret_key], sns_handler.secret_key
   end
 
-  def get_sns_body
-    sns_body
+  it 'tries to send a SNS message when properly configured' do
+    fake_sns.expects(:publish).once
+
+    sns_handler.run_report_safely(run_status)
   end
 
-end
+  it 'creates an Aws::SNS object' do
+    sns_handler.run_report_safely(run_status)
 
-describe Chef::Handler::Sns do
-  before do
-    AWS::SNS::Topic.any_instance.stubs(:publish).returns(true)
-    # avoid File.read("endpoints.json")
-    AWS::Core::Endpoints.stubs(:endpoints).returns({
-      'regions' => {
-        'us-east-1' => {
-          'sns' => {
-            'http' => true,
-            'https' => true,
-            'hostname' => 'sns.us-east-1.amazonaws.com',
-          }
-        }
-      }
-    })
-
-    @node = Chef::Node.new
-    @node.name('test')
-    Chef::Handler::Sns.any_instance.stubs(:node).returns(@node)
-    Chef::Handler::FakeSns.any_instance.stubs(:node).returns(@node)
-
-    @run_status = if Gem.loaded_specs['chef'].version > Gem::Version.new('0.12.0')
-      Chef::RunStatus.new(@node, {})
-    else
-      Chef::RunStatus.new(@node)
-    end
+    assert_equal true, fake_sns.sns_new
+  end
 
-    @run_status.start_clock
-    @run_status.stop_clock
+  it 'gets the AWS region from the ARN' do
+    sns_handler = Chef::Handler::Sns.new
+    sns_handler.topic_arn('arn:aws:sns:eu-west-1:1234:MyTopic')
 
-    @config = {
-      :access_key => '***AMAZON-KEY***',
-      :secret_key => '***AMAZON-SECRET***',
-      :topic_arn => 'arn:aws:sns:***',
-    }
+    assert_equal 'eu-west-1', sns_handler.region
+  end
+
+  it 'does not detect AWS region automatically when manually set' do
+    config[:region] = 'us-east-1'
+    sns_handler = Chef::Handler::Sns.new(config)
+    sns_handler.topic_arn('arn:aws:sns:eu-west-1:1234:MyTopic')
+    sns_handler.run_report_safely(run_status)
+
+    assert_equal 'us-east-1', sns_handler.region
+  end
+
+  it 'is able to generate the default subject in chef-client' do
+    Chef::Config[:solo] = false
+    sns_handler.run_report_unsafe(run_status)
+
+    assert_equal 'Chef Client success in test', sns_handler.send(:sns_subject)
   end
 
-  it 'should read the configuration options on initialization' do
-    @sns_handler = Chef::Handler::Sns.new(@config)
-    assert_equal @sns_handler.access_key, @config[:access_key]
-    assert_equal @sns_handler.secret_key, @config[:secret_key]
+  it 'is able to generate the default subject in chef-solo' do
+    Chef::Config[:solo] = true
+    sns_handler.run_report_unsafe(run_status)
+
+    assert_equal 'Chef Solo success in test', sns_handler.send(:sns_subject)
   end
 
-  it 'should be able to change configuration options using method calls' do
-    @sns_handler = Chef::Handler::Sns.new
-    @sns_handler.access_key(@config[:access_key])
-    @sns_handler.secret_key(@config[:secret_key])
-    assert_equal @sns_handler.access_key, @config[:access_key]
-    assert_equal @sns_handler.secret_key, @config[:secret_key]
+  it 'uses the configured subject when set' do
+    config[:subject] = 'My Subject'
+    sns_handler.run_report_unsafe(run_status)
+
+    assert_equal 'My Subject', sns_handler.send(:sns_subject)
   end
 
-  it 'should try to send a SNS message when properly configured' do
-    @sns_handler = Chef::Handler::Sns.new(@config)
-    AWS::SNS::Topic.any_instance.expects(:publish).once
+  it 'is able to generate the default message body' do
+    sns_handler.run_report_unsafe(run_status)
 
-    @sns_handler.run_report_safely(@run_status)
+    sns_handler.send(:sns_body).must_match Regexp.new('Node Name: test')
   end
 
-  it 'should create a AWS::SNS object' do
-    @sns_handler = Chef::Handler::Sns.new(@config)
-    fake_sns = AWS::FakeSNS.new({
-      :access_key_id => @config[:access_key],
-      :secret_access_key => @config[:secret_key],
-      :logger => Chef::Log
-    })
-    AWS::SNS.stubs(:new).returns(fake_sns)
-    @sns_handler.run_report_safely(@run_status)
+  it 'throws an exception when the body template file does not exist' do
+    config[:body_template] = '/tmp/nonexistent-template.erb'
 
-    assert_equal fake_sns.sns_new, true
+    assert_raises(Chef::Exceptions::ValidationFailed) do
+      sns_handler.run_report_unsafe(run_status)
+    end
   end
 
-  it 'should detect the AWS region automatically' do
-    @node.set['ec2']['placement_availability_zone'] = 'eu-west-1a'
-    @sns_handler = Chef::Handler::Sns.new(@config)
-    @sns_handler.run_report_safely(@run_status)
+  it 'is able to generate the body template when configured as an '\
+     'option' do
+    body_msg = 'My Template'
+    config[:body_template] = '/tmp/existing-template.erb'
+    ::File.stubs(:exist?).with(config[:body_template]).returns(true)
+    IO.stubs(:read).with(config[:body_template]).returns(body_msg)
+
+    sns_handler.run_report_unsafe(run_status)
 
-    @sns_handler.get_region.must_equal 'eu-west-1'
+    assert_equal body_msg, sns_handler.send(:sns_body)
   end
 
-  it 'should not detect AWS region automatically whan manually set' do
-    @node.set['ec2']['placement_availability_zone'] = 'eu-west-1a'
-    @config[:region] = 'us-east-1'
-    @sns_handler = Chef::Handler::Sns.new(@config)
-    @sns_handler.run_report_safely(@run_status)
+  it 'is able to read body templates in UTF-8' do
+    config[:body_template] = ::File.join(data_dir, 'body_utf8.txt')
+
+    sns_handler.run_report_unsafe(run_status)
 
-    @sns_handler.get_region.must_equal 'us-east-1'
+    assert_includes sns_handler.send(:sns_body), 'abc'
   end
 
-  it 'should be able to generate the default subject in chef-client' do
-    Chef::Config[:solo] = false
-    @fake_sns_handler = Chef::Handler::FakeSns.new(@config)
-    Chef::Handler::FakeSns.any_instance.stubs(:node).returns(@node)
-    @fake_sns_handler.run_report_unsafe(@run_status)
+  it 'is able to read body templates in latin' do
+    config[:body_template] = ::File.join(data_dir, 'body_latin.txt')
+
+    sns_handler.run_report_unsafe(run_status)
 
-    assert_equal @fake_sns_handler.get_sns_subject, 'Chef Client success in test'
+    assert_includes sns_handler.send(:sns_body), 'abc'
   end
 
-  it 'should be able to generate the default subject in chef-solo' do
-    Chef::Config[:solo] = true
-    @fake_sns_handler = Chef::Handler::FakeSns.new(@config)
-    Chef::Handler::FakeSns.any_instance.stubs(:node).returns(@node)
-    @fake_sns_handler.run_report_unsafe(@run_status)
+  it 'replaces body characters with wrong encoding' do
+    config[:body_template] = ::File.join(data_dir, 'body_latin.txt')
+
+    sns_handler.run_report_unsafe(run_status)
+
+    assert_includes sns_handler.send(:sns_body), '???'
+  end
+
+  it 'does not cut short bodies' do
+    body_msg = 'A' * 262_144
+    config[:body_template] = '/tmp/existing-template.erb'
+    ::File.stubs(:exist?).with(config[:body_template]).returns(true)
+    IO.stubs(:read).with(config[:body_template]).returns(body_msg)
 
-    assert_equal @fake_sns_handler.get_sns_subject, 'Chef Solo success in test'
+    assert_equal body_msg, sns_handler.send(:sns_body)
   end
 
-  it 'should use the configured subject when set' do
-    @config[:subject] = 'My Subject'
-    @fake_sns_handler = Chef::Handler::FakeSns.new(@config)
-    Chef::Handler::FakeSns.any_instance.stubs(:node).returns(@node)
-    @fake_sns_handler.run_report_unsafe(@run_status)
+  it 'cuts long bodies' do
+    body_msg = 'A' * 262_144
+    config[:body_template] = '/tmp/existing-template.erb'
+    ::File.stubs(:exist?).with(config[:body_template]).returns(true)
+    IO.stubs(:read).with(config[:body_template]).returns("#{body_msg}A")
 
-    assert_equal @fake_sns_handler.get_sns_subject, 'My Subject'
+    assert_equal body_msg, sns_handler.send(:sns_body)
   end
 
-  it 'should be able to generate the default message body' do
-    @fake_sns_handler = Chef::Handler::FakeSns.new(@config)
-    Chef::Handler::FakeSns.any_instance.stubs(:node).returns(@node)
-    @fake_sns_handler.run_report_unsafe(@run_status)
+  if RUBY_VERSION >= '2.1.0'
+    it 'does not cut short bodies with utf8' do
+      body_msg = 'A' * 262_141 + "\u2014"
+      config[:body_template] = '/tmp/existing-template.erb'
+      ::File.stubs(:exist?).with(config[:body_template]).returns(true)
+      IO.stubs(:read).with(config[:body_template]).returns(body_msg)
+
+      assert_equal body_msg, sns_handler.send(:sns_body)
+    end
+
+    it 'cuts long bodies with utf8' do
+      body_msg = 'A' * 262_142
+      config[:body_template] = '/tmp/existing-template.erb'
+      ::File.stubs(:exist?).with(config[:body_template]).returns(true)
+      IO.stubs(:read).with(config[:body_template]).returns("#{body_msg}\u2014")
+
+      assert_equal body_msg, sns_handler.send(:sns_body)
+    end
+
+    # Coverage to 100%: Run code for Ruby 2.0
+    it 'encodes utf8 chars as binary on Ruby < 2.1' do
+      Object.stub_const(:RUBY_VERSION, '2.0.0') do
+        body_msg = 'A' * 4
+        config[:body_template] = '/tmp/existing-template.erb'
+        ::File.stubs(:exist?).with(config[:body_template]).returns(true)
+        IO.stubs(:read).with(config[:body_template]).returns(body_msg)
 
-    @fake_sns_handler.get_sns_body.must_match Regexp.new('Node Name: test')
+        assert_equal body_msg, sns_handler.send(:sns_body)
+      end
+    end
   end
 
-  it 'should throw an exception when the body template file does not exist' do
-    @config[:body_template] = '/tmp/nonexistent-template.erb'
-    @sns_handler = Chef::Handler::Sns.new(@config)
+  it 'is able to use subject with wrong encoding' do
+    config[:subject] = ::IO.read(::File.join(data_dir, 'subject_utf8.txt'))
 
-    assert_raises(Chef::Exceptions::ValidationFailed) { @sns_handler.run_report_unsafe(@run_status) }
+    sns_handler.run_report_unsafe(run_status)
+
+    assert_includes sns_handler.send(:sns_subject), 'abc'
+    assert_includes sns_handler.send(:sns_subject), 'xyz'
   end
 
-  it 'should be able to generate the body template when configured as an option' do
-    body_msg = 'My Template'
-    @config[:body_template] = '/tmp/existing-template.erb'
-    ::File.stubs(:exists?).with(@config[:body_template]).returns(true)
-    IO.stubs(:read).with(@config[:body_template]).returns(body_msg)
+  it 'replaces subject characters with wrong encoding' do
+    config[:subject] = ::IO.read(::File.join(data_dir, 'subject_utf8.txt'))
 
-    fake_sns = AWS::FakeSNS.new({})
-    AWS::SNS.stubs(:new).returns(fake_sns)
-    @fake_sns_handler = Chef::Handler::FakeSns.new(@config)
-    Chef::Handler::FakeSns.any_instance.stubs(:node).returns(@node)
-    @fake_sns_handler.run_report_unsafe(@run_status)
+    sns_handler.run_report_unsafe(run_status)
 
-    assert_equal @fake_sns_handler.get_sns_body, body_msg
+    assert_includes sns_handler.send(:sns_subject), '???'
   end
 
-  it 'should publish messages if node["opsworks"]["activity"] does not exist' do
-    @sns_handler = Chef::Handler::Sns.new(@config)
-    AWS::SNS::Topic.any_instance.expects(:publish).once
+  it 'cuts long subjects' do
+    config[:subject] = 'A' * 200
 
-    @sns_handler.run_report_safely(@run_status)
+    sns_handler.run_report_unsafe(run_status)
+
+    assert_equal 'A' * 100, sns_handler.send(:sns_subject)
   end
 
-  it 'should publish messages if node["opsworks"]["activity"] matches allowed acvities' do
-    @node.set['opsworks']['activity'] = 'deploy'
-    @config[:filter_opsworks_activity] = ['deploy', 'setup']
+  it 'publishes messages if node["opsworks"]["activity"] does not exist' do
+    fake_sns.expects(:publish).once
 
-    @sns_handler = Chef::Handler::Sns.new(@config)
-    AWS::SNS::Topic.any_instance.expects(:publish).once
-    @sns_handler.run_report_safely(@run_status)
+    sns_handler.run_report_safely(run_status)
   end
 
-  it 'should not publish messages if node["opsworks"]["activity"] differs from allowed acvities' do
-    @node.set['opsworks']['activity'] = 'configure'
-    @config[:filter_opsworks_activity] = ['deploy', 'setup']
+  it 'publishes messages if node["opsworks"]["activity"] matches allowed '\
+     'acvities' do
+    node.set['opsworks']['activity'] = 'deploy'
+    config[:filter_opsworks_activity] = %w(deploy setup)
 
-    @sns_handler = Chef::Handler::Sns.new(@config)
-    AWS::SNS::Topic.any_instance.expects(:publish).never
-    @sns_handler.run_report_safely(@run_status)
+    fake_sns.expects(:publish).once
+    sns_handler.run_report_safely(run_status)
   end
 
-  it 'should not publish messages if node["opsworks"]["activity"] is set, but the node attribute is missing' do
-    @config[:filter_opsworks_activity] = ['deploy', 'setup']
+  it 'does not publish messages if node["opsworks"]["activity"] differs '\
+     'from allowed acvities' do
+    node.set['opsworks']['activity'] = 'configure'
+    config[:filter_opsworks_activity] = %w(deploy setup)
 
-    @sns_handler = Chef::Handler::Sns.new(@config)
-    AWS::SNS::Topic.any_instance.expects(:publish).never
-    @sns_handler.run_report_safely(@run_status)
+    fake_sns.expects(:publish).never
+    sns_handler.run_report_safely(run_status)
   end
 
+  it 'does not publish messages if node["opsworks"]["activity"] is set, '\
+     'but the node attribute is missing' do
+    config[:filter_opsworks_activity] = %w(deploy setup)
+
+    fake_sns.expects(:publish).never
+    sns_handler.run_report_safely(run_status)
+  end
 end