chef-dk 3.0.36 → 3.1.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (377) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +124 -126
  3. data/Gemfile.lock +815 -812
  4. data/LICENSE +201 -201
  5. data/README.md +333 -333
  6. data/Rakefile +74 -74
  7. data/acceptance/.shared/kitchen_acceptance/.kitchen.digitalocean.yml +27 -27
  8. data/acceptance/.shared/kitchen_acceptance/.kitchen.ec2.yml +287 -287
  9. data/acceptance/.shared/kitchen_acceptance/.kitchen.vagrant.yml +52 -52
  10. data/acceptance/.shared/kitchen_acceptance/libraries/kitchen.rb +51 -51
  11. data/acceptance/.shared/kitchen_acceptance/metadata.rb +1 -1
  12. data/acceptance/Gemfile +21 -21
  13. data/acceptance/Gemfile.lock +334 -334
  14. data/acceptance/README.md +132 -132
  15. data/acceptance/trivial/.acceptance/acceptance-cookbook/.gitignore +2 -2
  16. data/acceptance/trivial/.acceptance/acceptance-cookbook/metadata.rb +2 -2
  17. data/acceptance/trivial/.acceptance/acceptance-cookbook/recipes/destroy.rb +1 -1
  18. data/acceptance/trivial/.acceptance/acceptance-cookbook/recipes/provision.rb +1 -1
  19. data/acceptance/trivial/.acceptance/acceptance-cookbook/recipes/verify.rb +1 -1
  20. data/acceptance/trivial/.kitchen.yml +7 -7
  21. data/acceptance/trivial/test/integration/chefdk-current-install/inspec/chef_client_spec.rb +5 -5
  22. data/bin/chef +25 -25
  23. data/chef-dk.gemspec +60 -60
  24. data/lib/chef-dk.rb +19 -19
  25. data/lib/chef-dk/authenticated_http.rb +22 -22
  26. data/lib/chef-dk/builtin_commands.rb +59 -59
  27. data/lib/chef-dk/chef_runner.rb +114 -114
  28. data/lib/chef-dk/chef_server_api_multi.rb +73 -73
  29. data/lib/chef-dk/cli.rb +201 -201
  30. data/lib/chef-dk/command/base.rb +79 -79
  31. data/lib/chef-dk/command/clean_policy_cookbooks.rb +114 -114
  32. data/lib/chef-dk/command/clean_policy_revisions.rb +111 -111
  33. data/lib/chef-dk/command/delete_policy.rb +120 -120
  34. data/lib/chef-dk/command/delete_policy_group.rb +120 -120
  35. data/lib/chef-dk/command/diff.rb +315 -315
  36. data/lib/chef-dk/command/env.rb +89 -89
  37. data/lib/chef-dk/command/exec.rb +44 -44
  38. data/lib/chef-dk/command/export.rb +155 -155
  39. data/lib/chef-dk/command/gem.rb +47 -47
  40. data/lib/chef-dk/command/generate.rb +125 -125
  41. data/lib/chef-dk/command/generator_commands.rb +83 -83
  42. data/lib/chef-dk/command/generator_commands/app.rb +106 -106
  43. data/lib/chef-dk/command/generator_commands/attribute.rb +36 -36
  44. data/lib/chef-dk/command/generator_commands/base.rb +157 -157
  45. data/lib/chef-dk/command/generator_commands/build_cookbook.rb +125 -125
  46. data/lib/chef-dk/command/generator_commands/chef_exts/generator_desc_resource.rb +85 -85
  47. data/lib/chef-dk/command/generator_commands/chef_exts/quieter_doc_formatter.rb +38 -38
  48. data/lib/chef-dk/command/generator_commands/chef_exts/recipe_dsl_ext.rb +39 -39
  49. data/lib/chef-dk/command/generator_commands/cookbook.rb +241 -241
  50. data/lib/chef-dk/command/generator_commands/cookbook_code_file.rb +100 -100
  51. data/lib/chef-dk/command/generator_commands/cookbook_file.rb +45 -45
  52. data/lib/chef-dk/command/generator_commands/generator_generator.rb +174 -174
  53. data/lib/chef-dk/command/generator_commands/helpers.rb +36 -36
  54. data/lib/chef-dk/command/generator_commands/policyfile.rb +124 -124
  55. data/lib/chef-dk/command/generator_commands/recipe.rb +36 -36
  56. data/lib/chef-dk/command/generator_commands/repo.rb +123 -123
  57. data/lib/chef-dk/command/generator_commands/resource.rb +36 -36
  58. data/lib/chef-dk/command/generator_commands/template.rb +46 -46
  59. data/lib/chef-dk/command/install.rb +120 -120
  60. data/lib/chef-dk/command/provision.rb +436 -436
  61. data/lib/chef-dk/command/push.rb +117 -117
  62. data/lib/chef-dk/command/push_archive.rb +125 -125
  63. data/lib/chef-dk/command/shell_init.rb +179 -179
  64. data/lib/chef-dk/command/show_policy.rb +163 -163
  65. data/lib/chef-dk/command/undelete.rb +154 -154
  66. data/lib/chef-dk/command/update.rb +133 -133
  67. data/lib/chef-dk/command/verify.rb +629 -629
  68. data/lib/chef-dk/commands_map.rb +113 -113
  69. data/lib/chef-dk/completions/bash.sh.erb +5 -5
  70. data/lib/chef-dk/completions/chef.fish.erb +10 -10
  71. data/lib/chef-dk/completions/zsh.zsh.erb +21 -21
  72. data/lib/chef-dk/component_test.rb +227 -227
  73. data/lib/chef-dk/configurable.rb +88 -88
  74. data/lib/chef-dk/cookbook_metadata.rb +45 -45
  75. data/lib/chef-dk/cookbook_omnifetch.rb +32 -32
  76. data/lib/chef-dk/cookbook_profiler/git.rb +152 -152
  77. data/lib/chef-dk/cookbook_profiler/identifiers.rb +72 -72
  78. data/lib/chef-dk/cookbook_profiler/null_scm.rb +31 -31
  79. data/lib/chef-dk/exceptions.rb +151 -151
  80. data/lib/chef-dk/generator.rb +165 -165
  81. data/lib/chef-dk/helpers.rb +176 -176
  82. data/lib/chef-dk/pager.rb +104 -104
  83. data/lib/chef-dk/policyfile/artifactory_cookbook_source.rb +102 -102
  84. data/lib/chef-dk/policyfile/attribute_merge_checker.rb +110 -110
  85. data/lib/chef-dk/policyfile/chef_repo_cookbook_source.rb +138 -138
  86. data/lib/chef-dk/policyfile/chef_server_cookbook_source.rb +99 -99
  87. data/lib/chef-dk/policyfile/chef_server_lock_fetcher.rb +167 -167
  88. data/lib/chef-dk/policyfile/community_cookbook_source.rb +95 -95
  89. data/lib/chef-dk/policyfile/comparison_base.rb +123 -123
  90. data/lib/chef-dk/policyfile/cookbook_location_specification.rb +154 -154
  91. data/lib/chef-dk/policyfile/cookbook_locks.rb +466 -466
  92. data/lib/chef-dk/policyfile/cookbook_sources.rb +23 -23
  93. data/lib/chef-dk/policyfile/delivery_supermarket_source.rb +89 -89
  94. data/lib/chef-dk/policyfile/differ.rb +263 -263
  95. data/lib/chef-dk/policyfile/dsl.rb +288 -288
  96. data/lib/chef-dk/policyfile/git_lock_fetcher.rb +265 -265
  97. data/lib/chef-dk/policyfile/included_policies_cookbook_source.rb +156 -156
  98. data/lib/chef-dk/policyfile/lister.rb +229 -229
  99. data/lib/chef-dk/policyfile/local_lock_fetcher.rb +129 -129
  100. data/lib/chef-dk/policyfile/lock_applier.rb +80 -80
  101. data/lib/chef-dk/policyfile/null_cookbook_source.rb +49 -49
  102. data/lib/chef-dk/policyfile/policyfile_location_specification.rb +125 -125
  103. data/lib/chef-dk/policyfile/read_cookbook_for_compat_mode_upload.rb +124 -124
  104. data/lib/chef-dk/policyfile/reports/install.rb +69 -69
  105. data/lib/chef-dk/policyfile/reports/table_printer.rb +57 -57
  106. data/lib/chef-dk/policyfile/reports/upload.rb +70 -70
  107. data/lib/chef-dk/policyfile/solution_dependencies.rb +311 -311
  108. data/lib/chef-dk/policyfile/source_uri.rb +57 -57
  109. data/lib/chef-dk/policyfile/storage_config.rb +112 -112
  110. data/lib/chef-dk/policyfile/undo_record.rb +139 -139
  111. data/lib/chef-dk/policyfile/undo_stack.rb +128 -128
  112. data/lib/chef-dk/policyfile/uploader.rb +213 -213
  113. data/lib/chef-dk/policyfile_compiler.rb +528 -528
  114. data/lib/chef-dk/policyfile_lock.rb +581 -581
  115. data/lib/chef-dk/policyfile_services/clean_policies.rb +95 -95
  116. data/lib/chef-dk/policyfile_services/clean_policy_cookbooks.rb +123 -123
  117. data/lib/chef-dk/policyfile_services/export_repo.rb +419 -419
  118. data/lib/chef-dk/policyfile_services/install.rb +162 -162
  119. data/lib/chef-dk/policyfile_services/push.rb +112 -112
  120. data/lib/chef-dk/policyfile_services/push_archive.rb +164 -164
  121. data/lib/chef-dk/policyfile_services/rm_policy.rb +141 -141
  122. data/lib/chef-dk/policyfile_services/rm_policy_group.rb +85 -85
  123. data/lib/chef-dk/policyfile_services/show_policy.rb +234 -234
  124. data/lib/chef-dk/policyfile_services/undelete.rb +108 -108
  125. data/lib/chef-dk/policyfile_services/update_attributes.rb +110 -110
  126. data/lib/chef-dk/service_exception_inspectors.rb +24 -24
  127. data/lib/chef-dk/service_exception_inspectors/base.rb +39 -39
  128. data/lib/chef-dk/service_exception_inspectors/http.rb +119 -119
  129. data/lib/chef-dk/service_exceptions.rb +142 -142
  130. data/lib/chef-dk/shell_out.rb +36 -36
  131. data/lib/chef-dk/skeletons/code_generator/files/default/Berksfile +4 -4
  132. data/lib/chef-dk/skeletons/code_generator/files/default/build_cookbook/.kitchen.yml +21 -21
  133. data/lib/chef-dk/skeletons/code_generator/files/default/build_cookbook/README.md +146 -146
  134. data/lib/chef-dk/skeletons/code_generator/files/default/build_cookbook/test-fixture-recipe.rb +9 -9
  135. data/lib/chef-dk/skeletons/code_generator/files/default/chefignore +104 -104
  136. data/lib/chef-dk/skeletons/code_generator/files/default/cookbook_readmes/README-policy.md +9 -9
  137. data/lib/chef-dk/skeletons/code_generator/files/default/cookbook_readmes/README.md +66 -66
  138. data/lib/chef-dk/skeletons/code_generator/files/default/delivery-config.json +17 -17
  139. data/lib/chef-dk/skeletons/code_generator/files/default/delivery-project.toml +36 -36
  140. data/lib/chef-dk/skeletons/code_generator/files/default/gitignore +22 -22
  141. data/lib/chef-dk/skeletons/code_generator/files/default/repo/README.md +24 -24
  142. data/lib/chef-dk/skeletons/code_generator/files/default/repo/cookbooks/example/README.md +27 -27
  143. data/lib/chef-dk/skeletons/code_generator/files/default/repo/cookbooks/example/attributes/default.rb +8 -8
  144. data/lib/chef-dk/skeletons/code_generator/files/default/repo/cookbooks/example/metadata.rb +7 -7
  145. data/lib/chef-dk/skeletons/code_generator/files/default/repo/cookbooks/example/recipes/default.rb +9 -9
  146. data/lib/chef-dk/skeletons/code_generator/files/default/repo/data_bags/README.md +56 -56
  147. data/lib/chef-dk/skeletons/code_generator/files/default/repo/data_bags/example/example_item.json +3 -3
  148. data/lib/chef-dk/skeletons/code_generator/files/default/repo/dot-chef-repo.txt +6 -6
  149. data/lib/chef-dk/skeletons/code_generator/files/default/repo/environments/README.md +9 -9
  150. data/lib/chef-dk/skeletons/code_generator/files/default/repo/environments/example.json +12 -12
  151. data/lib/chef-dk/skeletons/code_generator/files/default/repo/policies/README.md +24 -24
  152. data/lib/chef-dk/skeletons/code_generator/files/default/repo/roles/README.md +9 -9
  153. data/lib/chef-dk/skeletons/code_generator/files/default/repo/roles/example.json +12 -12
  154. data/lib/chef-dk/skeletons/code_generator/files/default/spec_helper.rb +3 -3
  155. data/lib/chef-dk/skeletons/code_generator/files/default/spec_helper_policyfile.rb +3 -3
  156. data/lib/chef-dk/skeletons/code_generator/metadata.rb +8 -8
  157. data/lib/chef-dk/skeletons/code_generator/recipes/app.rb +89 -89
  158. data/lib/chef-dk/skeletons/code_generator/recipes/attribute.rb +13 -13
  159. data/lib/chef-dk/skeletons/code_generator/recipes/build_cookbook.rb +177 -177
  160. data/lib/chef-dk/skeletons/code_generator/recipes/cookbook.rb +158 -158
  161. data/lib/chef-dk/skeletons/code_generator/recipes/cookbook_file.rb +25 -25
  162. data/lib/chef-dk/skeletons/code_generator/recipes/helpers.rb +21 -21
  163. data/lib/chef-dk/skeletons/code_generator/recipes/policyfile.rb +9 -9
  164. data/lib/chef-dk/skeletons/code_generator/recipes/recipe.rb +52 -52
  165. data/lib/chef-dk/skeletons/code_generator/recipes/repo.rb +68 -68
  166. data/lib/chef-dk/skeletons/code_generator/recipes/resource.rb +13 -13
  167. data/lib/chef-dk/skeletons/code_generator/recipes/template.rb +32 -32
  168. data/lib/chef-dk/skeletons/code_generator/templates/default/CHANGELOG.md.erb +11 -11
  169. data/lib/chef-dk/skeletons/code_generator/templates/default/LICENSE.all_rights.erb +3 -3
  170. data/lib/chef-dk/skeletons/code_generator/templates/default/LICENSE.apachev2.erb +201 -201
  171. data/lib/chef-dk/skeletons/code_generator/templates/default/LICENSE.gplv2.erb +339 -339
  172. data/lib/chef-dk/skeletons/code_generator/templates/default/LICENSE.gplv3.erb +674 -674
  173. data/lib/chef-dk/skeletons/code_generator/templates/default/LICENSE.mit.erb +21 -21
  174. data/lib/chef-dk/skeletons/code_generator/templates/default/Policyfile.rb.erb +25 -25
  175. data/lib/chef-dk/skeletons/code_generator/templates/default/README.md.erb +4 -4
  176. data/lib/chef-dk/skeletons/code_generator/templates/default/build_cookbook/Berksfile.erb +7 -7
  177. data/lib/chef-dk/skeletons/code_generator/templates/default/build_cookbook/metadata.rb.erb +10 -10
  178. data/lib/chef-dk/skeletons/code_generator/templates/default/build_cookbook/recipe.rb.erb +8 -8
  179. data/lib/chef-dk/skeletons/code_generator/templates/default/helpers.rb.erb +39 -39
  180. data/lib/chef-dk/skeletons/code_generator/templates/default/inspec_default_test.rb.erb +18 -18
  181. data/lib/chef-dk/skeletons/code_generator/templates/default/kitchen.yml.erb +26 -26
  182. data/lib/chef-dk/skeletons/code_generator/templates/default/kitchen_policyfile.yml.erb +33 -33
  183. data/lib/chef-dk/skeletons/code_generator/templates/default/metadata.rb.erb +20 -20
  184. data/lib/chef-dk/skeletons/code_generator/templates/default/recipe.rb.erb +5 -5
  185. data/lib/chef-dk/skeletons/code_generator/templates/default/recipe_spec.rb.erb +35 -35
  186. data/lib/chef-dk/skeletons/code_generator/templates/default/repo/gitignore.erb +128 -128
  187. data/lib/chef-dk/skeletons/code_generator/templates/default/resource.rb.erb +1 -1
  188. data/lib/chef-dk/ui.rb +57 -57
  189. data/lib/chef-dk/version.rb +20 -20
  190. data/lib/kitchen/provisioner/policyfile_zero.rb +195 -195
  191. data/omnibus_overrides.rb +25 -25
  192. data/spec/shared/a_file_generator.rb +125 -125
  193. data/spec/shared/a_generated_file.rb +12 -12
  194. data/spec/shared/command_with_ui_object.rb +11 -11
  195. data/spec/shared/custom_generator_cookbook.rb +136 -136
  196. data/spec/shared/fixture_cookbook_checksums.rb +46 -46
  197. data/spec/shared/setup_git_committer_config.rb +54 -54
  198. data/spec/shared/setup_git_cookbooks.rb +53 -53
  199. data/spec/spec_helper.rb +51 -51
  200. data/spec/test_helpers.rb +84 -84
  201. data/spec/unit/chef_runner_spec.rb +139 -139
  202. data/spec/unit/chef_server_api_multi_spec.rb +120 -120
  203. data/spec/unit/cli_spec.rb +377 -377
  204. data/spec/unit/command/base_spec.rb +172 -172
  205. data/spec/unit/command/clean_policy_cookbooks_spec.rb +180 -180
  206. data/spec/unit/command/clean_policy_revisions_spec.rb +180 -180
  207. data/spec/unit/command/delete_policy_group_spec.rb +206 -206
  208. data/spec/unit/command/delete_policy_spec.rb +206 -206
  209. data/spec/unit/command/diff_spec.rb +311 -311
  210. data/spec/unit/command/env_spec.rb +52 -52
  211. data/spec/unit/command/exec_spec.rb +178 -178
  212. data/spec/unit/command/export_spec.rb +199 -199
  213. data/spec/unit/command/generate_spec.rb +142 -142
  214. data/spec/unit/command/generator_commands/app_spec.rb +166 -166
  215. data/spec/unit/command/generator_commands/attribute_spec.rb +31 -31
  216. data/spec/unit/command/generator_commands/base_spec.rb +181 -181
  217. data/spec/unit/command/generator_commands/build_cookbook_spec.rb +377 -377
  218. data/spec/unit/command/generator_commands/chef_exts/generator_desc_resource_spec.rb +97 -97
  219. data/spec/unit/command/generator_commands/chef_exts/recipe_dsl_ext_spec.rb +111 -111
  220. data/spec/unit/command/generator_commands/cookbook_file_spec.rb +31 -31
  221. data/spec/unit/command/generator_commands/cookbook_spec.rb +765 -765
  222. data/spec/unit/command/generator_commands/generator_generator_spec.rb +227 -227
  223. data/spec/unit/command/generator_commands/helpers_spec.rb +31 -31
  224. data/spec/unit/command/generator_commands/policyfile_spec.rb +223 -223
  225. data/spec/unit/command/generator_commands/recipe_spec.rb +37 -37
  226. data/spec/unit/command/generator_commands/repo_spec.rb +374 -374
  227. data/spec/unit/command/generator_commands/resource_spec.rb +31 -31
  228. data/spec/unit/command/generator_commands/template_spec.rb +31 -31
  229. data/spec/unit/command/install_spec.rb +179 -179
  230. data/spec/unit/command/provision_spec.rb +589 -589
  231. data/spec/unit/command/push_archive_spec.rb +153 -153
  232. data/spec/unit/command/push_spec.rb +198 -198
  233. data/spec/unit/command/shell_init_spec.rb +339 -339
  234. data/spec/unit/command/show_policy_spec.rb +234 -234
  235. data/spec/unit/command/undelete_spec.rb +244 -244
  236. data/spec/unit/command/update_spec.rb +283 -283
  237. data/spec/unit/command/verify_spec.rb +341 -341
  238. data/spec/unit/commands_map_spec.rb +57 -57
  239. data/spec/unit/component_test_spec.rb +128 -128
  240. data/spec/unit/configurable_spec.rb +68 -68
  241. data/spec/unit/cookbook_metadata_spec.rb +96 -96
  242. data/spec/unit/cookbook_profiler/git_spec.rb +176 -176
  243. data/spec/unit/cookbook_profiler/identifiers_spec.rb +81 -81
  244. data/spec/unit/fixtures/chef-runner-cookbooks/test_cookbook/recipes/recipe_one.rb +9 -9
  245. data/spec/unit/fixtures/chef-runner-cookbooks/test_cookbook/recipes/recipe_two.rb +9 -9
  246. data/spec/unit/fixtures/command/cli_test_command.rb +26 -26
  247. data/spec/unit/fixtures/command/explicit_path_example.rb +7 -7
  248. data/spec/unit/fixtures/configurable/test_config_loader.rb +5 -5
  249. data/spec/unit/fixtures/configurable/test_configurable.rb +10 -10
  250. data/spec/unit/fixtures/cookbook_cache/baz-f59ee7a5bca6a4e606b67f7f856b768d847c39bb/.kitchen.yml +16 -16
  251. data/spec/unit/fixtures/cookbook_cache/baz-f59ee7a5bca6a4e606b67f7f856b768d847c39bb/Berksfile +3 -3
  252. data/spec/unit/fixtures/cookbook_cache/baz-f59ee7a5bca6a4e606b67f7f856b768d847c39bb/README.md +4 -4
  253. data/spec/unit/fixtures/cookbook_cache/baz-f59ee7a5bca6a4e606b67f7f856b768d847c39bb/chefignore +96 -96
  254. data/spec/unit/fixtures/cookbook_cache/baz-f59ee7a5bca6a4e606b67f7f856b768d847c39bb/metadata.rb +8 -8
  255. data/spec/unit/fixtures/cookbook_cache/baz-f59ee7a5bca6a4e606b67f7f856b768d847c39bb/recipes/default.rb +8 -8
  256. data/spec/unit/fixtures/cookbook_cache/dep_of_bar-1.2.3/.kitchen.yml +16 -16
  257. data/spec/unit/fixtures/cookbook_cache/dep_of_bar-1.2.3/Berksfile +3 -3
  258. data/spec/unit/fixtures/cookbook_cache/dep_of_bar-1.2.3/README.md +4 -4
  259. data/spec/unit/fixtures/cookbook_cache/dep_of_bar-1.2.3/chefignore +96 -96
  260. data/spec/unit/fixtures/cookbook_cache/dep_of_bar-1.2.3/metadata.rb +8 -8
  261. data/spec/unit/fixtures/cookbook_cache/dep_of_bar-1.2.3/recipes/default.rb +8 -8
  262. data/spec/unit/fixtures/cookbook_cache/foo-1.0.0/.kitchen.yml +16 -16
  263. data/spec/unit/fixtures/cookbook_cache/foo-1.0.0/Berksfile +3 -3
  264. data/spec/unit/fixtures/cookbook_cache/foo-1.0.0/README.md +4 -4
  265. data/spec/unit/fixtures/cookbook_cache/foo-1.0.0/chefignore +96 -96
  266. data/spec/unit/fixtures/cookbook_cache/foo-1.0.0/metadata.rb +8 -8
  267. data/spec/unit/fixtures/cookbook_cache/foo-1.0.0/recipes/default.rb +8 -8
  268. data/spec/unit/fixtures/cookbooks_api/chef_server_universe.json +56 -56
  269. data/spec/unit/fixtures/cookbooks_api/pruned_chef_server_universe.json +30 -30
  270. data/spec/unit/fixtures/cookbooks_api/pruned_small_universe.json +1321 -1321
  271. data/spec/unit/fixtures/cookbooks_api/small_universe.json +2987 -2987
  272. data/spec/unit/fixtures/cookbooks_api/universe.json +1 -1
  273. data/spec/unit/fixtures/cookbooks_api/update_fixtures.rb +33 -33
  274. data/spec/unit/fixtures/dev_cookbooks/README.md +16 -16
  275. data/spec/unit/fixtures/eg_omnibus_dir/valid/embedded/apps/berkshelf/integration_test +2 -2
  276. data/spec/unit/fixtures/eg_omnibus_dir/valid/embedded/apps/berkshelf/verify_me +5 -5
  277. data/spec/unit/fixtures/eg_omnibus_dir/valid/embedded/apps/chef/verify_me +3 -3
  278. data/spec/unit/fixtures/eg_omnibus_dir/valid/embedded/apps/test-kitchen/verify_me +2 -2
  279. data/spec/unit/fixtures/example_cookbook/.gitignore +17 -17
  280. data/spec/unit/fixtures/example_cookbook/.kitchen.yml +16 -16
  281. data/spec/unit/fixtures/example_cookbook/Berksfile +3 -3
  282. data/spec/unit/fixtures/example_cookbook/README.md +4 -4
  283. data/spec/unit/fixtures/example_cookbook/chefignore +96 -96
  284. data/spec/unit/fixtures/example_cookbook/metadata.rb +8 -8
  285. data/spec/unit/fixtures/example_cookbook/recipes/default.rb +8 -8
  286. data/spec/unit/fixtures/example_cookbook_metadata_json_only/.gitignore +17 -17
  287. data/spec/unit/fixtures/example_cookbook_metadata_json_only/.kitchen.yml +16 -16
  288. data/spec/unit/fixtures/example_cookbook_metadata_json_only/Berksfile +3 -3
  289. data/spec/unit/fixtures/example_cookbook_metadata_json_only/README.md +4 -4
  290. data/spec/unit/fixtures/example_cookbook_metadata_json_only/chefignore +96 -96
  291. data/spec/unit/fixtures/example_cookbook_metadata_json_only/metadata.json +5 -5
  292. data/spec/unit/fixtures/example_cookbook_metadata_json_only/recipes/default.rb +8 -8
  293. data/spec/unit/fixtures/example_cookbook_no_metadata/.gitignore +17 -17
  294. data/spec/unit/fixtures/example_cookbook_no_metadata/.kitchen.yml +16 -16
  295. data/spec/unit/fixtures/example_cookbook_no_metadata/Berksfile +3 -3
  296. data/spec/unit/fixtures/example_cookbook_no_metadata/README.md +4 -4
  297. data/spec/unit/fixtures/example_cookbook_no_metadata/chefignore +96 -96
  298. data/spec/unit/fixtures/example_cookbook_no_metadata/recipes/default.rb +8 -8
  299. data/spec/unit/fixtures/local_path_cookbooks/another-local-cookbook/README.md +4 -4
  300. data/spec/unit/fixtures/local_path_cookbooks/another-local-cookbook/chefignore +96 -96
  301. data/spec/unit/fixtures/local_path_cookbooks/another-local-cookbook/metadata.rb +8 -8
  302. data/spec/unit/fixtures/local_path_cookbooks/another-local-cookbook/recipes/default.rb +8 -8
  303. data/spec/unit/fixtures/local_path_cookbooks/cookbook-with-a-dep/Berksfile +3 -3
  304. data/spec/unit/fixtures/local_path_cookbooks/cookbook-with-a-dep/README.md +4 -4
  305. data/spec/unit/fixtures/local_path_cookbooks/cookbook-with-a-dep/chefignore +96 -96
  306. data/spec/unit/fixtures/local_path_cookbooks/cookbook-with-a-dep/metadata.rb +9 -9
  307. data/spec/unit/fixtures/local_path_cookbooks/cookbook-with-a-dep/recipes/default.rb +8 -8
  308. data/spec/unit/fixtures/local_path_cookbooks/local-cookbook/.kitchen.yml +16 -16
  309. data/spec/unit/fixtures/local_path_cookbooks/local-cookbook/Berksfile +3 -3
  310. data/spec/unit/fixtures/local_path_cookbooks/local-cookbook/README.md +4 -4
  311. data/spec/unit/fixtures/local_path_cookbooks/local-cookbook/chefignore +96 -96
  312. data/spec/unit/fixtures/local_path_cookbooks/local-cookbook/metadata.rb +8 -8
  313. data/spec/unit/fixtures/local_path_cookbooks/local-cookbook/recipes/default.rb +8 -8
  314. data/spec/unit/fixtures/local_path_cookbooks/metadata-missing/README.md +2 -2
  315. data/spec/unit/fixtures/local_path_cookbooks/noignore-f59ee7a5bca6a4e606b67f7f856b768d847c39bb/.kitchen.yml +16 -16
  316. data/spec/unit/fixtures/local_path_cookbooks/noignore-f59ee7a5bca6a4e606b67f7f856b768d847c39bb/README.md +4 -4
  317. data/spec/unit/fixtures/local_path_cookbooks/noignore-f59ee7a5bca6a4e606b67f7f856b768d847c39bb/metadata.rb +8 -8
  318. data/spec/unit/fixtures/local_path_cookbooks/noignore-f59ee7a5bca6a4e606b67f7f856b768d847c39bb/recipes/default.rb +8 -8
  319. data/spec/unit/generator_spec.rb +119 -119
  320. data/spec/unit/pager_spec.rb +117 -117
  321. data/spec/unit/policyfile/artifactory_cookbook_source_spec.rb +59 -59
  322. data/spec/unit/policyfile/attribute_merge_checker_spec.rb +80 -80
  323. data/spec/unit/policyfile/chef_repo_cookbook_source_spec.rb +93 -93
  324. data/spec/unit/policyfile/chef_server_cookbook_source_spec.rb +55 -55
  325. data/spec/unit/policyfile/chef_server_lock_fetcher_spec.rb +161 -161
  326. data/spec/unit/policyfile/community_cookbook_source_spec.rb +83 -83
  327. data/spec/unit/policyfile/comparison_base_spec.rb +340 -340
  328. data/spec/unit/policyfile/cookbook_location_specification_spec.rb +347 -347
  329. data/spec/unit/policyfile/cookbook_locks_spec.rb +527 -527
  330. data/spec/unit/policyfile/delivery_supermarket_source_spec.rb +129 -129
  331. data/spec/unit/policyfile/differ_spec.rb +686 -686
  332. data/spec/unit/policyfile/git_lock_fetcher_spec.rb +155 -155
  333. data/spec/unit/policyfile/included_policies_cookbook_source_spec.rb +242 -242
  334. data/spec/unit/policyfile/lister_spec.rb +268 -268
  335. data/spec/unit/policyfile/local_lock_fetcher_spec.rb +173 -173
  336. data/spec/unit/policyfile/lock_applier_spec.rb +100 -100
  337. data/spec/unit/policyfile/null_cookbook_source_spec.rb +34 -34
  338. data/spec/unit/policyfile/read_cookbook_for_compat_mode_upload_spec.rb +92 -92
  339. data/spec/unit/policyfile/reports/install_spec.rb +114 -114
  340. data/spec/unit/policyfile/reports/upload_spec.rb +94 -94
  341. data/spec/unit/policyfile/solution_dependencies_spec.rb +170 -170
  342. data/spec/unit/policyfile/source_uri_spec.rb +36 -36
  343. data/spec/unit/policyfile/storage_config_spec.rb +180 -180
  344. data/spec/unit/policyfile/undo_record_spec.rb +258 -258
  345. data/spec/unit/policyfile/undo_stack_spec.rb +265 -265
  346. data/spec/unit/policyfile/uploader_spec.rb +409 -409
  347. data/spec/unit/policyfile_demands_spec.rb +1197 -1197
  348. data/spec/unit/policyfile_evaluation_spec.rb +628 -628
  349. data/spec/unit/policyfile_includes_dsl_spec.rb +159 -159
  350. data/spec/unit/policyfile_includes_spec.rb +720 -720
  351. data/spec/unit/policyfile_install_with_includes_spec.rb +232 -232
  352. data/spec/unit/policyfile_lock_build_spec.rb +1065 -1065
  353. data/spec/unit/policyfile_lock_install_spec.rb +137 -137
  354. data/spec/unit/policyfile_lock_serialization_spec.rb +424 -424
  355. data/spec/unit/policyfile_lock_validation_spec.rb +608 -608
  356. data/spec/unit/policyfile_services/clean_policies_spec.rb +236 -236
  357. data/spec/unit/policyfile_services/clean_policy_cookbooks_spec.rb +272 -272
  358. data/spec/unit/policyfile_services/export_repo_spec.rb +473 -473
  359. data/spec/unit/policyfile_services/install_spec.rb +209 -209
  360. data/spec/unit/policyfile_services/push_archive_spec.rb +359 -359
  361. data/spec/unit/policyfile_services/push_spec.rb +249 -249
  362. data/spec/unit/policyfile_services/rm_policy_group_spec.rb +237 -237
  363. data/spec/unit/policyfile_services/rm_policy_spec.rb +263 -263
  364. data/spec/unit/policyfile_services/show_policy_spec.rb +887 -887
  365. data/spec/unit/policyfile_services/undelete_spec.rb +302 -302
  366. data/spec/unit/policyfile_services/update_attributes_spec.rb +229 -229
  367. data/spec/unit/policyfile_services/update_spec.rb +140 -140
  368. data/spec/unit/service_exception_inspectors/base_spec.rb +41 -41
  369. data/spec/unit/service_exception_inspectors/http_spec.rb +138 -138
  370. data/spec/unit/shell_out_spec.rb +34 -34
  371. data/tasks/announce.rb +57 -57
  372. data/tasks/bin/bundle-platform.bat +2 -2
  373. data/tasks/dependencies.rb +89 -89
  374. data/tasks/templates/prerelease.md.erb +35 -35
  375. data/tasks/templates/release.md.erb +34 -34
  376. data/warning.txt +9 -9
  377. metadata +2 -2
@@ -1,608 +1,608 @@
1
- #
2
- # Copyright:: Copyright (c) 2014-2018 Chef Software Inc.
3
- # License:: Apache License, Version 2.0
4
- #
5
- # Licensed under the Apache License, Version 2.0 (the "License");
6
- # you may not use this file except in compliance with the License.
7
- # You may obtain a copy of the License at
8
- #
9
- # http://www.apache.org/licenses/LICENSE-2.0
10
- #
11
- # Unless required by applicable law or agreed to in writing, software
12
- # distributed under the License is distributed on an "AS IS" BASIS,
13
- # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14
- # See the License for the specific language governing permissions and
15
- # limitations under the License.
16
- #
17
-
18
- require "spec_helper"
19
- require "chef-dk/policyfile_lock.rb"
20
-
21
- describe ChefDK::PolicyfileLock, "validating locked cookbooks" do
22
-
23
- include ChefDK::Helpers
24
-
25
- let(:pristine_cache_path) do
26
- File.expand_path("spec/unit/fixtures/cookbook_cache", project_root)
27
- end
28
-
29
- let(:cache_path) do
30
- temp_cache_path = File.join(tempdir, "local_cache")
31
- FileUtils.cp_r(pristine_cache_path, temp_cache_path)
32
- temp_cache_path
33
- end
34
-
35
- let(:policyfile_lock_path) { "/fakepath/Policyfile.lock.json" }
36
-
37
- let(:local_cookbooks_root) do
38
- temp_local_path_cookbooks = File.join(tempdir, "local_path_cookbooks")
39
- FileUtils.cp_r(File.join(fixtures_path, "local_path_cookbooks"), temp_local_path_cookbooks)
40
- temp_local_path_cookbooks
41
- end
42
-
43
- let(:name) { "application-server" }
44
-
45
- let(:run_list) { [ "recipe[erlang::default]", "recipe[erchef::prereqs]", "recipe[erchef::app]" ] }
46
-
47
- let(:storage_config) do
48
- ChefDK::Policyfile::StorageConfig.new( cache_path: cache_path, relative_paths_root: local_cookbooks_root )
49
- end
50
-
51
- let(:solution_dependencies) do
52
- {
53
- "Policyfile" => [],
54
- "dependencies" => {
55
- "foo (1.0.0)" => [],
56
- "local-cookbook (2.3.4)" => [],
57
- },
58
- }
59
- end
60
-
61
- let(:lock_generator) do
62
- ChefDK::PolicyfileLock.build(storage_config) do |policy|
63
-
64
- policy.name = name
65
-
66
- policy.run_list = run_list
67
-
68
- policy.cached_cookbook("foo") do |c|
69
- c.origin = "https://artifact-server.example/foo/1.0.0"
70
- c.cache_key = "foo-1.0.0"
71
- c.source_options = { artifactserver: "https://artifact-server.example/foo/1.0.0", version: "1.0.0" }
72
- end
73
-
74
- policy.local_cookbook("local-cookbook") do |c|
75
- c.source = "local-cookbook"
76
- c.source_options = { path: "local-cookbook" }
77
- end
78
-
79
- policy.solution_dependencies.consume_lock_data(solution_dependencies)
80
- end
81
- end
82
-
83
- let(:lock_data) do
84
- lock_generator.to_lock
85
- end
86
-
87
- # Eagerly evaluate #policyfile_lock. This is necessary because many of
88
- # the tests follow this general process:
89
- # 1. setup valid state, generate a lockfile in-memory
90
- # 2. make the state invalid
91
- # 3. ensure validation detected the invalid state
92
- #
93
- # With lazy evaluation, #1 may happen after #2.
94
- let!(:policyfile_lock) do
95
- ChefDK::PolicyfileLock.new(storage_config).build_from_lock_data(lock_data)
96
- end
97
-
98
- let(:local_cookbook_path) { File.join(local_cookbooks_root, "local-cookbook") }
99
-
100
- context "when no cookbooks have changed" do
101
-
102
- it "validation succeeds" do
103
- expect(policyfile_lock.validate_cookbooks!).to be true
104
- end
105
-
106
- end
107
-
108
- describe "when a :path sourced cookbook has changed" do
109
-
110
- let(:metadata_path) { File.join(local_cookbook_path, "metadata.rb") }
111
-
112
- let(:cookbook_lock_data) { policyfile_lock.lock_data_for("local-cookbook") }
113
-
114
- # Validate the metadata is correct, so we know the test setup code
115
- # hasn't done something wrong.
116
- def ensure_metadata_as_expected!
117
- expected_metadata_rb = <<-E
118
- name 'local-cookbook'
119
- maintainer ''
120
- maintainer_email ''
121
- license ''
122
- description 'Installs/Configures local-cookbook'
123
- long_description 'Installs/Configures local-cookbook'
124
- version '2.3.4'
125
-
126
- E
127
- expect(IO.read(metadata_path)).to eq(expected_metadata_rb)
128
- end
129
-
130
- context "when the cookbook is missing" do
131
-
132
- before do
133
- FileUtils.rm_rf(local_cookbook_path)
134
- end
135
-
136
- it "reports the missing cookbook and fails validation" do
137
- full_path = File.expand_path(local_cookbook_path)
138
- message = "Cookbook `local-cookbook' not found at path source `local-cookbook` (full path: `#{full_path}')"
139
-
140
- expect { policyfile_lock.validate_cookbooks! }.to raise_error(ChefDK::LocalCookbookNotFound, message)
141
- end
142
-
143
- end
144
-
145
- context "when the cookbook has an incorrect name" do
146
-
147
- let(:new_metadata) do
148
- <<-E
149
- name 'WRONG'
150
- maintainer ''
151
- maintainer_email ''
152
- license ''
153
- description 'Installs/Configures local-cookbook'
154
- long_description 'Installs/Configures local-cookbook'
155
- version '2.3.4'
156
-
157
- E
158
- end
159
-
160
- before do
161
- ensure_metadata_as_expected!
162
- with_file(metadata_path) { |f| f.print(new_metadata) }
163
- end
164
-
165
- it "reports the unexpected cookbook and fails validation" do
166
- policyfile_lock
167
-
168
- message = "The cookbook at path source `local-cookbook' is expected to be named `local-cookbook', but is now named `WRONG' (full path: #{local_cookbook_path})"
169
- expect { policyfile_lock.validate_cookbooks! }.to raise_error(ChefDK::MalformedCookbook, message)
170
- end
171
-
172
- end
173
-
174
- context "when the cookbook has an updated version that violates no dependency constraints" do
175
-
176
- let(:new_metadata) do
177
- <<-E
178
- name 'local-cookbook'
179
- maintainer ''
180
- maintainer_email ''
181
- license ''
182
- description 'Installs/Configures local-cookbook'
183
- long_description 'Installs/Configures local-cookbook'
184
- version '2.3.5' # changed from 2.3.4
185
-
186
- E
187
- end
188
-
189
- before do
190
- ensure_metadata_as_expected!
191
- with_file(metadata_path) { |f| f.print(new_metadata) }
192
- policyfile_lock.validate_cookbooks! # no error
193
- end
194
-
195
- it "updates the version information in the lockfile" do
196
- expect(cookbook_lock_data.version).to eq("2.3.5")
197
- end
198
-
199
- it "updates the content identifier" do
200
- old_id = lock_generator.lock_data_for("local-cookbook").identifier
201
- expect(cookbook_lock_data.identifier).to_not eq(old_id)
202
- expect(cookbook_lock_data.identifier).to eq("5a2b09f9d5e6e8a1a2d811c41d58ed200599adbe")
203
- end
204
-
205
- it "has an updated version and identifier" do
206
- expect(cookbook_lock_data).to be_updated
207
- expect(cookbook_lock_data.version_updated?).to be true
208
- expect(cookbook_lock_data.identifier_updated?).to be true
209
- end
210
- end
211
-
212
- context "when the cookbook has an updated version that violates other dependency constraints" do
213
-
214
- let(:solution_dependencies) do
215
- {
216
- "Policyfile" => [],
217
- "dependencies" => {
218
- "foo (1.0.0)" => [ [ "local-cookbook", "~> 2.0" ] ],
219
- },
220
- }
221
- end
222
-
223
- let(:new_metadata) do
224
- <<-E
225
- name 'local-cookbook'
226
- maintainer ''
227
- maintainer_email ''
228
- license ''
229
- description 'Installs/Configures local-cookbook'
230
- long_description 'Installs/Configures local-cookbook'
231
- version '3.0.0' # changed from 2.3.4, violates `~> 2.0` constraint
232
-
233
- E
234
- end
235
-
236
- before do
237
- ensure_metadata_as_expected!
238
- with_file(metadata_path) { |f| f.print(new_metadata) }
239
- end
240
-
241
- it "reports the dependency conflict and fails validation" do
242
- expected_message = "Cookbook local-cookbook (3.0.0) conflicts with other dependencies:\nfoo (1.0.0) depends on local-cookbook ~> 2.0"
243
- expect { policyfile_lock.validate_cookbooks! }.to raise_error(ChefDK::DependencyConflict, expected_message)
244
- end
245
-
246
- end
247
-
248
- context "when a :path sourced cookbook has updated content" do
249
-
250
- let(:recipe_path) { File.join(local_cookbook_path, "recipes/default.rb") }
251
-
252
- let(:new_recipe) do
253
- <<-E
254
- # This is totally new code,
255
- # it is different than the old code
256
-
257
- E
258
- end
259
-
260
- before do
261
- ensure_metadata_as_expected!
262
- with_file(recipe_path) { |f| f.print(new_recipe) }
263
- policyfile_lock.validate_cookbooks! # no error
264
- end
265
-
266
- it "updates the lockfile with the new checksum and validation succeeds" do
267
- old_id = lock_generator.lock_data_for("local-cookbook").identifier
268
-
269
- expect(cookbook_lock_data.identifier).to_not eq(old_id)
270
- expect(cookbook_lock_data.identifier).to eq("0f62422f744d173c35a3e74f1a8c76c8b92908c2")
271
- end
272
-
273
- it "has an updated identifier but not an updated version" do
274
- expect(cookbook_lock_data).to be_updated
275
- expect(cookbook_lock_data.version_updated?).to be false
276
- expect(cookbook_lock_data.identifier_updated?).to be true
277
- end
278
-
279
- end
280
-
281
- context "when a :path source cookbook has added a dependency satisfied by the current cookbook set" do
282
-
283
- let(:new_metadata) do
284
- <<-E
285
- name 'local-cookbook'
286
- maintainer ''
287
- maintainer_email ''
288
- license ''
289
- description 'Installs/Configures local-cookbook'
290
- long_description 'Installs/Configures local-cookbook'
291
- version '2.3.4'
292
-
293
- depends "foo", "=1.0.0"
294
-
295
- E
296
- end
297
-
298
- before do
299
- ensure_metadata_as_expected!
300
- with_file(metadata_path) { |f| f.print(new_metadata) }
301
- policyfile_lock.validate_cookbooks! # no error
302
- end
303
-
304
- it "updates the lockfile with the new checksum and validation succeeds" do
305
- old_id = lock_generator.lock_data_for("local-cookbook").identifier
306
-
307
- expect(cookbook_lock_data.identifier).to_not eq(old_id)
308
- expect(cookbook_lock_data.identifier).to eq("af5e1252307bdf99b878ca5ede3c40e24ee9e45a")
309
- end
310
-
311
- it "has an updated identifier but not an updated version" do
312
- expect(cookbook_lock_data).to be_updated
313
- expect(cookbook_lock_data.version_updated?).to be false
314
- expect(cookbook_lock_data.identifier_updated?).to be true
315
- end
316
-
317
- it "has an updated dependency set" do
318
- actual = policyfile_lock.solution_dependencies.to_lock["dependencies"]
319
- expected = {
320
- "local-cookbook (2.3.4)" => [ ["foo", "= 1.0.0"] ],
321
- "foo (1.0.0)" => [],
322
- }
323
- expect(actual).to eq(expected)
324
- end
325
-
326
- end
327
-
328
- context "when a :path source cookbook has added a dependency not satisfied by the current cookbook set" do
329
-
330
- let(:new_metadata) do
331
- <<-E
332
- name 'local-cookbook'
333
- maintainer ''
334
- maintainer_email ''
335
- license ''
336
- description 'Installs/Configures local-cookbook'
337
- long_description 'Installs/Configures local-cookbook'
338
- version '2.3.4'
339
-
340
- depends "not-a-thing"
341
-
342
- E
343
- end
344
-
345
- before do
346
- ensure_metadata_as_expected!
347
- with_file(metadata_path) { |f| f.print(new_metadata) }
348
- end
349
-
350
- it "reports the not-satisfied dependency and validation fails" do
351
- error_message = "Cookbook local-cookbook (2.3.4) has dependency constraints that cannot be met by the existing cookbook set:\n" +
352
- "Cookbook not-a-thing isn't included in the existing cookbook set."
353
- expect { policyfile_lock.validate_cookbooks! }.to raise_error(ChefDK::DependencyConflict, error_message)
354
- end
355
-
356
- end
357
-
358
- context "when a :path source cookbook has modified a dep constraint and the new constraint is satisfied" do
359
-
360
- let(:solution_dependencies) do
361
- {
362
- "Policyfile" => [],
363
- "dependencies" => {
364
- "foo (1.0.0)" => [],
365
- "local-cookbook (2.3.4)" => [ ["foo", ">= 0.0.0"] ],
366
- },
367
- }
368
- end
369
-
370
- let(:new_metadata) do
371
- <<-E
372
- name 'local-cookbook'
373
- maintainer ''
374
- maintainer_email ''
375
- license ''
376
- description 'Installs/Configures local-cookbook'
377
- long_description 'Installs/Configures local-cookbook'
378
- version '2.3.4'
379
-
380
- depends "foo", ">= 1.0.0"
381
-
382
- E
383
- end
384
-
385
- before do
386
- ensure_metadata_as_expected!
387
- with_file(metadata_path) { |f| f.print(new_metadata) }
388
- policyfile_lock.validate_cookbooks! # no error
389
- end
390
-
391
- it "updates the lockfile with the new checksum and validation succeeds" do
392
- actual = policyfile_lock.solution_dependencies.to_lock["dependencies"]
393
- expected = {
394
- "local-cookbook (2.3.4)" => [ ["foo", ">= 1.0.0"] ],
395
- "foo (1.0.0)" => [],
396
- }
397
- expect(actual).to eq(expected)
398
- end
399
-
400
- end
401
-
402
- context "when a :path source cookbook has modified a dep constraint and the new constraint is not satisfied" do
403
-
404
- let(:new_metadata) do
405
- <<-E
406
- name 'local-cookbook'
407
- maintainer ''
408
- maintainer_email ''
409
- license ''
410
- description 'Installs/Configures local-cookbook'
411
- long_description 'Installs/Configures local-cookbook'
412
- version '2.3.4'
413
-
414
- depends "foo", "~> 2.0"
415
-
416
- E
417
- end
418
-
419
- before do
420
- ensure_metadata_as_expected!
421
- with_file(metadata_path) { |f| f.print(new_metadata) }
422
- end
423
-
424
- it "reports the not-satisfied dependency and validation fails" do
425
- error_message = "Cookbook local-cookbook (2.3.4) has dependency constraints that cannot be met by the existing cookbook set:\n" +
426
- "Dependency on foo ~> 2.0 conflicts with existing version foo (1.0.0)"
427
- expect { policyfile_lock.validate_cookbooks! }.to raise_error(ChefDK::DependencyConflict, error_message)
428
- end
429
-
430
- end
431
-
432
- context "when a :path source cookbook has updated it's version and another path source cookbook has updated its constraint" do
433
-
434
- # The situation we want to test here is when the user modifies a
435
- # cookbook's version, and also the dependency constraint on that cookbook
436
- # in a different cookbook. For example, cookbook A depends on B ~> 1.0,
437
- # then the user updates A to depend on B ~> 2.0, and bumps the version of B to 2.0.
438
-
439
- let(:lock_generator) do
440
- ChefDK::PolicyfileLock.build(storage_config) do |policy|
441
-
442
- policy.name = name
443
-
444
- policy.run_list = run_list
445
-
446
- policy.cached_cookbook("foo") do |c|
447
- c.origin = "https://artifact-server.example/foo/1.0.0"
448
- c.cache_key = "foo-1.0.0"
449
- c.source_options = { artifactserver: "https://artifact-server.example/foo/1.0.0", version: "1.0.0" }
450
- end
451
-
452
- policy.local_cookbook("local-cookbook") do |c|
453
- c.source = "local-cookbook"
454
- c.source_options = { path: "local-cookbook" }
455
- end
456
-
457
- policy.local_cookbook("another-local-cookbook") do |c|
458
- c.source = "another-local-cookbook"
459
- c.source_options = { path: "another-local-cookbook" }
460
- end
461
- policy.solution_dependencies.consume_lock_data(solution_dependencies)
462
- end
463
- end
464
-
465
- # Represents dependencies before modification
466
- let(:solution_dependencies) do
467
- {
468
- "Policyfile" => [],
469
- "dependencies" => {
470
- "foo (1.0.0)" => [],
471
- "local-cookbook (2.3.4)" => [ ],
472
- "another-local-cookbook (0.1.0)" => [ ["local-cookbook", "= 2.3.4"] ],
473
- },
474
- }
475
- end
476
-
477
- let(:new_metadata_local_cookbook) do
478
- <<-E
479
- name 'local-cookbook'
480
- maintainer ''
481
- maintainer_email ''
482
- license ''
483
- description 'Installs/Configures local-cookbook'
484
- long_description 'Installs/Configures local-cookbook'
485
- version '3.0.0' # changed from 2.3.4
486
-
487
- E
488
- end
489
-
490
- let(:new_metadata_another_local_cookbook) do
491
- <<-E
492
- name 'another-local-cookbook'
493
- maintainer ''
494
- maintainer_email ''
495
- license ''
496
- description 'Installs/Configures another-local-cookbook'
497
- long_description 'Installs/Configures another-local-cookbook'
498
- version '0.1.0'
499
-
500
- # This dep now requires the updated version of 'local-cookbook'
501
- depends 'local-cookbook', '= 3.0.0'
502
- E
503
- end
504
-
505
- let(:metadata_path_another_local_cookbook) do
506
- File.join(local_cookbooks_root, "another-local-cookbook", "metadata.rb")
507
- end
508
-
509
- before do
510
- ensure_metadata_as_expected!
511
- with_file(metadata_path) { |f| f.print(new_metadata_local_cookbook) }
512
- with_file(metadata_path_another_local_cookbook) { |f| f.print(new_metadata_another_local_cookbook) }
513
- policyfile_lock.validate_cookbooks! # no error
514
- end
515
-
516
- context "and the new constraint is satisfied by they new version" do
517
-
518
- it "updates the version and constraint in the lockfile (validation succeeds)" do
519
- actual = policyfile_lock.solution_dependencies.to_lock["dependencies"]
520
- expected = {
521
- "local-cookbook (3.0.0)" => [ ],
522
- "another-local-cookbook (0.1.0)" => [ [ "local-cookbook", "= 3.0.0" ] ],
523
- "foo (1.0.0)" => [],
524
- }
525
- expect(actual).to eq(expected)
526
- end
527
-
528
- end
529
-
530
- end
531
-
532
- end
533
-
534
- # Cached cookbook is both supermarket and git
535
- context "when a cached cookbook is modified" do
536
-
537
- let(:cached_cookbook_path) { File.join(cache_path, "foo-1.0.0") }
538
-
539
- let(:metadata_path) { File.join(cached_cookbook_path, "metadata.rb") }
540
-
541
- # Validate the metadata is correct, so we know the test setup code
542
- # hasn't done something wrong.
543
- def ensure_metadata_as_expected!
544
- expected_metadata_rb = <<-E
545
- name 'foo'
546
- maintainer ''
547
- maintainer_email ''
548
- license ''
549
- description 'Installs/Configures foo'
550
- long_description 'Installs/Configures foo'
551
- version '1.0.0'
552
-
553
- E
554
- expect(IO.read(metadata_path)).to eq(expected_metadata_rb)
555
- end
556
-
557
- context "when the cookbook missing" do
558
-
559
- before do
560
- ensure_metadata_as_expected!
561
- FileUtils.rm_rf(cached_cookbook_path)
562
- end
563
-
564
- it "reports the missing cookbook and fails validation" do
565
- message = "Cookbook `foo' not found at expected cache location `foo-1.0.0' (full path: `#{cached_cookbook_path}')"
566
- expect { policyfile_lock.validate_cookbooks! }.to raise_error(ChefDK::CachedCookbookNotFound, message)
567
- end
568
-
569
- end
570
-
571
- context "when the content has changed" do
572
-
573
- # This basically means the user modified the cached cookbook. There's no
574
- # technical reason we need to be whiny about this, but if we treat it like
575
- # we would a path cookbook, you could end up with two cookbooks that look
576
- # like the canonical (e.g.) apache2 1.2.3 cookbook from supermarket with no
577
- # indication of which is which.
578
- #
579
- # We'll treat it like an error, but we need to provide a "pristine"
580
- # function to let the user recover.
581
-
582
- let(:new_metadata) do
583
- <<-E
584
- # This is a cached copy of an upstream cookbook, I should not be editing it but
585
- # YOLO
586
- name 'foo'
587
- maintainer ''
588
- maintainer_email ''
589
- license ''
590
- description 'Installs/Configures foo'
591
- long_description 'Installs/Configures foo'
592
- version '1.0.0'
593
- E
594
- end
595
-
596
- before do
597
- ensure_metadata_as_expected!
598
- policyfile_lock
599
- with_file(metadata_path) { |f| f.print(new_metadata) }
600
- end
601
-
602
- it "reports the modified cached cookbook and validation fails" do
603
- message = "Cached cookbook `foo' (1.0.0) has been modified since the lockfile was generated. Cached cookbooks cannot be modified. (full path: `#{cached_cookbook_path}')"
604
- expect { policyfile_lock.validate_cookbooks! }.to raise_error(ChefDK::CachedCookbookModified, message)
605
- end
606
- end
607
- end
608
- end
1
+ #
2
+ # Copyright:: Copyright (c) 2014-2018 Chef Software Inc.
3
+ # License:: Apache License, Version 2.0
4
+ #
5
+ # Licensed under the Apache License, Version 2.0 (the "License");
6
+ # you may not use this file except in compliance with the License.
7
+ # You may obtain a copy of the License at
8
+ #
9
+ # http://www.apache.org/licenses/LICENSE-2.0
10
+ #
11
+ # Unless required by applicable law or agreed to in writing, software
12
+ # distributed under the License is distributed on an "AS IS" BASIS,
13
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14
+ # See the License for the specific language governing permissions and
15
+ # limitations under the License.
16
+ #
17
+
18
+ require "spec_helper"
19
+ require "chef-dk/policyfile_lock.rb"
20
+
21
+ describe ChefDK::PolicyfileLock, "validating locked cookbooks" do
22
+
23
+ include ChefDK::Helpers
24
+
25
+ let(:pristine_cache_path) do
26
+ File.expand_path("spec/unit/fixtures/cookbook_cache", project_root)
27
+ end
28
+
29
+ let(:cache_path) do
30
+ temp_cache_path = File.join(tempdir, "local_cache")
31
+ FileUtils.cp_r(pristine_cache_path, temp_cache_path)
32
+ temp_cache_path
33
+ end
34
+
35
+ let(:policyfile_lock_path) { "/fakepath/Policyfile.lock.json" }
36
+
37
+ let(:local_cookbooks_root) do
38
+ temp_local_path_cookbooks = File.join(tempdir, "local_path_cookbooks")
39
+ FileUtils.cp_r(File.join(fixtures_path, "local_path_cookbooks"), temp_local_path_cookbooks)
40
+ temp_local_path_cookbooks
41
+ end
42
+
43
+ let(:name) { "application-server" }
44
+
45
+ let(:run_list) { [ "recipe[erlang::default]", "recipe[erchef::prereqs]", "recipe[erchef::app]" ] }
46
+
47
+ let(:storage_config) do
48
+ ChefDK::Policyfile::StorageConfig.new( cache_path: cache_path, relative_paths_root: local_cookbooks_root )
49
+ end
50
+
51
+ let(:solution_dependencies) do
52
+ {
53
+ "Policyfile" => [],
54
+ "dependencies" => {
55
+ "foo (1.0.0)" => [],
56
+ "local-cookbook (2.3.4)" => [],
57
+ },
58
+ }
59
+ end
60
+
61
+ let(:lock_generator) do
62
+ ChefDK::PolicyfileLock.build(storage_config) do |policy|
63
+
64
+ policy.name = name
65
+
66
+ policy.run_list = run_list
67
+
68
+ policy.cached_cookbook("foo") do |c|
69
+ c.origin = "https://artifact-server.example/foo/1.0.0"
70
+ c.cache_key = "foo-1.0.0"
71
+ c.source_options = { artifactserver: "https://artifact-server.example/foo/1.0.0", version: "1.0.0" }
72
+ end
73
+
74
+ policy.local_cookbook("local-cookbook") do |c|
75
+ c.source = "local-cookbook"
76
+ c.source_options = { path: "local-cookbook" }
77
+ end
78
+
79
+ policy.solution_dependencies.consume_lock_data(solution_dependencies)
80
+ end
81
+ end
82
+
83
+ let(:lock_data) do
84
+ lock_generator.to_lock
85
+ end
86
+
87
+ # Eagerly evaluate #policyfile_lock. This is necessary because many of
88
+ # the tests follow this general process:
89
+ # 1. setup valid state, generate a lockfile in-memory
90
+ # 2. make the state invalid
91
+ # 3. ensure validation detected the invalid state
92
+ #
93
+ # With lazy evaluation, #1 may happen after #2.
94
+ let!(:policyfile_lock) do
95
+ ChefDK::PolicyfileLock.new(storage_config).build_from_lock_data(lock_data)
96
+ end
97
+
98
+ let(:local_cookbook_path) { File.join(local_cookbooks_root, "local-cookbook") }
99
+
100
+ context "when no cookbooks have changed" do
101
+
102
+ it "validation succeeds" do
103
+ expect(policyfile_lock.validate_cookbooks!).to be true
104
+ end
105
+
106
+ end
107
+
108
+ describe "when a :path sourced cookbook has changed" do
109
+
110
+ let(:metadata_path) { File.join(local_cookbook_path, "metadata.rb") }
111
+
112
+ let(:cookbook_lock_data) { policyfile_lock.lock_data_for("local-cookbook") }
113
+
114
+ # Validate the metadata is correct, so we know the test setup code
115
+ # hasn't done something wrong.
116
+ def ensure_metadata_as_expected!
117
+ expected_metadata_rb = <<-E
118
+ name 'local-cookbook'
119
+ maintainer ''
120
+ maintainer_email ''
121
+ license ''
122
+ description 'Installs/Configures local-cookbook'
123
+ long_description 'Installs/Configures local-cookbook'
124
+ version '2.3.4'
125
+
126
+ E
127
+ expect(IO.read(metadata_path)).to eq(expected_metadata_rb)
128
+ end
129
+
130
+ context "when the cookbook is missing" do
131
+
132
+ before do
133
+ FileUtils.rm_rf(local_cookbook_path)
134
+ end
135
+
136
+ it "reports the missing cookbook and fails validation" do
137
+ full_path = File.expand_path(local_cookbook_path)
138
+ message = "Cookbook `local-cookbook' not found at path source `local-cookbook` (full path: `#{full_path}')"
139
+
140
+ expect { policyfile_lock.validate_cookbooks! }.to raise_error(ChefDK::LocalCookbookNotFound, message)
141
+ end
142
+
143
+ end
144
+
145
+ context "when the cookbook has an incorrect name" do
146
+
147
+ let(:new_metadata) do
148
+ <<-E
149
+ name 'WRONG'
150
+ maintainer ''
151
+ maintainer_email ''
152
+ license ''
153
+ description 'Installs/Configures local-cookbook'
154
+ long_description 'Installs/Configures local-cookbook'
155
+ version '2.3.4'
156
+
157
+ E
158
+ end
159
+
160
+ before do
161
+ ensure_metadata_as_expected!
162
+ with_file(metadata_path) { |f| f.print(new_metadata) }
163
+ end
164
+
165
+ it "reports the unexpected cookbook and fails validation" do
166
+ policyfile_lock
167
+
168
+ message = "The cookbook at path source `local-cookbook' is expected to be named `local-cookbook', but is now named `WRONG' (full path: #{local_cookbook_path})"
169
+ expect { policyfile_lock.validate_cookbooks! }.to raise_error(ChefDK::MalformedCookbook, message)
170
+ end
171
+
172
+ end
173
+
174
+ context "when the cookbook has an updated version that violates no dependency constraints" do
175
+
176
+ let(:new_metadata) do
177
+ <<-E
178
+ name 'local-cookbook'
179
+ maintainer ''
180
+ maintainer_email ''
181
+ license ''
182
+ description 'Installs/Configures local-cookbook'
183
+ long_description 'Installs/Configures local-cookbook'
184
+ version '2.3.5' # changed from 2.3.4
185
+
186
+ E
187
+ end
188
+
189
+ before do
190
+ ensure_metadata_as_expected!
191
+ with_file(metadata_path) { |f| f.print(new_metadata) }
192
+ policyfile_lock.validate_cookbooks! # no error
193
+ end
194
+
195
+ it "updates the version information in the lockfile" do
196
+ expect(cookbook_lock_data.version).to eq("2.3.5")
197
+ end
198
+
199
+ it "updates the content identifier" do
200
+ old_id = lock_generator.lock_data_for("local-cookbook").identifier
201
+ expect(cookbook_lock_data.identifier).to_not eq(old_id)
202
+ expect(cookbook_lock_data.identifier).to eq("5a2b09f9d5e6e8a1a2d811c41d58ed200599adbe")
203
+ end
204
+
205
+ it "has an updated version and identifier" do
206
+ expect(cookbook_lock_data).to be_updated
207
+ expect(cookbook_lock_data.version_updated?).to be true
208
+ expect(cookbook_lock_data.identifier_updated?).to be true
209
+ end
210
+ end
211
+
212
+ context "when the cookbook has an updated version that violates other dependency constraints" do
213
+
214
+ let(:solution_dependencies) do
215
+ {
216
+ "Policyfile" => [],
217
+ "dependencies" => {
218
+ "foo (1.0.0)" => [ [ "local-cookbook", "~> 2.0" ] ],
219
+ },
220
+ }
221
+ end
222
+
223
+ let(:new_metadata) do
224
+ <<-E
225
+ name 'local-cookbook'
226
+ maintainer ''
227
+ maintainer_email ''
228
+ license ''
229
+ description 'Installs/Configures local-cookbook'
230
+ long_description 'Installs/Configures local-cookbook'
231
+ version '3.0.0' # changed from 2.3.4, violates `~> 2.0` constraint
232
+
233
+ E
234
+ end
235
+
236
+ before do
237
+ ensure_metadata_as_expected!
238
+ with_file(metadata_path) { |f| f.print(new_metadata) }
239
+ end
240
+
241
+ it "reports the dependency conflict and fails validation" do
242
+ expected_message = "Cookbook local-cookbook (3.0.0) conflicts with other dependencies:\nfoo (1.0.0) depends on local-cookbook ~> 2.0"
243
+ expect { policyfile_lock.validate_cookbooks! }.to raise_error(ChefDK::DependencyConflict, expected_message)
244
+ end
245
+
246
+ end
247
+
248
+ context "when a :path sourced cookbook has updated content" do
249
+
250
+ let(:recipe_path) { File.join(local_cookbook_path, "recipes/default.rb") }
251
+
252
+ let(:new_recipe) do
253
+ <<-E
254
+ # This is totally new code,
255
+ # it is different than the old code
256
+
257
+ E
258
+ end
259
+
260
+ before do
261
+ ensure_metadata_as_expected!
262
+ with_file(recipe_path) { |f| f.print(new_recipe) }
263
+ policyfile_lock.validate_cookbooks! # no error
264
+ end
265
+
266
+ it "updates the lockfile with the new checksum and validation succeeds" do
267
+ old_id = lock_generator.lock_data_for("local-cookbook").identifier
268
+
269
+ expect(cookbook_lock_data.identifier).to_not eq(old_id)
270
+ expect(cookbook_lock_data.identifier).to eq("0f62422f744d173c35a3e74f1a8c76c8b92908c2")
271
+ end
272
+
273
+ it "has an updated identifier but not an updated version" do
274
+ expect(cookbook_lock_data).to be_updated
275
+ expect(cookbook_lock_data.version_updated?).to be false
276
+ expect(cookbook_lock_data.identifier_updated?).to be true
277
+ end
278
+
279
+ end
280
+
281
+ context "when a :path source cookbook has added a dependency satisfied by the current cookbook set" do
282
+
283
+ let(:new_metadata) do
284
+ <<-E
285
+ name 'local-cookbook'
286
+ maintainer ''
287
+ maintainer_email ''
288
+ license ''
289
+ description 'Installs/Configures local-cookbook'
290
+ long_description 'Installs/Configures local-cookbook'
291
+ version '2.3.4'
292
+
293
+ depends "foo", "=1.0.0"
294
+
295
+ E
296
+ end
297
+
298
+ before do
299
+ ensure_metadata_as_expected!
300
+ with_file(metadata_path) { |f| f.print(new_metadata) }
301
+ policyfile_lock.validate_cookbooks! # no error
302
+ end
303
+
304
+ it "updates the lockfile with the new checksum and validation succeeds" do
305
+ old_id = lock_generator.lock_data_for("local-cookbook").identifier
306
+
307
+ expect(cookbook_lock_data.identifier).to_not eq(old_id)
308
+ expect(cookbook_lock_data.identifier).to eq("af5e1252307bdf99b878ca5ede3c40e24ee9e45a")
309
+ end
310
+
311
+ it "has an updated identifier but not an updated version" do
312
+ expect(cookbook_lock_data).to be_updated
313
+ expect(cookbook_lock_data.version_updated?).to be false
314
+ expect(cookbook_lock_data.identifier_updated?).to be true
315
+ end
316
+
317
+ it "has an updated dependency set" do
318
+ actual = policyfile_lock.solution_dependencies.to_lock["dependencies"]
319
+ expected = {
320
+ "local-cookbook (2.3.4)" => [ ["foo", "= 1.0.0"] ],
321
+ "foo (1.0.0)" => [],
322
+ }
323
+ expect(actual).to eq(expected)
324
+ end
325
+
326
+ end
327
+
328
+ context "when a :path source cookbook has added a dependency not satisfied by the current cookbook set" do
329
+
330
+ let(:new_metadata) do
331
+ <<-E
332
+ name 'local-cookbook'
333
+ maintainer ''
334
+ maintainer_email ''
335
+ license ''
336
+ description 'Installs/Configures local-cookbook'
337
+ long_description 'Installs/Configures local-cookbook'
338
+ version '2.3.4'
339
+
340
+ depends "not-a-thing"
341
+
342
+ E
343
+ end
344
+
345
+ before do
346
+ ensure_metadata_as_expected!
347
+ with_file(metadata_path) { |f| f.print(new_metadata) }
348
+ end
349
+
350
+ it "reports the not-satisfied dependency and validation fails" do
351
+ error_message = "Cookbook local-cookbook (2.3.4) has dependency constraints that cannot be met by the existing cookbook set:\n" +
352
+ "Cookbook not-a-thing isn't included in the existing cookbook set."
353
+ expect { policyfile_lock.validate_cookbooks! }.to raise_error(ChefDK::DependencyConflict, error_message)
354
+ end
355
+
356
+ end
357
+
358
+ context "when a :path source cookbook has modified a dep constraint and the new constraint is satisfied" do
359
+
360
+ let(:solution_dependencies) do
361
+ {
362
+ "Policyfile" => [],
363
+ "dependencies" => {
364
+ "foo (1.0.0)" => [],
365
+ "local-cookbook (2.3.4)" => [ ["foo", ">= 0.0.0"] ],
366
+ },
367
+ }
368
+ end
369
+
370
+ let(:new_metadata) do
371
+ <<-E
372
+ name 'local-cookbook'
373
+ maintainer ''
374
+ maintainer_email ''
375
+ license ''
376
+ description 'Installs/Configures local-cookbook'
377
+ long_description 'Installs/Configures local-cookbook'
378
+ version '2.3.4'
379
+
380
+ depends "foo", ">= 1.0.0"
381
+
382
+ E
383
+ end
384
+
385
+ before do
386
+ ensure_metadata_as_expected!
387
+ with_file(metadata_path) { |f| f.print(new_metadata) }
388
+ policyfile_lock.validate_cookbooks! # no error
389
+ end
390
+
391
+ it "updates the lockfile with the new checksum and validation succeeds" do
392
+ actual = policyfile_lock.solution_dependencies.to_lock["dependencies"]
393
+ expected = {
394
+ "local-cookbook (2.3.4)" => [ ["foo", ">= 1.0.0"] ],
395
+ "foo (1.0.0)" => [],
396
+ }
397
+ expect(actual).to eq(expected)
398
+ end
399
+
400
+ end
401
+
402
+ context "when a :path source cookbook has modified a dep constraint and the new constraint is not satisfied" do
403
+
404
+ let(:new_metadata) do
405
+ <<-E
406
+ name 'local-cookbook'
407
+ maintainer ''
408
+ maintainer_email ''
409
+ license ''
410
+ description 'Installs/Configures local-cookbook'
411
+ long_description 'Installs/Configures local-cookbook'
412
+ version '2.3.4'
413
+
414
+ depends "foo", "~> 2.0"
415
+
416
+ E
417
+ end
418
+
419
+ before do
420
+ ensure_metadata_as_expected!
421
+ with_file(metadata_path) { |f| f.print(new_metadata) }
422
+ end
423
+
424
+ it "reports the not-satisfied dependency and validation fails" do
425
+ error_message = "Cookbook local-cookbook (2.3.4) has dependency constraints that cannot be met by the existing cookbook set:\n" +
426
+ "Dependency on foo ~> 2.0 conflicts with existing version foo (1.0.0)"
427
+ expect { policyfile_lock.validate_cookbooks! }.to raise_error(ChefDK::DependencyConflict, error_message)
428
+ end
429
+
430
+ end
431
+
432
+ context "when a :path source cookbook has updated it's version and another path source cookbook has updated its constraint" do
433
+
434
+ # The situation we want to test here is when the user modifies a
435
+ # cookbook's version, and also the dependency constraint on that cookbook
436
+ # in a different cookbook. For example, cookbook A depends on B ~> 1.0,
437
+ # then the user updates A to depend on B ~> 2.0, and bumps the version of B to 2.0.
438
+
439
+ let(:lock_generator) do
440
+ ChefDK::PolicyfileLock.build(storage_config) do |policy|
441
+
442
+ policy.name = name
443
+
444
+ policy.run_list = run_list
445
+
446
+ policy.cached_cookbook("foo") do |c|
447
+ c.origin = "https://artifact-server.example/foo/1.0.0"
448
+ c.cache_key = "foo-1.0.0"
449
+ c.source_options = { artifactserver: "https://artifact-server.example/foo/1.0.0", version: "1.0.0" }
450
+ end
451
+
452
+ policy.local_cookbook("local-cookbook") do |c|
453
+ c.source = "local-cookbook"
454
+ c.source_options = { path: "local-cookbook" }
455
+ end
456
+
457
+ policy.local_cookbook("another-local-cookbook") do |c|
458
+ c.source = "another-local-cookbook"
459
+ c.source_options = { path: "another-local-cookbook" }
460
+ end
461
+ policy.solution_dependencies.consume_lock_data(solution_dependencies)
462
+ end
463
+ end
464
+
465
+ # Represents dependencies before modification
466
+ let(:solution_dependencies) do
467
+ {
468
+ "Policyfile" => [],
469
+ "dependencies" => {
470
+ "foo (1.0.0)" => [],
471
+ "local-cookbook (2.3.4)" => [ ],
472
+ "another-local-cookbook (0.1.0)" => [ ["local-cookbook", "= 2.3.4"] ],
473
+ },
474
+ }
475
+ end
476
+
477
+ let(:new_metadata_local_cookbook) do
478
+ <<-E
479
+ name 'local-cookbook'
480
+ maintainer ''
481
+ maintainer_email ''
482
+ license ''
483
+ description 'Installs/Configures local-cookbook'
484
+ long_description 'Installs/Configures local-cookbook'
485
+ version '3.0.0' # changed from 2.3.4
486
+
487
+ E
488
+ end
489
+
490
+ let(:new_metadata_another_local_cookbook) do
491
+ <<-E
492
+ name 'another-local-cookbook'
493
+ maintainer ''
494
+ maintainer_email ''
495
+ license ''
496
+ description 'Installs/Configures another-local-cookbook'
497
+ long_description 'Installs/Configures another-local-cookbook'
498
+ version '0.1.0'
499
+
500
+ # This dep now requires the updated version of 'local-cookbook'
501
+ depends 'local-cookbook', '= 3.0.0'
502
+ E
503
+ end
504
+
505
+ let(:metadata_path_another_local_cookbook) do
506
+ File.join(local_cookbooks_root, "another-local-cookbook", "metadata.rb")
507
+ end
508
+
509
+ before do
510
+ ensure_metadata_as_expected!
511
+ with_file(metadata_path) { |f| f.print(new_metadata_local_cookbook) }
512
+ with_file(metadata_path_another_local_cookbook) { |f| f.print(new_metadata_another_local_cookbook) }
513
+ policyfile_lock.validate_cookbooks! # no error
514
+ end
515
+
516
+ context "and the new constraint is satisfied by they new version" do
517
+
518
+ it "updates the version and constraint in the lockfile (validation succeeds)" do
519
+ actual = policyfile_lock.solution_dependencies.to_lock["dependencies"]
520
+ expected = {
521
+ "local-cookbook (3.0.0)" => [ ],
522
+ "another-local-cookbook (0.1.0)" => [ [ "local-cookbook", "= 3.0.0" ] ],
523
+ "foo (1.0.0)" => [],
524
+ }
525
+ expect(actual).to eq(expected)
526
+ end
527
+
528
+ end
529
+
530
+ end
531
+
532
+ end
533
+
534
+ # Cached cookbook is both supermarket and git
535
+ context "when a cached cookbook is modified" do
536
+
537
+ let(:cached_cookbook_path) { File.join(cache_path, "foo-1.0.0") }
538
+
539
+ let(:metadata_path) { File.join(cached_cookbook_path, "metadata.rb") }
540
+
541
+ # Validate the metadata is correct, so we know the test setup code
542
+ # hasn't done something wrong.
543
+ def ensure_metadata_as_expected!
544
+ expected_metadata_rb = <<-E
545
+ name 'foo'
546
+ maintainer ''
547
+ maintainer_email ''
548
+ license ''
549
+ description 'Installs/Configures foo'
550
+ long_description 'Installs/Configures foo'
551
+ version '1.0.0'
552
+
553
+ E
554
+ expect(IO.read(metadata_path)).to eq(expected_metadata_rb)
555
+ end
556
+
557
+ context "when the cookbook missing" do
558
+
559
+ before do
560
+ ensure_metadata_as_expected!
561
+ FileUtils.rm_rf(cached_cookbook_path)
562
+ end
563
+
564
+ it "reports the missing cookbook and fails validation" do
565
+ message = "Cookbook `foo' not found at expected cache location `foo-1.0.0' (full path: `#{cached_cookbook_path}')"
566
+ expect { policyfile_lock.validate_cookbooks! }.to raise_error(ChefDK::CachedCookbookNotFound, message)
567
+ end
568
+
569
+ end
570
+
571
+ context "when the content has changed" do
572
+
573
+ # This basically means the user modified the cached cookbook. There's no
574
+ # technical reason we need to be whiny about this, but if we treat it like
575
+ # we would a path cookbook, you could end up with two cookbooks that look
576
+ # like the canonical (e.g.) apache2 1.2.3 cookbook from supermarket with no
577
+ # indication of which is which.
578
+ #
579
+ # We'll treat it like an error, but we need to provide a "pristine"
580
+ # function to let the user recover.
581
+
582
+ let(:new_metadata) do
583
+ <<-E
584
+ # This is a cached copy of an upstream cookbook, I should not be editing it but
585
+ # YOLO
586
+ name 'foo'
587
+ maintainer ''
588
+ maintainer_email ''
589
+ license ''
590
+ description 'Installs/Configures foo'
591
+ long_description 'Installs/Configures foo'
592
+ version '1.0.0'
593
+ E
594
+ end
595
+
596
+ before do
597
+ ensure_metadata_as_expected!
598
+ policyfile_lock
599
+ with_file(metadata_path) { |f| f.print(new_metadata) }
600
+ end
601
+
602
+ it "reports the modified cached cookbook and validation fails" do
603
+ message = "Cached cookbook `foo' (1.0.0) has been modified since the lockfile was generated. Cached cookbooks cannot be modified. (full path: `#{cached_cookbook_path}')"
604
+ expect { policyfile_lock.validate_cookbooks! }.to raise_error(ChefDK::CachedCookbookModified, message)
605
+ end
606
+ end
607
+ end
608
+ end