checker 0.7.0 → 0.8.0.beta

data/lib/checker/modules/slim.rb

@@ -1,9 +1,11 @@
 module Checker
   module Modules
     class Slim < Base
-      extensions 'slim'
+      extensions "slim"
+
       private
-      def check_one(file, opts = {})
+
+      def check_one(file, _opts = {})
         Checker::Result.result(self, plain_command("slimrb --compile #{file} >> /dev/null"))
       end
 

data/lib/checker/modules/yaml.rb

@@ -1,11 +1,13 @@
-require 'yaml'
+require "yaml"
 
 module Checker
   module Modules
     class Yaml < Base
-      extensions 'yaml', 'yml'
+      extensions "yaml", "yml"
+
       private
-      def check_one(file, opts = {})
+
+      def check_one(file, _opts = {})
         ret = begin
           YAML.load_file(file)
           Checker::Result.result(self, 0)

data/lib/checker/options.rb

@@ -3,7 +3,7 @@ module Checker
     class << self
       def get_config(conf, default = nil)
         config = `git config checker.#{conf}`.chomp
-        (config.empty? && !default.nil?) ? default : config
+        config.empty? && !default.nil? ? default : config
       end
 
       def modules_to_check

data/lib/checker/results/console_log.rb

@@ -2,7 +2,7 @@ module Checker
   module Results
     class ConsoleLog < Default
       def success?
-        (Checker::Options.prevent_commit_on_warning && exitstatus == 0) ? false : true
+        Checker::Options.prevent_commit_on_warning && exitstatus == 0 ? false : true
       end
 
       def status

data/lib/checker/rvm.rb

@@ -2,14 +2,14 @@ module Checker
   class RVM
     class << self
       def rvm_command(command)
-        rvm_gem  = ENV['GEM_HOME'].to_s
+        rvm_gem = ENV["GEM_HOME"].to_s
         rvm_version = rvm_gem.gsub(/.+rvm\/gems\//, "")
 
         "#{rvm_shell} '#{rvm_version}' -c '#{command}'"
       end
 
       def rvm_shell
-        File.join(ENV['rvm_path'].to_s, 'bin/rvm-shell')
+        File.join(ENV["rvm_path"].to_s, "bin/rvm-shell")
       end
     end
   end

data/lib/checker/version.rb

@@ -1,3 +1,3 @@
 module Checker
-  VERSION = '0.7.0'
+  VERSION = "0.8.0.beta".freeze
 end

data/spec/checker/cli_spec.rb

@@ -1,11 +1,13 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Checker
   module Modules
     class Bogus < Base
-      extensions '.test'
+      extensions ".test"
+
       private
-      def check_one(file)
+
+      def check_one(_file)
         true
       end
 
@@ -19,9 +21,9 @@ end
 describe Checker::CLI do
   context "running without arguments" do
     it "should run checks on modules from git config" do
-      ARGV.stub(:size).and_return 0
-      Checker::CLI.should_receive(:get_modules_to_check).and_return(["bogus"])
-      Checker::CLI.should_receive(:exit).with(0).and_return true
+      allow(ARGV).to receive(:empty?).and_return true
+      expect(Checker::CLI).to receive(:get_modules_to_check).and_return(["bogus"])
+      expect(Checker::CLI).to receive(:exit).with(0).and_return true
       Checker::CLI.execute
     end
   end
@@ -29,8 +31,8 @@ describe Checker::CLI do
   context "running with argument" do
     it "should run check on modules from argument" do
       stub_const("ARGV", ["pry"])
-      Checker::CLI.should_not_receive(:get_modules_to_check)
-      Checker::CLI.should_receive(:exit).with(0).and_return true
+      expect(Checker::CLI).not_to receive(:get_modules_to_check)
+      expect(Checker::CLI).to receive(:exit).with(0).and_return true
       Checker::CLI.execute
     end
   end

data/spec/checker/fixtures/conflict/without_conflict.rb

@@ -1,2 +1 @@
-def test
-end
+def test; end

data/spec/checker/fixtures/pry/with_both.rb

@@ -1,4 +1,3 @@
 binding.pry
-def test
-end
+def test; end
 binding.remote_pry

data/spec/checker/fixtures/pry/with_pry.rb

@@ -1,3 +1,3 @@
 def test
   binding.pry
-end
+end

data/spec/checker/fixtures/pry/with_pry_remote.rb

@@ -1,3 +1,3 @@
 def test
   binding.remote_pry
-end
+end

data/spec/checker/fixtures/pry/without_pry.rb

@@ -1,2 +1 @@
-def test
-end
+def test; end

data/spec/checker/fixtures/ruby/good.rb

@@ -1,3 +1,3 @@
 def test
-  {some: 'random', hash: 'qwe'}
+  { some: "random", hash: "qwe" }
 end

data/spec/checker/modules/base_spec.rb

@@ -1,52 +1,52 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Checker::Modules::Base do
   describe "rvm_command method" do
     context "properly fetches the ruby version from the environment variables" do
       before do
-        ENV.stub!(:[]).with("rvm_path").and_return "/Users/test/.rvm"
+        allow(ENV).to receive(:[]).with("rvm_path").and_return "/Users/test/.rvm"
       end
 
       it "uses no gemsets" do
-        ENV.stub!(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version"
+        allow(ENV).to receive(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version"
 
-        Checker::Modules::Base.new.send(:rvm_command, "test").should == "/Users/test/.rvm/bin/rvm-shell 'some_ruby_version' -c 'test'"
+        expect(Checker::Modules::Base.new.send(:rvm_command, "test")).to eq "/Users/test/.rvm/bin/rvm-shell 'some_ruby_version' -c 'test'"
       end
 
       it "uses global gemset" do
-        ENV.stub!(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version@global"
+        allow(ENV).to receive(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version@global"
 
-        Checker::Modules::Base.new.send(:rvm_command, "test").should == "/Users/test/.rvm/bin/rvm-shell 'some_ruby_version@global' -c 'test'"
+        expect(Checker::Modules::Base.new.send(:rvm_command, "test")).to eq "/Users/test/.rvm/bin/rvm-shell 'some_ruby_version@global' -c 'test'"
       end
 
       it "uses some other gemset" do
-        ENV.stub!(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version@v2"
+        allow(ENV).to receive(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version@v2"
 
-        Checker::Modules::Base.new.send(:rvm_command, "test").should == "/Users/test/.rvm/bin/rvm-shell 'some_ruby_version@v2' -c 'test'"
+        expect(Checker::Modules::Base.new.send(:rvm_command, "test")).to eq "/Users/test/.rvm/bin/rvm-shell 'some_ruby_version@v2' -c 'test'"
       end
     end
 
     context "using different rvm_path (system-wide rvm)" do
       before do
-        ENV.stub!(:[]).with("rvm_path").and_return "/usr/lib/rvm"
+        allow(ENV).to receive(:[]).with("rvm_path").and_return "/usr/lib/rvm"
       end
 
       it "uses no gemsets" do
-        ENV.stub!(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version"
+        allow(ENV).to receive(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version"
 
-        Checker::Modules::Base.new.send(:rvm_command, "test").should == "/usr/lib/rvm/bin/rvm-shell 'some_ruby_version' -c 'test'"
+        expect(Checker::Modules::Base.new.send(:rvm_command, "test")).to eq "/usr/lib/rvm/bin/rvm-shell 'some_ruby_version' -c 'test'"
       end
 
       it "uses global gemset" do
-        ENV.stub!(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version@global"
+        allow(ENV).to receive(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version@global"
 
-        Checker::Modules::Base.new.send(:rvm_command, "test").should == "/usr/lib/rvm/bin/rvm-shell 'some_ruby_version@global' -c 'test'"
+        expect(Checker::Modules::Base.new.send(:rvm_command, "test")).to eq "/usr/lib/rvm/bin/rvm-shell 'some_ruby_version@global' -c 'test'"
       end
 
       it "uses some other gemset" do
-        ENV.stub!(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version@v2"
+        allow(ENV).to receive(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version@v2"
 
-        Checker::Modules::Base.new.send(:rvm_command, "test").should == "/usr/lib/rvm/bin/rvm-shell 'some_ruby_version@v2' -c 'test'"
+        expect(Checker::Modules::Base.new.send(:rvm_command, "test")).to eq "/usr/lib/rvm/bin/rvm-shell 'some_ruby_version@v2' -c 'test'"
       end
     end
   end

data/spec/checker/modules/coffeescript_spec.rb

@@ -1,16 +1,16 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Checker::Modules::Coffeescript do
-  it 'should only check .coffee files' do
-    files = ['a.rb', 'b.js.erb', 'c.r', 'd.yml', 'e.yaml', 'f.coffee']
+  it "should only check .coffee files" do
+    files = ["a.rb", "b.js.erb", "c.r", "d.yml", "e.yaml", "f.coffee"]
     mod = Checker::Modules::Coffeescript.new(files)
-    mod.stub(:check_for_executable).and_return(true)
-    mod.should_receive(:check_one_file).with('f.coffee').and_return(stub(:success? => true, :status => :ok))
-    mod.should_not_receive(:check_one_file).with('e.yaml')
-    mod.should_not_receive(:check_one_file).with('d.yml')
-    mod.should_not_receive(:check_one_file).with('a.rb')
-    mod.should_not_receive(:check_one_file).with('b.js.erb')
-    mod.should_not_receive(:check_one_file).with('c.r')
-    mod.check 
+    expect(mod).to receive(:check_for_executable).and_return(true)
+    expect(mod).to receive(:check_one_file).with("f.coffee").and_return(double(success?: true, status: :ok))
+    expect(mod).not_to receive(:check_one_file).with("e.yaml")
+    expect(mod).not_to receive(:check_one_file).with("d.yml")
+    expect(mod).not_to receive(:check_one_file).with("a.rb")
+    expect(mod).not_to receive(:check_one_file).with("b.js.erb")
+    expect(mod).not_to receive(:check_one_file).with("c.r")
+    mod.check
   end
 end

data/spec/checker/modules/conflict_spec.rb

@@ -1,23 +1,23 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Checker::Modules::Conflict do
-  it 'checks all files' do
-    files = ['a.rb', 'b.js.erb', 'c.r', 'd.yaml', 'e.yml', 'f.coffee']
+  it "checks all files" do
+    files = ["a.rb", "b.js.erb", "c.r", "d.yaml", "e.yml", "f.coffee"]
     mod = Checker::Modules::Conflict.new(files)
-    mod.stub(:check_one).and_return(stub(:success? => true, :status => :ok))
-    mod.should_receive(:check_one).exactly(6).times
-    mod.check 
+    allow(mod).to receive(:check_one).and_return(double(success?: true, status: :ok))
+    expect(mod).to receive(:check_one).exactly(6).times
+    mod.check
   end
 
   it "does find git conflict" do
     files = [fixture("conflict", "with_conflict.rb")]
     mod = Checker::Modules::Conflict.new(files)
-    mod.check.should be_false
+    expect(mod.check).to be_falsey
   end
 
   it "does not find git conflict" do
     files = [fixture("conflict", "without_conflict.rb")]
     mod = Checker::Modules::Conflict.new(files)
-    mod.check.should be_true
+    expect(mod.check).to be_truthy
   end
 end

data/spec/checker/modules/console_log_spec.rb

@@ -1,12 +1,12 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Checker::Modules::ConsoleLog do
-  it 'checks coffee and js files' do
-    files = ['a.rb', 'b.js.erb', 'c.r', 'd.yaml', 'e.yml', 'f.coffee', 'g.js']
+  it "checks coffee and js files" do
+    files = ["a.rb", "b.js.erb", "c.r", "d.yaml", "e.yml", "f.coffee", "g.js"]
     mod = Checker::Modules::ConsoleLog.new(files)
-    mod.stub(:check_one).and_return(stub(:success? => true, :status => :ok))
-    mod.should_receive(:check_one).exactly(2).times
-    mod.check 
+    allow(mod).to receive(:check_one).and_return(double(success?: true, status: :ok))
+    expect(mod).to receive(:check_one).exactly(2).times
+    mod.check
   end
 
   describe "does find console.log" do
@@ -16,17 +16,17 @@ describe Checker::Modules::ConsoleLog do
     end
 
     it "results to be true if prevent_commit_on_warning is set to false" do
-      Checker::Options.stub(:prevent_commit_on_warning).and_return(false)
-      @mod.check.should be_true
+      allow(Checker::Options).to receive(:prevent_commit_on_warning).and_return(false)
+      expect(@mod.check).to be_truthy
     end
 
     it "results to be false if prevent_commit_on_warning is set to true" do
-      Checker::Options.stub(:prevent_commit_on_warning).and_return(true)
-      @mod.check.should be_false
+      allow(Checker::Options).to receive(:prevent_commit_on_warning).and_return(true)
+      expect(@mod.check).to be_falsey
     end
 
     it "prints proper message" do
-      @mod.should_receive(:print_warning_message)
+      expect(@mod).to receive(:print_warning_message)
       @mod.check
     end
   end
@@ -38,11 +38,11 @@ describe Checker::Modules::ConsoleLog do
     end
 
     it "results to be true" do
-      @mod.check.should be_true
+      expect(@mod.check).to be_truthy
     end
 
     it "prints proper message" do
-      @mod.should_receive(:print_success_message)
+      expect(@mod).to receive(:print_success_message)
       @mod.check
     end
   end

data/spec/checker/modules/haml_spec.rb

@@ -1,18 +1,18 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Checker::Modules::Haml do
-  it 'should only check .haml files' do
-    files = ['a.rb', 'b.js.erb', 'c.r', 'd.yml', 'e.yaml', 'f.coffee', 'g.haml']
+  it "should only check .haml files" do
+    files = ["a.rb", "b.js.erb", "c.r", "d.yml", "e.yaml", "f.coffee", "g.haml"]
     mod = Checker::Modules::Haml.new(files)
-    mod.stub(:check_for_executable).and_return(true)
-    mod.stub(:check_one_file).and_return(stub(:success? => true, :status => :ok))
-    mod.should_receive(:check_one_file).with('g.haml')
-    mod.should_not_receive(:check_one_file).with('f.coffee')
-    mod.should_not_receive(:check_one_file).with('e.yaml')
-    mod.should_not_receive(:check_one_file).with('d.yml')
-    mod.should_not_receive(:check_one_file).with('a.rb')
-    mod.should_not_receive(:check_one_file).with('b.js.erb')
-    mod.should_not_receive(:check_one_file).with('c.r')
-    mod.check 
+    allow(mod).to receive(:check_for_executable).and_return(true)
+    allow(mod).to receive(:check_one_file).and_return(double(success?: true, status: :ok))
+    expect(mod).to receive(:check_one_file).with("g.haml")
+    expect(mod).not_to receive(:check_one_file).with("f.coffee")
+    expect(mod).not_to receive(:check_one_file).with("e.yaml")
+    expect(mod).not_to receive(:check_one_file).with("d.yml")
+    expect(mod).not_to receive(:check_one_file).with("a.rb")
+    expect(mod).not_to receive(:check_one_file).with("b.js.erb")
+    expect(mod).not_to receive(:check_one_file).with("c.r")
+    mod.check
   end
 end

data/spec/checker/modules/javascript_spec.rb

@@ -1,26 +1,26 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Checker::Modules::Javascript do
-  it 'should only check .js files' do
-    files = ['a.rb', 'b.js.erb', 'c.r', 'd.yml', 'e.yaml', 'f.coffee', 'g.haml', 'h.js']
+  it "should only check .js files" do
+    files = ["a.rb", "b.js.erb", "c.r", "d.yml", "e.yaml", "f.coffee", "g.haml", "h.js"]
     mod = Checker::Modules::Javascript.new(files)
-    mod.stub(:check_for_executable).and_return(true)
-    mod.should_receive(:check_one_file).with('h.js').and_return(stub(:success? => true, :status => :ok))
-    mod.should_not_receive(:check_one_file).with('g.haml')
-    mod.should_not_receive(:check_one_file).with('f.coffee')
-    mod.should_not_receive(:check_one_file).with('e.yaml')
-    mod.should_not_receive(:check_one_file).with('d.yml')
-    mod.should_not_receive(:check_one_file).with('a.rb')
-    mod.should_not_receive(:check_one_file).with('b.js.erb')
-    mod.should_not_receive(:check_one_file).with('c.r')
-    mod.check 
+    allow(mod).to receive(:check_for_executable).and_return(true)
+    expect(mod).to receive(:check_one_file).with("h.js").and_return(double(success?: true, status: :ok))
+    expect(mod).not_to receive(:check_one_file).with("g.haml")
+    expect(mod).not_to receive(:check_one_file).with("f.coffee")
+    expect(mod).not_to receive(:check_one_file).with("e.yaml")
+    expect(mod).not_to receive(:check_one_file).with("d.yml")
+    expect(mod).not_to receive(:check_one_file).with("a.rb")
+    expect(mod).not_to receive(:check_one_file).with("b.js.erb")
+    expect(mod).not_to receive(:check_one_file).with("c.r")
+    mod.check
   end
 
   describe "good js file" do
     before do
-      files = ['good.js']
+      files = ["good.js"]
       @mod = Checker::Modules::Javascript.new(files)
-      @mod.should_receive(:check_one_file).with('good.js').and_return(stub(:success? => true, :status => :ok))
+      expect(@mod).to receive(:check_one_file).with("good.js").and_return(double(success?: true, status: :ok))
     end
 
     xit "results to be true" do
@@ -28,16 +28,16 @@ describe Checker::Modules::Javascript do
     end
 
     xit "prints proper message" do
-      @mod.should_receive(:print_success_message)
+      expect(@mod).to receive(:print_success_message)
       @mod.check
     end
   end
 
   describe "js with warnings" do
     before do
-      files = ['warning.js']
+      files = ["warning.js"]
       @mod = Checker::Modules::Javascript.new(files)
-      @mod.should_receive(:check_one_file).with('warning.js').and_return(stub(:success? => true, :status => :warning))
+      expect(@mod).to receive(:check_one_file).with("warning.js").and_return(double(success?: true, status: :warning))
     end
 
     xit "results to be true" do
@@ -45,16 +45,16 @@ describe Checker::Modules::Javascript do
     end
 
     xit "prints proper message" do
-      @mod.should_receive(:print_warning_message)
+      expect(@mod).to receive(:print_warning_message)
       @mod.check
     end
   end
 
   describe "bad js with errors" do
     before do
-      files = ['bad.js']
+      files = ["bad.js"]
       @mod = Checker::Modules::Javascript.new(files)
-      @mod.should_receive(:check_one_file).with('bad.js').and_return(stub(:success? => false, :status => :fail))
+      expect(@mod).to receive(:check_one_file).with("bad.js").and_return(double(success?: false, status: :fail))
     end
 
     xit "results to be true" do
@@ -62,7 +62,7 @@ describe Checker::Modules::Javascript do
     end
 
     xit "prints proper message" do
-      @mod.should_receive(:print_fail_message)
+      expect(@mod).to receive(:print_fail_message)
       @mod.check
     end
   end