checker 0.7.0 → 0.8.0.beta

data/lib/checker/installator.rb

@@ -1,7 +1,7 @@
 module Checker
   class Installator
     def self.template
-      dir = File.expand_path('../../..', __FILE__)
+      dir = File.expand_path("../../..", __FILE__)
       temp = File.read(File.join(dir, "/templates/checker-prepare-commit-msg"))
       ERB.new(temp).result
     end
@@ -21,7 +21,7 @@ module Checker
       check_hook!
 
       pre_commit = "#{hooks_dir}/prepare-commit-msg"
-      if File.exists?(pre_commit)
+      if File.exist?(pre_commit)
         puts "Removing current git precommit hook..."
         File.delete(pre_commit)
       end
@@ -36,9 +36,9 @@ module Checker
       if File.exist?(pre_commit)
         puts "Appending checker script to existing prepare-commit-msg hook..."
         begin
-          open(pre_commit, 'a') do |f| 
-            f.puts(self.template)
-            f.chmod(0755)
+          open(pre_commit, "a") do |f|
+            f.puts(template)
+            f.chmod(0o755)
           end
         rescue Exception => e
           puts "Couldn't append checker script: #{e.message}"
@@ -46,12 +46,12 @@ module Checker
         end
         exit 0
       else
-        tmp = self.template
+        tmp = template
         str = "#!/bin/bash \n #{tmp}"
         begin
-          open(pre_commit, "w") do |f| 
+          open(pre_commit, "w") do |f|
             f.puts(str)
-            f.chmod(0755)
+            f.chmod(0o755)
           end
         rescue Exception => e
           puts "Couldn't write checker script: #{e.message}"

data/lib/checker/modules/base.rb

@@ -5,13 +5,13 @@ module Checker
 
       def initialize(file_list = nil)
         self.files = file_list
-        self.full_results = {:total => 0, :ok => 0, :warning => 0, :fail => 0}
+        self.full_results = { total: 0, ok: 0, warning: 0, fail: 0 }
       end
 
       def check
-        check_files_existing or return true
+        check_files_existing || (return true)
         print_module_header
-        check_executable or return true
+        check_executable || (return true)
         check_all_files
         valid?
       end
@@ -23,17 +23,17 @@ module Checker
       def files_to_check
         @files_to_check ||= begin
           if self.class.extensions.any?
-            self.files.select { |f|
+            files.select do |f|
               self.class.extensions.map { |ex| f.ends_with?(".#{ex}") }.any?
-            }
+            end
           else
-            self.files
+            files
           end
         end
       end
 
       def classname
-        self.class.to_s.split('::').last
+        self.class.to_s.split("::").last
       end
 
       private
@@ -63,33 +63,33 @@ module Checker
         true
       end
 
+      def after_check; end
+
       def check_all_files
-        with_checker_cache do
-          @results = files_to_check.map do |file_name|
-            gather_result :total
-            color "  Checking #{file_name}...", :yellow
-            result = check_one_file(file_name)
-            show_status result.status
-            gather_result result.status
-            flush_and_forget_output result.status
-            result.success?
-          end
+        @results = files_to_check.map do |file_name|
+          gather_result :total
+          color "  Checking #{file_name}...", :yellow
+          result = check_one_file(file_name)
+          show_status result.status
+          gather_result result.status
+          flush_and_forget_output result.status
+          after_check
+          result.success?
         end
       end
 
-      def check_one(filename, options = {})
+      def check_one(_filename, _options = {})
         puts "Called from #{self.class} - extend me in here!"
         false
       end
 
-      def check_one_file file_name
+      def check_one_file(file_name)
         checksum = ::Digest::MD5.hexdigest(file_name)
         debug(file_name)
-        checkout_file(file_name, checksum)
-        check_one(checkout_file_name(checksum), :extension => File.extname(file_name))
+        check_one(file_name, extension: File.extname(file_name))
       end
 
-      def self.extensions *args
+      def self.extensions(*args)
         @extensions ||= []
         if args.empty?
           @extensions
@@ -98,8 +98,8 @@ module Checker
         end
       end
 
-      def gather_result result
-        self.full_results[result] += 1
+      def gather_result(result)
+        full_results[result] += 1
       end
 
       def plain_command(cmd, options = {})
@@ -108,13 +108,13 @@ module Checker
       end
 
       def silent_command(cmd, options = {})
-        options = { :output => false, :return_boolean => true }.merge(options)
+        options = { output: false, return_boolean: true }.merge(options)
         cmd = parse_command(cmd, options)
         execute(cmd, options)
       end
 
       def flush_and_forget_output(status)
-        print @buffer.to_s if (status == :warning or status == :fail)
+        print @buffer.to_s if (status == :warning) || (status == :fail)
         @buffer = ""
       end
 
@@ -150,15 +150,15 @@ module Checker
       end
 
       def exitstatus
-        $? && $?.exitstatus
+        $CHILD_STATUS && $CHILD_STATUS.exitstatus
       end
 
       def success?
-        $? && $?.success?
+        $CHILD_STATUS && $CHILD_STATUS.success?
       end
 
-      def parse_command command, options
-        options = { :bundler => true, :output => true, :rvm => true }.merge(options)
+      def parse_command(command, options)
+        options = { bundler: true, output: true, rvm: true }.merge(options)
         command = bundler_command(command) if use_bundler? && options[:bundler]
         command = rvm_command(command) if use_rvm? && options[:rvm]
         command << " > /dev/null" unless options[:output]
@@ -166,7 +166,7 @@ module Checker
       end
 
       def color(str, color)
-        print str.colorize(color) if str.length > 0
+        print str.colorize(color) unless str.empty?
       end
 
       def name
@@ -174,7 +174,7 @@ module Checker
       end
 
       def use_bundler?
-        File.exists?("Gemfile.lock")
+        File.exist?("Gemfile.lock")
       end
 
       def bundler_command(command)
@@ -182,7 +182,7 @@ module Checker
       end
 
       def use_rvm?
-        File.exists?(rvm_shell)
+        false
       end
 
       def rails_project?
@@ -190,7 +190,7 @@ module Checker
       end
 
       def rails_with_ap?
-        rails_project? && File.exists?("app/assets")
+        rails_project? && File.exist?("app/assets")
       end
 
       def rvm_command(command)
@@ -202,21 +202,19 @@ module Checker
       end
 
       def with_checker_cache
-        begin
-          `mkdir .checker-cache`
-          yield if block_given?
-        ensure
-          `rm -rf .checker-cache > /dev/null 2>&1`
-          ## for sass check
-          `rm -rf app/assets/stylesheets/checker-cache*` if rails_with_ap?
-        end
+        `mkdir .checker-cache`
+        yield if block_given?
+      ensure
+        `rm -rf .checker-cache > /dev/null 2>&1`
+        ## for sass check
+        `rm -rf app/assets/stylesheets/checker-cache*` if rails_with_ap?
       end
 
-      def checkout_file file_name, target
+      def checkout_file(file_name, target)
         `git show :0:#{file_name} > #{checkout_file_name(target)} 2>/dev/null`
       end
 
-      def checkout_file_name target
+      def checkout_file_name(target)
         ".checker-cache/#{target}"
       end
     end

data/lib/checker/modules/coffeescript.rb

@@ -1,14 +1,16 @@
 module Checker
   module Modules
     class Coffeescript < Base
-      extensions 'coffee'
+      extensions "coffee"
+
       private
-      def check_one(file, opts = {})
+
+      def check_one(file, _opts = {})
         Checker::Result.result(self, plain_command("cat #{file} | egrep -v '^//=' | coffee -sc > /dev/null"))
       end
 
       def check_for_executable
-        silent_command('coffee -v', :bundler => false)
+        silent_command("coffee -v", bundler: false)
       end
 
       def dependency_message

data/lib/checker/modules/conflict.rb

@@ -1,19 +1,19 @@
 module Checker
   module Modules
     class Conflict < Base
-
       private
-      def check_one(file, opts = {})
+
+      def check_one(file, _opts = {})
         status = [check_for_conflict_start(file), check_for_conflict_end(file)].all_true?
         Checker::Result.result(self, status ? 0 : 1)
       end
 
       def check_for_conflict_start(file)
-        !plain_command("grep -n \"<<<<<<< \" #{file}", :bundler => false, :return_boolean => true, :rvm => false)
+        !plain_command("grep -n \"<<<<<<< \" #{file}", bundler: false, return_boolean: true, rvm: false)
       end
 
       def check_for_conflict_end(file)
-        !plain_command("grep -n \">>>>>>> \" #{file}", :bundler => false, :return_boolean => true, :rvm => false)
+        !plain_command("grep -n \">>>>>>> \" #{file}", bundler: false, return_boolean: true, rvm: false)
       end
     end
   end

data/lib/checker/modules/console_log.rb

@@ -1,11 +1,12 @@
 module Checker
   module Modules
     class ConsoleLog < Base
-      extensions 'coffee', 'js'
+      extensions "coffee", "js"
 
       private
-      def check_one(file, opts = {})
-        Checker::Result.result(self, plain_command("grep -n \"console\\.log\" #{file}", :bundler => false, :rvm => false))
+
+      def check_one(file, _opts = {})
+        Checker::Result.result(self, plain_command("grep -n \"console\\.log\" #{file}", bundler: false, rvm: false))
       end
 
       def show_status(status)

data/lib/checker/modules/haml.rb

@@ -1,9 +1,11 @@
 module Checker
   module Modules
     class Haml < Base
-      extensions 'haml'
+      extensions "haml"
+
       private
-      def check_one(file, opts = {})
+
+      def check_one(file, _opts = {})
         Checker::Result.result(self, plain_command("haml --check #{file} >> /dev/null"))
       end
 

data/lib/checker/modules/javascript.rb

@@ -1,14 +1,16 @@
 module Checker
   module Modules
     class Javascript < Base
-      extensions 'js'
+      extensions "js"
+
       private
-      def check_one(file, opts = {})
+
+      def check_one(file, _opts = {})
         Checker::Result.result(self, plain_command("jsl -process #{file}"))
       end
 
       def check_for_executable
-        silent_command('jsl -help:conf', :bundler => false)
+        silent_command("jsl -help:conf", bundler: false)
       end
 
       def dependency_message

data/lib/checker/modules/multifile.rb

@@ -0,0 +1,16 @@
+module Checker
+  module Modules
+    class Multifile < Base
+      def check_all_files
+        gather_result :total
+        color "  Checking #{files_to_check.join(', ')}...", :yellow
+        result = check_all(files_to_check)
+        show_status result.status
+        gather_result result.status
+        flush_and_forget_output result.status
+        @results = [result.success?]
+        after_check
+      end
+    end
+  end
+end

data/lib/checker/modules/pry.rb

@@ -1,19 +1,19 @@
 module Checker
   module Modules
     class Pry < Base
-
       private
-      def check_one(file, opts = {})
+
+      def check_one(file, _opts = {})
         status = [check_for_binding_pry(file), check_for_binding_remote_pry(file)].all_true?
         Checker::Result.result(self, status ? 0 : 1)
       end
 
       def check_for_binding_pry(file)
-        !plain_command("grep -n \"binding\\.pry\" #{file}", :bundler => false, :return_boolean => true, :rvm => false)
+        !plain_command("grep -n \"binding\\.pry\" #{file}", bundler: false, return_boolean: true, rvm: false)
       end
 
       def check_for_binding_remote_pry(file)
-        !plain_command("grep -n \"binding\\.remote_pry\" #{file}", :bundler => false, :return_boolean => true, :rvm => false)
+        !plain_command("grep -n \"binding\\.remote_pry\" #{file}", bundler: false, return_boolean: true, rvm: false)
       end
     end
   end

data/lib/checker/modules/rubocop.rb

@@ -1,10 +1,10 @@
 module Checker
   module Modules
-    class Rubocop < Base
-      extensions 'rb'
+    class Rubocop < Multifile
       private
-      def check_one(file, opts = {})
-        Checker::Result.result(self, plain_command("rubocop #{file}", :bundler => false))
+
+      def check_all(files, _opts = {})
+        Checker::Result.result(self, plain_command("rubocop -f c #{files.join(' ')}", bundler: false))
       end
 
       def dependency_message
@@ -12,6 +12,14 @@ module Checker
         str << "Install rubocop using rubygems: 'gem install rubocop'"
         str
       end
+
+      def fix_message(files)
+        "\nTo Autocorrect, execute: rubocop -a #{files.join(' ')}\n"
+      end
+
+      def after_check
+        puts fix_message(files_to_check).colorize(:green) if @results.first == false
+      end
     end
   end
 end

data/lib/checker/modules/ruby.rb

@@ -1,10 +1,13 @@
 module Checker
   module Modules
     class Ruby < Base
-      extensions 'rb'
+      extensions "rb"
+
       private
-      def check_one(file, opts = {})
-        Checker::Result.result(self, plain_command("ruby -c #{file}", :bundler => false))
+
+      def check_one(file, _opts = {})
+        puts " using version: #{`ruby -v`.chomp}"
+        Checker::Result.result(self, plain_command("ruby -c #{file}", bundler: false))
       end
     end
   end

data/lib/checker/modules/sass.rb

@@ -1,23 +1,25 @@
 module Checker
   module Modules
     class Sass < Base
-      extensions 'scss', 'sass'
+      extensions "scss", "sass"
+
       private
+
       def check_one(file, opts = {})
-        if preconditions_for_rails?(file) && Checker::Options.use_rails_for_sass
+        if Checker::Options.use_rails_for_sass && preconditions_for_rails?(file)
           rails_check(file, opts)
         else
           normal_check(file, opts)
         end
       end
 
-      def rails_check(file, opts)
+      def rails_check(file, _opts)
         debug("Rails project detected") if rails_project?
         Checker::Result.result(self, plain_command(%(rails runner "Rails.application.assets.find_asset(\\"#{Dir.pwd}/#{file}\\").to_s")))
       end
 
       def normal_check(file, opts)
-        Checker::Result.result(self, plain_command("sass #{"--scss" if opts[:extension] == ".scss"} -c #{file}"))
+        Checker::Result.result(self, plain_command("sass #{'--scss' if opts[:extension] == '.scss'} -c #{file}"))
       end
 
       def check_for_executable
@@ -36,41 +38,41 @@ module Checker
       end
 
       ## for rails project
-      def checkout_file file_name, target
+      def checkout_file(file_name, target)
         debug("git show :0:#{file_name} > #{checkout_file_name(target)} 2>/dev/null")
         mkdir_if_necessary(checkout_file_name(target))
         `git show :0:#{file_name} > #{checkout_file_name(target)} 2>/dev/null`
       end
 
       def mkdir_if_necessary(target)
-        dir = target.gsub(File.basename(target), '')
+        dir = target.gsub(File.basename(target), "")
         create_dir(dir)
       end
 
       def create_dir(dir)
         debug("Creating dir #{dir}")
-        Dir.mkdir(dir) unless File.exists?(dir)
+        Dir.mkdir(dir) unless File.exist?(dir)
       end
 
       def stylesheets_dir
         "app/assets/stylesheets/"
       end
 
-      def checkout_file_name target
-        (Checker::Options.use_rails_for_sass && rails_with_ap?) ? "#{stylesheets_dir}checker-cache#{target}" : super
+      def checkout_file_name(target)
+        Checker::Options.use_rails_for_sass && rails_with_ap? ? "#{stylesheets_dir}checker-cache#{target}" : super
       end
 
-      def proper_path file_name
-        file_name.gsub(/app\/assets\/stylesheets\//, '')
+      def proper_path(file_name)
+        file_name.gsub(/app\/assets\/stylesheets\//, "")
       end
 
-      def check_one_file file_name
-        if (Checker::Options.use_rails_for_sass && rails_with_ap?)
+      def check_one_file(file_name)
+        if Checker::Options.use_rails_for_sass && rails_with_ap?
           color " (using rails runner)... ", :blue
           debug(file_name)
           debug(proper_path(file_name))
           checkout_file(file_name, proper_path(file_name))
-          check_one(checkout_file_name(proper_path(file_name)), :extension => File.extname(file_name))
+          check_one(checkout_file_name(proper_path(file_name)), extension: File.extname(file_name))
         else
           super
         end