checkability 1.0.1 → 2.1.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/README.md +2 -1
- data/lib/checkability/acts_as_checkable.rb +4 -3
- data/lib/checkability/base_checker.rb +7 -7
- data/lib/checkability/checkable.rb +15 -14
- data/lib/checkability/external_api_checker.rb +1 -1
- data/lib/checkability/storage_checker.rb +1 -1
- data/lib/checkability/version.rb +1 -1
- metadata +2 -2
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA256:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: 597efc0d486d6dc0f0487b242871e712cafb59f1ca3e76f9f5538cde17c5de54
|
4
|
+
data.tar.gz: d58963305fa999ab2bd1663303ee8fbbb5844bcda276977eecc009484e79e8ce
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: c4a2b9dacaa1b6e4f9e9f2441a2fc7d3b8f6b191b8a4f97f18e54b511fbc6440da27d191258e17618bdfae8ffff65be3109c6d36467f3049e3b4d2d0786038aa
|
7
|
+
data.tar.gz: 7a54d3c0f0b8d506def36cdb6143b35af1be503bc9e5f523f9266efe051685cc63db15c862549e51deef7b9e0f93fb5b25c89383aeff7bb3740414c7d8d139ed
|
data/README.md
CHANGED
@@ -76,4 +76,5 @@ The gem is available as open source under the terms of the [MIT License](https:/
|
|
76
76
|
|
77
77
|
## Future works
|
78
78
|
|
79
|
-
- [
|
79
|
+
- [X] Use ChainOfResponsibility pattern to simplify call of checkers
|
80
|
+
- [ ] Improve test with adding doubles
|
@@ -23,7 +23,7 @@ module Checkability
|
|
23
23
|
end
|
24
24
|
end
|
25
25
|
|
26
|
-
attr_accessor :ch_allowed, :ch_messages
|
26
|
+
attr_accessor :ch_allowed, :ch_messages, :ch_conf
|
27
27
|
|
28
28
|
def initialize(params)
|
29
29
|
@ch_messages = []
|
@@ -32,8 +32,9 @@ module Checkability
|
|
32
32
|
end
|
33
33
|
|
34
34
|
def perform_check
|
35
|
-
|
36
|
-
|
35
|
+
@ch_conf = ch_conf
|
36
|
+
Checkability::Checkable.new(self).check
|
37
|
+
ch_messages << "#{ch_allowed}:::'#{_value}' is #{_allowness}. "
|
37
38
|
end
|
38
39
|
|
39
40
|
private
|
@@ -10,10 +10,10 @@ module Checkability
|
|
10
10
|
:success_message, :failure_message
|
11
11
|
|
12
12
|
def initialize(opts = {})
|
13
|
-
@stop_process_on_failure = opts
|
14
|
-
@stop_process_on_success = opts
|
15
|
-
@success_message = opts
|
16
|
-
@failure_message = opts
|
13
|
+
@stop_process_on_failure = opts.fetch(:stop_process_on_failure) || false
|
14
|
+
@stop_process_on_success = opts.fetch(:stop_process_on_success) || false
|
15
|
+
@success_message = opts.fetc(:success_message) || 'Success.'
|
16
|
+
@failure_message = opts.fetc(:failure_message) || 'Failed.'
|
17
17
|
|
18
18
|
@next_handler = nil
|
19
19
|
post_initialize(opts) # implemented in subclass
|
@@ -53,8 +53,8 @@ module Checkability
|
|
53
53
|
|
54
54
|
str = res ? success_message : failure_message
|
55
55
|
[res, message(res, str)]
|
56
|
-
|
57
|
-
|
56
|
+
rescue StandardError => e
|
57
|
+
[false, message(false, e)]
|
58
58
|
end
|
59
59
|
|
60
60
|
# subclass should implement
|
@@ -64,7 +64,7 @@ module Checkability
|
|
64
64
|
|
65
65
|
# subclass may override
|
66
66
|
def message(res, str)
|
67
|
-
"#{res}
|
67
|
+
"#{res}:::#{str}"
|
68
68
|
end
|
69
69
|
|
70
70
|
private
|
@@ -7,10 +7,10 @@ module Checkability
|
|
7
7
|
# Possible to implemet as Iterator in future
|
8
8
|
#
|
9
9
|
class Checkable
|
10
|
-
attr_accessor :check_obj
|
10
|
+
attr_accessor :check_obj, :handler_confs
|
11
11
|
|
12
12
|
extend Forwardable
|
13
|
-
def_delegators :@check_obj, :ch_messages, :ch_allowed
|
13
|
+
def_delegators :@check_obj, :ch_messages, :ch_allowed, :ch_conf
|
14
14
|
|
15
15
|
def initialize(check_obj)
|
16
16
|
@check_obj = check_obj
|
@@ -26,29 +26,30 @@ module Checkability
|
|
26
26
|
#
|
27
27
|
# ChainOfResponsibilty
|
28
28
|
#
|
29
|
-
def check
|
30
|
-
|
31
|
-
first_handler = _handlers(handler_confs)[first_handler_name]
|
32
|
-
|
33
|
-
first_handler.handle(check_obj)
|
29
|
+
def check
|
30
|
+
_first_handler.handle(check_obj)
|
34
31
|
rescue StandardError => e
|
35
|
-
check_obj.ch_messages << "false
|
32
|
+
check_obj.ch_messages << "false:::#{e}: #{handler_confs}."
|
36
33
|
false
|
37
34
|
end
|
38
35
|
|
39
36
|
private
|
40
37
|
|
41
|
-
def
|
42
|
-
|
38
|
+
def _first_handler
|
39
|
+
_handlers[ch_conf.keys.first]
|
40
|
+
end
|
41
|
+
|
42
|
+
def _handlers
|
43
|
+
handlers = _make_handlers
|
43
44
|
handlers.each_value.with_index do |handler, i|
|
44
|
-
|
45
|
-
handler.next_handler(
|
45
|
+
next_handler = handlers[handlers.keys[i + 1]]
|
46
|
+
handler.next_handler(next_handler) if next_handler
|
46
47
|
end
|
47
48
|
handlers
|
48
49
|
end
|
49
50
|
|
50
|
-
def _make_handlers
|
51
|
-
|
51
|
+
def _make_handlers
|
52
|
+
ch_conf.transform_values { |conf| _make_handler(conf) }
|
52
53
|
end
|
53
54
|
|
54
55
|
def _make_handler(conf)
|
data/lib/checkability/version.rb
CHANGED
metadata
CHANGED
@@ -1,14 +1,14 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: checkability
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version: 1.
|
4
|
+
version: 2.1.1
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
7
|
- Andrey Eremeev
|
8
8
|
autorequire:
|
9
9
|
bindir: bin
|
10
10
|
cert_chain: []
|
11
|
-
date: 2021-04-
|
11
|
+
date: 2021-04-13 00:00:00.000000000 Z
|
12
12
|
dependencies: []
|
13
13
|
description: Provide Checkers functionality.
|
14
14
|
email:
|