checkability 1.0.1 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 49569c239e2acdb43486cf8269a923d3118424798700e49be0edfaf7f7551b25
-  data.tar.gz: 7a81f73bc65865564495bd5d8b9680d76249fa69b3d730543162ebd5b1f61048
+  metadata.gz: 597efc0d486d6dc0f0487b242871e712cafb59f1ca3e76f9f5538cde17c5de54
+  data.tar.gz: d58963305fa999ab2bd1663303ee8fbbb5844bcda276977eecc009484e79e8ce
 SHA512:
-  metadata.gz: d28be27a0487566262cf3d284213b076f1c7dbc9bfc2f59844444fa16761842c9348dd9df609420488bc8d597a3b50741a7bb712de86ab2056afb565399dc07b
-  data.tar.gz: ad42af8d0f399d130c2282d4c2938230f87c9f01e70fd43df3f031303aeca8767335a5e0fabe281b58edb1d081c5500a10a83d94e7befda7f461f4770bbf9c0c
+  metadata.gz: c4a2b9dacaa1b6e4f9e9f2441a2fc7d3b8f6b191b8a4f97f18e54b511fbc6440da27d191258e17618bdfae8ffff65be3109c6d36467f3049e3b4d2d0786038aa
+  data.tar.gz: 7a54d3c0f0b8d506def36cdb6143b35af1be503bc9e5f523f9266efe051685cc63db15c862549e51deef7b9e0f93fb5b25c89383aeff7bb3740414c7d8d139ed

data/README.md

@@ -76,4 +76,5 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Future works
 
-- [ ] Use ChainOfResponsibility pattern to simplify call of checkers
+- [X] Use ChainOfResponsibility pattern to simplify call of checkers
+- [ ] Improve test with adding doubles

data/lib/checkability/acts_as_checkable.rb

@@ -23,7 +23,7 @@ module Checkability
       end
     end
 
-    attr_accessor :ch_allowed, :ch_messages
+    attr_accessor :ch_allowed, :ch_messages, :ch_conf
 
     def initialize(params)
       @ch_messages = []
@@ -32,8 +32,9 @@ module Checkability
     end
 
     def perform_check
-      Checkability::Checkable.new(self).check(ch_conf)
-      ch_messages << "#{ch_allowed}::'#{_value}' is #{_allowness}. "
+      @ch_conf = ch_conf
+      Checkability::Checkable.new(self).check
+      ch_messages << "#{ch_allowed}:::'#{_value}' is #{_allowness}. "
     end
 
     private

data/lib/checkability/base_checker.rb

@@ -10,10 +10,10 @@ module Checkability
                 :success_message, :failure_message
 
     def initialize(opts = {})
-      @stop_process_on_failure = opts[:stop_process_on_failure] || false
-      @stop_process_on_success = opts[:stop_process_on_success] || false
-      @success_message = opts[:success_message] || 'Success.'
-      @failure_message = opts[:failure_message] || 'Failed.'
+      @stop_process_on_failure = opts.fetch(:stop_process_on_failure) || false
+      @stop_process_on_success = opts.fetch(:stop_process_on_success) || false
+      @success_message = opts.fetc(:success_message) || 'Success.'
+      @failure_message = opts.fetc(:failure_message) || 'Failed.'
 
       @next_handler = nil
       post_initialize(opts) # implemented in subclass
@@ -53,8 +53,8 @@ module Checkability
 
       str = res ? success_message : failure_message
       [res, message(res, str)]
-      #    rescue StandardError => e
-      #      [false, message(false, e)]
+    rescue StandardError => e
+      [false, message(false, e)]
     end
 
     # subclass should implement
@@ -64,7 +64,7 @@ module Checkability
 
     # subclass may override
     def message(res, str)
-      "#{res}::#{str}"
+      "#{res}:::#{str}"
     end
 
     private

data/lib/checkability/checkable.rb

@@ -7,10 +7,10 @@ module Checkability
   # Possible to implemet as Iterator in future
   #
   class Checkable
-    attr_accessor :check_obj
+    attr_accessor :check_obj, :handler_confs
 
     extend Forwardable
-    def_delegators :@check_obj, :ch_messages, :ch_allowed
+    def_delegators :@check_obj, :ch_messages, :ch_allowed, :ch_conf
 
     def initialize(check_obj)
       @check_obj = check_obj
@@ -26,29 +26,30 @@ module Checkability
     #
     # ChainOfResponsibilty
     #
-    def check(handler_confs)
-      first_handler_name = handler_confs.keys.first
-      first_handler = _handlers(handler_confs)[first_handler_name]
-
-      first_handler.handle(check_obj)
+    def check
+      _first_handler.handle(check_obj)
     rescue StandardError => e
-      check_obj.ch_messages << "false::#{e}: #{handler_confs}."
+      check_obj.ch_messages << "false:::#{e}: #{handler_confs}."
       false
     end
 
     private
 
-    def _handlers(handler_confs)
-      handlers = _make_handlers(handler_confs)
+    def _first_handler
+      _handlers[ch_conf.keys.first]
+    end
+
+    def _handlers
+      handlers = _make_handlers
       handlers.each_value.with_index do |handler, i|
-        next_handler_name = handlers.keys[i + 1]
-        handler.next_handler(handlers[next_handler_name]) if handlers[next_handler_name]
+        next_handler = handlers[handlers.keys[i + 1]]
+        handler.next_handler(next_handler) if next_handler
       end
       handlers
     end
 
-    def _make_handlers(confs)
-      confs.transform_values { |conf| _make_handler(conf) }
+    def _make_handlers
+      ch_conf.transform_values { |conf| _make_handler(conf) }
     end
 
     def _make_handler(conf)

data/lib/checkability/external_api_checker.rb

@@ -35,7 +35,7 @@ module Checkability
     end
 
     def message(res, str = nil)
-      "#{res}::#{path}: #{str}"
+      "#{res}:::#{path}: #{str}"
     end
 
     private

data/lib/checkability/storage_checker.rb

@@ -18,7 +18,7 @@ module Checkability
     end
 
     def message(res, str = nil)
-      "#{res}::Allowed #{storage_class}s list: #{str}"
+      "#{res}:::Allowed #{storage_class}s list: #{str}"
     end
 
     private

data/lib/checkability/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Checkability
-  VERSION = '1.0.1'
+  VERSION = '2.1.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkability
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 2.1.1
 platform: ruby
 authors:
 - Andrey Eremeev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-06 00:00:00.000000000 Z
+date: 2021-04-13 00:00:00.000000000 Z
 dependencies: []
 description: Provide Checkers functionality.
 email: