cartage 2.0 → 2.2.1

data/test/test_cartage_config.rb

@@ -1,17 +1,17 @@
 # frozen_string_literal: true
 
-require 'minitest_config'
-require 'cartage/config'
+require "minitest_config"
+require "cartage/config"
 
 describe Cartage::Config do
   let(:data) {
     {
-      'x' => 1,
-      'arr' => %w(a b c),
-      'commands' => {},
-      'plugins' => {
-        'test' => {
-          'x' => 2
+      "x" => 1,
+      "arr" => %w[a b c],
+      "commands" => {},
+      "plugins" => {
+        "test" => {
+          "x" => 2
         }
       }
     }
@@ -20,7 +20,7 @@ describe Cartage::Config do
   let(:config) { Cartage::Config.new(odata) }
   let(:hdata) { Marshal.load(Marshal.dump(data)) }
 
-  describe 'load' do
+  describe "load" do
     def watch_pathname_exist
       mpname = Pathname.singleton_class
       mpname.send(:define_method, :exist_tries, -> { @exist_tries ||= [] })
@@ -47,7 +47,7 @@ describe Cartage::Config do
       Pathname.send(:undef_method, :__stub_expand_path__)
     end
 
-    it 'looks for default files when given :default' do
+    it "looks for default files when given :default" do
       watch_pathname_exist do
         ignore_pathname_expand_path do
           Cartage::Config.load(:default)
@@ -56,17 +56,17 @@ describe Cartage::Config do
       end
     end
 
-    it 'fails if the file does not exist' do
+    it "fails if the file does not exist" do
       instance_stub Pathname, :exist?, -> { false } do
         assert_raises_with_message ArgumentError,
-          'Configuration file foo does not exist.' do
-          Cartage::Config.load('foo')
+          "Configuration file foo does not exist." do
+          Cartage::Config.load("foo")
         end
       end
     end
 
-    it 'loads the file if it exists' do
-      instance_stub Pathname, :read, -> { '{ faked: true }' } do
+    it "loads the file if it exists" do
+      instance_stub Pathname, :read, -> { "{ faked: true }" } do
         instance_stub Pathname, :exist?, -> { true } do
           expected = {
             faked: true,
@@ -74,12 +74,12 @@ describe Cartage::Config do
             plugins: OpenStruct.new
           }
           assert_equal expected,
-            Cartage::Config.load('foo').instance_variable_get(:@table)
+            Cartage::Config.load("foo").instance_variable_get(:@table)
         end
       end
     end
 
-    it 'uses a default configuration if there is no default config file' do
+    it "uses a default configuration if there is no default config file" do
       expected = {
         commands: OpenStruct.new,
         plugins: OpenStruct.new
@@ -89,30 +89,30 @@ describe Cartage::Config do
     end
   end
 
-  describe 'import' do
-    it 'reads a file if it exists' do
+  describe "import" do
+    it "reads a file if it exists" do
       stub File, :exist?, ->(_) { true } do
-        stub File, :read, ->(_) { 'faked' } do
-          assert_equal 'faked', Cartage::Config.import('foo')
+        stub File, :read, ->(_) { "faked" } do
+          assert_equal "faked", Cartage::Config.import("foo")
         end
       end
     end
 
-    it 'returns nil if the file does not exist' do
+    it "returns nil if the file does not exist" do
       stub File, :exist?, ->(_) { false } do
-        assert_nil Cartage::Config.import('foo')
+        assert_nil Cartage::Config.import("foo")
       end
     end
   end
 
-  describe '#to_h' do
-    it 'completely converts a Config object to hash' do
+  describe "#to_h" do
+    it "completely converts a Config object to hash" do
       assert_equal hdata, config.to_h
     end
   end
 
-  describe '#to_yaml' do
-    it 'overrides the OpenStruct implementation' do
+  describe "#to_yaml" do
+    it "overrides the OpenStruct implementation" do
       assert_equal hdata.to_yaml, config.to_yaml
     end
   end

data/test/test_cartage_core.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'minitest_config'
+require "minitest_config"
 
 describe Cartage::Core do
   let(:subject) {
@@ -18,20 +18,20 @@ describe Cartage::Core do
   }
   let(:object) { subject.new }
 
-  describe 'attr_reader_with_default' do
-    it 'fails without a default' do
-      assert_raises_with_message ArgumentError, 'No default provided.' do
+  describe "attr_reader_with_default" do
+    it "fails without a default" do
+      assert_raises_with_message ArgumentError, "No default provided." do
         subject.attr_reader_with_default :answer
       end
     end
 
-    it 'fails with too many defaults' do
-      assert_raises_with_message ArgumentError, 'Too many defaults provided.' do
+    it "fails with too many defaults" do
+      assert_raises_with_message ArgumentError, "Too many defaults provided." do
         subject.attr_reader_with_default :answer, 42, &-> { 42 }
       end
     end
 
-    it 'defines default and reader methods when given a value' do
+    it "defines default and reader methods when given a value" do
       subject.attr_reader_with_default :answer, 42
       assert_respond_to object, :answer
       assert_equal 42, object.answer
@@ -40,7 +40,7 @@ describe Cartage::Core do
       assert_equal 42, object.default_answer
     end
 
-    it 'defines default and reader methods when given a block' do
+    it "defines default and reader methods when given a block" do
       subject.attr_reader_with_default :answer do
         42
       end
@@ -52,63 +52,63 @@ describe Cartage::Core do
       assert_equal 42, object.default_answer
     end
 
-    it 'memoizes the default value' do
-      subject.attr_reader_with_default :favourite_colour, 'blue'
+    it "memoizes the default value" do
+      subject.attr_reader_with_default :favourite_colour, "blue"
       assert_same object.default_favourite_colour, object.default_favourite_colour
     end
   end
 
-  describe 'attr_writer_with_transform' do
-    it 'fails without a transform' do
-      assert_raises_with_message ArgumentError, 'No transform provided.' do
+  describe "attr_writer_with_transform" do
+    it "fails without a transform" do
+      assert_raises_with_message ArgumentError, "No transform provided." do
         subject.attr_writer_with_transform :answer
       end
     end
 
-    it 'fails with too many transforms' do
-      assert_raises_with_message ArgumentError, 'Too many transforms provided.' do
+    it "fails with too many transforms" do
+      assert_raises_with_message ArgumentError, "Too many transforms provided." do
         subject.attr_writer_with_transform :answer, 42, &-> { 42 }
       end
     end
 
-    it 'fails if the transform is not callable' do
-      assert_raises_with_message ArgumentError, 'Transform is not callable.' do
+    it "fails if the transform is not callable" do
+      assert_raises_with_message ArgumentError, "Transform is not callable." do
         subject.attr_writer_with_transform :answer, 42
       end
     end
 
-    it 'defines a writer method when given a symbol' do
+    it "defines a writer method when given a symbol" do
       subject.attr_writer_with_transform :answer, :to_s
       assert_respond_to object, :answer=
       object.answer = 42
-      assert_equal '42', object.instance_variable_get(:"@answer")
+      assert_equal "42", object.instance_variable_get(:@answer)
     end
 
-    it 'defines a writer method when given a callable' do
+    it "defines a writer method when given a callable" do
       subject.attr_writer_with_transform :answer, ->(v) { v.to_s }
       assert_respond_to object, :answer=
       object.answer = 42
-      assert_equal '42', object.instance_variable_get(:"@answer")
+      assert_equal "42", object.instance_variable_get(:@answer)
     end
 
-    it 'defines a writer method when given a block' do
+    it "defines a writer method when given a block" do
       subject.attr_writer_with_transform :answer do |v|
         String(v)
       end
       assert_respond_to object, :answer=
       object.answer = 42
-      assert_equal '42', object.instance_variable_get(:"@answer")
+      assert_equal "42", object.instance_variable_get(:@answer)
     end
   end
 
-  describe 'attr_accessor_with_default' do
-    it 'fails without a default' do
-      assert_raises_with_message ArgumentError, 'No default provided.' do
+  describe "attr_accessor_with_default" do
+    it "fails without a default" do
+      assert_raises_with_message ArgumentError, "No default provided." do
         subject.attr_accessor_with_default :answer
       end
     end
 
-    it 'defines a default, reader, and writer methods when given a value' do
+    it "defines a default, reader, and writer methods when given a value" do
       subject.attr_accessor_with_default :answer, default: 42
 
       assert_respond_to object, :answer
@@ -120,7 +120,7 @@ describe Cartage::Core do
       assert_equal 42, object.default_answer
     end
 
-    it 'defines a default, reader, and writer methods when given a block' do
+    it "defines a default, reader, and writer methods when given a block" do
       subject.attr_accessor_with_default :answer do
         42
       end
@@ -134,18 +134,18 @@ describe Cartage::Core do
       assert_equal 42, object.default_answer
     end
 
-    it 'memoizes the default value' do
-      subject.attr_accessor_with_default :favourite_colour, default: 'blue'
+    it "memoizes the default value" do
+      subject.attr_accessor_with_default :favourite_colour, default: "blue"
       assert_same object.favourite_colour, object.favourite_colour
     end
 
-    it 'fails if transform is not callable' do
-      assert_raises_with_message ArgumentError, 'Transform is not callable.' do
+    it "fails if transform is not callable" do
+      assert_raises_with_message ArgumentError, "Transform is not callable." do
         subject.attr_accessor_with_default :answer, default: 42, transform: 42
       end
     end
 
-    it 'accepts a symbol for transform' do
+    it "accepts a symbol for transform" do
       subject.attr_accessor_with_default :answer, default: 42, transform: :to_s
 
       assert_respond_to object, :answer
@@ -154,10 +154,10 @@ describe Cartage::Core do
 
       assert_equal 42, object.answer
       object.answer = 21
-      assert_equal '21', object.answer
+      assert_equal "21", object.answer
     end
 
-    it 'accepts a callable for transform' do
+    it "accepts a callable for transform" do
       subject.attr_accessor_with_default :answer,
         default: 42, transform: ->(v) { v.to_s }
       assert_respond_to object, :answer
@@ -166,7 +166,7 @@ describe Cartage::Core do
 
       assert_equal 42, object.answer
       object.answer = 21
-      assert_equal '21', object.answer
+      assert_equal "21", object.answer
     end
   end
 end

data/test/test_cartage_manifest.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-require 'minitest_config'
+require "minitest_config"
 
-describe 'Cartage::Manifest' do
+describe "Cartage::Manifest" do
   let(:cartage) { Cartage.new }
   let(:manifest) { cartage.manifest }
-  let(:manifest_contents) { %w(bin/build bin/cartage lib/cartage.rb spec/cartage.rb) }
-  let(:expected_tmpfile) { %W(foo/bin/build\n foo/bin/cartage\n foo/lib/cartage.rb\n) }
+  let(:manifest_contents) { %w[bin/build bin/cartage lib/cartage.rb spec/cartage.rb] }
+  let(:expected_tmpfile) { %W[foo/bin/build\n foo/bin/cartage\n foo/lib/cartage.rb\n] }
 
   before do
     cartage
@@ -51,8 +51,8 @@ describe 'Cartage::Manifest' do
     end
   end
 
-  describe '#resolve' do
-    it 'fails if there is no manifest_file' do
+  describe "#resolve" do
+    it "fails if there is no manifest_file" do
       stub_manifest_file exists: false do
         ex = assert_raises Cartage::Manifest::MissingError do
           manifest.resolve
@@ -61,26 +61,26 @@ describe 'Cartage::Manifest' do
       end
     end
 
-    it 'fails if there is no block given' do
+    it "fails if there is no block given" do
       stub_manifest_file do
-        assert_raises_with_message ArgumentError, 'A block is required.' do
+        assert_raises_with_message ArgumentError, "A block is required." do
           manifest.resolve
         end
       end
     end
 
-    it 'fails if the manifest is empty' do
+    it "fails if the manifest is empty" do
       stub_manifest_file contents: [] do
-        assert_raises_with_message RuntimeError, 'Manifest.txt is empty.' do
+        assert_raises_with_message RuntimeError, "Manifest.txt is empty." do
           manifest.resolve {}
         end
       end
     end
 
-    it 'yields the name of a tempfile with the manifest contents' do
+    it "yields the name of a tempfile with the manifest contents" do
       stub_ignore_file contents: [] do
         stub_manifest_file contents: manifest_contents do
-          manifest.resolve(Pathname('foo')) { |name|
+          manifest.resolve(Pathname("foo")) { |name|
             assert_match(/Manifest\./, name)
             assert_equal (expected_tmpfile << "foo/spec/cartage.rb\n"),
               Pathname(name).readlines
@@ -89,21 +89,21 @@ describe 'Cartage::Manifest' do
       end
     end
 
-    it 'prunes out ignored files from a specified cartignore' do
-      stub_ignore_file contents: %w(spec/) do
+    it "prunes out ignored files from a specified cartignore" do
+      stub_ignore_file contents: %w[spec/] do
         stub_manifest_file contents: manifest_contents do
-          manifest.resolve(Pathname('foo')) { |name|
+          manifest.resolve(Pathname("foo")) { |name|
             assert_equal expected_tmpfile, Pathname(name).readlines
           }
         end
       end
     end
 
-    it 'prunes out ignored files from a specified slugignore' do
+    it "prunes out ignored files from a specified slugignore" do
       stub_ignore_file exists: false do
-        stub_slugignore_file contents: %w(spec/) do
+        stub_slugignore_file contents: %w[spec/] do
           stub_manifest_file contents: manifest_contents do
-            manifest.resolve(Pathname('foo')) { |name|
+            manifest.resolve(Pathname("foo")) { |name|
               assert_equal expected_tmpfile, Pathname(name).readlines
             }
           end
@@ -111,11 +111,11 @@ describe 'Cartage::Manifest' do
       end
     end
 
-    it 'prunes out ignored files from the default cartignore' do
+    it "prunes out ignored files from the default cartignore" do
       stub_ignore_file exists: false do
         stub_slugignore_file exists: false do
           stub_manifest_file contents: manifest_contents do
-            manifest.resolve(Pathname('foo')) { |name|
+            manifest.resolve(Pathname("foo")) { |name|
               assert_equal expected_tmpfile.reject { |v| v =~ /build/ },
                 Pathname(name).readlines
             }
@@ -124,10 +124,10 @@ describe 'Cartage::Manifest' do
       end
     end
 
-    it 'prunes out ignored files with a leading slash' do
-      stub_ignore_file contents: %w(/spec) do
+    it "prunes out ignored files with a leading slash" do
+      stub_ignore_file contents: %w[/spec] do
         stub_manifest_file contents: manifest_contents do
-          manifest.resolve(Pathname('foo')) { |name|
+          manifest.resolve(Pathname("foo")) { |name|
             assert_equal expected_tmpfile, Pathname(name).readlines
           }
         end
@@ -135,18 +135,18 @@ describe 'Cartage::Manifest' do
     end
   end
 
-  describe '#generate' do
-    it 'is created with sorted and unique filenames' do
+  describe "#generate" do
+    it "is created with sorted and unique filenames" do
       assert_pathname_write "a\nb\nc\n" do
-        stub_backticks %w(b a a a b c).join("\n") do
+        stub_backticks %w[b a a a b c].join("\n") do
           manifest.generate
         end
       end
     end
   end
 
-  describe '#check' do
-    it 'fails if there is no manifest_file' do
+  describe "#check" do
+    it "fails if there is no manifest_file" do
       stub_manifest_file exists: false do
         ex = assert_raises Cartage::Manifest::MissingError do
           manifest.check
@@ -155,35 +155,33 @@ describe 'Cartage::Manifest' do
       end
     end
 
-    it 'compares the current files against the manifest' do
-      begin
-        sysc = ->(*args) { IO.popen(args) { |diff| puts diff.read } }
+    it "compares the current files against the manifest" do
+      sysc = ->(*args) { IO.popen(args) { |diff| puts diff.read } }
 
-        assert_output(/^\+d/) do
-          instance_stub Kernel, :system, sysc do
-            stub_backticks %w(a b c).join("\n") do
-              manifest.instance_variable_set(:@manifest_file, Pathname('Manifest.test'))
-              manifest.generate
-            end
+      assert_output(/^\+d/) do
+        instance_stub Kernel, :system, sysc do
+          stub_backticks %w[a b c].join("\n") do
+            manifest.instance_variable_set(:@manifest_file, Pathname("Manifest.test"))
+            manifest.generate
+          end
 
-            stub_backticks %w(a b c d).join("\n") do
-              manifest.check
-            end
+          stub_backticks %w[a b c d].join("\n") do
+            manifest.check
           end
         end
-      ensure
-        file = manifest.send(:manifest_file)
-        file.unlink if file.to_s.end_with?('Manifest.test')
       end
+    ensure
+      file = manifest.send(:manifest_file)
+      file.unlink if file.to_s.end_with?("Manifest.test")
     end
   end
 
-  describe '#install_default_ignore' do
+  describe "#install_default_ignore" do
     before do
       cartage.verbose = true
     end
 
-    it 'does nothing if the ignore file exists without overwrite or merge' do
+    it "does nothing if the ignore file exists without overwrite or merge" do
       assert_output ".cartignore already exists, skipping...\n" do
         stub_ignore_file do |ignore_file|
           stub ignore_file, :write, ->(_) {} do
@@ -206,11 +204,11 @@ describe 'Cartage::Manifest' do
       end
     end
 
-    it 'merges if mode is merge' do
-      stub_ignore_file contents: %w(xyz/) do |ignore_file|
+    it "merges if mode is merge" do
+      stub_ignore_file contents: %w[xyz/] do |ignore_file|
         stub ignore_file, :write, ignore_file_writer(%r{^xyz/.*vendor/bundle/$}m) do
           assert_output "Merging .cartignore...\n" do
-            manifest.install_default_ignore(mode: 'merge')
+            manifest.install_default_ignore(mode: "merge")
           end
 
           assert_instance_called ignore_file.class, :write
@@ -218,11 +216,11 @@ describe 'Cartage::Manifest' do
       end
     end
 
-    it 'merges if mode is merge and ignore file is empty' do
+    it "merges if mode is merge and ignore file is empty" do
       stub_ignore_file contents: [] do |ignore_file|
         stub ignore_file, :write, ignore_file_writer(%r{^# Some .*vendor/bundle/$}m) do
           assert_output "Merging .cartignore...\n" do
-            manifest.install_default_ignore(mode: 'merge')
+            manifest.install_default_ignore(mode: "merge")
           end
 
           assert_instance_called ignore_file.class, :write
@@ -230,11 +228,11 @@ describe 'Cartage::Manifest' do
       end
     end
 
-    it 'forces when mode is force' do
-      stub_ignore_file contents: %w(xyz/) do |ignore_file|
+    it "forces when mode is force" do
+      stub_ignore_file contents: %w[xyz/] do |ignore_file|
         stub ignore_file, :write, ignore_file_writer(%r{^# Some .*vendor/bundle/$}m) do
           assert_output "Creating .cartignore...\n" do
-            manifest.install_default_ignore(mode: 'force')
+            manifest.install_default_ignore(mode: "force")
           end
 
           assert_instance_called ignore_file.class, :write

data/test/test_cartage_plugin.rb

@@ -1,6 +1,12 @@
 # frozen_string_literal: true
 
-require 'minitest_config'
+require "minitest_config"
+
+class Cartage::Plugin::Test < ::Cartage::Plugin
+  def test
+    "test"
+  end
+end
 
 describe Cartage::Plugin do
   let(:config) { Cartage::Config.load(:default) }
@@ -8,25 +14,19 @@ describe Cartage::Plugin do
   let(:plugin) { Cartage::Plugin::Test }
   let(:instance) { plugin.new(cartage) }
 
-  it 'cannot be instantiated without being subclassed' do
-    assert_raises_with_message NotImplementedError, 'not a subclass' do
+  it "cannot be instantiated without being subclassed" do
+    assert_raises_with_message NotImplementedError, "not a subclass" do
       Cartage::Plugin.new(cartage)
     end
   end
 
-  class Cartage::Plugin::Test < ::Cartage::Plugin
-    def test
-      'test'
-    end
-  end
-
   describe Cartage::Plugin::Test do
-    it 'is enabled by default' do
+    it "is enabled by default" do
       assert_true instance.enabled?
       assert_false instance.disabled?
     end
 
-    it 'can be disabled by configuration' do
+    it "can be disabled by configuration" do
       contents = {
         plugins: {
           test: {
@@ -37,7 +37,7 @@ describe Cartage::Plugin do
 
       config = instance_stub Pathname, :read, -> { contents } do
         instance_stub Pathname, :exist?, -> { true } do
-          Cartage::Config.load('foo')
+          Cartage::Config.load("foo")
         end
       end
 
@@ -46,14 +46,14 @@ describe Cartage::Plugin do
       assert_true cartage.test.disabled?
     end
 
-    it 'has its configured feature offers' do
+    it "has its configured feature offers" do
       assert_true instance.offer?(:test)
       assert_false instance.offer?(:other)
     end
 
-    it 'is named based on the class' do
-      assert_equal 'test', instance.plugin_name
-      assert_equal 'test', plugin.plugin_name
+    it "is named based on the class" do
+      assert_equal "test", instance.plugin_name
+      assert_equal "test", plugin.plugin_name
     end
   end
 
@@ -61,12 +61,12 @@ describe Cartage::Plugin do
     let(:manifest) { Cartage::Manifest.new(cartage) }
     let(:subject) { Cartage::Plugins.new.tap { |c| c.add(instance, manifest) } }
 
-    it '#enabled returns all enabled plugins' do
+    it "#enabled returns all enabled plugins" do
       instance.define_singleton_method(:disabled?, -> { true })
       assert_equal 1, subject.enabled.count
     end
 
-    it '#request executes the named feature on found plug-ins' do
+    it "#request executes the named feature on found plug-ins" do
       instance_stub Cartage::Plugin::Test, :test, -> {} do
         subject.request(:test)
       end
@@ -74,9 +74,9 @@ describe Cartage::Plugin do
       assert_instance_called Cartage::Plugin::Test, :test, 1
     end
 
-    it '#request_map maps the named feature on found plug-ins' do
-      instance_stub Cartage::Plugin::Test, :test, -> { 'TEST' } do
-        assert_equal %w(TEST), subject.request_map(:test)
+    it "#request_map maps the named feature on found plug-ins" do
+      instance_stub Cartage::Plugin::Test, :test, -> { "TEST" } do
+        assert_equal %w[TEST], subject.request_map(:test)
       end
 
       assert_instance_called Cartage::Plugin::Test, :test, 1