cartage 2.0 → 2.2.1

data/test/test_cartage.rb

@@ -1,91 +1,91 @@
 # frozen_string_literal: true
 
-require 'minitest_config'
+require "minitest_config"
 
 describe Cartage do
   let(:config) { nil }
   let(:cartage) { Cartage.new(config) }
 
-  describe '#initialize' do
-    it 'loads an empty configuration when created without a config' do
+  describe "#initialize" do
+    it "loads an empty configuration when created without a config" do
       assert_equal Cartage::Config.new, cartage.config
     end
   end
 
-  describe '#name, #name=' do
-    it 'defaults to #default_name' do
+  describe "#name, #name=" do
+    it "defaults to #default_name" do
       stub_cartage_repo_url do
-        assert_equal 'repo-url', cartage.name
+        assert_equal "repo-url", cartage.name
         assert_equal cartage.default_name, cartage.name
       end
     end
 
-    it 'can be overridden' do
+    it "can be overridden" do
       stub_cartage_repo_url do
-        cartage.name = 'xyz'
-        assert_equal 'xyz', cartage.name
+        cartage.name = "xyz"
+        assert_equal "xyz", cartage.name
       end
     end
   end
 
-  describe '#root_path, #root_path=' do
-    it 'defaults to #default_root_path' do
+  describe "#root_path, #root_path=" do
+    it "defaults to #default_root_path" do
       stub_cartage_repo_url do
-        stub_backticks '/x/y/z' do
-          assert_equal Pathname('/x/y/z'), cartage.root_path
+        stub_backticks "/x/y/z" do
+          assert_equal Pathname("/x/y/z"), cartage.root_path
           assert_equal cartage.default_root_path, cartage.root_path
         end
       end
     end
 
-    it 'can be overridden and creates a Pathname' do
+    it "can be overridden and creates a Pathname" do
       stub_cartage_repo_url do
-        cartage.root_path = '/a/b/c'
-        assert_equal Pathname('/a/b/c'), cartage.root_path
+        cartage.root_path = "/a/b/c"
+        assert_equal Pathname("/a/b/c"), cartage.root_path
       end
     end
 
-    it 'expands the created Pathname' do
+    it "expands the created Pathname" do
       stub_cartage_repo_url do
-        cartage.root_path = '/a/b/../c'
-        assert_equal Pathname('/a/c'), cartage.root_path
+        cartage.root_path = "/a/b/../c"
+        assert_equal Pathname("/a/c"), cartage.root_path
       end
     end
   end
 
-  describe '#timestamp, #timestamp=' do
+  describe "#timestamp, #timestamp=" do
     it 'defaults to #now.utc.strftime("%Y%m%d%H%M%S")' do
-      stub Time, :now, -> { Time.new(2014, 12, 31, 23, 59, 59, '+00:00') } do
-        assert_equal '20141231235959', cartage.timestamp
+      stub Time, :now, -> { Time.new(2014, 12, 31, 23, 59, 59, "+00:00") } do
+        assert_equal "20141231235959", cartage.timestamp
         assert_equal cartage.default_timestamp, cartage.timestamp
       end
     end
 
-    it 'does no validation of assigned values' do
-      cartage.timestamp = 'not a timestamp'
-      assert_equal 'not a timestamp', cartage.timestamp
+    it "does no validation of assigned values" do
+      cartage.timestamp = "not a timestamp"
+      assert_equal "not a timestamp", cartage.timestamp
     end
   end
 
-  describe '#target, #target=' do
-    it 'defaults to tmp/ as a Pathname' do
-      assert_equal Pathname('tmp'), cartage.target
+  describe "#target, #target=" do
+    it "defaults to tmp/ as a Pathname" do
+      assert_equal Pathname("tmp"), cartage.target
       assert_equal cartage.default_target, cartage.target
     end
 
-    it 'it converts the assigned value into a pathname' do
-      cartage.target = '/a/b/c'
-      assert_equal Pathname('/a/b/c'), cartage.target
+    it "it converts the assigned value into a pathname" do
+      cartage.target = "/a/b/c"
+      assert_equal Pathname("/a/b/c"), cartage.target
     end
   end
 
-  describe '#compression, #compression=' do
-    it 'defaults to :bzip2' do
+  describe "#compression, #compression=" do
+    it "defaults to :bzip2" do
       assert_equal :bzip2, cartage.compression
     end
 
-    it 'accepts bzip2, none, and gzip as valid values' do
-      candidates = %i(bzip2 none gzip)
+    it "accepts bzip2, none, and gzip as valid values" do
+      candidates = %i[bzip2 none gzip]
       candidates += candidates.map(&:to_s)
       candidates.each { |candidate|
         cartage.compression = candidate
@@ -93,68 +93,68 @@ describe Cartage do
       }
     end
 
-    it 'fails if given an unknown type' do
-      assert_raises_with_message ArgumentError, 'Invalid compression type nil' do
+    it "fails if given an unknown type" do
+      assert_raises_with_message ArgumentError, "Invalid compression type nil" do
         cartage.compression = nil
       end
-      assert_raises_with_message ArgumentError, 'Invalid compression type 3' do
+      assert_raises_with_message ArgumentError, "Invalid compression type 3" do
         cartage.compression = 3
       end
       assert_raises_with_message ArgumentError, 'Invalid compression type "foo"' do
-        cartage.compression = 'foo'
+        cartage.compression = "foo"
       end
     end
 
-    it 'affects #tar_compression_extension' do
-      assert_equal '.bz2', cartage.tar_compression_extension
+    it "affects #tar_compression_extension" do
+      assert_equal ".bz2", cartage.tar_compression_extension
 
-      cartage.compression = 'none'
-      assert_equal '', cartage.tar_compression_extension
+      cartage.compression = "none"
+      assert_equal "", cartage.tar_compression_extension
 
-      cartage.compression = 'gzip'
-      assert_equal '.gz', cartage.tar_compression_extension
+      cartage.compression = "gzip"
+      assert_equal ".gz", cartage.tar_compression_extension
     end
 
-    it 'affects #tar_compression_flag' do
-      assert_equal 'j', cartage.tar_compression_flag
+    it "affects #tar_compression_flag" do
+      assert_equal "j", cartage.tar_compression_flag
 
-      cartage.compression = 'none'
-      assert_equal '', cartage.tar_compression_flag
+      cartage.compression = "none"
+      assert_equal "", cartage.tar_compression_flag
 
-      cartage.compression = 'gzip'
-      assert_equal 'z', cartage.tar_compression_flag
+      cartage.compression = "gzip"
+      assert_equal "z", cartage.tar_compression_flag
     end
   end
 
-  describe '#dependency_cache, #dependency_cache_path, #dependency_cache_path=' do
-    it 'defaults to #tmp_path{,/dependency-cache.tar.bz2}' do
+  describe "#dependency_cache, #dependency_cache_path, #dependency_cache_path=" do
+    it "defaults to #tmp_path{,/dependency-cache.tar.bz2}" do
       assert_equal cartage.tmp_path, cartage.dependency_cache_path
-      assert_equal cartage.tmp_path.join('dependency-cache.tar.bz2'),
+      assert_equal cartage.tmp_path.join("dependency-cache.tar.bz2"),
         cartage.dependency_cache
     end
 
-    it 'is affected by the compression setting' do
-      cartage.compression = 'none'
-      assert_equal cartage.tmp_path.join('dependency-cache.tar'),
+    it "is affected by the compression setting" do
+      cartage.compression = "none"
+      assert_equal cartage.tmp_path.join("dependency-cache.tar"),
         cartage.dependency_cache
 
-      cartage.compression = 'gzip'
-      assert_equal cartage.tmp_path.join('dependency-cache.tar.gz'),
+      cartage.compression = "gzip"
+      assert_equal cartage.tmp_path.join("dependency-cache.tar.gz"),
         cartage.dependency_cache
     end
 
-    it 'becomes a Pathname' do
-      cartage.dependency_cache_path = 'foo'
-      assert_equal Pathname('foo').expand_path, cartage.dependency_cache_path
-      assert_equal Pathname('foo/dependency-cache.tar.bz2').expand_path,
+    it "becomes a Pathname" do
+      cartage.dependency_cache_path = "foo"
+      assert_equal Pathname("foo").expand_path, cartage.dependency_cache_path
+      assert_equal Pathname("foo/dependency-cache.tar.bz2").expand_path,
         cartage.dependency_cache
     end
   end
 
-  describe '#config' do
+  describe "#config" do
     let(:data) {
       {
-        release_hashref: '12345',
+        release_hashref: "12345",
         x: 1,
         plugins: {
           test: {
@@ -178,11 +178,11 @@ describe Cartage do
       assert_equal config.commands.test, cartage.config(for_command: :test)
     end
 
-    it 'knows the whole config' do
+    it "knows the whole config" do
       assert_equal config, cartage.config
     end
 
-    it 'fails with an error when asking for plugin and command together' do
+    it "fails with an error when asking for plugin and command together" do
       exception = assert_raises ArgumentError do
         cartage.config(for_plugin: :test, for_command: :test)
       end
@@ -190,72 +190,72 @@ describe Cartage do
     end
   end
 
-  describe '#dependency_cache' do
+  describe "#dependency_cache" do
     def assert_dependency_cache_equal(path)
       yield if block_given?
-      assert_equal Pathname('.').join(path).expand_path, cartage.dependency_cache
+      assert_equal Pathname(".").join(path).expand_path, cartage.dependency_cache
     end
 
     it 'defaults to "tmp/dependency-cache.tar.bz2"' do
-      assert_dependency_cache_equal 'tmp/dependency-cache.tar.bz2'
+      assert_dependency_cache_equal "tmp/dependency-cache.tar.bz2"
     end
 
-    it 'can be overridden through #dependency_cache_path=' do
-      assert_dependency_cache_equal 'tmp/dependency-cache.tar.bz2'
-      assert_dependency_cache_equal 'tmpx/dependency-cache.tar.bz2' do
-        cartage.dependency_cache_path = 'tmpx'
+    it "can be overridden through #dependency_cache_path=" do
+      assert_dependency_cache_equal "tmp/dependency-cache.tar.bz2"
+      assert_dependency_cache_equal "tmpx/dependency-cache.tar.bz2" do
+        cartage.dependency_cache_path = "tmpx"
       end
     end
   end
 
-  describe '#release_hashref' do
-    it 'returns the current hashref' do
+  describe "#release_hashref" do
+    it "returns the current hashref" do
       stub_cartage_repo_url do
-        stub_backticks '12345' do
-          assert_equal '12345', cartage.release_hashref
+        stub_backticks "12345" do
+          assert_equal "12345", cartage.release_hashref
         end
       end
     end
   end
 
-  describe '#repo_url' do
-    it 'returns the origin Fetch URL' do
-      origin = <<-origin
-* remote origin
-  Fetch URL: git@github.com:KineticCafe/cartage.git
-  Push  URL: git@github.com:KineticCafe/cartage.git
-  HEAD branch: (not queried)
-  Remote branch: (status not queried)
-    master
-  Local branch configured for 'git pull':
-    master rebases onto remote master
-  Local ref configured for 'git push' (status not queried):
-    (matching) pushes to (matching)
-      origin
+  describe "#repo_url" do
+    it "returns the origin Fetch URL" do
+      origin = <<~ORIGIN
+        * remote origin
+          Fetch URL: git@github.com:KineticCafe/cartage.git
+          Push  URL: git@github.com:KineticCafe/cartage.git
+          HEAD branch: (not queried)
+          Remote branch: (status not queried)
+            master
+          Local branch configured for 'git pull':
+            master rebases onto remote master
+          Local ref configured for 'git push' (status not queried):
+            (matching) pushes to (matching)
+      ORIGIN
       stub_backticks origin do
-        assert_equal 'git@github.com:KineticCafe/cartage.git',
+        assert_equal "git@github.com:KineticCafe/cartage.git",
           cartage.repo_url
       end
     end
   end
 
-  describe 'computed paths' do
+  describe "computed paths" do
     before do
-      cartage.root_path = '/a/b/c'
-      cartage.name = 'test'
-      cartage.timestamp = 'value'
+      cartage.root_path = "/a/b/c"
+      cartage.name = "test"
+      cartage.timestamp = "value"
     end
 
-    it '#tmp_path is #root_path/tmp' do
-      assert_equal Pathname('/a/b/c/tmp'), cartage.tmp_path
+    it "#tmp_path is #root_path/tmp" do
+      assert_equal Pathname("/a/b/c/tmp"), cartage.tmp_path
     end
 
-    it '#work_path is #tmp_path/#name' do
-      assert_equal Pathname('/a/b/c/tmp/test'), cartage.work_path
+    it "#work_path is #tmp_path/#name" do
+      assert_equal Pathname("/a/b/c/tmp/test"), cartage.work_path
     end
 
-    it '#final_name is #tmp_path/#name-#timestamp' do
-      assert_equal Pathname('/a/b/c/tmp/test-value'), cartage.final_name
+    it "#final_name is #tmp_path/#name-#timestamp" do
+      assert_equal Pathname("/a/b/c/tmp/test-value"), cartage.final_name
     end
 
     # it '#build_tarball.final_tarball is #final_name.tar#compression_extension' do
@@ -271,55 +271,55 @@ describe Cartage do
     #     cartage.build_tarball.final_tarball
     # end
 
-    it '#final_release_metadata_json is #final_name-release-metadata.json' do
-      assert_equal Pathname('/a/b/c/tmp/test-value-release-metadata.json'),
+    it "#final_release_metadata_json is #final_name-release-metadata.json" do
+      assert_equal Pathname("/a/b/c/tmp/test-value-release-metadata.json"),
         cartage.final_release_metadata_json
     end
   end
 
-  describe '#display' do
-    it 'does not display a message if not verbose' do
+  describe "#display" do
+    it "does not display a message if not verbose" do
       cartage.verbose = false
       assert_silent do
-        cartage.display 'hello'
+        cartage.display "hello"
       end
     end
 
-    it 'displays a message if verbose' do
+    it "displays a message if verbose" do
       cartage.verbose = true
       assert_output "hello\n" do
-        cartage.display 'hello'
+        cartage.display "hello"
       end
     end
 
-    it 'does not display a message if verbose and quiet' do
+    it "does not display a message if verbose and quiet" do
       cartage.verbose = true
       cartage.quiet = true
       assert_silent do
-        cartage.display 'hello'
+        cartage.display "hello"
       end
     end
   end
 
-  describe '#run' do
+  describe "#run" do
     before do
-      @command = %w(echo yes)
+      @command = %w[echo yes]
     end
 
-    it 'displays the output if not verbose and not quiet' do
+    it "displays the output if not verbose and not quiet" do
       assert_output "yes\n" do
         cartage.send(:run, @command)
       end
     end
 
-    it 'displays the command and output if verbose and not quiet' do
+    it "displays the command and output if verbose and not quiet" do
       cartage.verbose = true
       assert_output "echo yes\nyes\n" do
         cartage.send(:run, @command)
       end
     end
 
-    it 'displays nothing if quiet' do
+    it "displays nothing if quiet" do
       cartage.verbose = true
       cartage.quiet = true
       assert_silent do
@@ -327,29 +327,29 @@ describe Cartage do
       end
     end
 
-    it 'raises an exception on error' do
+    it "raises an exception on error" do
       cartage.quiet = true
       ex = assert_raises StandardError do
-        cartage.send(:run, %w(false))
+        cartage.send(:run, %w[false])
       end
       assert_equal "Error running 'false'", ex.message
     end
   end
 
-  describe '#release_metadata' do
-    it 'has the structure we want' do
+  describe "#release_metadata" do
+    it "has the structure we want" do
       stub_cartage_repo_url do
-        cartage.send(:release_hashref=, '12345')
+        cartage.send(:release_hashref=, "12345")
         cartage.timestamp = 3
 
         expected = {
           package: {
-            name: 'repo-url',
+            name: "repo-url",
             repo: {
-              type: 'git',
-              url: 'git://host/repo-url.git'
+              type: "git",
+              url: "git://host/repo-url.git"
             },
-            hashref: '12345',
+            hashref: "12345",
             timestamp: 3
           }
         }
@@ -359,7 +359,7 @@ describe Cartage do
     end
   end
 
-  describe '#build_package' do
+  describe "#build_package" do
     def disable_unsafe_method(*names, &block)
       block ||= -> {}
       names.each { |name| cartage.define_singleton_method name, &block }
@@ -371,7 +371,7 @@ describe Cartage do
       disable_unsafe_method :create_dependency_cache, &->(_) {}
     end
 
-    it 'requests :vendor_dependencies and :vendor_dependencies#path' do
+    it "requests :vendor_dependencies and :vendor_dependencies#path" do
       disable_unsafe_method :request_build_package
 
       verify_request = ->(f) { assert_equal :vendor_dependencies, f }
@@ -388,10 +388,10 @@ describe Cartage do
       end
     end
 
-    it 'requests :pre_build_package, :build_package, and :post_build_package' do
+    it "requests :pre_build_package, :build_package, and :post_build_package" do
       disable_unsafe_method :vendor_dependencies
 
-      requests = %i(pre_build_package build_package post_build_package)
+      requests = %i[pre_build_package build_package post_build_package]
 
       verify_request = ->(f) { assert_equal requests.shift, f }
 

data/test/test_cartage_build_tarball.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
-require 'minitest_config'
+require "minitest_config"
 
-describe 'Cartage::BuildTarball' do
+describe "Cartage::BuildTarball" do
   let(:config) {
     Cartage::Config.new(
-      root_path: '/a/b/c',
-      name: 'test',
-      timestamp: 'value'
+      root_path: "/a/b/c",
+      name: "test",
+      timestamp: "value"
     )
   }
   let(:cartage) {
@@ -15,18 +15,18 @@ describe 'Cartage::BuildTarball' do
   }
   let(:subject) { cartage.build_tarball }
 
-  it '#build_package requests :pre_build_tarball and :post_build_tarball' do
-    requests = %i(pre_build_tarball post_build_tarball)
+  it "#build_package requests :pre_build_tarball and :post_build_tarball" do
+    requests = %i[pre_build_tarball post_build_tarball]
 
     verify_request = ->(f) { assert_equal requests.shift, f }
     verify_run = ->(c) {
       assert_equal [
-        'tar',
-        'cfj',
-        '/a/b/c/tmp/test-value.tar.bz2',
-        '-C',
-        '/a/b/c/tmp',
-        'test'
+        "tar",
+        "cfj",
+        "/a/b/c/tmp/test-value.tar.bz2",
+        "-C",
+        "/a/b/c/tmp",
+        "test"
       ], c
     }
 
@@ -39,19 +39,19 @@ describe 'Cartage::BuildTarball' do
     assert_empty requests
   end
 
-  describe '#package_name is dependent on Cartage configuration' do
-    it 'is .tar.bz2 when compression is :bzip2' do
-      assert_equal Pathname('/a/b/c/tmp/test-value.tar.bz2'), subject.package_name
+  describe "#package_name is dependent on Cartage configuration" do
+    it "is .tar.bz2 when compression is :bzip2" do
+      assert_equal Pathname("/a/b/c/tmp/test-value.tar.bz2"), subject.package_name
     end
 
-    it 'is .tar when compression is :none' do
-      cartage.compression = 'none'
-      assert_equal Pathname('/a/b/c/tmp/test-value.tar'), subject.package_name
+    it "is .tar when compression is :none" do
+      cartage.compression = "none"
+      assert_equal Pathname("/a/b/c/tmp/test-value.tar"), subject.package_name
     end
 
-    it 'is .tar.gz when compression is :gzip' do
-      cartage.compression = 'gzip'
-      assert_equal Pathname('/a/b/c/tmp/test-value.tar.gz'), subject.package_name
+    it "is .tar.gz when compression is :gzip" do
+      cartage.compression = "gzip"
+      assert_equal Pathname("/a/b/c/tmp/test-value.tar.gz"), subject.package_name
     end
   end
 end