cardconnect 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a8573cecba2cb8cac90e17b0ce8ca92e73280253
-  data.tar.gz: 5ca366ccec6c686f6e2e19fd159e4761cd93825e
+  metadata.gz: 9cdcd8db1cec80bc8985ed0cb3a25e7bf3eb9751
+  data.tar.gz: 321b5a61678fa64c20785b23cafac3a4ef587bbe
 SHA512:
-  metadata.gz: 5065e73f0951b0fe238b049dd333f8a1f3fd4c6ca2f328858b0f869a3c9e344bc8a3a42bb7ed916050c3ea1609b56529b9fc60d77086485031872b14cb401d85
-  data.tar.gz: 3561424fc95e5a43e0d2c51db6673c6cedabd8354effa6f9f76abbdd2e7e35c6ff0f4093f9132859ea3cc1e20518fc6b28a5f40ef2db976cad7316abc17f69a9
+  metadata.gz: 293887a01cfce95fde55de4495e2f2670dbec81aa3bd2af6a9d639d05b5946ca25082c2ce8163b976fa6372bfd3423f7031be48dd9d07d8a1f46a8ecf4496a4b
+  data.tar.gz: 46b5f0873300fb5aabe005e584356caf510938c7ed4d98d821b1642908b5465c97e1ea37f382c6a7df193ac2c23b7986f52adf0a466bfb5ffaaf71e47c55dfc9

data/.codeclimate.yml

@@ -0,0 +1,11 @@
+---
+engines:
+  fixme:
+    enabled: true
+  rubocop:
+    enabled: true
+ratings:
+  paths:
+  - '**.rb'
+exclude_paths:
+- test/**/*

data/.rubocop.yml

@@ -0,0 +1,10 @@
+Metrics/LineLength:
+  Max: 110
+Documentation:
+  Enabled: false
+Style/NumericLiterals:
+  MinDigits: 10
+AllCops:
+  Exclude:
+    - LICENSE.txt
+    - README.md

data/.travis.yml

@@ -0,0 +1,7 @@
+language: ruby
+rvm:
+  - 2.2.0
+  - 1.9.3
+addons:
+  code_climate:
+      repo_token: 77ed2a0fb6a3c8841131b45bcf6beae12ead240bb0b127d1a064d069bfbe9376

data/README.md

@@ -3,6 +3,8 @@
 CardConnect API Ruby Wrapper
 
 [![Gem Version](https://badge.fury.io/rb/cardconnect.svg)](http://badge.fury.io/rb/cardconnect)
+[![Code Climate](https://codeclimate.com/github/mobilecause/cardconnect/badges/gpa.svg)](https://codeclimate.com/github/mobilecause/cardconnect)
+[![Build Status](https://travis-ci.org/mobilecause/cardconnect.svg?branch=master)](https://travis-ci.org/mobilecause/cardconnect)
 
 ## Installation
 

data/Rakefile

@@ -1,15 +1,15 @@
-require "bundler/gem_tasks"
-
+require 'bundler/gem_tasks'
 require 'rake/testtask'
+require 'cardconnect'
+
+task default: [:test]
 
 Rake::TestTask.new do |t|
   t.libs << 'test'
-  t.pattern = "test/**/*_test.rb"
+  t.pattern = 'test/**/*_test.rb'
 end
 
 namespace :cardconnect do
-  require 'cardconnect'
-
   def cardconnect_configure(args)
     CardConnect.configure do |config|
       config.merchant_id = args.merchant_id
@@ -19,28 +19,57 @@ namespace :cardconnect do
     end
   end
 
-  desc "Ping the API Server"
-  task :ping, [:merchant_id, :api_username, :api_password, :api_endpoint] do |t, args|
+  desc 'Ping the API Server'
+  task :ping, [:merchant_id, :api_username, :api_password, :api_endpoint] do |_, args|
     cardconnect_configure(args)
 
     response = CardConnect::Connection.new.ping_server
     puts response.body
   end
 
-  desc "Simulate an Authorization request"
-  task :authorize, [:capture?, :merchant_id, :api_username, :api_password, :api_endpoint] do |t, args|
+  desc 'Simulate an Authorization request'
+  task :authorize, [:merchant_id, :api_username, :api_password, :api_endpoint] do |_, args|
     cardconnect_configure(args)
 
     auth_params = {
-        'account' => '4111111111111111',
-        "accttype" => "VISA",
-        'expiry' => '1220',
-        'amount' => '1000',
-        'currency' => 'USD',
-        "tokenize" => "Y"
+      'account' => '4111111111111111',
+      'accttype' => 'VISA',
+      'expiry' => '1220',
+      'amount' => '1000',
+      'currency' => 'USD',
+      'tokenize' => 'Y',
+      'profile' => 'Y',
+      'name' => 'Bob Johnson',
+      'capture' => 'N'
     }
 
-    auth_params.merge!("capture" => "Y") if args[:capture?]
+    auth = CardConnect::Service::Authorization.new
+    auth.build_request(auth_params)
+
+    if auth.request.valid?
+      response = auth.submit
+      puts response.body
+    else
+      puts auth.request.errors
+    end
+  end
+
+  desc 'Simulate an Authorization Capture request'
+  task :auth_capture, [:merchant_id, :api_username, :api_password, :api_endpoint] do |_, args|
+    cardconnect_configure(args)
+
+    auth_params = {
+      'account' => '4111111111111111',
+      'accttype' => 'VISA',
+      'expiry' => '1220',
+      'amount' => '1000',
+      'currency' => 'USD',
+      'tokenize' => 'Y',
+      'profile' => 'Y',
+      'name' => 'Bob Johnson',
+      'capture' => 'Y',
+      'ponumber' => '1234'
+    }
 
     auth = CardConnect::Service::Authorization.new
     auth.build_request(auth_params)
@@ -53,13 +82,13 @@ namespace :cardconnect do
     end
   end
 
-  desc "Simulate a Capture request"
-  task :capture, [:retref, :merchant_id, :api_username, :api_password, :api_endpoint] do |t, args|
+  desc 'Simulate a Capture request'
+  task :capture, [:retref, :merchant_id, :api_username, :api_password, :api_endpoint] do |_, args|
     cardconnect_configure(args)
 
     capture_params = {
-        'merchid' => CardConnect.configuration.merchant_id,
-        'retref' => args.retref
+      'merchid' => CardConnect.configuration.merchant_id,
+      'retref' => args.retref
     }
 
     capture = CardConnect::Service::Capture.new
@@ -73,13 +102,13 @@ namespace :cardconnect do
     end
   end
 
-  desc "Simulate a Void request"
-  task :void, [:retref, :merchant_id, :api_username, :api_password, :api_endpoint] do |t, args|
+  desc 'Simulate a Void request'
+  task :void, [:retref, :merchant_id, :api_username, :api_password, :api_endpoint] do |_, args|
     cardconnect_configure(args)
 
     void_params = {
-        'merchid' => CardConnect.configuration.merchant_id,
-        'retref' => args[:retref]
+      'merchid' => CardConnect.configuration.merchant_id,
+      'retref' => args[:retref]
     }
 
     void = CardConnect::Service::Void.new
@@ -93,13 +122,13 @@ namespace :cardconnect do
     end
   end
 
-  desc "Simulate a Refund request"
-  task :refund, [:retref, :merchant_id, :api_username, :api_password, :api_endpoint] do |t, args|
+  desc 'Simulate a Refund request'
+  task :refund, [:retref, :merchant_id, :api_username, :api_password, :api_endpoint] do |_, args|
     cardconnect_configure(args)
 
     refund_params = {
-        'merchid' => CardConnect.configuration.merchant_id,
-        'retref' => args[:retref]
+      'merchid' => CardConnect.configuration.merchant_id,
+      'retref' => args[:retref]
     }
 
     refund = CardConnect::Service::Refund.new
@@ -113,13 +142,13 @@ namespace :cardconnect do
     end
   end
 
-  desc "Simulate an Inquire request"
-  task :inquire, [:retref, :merchant_id, :api_username, :api_password, :api_endpoint] do |t, args|
+  desc 'Simulate an Inquire request'
+  task :inquire, [:retref, :merchant_id, :api_username, :api_password, :api_endpoint] do |_, args|
     cardconnect_configure(args)
 
     inquire_params = {
-        'merchid' => CardConnect.configuration.merchant_id,
-        'retref' => args[:retref]
+      'merchid' => CardConnect.configuration.merchant_id,
+      'retref' => args[:retref]
     }
 
     inquire = CardConnect::Service::Inquire.new
@@ -133,14 +162,14 @@ namespace :cardconnect do
     end
   end
 
-  desc "Simulate a Settlement Status request"
-  task :settle_status, [:date, :merchant_id, :api_username, :api_password, :api_endpoint] do |t, args|
+  desc 'Simulate a Settlement Status request'
+  task :settle_status, [:date, :merchant_id, :api_username, :api_password, :api_endpoint] do |_, args|
     # Date format is MMDD
     cardconnect_configure(args)
 
     settle_params = {
-        'merchid' => CardConnect.configuration.merchant_id,
-        'date' => args[:date]
+      'merchid' => CardConnect.configuration.merchant_id,
+      'date' => args[:date]
     }
 
     status = CardConnect::Service::SettlementStatus.new
@@ -154,14 +183,14 @@ namespace :cardconnect do
     end
   end
 
-  desc "Simulate a Deposit request"
-  task :deposit, [:date, :merchant_id, :api_username, :api_password, :api_endpoint] do |t, args|
+  desc 'Simulate a Deposit request'
+  task :deposit, [:date, :merchant_id, :api_username, :api_password, :api_endpoint] do |_, args|
     # Date format is MMDD
     cardconnect_configure(args)
 
     deposit_params = {
-        'merchid' => CardConnect.configuration.merchant_id,
-        'date' => args[:date]
+      'merchid' => CardConnect.configuration.merchant_id,
+      'date' => args[:date]
     }
 
     deposit = CardConnect::Service::Deposit.new
@@ -174,5 +203,4 @@ namespace :cardconnect do
       puts deposit.request.errors
     end
   end
-
-end
+end

data/cardconnect.gemspec

@@ -4,19 +4,19 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'cardconnect/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "cardconnect"
+  spec.name          = 'cardconnect'
   spec.version       = CardConnect::VERSION
-  spec.authors       = ["Tim McKenzie", "Prashant Mokkarala", "Jason Taylor"]
-  spec.email         = ["tim@mobilecause.com", "prashant@mobilecause.com", "j.m.taylor1@gmail.com"]
-  spec.summary       = %q{CardConnect API Ruby Wrapper}
-  spec.description   = %q{CardConnect API Ruby Wrapper}
-  spec.homepage      = "http://developer.cardconnect.com/"
-  spec.license       = "MIT"
+  spec.authors       = ['Tim McKenzie', 'Prashant Mokkarala', 'Jason Taylor']
+  spec.email         = ['tim@mobilecause.com', 'prashant@mobilecause.com', 'j.m.taylor1@gmail.com']
+  spec.summary       = 'CardConnect API Ruby Wrapper'
+  spec.description   = 'CardConnect API Ruby Wrapper'
+  spec.homepage      = 'http://developer.cardconnect.com/'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler', '~> 1.0'
 

data/lib/cardconnect.rb

@@ -1,4 +1,4 @@
-require "cardconnect/version"
+require 'cardconnect/version'
 
 require 'cardconnect/utils'
 require 'cardconnect/error'
@@ -30,9 +30,7 @@ require 'cardconnect/services/deposit/deposit'
 require 'cardconnect/services/void/void'
 
 module CardConnect
-
   class << self
-
     def configure
       yield(configuration)
     end
@@ -44,6 +42,5 @@ module CardConnect
     def connection
       @connection ||= Connection.new.connection
     end
-
   end
 end

data/lib/cardconnect/configuration.rb

@@ -1,6 +1,5 @@
 module CardConnect
   class Configuration
-
     # Attributes that need to be passed in from the user
     attr_accessor :merchant_id
     attr_accessor :api_username

data/lib/cardconnect/connection.rb

@@ -3,33 +3,29 @@ require 'faraday_middleware'
 
 module CardConnect
   class Connection
-
     def initialize
       @config = CardConnect.configuration
-      @headers = {user_agent: "CardConnectRubyGem/#{CardConnect::VERSION}"}
+      @headers = { user_agent: "CardConnectRubyGem/#{CardConnect::VERSION}" }
     end
 
     def connection
-      @connection ||= Faraday.new(url: @config.endpoint, headers: @headers, ssl: {verify: false}) do |faraday|
-        faraday.request :basic_auth, @config.api_username, @config.api_password
-        faraday.request :json
+      @connection ||= Faraday.new(url: @config.endpoint, headers: @headers, ssl: { verify: false }) do |f|
+        f.request :basic_auth, @config.api_username, @config.api_password
+        f.request :json
 
-        faraday.response :json, :content_type => /\bjson$/
-        faraday.response :raise_error
+        f.response :json, content_type: /\bjson$/
+        f.response :raise_error
 
-        faraday.adapter Faraday.default_adapter
+        f.adapter Faraday.default_adapter
       end
     end
 
     def ping_server
-      begin
-        connection.get('/cardconnect/rest/')
-      rescue Faraday::ResourceNotFound => e
-        return e
-      rescue Faraday::ClientError => e
-        return e
-      end
+      connection.get('/cardconnect/rest/')
+    rescue Faraday::ResourceNotFound => e
+      return e
+    rescue Faraday::ClientError => e
+      return e
     end
-
   end
 end

data/lib/cardconnect/error.rb

@@ -1,3 +1,3 @@
 module CardConnect
   class Error < StandardError; end
-end
+end

data/lib/cardconnect/services/authorization/authorization.rb

@@ -1,7 +1,6 @@
 module CardConnect
   module Service
     class Authorization < ServiceEndpoint
-
       # Initializes an Authorization Service
       #
       # @param connection [CardConnect::Connection]
@@ -11,7 +10,6 @@ module CardConnect
         @resource_name = '/auth'
         @rest_method = 'put'
       end
-
     end
   end
-end
+end

data/lib/cardconnect/services/authorization/authorization_request.rb

@@ -3,15 +3,16 @@ module CardConnect
     class AuthorizationRequest
       include Utils
 
-      REQUIRED_FIELDS = [:merchid, :account, :expiry, :amount, :currency]
+      REQUIRED_FIELDS = [:merchid, :account, :expiry, :amount, :currency].freeze
 
       OPTIONAL_FIELDS = [:accttype, :name, :address, :city, :region, :country, :phone,
                          :postal, :email, :ecomind, :cvv2, :orderid, :track, :bankaba,
-                         :tokenize, :termid, :capture, :ssnl4, :license, :profile, :userfields]
+                         :tokenize, :termid, :capture, :ssnl4, :license, :profile, :userfields,
+                         :ponumber, :authcode, :invoiceid, :taxamnt].freeze
 
       FIELDS = REQUIRED_FIELDS + OPTIONAL_FIELDS
 
-      attr_accessor *FIELDS
+      attr_accessor(*FIELDS)
       attr_reader :errors
 
       # Initializes a new Authorization Request
@@ -33,7 +34,7 @@ module CardConnect
       def payload
         payload = {}
         FIELDS.each do |field|
-          payload.merge!({field => send(field)})
+          payload.merge!(field => send(field))
         end
         payload
       end
@@ -48,4 +49,4 @@ module CardConnect
       end
     end
   end
-end
+end

data/lib/cardconnect/services/authorization/authorization_response.rb

@@ -4,14 +4,14 @@ module CardConnect
       include Utils
 
       FIELDS = [:respstat, :retref, :account, :token, :amount, :merchid, :respcode,
-                :resptext, :respproc, :avsresp, :cvvresp, :authcode, :commcard]
+                :resptext, :respproc, :avsresp, :cvvresp, :authcode, :commcard, :profileid].freeze
 
-      attr_accessor *FIELDS
+      attr_accessor(*FIELDS)
       attr_reader :errors
 
-      STATUS_APPROVED = 'A'
-      STATUS_RETRY = 'B'
-      STATUS_DECLINED = 'C'
+      STATUS_APPROVED = 'A'.freeze
+      STATUS_RETRY = 'B'.freeze
+      STATUS_DECLINED = 'C'.freeze
 
       def initialize(response)
         set_attributes(response, FIELDS)
@@ -26,7 +26,7 @@ module CardConnect
       def body
         body = {}
         FIELDS.each do |attr|
-          body.merge!({attr => send(attr)})
+          body.merge!(attr => send(attr))
         end
         body
       end
@@ -38,4 +38,4 @@ module CardConnect
       end
     end
   end
-end
+end