cardconnect 1.0.0 → 1.1.0

data/test/cardconnect/connection_test.rb

@@ -16,7 +16,7 @@ describe CardConnect::Connection do
 
     it 'must have a URL that matches the configured endpoint' do
       @connection.url_prefix.host.must_equal URI.parse(CardConnect.configuration.endpoint).host
-      @connection.url_prefix.scheme.must_equal "https"
+      @connection.url_prefix.scheme.must_equal 'https'
     end
 
     describe 'Faraday handlers' do

data/test/cardconnect/services/authorization/authorization_request_test.rb

@@ -11,102 +11,118 @@ describe CardConnect::Service::AuthorizationRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal "000000927996"
+      @request.merchid.must_equal '000000927996'
     end
 
     it 'should have account' do
-      @request.account.must_equal "4111111111111111"
+      @request.account.must_equal '4111111111111111'
     end
 
     it 'should have expiry' do
-      @request.expiry.must_equal "1212"
+      @request.expiry.must_equal '1212'
     end
 
     it 'should have amount' do
-      @request.amount.must_equal "0"
+      @request.amount.must_equal '0'
     end
 
     it 'should have currency' do
-      @request.currency.must_equal "USD"
+      @request.currency.must_equal 'USD'
     end
 
     it 'should have account type' do
-      @request.accttype.must_equal "VISA"
+      @request.accttype.must_equal 'VISA'
     end
 
     it 'should have name' do
-      @request.name.must_equal "TOM JONES"
+      @request.name.must_equal 'TOM JONES'
     end
 
     it 'should have address' do
-      @request.address.must_equal "123 MAIN STREET"
+      @request.address.must_equal '123 MAIN STREET'
     end
 
     it 'should have city' do
-      @request.city.must_equal "anytown"
+      @request.city.must_equal 'anytown'
     end
 
     it 'should have country' do
-      @request.country.must_equal "US"
+      @request.country.must_equal 'US'
     end
 
     it 'should have phone' do
-      @request.phone.must_equal "3334445555"
+      @request.phone.must_equal '3334445555'
     end
 
     it 'should have postal' do
-      @request.postal.must_equal "55555"
+      @request.postal.must_equal '55555'
     end
 
     it 'should have email' do
-      @request.email.must_equal "tom@jones.com"
+      @request.email.must_equal 'tom@jones.com'
     end
 
     it 'should have ecomind' do
-      @request.ecomind.must_equal "E"
+      @request.ecomind.must_equal 'E'
     end
 
     it 'should have cvv2' do
-      @request.cvv2.must_equal "123"
+      @request.cvv2.must_equal '123'
     end
 
     it 'should have order id' do
-      @request.orderid.must_equal "AB-11-9876"
+      @request.orderid.must_equal 'AB-11-9876'
     end
 
     it 'should have track' do
-      @request.track.must_equal "Y"
+      @request.track.must_equal 'Y'
     end
 
     it 'should have bankaba' do
-      @request.bankaba.must_equal "1010101"
+      @request.bankaba.must_equal '1010101'
     end
 
     it 'should have tokenize' do
-      @request.tokenize.must_equal "Y"
+      @request.tokenize.must_equal 'Y'
     end
 
     it 'should have termid' do
-      @request.termid.must_equal "12345"
+      @request.termid.must_equal '12345'
     end
 
     it 'should have capture' do
-      @request.capture.must_equal "Y"
+      @request.capture.must_equal 'Y'
     end
 
     it 'should have ssnl4 field' do
-      @request.ssnl4.must_equal "1234"
+      @request.ssnl4.must_equal '1234'
     end
 
     it 'should have license field' do
-      @request.license.must_equal "CO:1231231234"
+      @request.license.must_equal 'CO:1231231234'
     end
 
     it 'should have profile field' do
-      @request.profile.must_equal "Y"
+      @request.profile.must_equal 'Y'
     end
 
-    describe "userfields" do
+    it 'should have ponumber field' do
+      @request.ponumber.must_equal '1234'
+    end
+
+    it 'should have authcode field' do
+      @request.authcode.must_equal '123456'
+    end
+
+    it 'should have invoiceid field' do
+      @request.invoiceid.must_equal '000000000001'
+    end
+
+    it 'should have taxamnt field' do
+      @request.taxamnt.must_equal '0'
+    end
+
+    describe 'userfields' do
       it 'should be an array of name-value pairs' do
         @request.userfields.must_be_kind_of Array
         @request.userfields.first.must_be_kind_of Hash
@@ -127,8 +143,9 @@ describe CardConnect::Service::AuthorizationRequest do
 
   describe '#errors' do
     CardConnect::Service::AuthorizationRequest::REQUIRED_FIELDS.each do |field|
-      it "should have an error message if #{field} is missing" do
-        CardConnect::Service::AuthorizationRequest.new.errors.must_include "#{field.to_s.capitalize} is missing"
+      field_name = field.to_s.capitalize
+      it "should have an error message if #{field_name} is missing" do
+        CardConnect::Service::AuthorizationRequest.new.errors.must_include "#{field_name} is missing"
       end
     end
   end

data/test/cardconnect/services/authorization/authorization_response_test.rb

@@ -11,55 +11,59 @@ describe CardConnect::Service::AuthorizationResponse do
 
   describe 'FIELDS' do
     it 'should have the merchant id' do
-      @response.merchid.must_equal "020594000000"
+      @response.merchid.must_equal '020594000000'
     end
 
     it 'should have the status' do
-      @response.respstat.must_equal "A"
+      @response.respstat.must_equal 'A'
     end
 
     it 'should have the Retrieval Reference Number' do
-      @response.retref.must_equal "343005123105"
+      @response.retref.must_equal '343005123105'
     end
 
     it 'should have the Account Number' do
-      @response.account.must_equal "41XXXXXXXXXX1111"
+      @response.account.must_equal '41XXXXXXXXXX1111'
     end
 
     it 'should have the Token' do
-      @response.token.must_equal "9419786452781111"
+      @response.token.must_equal '9419786452781111'
     end
 
     it 'should have the Amount' do
-      @response.amount.must_equal "111"
+      @response.amount.must_equal '111'
     end
 
     it 'should have the Response Code' do
-      @response.respcode.must_equal "00"
+      @response.respcode.must_equal '00'
     end
 
     it 'should have the Response text' do
-      @response.resptext.must_equal "Approved"
+      @response.resptext.must_equal 'Approved'
     end
 
     it 'should have the Response Processor' do
-      @response.respproc.must_equal "FNOR"
+      @response.respproc.must_equal 'FNOR'
     end
 
     it 'should have the AVS response code' do
-      @response.avsresp.must_equal "9"
+      @response.avsresp.must_equal '9'
     end
 
     it 'should have the CVV response code' do
-      @response.cvvresp.must_equal "M"
+      @response.cvvresp.must_equal 'M'
     end
 
     it 'should have the Authorization code' do
-      @response.authcode.must_equal "046221"
+      @response.authcode.must_equal '046221'
     end
 
     it 'should have the Commercial Card Flag' do
-      @response.commcard.must_equal "N"
+      @response.commcard.must_equal 'N'
+    end
+
+    it 'should have the profile id' do
+      @response.profileid.must_equal '12345678'
     end
   end
 
@@ -69,7 +73,8 @@ describe CardConnect::Service::AuthorizationResponse do
     end
 
     it 'should be false when there are errors' do
-      response = CardConnect::Service::AuthorizationResponse.new(valid_auth_response.merge!("respstat" => "B", "resptext" => "this is an error"))
+      auth_response = valid_auth_response.merge!('respstat' => 'B', 'resptext' => 'this is an error')
+      response = CardConnect::Service::AuthorizationResponse.new(auth_response)
       response.success?.must_equal false
     end
   end
@@ -80,14 +85,15 @@ describe CardConnect::Service::AuthorizationResponse do
     end
 
     it 'should be an array of error messages when there are errors' do
-      response = CardConnect::Service::AuthorizationResponse.new(valid_auth_response.merge!("respstat" => "B", "resptext" => "this is an error"))
-      response.errors.must_equal ["this is an error"]
+      auth_response = valid_auth_response.merge!('respstat' => 'B', 'resptext' => 'this is an error')
+      response = CardConnect::Service::AuthorizationResponse.new(auth_response)
+      response.errors.must_equal ['this is an error']
     end
   end
 
-  describe "#body" do
+  describe '#body' do
     it 'should generate hash with all the right values' do
       @response.body.must_equal symbolize_keys(valid_auth_response)
     end
   end
-end
+end

data/test/cardconnect/services/authorization/authorization_test.rb

@@ -26,15 +26,13 @@ describe CardConnect::Service::Authorization do
     end
 
     it 'uses the default merchant id if it is not passed in' do
-      @service.build_request(@valid_params.reject!{|k,v| k == 'merchid' })
+      @service.build_request(@valid_params.reject! { |k, _| k == 'merchid' })
       @service.request.merchid.must_equal 'merchant123'
     end
 
     it 'creates an Authorization request object with the right params' do
       @service.build_request(@valid_params)
-
       @service.request.must_be_kind_of CardConnect::Service::AuthorizationRequest
-
       @service.request.merchid.must_equal '000000927996'
       @service.request.account.must_equal '4111111111111111'
       @service.request.expiry.must_equal '1212'
@@ -55,5 +53,4 @@ describe CardConnect::Service::Authorization do
       @service.response.must_be_kind_of CardConnect::Service::AuthorizationResponse
     end
   end
-
 end

data/test/cardconnect/services/capture/capture_request_test.rb

@@ -11,31 +11,31 @@ describe CardConnect::Service::CaptureRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal "000000927996"
+      @request.merchid.must_equal '000000927996'
     end
 
     it 'should have retrieval reference number' do
-      @request.retref.must_equal "288002073633"
+      @request.retref.must_equal '288002073633'
     end
 
     it 'should have authorization code' do
-      @request.authcode.must_equal "046221"
+      @request.authcode.must_equal '046221'
     end
 
     it 'should have amount' do
-      @request.amount.must_equal "596.00"
+      @request.amount.must_equal '596.00'
     end
 
     it 'should have invoice id' do
-      @request.invoiceid.must_equal "7890"
+      @request.invoiceid.must_equal '7890'
     end
 
     it 'should have PO number' do
-      @request.ponumber.must_equal "PO-0736332"
+      @request.ponumber.must_equal 'PO-0736332'
     end
 
     it 'should have tax amount' do
-      @request.taxamnt.must_equal "40.00"
+      @request.taxamnt.must_equal '40.00'
     end
   end
 
@@ -57,7 +57,7 @@ describe CardConnect::Service::CaptureRequest do
     end
   end
 
-  describe "#payload" do
+  describe '#payload' do
     it 'should generate hash with all the right values' do
       @request.payload.must_equal symbolize_keys(valid_capture_request)
     end

data/test/cardconnect/services/capture/capture_response_test.rb

@@ -11,29 +11,29 @@ describe CardConnect::Service::CaptureResponse do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @response.merchid.must_equal "000000927996"
+      @response.merchid.must_equal '000000927996'
     end
 
     it 'should have account' do
-      @response.account.must_equal "41XXXXXXXXXX4113"
+      @response.account.must_equal '41XXXXXXXXXX4113'
     end
 
     it 'should have amount' do
-      @response.amount.must_equal "596.00"
+      @response.amount.must_equal '596.00'
     end
 
     it 'should have retrieval reference number' do
-      @response.retref.must_equal "288002073633"
+      @response.retref.must_equal '288002073633'
     end
 
     it 'should have settlement status' do
-      @response.setlstat.must_equal "Pending"
+      @response.setlstat.must_equal 'Pending'
     end
   end
 
-  describe "#body" do
+  describe '#body' do
     it 'should generate hash with all the right values' do
       @response.body.must_equal symbolize_keys(valid_capture_response)
     end
   end
-end
+end

data/test/cardconnect/services/capture/capture_test.rb

@@ -35,10 +35,8 @@ describe CardConnect::Service::Capture do
     end
 
     it 'uses default merchant ID if merchid is not passed in' do
-      @service.build_request(@valid_params.reject!{|k,v| k == 'merchid' })
-
+      @service.build_request(@valid_params.reject! { |k, _| k == 'merchid' })
       @service.request.must_be_kind_of CardConnect::Service::CaptureRequest
-
       @service.request.merchid.must_equal 'merchant123'
     end
   end

data/test/cardconnect/services/deposit/deposit_request_test.rb

@@ -11,11 +11,11 @@ describe CardConnect::Service::DepositRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal "000000927996"
+      @request.merchid.must_equal '000000927996'
     end
 
     it 'should have date' do
-      @request.date.must_equal "0110"
+      @request.date.must_equal '0110'
     end
   end
 
@@ -38,26 +38,26 @@ describe CardConnect::Service::DepositRequest do
 
     describe '#validate_date_format' do
       it 'should have an error when date is less than 4 characters long' do
-        request = CardConnect::Service::DepositRequest.new({date: '123'})
+        request = CardConnect::Service::DepositRequest.new(date: '123')
         request.valid?.must_equal false
-        request.errors.must_include "Date format is invalid. Please use MMDD format"
+        request.errors.must_include 'Date format is invalid. Please use MMDD format'
       end
 
       it 'should have an error when date is more than 4 characters long' do
-        request = CardConnect::Service::DepositRequest.new({date: '12345'})
+        request = CardConnect::Service::DepositRequest.new(date: '12345')
         request.valid?.must_equal false
-        request.errors.must_include "Date format is invalid. Please use MMDD format"
+        request.errors.must_include 'Date format is invalid. Please use MMDD format'
       end
 
       it 'should have an error when date is not parseable in MMDD format' do
-        request = CardConnect::Service::DepositRequest.new({date: '0000'})
+        request = CardConnect::Service::DepositRequest.new(date: '0000')
         request.valid?.must_equal false
-        request.errors.must_include "Date format is invalid. Please use MMDD format"
+        request.errors.must_include 'Date format is invalid. Please use MMDD format'
       end
     end
   end
 
-  describe "#payload" do
+  describe '#payload' do
     it 'should generate the correct path params' do
       @request.payload.must_equal "?merchid=#{@request.merchid}&date=#{@request.date}&"
     end

data/test/cardconnect/services/deposit/deposit_response_test.rb

@@ -14,62 +14,64 @@ describe CardConnect::Service::DepositResponse do
   end
 
   it 'should have the merchant id' do
-    @response.merchid.must_equal "000000927996"
+    @response.merchid.must_equal '000000927996'
   end
 
   it 'should have the respproc' do
-    @response.respproc.must_equal "FNOR"
+    @response.respproc.must_equal 'FNOR'
   end
 
   it 'should have the accttype' do
-    @response.accttype.must_equal "VI"
+    @response.accttype.must_equal 'VI'
   end
 
   it 'should have the action' do
-    @response.action.must_equal "DEB"
+    @response.action.must_equal 'DEB'
   end
 
   it 'should have the actdate' do
-    @response.actdate.must_equal "20121008"
+    @response.actdate.must_equal '20121008'
   end
 
   it 'should have the postdate' do
-    @response.postdate.must_equal "20121009"
+    @response.postdate.must_equal '20121009'
   end
 
   it 'should have the currency' do
-    @response.currency.must_equal "USD"
+    @response.currency.must_equal 'USD'
   end
 
   it 'should have the amount' do
-    @response.amount.must_equal "11.00"
+    @response.amount.must_equal '11.00'
   end
 
   it 'should have the feeamnt' do
-    @response.feeamnt.must_equal "0.55"
+    @response.feeamnt.must_equal '0.55'
   end
 
   it 'should have the cbakamnt' do
-    @response.cbakamnt.must_equal "0.00"
+    @response.cbakamnt.must_equal '0.00'
   end
 
   it 'should have the resptext' do
-    @response.resptext.must_equal "Successful or something"
+    @response.resptext.must_equal 'Successful or something'
   end
 
   it 'should have the transactions' do
-    @response.txns.must_equal [{merchbatch: 92821429, retref: "282005142924", hostbatch: "1429", feeamnt: "0.00", action: "DEB", depamnt: "11.00"}]
+    @response.txns.must_equal [{ merchbatch: 92821429, retref: '282005142924', hostbatch: '1429',
+                                 feeamnt: '0.00', action: 'DEB', depamnt: '11.00' }]
   end
 
   describe '#body' do
     it 'should have all the right fields in the body' do
-      @response.body.keys.must_equal [:depositid, :merchid, :respproc, :accttype, :action, :actdate, :postdate, :currency, :amount, :feeamnt, :cbakamnt, :resptext, :txns]
+      @response.body.keys.must_equal [:depositid, :merchid, :respproc, :accttype, :action, :actdate,
+                                      :postdate, :currency, :amount, :feeamnt, :cbakamnt, :resptext, :txns]
     end
 
     it 'should generate hash with all the right values' do
       valid_payload = symbolize_keys(valid_deposit_response.first)
-      valid_payload[:txns] = valid_payload[:txns].map{|txn| symbolize_keys(txn)}
+      valid_payload[:txns] = valid_payload[:txns].map { |txn| symbolize_keys(txn) }
       @response.body.must_equal valid_payload
     end
   end
-end
+end