cardconnect 1.0.0 → 1.1.0

data/test/cardconnect/services/deposit/deposit_test.rb

@@ -29,14 +29,14 @@ describe CardConnect::Service::Deposit do
       @service.build_request(@valid_params)
 
       @service.request.must_be_kind_of CardConnect::Service::DepositRequest
-      @service.request.merchid.must_equal "000000927996"
-      @service.request.date.must_equal "0110"
+      @service.request.merchid.must_equal '000000927996'
+      @service.request.date.must_equal '0110'
     end
 
     it 'uses default merchant ID if merchid is not passed in' do
-      @service.build_request(@valid_params.reject!{|k,v| k == 'merchid' })
+      @service.build_request(@valid_params.reject! { |k, _| k == 'merchid' })
       @service.request.must_be_kind_of CardConnect::Service::DepositRequest
-      @service.request.merchid.must_equal "merchant123"
+      @service.request.merchid.must_equal 'merchant123'
     end
   end
 

data/test/cardconnect/services/inquire/inquire_request_test.rb

@@ -11,11 +11,11 @@ describe CardConnect::Service::InquireRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal "000000927996"
+      @request.merchid.must_equal '000000927996'
     end
 
     it 'should have retrieval reference number' do
-      @request.retref.must_equal "288002073633"
+      @request.retref.must_equal '288002073633'
     end
   end
 
@@ -37,7 +37,7 @@ describe CardConnect::Service::InquireRequest do
     end
   end
 
-  describe "#payload" do
+  describe '#payload' do
     it 'should generate the correct path params' do
       @request.payload.must_equal '/288002073633/000000927996'
     end

data/test/cardconnect/services/inquire/inquire_response_test.rb

@@ -11,49 +11,49 @@ describe CardConnect::Service::InquireResponse do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @response.merchid.must_equal "000000927996"
+      @response.merchid.must_equal '000000927996'
     end
 
     it 'should have account' do
-      @response.account.must_equal "41XXXXXXXXXX4113"
+      @response.account.must_equal '41XXXXXXXXXX4113'
     end
 
     it 'should have amount' do
-      @response.amount.must_equal "596.00"
+      @response.amount.must_equal '596.00'
     end
 
     it 'should have currency' do
-      @response.currency.must_equal "USD"
+      @response.currency.must_equal 'USD'
     end
 
     it 'should have retrieval reference number' do
-      @response.retref.must_equal "288015190411"
+      @response.retref.must_equal '288015190411'
     end
 
     it 'should have response code' do
-      @response.respcode.must_equal "00"
+      @response.respcode.must_equal '00'
     end
 
     it 'should have response processor' do
-      @response.respproc.must_equal "FNOR"
+      @response.respproc.must_equal 'FNOR'
     end
 
     it 'should have response status' do
-      @response.respstat.must_equal "A"
+      @response.respstat.must_equal 'A'
     end
 
     it 'should have capture status' do
-      @response.resptext.must_equal "Approval"
+      @response.resptext.must_equal 'Approval'
     end
 
     it 'should have settlement status' do
-      @response.setlstat.must_equal "NOTCAPTURED"
+      @response.setlstat.must_equal 'NOTCAPTURED'
     end
   end
 
-  describe "#body" do
+  describe '#body' do
     it 'should generate hash with all the right values' do
       @response.body.must_equal symbolize_keys(valid_inquire_response)
     end
   end
-end
+end

data/test/cardconnect/services/inquire/inquire_test.rb

@@ -3,7 +3,7 @@ require 'test_helper'
 describe CardConnect::Service::Inquire do
   before do
     @connection = CardConnect::Connection.new.connection do |stubs|
-      path = @service.path + "/#{valid_inquire_request['retref']}/#{valid_inquire_request['merchid']}"
+      path = "#{@service.path}/#{valid_inquire_request['retref']}/#{valid_inquire_request['merchid']}"
       stubs.get(path) { [200, {}, valid_inquire_response] }
     end
     @service = CardConnect::Service::Inquire.new(@connection)
@@ -30,14 +30,14 @@ describe CardConnect::Service::Inquire do
       @service.build_request(@valid_params)
 
       @service.request.must_be_kind_of CardConnect::Service::InquireRequest
-      @service.request.retref.must_equal "288002073633"
-      @service.request.merchid.must_equal "000000927996"
+      @service.request.retref.must_equal '288002073633'
+      @service.request.merchid.must_equal '000000927996'
     end
 
     it 'uses default merchant ID if merchid is not passed in' do
-      @service.build_request(@valid_params.reject!{|k,v| k == 'merchid' })
+      @service.build_request(@valid_params.reject! { |k, _| k == 'merchid' })
       @service.request.must_be_kind_of CardConnect::Service::InquireRequest
-      @service.request.merchid.must_equal "merchant123"
+      @service.request.merchid.must_equal 'merchant123'
     end
   end
 

data/test/cardconnect/services/refund/refund_request_test.rb

@@ -11,15 +11,15 @@ describe CardConnect::Service::RefundRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal "000000927996"
+      @request.merchid.must_equal '000000927996'
     end
 
     it 'should have retrieval reference number' do
-      @request.retref.must_equal "288009185241"
+      @request.retref.must_equal '288009185241'
     end
 
     it 'should have amount' do
-      @request.amount.must_equal "59.60"
+      @request.amount.must_equal '59.60'
     end
   end
 

data/test/cardconnect/services/refund/refund_response_test.rb

@@ -11,35 +11,35 @@ describe CardConnect::Service::RefundResponse do
 
   describe 'FIELDS' do
     it 'should have the merchant id' do
-      @response.merchid.must_equal "000000927996"
+      @response.merchid.must_equal '000000927996'
     end
 
     it 'should have the Amount' do
-      @response.amount.must_equal "59.60"
+      @response.amount.must_equal '59.60'
     end
 
     it 'should have the Retrieval Reference Number' do
-      @response.retref.must_equal "288010185242"
+      @response.retref.must_equal '288010185242'
     end
 
     it 'should have the Response Code' do
-      @response.respcode.must_equal "00"
+      @response.respcode.must_equal '00'
     end
 
     it 'should have the Response Processor' do
-      @response.respproc.must_equal "PPS"
+      @response.respproc.must_equal 'PPS'
     end
 
     it 'should have the status' do
-      @response.respstat.must_equal "A"
+      @response.respstat.must_equal 'A'
     end
 
     it 'should have the Response text' do
-      @response.resptext.must_equal "Approval"
+      @response.resptext.must_equal 'Approval'
     end
 
     it 'should have authcode' do
-      @response.authcode.must_equal "REFUND"
+      @response.authcode.must_equal 'REFUND'
     end
   end
 
@@ -49,7 +49,8 @@ describe CardConnect::Service::RefundResponse do
     end
 
     it 'should be false when there are errors' do
-      response = CardConnect::Service::RefundResponse.new(valid_refund_response.merge!("respstat" => "C", "resptext" => "this is an error"))
+      refund_response = valid_refund_response.merge!('respstat' => 'C', 'resptext' => 'this is an error')
+      response = CardConnect::Service::RefundResponse.new(refund_response)
       response.success?.must_equal false
     end
   end
@@ -60,14 +61,15 @@ describe CardConnect::Service::RefundResponse do
     end
 
     it 'should be an array of error messages when there are errors' do
-      response = CardConnect::Service::RefundResponse.new(valid_refund_response.merge!("respstat" => "C", "resptext" => "this is an error"))
-      response.errors.must_equal ["this is an error"]
+      refund_response = valid_refund_response.merge!('respstat' => 'C', 'resptext' => 'this is an error')
+      response = CardConnect::Service::RefundResponse.new(refund_response)
+      response.errors.must_equal ['this is an error']
     end
   end
 
-  describe "#body" do
+  describe '#body' do
     it 'should generate hash with all the right values' do
       @response.body.must_equal symbolize_keys(valid_refund_response)
     end
   end
-end
+end

data/test/cardconnect/services/refund/refund_test.rb

@@ -26,7 +26,7 @@ describe CardConnect::Service::Refund do
     end
 
     it 'uses the default merchant id if it is not passed in' do
-      @service.build_request(@valid_params.reject!{|k,v| k == 'merchid' })
+      @service.build_request(@valid_params.reject! { |k, _| k == 'merchid' })
       @service.request.merchid.must_equal 'merchant123'
     end
 
@@ -53,5 +53,4 @@ describe CardConnect::Service::Refund do
       @service.response.must_be_kind_of CardConnect::Service::RefundResponse
     end
   end
-
 end

data/test/cardconnect/services/settlement_status/settlement_status_request_test.rb

@@ -11,11 +11,11 @@ describe CardConnect::Service::SettlementStatusRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal "000000927996"
+      @request.merchid.must_equal '000000927996'
     end
 
     it 'should have retrieval reference number' do
-      @request.date.must_equal "0110"
+      @request.date.must_equal '0110'
     end
   end
 
@@ -31,33 +31,34 @@ describe CardConnect::Service::SettlementStatusRequest do
 
   describe '#errors' do
     CardConnect::Service::SettlementStatusRequest::REQUIRED_FIELDS.each do |field|
-      it "should have an error message if #{field} is missing" do
-        CardConnect::Service::SettlementStatusRequest.new.errors.must_include "#{field.to_s.capitalize} is missing"
+      field_name = field.to_s.capitalize
+      it "should have an error message if #{field_name} is missing" do
+        CardConnect::Service::SettlementStatusRequest.new.errors.must_include "#{field_name} is missing"
       end
     end
 
     describe '#validate_date_format' do
       it 'should have an error when date is less than 4 characters long' do
-        request = CardConnect::Service::SettlementStatusRequest.new({date: '123'})
+        request = CardConnect::Service::SettlementStatusRequest.new(date: '123')
         request.valid?.must_equal false
-        request.errors.must_include "Date format is invalid. Please use MMDD format"
+        request.errors.must_include 'Date format is invalid. Please use MMDD format'
       end
 
       it 'should have an error when date is more than 4 characters long' do
-        request = CardConnect::Service::SettlementStatusRequest.new({date: '12345'})
+        request = CardConnect::Service::SettlementStatusRequest.new(date: '12345')
         request.valid?.must_equal false
-        request.errors.must_include "Date format is invalid. Please use MMDD format"
+        request.errors.must_include 'Date format is invalid. Please use MMDD format'
       end
 
       it 'should have an error when date is not parseable in MMDD format' do
-        request = CardConnect::Service::SettlementStatusRequest.new({date: '0000'})
+        request = CardConnect::Service::SettlementStatusRequest.new(date: '0000')
         request.valid?.must_equal false
-        request.errors.must_include "Date format is invalid. Please use MMDD format"
+        request.errors.must_include 'Date format is invalid. Please use MMDD format'
       end
     end
   end
 
-  describe "#payload" do
+  describe '#payload' do
     it 'should generate the correct path params' do
       @request.payload.must_equal "?merchid=#{@request.merchid}&date=#{@request.date}&"
     end

data/test/cardconnect/services/settlement_status/settlement_status_response_test.rb

@@ -10,27 +10,28 @@ describe CardConnect::Service::SettlementStatusResponse do
   end
 
   it 'should have the merchant id' do
-    @response.merchid.must_equal "000000927996"
+    @response.merchid.must_equal '000000927996'
   end
 
   it 'should have the batch id' do
-    @response.batchid.must_equal "71742042"
+    @response.batchid.must_equal '71742042'
   end
 
   it 'should have the settlement status' do
-    @response.hoststat.must_equal "GB"
+    @response.hoststat.must_equal 'GB'
   end
 
   it 'should have the host batch id' do
-    @response.hostbatch.must_equal "71742041"
+    @response.hostbatch.must_equal '71742041'
   end
 
   it 'should have the clearing house' do
-    @response.respproc.must_equal "FNOR"
+    @response.respproc.must_equal 'FNOR'
   end
 
   it 'should have the transactions' do
-    @response.txns.must_equal [{setlstat: "N", retref: "179001161341"}, {setlstat: "Y", retref: "179002161341"}]
+    @response.txns.must_equal [{ setlstat: 'N', retref: '179001161341' },
+                               { setlstat: 'Y', retref: '179002161341' }]
   end
 
   describe '#body' do
@@ -40,8 +41,8 @@ describe CardConnect::Service::SettlementStatusResponse do
 
     it 'should generate hash with all the right values' do
       valid_payload = symbolize_keys(valid_settlestat_response.first)
-      valid_payload[:txns] = valid_payload[:txns].map{|txn| symbolize_keys(txn)}
+      valid_payload[:txns] = valid_payload[:txns].map { |txn| symbolize_keys(txn) }
       @response.body.must_equal valid_payload
     end
   end
-end
+end

data/test/cardconnect/services/settlement_status/settlement_status_test.rb

@@ -29,14 +29,14 @@ describe CardConnect::Service::SettlementStatus do
       @service.build_request(@valid_params)
 
       @service.request.must_be_kind_of CardConnect::Service::SettlementStatusRequest
-      @service.request.merchid.must_equal "000000927996"
-      @service.request.date.must_equal "0110"
+      @service.request.merchid.must_equal '000000927996'
+      @service.request.date.must_equal '0110'
     end
 
     it 'uses default merchant ID if merchid is not passed in' do
-      @service.build_request(@valid_params.reject!{|k,v| k == 'merchid' })
+      @service.build_request(@valid_params.reject! { |k, _| k == 'merchid' })
       @service.request.must_be_kind_of CardConnect::Service::SettlementStatusRequest
-      @service.request.merchid.must_equal "merchant123"
+      @service.request.merchid.must_equal 'merchant123'
     end
   end
 

data/test/cardconnect/services/void/void_request_test.rb

@@ -11,15 +11,15 @@ describe CardConnect::Service::VoidRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal "000000927996"
+      @request.merchid.must_equal '000000927996'
     end
 
     it 'should have retrieval reference number' do
-      @request.retref.must_equal "288013185633"
+      @request.retref.must_equal '288013185633'
     end
 
     it 'should have amount' do
-      @request.amount.must_equal "101"
+      @request.amount.must_equal '101'
     end
   end
 

data/test/cardconnect/services/void/void_response_test.rb

@@ -11,39 +11,39 @@ describe CardConnect::Service::VoidResponse do
 
   describe 'FIELDS' do
     it 'should have the merchant id' do
-      @response.merchid.must_equal "000000927996"
+      @response.merchid.must_equal '000000927996'
     end
 
     it 'should have the Amount' do
-      @response.amount.must_equal "1.01"
+      @response.amount.must_equal '1.01'
     end
 
     it 'should have the currency' do
-      @response.currency.must_equal "USD"
+      @response.currency.must_equal 'USD'
     end
 
     it 'should have the Retrieval Reference Number' do
-      @response.retref.must_equal "288013185633"
+      @response.retref.must_equal '288013185633'
     end
 
     it 'should have the authcode' do
-      @response.authcode.must_equal "REVERS"
+      @response.authcode.must_equal 'REVERS'
     end
 
     it 'should have the Response Code' do
-      @response.respcode.must_equal "00"
+      @response.respcode.must_equal '00'
     end
 
     it 'should have the Response Processor' do
-      @response.respproc.must_equal "FNOR"
+      @response.respproc.must_equal 'FNOR'
     end
 
     it 'should have the status' do
-      @response.respstat.must_equal "A"
+      @response.respstat.must_equal 'A'
     end
 
     it 'should have the Response text' do
-      @response.resptext.must_equal "Approval"
+      @response.resptext.must_equal 'Approval'
     end
   end
 
@@ -53,7 +53,8 @@ describe CardConnect::Service::VoidResponse do
     end
 
     it 'should be false when there are errors' do
-      response = CardConnect::Service::VoidResponse.new(valid_void_response.merge!("respstat" => "C", "resptext" => "this is an error"))
+      void_response = valid_void_response.merge!('respstat' => 'C', 'resptext' => 'this is an error')
+      response = CardConnect::Service::VoidResponse.new(void_response)
       response.success?.must_equal false
     end
   end
@@ -64,14 +65,15 @@ describe CardConnect::Service::VoidResponse do
     end
 
     it 'should be an array of error messages when there are errors' do
-      response = CardConnect::Service::VoidResponse.new(valid_void_response.merge!("respstat" => "C", "resptext" => "this is an error"))
-      response.errors.must_equal ["this is an error"]
+      void_response = valid_void_response.merge!('respstat' => 'C', 'resptext' => 'this is an error')
+      response = CardConnect::Service::VoidResponse.new(void_response)
+      response.errors.must_equal ['this is an error']
     end
   end
 
-  describe "#body" do
+  describe '#body' do
     it 'should generate hash with all the right values' do
       @response.body.must_equal symbolize_keys(valid_void_response)
     end
   end
-end
+end