cardconnect 2.3.0 → 2.4.0

data/test/cardconnect/services/refund/refund_response_test.rb

@@ -11,65 +11,65 @@ describe CardConnect::Service::RefundResponse do
 
   describe 'FIELDS' do
     it 'should have the merchant id' do
-      @response.merchid.must_equal '000000927996'
+      _(@response.merchid).must_equal '000000927996'
     end
 
     it 'should have the Amount' do
-      @response.amount.must_equal '59.60'
+      _(@response.amount).must_equal '59.60'
     end
 
     it 'should have the Retrieval Reference Number' do
-      @response.retref.must_equal '288010185242'
+      _(@response.retref).must_equal '288010185242'
     end
 
     it 'should have the Response Code' do
-      @response.respcode.must_equal '00'
+      _(@response.respcode).must_equal '00'
     end
 
     it 'should have the Response Processor' do
-      @response.respproc.must_equal 'PPS'
+      _(@response.respproc).must_equal 'PPS'
     end
 
     it 'should have the status' do
-      @response.respstat.must_equal 'A'
+      _(@response.respstat).must_equal 'A'
     end
 
     it 'should have the Response text' do
-      @response.resptext.must_equal 'Approval'
+      _(@response.resptext).must_equal 'Approval'
     end
 
     it 'should have authcode' do
-      @response.authcode.must_equal 'REFUND'
+      _(@response.authcode).must_equal 'REFUND'
     end
   end
 
   describe '#success?' do
     it 'should be true when there are no errors' do
-      @response.success?.must_equal true
+      _(@response.success?).must_equal true
     end
 
     it 'should be false when there are errors' do
       refund_response = valid_refund_response.merge!('respstat' => 'C', 'resptext' => 'this is an error')
       response = CardConnect::Service::RefundResponse.new(refund_response)
-      response.success?.must_equal false
+      _(response.success?).must_equal false
     end
   end
 
   describe '#errors' do
     it 'should be empty when there are no errors' do
-      @response.errors.must_be_empty
+      _(@response.errors).must_be_empty
     end
 
     it 'should be an array of error messages when there are errors' do
       refund_response = valid_refund_response.merge!('respstat' => 'C', 'resptext' => 'this is an error')
       response = CardConnect::Service::RefundResponse.new(refund_response)
-      response.errors.must_equal ['this is an error']
+      _(response.errors).must_equal ['this is an error']
     end
   end
 
   describe '#body' do
     it 'should generate hash with all the right values' do
-      @response.body.must_equal symbolize_keys(valid_refund_response)
+      _(@response.body).must_equal symbolize_keys(valid_refund_response)
     end
   end
 end

data/test/cardconnect/services/refund/refund_test.rb

@@ -13,7 +13,7 @@ describe CardConnect::Service::Refund do
   end
 
   it 'must have the right path' do
-    @service.path.must_equal '/cardconnect/rest/refund'
+    _(@service.path).must_equal '/cardconnect/rest/refund'
   end
 
   describe '#build_request' do
@@ -27,30 +27,30 @@ describe CardConnect::Service::Refund do
 
     it 'uses the default merchant id if it is not passed in' do
       @service.build_request(@valid_params.reject! { |k, _| k == 'merchid' })
-      @service.request.merchid.must_equal 'merchant123'
+      _(@service.request.merchid).must_equal 'merchant123'
     end
 
     it 'creates an Authorization request object with the right params' do
       @service.build_request(@valid_params)
 
-      @service.request.must_be_kind_of CardConnect::Service::RefundRequest
+      _(@service.request).must_be_kind_of CardConnect::Service::RefundRequest
 
-      @service.request.merchid.must_equal '000000927996'
-      @service.request.retref.must_equal '288009185241'
-      @service.request.amount.must_equal '59.60'
+      _(@service.request.merchid).must_equal '000000927996'
+      _(@service.request.retref).must_equal '288009185241'
+      _(@service.request.amount).must_equal '59.60'
     end
   end
 
   describe '#submit' do
     it 'raises an error when there is no request' do
-      @service.request.nil?.must_equal true
-      proc { @service.submit }.must_raise CardConnect::Error
+      _(@service.request.nil?).must_equal true
+      _(proc { @service.submit }).must_raise CardConnect::Error
     end
 
     it 'creates a response when a valid request is processed' do
       @service.build_request(valid_refund_request)
       @service.submit
-      @service.response.must_be_kind_of CardConnect::Service::RefundResponse
+      _(@service.response).must_be_kind_of CardConnect::Service::RefundResponse
     end
   end
 end

data/test/cardconnect/services/settlement_status/settlement_status_request_test.rb

@@ -11,21 +11,21 @@ describe CardConnect::Service::SettlementStatusRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal '000000927996'
+      _(@request.merchid).must_equal '000000927996'
     end
 
     it 'should have retrieval reference number' do
-      @request.date.must_equal '0110'
+      _(@request.date).must_equal '0110'
     end
   end
 
   describe '#valid?' do
     it 'should not be valid if no attributes are passed in' do
-      CardConnect::Service::SettlementStatusRequest.new.valid?.must_equal false
+      _(CardConnect::Service::SettlementStatusRequest.new.valid?).must_equal false
     end
 
     it 'should be valid if valid attributes are passed in' do
-      CardConnect::Service::SettlementStatusRequest.new(valid_settlestat_request).valid?.must_equal true
+      _(CardConnect::Service::SettlementStatusRequest.new(valid_settlestat_request).valid?).must_equal true
     end
   end
 
@@ -33,34 +33,34 @@ describe CardConnect::Service::SettlementStatusRequest do
     CardConnect::Service::SettlementStatusRequest::REQUIRED_FIELDS.each do |field|
       field_name = field.to_s.capitalize
       it "should have an error message if #{field_name} is missing" do
-        CardConnect::Service::SettlementStatusRequest.new.errors.must_include "#{field_name} is missing"
+        _(CardConnect::Service::SettlementStatusRequest.new.errors).must_include "#{field_name} is missing"
       end
     end
 
     describe '#validate_date_format' do
       it 'should have an error when date is less than 4 characters long' do
         request = CardConnect::Service::SettlementStatusRequest.new(date: '123')
-        request.valid?.must_equal false
-        request.errors.must_include 'Date format is invalid. Please use MMDD format'
+        _(request.valid?).must_equal false
+        _(request.errors).must_include 'Date format is invalid. Please use MMDD format'
       end
 
       it 'should have an error when date is more than 4 characters long' do
         request = CardConnect::Service::SettlementStatusRequest.new(date: '12345')
-        request.valid?.must_equal false
-        request.errors.must_include 'Date format is invalid. Please use MMDD format'
+        _(request.valid?).must_equal false
+        _(request.errors).must_include 'Date format is invalid. Please use MMDD format'
       end
 
       it 'should have an error when date is not parseable in MMDD format' do
         request = CardConnect::Service::SettlementStatusRequest.new(date: '0000')
-        request.valid?.must_equal false
-        request.errors.must_include 'Date format is invalid. Please use MMDD format'
+        _(request.valid?).must_equal false
+        _(request.errors).must_include 'Date format is invalid. Please use MMDD format'
       end
     end
   end
 
   describe '#payload' do
     it 'should generate the correct path params' do
-      @request.payload.must_equal "?merchid=#{@request.merchid}&date=#{@request.date}&"
+      _(@request.payload).must_equal "?merchid=#{@request.merchid}&date=#{@request.date}&"
     end
   end
 end

data/test/cardconnect/services/settlement_status/settlement_status_response_test.rb

@@ -10,39 +10,39 @@ describe CardConnect::Service::SettlementStatusResponse do
   end
 
   it 'should have the merchant id' do
-    @response.merchid.must_equal '000000927996'
+    _(@response.merchid).must_equal '000000927996'
   end
 
   it 'should have the batch id' do
-    @response.batchid.must_equal '71742042'
+    _(@response.batchid).must_equal '71742042'
   end
 
   it 'should have the settlement status' do
-    @response.hoststat.must_equal 'GB'
+    _(@response.hoststat).must_equal 'GB'
   end
 
   it 'should have the host batch id' do
-    @response.hostbatch.must_equal '71742041'
+    _(@response.hostbatch).must_equal '71742041'
   end
 
   it 'should have the clearing house' do
-    @response.respproc.must_equal 'FNOR'
+    _(@response.respproc).must_equal 'FNOR'
   end
 
   it 'should have the transactions' do
-    @response.txns.must_equal [{ setlstat: 'N', retref: '179001161341' },
+    _(@response.txns).must_equal [{ setlstat: 'N', retref: '179001161341' },
                                { setlstat: 'Y', retref: '179002161341' }]
   end
 
   describe '#body' do
     it 'should have all the right fields in the body' do
-      @response.body.keys.must_equal [:merchid, :batchid, :hoststat, :hostbatch, :respproc, :txns]
+      _(@response.body.keys).must_equal [:merchid, :batchid, :hoststat, :hostbatch, :respproc, :txns]
     end
 
     it 'should generate hash with all the right values' do
       valid_payload = symbolize_keys(valid_settlestat_response.first)
       valid_payload[:txns] = valid_payload[:txns].map { |txn| symbolize_keys(txn) }
-      @response.body.must_equal valid_payload
+      _(@response.body).must_equal valid_payload
     end
   end
 end

data/test/cardconnect/services/settlement_status/settlement_status_test.rb

@@ -13,7 +13,7 @@ describe CardConnect::Service::SettlementStatus do
   end
 
   it 'must have the right path' do
-    @service.path.must_equal '/cardconnect/rest/settlestat'
+    _(@service.path).must_equal '/cardconnect/rest/settlestat'
   end
 
   describe '#build_request' do
@@ -28,28 +28,28 @@ describe CardConnect::Service::SettlementStatus do
     it 'creates a Capture request object with the passed in params' do
       @service.build_request(@valid_params)
 
-      @service.request.must_be_kind_of CardConnect::Service::SettlementStatusRequest
-      @service.request.merchid.must_equal '000000927996'
-      @service.request.date.must_equal '0110'
+      _(@service.request).must_be_kind_of CardConnect::Service::SettlementStatusRequest
+      _(@service.request.merchid).must_equal '000000927996'
+      _(@service.request.date).must_equal '0110'
     end
 
     it 'uses default merchant ID if merchid is not passed in' do
       @service.build_request(@valid_params.reject! { |k, _| k == 'merchid' })
-      @service.request.must_be_kind_of CardConnect::Service::SettlementStatusRequest
-      @service.request.merchid.must_equal 'merchant123'
+      _(@service.request).must_be_kind_of CardConnect::Service::SettlementStatusRequest
+      _(@service.request.merchid).must_equal 'merchant123'
     end
   end
 
   describe '#submit' do
     it 'raises an error when there is no request' do
-      @service.request.nil?.must_equal true
-      proc { @service.submit }.must_raise CardConnect::Error
+      _(@service.request.nil?).must_equal true
+      _(proc { @service.submit }).must_raise CardConnect::Error
     end
 
     it 'creates a response when a valid request is processed' do
       @service.build_request(valid_settlestat_request)
       @service.submit
-      @service.response.must_be_kind_of CardConnect::Service::SettlementStatusResponse
+      _(@service.response).must_be_kind_of CardConnect::Service::SettlementStatusResponse
     end
   end
 end

data/test/cardconnect/services/void/void_request_test.rb

@@ -11,39 +11,39 @@ describe CardConnect::Service::VoidRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal '000000927996'
+      _(@request.merchid).must_equal '000000927996'
     end
 
     it 'should have retrieval reference number' do
-      @request.retref.must_equal '288013185633'
+      _(@request.retref).must_equal '288013185633'
     end
 
     it 'should have amount' do
-      @request.amount.must_equal '101'
+      _(@request.amount).must_equal '101'
     end
   end
 
   describe '#valid?' do
     it 'should not be valid if no attributes are passed in' do
-      CardConnect::Service::VoidRequest.new.valid?.must_equal false
+      _(CardConnect::Service::VoidRequest.new.valid?).must_equal false
     end
 
     it 'should be valid if valid attributes are passed in' do
-      CardConnect::Service::VoidRequest.new(valid_void_request).valid?.must_equal true
+      _(CardConnect::Service::VoidRequest.new(valid_void_request).valid?).must_equal true
     end
   end
 
   describe '#errors' do
     CardConnect::Service::VoidRequest::REQUIRED_FIELDS.each do |field|
       it "should have an error message if #{field} is missing" do
-        CardConnect::Service::VoidRequest.new.errors.must_include "#{field.to_s.capitalize} is missing"
+        _(CardConnect::Service::VoidRequest.new.errors).must_include "#{field.to_s.capitalize} is missing"
       end
     end
   end
 
   describe '#payload' do
     it 'should generate hash with all the right values' do
-      @request.payload.must_equal symbolize_keys(valid_void_request)
+      _(@request.payload).must_equal symbolize_keys(valid_void_request)
     end
   end
 end

data/test/cardconnect/services/void/void_response_test.rb

@@ -11,69 +11,69 @@ describe CardConnect::Service::VoidResponse do
 
   describe 'FIELDS' do
     it 'should have the merchant id' do
-      @response.merchid.must_equal '000000927996'
+      _(@response.merchid).must_equal '000000927996'
     end
 
     it 'should have the Amount' do
-      @response.amount.must_equal '1.01'
+      _(@response.amount).must_equal '1.01'
     end
 
     it 'should have the currency' do
-      @response.currency.must_equal 'USD'
+      _(@response.currency).must_equal 'USD'
     end
 
     it 'should have the Retrieval Reference Number' do
-      @response.retref.must_equal '288013185633'
+      _(@response.retref).must_equal '288013185633'
     end
 
     it 'should have the authcode' do
-      @response.authcode.must_equal 'REVERS'
+      _(@response.authcode).must_equal 'REVERS'
     end
 
     it 'should have the Response Code' do
-      @response.respcode.must_equal '00'
+      _(@response.respcode).must_equal '00'
     end
 
     it 'should have the Response Processor' do
-      @response.respproc.must_equal 'FNOR'
+      _(@response.respproc).must_equal 'FNOR'
     end
 
     it 'should have the status' do
-      @response.respstat.must_equal 'A'
+      _(@response.respstat).must_equal 'A'
     end
 
     it 'should have the Response text' do
-      @response.resptext.must_equal 'Approval'
+      _(@response.resptext).must_equal 'Approval'
     end
   end
 
   describe '#success?' do
     it 'should be true when there are no errors' do
-      @response.success?.must_equal true
+      _(@response.success?).must_equal true
     end
 
     it 'should be false when there are errors' do
       void_response = valid_void_response.merge!('respstat' => 'C', 'resptext' => 'this is an error')
       response = CardConnect::Service::VoidResponse.new(void_response)
-      response.success?.must_equal false
+      _(response.success?).must_equal false
     end
   end
 
   describe '#errors' do
     it 'should be empty when there are no errors' do
-      @response.errors.must_be_empty
+      _(@response.errors).must_be_empty
     end
 
     it 'should be an array of error messages when there are errors' do
       void_response = valid_void_response.merge!('respstat' => 'C', 'resptext' => 'this is an error')
       response = CardConnect::Service::VoidResponse.new(void_response)
-      response.errors.must_equal ['this is an error']
+      _(response.errors).must_equal ['this is an error']
     end
   end
 
   describe '#body' do
     it 'should generate hash with all the right values' do
-      @response.body.must_equal symbolize_keys(valid_void_response)
+      _(@response.body).must_equal symbolize_keys(valid_void_response)
     end
   end
 end

data/test/cardconnect/services/void/void_test.rb

@@ -13,7 +13,7 @@ describe CardConnect::Service::Void do
   end
 
   it 'must have the right path' do
-    @service.path.must_equal '/cardconnect/rest/void'
+    _(@service.path).must_equal '/cardconnect/rest/void'
   end
 
   describe '#build_request' do
@@ -27,30 +27,30 @@ describe CardConnect::Service::Void do
 
     it 'uses the default merchant id if it is not passed in' do
       @service.build_request(@valid_params.reject! { |k, _| k == 'merchid' })
-      @service.request.merchid.must_equal 'merchant123'
+      _(@service.request.merchid).must_equal 'merchant123'
     end
 
     it 'creates an Authorization request object with the right params' do
       @service.build_request(@valid_params)
 
-      @service.request.must_be_kind_of CardConnect::Service::VoidRequest
+      _(@service.request).must_be_kind_of CardConnect::Service::VoidRequest
 
-      @service.request.merchid.must_equal '000000927996'
-      @service.request.retref.must_equal '288013185633'
-      @service.request.amount.must_equal '101'
+      _(@service.request.merchid).must_equal '000000927996'
+      _(@service.request.retref).must_equal '288013185633'
+      _(@service.request.amount).must_equal '101'
     end
   end
 
   describe '#submit' do
     it 'raises an error when there is no request' do
-      @service.request.nil?.must_equal true
-      proc { @service.submit }.must_raise CardConnect::Error
+      _(@service.request.nil?).must_equal true
+      _(proc { @service.submit }).must_raise CardConnect::Error
     end
 
     it 'creates a response when a valid request is processed' do
       @service.build_request(valid_void_request)
       @service.submit
-      @service.response.must_be_kind_of CardConnect::Service::VoidResponse
+      _(@service.response).must_be_kind_of CardConnect::Service::VoidResponse
     end
   end
 end

data/test/cardconnect_test.rb

@@ -2,12 +2,12 @@ require 'test_helper'
 
 describe CardConnect do
   it 'must respond to configure' do
-    CardConnect.must_respond_to :configure
+    _(CardConnect).must_respond_to :configure
   end
 
   describe 'configuration' do
     it 'must return instance of Configuration' do
-      CardConnect.configuration.must_be_kind_of CardConnect::Configuration
+      _(CardConnect.configuration).must_be_kind_of CardConnect::Configuration
     end
   end
 end

data/test/test_helper.rb

@@ -22,7 +22,7 @@ module CardConnect
 
     def connection
       @connection ||= Faraday.new(faraday_options) do |faraday|
-        faraday.request :basic_auth, @config.api_username, @config.api_password
+        faraday.request :authorization, :basic, @config.api_username, @config.api_password
         faraday.request :json
 
         faraday.response :json, content_type: /\bjson$/

metadata

@@ -1,59 +1,31 @@
 --- !ruby/object:Gem::Specification
 name: cardconnect
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.4.0
 platform: ruby
 authors:
 - Tim McKenzie
 - Prashant Mokkarala
 - Jason Taylor
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-04-24 00:00:00.000000000 Z
+date: 2023-05-11 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.12.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.12.1
-- !ruby/object:Gem::Dependency
-  name: faraday_middleware
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.11.0.1
+        version: 2.7.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.11.0.1
+        version: 2.7.4
 description: CardConnect API Ruby Client
 email:
 - tim@mobilecause.com
@@ -64,9 +36,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -146,7 +118,7 @@ homepage: http://developer.cardconnect.com/
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -161,9 +133,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: CardConnect API Ruby Client
 test_files:

data/.travis.yml

@@ -1,10 +0,0 @@
-language: ruby
-rvm:
-  - 2.5
-  - 2.4
-  - 2.3
-  - 2.2
-  - 2.1
-addons:
-  code_climate:
-      repo_token: 77ed2a0fb6a3c8841131b45bcf6beae12ead240bb0b127d1a064d069bfbe9376