cardconnect 2.3.0 → 2.4.0

data/test/cardconnect/services/bin/bin_response_test.rb

@@ -11,57 +11,57 @@ describe CardConnect::Service::BinResponse do
 
   describe 'FIELDS' do
     it 'should have country' do
-      @response.country.must_equal 'USA'
+      _(@response.country).must_equal 'USA'
     end
 
     it 'should have product' do
-      @response.product.must_equal 'V'
+      _(@response.product).must_equal 'V'
     end
 
     it 'should have cardusestring' do
-      @response.cardusestring.must_equal 'True credit'
+      _(@response.cardusestring).must_equal 'True credit'
     end
 
     it 'should have gsa' do
-      @response.gsa.must_equal false
+      _(@response.gsa).must_equal false
     end
 
     it 'should have corporate' do
-      @response.corporate.must_equal true
+      _(@response.corporate).must_equal true
     end
 
     it 'should have fsa' do
-      @response.fsa.must_equal false
+      _(@response.fsa).must_equal false
     end
 
     it 'should have subtype' do
-      @response.subtype.must_equal 'Visa Corporate T&E'
+      _(@response.subtype).must_equal 'Visa Corporate T&E'
     end
 
     it 'should have purchase' do
-      @response.purchase.must_equal false
+      _(@response.purchase).must_equal false
     end
 
     it 'should have prepaid' do
-      @response.prepaid.must_equal false
+      _(@response.prepaid).must_equal false
     end
 
     it 'should have binlo' do
-      @response.binlo.must_equal '478823XXX'
+      _(@response.binlo).must_equal '478823XXX'
     end
 
     it 'should have issuer' do
-      @response.issuer.must_equal "JPMorgan Chase Bank N.A. - Commercial"
+      _(@response.issuer).must_equal "JPMorgan Chase Bank N.A. - Commercial"
     end
 
     it 'should have binhi' do
-      @response.binhi.must_equal "478825XXX"
+      _(@response.binhi).must_equal "478825XXX"
     end
   end
 
   describe '#body' do
     it 'should generate hash with all the right values' do
-      @response.body.must_equal symbolize_keys(valid_bin_response)
+      _(@response.body).must_equal symbolize_keys(valid_bin_response)
     end
   end
 end

data/test/cardconnect/services/bin/bin_test.rb

@@ -14,7 +14,7 @@ describe CardConnect::Service::Bin do
   end
 
   it 'must have the right path' do
-    @service.path.must_equal '/cardconnect/rest/bin'
+    _(@service.path).must_equal '/cardconnect/rest/bin'
   end
 
   describe '#build_request' do
@@ -29,28 +29,28 @@ describe CardConnect::Service::Bin do
     it 'creates a bin request object with the passed in params' do
       @service.build_request(@valid_params)
 
-      @service.request.must_be_kind_of CardConnect::Service::BinRequest
-      @service.request.token.must_equal '9477709629051443'
-      @service.request.merchid.must_equal '000000927996'
+      _(@service.request).must_be_kind_of CardConnect::Service::BinRequest
+      _(@service.request.token).must_equal '9477709629051443'
+      _(@service.request.merchid).must_equal '000000927996'
     end
 
     it 'uses default merchant ID if merchid is not passed in' do
       @service.build_request(@valid_params.reject! { |k, _| k == 'merchid' })
-      @service.request.must_be_kind_of CardConnect::Service::BinRequest
-      @service.request.merchid.must_equal 'merchant123'
+      _(@service.request).must_be_kind_of CardConnect::Service::BinRequest
+      _(@service.request.merchid).must_equal 'merchant123'
     end
   end
 
   describe '#submit' do
     it 'raises an error when there is no request' do
-      @service.request.nil?.must_equal true
-      proc { @service.submit }.must_raise CardConnect::Error
+      _(@service.request.nil?).must_equal true
+      _(-> { @service.submit }).must_raise CardConnect::Error
     end
 
     it 'creates a response when a valid request is processed' do
       @service.build_request(valid_bin_request)
       @service.submit
-      @service.response.must_be_kind_of CardConnect::Service::BinResponse
+      _(@service.response).must_be_kind_of CardConnect::Service::BinResponse
     end
   end
 end

data/test/cardconnect/services/capture/capture_request_test.rb

@@ -11,55 +11,55 @@ describe CardConnect::Service::CaptureRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal '000000927996'
+      _(@request.merchid).must_equal '000000927996'
     end
 
     it 'should have retrieval reference number' do
-      @request.retref.must_equal '288002073633'
+      _(@request.retref).must_equal '288002073633'
     end
 
     it 'should have authorization code' do
-      @request.authcode.must_equal '046221'
+      _(@request.authcode).must_equal '046221'
     end
 
     it 'should have amount' do
-      @request.amount.must_equal '596.00'
+      _(@request.amount).must_equal '596.00'
     end
 
     it 'should have invoice id' do
-      @request.invoiceid.must_equal '7890'
+      _(@request.invoiceid).must_equal '7890'
     end
 
     it 'should have PO number' do
-      @request.ponumber.must_equal 'PO-0736332'
+      _(@request.ponumber).must_equal 'PO-0736332'
     end
 
     it 'should have tax amount' do
-      @request.taxamnt.must_equal '40.00'
+      _(@request.taxamnt).must_equal '40.00'
     end
   end
 
   describe '#valid?' do
     it 'should not be valid if no attributes are passed in' do
-      CardConnect::Service::CaptureRequest.new.valid?.must_equal false
+      _(CardConnect::Service::CaptureRequest.new.valid?).must_equal false
     end
 
     it 'should be valid if valid attributes are passed in' do
-      CardConnect::Service::CaptureRequest.new(valid_capture_request).valid?.must_equal true
+      _(CardConnect::Service::CaptureRequest.new(valid_capture_request).valid?).must_equal true
     end
   end
 
   describe '#errors' do
     CardConnect::Service::CaptureRequest::REQUIRED_FIELDS.each do |field|
       it "should have an error message if #{field} is missing" do
-        CardConnect::Service::CaptureRequest.new.errors.must_include "#{field.to_s.capitalize} is missing"
+        _(CardConnect::Service::CaptureRequest.new.errors).must_include "#{field.to_s.capitalize} is missing"
       end
     end
   end
 
   describe '#payload' do
     it 'should generate hash with all the right values' do
-      @request.payload.must_equal symbolize_keys(valid_capture_request)
+      _(@request.payload).must_equal symbolize_keys(valid_capture_request)
     end
   end
 end

data/test/cardconnect/services/capture/capture_response_test.rb

@@ -11,29 +11,29 @@ describe CardConnect::Service::CaptureResponse do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @response.merchid.must_equal '000000927996'
+      _(@response.merchid).must_equal '000000927996'
     end
 
     it 'should have account' do
-      @response.account.must_equal '41XXXXXXXXXX4113'
+      _(@response.account).must_equal '41XXXXXXXXXX4113'
     end
 
     it 'should have amount' do
-      @response.amount.must_equal '596.00'
+      _(@response.amount).must_equal '596.00'
     end
 
     it 'should have retrieval reference number' do
-      @response.retref.must_equal '288002073633'
+      _(@response.retref).must_equal '288002073633'
     end
 
     it 'should have settlement status' do
-      @response.setlstat.must_equal 'Pending'
+      _(@response.setlstat).must_equal 'Pending'
     end
   end
 
   describe '#body' do
     it 'should generate hash with all the right values' do
-      @response.body.must_equal symbolize_keys(valid_capture_response)
+      _(@response.body).must_equal symbolize_keys(valid_capture_response)
     end
   end
 end

data/test/cardconnect/services/capture/capture_test.rb

@@ -13,7 +13,7 @@ describe CardConnect::Service::Capture do
   end
 
   it 'must have the right path' do
-    @service.path.must_equal '/cardconnect/rest/capture'
+    _(@service.path).must_equal '/cardconnect/rest/capture'
   end
 
   describe '#build_request' do
@@ -28,29 +28,29 @@ describe CardConnect::Service::Capture do
     it 'creates a Capture request object with the passed in params' do
       @service.build_request(@valid_params)
 
-      @service.request.must_be_kind_of CardConnect::Service::CaptureRequest
+      _(@service.request).must_be_kind_of CardConnect::Service::CaptureRequest
 
-      @service.request.merchid.must_equal '000000927996'
-      @service.request.retref.must_equal '288002073633'
+      _(@service.request.merchid).must_equal '000000927996'
+      _(@service.request.retref).must_equal '288002073633'
     end
 
     it 'uses default merchant ID if merchid is not passed in' do
       @service.build_request(@valid_params.reject! { |k, _| k == 'merchid' })
-      @service.request.must_be_kind_of CardConnect::Service::CaptureRequest
-      @service.request.merchid.must_equal 'merchant123'
+      _(@service.request).must_be_kind_of CardConnect::Service::CaptureRequest
+      _(@service.request.merchid).must_equal 'merchant123'
     end
   end
 
   describe '#submit' do
     it 'raises an error when there is no request' do
-      @service.request.nil?.must_equal true
-      proc { @service.submit }.must_raise CardConnect::Error
+      _(@service.request.nil?).must_equal true
+      _(proc { @service.submit }).must_raise CardConnect::Error
     end
 
     it 'creates a response when a valid request is processed' do
       @service.build_request(valid_capture_request)
       @service.submit
-      @service.response.must_be_kind_of CardConnect::Service::CaptureResponse
+      _(@service.response).must_be_kind_of CardConnect::Service::CaptureResponse
     end
   end
 end

data/test/cardconnect/services/inquire/inquire_request_test.rb

@@ -11,35 +11,35 @@ describe CardConnect::Service::InquireRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal '000000927996'
+      _(@request.merchid).must_equal '000000927996'
     end
 
     it 'should have retrieval reference number' do
-      @request.retref.must_equal '288002073633'
+      _(@request.retref).must_equal '288002073633'
     end
   end
 
   describe '#valid?' do
     it 'should not be valid if no attributes are passed in' do
-      CardConnect::Service::InquireRequest.new.valid?.must_equal false
+      _(CardConnect::Service::InquireRequest.new.valid?).must_equal false
     end
 
     it 'should be valid if valid attributes are passed in' do
-      CardConnect::Service::InquireRequest.new(valid_inquire_request).valid?.must_equal true
+      _(CardConnect::Service::InquireRequest.new(valid_inquire_request).valid?).must_equal true
     end
   end
 
   describe '#errors' do
     CardConnect::Service::InquireRequest::REQUIRED_FIELDS.each do |field|
       it "should have an error message if #{field} is missing" do
-        CardConnect::Service::InquireRequest.new.errors.must_include "#{field.to_s.capitalize} is missing"
+        _(CardConnect::Service::InquireRequest.new.errors).must_include "#{field.to_s.capitalize} is missing"
       end
     end
   end
 
   describe '#payload' do
     it 'should generate the correct path params' do
-      @request.payload.must_equal '/288002073633/000000927996'
+      _(@request.payload).must_equal '/288002073633/000000927996'
     end
   end
 end

data/test/cardconnect/services/inquire/inquire_response_test.rb

@@ -11,73 +11,73 @@ describe CardConnect::Service::InquireResponse do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @response.merchid.must_equal '000000927996'
+      _(@response.merchid).must_equal '000000927996'
     end
 
     it 'should have name' do
-      @response.name.must_equal 'TOM JONES'
+      _(@response.name).must_equal 'TOM JONES'
     end
 
     it 'should have account' do
-      @response.account.must_equal '9418594164541111'
+      _(@response.account).must_equal '9418594164541111'
     end
 
     it 'should have amount' do
-      @response.amount.must_equal '596.00'
+      _(@response.amount).must_equal '596.00'
     end
 
     it 'should have currency' do
-      @response.currency.must_equal 'USD'
+      _(@response.currency).must_equal 'USD'
     end
 
     it 'should have retrieval reference number' do
-      @response.retref.must_equal '288015190411'
+      _(@response.retref).must_equal '288015190411'
     end
 
     it 'should have response code' do
-      @response.respcode.must_equal '00'
+      _(@response.respcode).must_equal '00'
     end
 
     it 'should have response processor' do
-      @response.respproc.must_equal 'FNOR'
+      _(@response.respproc).must_equal 'FNOR'
     end
 
     it 'should have response status' do
-      @response.respstat.must_equal 'A'
+      _(@response.respstat).must_equal 'A'
     end
 
     it 'should have capture status' do
-      @response.resptext.must_equal 'Approval'
+      _(@response.resptext).must_equal 'Approval'
     end
 
     it 'should have settlement status' do
-      @response.setlstat.must_equal 'Accepted'
+      _(@response.setlstat).must_equal 'Accepted'
     end
 
     it 'should have token' do
-      @response.token.must_equal '9418594164541111'
+      _(@response.token).must_equal '9418594164541111'
     end
 
     it 'should have authdate' do
-      @response.authdate.must_equal '20180410'
+      _(@response.authdate).must_equal '20180410'
     end
 
     it 'should have captureddate' do
-      @response.capturedate.must_equal '20180326065748'
+      _(@response.capturedate).must_equal '20180326065748'
     end
 
     it 'should have lastfour value' do
-      @response.lastfour.must_equal '1111'
+      _(@response.lastfour).must_equal '1111'
     end
 
     it 'should have settledate' do
-      @response.settledate.must_equal '20180327143721'
+      _(@response.settledate).must_equal '20180327143721'
     end
   end
 
   describe '#body' do
     it 'should generate hash with all the right values' do
-      @response.body.must_equal symbolize_keys(valid_inquire_response)
+      _(@response.body).must_equal symbolize_keys(valid_inquire_response)
     end
   end
 end

data/test/cardconnect/services/inquire/inquire_test.rb

@@ -14,7 +14,7 @@ describe CardConnect::Service::Inquire do
   end
 
   it 'must have the right path' do
-    @service.path.must_equal '/cardconnect/rest/inquire'
+    _(@service.path).must_equal '/cardconnect/rest/inquire'
   end
 
   describe '#build_request' do
@@ -29,28 +29,28 @@ describe CardConnect::Service::Inquire do
     it 'creates a inquire request object with the passed in params' do
       @service.build_request(@valid_params)
 
-      @service.request.must_be_kind_of CardConnect::Service::InquireRequest
-      @service.request.retref.must_equal '288002073633'
-      @service.request.merchid.must_equal '000000927996'
+      _(@service.request).must_be_kind_of CardConnect::Service::InquireRequest
+      _(@service.request.retref).must_equal '288002073633'
+      _(@service.request.merchid).must_equal '000000927996'
     end
 
     it 'uses default merchant ID if merchid is not passed in' do
       @service.build_request(@valid_params.reject! { |k, _| k == 'merchid' })
-      @service.request.must_be_kind_of CardConnect::Service::InquireRequest
-      @service.request.merchid.must_equal 'merchant123'
+      _(@service.request).must_be_kind_of CardConnect::Service::InquireRequest
+      _(@service.request.merchid).must_equal 'merchant123'
     end
   end
 
   describe '#submit' do
     it 'raises an error when there is no request' do
-      @service.request.nil?.must_equal true
-      proc { @service.submit }.must_raise CardConnect::Error
+      _(@service.request.nil?).must_equal true
+      _(proc { @service.submit }).must_raise CardConnect::Error
     end
 
     it 'creates a response when a valid request is processed' do
       @service.build_request(valid_inquire_request)
       @service.submit
-      @service.response.must_be_kind_of CardConnect::Service::InquireResponse
+      _(@service.response).must_be_kind_of CardConnect::Service::InquireResponse
     end
   end
 end

data/test/cardconnect/services/profile/profile_delete_request_test.rb

@@ -11,25 +11,25 @@ describe CardConnect::Service::ProfileDeleteRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal '000000927996'
+      _(@request.merchid).must_equal '000000927996'
     end
 
     it 'should have profile id' do
-      @request.profileid.must_equal '12345678901234567890'
+      _(@request.profileid).must_equal '12345678901234567890'
     end
 
     it 'should have account id' do
-      @request.acctid.must_equal '1'
+      _(@request.acctid).must_equal '1'
     end
   end
 
   describe '#valid?' do
     it 'should not be valid if no attributes are passed in' do
-      CardConnect::Service::ProfileDeleteRequest.new.valid?.must_equal false
+      _(CardConnect::Service::ProfileDeleteRequest.new.valid?).must_equal false
     end
 
     it 'should be valid if valid attributes are passed in' do
-      CardConnect::Service::ProfileDeleteRequest.new(valid_profile_request).valid?.must_equal true
+      _(CardConnect::Service::ProfileDeleteRequest.new(valid_profile_request).valid?).must_equal true
     end
   end
 
@@ -37,14 +37,14 @@ describe CardConnect::Service::ProfileDeleteRequest do
     CardConnect::Service::ProfileDeleteRequest::REQUIRED_FIELDS.each do |field|
       field_name = field.to_s.capitalize
       it "should have an error message if #{field_name} is missing" do
-        CardConnect::Service::ProfileDeleteRequest.new.errors.must_include "#{field_name} is missing"
+        _(CardConnect::Service::ProfileDeleteRequest.new.errors).must_include "#{field_name} is missing"
       end
     end
   end
 
   describe '#payload' do
     it 'should generate hash with all the right values' do
-      @request.payload.must_equal "/12345678901234567890/1/000000927996"
+      _(@request.payload).must_equal "/12345678901234567890/1/000000927996"
     end
   end
 end

data/test/cardconnect/services/profile/profile_delete_response_test.rb

@@ -11,57 +11,57 @@ describe CardConnect::Service::ProfileDeleteResponse do
 
   describe 'FIELDS' do
     it 'should have response text' do
-      @response.resptext.must_equal 'Profile Deleted'
+      _(@response.resptext).must_equal 'Profile Deleted'
     end
 
     it 'should have the response code' do
-      @response.respcode.must_equal '08'
+      _(@response.respcode).must_equal '08'
     end
 
     it 'should have the respproc' do
-      @response.respproc.must_equal 'PPS'
+      _(@response.respproc).must_equal 'PPS'
     end
 
     it 'should have response status' do
-      @response.respstat.must_equal 'A'
+      _(@response.respstat).must_equal 'A'
     end
 
     it 'should have profileid' do
-      @response.profileid.must_equal '12345678901234567890'
+      _(@response.profileid).must_equal '12345678901234567890'
     end
 
     it 'should have acctid' do
-      @response.acctid.must_equal '1'
+      _(@response.acctid).must_equal '1'
     end
   end
 
   describe '#success?' do
     it 'should be true when there are no errors' do
-      @response.success?.must_equal true
+      _(@response.success?).must_equal true
     end
 
     it 'should be false when there are errors' do
       prof_response = valid_profile_delete_response.merge!('respstat' => 'C', 'resptext' => 'this is an error')
       response = CardConnect::Service::ProfileDeleteResponse.new(prof_response)
-      response.success?.must_equal false
+      _(response.success?).must_equal false
     end
   end
 
   describe '#errors' do
     it 'should be empty when there are no errors' do
-      @response.errors.must_be_empty
+      _(@response.errors).must_be_empty
     end
 
     it 'should be an array of error messages when there are errors' do
       prof_response = valid_profile_delete_response.merge!('respstat' => 'C', 'resptext' => 'this is an error')
       response = CardConnect::Service::ProfileDeleteResponse.new(prof_response)
-      response.errors.must_equal ['this is an error']
+      _(response.errors).must_equal ['this is an error']
     end
   end
 
   describe '#body' do
     it 'should generate hash with all the right values' do
-      @response.body.must_equal symbolize_keys(valid_profile_delete_response)
+      _(@response.body).must_equal symbolize_keys(valid_profile_delete_response)
     end
   end
 end

data/test/cardconnect/services/profile/profile_get_request_test.rb

@@ -11,25 +11,25 @@ describe CardConnect::Service::ProfileGetRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal '000000927996'
+      _(@request.merchid).must_equal '000000927996'
     end
 
     it 'should have profile id' do
-      @request.profileid.must_equal '12345678901234567890'
+      _(@request.profileid).must_equal '12345678901234567890'
     end
 
     it 'should have account id' do
-      @request.acctid.must_equal '1'
+      _(@request.acctid).must_equal '1'
     end
   end
 
   describe '#valid?' do
     it 'should not be valid if no attributes are passed in' do
-      CardConnect::Service::ProfileGetRequest.new.valid?.must_equal false
+      _(CardConnect::Service::ProfileGetRequest.new.valid?).must_equal false
     end
 
     it 'should be valid if valid attributes are passed in' do
-      CardConnect::Service::ProfileGetRequest.new(valid_profile_request).valid?.must_equal true
+      _(CardConnect::Service::ProfileGetRequest.new(valid_profile_request).valid?).must_equal true
     end
   end
 
@@ -37,14 +37,14 @@ describe CardConnect::Service::ProfileGetRequest do
     CardConnect::Service::ProfileGetRequest::REQUIRED_FIELDS.each do |field|
       field_name = field.to_s.capitalize
       it "should have an error message if #{field_name} is missing" do
-        CardConnect::Service::ProfileGetRequest.new.errors.must_include "#{field_name} is missing"
+        _(CardConnect::Service::ProfileGetRequest.new.errors).must_include "#{field_name} is missing"
       end
     end
   end
 
   describe '#payload' do
     it 'should generate hash with all the right values' do
-      @request.payload.must_equal "/12345678901234567890/1/000000927996"
+      _(@request.payload).must_equal "/12345678901234567890/1/000000927996"
     end
   end
 end