capybara 3.3.0 → 3.40.0

data/lib/capybara/spec/session/window/switch_to_window_spec.rb

@@ -1,5 +1,9 @@
 # frozen_string_literal: true
 
+# NOTE: This file uses `sleep` to sync up parts of the tests. This is only implemented like this
+# because of the methods being tested. In tests using Capybara this type of behavior should be implemented
+# using Capybara provided assertions with builtin waiting behavior.
+
 Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
   before do
     @window = @session.current_window
@@ -15,27 +19,27 @@ Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
     @session.switch_to_window(@window)
   end
 
-  it "should raise error when invoked without args" do
+  it 'should raise error when invoked without args' do
     expect do
       @session.switch_to_window
-    end.to raise_error(ArgumentError, "`switch_to_window`: either window or block should be provided")
+    end.to raise_error(ArgumentError, '`switch_to_window`: either window or block should be provided')
   end
 
-  it "should raise error when invoked with window and block" do
+  it 'should raise error when invoked with window and block' do
     expect do
       @session.switch_to_window(@window) { @session.title == 'Title of the first popup' }
-    end.to raise_error(ArgumentError, "`switch_to_window` can take either a block or a window, not both")
+    end.to raise_error(ArgumentError, '`switch_to_window` can take either a block or a window, not both')
   end
 
-  context "with an instance of Capybara::Window" do
-    it "should be able to switch to window" do
+  context 'with an instance of Capybara::Window' do
+    it 'should be able to switch to window' do
       window = @session.open_new_window
       expect(@session.title).to eq('With Windows')
       @session.switch_to_window(window)
       expect(@session.title).to satisfy('be a blank title') { |title| ['', 'about:blank'].include? title }
     end
 
-    it "should raise error when closed window is passed" do
+    it 'should raise error when closed window is passed' do
       original_window = @session.current_window
       new_window = @session.open_new_window
       @session.switch_to_window(new_window)
@@ -47,30 +51,30 @@ Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
     end
   end
 
-  context "with block" do
+  context 'with block' do
     before do
       @session.find(:css, '#openTwoWindows').click
       sleep(1) # wait for the windows to open
     end
 
-    it "should be able to switch to current window" do
+    it 'should be able to switch to current window' do
       @session.switch_to_window { @session.title == 'With Windows' }
       expect(@session).to have_css('#openTwoWindows')
     end
 
-    it "should find the div in another window" do
+    it 'should find the div in another window' do
       @session.switch_to_window { @session.title == 'Title of popup two' }
       expect(@session).to have_css('#divInPopupTwo')
     end
 
-    it "should be able to switch multiple times" do
+    it 'should be able to switch multiple times' do
       @session.switch_to_window { @session.title == 'Title of the first popup' }
       expect(@session).to have_css('#divInPopupOne')
       @session.switch_to_window { @session.title == 'Title of popup two' }
       expect(@session).to have_css('#divInPopupTwo')
     end
 
-    it "should return window" do
+    it 'should return window' do
       window = @session.switch_to_window { @session.title == 'Title of popup two' }
       expect((@session.windows - [@window])).to include(window)
     end
@@ -91,7 +95,7 @@ Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
       end.to raise_error(Capybara::ScopeError, /`switch_to_window` is not supposed to be invoked from/)
     end
 
-    it "should allow to be called inside within_window and within_window will still return to original" do
+    it 'should allow to be called inside within_window and within_window will still return to original' do
       other_windows = (@session.windows - [@window])
       expect(@session.current_window).to eq(@window)
       @session.within_window other_windows[0] do
@@ -106,11 +110,11 @@ Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
       original = @session.current_window
       expect do
         @session.switch_to_window { @session.title == 'A title' }
-      end.to raise_error(Capybara::WindowError, "Could not find a window matching block/lambda")
+      end.to raise_error(Capybara::WindowError, 'Could not find a window matching block/lambda')
       expect(@session.current_window).to eq(original)
     end
 
-    it "should switch to original window if error is raised inside block" do
+    it 'should switch to original window if error is raised inside block' do
       original = @session.switch_to_window(@session.windows[1])
       expect do
         @session.switch_to_window { raise 'error' }
@@ -119,7 +123,7 @@ Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
     end
   end
 
-  it "should wait for window to appear" do
+  it 'should wait for window to appear' do
     @session.find(:css, '#openWindowWithTimeout').click
     expect do
       @session.switch_to_window(wait: 5) { @session.title == 'Title of the first popup' }

data/lib/capybara/spec/session/window/window_opened_by_spec.rb

@@ -1,5 +1,9 @@
 # frozen_string_literal: true
 
+# NOTE: This file uses `sleep` to sync up parts of the tests. This is only implemented like this
+# because of the methods being tested. In tests using Capybara this type of behavior should be implemented
+# using Capybara provided assertions with builtin waiting behavior.
+
 Capybara::SpecHelper.spec '#window_opened_by', requires: [:windows] do
   before do
     @window = @session.current_window
@@ -15,8 +19,8 @@ Capybara::SpecHelper.spec '#window_opened_by', requires: [:windows] do
     @session.switch_to_window(@window)
   end
 
-  let(:zero_windows_message) { "block passed to #window_opened_by opened 0 windows instead of 1" }
-  let(:two_windows_message) { "block passed to #window_opened_by opened 2 windows instead of 1" }
+  let(:zero_windows_message) { 'block passed to #window_opened_by opened 0 windows instead of 1' }
+  let(:two_windows_message) { 'block passed to #window_opened_by opened 2 windows instead of 1' }
 
   context 'with :wait option' do
     it 'should raise error if value of :wait is less than timeout' do

data/lib/capybara/spec/session/window/window_spec.rb

@@ -1,95 +1,97 @@
 # frozen_string_literal: true
 
+# NOTE: This file uses `sleep` to sync up parts of the tests. This is only implemented like this
+# because of the methods being tested. In tests using Capybara this type of behavior should be implemented
+# using Capybara provided assertions with builtin waiting behavior.
+
 Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
+  let!(:orig_window) { @session.current_window }
   before do
-    @window = @session.current_window
     @session.visit('/with_windows')
   end
 
   after do
-    (@session.windows - [@window]).each do |w|
+    (@session.windows - [orig_window]).each do |w|
       @session.switch_to_window w
       w.close
     end
-    @session.switch_to_window(@window)
+    @session.switch_to_window(orig_window)
   end
 
   describe '#exists?' do
-    before do
-      @other_window = @session.window_opened_by do
+    it 'should become false after window was closed' do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
-    end
 
-    it "should become false after window was closed" do
       expect do
-        @session.switch_to_window @other_window
-        @other_window.close
-      end.to change { @other_window.exists? }.from(true).to(false)
+        @session.switch_to_window other_window
+        other_window.close
+      end.to change(other_window, :exists?).from(true).to(false)
     end
   end
 
   describe '#closed?' do
-    it "should become true after window was closed" do
-      @other_window = @session.window_opened_by do
+    it 'should become true after window was closed' do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
       expect do
-        @session.switch_to_window @other_window
-        @other_window.close
-      end.to change { @other_window.closed? }.from(false).to(true)
+        @session.switch_to_window other_window
+        other_window.close
+      end.to change { other_window.closed? }.from(false).to(true)
     end
   end
 
   describe '#current?' do
-    before do
-      @other_window = @session.window_opened_by do
+    let(:other_window) do
+      @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
     end
 
     it 'should become true after switching to window' do
       expect do
-        @session.switch_to_window(@other_window)
-      end.to change { @other_window.current? }.from(false).to(true)
+        @session.switch_to_window(other_window)
+      end.to change(other_window, :current?).from(false).to(true)
     end
 
     it 'should return false if window is closed' do
-      @session.switch_to_window(@other_window)
-      @other_window.close
-      expect(@other_window.current?).to eq(false)
+      @session.switch_to_window(other_window)
+      other_window.close
+      expect(other_window.current?).to be(false)
     end
   end
 
   describe '#close' do
-    before do
-      @other_window = @session.window_opened_by do
+    let!(:other_window) do
+      @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
     end
 
     it 'should switch to original window if invoked not for current window' do
       expect(@session.windows.size).to eq(2)
-      expect(@session.current_window).to eq(@window)
-      @other_window.close
+      expect(@session.current_window).to eq(orig_window)
+      other_window.close
       expect(@session.windows.size).to eq(1)
-      expect(@session.current_window).to eq(@window)
+      expect(@session.current_window).to eq(orig_window)
     end
 
     it 'should make subsequent invocations of other methods raise no_such_window_error if invoked for current window' do
-      @session.switch_to_window(@other_window)
-      expect(@session.current_window).to eq(@other_window)
-      @other_window.close
+      @session.switch_to_window(other_window)
+      expect(@session.current_window).to eq(other_window)
+      other_window.close
       expect do
         @session.find(:css, '#some_id')
       end.to raise_error(@session.driver.no_such_window_error)
-      @session.switch_to_window(@window)
+      @session.switch_to_window(orig_window)
     end
   end
 
   describe '#size' do
     def win_size
-      @session.evaluate_script("[window.outerWidth || window.innerWidth, window.outerHeight || window.innerHeight]")
+      @session.evaluate_script('[window.outerWidth || window.innerWidth, window.outerHeight || window.innerHeight]')
     end
 
     it 'should return size of whole window', requires: %i[windows js] do
@@ -97,57 +99,54 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
     end
 
     it 'should switch to original window if invoked not for current window' do
-      @other_window = @session.window_opened_by do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
       sleep 1
-      size = @session.within_window(@other_window) do
+      size = @session.within_window(other_window) do
         win_size
       end
-      expect(@other_window.size).to eq(size)
-      expect(@session.current_window).to eq(@window)
+      expect(other_window.size).to eq(size)
+      expect(@session.current_window).to eq(orig_window)
     end
   end
 
   describe '#resize_to' do
-    before do
-      @initial_size = @session.current_window.size
-    end
+    let!(:initial_size) { @session.current_window.size }
 
     after do
-      @session.current_window.resize_to(*@initial_size)
-      sleep 0.5
+      @session.current_window.resize_to(*initial_size)
+      sleep 1
     end
 
     it 'should be able to resize window', requires: %i[windows js] do
-      width, height = @initial_size
+      width, height = initial_size
       @session.current_window.resize_to(width - 100, height - 100)
       sleep 1
       expect(@session.current_window.size).to eq([width - 100, height - 100])
     end
 
     it 'should stay on current window if invoked not for current window', requires: %i[windows js] do
-      @other_window = @session.window_opened_by do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
-      @other_window.resize_to(400, 300)
-      expect(@session.current_window).to eq(@window)
 
-      # #size returns values larger than availWidth, availHeight with Chromedriver
-      @session.within_window(@other_window) do
-        expect(@session.current_window.size).to eq([400, 300])
-        # expect(@session.evaluate_script("[window.outerWidth, window.outerHeight]")).to eq([400,300])
+      other_window.resize_to(600, 400)
+      expect(@session.current_window).to eq(orig_window)
+
+      @session.within_window(other_window) do
+        expect(@session.current_window.size).to eq([600, 400])
       end
     end
   end
 
   describe '#maximize' do
-    before do
-      @initial_size = @session.current_window.size
+    let! :initial_size do
+      @session.current_window.size
     end
 
     after do
-      @session.current_window.resize_to(*@initial_size)
+      @session.current_window.resize_to(*initial_size)
       sleep 0.5
     end
 
@@ -167,35 +166,35 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
     end
 
     it 'should stay on current window if invoked not for current window', requires: %i[windows js] do
-      @other_window = @session.window_opened_by do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
-      @other_window.resize_to(400, 300)
+      other_window.resize_to(400, 300)
       sleep 0.5
-      @other_window.maximize
+      other_window.maximize
       sleep 0.5 # The timing on maximize is finicky on Travis -- wait a bit for maximize to occur
 
-      expect(@session.current_window).to eq(@window)
+      expect(@session.current_window).to eq(orig_window)
       # Maximizing the browser affects all tabs so this may not be valid in real browsers
-      # expect(@session.current_window.size).to eq(@initial_size)
+      # expect(@session.current_window.size).to eq(initial_size)
 
-      ow_width, ow_height = @other_window.size
+      ow_width, ow_height = other_window.size
       expect(ow_width).to be > 400
       expect(ow_height).to be > 300
     end
   end
 
   describe '#fullscreen' do
-    before do
-      @initial_size = @session.current_window.size
+    let! :initial_size do
+      @session.current_window.size
     end
 
     after do
-      @session.current_window.resize_to(*@initial_size)
-      sleep 0.5
+      @session.current_window.resize_to(*initial_size)
+      sleep 1
     end
 
-    it "should be able to fullscreen the window" do
+    it 'should be able to fullscreen the window' do
       expect do
         @session.current_window.fullscreen
       end.not_to raise_error

data/lib/capybara/spec/session/window/windows_spec.rb

@@ -1,5 +1,9 @@
 # frozen_string_literal: true
 
+# NOTE: This file uses `sleep` to sync up parts of the tests. This is only implemented like this
+# because of the methods being tested. In tests using Capybara this type of behavior should be implemented
+# using Capybara provided assertions with builtin waiting behavior.
+
 Capybara::SpecHelper.spec '#windows', requires: [:windows] do
   before do
     @window = @session.current_window
@@ -25,6 +29,6 @@ Capybara::SpecHelper.spec '#windows', requires: [:windows] do
     titles = @session.windows.map do |window|
       @session.within_window(window) { @session.title }
     end
-    expect(titles).to match_array(['With Windows', 'Title of the first popup', 'Title of popup two'])
+    expect(titles).to match_array(['With Windows', 'Title of the first popup', 'Title of popup two']) # rubocop:disable RSpec/MatchArray
   end
 end

data/lib/capybara/spec/session/window/within_window_spec.rb

@@ -19,8 +19,8 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
     @session.switch_to_window(@window)
   end
 
-  context "with an instance of Capybara::Window" do
-    it "should not invoke driver#switch_to_window when given current window" do
+  context 'with an instance of Capybara::Window' do
+    it 'should not invoke driver#switch_to_window when given current window' do
       allow(@session.driver).to receive(:switch_to_window).and_call_original
       @session.within_window @window do
         expect(@session.title).to eq('With Windows')
@@ -28,7 +28,7 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       expect(@session.driver).not_to have_received(:switch_to_window)
     end
 
-    it "should be able to switch to another window" do
+    it 'should be able to switch to another window' do
       window = (@session.windows - [@window]).first
       @session.within_window window do
         expect(@session).to have_title(/Title of the first popup|Title of popup two/)
@@ -36,7 +36,7 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       expect(@session.title).to eq('With Windows')
     end
 
-    it "returns value from the block" do
+    it 'returns value from the block' do
       window = (@session.windows - [@window]).first
       value = @session.within_window window do
         43252003274489856000
@@ -44,7 +44,7 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       expect(value).to eq(43252003274489856000)
     end
 
-    it "should switch back if exception was raised inside block" do
+    it 'should switch back if exception was raised inside block' do
       window = (@session.windows - [@window]).first
       expect do
         @session.within_window(window) do
@@ -58,7 +58,7 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       expect(@session.send(:scopes)).to eq([nil])
     end
 
-    it "should leave correct scopes after execution in case of error", requires: %i[windows frames] do
+    it 'should leave correct scopes after execution in case of error', requires: %i[windows frames] do
       window = (@session.windows - [@window]).first
       expect do
         @session.within_frame 'frameOne' do
@@ -86,14 +86,14 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
     end
   end
 
-  context "with lambda" do
-    it "should find the div in another window" do
+  context 'with lambda' do
+    it 'should find the div in another window' do
       @session.within_window(-> { @session.title == 'Title of the first popup' }) do
         expect(@session).to have_css('#divInPopupOne')
       end
     end
 
-    it "should find divs in both windows" do
+    it 'should find divs in both windows' do
       @session.within_window(-> { @session.title == 'Title of popup two' }) do
         expect(@session).to have_css('#divInPopupTwo')
       end
@@ -103,7 +103,7 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       expect(@session.title).to eq('With Windows')
     end
 
-    it "should be able to nest within_window" do
+    it 'should be able to nest within_window' do
       @session.within_window(-> { @session.title == 'Title of popup two' }) do
         expect(@session).to have_css('#divInPopupTwo')
         @session.within_window(-> { @session.title == 'Title of the first popup' }) do
@@ -117,7 +117,7 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       expect(@session.title).to eq('With Windows')
     end
 
-    it "should work inside a normal scope" do
+    it 'should work inside a normal scope' do
       expect(@session).to have_css('#openWindow')
       @session.within(:css, '#scope') do
         @session.within_window(-> { @session.title == 'Title of the first popup' }) do
@@ -133,18 +133,18 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
         @session.within_window(-> { @session.title == 'Invalid title' }) do
           expect(@session).to have_css('#divInPopupOne')
         end
-      end.to raise_error(Capybara::WindowError, "Could not find a window matching block/lambda")
+      end.to raise_error(Capybara::WindowError, 'Could not find a window matching block/lambda')
       expect(@session.current_window).to eq(@window)
       expect(@session).to have_css('#doesNotOpenWindows')
       expect(@session.send(:scopes)).to eq([nil])
     end
 
-    it "returns value from the block" do
+    it 'returns value from the block' do
       value = @session.within_window(-> { @session.title == 'Title of popup two' }) { 42 }
       expect(value).to eq(42)
     end
 
-    it "should switch back if exception was raised inside block" do
+    it 'should switch back if exception was raised inside block' do
       expect do
         @session.within_window(-> { @session.title == 'Title of popup two' }) do
           raise 'some error'