capybara 3.3.0 → 3.40.0

data/lib/capybara/spec/session/has_title_spec.rb

@@ -5,35 +5,39 @@ Capybara::SpecHelper.spec '#has_title?' do
     @session.visit('/with_js')
   end
 
-  it "should be true if the page has the given title" do
+  it 'should be true if the page has the given title' do
     expect(@session).to have_title('with_js')
+    expect(@session.has_title?('with_js')).to be true
   end
 
-  it "should allow regexp matches" do
+  it 'should allow regexp matches' do
     expect(@session).to have_title(/w[a-z]{3}_js/)
     expect(@session).not_to have_title(/monkey/)
   end
 
-  it "should wait for title", requires: [:js] do
-    @session.click_link("Change title")
-    expect(@session).to have_title("changed title")
+  it 'should wait for title', requires: [:js] do
+    @session.click_link('Change title')
+    expect(@session).to have_title('changed title')
   end
 
-  it "should be false if the page has not the given title" do
+  it 'should be false if the page has not the given title' do
     expect(@session).not_to have_title('monkey')
+    expect(@session.has_title?('monkey')).to be false
   end
 
-  it "should default to exact: false matching" do
+  it 'should default to exact: false matching' do
     expect(@session).to have_title('with_js', exact: false)
     expect(@session).to have_title('with_', exact: false)
   end
 
-  it "should match exactly if exact: true option passed" do
+  it 'should match exactly if exact: true option passed' do
     expect(@session).to have_title('with_js', exact: true)
     expect(@session).not_to have_title('with_', exact: true)
+    expect(@session.has_title?('with_js', exact: true)).to be true
+    expect(@session.has_title?('with_', exact: true)).to be false
   end
 
-  it "should match partial if exact: false option passed" do
+  it 'should match partial if exact: false option passed' do
     expect(@session).to have_title('with_js', exact: false)
     expect(@session).to have_title('with_', exact: false)
   end
@@ -44,23 +48,24 @@ Capybara::SpecHelper.spec '#has_no_title?' do
     @session.visit('/with_js')
   end
 
-  it "should be false if the page has the given title" do
+  it 'should be false if the page has the given title' do
     expect(@session).not_to have_no_title('with_js')
   end
 
-  it "should allow regexp matches" do
+  it 'should allow regexp matches' do
     expect(@session).not_to have_no_title(/w[a-z]{3}_js/)
     expect(@session).to have_no_title(/monkey/)
   end
 
-  it "should wait for title to disappear", requires: [:js] do
+  it 'should wait for title to disappear', requires: [:js] do
     Capybara.using_wait_time(5) do
-      @session.click_link("Change title") # triggers title change after 400ms
+      @session.click_link('Change title') # triggers title change after 400ms
       expect(@session).to have_no_title('with_js')
     end
   end
 
-  it "should be true if the page has not the given title" do
+  it 'should be true if the page has not the given title' do
     expect(@session).to have_no_title('monkey')
+    expect(@session.has_no_title?('monkey')).to be true
   end
 end

data/lib/capybara/spec/session/has_xpath_spec.rb

@@ -5,31 +5,45 @@ Capybara::SpecHelper.spec '#has_xpath?' do
     @session.visit('/with_html')
   end
 
-  it "should be true if the given selector is on the page" do
-    expect(@session).to have_xpath("//p")
+  it 'should be true if the given selector is on the page' do
+    expect(@session).to have_xpath('//p')
     expect(@session).to have_xpath("//p//a[@id='foo']")
     expect(@session).to have_xpath("//p[contains(.,'est')]")
   end
 
-  it "should be false if the given selector is not on the page" do
-    expect(@session).not_to have_xpath("//abbr")
+  it 'should support :id option' do
+    expect(@session).to have_xpath('//h2', id: 'h2one')
+    expect(@session).to have_xpath('//h2')
+    expect(@session).to have_xpath('//h2', id: /h2o/)
+  end
+
+  it 'should support :class option' do
+    expect(@session).to have_xpath('//li', class: 'guitarist')
+    expect(@session).to have_xpath('//li', class: /guitar/)
+    expect(@session).to have_xpath('//li', class: /guitar|drummer/)
+    expect(@session).to have_xpath('//li', class: %w[beatle guitarist])
+    expect(@session).to have_xpath('//li', class: /.*/)
+  end
+
+  it 'should be false if the given selector is not on the page' do
+    expect(@session).not_to have_xpath('//abbr')
     expect(@session).not_to have_xpath("//p//a[@id='doesnotexist']")
     expect(@session).not_to have_xpath("//p[contains(.,'thisstringisnotonpage')]")
   end
 
-  it "should use xpath even if default selector is CSS" do
+  it 'should use xpath even if default selector is CSS' do
     Capybara.default_selector = :css
     expect(@session).not_to have_xpath("//p//a[@id='doesnotexist']")
   end
 
-  it "should respect scopes" do
+  it 'should respect scopes' do
     @session.within "//p[@id='first']" do
       expect(@session).to have_xpath(".//a[@id='foo']")
       expect(@session).not_to have_xpath(".//a[@id='red']")
     end
   end
 
-  it "should wait for content to appear", requires: [:js] do
+  it 'should wait for content to appear', requires: [:js] do
     Capybara.using_wait_time(3) do
       @session.visit('/with_js')
       @session.click_link('Click me') # updates page after 500ms
@@ -37,31 +51,34 @@ Capybara::SpecHelper.spec '#has_xpath?' do
     end
   end
 
-  context "with count" do
-    it "should be true if the content occurs the given number of times" do
-      expect(@session).to have_xpath("//p", count: 3)
+  context 'with count' do
+    it 'should be true if the content occurs the given number of times' do
+      expect(@session).to have_xpath('//p', count: 3)
       expect(@session).to have_xpath("//p//a[@id='foo']", count: 1)
       expect(@session).to have_xpath("//p[contains(.,'est')]", count: 1)
       expect(@session).to have_xpath("//p//a[@id='doesnotexist']", count: 0)
+      expect(@session).to have_xpath('//li', class: /guitar|drummer/, count: 4)
+      expect(@session).to have_xpath('//li', id: /john|paul/, class: /guitar|drummer/, count: 2)
+      expect(@session).to have_xpath('//li', class: %w[beatle guitarist], count: 2)
     end
 
-    it "should be false if the content occurs a different number of times than the given" do
-      expect(@session).not_to have_xpath("//p", count: 6)
+    it 'should be false if the content occurs a different number of times than the given' do
+      expect(@session).not_to have_xpath('//p', count: 6)
       expect(@session).not_to have_xpath("//p//a[@id='foo']", count: 2)
       expect(@session).not_to have_xpath("//p[contains(.,'est')]", count: 5)
       expect(@session).not_to have_xpath("//p//a[@id='doesnotexist']", count: 1)
     end
   end
 
-  context "with text" do
-    it "should discard all matches where the given string is not contained" do
-      expect(@session).to have_xpath("//p//a", text: "Redirect", count: 1)
-      expect(@session).not_to have_xpath("//p", text: "Doesnotexist")
+  context 'with text' do
+    it 'should discard all matches where the given string is not contained' do
+      expect(@session).to have_xpath('//p//a', text: 'Redirect', count: 1)
+      expect(@session).not_to have_xpath('//p', text: 'Doesnotexist')
     end
 
-    it "should discard all matches where the given regexp is not matched" do
-      expect(@session).to have_xpath("//p//a", text: /re[dab]i/i, count: 1)
-      expect(@session).not_to have_xpath("//p//a", text: /Red$/)
+    it 'should discard all matches where the given regexp is not matched' do
+      expect(@session).to have_xpath('//p//a', text: /re[dab]i/i, count: 1)
+      expect(@session).not_to have_xpath('//p//a', text: /Red$/)
     end
   end
 end
@@ -71,61 +88,62 @@ Capybara::SpecHelper.spec '#has_no_xpath?' do
     @session.visit('/with_html')
   end
 
-  it "should be false if the given selector is on the page" do
-    expect(@session).not_to have_no_xpath("//p")
+  it 'should be false if the given selector is on the page' do
+    expect(@session).not_to have_no_xpath('//p')
     expect(@session).not_to have_no_xpath("//p//a[@id='foo']")
     expect(@session).not_to have_no_xpath("//p[contains(.,'est')]")
   end
 
-  it "should be true if the given selector is not on the page" do
-    expect(@session).to have_no_xpath("//abbr")
+  it 'should be true if the given selector is not on the page' do
+    expect(@session).to have_no_xpath('//abbr')
     expect(@session).to have_no_xpath("//p//a[@id='doesnotexist']")
     expect(@session).to have_no_xpath("//p[contains(.,'thisstringisnotonpage')]")
   end
 
-  it "should use xpath even if default selector is CSS" do
+  it 'should use xpath even if default selector is CSS' do
     Capybara.default_selector = :css
     expect(@session).to have_no_xpath("//p//a[@id='doesnotexist']")
   end
 
-  it "should respect scopes" do
+  it 'should respect scopes' do
     @session.within "//p[@id='first']" do
       expect(@session).not_to have_no_xpath(".//a[@id='foo']")
       expect(@session).to have_no_xpath(".//a[@id='red']")
     end
   end
 
-  it "should wait for content to disappear", requires: [:js] do
+  it 'should wait for content to disappear', requires: [:js] do
+    Capybara.default_max_wait_time = 2
     @session.visit('/with_js')
     @session.click_link('Click me')
     expect(@session).to have_no_xpath("//p[@id='change']")
   end
 
-  context "with count" do
-    it "should be false if the content occurs the given number of times" do
-      expect(@session).not_to have_no_xpath("//p", count: 3)
+  context 'with count' do
+    it 'should be false if the content occurs the given number of times' do
+      expect(@session).not_to have_no_xpath('//p', count: 3)
       expect(@session).not_to have_no_xpath("//p//a[@id='foo']", count: 1)
       expect(@session).not_to have_no_xpath("//p[contains(.,'est')]", count: 1)
       expect(@session).not_to have_no_xpath("//p//a[@id='doesnotexist']", count: 0)
     end
 
-    it "should be true if the content occurs a different number of times than the given" do
-      expect(@session).to have_no_xpath("//p", count: 6)
+    it 'should be true if the content occurs a different number of times than the given' do
+      expect(@session).to have_no_xpath('//p', count: 6)
       expect(@session).to have_no_xpath("//p//a[@id='foo']", count: 2)
       expect(@session).to have_no_xpath("//p[contains(.,'est')]", count: 5)
       expect(@session).to have_no_xpath("//p//a[@id='doesnotexist']", count: 1)
     end
   end
 
-  context "with text" do
-    it "should discard all matches where the given string is contained" do
-      expect(@session).not_to have_no_xpath("//p//a", text: "Redirect", count: 1)
-      expect(@session).to have_no_xpath("//p", text: "Doesnotexist")
+  context 'with text' do
+    it 'should discard all matches where the given string is contained' do
+      expect(@session).not_to have_no_xpath('//p//a', text: 'Redirect', count: 1)
+      expect(@session).to have_no_xpath('//p', text: 'Doesnotexist')
     end
 
-    it "should discard all matches where the given regexp is matched" do
-      expect(@session).not_to have_no_xpath("//p//a", text: /re[dab]i/i, count: 1)
-      expect(@session).to have_no_xpath("//p//a", text: /Red$/)
+    it 'should discard all matches where the given regexp is matched' do
+      expect(@session).not_to have_no_xpath('//p//a', text: /re[dab]i/i, count: 1)
+      expect(@session).to have_no_xpath('//p//a', text: /Red$/)
     end
   end
 end

data/lib/capybara/spec/session/headers_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 Capybara::SpecHelper.spec '#response_headers' do
-  it "should return response headers", requires: [:response_headers] do
+  it 'should return response headers', requires: [:response_headers] do
     @session.visit('/with_simple_html')
     expect(@session.response_headers['Content-Type']).to match %r{text/html}
   end

data/lib/capybara/spec/session/html_spec.rb

@@ -1,39 +1,46 @@
 # frozen_string_literal: true
 
+# NOTE: This file uses `sleep` to sync up parts of the tests. This is only implemented like this
+# because of the methods being tested. In tests using Capybara this type of behavior should be implemented
+# using Capybara provided assertions with builtin waiting behavior.
+
 Capybara::SpecHelper.spec '#html' do
-  it "should return the unmodified page body" do
+  it 'should return the unmodified page body' do
     @session.visit('/')
     expect(@session.html).to include('Hello world!')
   end
 
-  it "should return the current state of the page", requires: [:js] do
+  it 'should return the current state of the page', requires: [:js] do
     @session.visit('/with_js')
+    sleep 1
     expect(@session.html).to include('I changed it')
     expect(@session.html).not_to include('This is text')
   end
 end
 
 Capybara::SpecHelper.spec '#source' do
-  it "should return the unmodified page source" do
+  it 'should return the unmodified page source' do
     @session.visit('/')
     expect(@session.source).to include('Hello world!')
   end
 
-  it "should return the current state of the page", requires: [:js] do
+  it 'should return the current state of the page', requires: [:js] do
     @session.visit('/with_js')
+    sleep 1
     expect(@session.source).to include('I changed it')
     expect(@session.source).not_to include('This is text')
   end
 end
 
 Capybara::SpecHelper.spec '#body' do
-  it "should return the unmodified page source" do
+  it 'should return the unmodified page source' do
     @session.visit('/')
     expect(@session.body).to include('Hello world!')
   end
 
-  it "should return the current state of the page", requires: [:js] do
+  it 'should return the current state of the page', requires: [:js] do
     @session.visit('/with_js')
+    sleep 1
     expect(@session.body).to include('I changed it')
     expect(@session.body).not_to include('This is text')
   end

data/lib/capybara/spec/session/matches_style_spec.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+Capybara::SpecHelper.spec '#matches_style?', requires: [:css] do
+  before do
+    @session.visit('/with_html')
+  end
+
+  it 'should be true if the element has the given style' do
+    expect(@session.find(:css, '#first')).to match_style(display: 'block')
+    expect(@session.find(:css, '#first').matches_style?(display: 'block')).to be true
+    expect(@session.find(:css, '#second')).to match_style('display' => 'inline')
+    expect(@session.find(:css, '#second').matches_style?('display' => 'inline')).to be true
+  end
+
+  it 'should be false if the element does not have the given style' do
+    expect(@session.find(:css, '#first').matches_style?('display' => 'inline')).to be false
+    expect(@session.find(:css, '#second').matches_style?(display: 'block')).to be false
+  end
+
+  it 'allows Regexp for value matching' do
+    expect(@session.find(:css, '#first')).to match_style(display: /^bl/)
+    expect(@session.find(:css, '#first').matches_style?('display' => /^bl/)).to be true
+    expect(@session.find(:css, '#first').matches_style?(display: /^in/)).to be false
+  end
+
+  # rubocop:disable Capybara/MatchStyle
+  it 'deprecated has_style?' do
+    expect { have_style(display: /^bl/) }.to \
+      output(/have_style is deprecated/).to_stderr
+
+    el = @session.find(:css, '#first')
+    allow(Capybara::Helpers).to receive(:warn).and_return(nil)
+    el.has_style?('display' => /^bl/)
+    expect(Capybara::Helpers).to have_received(:warn)
+  end
+  # rubocop:enable Capybara/MatchStyle
+end